[AMDGPU] Form VOPD3 pairs with pair-local literal moves
This PR lets GCNCreateVOPD form a VOPD3 pair when its components use one
distinct non-inline constant. VOPD3 cannot encode literal operands, but src0
can read scalar registers, so we move the value to a free SGPR. If both
components use the same value, one move serves both.
We reject pairs that need two values because two moves add more instructions
than one fusion removes. We also reject functions without tracked liveness and
functions optimized for size.
We use one reverse liveness walk to find an SGPR that is free over each
pair-local range. We exclude reserved registers and VCC. Disjoint selected
pairs can reuse the same SGPR, and each accepted pair adds at most one
S_MOV_B32 for the one instruction removed by fusion.
When overlapping candidates form the same number of pairs, we prefer the set
that needs fewer scalar moves. We keep pair count as the primary objective.
[2 lines not shown]
[NFC][AMDGPU] Separate VOPD candidate selection (#223518)
This PR separates VOPD candidate matching from selection without
changing generated code.
`GCNCreateVOPD` used to choose a pair as soon as `tryMatchVOPDPair`
found one. That made matching and selection one operation: the first
match consumed both instructions before later work could decide whether
the pair was usable.
We now record matches in program order, collect every adjacent
candidate, and select the same greedy non-overlapping set in a separate
step.
This gives later changes a place to reject or rank a candidate without
hiding an overlapping pair that uses its second instruction.
NAS-143145 / 27.0.0-BETA.1 / always trigger smbd service reload on attachment op (#19784)
This commit adds a manual reload of the smb.conf whenever we trigger a
filesystem attachment event for an SMB share. Established SMB sessions
will only check for changes to smb.conf every 180 seconds which can
cause TCON refused messages. This behavior regressed when we
transitioned from the old libzfs python library, which necessitated a
large-scale service / filesystem attachment refactor.
NAS-143860 / 27.0.0-BETA.1 / Restart the S3 service when the license changes (#19781)
The S3 daemon asks truenas.entitlements.check for S3_VERSIONING and
S3_AUDIT once, before it registers a bucket, and holds the answer for
the life of the process. A reload re-reads its files and not the license
-- by design, so every registration-consumed fact arrives the same way,
a restart. Nothing performed that restart: no system.post_license_update
subscriber reached the service, and the license reconcile pass carried
no S3 delegate.
So a revoked versioning entitlement went on minting versions until
someone restarted the service by hand, and -- the direction that reaches
a customer -- a granted one left every object-lock bucket the daemon had
excluded at start answering 503 after the license that would serve it
was installed.
Register a RESTART delegate for the service, ordered after the user
delegate since the credentials file the restart renders resolves every
access key through NSS. It runs only while the service is up: RESTART
starts a stopped unit, which a license change must not do, and a stopped
service reads the license fresh at its next start anyway.
[CIR] Use the LLVM dialect's memory effects attribute
#cir.memory_effects copied #llvm.memory_effects slot for slot, and the
compact printer copied the memory( block of Attribute::getAsString,
diverging from it on target_mem in both directions. Reusing the LLVM
attribute drops both, along with the ModRefInfo enum and the lowering
conversion.
Assisted-by: Cursor / claude-opus-5
ice: Honor iflib transmit completion batching
ice marked every transmitted packet RS and recorded every last
descriptor in its report-status queue. Hardware therefore wrote
descriptor status for every packet, and the driver traversed every
packet while reclaiming completed descriptors.
iflib marks selected packets with IPI_TX_INTR as completion
checkpoints. It forces a checkpoint as deferred work or ring pressure
grows. Retain EOP on every packet, but set RS and record the descriptor
only at those checkpoints.
DPDK uses the same sparse-RS design and defaults tx_rs_thresh to 32.
Let iflib choose the adaptive interval for FreeBSD. This reduces PCIe
and memory traffic while preserving bounded descriptor reclamation.
Validated on an E810-XXV in an A-B-A test with five matched
four-stream, TSO-disabled transmit runs per phase. Median throughput
was 9.413, 9.413, and 9.414 Gbps. Median whole-system CPU was 21.54%,
[11 lines not shown]
Allow scripted frames to implement custom step operations (#223834)
Add an API to the ScriptedFrame interface that gives the ScriptedFrame a
chance to return a scripted ThreadPlan class name for a class that
implements the requested step type.
LLDB will consult the ScriptedFrame (if any) first. If the ScriptedFrame
returns an empty class name, the standard stepping algorithms will be
used, otherwise an instance of the provided class will be constructed -
passing in an optional - ScriptedFrame provided `extra_args` dictionary
- and added to the ThreadPlanStack to handle this step.
ice: Defer RDMA critical error notifications
ice_msix_admin() runs as an interrupt filter inside a critical section.
ice_rdma_notify_pe_intr() acquires the global RDMA sx and invokes the
client event handler, both of which require sleepable thread context. A
PE or HMC critical error could therefore panic under WITNESS or sleep
from interrupt context.
Accumulate OICR causes atomically in the interrupt filter and mark them
pending in the driver state. Deliver the notification from the iflib
admin task before processing reset events. This preserves the existing
ordering, lets an iRDMA-requested reset run in the same admin pass, and
coalesces causes from multiple interrupts.
MFC after: 2 weeks
Sponsored by: BBOX.io
Differential Revision: https://reviews.freebsd.org/D59340
NAS-143880 / 26.0.0 / Add S3 protocol tests under tests/sharing_protocols/s3 (by anodos325) (#19787)
A bucket's stored options are almost all unobservable through the API:
what object_ownership means, what a DENY grant does, whether a
manage_buckets key can create a bucket. Provision through the API,
observe over the protocol.
Assets split in two. The middleware half is assets/s3.py -- accounts,
access keys, buckets, grants, the service -- and imports no client
library, so it stays usable on a runner without one. The client half is
s3_client.py in the test directory rather than tests/protocols/, whose
`__init__` imports every client it re-exports and would make an S3 case
need samba and pynfs to reach boto3.
The session stands up two principals and nine buckets, one per thing
that is only answerable per bucket, and skips rather than proving
something weaker where it could not make one.
Beside the bucket plane: the object surfaces. Metadata and the content
[13 lines not shown]
ping: do a better job with what we received from the net, part 2
When we see a difference between the payload we sent and what we
received, we dump both but we were not prepared for the case when
the received payload is less than we sent. In this case we were trying
to dump more than needed.
Funny enough, 23 years ago I already fixed a similar issue here but
didn't pay attention to this small dumping loop.
Test written by jlduran.
Reviewed by: jlduran
MFC after: 1 month
Found with: Claude Code Sonnet 5
Differential Revision: https://reviews.freebsd.org/D59556
Differential Revision: https://reviews.freebsd.org/D59582
ping: do a better job checking what we receive from the net
- zero out a buffer for the incoming icmp message that
we are about to parse
- for ICMP_MASKREPLY and ICMP_TSTAMPREPLY responses check their length
and warn and reject them if they are truncated
Without these checks a part of stack allocated struct icmp icp could
be printed out which seems low severity since we already dropped root
privileges by the time icp is allocated.
Reviewed by: glebius
MFC after: 1 month
Found with: Claude Code Sonnet 5
Differential Revision: https://reviews.freebsd.org/D59555
iavf: Honor PF-negotiated RSS sizes
Use the key and lookup table lengths returned by GET_VF_RESOURCES when
configuring RSS through virtchnl, as DPDK does. The Windows E835 PF
advertises a 40-byte key and rejects our fixed 52-byte CONFIG_RSS_KEY
request, leaving receive traffic on queue zero.
Validate the negotiated lengths before constructing AdminQ messages and
publish the lookup table size to iflib. Preserve register-mode RSS
selection and its fixed hardware sizes. Use aligned, zero initialized
key storage so an RSS kernel's 40-byte key does not leave an uninitialized
tail when the PF requests 52 bytes.
Validation: normal and RSS enabled iavf module builds passed. On an E835
VF under Hyper-V Server 2025, repeated IPv4 and IPv6 receive tests used all
three configured guest RX queues in both transparent hn and non-transparent
lagg modes. The RSS key rejection disappeared, IPv4 transmit tests passed,
and no TX watchdog fired. Each traffic case used three runs of 16 streams.
[3 lines not shown]
thunderbolt: Account for CRC in router config write message size
Fixes: 9c6e9bfb3474 ("thunderbolt: Support writing to router config space")
Sponsored by: The FreeBSD Foundation
hn: Forward capability changes to transparent VFs
The transparent VF capability handler ignored the requested change and
only copied the VF's enabled capabilities. Forward SIOCSIFCAP to the VF
and return its result. Preserve VF capabilities which hn does not expose.
Limit advertised capabilities to those supported by the transparent
packet path and VLAN relay. Do not inherit VF services such as send tags
or the extended capability ioctl when hn has no corresponding methods.
At handoff, adopt the VF's enabled offloads without reconfiguring it.
Mark the datapath as switching while the VF applies a capability change,
since its ioctl may reinitialize the device. If the association is still
ready and unchanged afterwards, synchronize hn with the actual VF state
even on error and restrict checksum assistance to the forwarded offloads.
Republish link state suppressed during the transition when the VF is
still ready. Refresh VLAN child capabilities after adoption and when
restoring the synthetic path.
[9 lines not shown]
hn: Relay VLAN membership to transparent VFs
VLANs configured on the synthetic interface do not otherwise reach the
accelerating VF's VLAN callbacks. Those callbacks can be needed for
hardware filter membership or for interpreting stripped VLAN tags, even
though no vlan interface is attached directly to the VF.
Subscribe to VLAN events only in transparent mode and schedule the
existing VF task. Snapshot the synthetic interface's VLAN topology under
network epoch, then leave epoch before invoking the VF callbacks, which
may sleep. Do not acquire hn_lock or configure the VF from a VLAN event
handler; the worker applies membership outside the VLAN configuration
lock.
Keep an applied-VID bitmap under hn_lock and relay only changes. Replay
VLANs configured before VF arrival, reconcile changes while acceleration
is active, and preserve membership across temporary datapath switches.
This relays guest intent; it does not configure host access VLAN policy
or overcome PF restrictions on tagged traffic.
[7 lines not shown]
