[analyzer][NFC] BugReporterVisitors.h should include MemRegion.h
BugReporterVisitors.h includes RangedConstraintManager.h but uses
nothing it declares: RangeSet, Range, ConstraintMap and
SimpleConstraintManager appear nowhere in the file. What the header
actually needs is MemRegion.h, which supplies SubRegion,
MemRegionManager and MemRegion completeness for an inline constructor;
today those arrive only by accident, transitively through
RangedConstraintManager.h -> ProgramState.h. Swapping the include for
the one that carries the used declarations makes the dependency honest
and adds a forward declaration of CallEvent in namespace clang::ento
for the one name that only needs to be incomplete.
One header needs a compensating include: Z3CrosscheckVisitor.h uses
ConstraintMap and was getting RangedConstraintManager.h through
BugReporterVisitors.h, so it now includes it directly. No translation
unit in clangStaticAnalyzerCore, clangStaticAnalyzerCheckers or
clangStaticAnalyzerFrontend required any other change.
[3 lines not shown]
[analyzer][NFC] Forward-declare Preprocessor in AnalysisManager.h (#235282)
AnalysisManager.h includes clang/Lex/Preprocessor.h, and through that
one edge the whole Lex subtree -- roughly 34 headers, among them
Basic/Module.h, HeaderSearch.h and ModuleMap.h -- is parsed by 147 of
the 197 translation units in clangStaticAnalyzerCore,
clangStaticAnalyzerCheckers and clangStaticAnalyzerFrontend. The
mechanism is transitive inclusion: AnalysisManager.h sits under almost
every analyzer source, so almost every one of them pays for the
preprocessor without naming it.
Preprocessor is used here only as a reference member, a constructor
parameter and a reference-returning accessor; no member of it is ever
named, so a forward declaration in namespace clang suffices and the
generated code is identical. The include is replaced by
clang/Basic/SourceManager.h rather than simply dropped, because
isInCodeFile() calls SM.isInMainFile(), SM.getIncludeLoc(),
SM.getFileID() and SM.getFilename(), and SourceManager is otherwise
unreachable from this header once Preprocessor.h is gone. That swap is
[20 lines not shown]
net/unifi: append to RUN_DEPENDS in Makefile.inc
Using '=' instead of '+=' for RUN_DEPENDS in Makefile.inc overwrote previously
defined dependencies, i.e., specifically databases/mongodb. Bump REVISION for
main and v9 ports.
OK sthen@
Tools/scripts/rmport: change method to look for PRs
Use the Bugzilla REST interface to look for PRs files against the
port(s) to be deleted as that one still allows anonymous access.
Tools/scripts/rmport: change method to look for PRs
Use the Bugzilla REST interface to look for PRs files against the
port(s) to be deleted as that one still allows anonymous access.
Introduce debug function print_winregs() and clear_winregs().
These debug functions can be used to print out snapshots of the register
window.
The SAVE_WINREGS() macro in locore.s creates the snapshot.
