[Clang][C2y] Make the 'if' declaration extension warning on by default
Declarations in the condition of 'if' and 'switch' statements (N3356)
were previously only diagnosed in pre-C2y modes under -pedantic, since
the C compatibility warnings default to Extension. Promote the
diagnostic to an ExtWarn so users on older language modes are told
they are relying on a C2y extension; -Wno-c2y-extensions silences it.
Co-Authored-By: Claude Fable 5.1 <noreply at anthropic.com>
[Clang][C2y] Simplify condition-declaration diagnostics in C
Key the diagnostics on whether a declaration is permitted as the
condition (only as the sole clause of an 'if' or 'switch'), so the two
"expected expression" emissions collapse into one and the first-clause
check is no longer nested inside the branching. No functional change.
Co-Authored-By: Claude Fable 5.1 <noreply at anthropic.com>
[analyzer] Default to fresh state in addTransitionImpl (#234123)
When `CheckerContext::addTransitionImpl` is called with a null `State`,
it defaulted to using the state of the node that was passed to the
constructor of `CheckerContext` -- even if the parent of the new node
(`P`) was another more recent node.
This logic could have "jumped back" to a slightly older, obsolete state
in the case when the state of `P` was distinct from the state of the
node that was passed to the constructor of `CheckerContext`. I did not
observe this in practice (and I verified that it never happens among the
LIT tests), but it is better to completely rule it out.
Using the state of `P` should be a very safe fallback choice, so I don't
expect disruptions from this change. A checker has to be _very_ buggy if
this change (i.e. _not_ forgetting its state updates) triggered buggy
behavior in it.
[AArch64] Enable quad variant st1b/ld1b for callee-saved spills (#225100)
Currently, only the pair variant is generated by callee-saved spills.
Generate quad variants when:
- 4 consecutive registers (example: z8, z9, z10, z11)
- First register will be divisible by 4. (example: z8)
- Offset will be divisible by 4. (example: 4, mul vl)
- Offset in range -32 to 28
A correction was also made in the expensive checks block, where I
corrected the c.Reg1 == PPR to c.Type == PPR
security/zeek: fix build on powerpc64
The 9.0.0 update dropped the powerpc64 patches from 144863452393. Bring back
the ones still needed: the VSX hash kernel stays off on big-endian (it
computes wrong hashes there) and the bundled fiber library enables its
ppc64 ELFv2 assembly on big-endian too (upstream simonfxr/fiber
dc084920bc81). The hilti stack-direction change is upstream now.
lang/fpc-wasip1-devel: fix build on powerpc64le
fpc only marks a FreeBSD/powerpc64 host as little endian when building
the native compiler. The wasm32 cross compiler misses that, thinks it's
cross-endian and wants llvm-mc. Test the CPU define instead, like the
Linux target does.
net-p2p/pulsar-client-cpp: enable on powerpc64*
-mcrc32 and -mpclmul are x86-only flags; upstream has a software CRC32C
fallback for other architectures.
sysutils/reptyr: enable on powerpc64*
Add the powerpc64 ptrace backend: syscall number in r0, arguments in
r3-r8, PC rewound by one instruction after the stub. Merged upstream
as 59aa0dcb9911.
[clangd] Extract to function: Suppress pure forwarding wrappers (#232654)
Extracting a single statement that's just a lone call (or a return of
one), where every operand that would need to become a parameter is
already exactly that parameter value unchanged, produces nothing but a
renamed call: `foo(x);` becomes `void extracted(int x) { foo(x); }`
called as `extracted(x);`, with no abstraction gained. A value-less
`return;` is the same kind of no-op: there's nothing to abstract over
at all. Both are now rejected.
This is deliberately narrow and per-operand, not a naive argument-count
check: `foo(100)` (a literal), `foo(globalVar)` (an already-visible
global), and `foo(x + y)` (real computation) are all still offered,
since each does something a plain rename wouldn't.
Assisted-by: Claude Code
[Clang][C2y] Fix pre-c2y-compat expectations in c2y-if-decl-while.c
The -std=c2y run line passes -Wpre-c2y-compat, so the compat form of the
'if'/'switch' declaration diagnostic fires. Give that run a 'compat'
prefix and expect the warnings.
Co-Authored-By: Claude Fable 5.1 <noreply at anthropic.com>
[sancov][NFC] Store raw coverage addresses in a DenseSet
Union inserts the same addresses over and over. A std::set walks a tree for every one of them. A hash set checks whether the address is already present in one step. Sort once on output so the bytes stay ordered. On 5,000 llc dumps, union went from 39s to 5s.
Assisted-by: Cursor (Grok 4.7)
[sancov][NFC] Append a coverage file into an existing address set
Union was reading each .sancov file into its own address set and then
inserting that set into the union. Read the file straight into the
caller's set instead. append returns the file header so a bitness
mismatch still warns, and read is implemented on top of it.
Assisted-by: Cursor (Grok 4.7)
[X86] Remove v4i64 S/UMUL_LOHI lowering and consistently rely on MULHS/U (#231976)
Improve the MULH lowering logic - only scalarize if i64 MUL is legal
(i.e. 64-bit target) and vXi64 VPMULLQ isn't, - always for MULHS and
only for MULHU if the operands have other uses.
v8i64 is always better to stay on the FPU as scalarization is so messy,
even if we don't have VPMULLQ.
[MIR] Use block references in callSites and calledGlobals (#229320)
The bb field of callSites and calledGlobals is the number of the block,
as the MIR printer writes it, but the parser used it as the position of
the block in the function. The two differ once a pass adds, removes or
moves blocks without renumbering them, for example after block placement
or when a custom inserter splits a block in finalize-isel. Such MIR then
fails to parse, or an entry is silently attached to the call in another
block.
Make the field a block reference, printed and parsed like the blocks of
jump tables and savePoint, and update the tests that use it.
[AArch64] Preserve exceptions from discarded strict SVE FP operations (#230112)
Mark strict AArch64 target SDNodes as IsStrictFP and advertise FP
exception capability on the SVE FP-unary undef pseudos. Both metadata
properties are needed to preserve observable exception effects when the
numeric result is unused.
Add a regression covering discarded strict f16/f32/f64 round calls with
SVE and streaming SME, selected MIR without nofpexcept, and removable
ignore-mode f32/f64 controls.
Signed-off-by: Sriram Shastry <sriramshastry at gmail.com>
[lldb][OpenBSD] Fix sysctl usage for process info (#122534)
The OpenBSD Host code used FreeBSD-style sysctl MIBs, which don't
match OpenBSD's interface, so process lookups failed.
- GetOpenBSDProcessArgs: use {CTL_KERN, KERN_PROC_ARGS, pid,
KERN_PROC_ARGV}. OpenBSD returns a NULL-terminated argv array
whose pointers point into the returned buffer, so iterate it
directly.
- GetOpenBSDProcessUserAndGroup, FindProcessesImpl: KERN_PROC
takes a 6-element MIB on OpenBSD, with the kinfo_proc element
size and element count as the last two entries.
[sancov][NFC] Store raw coverage addresses in a DenseSet
Union inserts the same addresses over and over. A std::set walks a tree for every one of them. A hash set checks whether the address is already present in one step. Sort once on output so the bytes stay ordered. On 5,000 llc dumps, union went from 39s to 5s.
Assisted-by: Cursor (Grok 4.7)
[sancov][NFC] Append a coverage file into an existing address set
Union was reading each .sancov file into its own address set and then
inserting that set into the union. Read the file straight into the
caller's set instead. append returns the file header so a bitness
mismatch still warns, and read is implemented on top of it.
Assisted-by: Cursor (Grok 4.7)
