FreshBSD

FreeNAS/freenas 1cd8935 — src/middlewared/middlewared/plugins/apps init.py crud.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Minor fixes

Delta		File
+5	-1	src/middlewared/middlewared/plugins/apps/__init__.py
+4	-2	src/middlewared/middlewared/plugins/apps/crud.py
+1	-1	src/middlewared/middlewared/plugins/apps/custom_app_ops.py
+1	-0	src/middlewared/middlewared/plugins/apps/ix_volumes.py
+11	-4	4 files

FreeNAS/freenas 51fb833 — src/middlewared/middlewared/plugins/apps stats.py logs.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Declare event sources in init.py

Delta		File
+2	-10	src/middlewared/middlewared/plugins/apps/stats.py
+1	-9	src/middlewared/middlewared/plugins/apps/logs.py
+6	-0	src/middlewared/middlewared/plugins/apps/__init__.py
+9	-19	3 files

FreeNAS/freenas 8f6f7c5 — src/middlewared/middlewared/plugins/apps logs.py stats.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Make logs/stats as typesafe

Delta		File
+29	-18	src/middlewared/middlewared/plugins/apps/logs.py
+4	-4	src/middlewared/middlewared/plugins/apps/stats.py
+33	-22	2 files

FreeNAS/freenas 9ee3d29 — src/middlewared/middlewared/common/attachment certificate.py, src/middlewared/middlewared/plugins/apps schema_construction_utils.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Make schema_construction_utils typesafe

Delta		File
+60	-38	src/middlewared/middlewared/plugins/apps/schema_construction_utils.py
+8	-1	src/middlewared/middlewared/common/attachment/certificate.py
+68	-39	2 files

FreeNAS/freenas e51ef75 — src/middlewared/middlewared/plugins/apps init.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Mark app service as generic

Delta		File
+1	-0	src/middlewared/middlewared/plugins/apps/__init__.py
+1	-0	1 files

FreeNAS/freenas 614937b — src/middlewared/middlewared/plugins/apps schema_validation.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Convert schema validation to new typesafe pattern

Delta		File
+103	-82	src/middlewared/middlewared/plugins/apps/schema_validation.py
+103	-82	1 files

FreeNAS/freenas 43d762e — src/middlewared/middlewared/plugins/apps upgrade_old.py init.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Complete remove old upgrade.py

Delta		File
+0	-53	src/middlewared/middlewared/plugins/apps/upgrade_old.py
+11	-1	src/middlewared/middlewared/plugins/apps/__init__.py
+5	-0	src/middlewared/middlewared/plugins/apps/upgrade.py
+16	-54	3 files

FreeNAS/freenas af5933c — src/middlewared/middlewared/api/v27_0_0 app.py, src/middlewared/middlewared/plugins/apps app_scale.py init.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Move app_scale methods to be typesafe

Delta		File
+39	-67	src/middlewared/middlewared/plugins/apps/app_scale.py
+40	-0	src/middlewared/middlewared/plugins/apps/__init__.py
+1	-1	src/middlewared/middlewared/api/v27_0_0/app.py
+1	-1	src/middlewared/middlewared/plugins/apps/crud.py
+81	-69	4 files

FreeNAS/freenas ff819d2 — src/middlewared/middlewared/plugins/apps crud.py crud_old.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Add query/get_instance impl

Delta		File
+91	-6	src/middlewared/middlewared/plugins/apps/crud.py
+0	-55	src/middlewared/middlewared/plugins/apps/crud_old.py
+48	-7	src/middlewared/middlewared/plugins/apps/__init__.py
+139	-68	3 files

FreeNAS/freenas 88b266d — src/middlewared/middlewared/plugins/apps crud.py init.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Barebones crud.py

Delta		File
+14	-0	src/middlewared/middlewared/plugins/apps/crud.py
+3	-0	src/middlewared/middlewared/plugins/apps/__init__.py
+17	-0	2 files

FreeNAS/freenas 71447bc — src/middlewared/middlewared/plugins/apps crud.py crud_old.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Rename crud file

Delta		File
+0	-371	src/middlewared/middlewared/plugins/apps/crud.py
+371	-0	src/middlewared/middlewared/plugins/apps/crud_old.py
+371	-371	2 files

FreeNAS/freenas 973ff1f — src/middlewared/middlewared/api/v27_0_0 app.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Fix integration tests

Delta		File
+7	-7	src/middlewared/middlewared/api/v27_0_0/app.py
+7	-7	1 files

FreeNAS/freenas 0f48bbd — src/middlewared/middlewared/apps webshell_app.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

More fixes

Delta		File
+4	-3	src/middlewared/middlewared/apps/webshell_app.py
+4	-3	1 files

FreeNAS/freenas 035a074 — src/middlewared/middlewared/plugins/apps crud.py available_apps_info.py, src/middlewared/middlewared/plugins/zfs_ utils.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Mypy fixes

Delta		File
+18	-9	src/middlewared/middlewared/plugins/apps/crud.py
+21	-5	src/middlewared/middlewared/plugins/apps/available_apps_info.py
+8	-5	src/middlewared/middlewared/plugins/apps/resources.py
+2	-6	src/middlewared/middlewared/plugins/apps/schema_validation.py
+5	-1	src/middlewared/middlewared/plugins/apps/schema_action_context.py
+1	-1	src/middlewared/middlewared/plugins/zfs_/utils.py
+55	-27	2 files not shown
+57	-28	8 files

FreeNAS/freenas a30f77a — src/middlewared/middlewared/plugins/apps schema_normalization_old.py crud.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Remove usages of old schema normalization

Delta		File
+0	-46	src/middlewared/middlewared/plugins/apps/schema_normalization_old.py
+9	-11	src/middlewared/middlewared/plugins/apps/crud.py
+6	-7	src/middlewared/middlewared/plugins/apps/rollback.py
+6	-7	src/middlewared/middlewared/plugins/apps/upgrade.py
+2	-2	src/middlewared/middlewared/plugins/apps/app_scale.py
+23	-73	5 files

FreeNAS/freenas ff62cc0 — src/middlewared/middlewared/plugins/apps schema_action_context.py schema_normalization.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Convert app.schema.actions to be typesafe

Delta		File
+35	-39	src/middlewared/middlewared/plugins/apps/schema_action_context.py
+5	-1	src/middlewared/middlewared/plugins/apps/schema_normalization.py
+40	-40	2 files

FreeNAS/freenas 5589aad — src/middlewared/middlewared/api/v27_0_0 app.py, src/middlewared/middlewared/plugins/apps crud_old.py crud.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Complete crud methods to be typeafe

Delta		File
+0	-233	src/middlewared/middlewared/plugins/apps/crud_old.py
+184	-4	src/middlewared/middlewared/plugins/apps/crud.py
+57	-2	src/middlewared/middlewared/plugins/apps/__init__.py
+8	-4	src/middlewared/middlewared/api/v27_0_0/app.py
+249	-243	4 files

FreeNAS/freenas 3fd111b — src/middlewared/middlewared/plugins/apps resources.py upgrade.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Make get_app_volume_ds typesafe

Delta		File
+14	-1	src/middlewared/middlewared/plugins/apps/resources.py
+2	-2	src/middlewared/middlewared/plugins/apps/upgrade.py
+2	-1	src/middlewared/middlewared/plugins/apps/rollback.py
+18	-4	3 files

FreeNAS/freenas 2e490fc — src/middlewared/middlewared main.py, src/middlewared/middlewared/plugins/apps metadata.py init.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Convert metadata to typesafe impl

Delta		File
+22	-24	src/middlewared/middlewared/plugins/apps/metadata.py
+6	-0	src/middlewared/middlewared/plugins/apps/__init__.py
+1	-2	src/middlewared/middlewared/plugins/apps/custom_app_ops.py
+1	-1	src/middlewared/middlewared/plugins/docker/restore_backup.py
+2	-0	src/middlewared/middlewared/main.py
+1	-1	src/middlewared/middlewared/plugins/apps/rollback.py
+33	-28	2 files not shown
+35	-30	8 files

FreeNAS/freenas d4e427d — src/middlewared/middlewared/plugins/apps ix_volumes.py ix_volumes_crud.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Convert ix_volume service to typesafe

Delta		File
+60	-40	src/middlewared/middlewared/plugins/apps/ix_volumes.py
+74	-0	src/middlewared/middlewared/plugins/apps/ix_volumes_crud.py
+2	-0	src/middlewared/middlewared/plugins/apps/__init__.py
+136	-40	3 files

FreeNAS/freenas b7dd333 — src/middlewared/middlewared/plugins/apps utils.py fs_attachments.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Make various app related util files typesafe

Delta		File
+22	-19	src/middlewared/middlewared/plugins/apps/utils.py
+16	-7	src/middlewared/middlewared/plugins/apps/fs_attachments.py
+14	-6	src/middlewared/middlewared/plugins/apps/cert_attachments.py
+12	-5	src/middlewared/middlewared/plugins/apps/port_attachments.py
+10	-5	src/middlewared/middlewared/plugins/apps/resources_utils.py
+7	-4	src/middlewared/middlewared/plugins/apps/pydantic_utils.py
+81	-46	5 files not shown
+101	-54	11 files

FreeNAS/freenas 56743d7 — src/middlewared/middlewared/plugins/apps available_apps_info.py init.py, src/middlewared/middlewared/plugins/catalog apps.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Complete removing app service from catalog/

Delta		File
+0	-101	src/middlewared/middlewared/plugins/catalog/apps.py
+71	-2	src/middlewared/middlewared/plugins/apps/available_apps_info.py
+39	-1	src/middlewared/middlewared/plugins/apps/__init__.py
+110	-104	3 files

FreeNAS/freenas 2120cc5 — src/middlewared/middlewared/plugins/apps available_apps_info.py crud.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Initial pass at moving app related endpoitns from catalog plugin

Delta		File
+43	-0	src/middlewared/middlewared/plugins/apps/available_apps_info.py
+4	-12	src/middlewared/middlewared/plugins/apps/crud.py
+15	-0	src/middlewared/middlewared/plugins/apps/utils.py
+62	-12	3 files

FreeNAS/freenas 9fd125f — src/middlewared/middlewared/plugins/apps crud.py init.py, src/middlewared/middlewared/service crud_service.py base.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Fix serialization of app.query

Delta		File
+3	-2	src/middlewared/middlewared/plugins/apps/crud.py
+2	-2	src/middlewared/middlewared/plugins/apps/__init__.py
+1	-1	src/middlewared/middlewared/service/crud_service.py
+2	-0	src/middlewared/middlewared/service/base.py
+8	-5	4 files

FreeNAS/freenas 3a5c094 — src/middlewared/middlewared/plugins/apps init.py, src/middlewared/middlewared/pytest/unit/api/base test_decorator.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Allow filterable api method to pass check annotations

Delta		File
+14	-0	src/middlewared/middlewared/pytest/unit/api/base/test_decorator.py
+7	-3	src/middlewared/middlewared/plugins/apps/__init__.py
+9	-0	src/middlewared/middlewared/pytest/unit/api/handler/accept/test_accept_1.py
+2	-0	src/middlewared/middlewared/service/decorators.py
+32	-3	4 files

FreeNAS/freenas 47ad49d — src/middlewared/middlewared/pytest/unit/plugins/apps test_normalize_questions.py test_upgrade_values.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

More fixes

Delta		File
+38	-32	src/middlewared/middlewared/pytest/unit/plugins/apps/test_normalize_questions.py
+9	-19	src/middlewared/middlewared/pytest/unit/plugins/apps/test_upgrade_values.py
+7	-16	src/middlewared/middlewared/pytest/unit/plugins/apps/test_normalize_and_validate.py
+12	-10	src/middlewared/middlewared/pytest/unit/plugins/apps/test_normalize_ix_volumes.py
+10	-8	src/middlewared/middlewared/pytest/unit/plugins/apps/test_normalize_acl.py
+10	-7	src/middlewared/middlewared/pytest/unit/plugins/apps/test_normalize_values.py
+86	-92	10 files not shown
+118	-117	16 files

FreeNAS/freenas 500f9bb — src/middlewared/middlewared/api/v27_0_0 app.py, src/middlewared/middlewared/plugins/apps upgrade.py upgrade_old.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Add initial code to covert upgrade.py

Delta		File
+250	-340	src/middlewared/middlewared/plugins/apps/upgrade.py
+146	-0	src/middlewared/middlewared/plugins/apps/upgrade_old.py
+20	-0	src/middlewared/middlewared/plugins/apps/__init__.py
+6	-6	src/middlewared/middlewared/api/v27_0_0/app.py
+1	-1	src/middlewared/middlewared/pytest/unit/plugins/apps/test_upgrade_values.py
+423	-347	5 files

FreeNAS/freenas 9d6b90e — src/middlewared/middlewared/plugins/apps resources.py resources_old.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Convert resources.py to typesafe imple

Delta		File
+0	-134	src/middlewared/middlewared/plugins/apps/resources.py
+134	-0	src/middlewared/middlewared/plugins/apps/resources_old.py
+134	-134	2 files

FreeNAS/freenas 0e9add0 — src/middlewared/middlewared/plugins/apps/ix_apps metadata.py lifecycle.py, src/middlewared/middlewared/plugins/apps/ix_apps/docker stats.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Address reviews

Delta		File
+22	-3	src/middlewared/middlewared/utils/yaml.py
+3	-8	src/middlewared/middlewared/plugins/apps/ix_apps/metadata.py
+1	-4	src/middlewared/middlewared/plugins/apps/ix_apps/lifecycle.py
+1	-1	src/middlewared/middlewared/plugins/apps/ix_apps/docker/stats.py
+27	-16	4 files

FreeNAS/freenas c31bcd6 — src/middlewared/middlewared/plugins/apps available_apps_info.py

2026-04-22 06:26:34 UTC by Waqar Ahmed on ⎇

apps-typesafe

Fix app.latest/app.available models mismatch

Delta		File
+15	-10	src/middlewared/middlewared/plugins/apps/available_apps_info.py
+15	-10	1 files