[flang][OpenACC] Generalize cross-region GOTO exit handling for all ACC region ops (#187613)
When a `GoTo` inside an ACC region (`acc.loop`, `acc.data`,
`acc.parallel`, etc.) targets a label outside that region, the lowering
generated an illegal cross-region `cf.br`. This caused MLIR verification
failures or stack overflows in `runRegionDCE`'s recursive
`propagateLiveness`.
This patch addresses the issue with a generalized approach:
- Add `genOpenACCRegionExitBranch` helper that detects cross-region
branches from any ACC region op and generates the appropriate terminator
(`acc.yield` for compute/loop ops, `acc.terminator` for data ops). The
helper verifies that `parentOp` is an ACC operation, so it does not
interfere with branches inside `scf.execute_region` or other non-ACC
regions.
- In `genBranch`, when a cross-region exit from an ACC region is
detected, store a unique exit ID into a selector variable and generate
the region terminator. After the ACC op, a jump table dispatches to the
[7 lines not shown]
[flang][DoConcurrent] Map reduction variables as tofrom ByRef for device offloading
Scalar reduction variables in `do concurrent reduce(...)` were being
mapped with `implicit ByCopy` when offloaded to device, because
`genMapInfoOpForLiveIn` treated all trivial types uniformly. This caused
the reduction result to be silently dropped — the device-side reduction
would compute the correct value but never write it back to the host.
Fix by detecting reduction variables and forcing `implicit tofrom ByRef`
mapping, matching the behavior of explicit
`!$omp target teams distribute parallel do reduction(...)`.
Co-authored-by: ergawy <kareem.ergawy at amd.com>
Co-authored-by: Claude <noreply at anthropic.com>
Made-with: Cursor
[lld][COFF] Restore `lto-embed-bitcode` and `-fembed-bitcode` Bitcode Embedding Features (#188398)
Removes the patches introduced by #150897 which broke LTO embed
documented features for creating whole-program-bitcode representations
of executables, used in production analysis/rewriting toolsets. This was
a documented feature available up until 21.1.8 broken by 22.x release.
This previously allowed the users to have a whole-program-bitcode
section `.llvmbc` embedded inside of the final executable.
audio/spotify-player: update to 0.23.0
Highlight of this release is the new optional real-time audio visualisation (thanks @Narqulie for the implementation)
What's Changed
- docs: fix broken relative links in README for crates.io compatibility by @greqor in #926
- fix: bind CLI socket before spawning handler thread by @greqor in #929
- Add doc for component styles and improve wording for other docs by @aome510 in #932
- feat: add mouse scroll to incease/decrease volume by @Alimedhat000 in #931
- feat: remember Tracks context in Currently Playing page by @aome510 in #933
- refactor: consolidate client requests and move currently_playing_tracks_id to PlayerState by @aome510 in #939
- docs: add THEMES.md to showcase community theme collections by @MBeggiato in #938
- Feat: Adding real-time audio visualisation by @Narqulie in #943
- Fix: Artist Page "Albums" and "Related Artists" shown even on small windows by @wzifox in #945
- fix: include seed track when using GoToRadio by @anspangilinan in #947
- Loading spinner on startup by @mielpeeters in #950
[mlir][memref] Fix invalid folds in ReinterpretCastOpConstantFolder for negative constants (#189237)
`ReinterpretCastOpConstantFolder` could fold `memref.reinterpret_cast`
ops whose offset or sizes contain negative constants (e.g. `-1 :
index`).
- A negative constant size passed into `ReinterpretCastOp::create`
reaches
`MemRefType::get`, which asserts that all static dimension sizes are
non-negative, causing a crash.
- A negative constant offset produces an op with a static negative
offset,
which the `ViewLikeInterface` verifier then rejects ("expected offsets
to
be non-negative").
Fix by skipping the fold when any constant size or the offset is
negative.
[7 lines not shown]
libz: Override z_off_t to 'long' to fix bootloader linking
zlib v1.3.2 changed 'z_off_t' from 'long' to 'long long', which is
always 64bit even on i386. As a result, the built libstand32.a
depended on libgcc to provide 64-bit operations, e.g., '__moddi3', and
thus the bootloader failed to link with errors like:
```
/usr/obj/home/jenkins/workspace/DragonFlyBSD/ctools_x86_64_x86_64/usr/libexec/binutils234/elf/ld.bfd: /usr/obj/home/jenkins/workspace/DragonFlyBSD/world_x86_64/home/jenkins/workspace/DragonFlyBSD/stand/boot/pc32/loader/../../libstand32/libstand32.a(adler32.o): in function `adler32_combine_':
adler32.c:(.text+0x22): undefined reference to `__moddi3'
collect2: error: ld returned 1 exit status
```
Fix this problem by overriding 'z_off_t' to 'long' for libstand32.
clang: Return Triple from OffloadArchToTriple instead of a string (#189343)
Also stop bothering to call normalizeOffloadTriple. This was
produced by code which should always produce normalized triples.
clang: Fix warnings with multiple offload arch args (#189329)
Fix regression after ab885fdf5f67726ef564c34087e813f2ca861f5c.
Apparently driver tests do not enforce there are no warnings.
Oddly, I need to use -Werror for the specific error. If I use
just -Werror, I get an error that the -Werror is unused.
update to vim-9.2.272
adapt flavour changes as done in vim-classic (rather than have a no_x11
flavour, the default is now no_x11; in this case, to cope with updates
from old versions, @pkgpath is built dynamically and passed via a var
to PLIST). reduce other differences to vim-classic makefile.
[VPlan] Handle regions with live-outs and scalar VF when replicating. (#186252)
Extend intial unrolling of replicate regions
(https://github.com/llvm/llvm-project/pull/170212) to support live-outs,
if the VF is scalar.
This allows adding the logic needed to explicitly unroll, and replacing
VPPredPhiInsts with regular scalar VPPhi, without yet having to worry
about packing values into vector phis. This will be done in a follow-up
change, which means all replicate regions will be fully dissolved.
PR: https://github.com/llvm/llvm-project/pull/186252
use DEBUG_PACKAGES to provide debug-* packages on supported archs,
otherwise explicitly strip the binaries. with 3.11, there are now
statically-linked copies of openssl libraries in many more binaries
than in 3.10, resulting in a big size increase. size increase noticed
by danj@, ok danj tb brad
[InstCombine] Fold cmp of select-of-constants via truth table (#186591)
This patch adds a generic InstCombine fold for:
cmp pred (select C1, TV1, FV1), (select C2, TV2, FV2)
when all select arms are constants and the comparison can be
constant-folded for all four combinations of C1/C2. The fold computes a
4-entry truth table and synthesizes a boolean expression using
createLogicFromTable.
This generalizes patterns like:
fcmp une (select C1, -1.0, 1.0), (select C2, -1.0, 1.0) -> xor C1, C2
The transform bails out for mixed vector results like:
<i1 true, i1 false>
alive2: https://alive2.llvm.org/ce/z/JQ_Poy
Fixes #186558
