PKCS#12: fix erroneous error check in PKCS12_newpass()
This is an error I introduced in a refactoring two years ago in r1.20.
This means that nothing uses this...
From Frank Denis via logan
bob: Update to 0.99.5.
* Sandbox setup actions and per-package pre/post-build hook `cmd` actions no
longer have any environment applied to them. This allows setting variables
such as `LD_PRELOAD`, which otherwise would be applied directly to the chroot
command and likely lead to failures in the host environment. This is a
breaking change, but is hopefully clearer overall and less surprising for the
common cases.
* Ensure all `bob dev` sandbox commands use `environment.dev` rather than
`environment.build`.
* `bob log <pkg>` falls back to `setup.log` when no failed stage was recorded,
so that failures that happen before any pkgsrc stage runs work as expected.
* Improve error handling and output formatting for pre-build and post-build
scripts and hooks, as well as ensuring that the failure reasons are correctly
propagated to build status results.
[4 lines not shown]
[CI] Ignore TidyFastChecks.inc for formatter CI. NFC. (#196682)
`TidyFastChecks.inc` is generated and its contents should not be checked
by clang-format CI workflow. Add a local `.clang-format-ignore` entry so
the PR formatting check does not report diffs for this file.
Related run:
https://github.com/llvm/llvm-project/pull/194516#issuecomment-4332061836
[clang-tidy] Avoid `use-nodiscard` false positives for class templates (#196661)
Do not suggest adding `[[nodiscard]]` to functions returning a class
template specialization whose primary template is already marked
`[[nodiscard]]`.
Class template specializations do not carry the `[[nodiscard]]`
attribute on their own declarations, so `modernize-use-nodiscard`
previously missed this case and emitted redundant diagnostics for return
types such as:
```cpp
template <class T>
struct [[nodiscard]] Result;
Result<int> f() const;
```
Fixes #163425.
pci: use uint32_t for eecp
eecp holds the extended capability offset. If that offset is larger
than 0xff, storing it in uint8_t truncates it, which can make the
early EHCI/XHCI capability walk read the wrong location and loop during
boot.
Seen on AMD device 1022:151e, where HCCPARAMS1 = 0x0118ffc5 and the
first xHCI extended capability offset is 0x460. Widen eecp to uint32_t
in xhci_early_takeover(), matching xhci_pci_take_controller().
Signed-off-by: Gisle Nes <gisle at gisle.net>
Reviewed by: zlei, aokblast
MFC after: 3 days
Pull Request: https://github.com/freebsd/freebsd-src/pull/2127
Closes: https://github.com/freebsd/freebsd-src/pull/2127
BSD.root.dist: Correct tag for /etc/sysctl.kld.d
This is only used by rc.subr and belongs in rc, not runtime.
Fixes: fa6d67cd16b5 ("BSD.root.dist: Add package tag for all directories")
MFC after: 3 days
Reviewed by: ivy
Differential Revision: https://reviews.freebsd.org/D56900
[ObjectYAML][NFC] Extract BBAddrMap YAML types into shared namespace (#196019)
Move BBAddrMapEntry and PGOAnalysisMapEntry out of namespace ELFYAML
into a new format-agnostic namespace BBAddrMapYAML so that COFF
YAML support can reuse the same schema and MappingTraits.
[AArch64][NFC] Remove unused TRI member from class (#184363)
I’ve removed the TRI member and its initialization, leaving only MRI and
TII as the stored pointers.
---------
Co-authored-by: Benjamin Maxwell <benjamin.maxwell at arm.com>
Release parked async LUN-replace cleanup after DLM peer eviction
scst.async_lun_replace=1 now also tells the kernel to park the deferred
cleanup of old tgt_devs from each LUN replace until the flag is cleared.
This avoids stalling become_active on scst_dlm_lock_wait inside
scst_clear_reservation while the dead peer is still a DLM lockspace
member.
Add iscsi.scst.disable_async_lun_replace and call it from the end of
iscsi.alua.reset_active, after dlm.reset_active (which evicts the peer)
completes.
