[libc++] Remove workaround for Clang < 20 in clang-tidy plugin (#211314)
The clang-tidy plugin is now always built with Clang >= 20, so the
workaround can be removed.
[AArch64] Add a ctpop cost with CSSC (#211189)
FEAT_CSSC adds a CNT instruction that can perform ctpop. This adds a
specific cost for it to prevent us from using the neon cost.
NAS-141874 / 26.0.0-BETA.3 / webshell: fix sessions hanging with a blank terminal (by anodos325) (#19386)
login(1) hangs up and reopens its tty at session start, so reads on
the pty master transiently fail with EIO. The reader thread treated
any read error as fatal and exited silently: the UI showed
"connected" but the terminal stayed blank while the shell kept
running with nobody forwarding its output. Treat EIO as fatal only
when the shell child is gone (50ms retry, 5s cap).
Also harden the worker teardown:
- abort() closed master_fd while the reader/writer threads still
used the fd number; it now only signals and kills the child, and
run() reaps, joins, then closes under try/finally.
- terminate_pid(use_pgid=True) before the child's setsid() resolved
to middlewared's own process group and could kill the daemon;
signal the pid directly when the group is the caller's own.
- Bound every teardown wait: WNOHANG reap (D-state child), 600s
websocket send (stalled client). Catch BaseException so thread
death is never silent; clear shell_pid once reaped.
[6 lines not shown]
NAS-141874 / 26.0.0-RC.1 / webshell: fix sessions hanging with a blank terminal (by anodos325) (#19387)
login(1) hangs up and reopens its tty at session start, so reads on
the pty master transiently fail with EIO. The reader thread treated
any read error as fatal and exited silently: the UI showed
"connected" but the terminal stayed blank while the shell kept
running with nobody forwarding its output. Treat EIO as fatal only
when the shell child is gone (50ms retry, 5s cap).
Also harden the worker teardown:
- abort() closed master_fd while the reader/writer threads still
used the fd number; it now only signals and kills the child, and
run() reaps, joins, then closes under try/finally.
- terminate_pid(use_pgid=True) before the child's setsid() resolved
to middlewared's own process group and could kill the daemon;
signal the pid directly when the group is the caller's own.
- Bound every teardown wait: WNOHANG reap (D-state child), 600s
websocket send (stalled client). Catch BaseException so thread
death is never silent; clear shell_pid once reaped.
[6 lines not shown]
Bump timeout slightly
We use 60 second timeouts in various other places and an extra
30 seconds to catch a wedged client isn't onerous.
(cherry picked from commit f4ed4c8ff1eb0a58d8eb144cef55d1e2e9d2687c)
webshell: fix sessions hanging with a blank terminal
login(1) hangs up and reopens its tty at session start, so reads on
the pty master transiently fail with EIO. The reader thread treated
any read error as fatal and exited silently: the UI showed
"connected" but the terminal stayed blank while the shell kept
running with nobody forwarding its output. Treat EIO as fatal only
when the shell child is gone (50ms retry, 5s cap).
Also harden the worker teardown:
- abort() closed master_fd while the reader/writer threads still
used the fd number; it now only signals and kills the child, and
run() reaps, joins, then closes under try/finally.
- terminate_pid(use_pgid=True) before the child's setsid() resolved
to middlewared's own process group and could kill the daemon;
signal the pid directly when the group is the caller's own.
- Bound every teardown wait: WNOHANG reap (D-state child), 30s
websocket send (stalled client). Catch BaseException so thread
[4 lines not shown]
Bump timeout slightly
We use 60 second timeouts in various other places and an extra
30 seconds to catch a wedged client isn't onerous.
(cherry picked from commit f4ed4c8ff1eb0a58d8eb144cef55d1e2e9d2687c)
webshell: fix sessions hanging with a blank terminal
login(1) hangs up and reopens its tty at session start, so reads on
the pty master transiently fail with EIO. The reader thread treated
any read error as fatal and exited silently: the UI showed
"connected" but the terminal stayed blank while the shell kept
running with nobody forwarding its output. Treat EIO as fatal only
when the shell child is gone (50ms retry, 5s cap).
Also harden the worker teardown:
- abort() closed master_fd while the reader/writer threads still
used the fd number; it now only signals and kills the child, and
run() reaps, joins, then closes under try/finally.
- terminate_pid(use_pgid=True) before the child's setsid() resolved
to middlewared's own process group and could kill the daemon;
signal the pid directly when the group is the caller's own.
- Bound every teardown wait: WNOHANG reap (D-state child), 30s
websocket send (stalled client). Catch BaseException so thread
[4 lines not shown]
NAS-141874 / 27.0.0-BETA.1 / webshell: fix sessions hanging with a blank terminal (#19382)
login(1) hangs up and reopens its tty at session start, so reads on
the pty master transiently fail with EIO. The reader thread treated
any read error as fatal and exited silently: the UI showed
"connected" but the terminal stayed blank while the shell kept
running with nobody forwarding its output. Treat EIO as fatal only
when the shell child is gone (50ms retry, 5s cap).
Also harden the worker teardown:
- abort() closed master_fd while the reader/writer threads still
used the fd number; it now only signals and kills the child, and
run() reaps, joins, then closes under try/finally.
- terminate_pid(use_pgid=True) before the child's setsid() resolved
to middlewared's own process group and could kill the daemon;
signal the pid directly when the group is the caller's own.
- Bound every teardown wait: WNOHANG reap (D-state child), 600s
websocket send (stalled client). Catch BaseException so thread
death is never silent; clear shell_pid once reaped.
- Add a host shell I/O regression test.
[lldb-dap] Migrate DAP attach tests. (#210814)
Address some issues with the previous tests.
- Always wait for the continued event after sending a continue request.
since the continue response is just an acknowlegement that we send a
continue packet.
- Retry reading stdin if it has an error when the debugger attaches.
- Update and enable the attachByPortNum test, this may now run on NetBSD
and Windows. will try to enable in a different PR.
[TLI] Add x86 libmvec mappings for GLIBC 2.35 vector functions (#206274)
## Summary
glibc 2.35 extended x86_64 libmvec with vector implementations of `erf`,
`erfc`,
`cbrt`, `expm1`, `log1p`, `asinh`, `acosh` and `atanh` (among others),
but LLVM's
`LIBMVEC_X86` table in `VecFuncs.def` was never updated past the
original glibc-2.22
set. As a result `clang -fveclib=libmvec` cannot vectorize loops over
these functions
on x86_64, even though the vector symbols are present in the linked
`libmvec.so`. The
AArch64 libmvec table already maps several of them.
This patch adds the x86 mappings for the 8 GLIBC-2.35 functions that
have **no
corresponding LLVM intrinsic** (pure named/TLI mappings). The
[48 lines not shown]
[llubi][NFC] Use context-aware value printer (#211275)
As discussed in
https://github.com/llvm/llvm-project/pull/200672#discussion_r3624927046,
we need information from the global state to provide a better debugging
representation of byte SSA values.
This patch adds a wrapper to pass `Context&` into the actual printer.
NAS-141891 / 27.0.0-BETA.1 / Account and group integration tests (#19370)
84% of `account.py` is now covered with integration tests (some of the
DS tests might cover the rest)
[Clang][X86] Introduce Clang ABI Gate for MSVC alignment (#210305)
On x86_64-windows-msvc after 8ecec455183f, clang applies the MSVC
size-based global-alignment scheme (Microsoft64BitMinGlobalAlign) and
does not apply the Sys V "large array" alignment increase. Users may
want to preserve the earlier ABI for compatibility with objects produced
by older clang releases.
Gate this behavior on the Clang ABI compatibility level. When
`-fclang-abi-compat=22` (or lower) is in effect,
MicrosoftX86_64TargetInfo restores LargeArrayMinWidth/LargeArrayAlign to
128 and getMinGlobalAlign skips the Microsoft64BitMinGlobalAlign step,
matching the older alignment choices.
Assisted by Claude (Anthropic).
