[AArch64] Load CC-widened vector stack arguments as their value type (#237946)
A CC-widened vector argument (<N x i1>, odd Lane counts like <3 x i32>)
passed on the stack was loaded as its bitconverted LocVT instead of the
CC value type, producing a part of the wrong type for getCopyFromParts –
a crash or silently wrong values, on either end for <3 x float>. Load
the value type instead; the memory image is the same either way.
Fixes #237850
[CHR] Don't attempt to fixup selects we can't handle (#236454)
CHR attempts to merge selects with integer and vector typed condition
without type verification, which triggers assertion in some LTO + PGO
builds.
[flang] Keep switch successor operand counts in sync (#234126)
FIR switch operations fail to update target_operand_offsets when
successor operands are added or removed through MutableOperandRange.
Declare the attribute in ODS so it can be updated by setInherentAttr,
which MutableOperandRange has used since ad9dc60252ed (#218907).
Add regression tests for operand insertion and removal.
[LifetimeSafety] Analyze blocks that cannot reach the exit in liveness (#240890)
The backward liveness analysis was seeded only at the exit block, so
blocks that cannot reach it, e.g., the body of an infinite loop, were
never analyzed and uses in them were missed.
Fixes #222273
Assisted-by: Claude Opus 5.5
Co-authored-by: Gabor Horvath <gaborh at apple.com>
[mlir][vector] Don't drop out-of-bounds leading unit dims of transfers (#239699)
`CastAwayTransferReadLeadingOneDim` and
`CastAwayTransferWriteLeadingOneDim` drop the leading unit dims of a
transfer and keep `in_bounds` only for the remaining dims. A dropped dim
becomes a non-vector dim, and those must always be in bounds, so an
out-of-bounds leading unit dim was lost:
```mlir
%r = vector.transfer_read %A[%i, %j], %pad {in_bounds = [false, true]} : memref<?x?xf32>, vector<1x4xf32>
```
became
```mlir
%0 = vector.transfer_read %A[%i, %j], %pad {in_bounds = [true]} : memref<?x?xf32>, vector<4xf32>
%r = vector.broadcast %0 : vector<4xf32> to vector<1x4xf32>
```
[5 lines not shown]
[libc++][pstl] Added tests for corner cases of calling __apply() (#240398)
Add a couple of tests that check non-trivial usage of
`__apply()`, which is not currently covered by any of "conventional"
PSTL tests. Any parallelism provider behind `__apply()` must allow for
these tests to pass, so that the overall PSTL offering is sound.
Added tests include:
- Calling `__apply` before the `main` function has started.
- Calling `__apply` after the `main` function has finished.
- Calling `__apply` concurrently from multiple threads.
- Calling `__apply` recursively and fanning out, nesting up to three
levels.
- Calling `__apply` recursively, nesting up to ten levels.
- Calling `__apply` recursively while holding a mutex.
20 years ago when the 1-Wire infrastructure was ported over from
OpenBSD, the calls in the onewire_detach() function in the onewirebus
(sys/dev/onewire/onewire.c) code for config_detach_children() was
commented out. I don't know why this was done, exactly, as there
wasn't any particular comments present. I suspect it might have been
because owtemp, the common end device, could not detach or maybe
detaching just didn't work as expected at that time.
The string of devices are as follows:
End controller -> onewirebus -> End device
gpioow or ds2482ow -> -> such as owtemp or ds24e17iic
If the onewirebus does not call config_detach_children(), the end
devices will end up orphened and not detach if the controller is
unloaded, such as with modunload. In a DIAGNOSTIC kernel, you will
panic with a complaint about the end device still being present.
[6 lines not shown]
[libc][stdfix] Implement expuhk and expuk functions (#240631)
Implement `expuhk` and `expuk` functions with unit tests.
```c
unsigned short accum expuhk(unsigned short accum);
unsigned accum expuk(unsigned accum);
```
[MLIR][Vector] Fix ShapeCastBroadcastFolder when shape_cast changes non-unit dim strides (#227574)
### Summary
`ShapeCastBroadcastFolder` previously checked whether
`vector.shape_cast(vector.broadcast)` could be folded into a single
`vector.broadcast` by comparing the scalar product of stretched unit
dimensions (`getBroadcastStretchingFactor`).
However, a single scalar product is insufficient when `srcShape` has
multiple unit dimensions across different sides of a non-unit dimension,
and the `shape_cast` shifts the broadcast factor from an inner unit
dimension to an outer unit dimension.
For example:
```mlir
%0 = vector.broadcast %arg0 : vector<1x4x1xf32> to vector<1x4x4xf32>
%1 = vector.shape_cast %0 : vector<1x4x4xf32> to vector<4x4x1xf32>
```
[26 lines not shown]
[clang-tidy] Fix false negative for binary logical expressions for tw… (#230846)
Fixes #230601
This PR addresses the false-negative scenario where
`bugprone-redundant-branch-condition` fails to trigger on simple
two-variable logical conjunction expressions (e.g., `if (x && y) { if
(y) ... }`).
Note: This is a partial fix. As noted in the code's `// FIXME` comments,
handling longer conjunctive and disjunctive chain clauses (3 or more
variables) requires further extension is not yet touched.
---------
Co-authored-by: EugeneZelenko <eugene.zelenko at gmail.com>
Co-authored-by: Zeyi Xu <zeyi2 at nekoarch.cc>
[llvm-dwarfdump] Fix --error-display=summary and --error-display=quiet (#234308)
Before the patch `--error-display=summary` printed every error in detail
and no summary, and `--error-display=quiet` printed the aggregated
summary.
This patch adds `DIDumpOptions::ShowErrorDetails` to control per-error
output, and make `DIDumpOptions::ShowAggregateErrors` switch only the
"Aggregated error counts" summary. `DIDumpOptions::ShowErrorDetails`
defaults to true, so other DWARFVerifier users keep printing details.
Verbose no longer affects which verifier output is printed.
`llvm-dwarfdump --verify` sets `Verbose = true` unconditionally again,
and it only selects the format of the DIEs dumped in error details.
The duplicate .debug_line file name warning, which was gated on Verbose
to keep it out of the summary and quiet modes, is now gated on
ShowErrorDetails. As a consequence, dsymutil, DWARFLinker and
llvm-dwarfutil, which verify with default options, report this warning
[2 lines not shown]
math/R-cran-corpcor: New port: Efficient estimation of covariance and partial correlation
Implements a James-Stein-type shrinkage estimator for the covariance
matrix, with separate shrinkage for variances and correlations. The
approach is both computationally as well as statistically very efficient,
it is applicable to "small n, large p" data, and always returns a positive
definite and well-conditioned covariance matrix. In addition to inferring
the covariance matrix the package also provides shrinkage estimators for
partial correlations and partial variances. The inverse of the covariance
and correlation matrix can be efficiently computed, as well as any
arbitrary power of the shrinkage correlation matrix. Furthermore,
functions are available for fast singular value decomposition, for
computing the pseudoinverse, and for checking the rank and positive
definiteness of a matrix.
PR: 296812
Approved by: jrm (mentor)
Differential Revision: https://reviews.freebsd.org/D61259
math/R-cran-ranger: New port: Fast implementation of random forests
Fast implementation of Random Forests for classification, regression,
survival and probability prediction, suited for high dimensional data.
Approved by: jrm (mentor)
Differential Revision: https://reviews.freebsd.org/D61244
[Offload][AMDGPU] Return the real user count from getUserCount
This patch fixes the return type of AMDGPUQueueTy::getUserCount, which
currently returns bool: that collapses the count to 0 or 1, which upsets
the occupancy measurement in assignNextQueue.
A new test checks that work is queued appropriately across hardware
queues.
Assisted-By: Claude
[Offload][AMDGPU] Return the HSA queue as a queue's native handle
Implement getNativeQueueHandle (introduced by #234186) for AMDGPU, so
that olGetQueueInfo can report OL_QUEUE_INFO_NATIVE_HANDLE for an AMDGPU
queue instead of UNSUPPORTED. The handle is the hsa_queue_t the queue's
stream is bound to; a stream is bound on first use, so querying binds
one if necessary. Several streams may share an HSA queue, in which case
their queues report the same handle.
Assisted-By: Claude
[LV] Allow targets to filter which types maximize bandwidth (#234642)
The motivation for this is to avoid maximizing bandwidth for `i1`s on
AArch64.
On AArch64, `i1` is a legal SVE predicate element type, but data vectors
require wider types.
Treating `i1` like any other element type in
`getSmallestAndWidestTypes()` can cause the maximize-vector-bandwidth
heuristic to select excessively large VFs based on the width of `i1`
vectors.
This is undesirable because predicate vectors are normally produced or
consumed alongside data vectors, and their legal width for such
operations matches that of the data vectors. Selecting wider predicate
vectors introduces unnecessary predicate unpacking and increases vector
register pressure.
[5 lines not shown]
