[lldb][Windows] Don't exit lldb-server when Halt can't suspend a thread (#243856)
On `Halt`, `NativeProcessWindows::HandleBreakpointException` suspends
every thread and calls `exit(1)` if `DoStop` fails. `DoStop` fails with
`ERROR_ACCESS_DENIED` for a thread that is exiting but whose exit event
has not been processed yet.
This makes `TestAttachResume.py` fail on the x64 Windows bot
([5308](https://ci-external.swift.org/job/lldb-windows/job/main/5308/))
with `10 != 5`: lldb-server exits on the second `process interrupt`
because the attach thread is still exiting, and lldb reports the process
as exited.
Log the failure and continue, like the other callers of `DoStop` do, and
fix the swapped arguments of that log.
The new `TestExitDuringInterrupt.py` fails 12 of 60 runs in the bot's
image and 33 of 56 on Windows 11 without this patch. It passes 60 of 60
and 112 of 112 with it.
[2 lines not shown]
[msan] Combine scalar and scalable vector shadows per element
When Combiner::Add() combines a scalar shadow with a scalable vector
shadow, e.g. for a GEP with a scalar base and scalable indices, it hits
an assertion when casting the (scalable) vector shadow to a scalar.
Fix it by combining the two shadows as a scalable vector of the wider
element type. As a side effect, the origin check for the scalar index of
a GEP with a vector of bases no longer OR-reduces a splat of its shadow.
Assisted-by: Antigravity
[msan] Support scalable vectors in CreateShadowCast
CreateShadowCast() currently hits an assert on scalable vectors because
it casts to FixedVectorType.
Add CreateScalableShadowCast() to handle this. It casts elementwise from
a same-length vector, or splats a scalar. Narrowing poisons a whole
element if any of its bits is poisoned.
Assisted-by: Antigravity
[msan] Fix handleMulByConstant crashes on scalable vectors
For x * C, handleMulByConstant() multiplies the shadow of x by
2^ctz(C), computed for each element of a vector constant. This asserts
on scalable vectors, which it casts to FixedVectorType, and on
fixed-width constant expressions, for which getAggregateElement()
returns null.
Fix it by using the splat value of scalable vectors, and a factor of 1
(shadow unchanged) for anything that is not a ConstantInt, including
null.
Assisted-by: Antigravity
NAS-145315 / 28.0.0-BETA.1 / Remove SMB aapl_extensions, multichannel and streams from the API (#20256)
The backend logic was removed in NAS-145310, this commit finalizes the
change by removing the API fields as well. Won't be merged until
NAS-145313 (UI change) is merged.
(cherry picked from commit bb63770a7abf45379d552b998e5b2b4010294b4a)
[mlir][rewriter] Add test for stale deadness cache on nested in-place update (#244254)
Show that invalidating only the op and its ancestors in
DeadnessListener::notifyOperationModified is insufficient:
updateOpInPlace may also change IR nested in the op, leaving descendants
cached as dead and causing the op to be wrongly erased.
Test invalidating #243287
Assisted-by: Claude Code
Co-authored-by: Claude Sonnet 5.5 <noreply at anthropic.com>
CI: update the FreeBSD 15 STABLE CI runner to 15.2-STABLE
Follow the stable/15 snapshots, which are now published as
15.2-STABLE.
Reviewed-by: Brian Behlendorf <behlendorf1 at llnl.gov>
Reviewed-by: Tigerblue77 <37409593+tigerblue77 at users.noreply.github.com>
Signed-off-by: Christos Longros <longros at FreeBSD.org>
Closes #19899
ctld: Fix namespace IDs for exported NVMe namespaces part 2
This is the same fix as in commit
9c8be6518e2e5f396055ecdab8098ce19c4b2218 just applied to another
method that also accepts namespace IDs. The original commit handled
configuration statements assigning a named LUN to a namespace. This
change handles anonymous namespaces configured within a controller
context.
Fixes: 66b5296f1b29 ("ctld: Add support for NVMe over Fabrics")
Sponsored by: Chelsio Communications
(cherry picked from commit 9a99fa3932ddd794234becc6eab6519d56ae6947)
acpi_pci_link: Ignore tunables with negative values
IRQ values are unsigned and negative values do not make sense. The
invalid IRQ value (255) is already ignored, so ignoring other invalid
values is consistent with that behavior.
Reported by: cperciva
(cherry picked from commit 81dab94a5452f996a063bdba2103eda4aa32b3d1)
ctld: Fix namespace IDs for exported NVMe namespaces
NVMe namespace IDs are 1-based, but CTL LUN IDs are 0-based. The
in-kernel NVMe ctl(4) target accounts for this by adding one to the
LUN ID to compute a namespace ID. ctld was attempting to handle this
by translating namespace IDs from config files to internal LUN IDs,
but it did this incorrectly resulting in the namespace configured for
as namespace N actually showing up as namespace N + 1.
Fixes: 66b5296f1b29 ("ctld: Add support for NVMe over Fabrics")
Sponsored by: Chelsio Communications
(cherry picked from commit 9c8be6518e2e5f396055ecdab8098ce19c4b2218)
cxgbe: Don't cache nsegs for KTLS requests
KTLS mbufs are initially parsed when they are first enqueued to
estimate the number of transmit descriptors needed so that the mbuf is
queued until enough descriptors are available. As part of this
estimate, the number of DSGL segments required by each KTLS mbuf is
calculated. Originally, the count for the first TLS record in a chain
was cached in the header mbuf to avoid having to recalculate it when
writing out the actual work request for the first TLS record, but this
requires duplicating fairly complex logic both when parsing and
transmitting requests.
Sponsored by: Chelsio Communications
(cherry picked from commit 6d587ff04b71cb82a1e98fd84b5e0257dd65fec9)
cxgbe: Add a sysctl/tunable to control KTLS offload of AES-CBC cipher suites
Disable these by default as they are less efficient and rarely used.
Sponsored by: Chelsio Communications
(cherry picked from commit 9cf774a577abbe28e03a849d1ec25f47827f07e6)
cxgbe tls: Send final data as immediate when trailing waste is trimmed
When a request needs to drop data from the crypto output (via a split
mode request), send the last 16 bytes of input as immediate data
instead of via DSGL. Requests with small payloads (16 bytes or fewer)
are now sent as immediate data only without any DSGL at all.
Sponsored by: Chelsio Communications
(cherry picked from commit 1bc81d3bb05505d1facc6884ee875ccb56e42977)
acpi_pci_link: Handle IRQ values > 255
Some systems use a stub PCI link device for hardwired interrupts
instead of static _PRT entries. These link devices can use an IRQ >
255. The current driver was designed to handle PCI link devices on
x86 used for legacy INTx IRQs which were < 255. These changes handle
larger IRQ values while making a few tradeoffs.
- Expand most IRQ fields from 8 bits to 32-bits. The BIOS IRQ
(read from the PCIR_INTLINE config register which is an 8-bit register)
remains 8 bits.
- Add a wrapper API for managing interrupt weights and avoid tracking
weights for IRQs > 255 and instead report a constant weight of 0 for
IRQs > 255.
PR: 300476
Reported by: Aviv Bakal <avivb at amazon.com>
Tested by: cperciva
[2 lines not shown]
cxgbe: Greatly simplify ktls_wr_len for T7
Don't try to fine-tune the WR size when estimating the work request
length when parsing the packet. Use a much simpler worst-case
estimate that only depends on a few fields in the mbuf metadata.
Sponsored by: Chelsio Communications
(cherry picked from commit 613e7ce43f814c3fb3e076f8509b969b5c12808f)
cxgbe: Various assertions for lengths in KTLS work requests
The construction of KTLS work requests is quite fragile, and these
assertions ensure that the constructed work requests match the length
fields encoded in some of the WR structures.
Sponsored by: Chelsio Communications
(cherry picked from commit 17126d54c40a2e3f3e2a81e31a07c299416ddf4a)
[lldb][test] Skip more tests that don't work with WebAssembly (#244248)
These are breaking the new Green Dragon matrix bot that now also tests
WebAssembly. This patch just adds skipIfWasm to all broken tests I could
see in the log to unbreak the bot.
netflow: modify netgraph NAT accounting to prevent duplicate flow records (#11235)
Use global ONCE accounting instead of THISONCE across per-interface
Netgraph nodes so routed packets are exported only at the
first eligible observation point. Preserve internal addresses
through egress-only WAN capture and update its help text.
While here, replace deprecated Python SQLite datetime handling.