[lldb] Avoid interning SBStream contents into the ConstString Pool (#227338)
SBStream::GetData() builds a ConstString from the stream's contents
before returning a const char*. ConstString's backing StringPool is
global and never frees entries, so every call permanently adds a copy of
the stream's contents to the pool for the lifetime of the debugger.
lldb-dap's telemetry dispatcher uses `SetFromJSON` to send the telemetry
to the debugger. This keeps growing the pool with data that will never
be used again. From https://github.com/llvm/llvm-project/pull/225785
Add a private SBStream::GetString(), returning the underlying
StreamString's contents as an llvm::StringRef without touching the
ConstString pool.
[libc][NFC] fix fdopen_test comparisons (#232104)
When possible it's better to use ASSERT_EQ/NE instead of ASSERT_TRUE.
fdopen_test was using ASSERT_TRUE for some FILE* variables. This PR
moves them to ASSERT_RQ/NE.
[tsan] Clear ThreadSignalContext shadow memory on thread exit (#230708)
[tsan] Clear ThreadSignalContext shadow memory on thread exit
`SigCtx(ThreadState *thr)` allocates a per-thread `ThreadSignalContext`
(`sctx`) via internal `MmapOrDie(sizeof(*sctx))`. When a signal is
delivered to a user `sa_sigaction` handler, `CallUserSignalHandler`
passes `&sctx->pending_signals[sig].siginfo` and
`&sctx->pending_signals[sig].ctx` directly to the user handler. Any
instrumented reads or writes to the `siginfo_t` or `ucontext_t`
arguments populate TSan shadow memory for the `sctx` mapping.
Previously, `PlatformCleanUpThreadState` unmapped `sctx` via raw
`UnmapOrDie(sctx, sizeof(*sctx))` upon thread exit without clearing its
shadow memory, leaving stale shadow entries behind when the virtual
pages were reused or shared a shadow page with an adjacent mapping.
Call `DontNeedShadowFor((uptr)sctx, RoundUpTo(sizeof(*sctx),
GetPageSizeCached()))`
[5 lines not shown]
DAG: Don't export arguments for FastISel if it won't be used
LowerArguments decided whether to export arguments to virtual
registers based on TM.Options.EnableFastISel. That option is set at
-O0 even for targets that have no FastISel implementation. This is
unnecessary without fast isel, so stop doing that.
The unneeded CopyToReg was an extra use of every argument, which
blocked some combines. The dead copies also survived to register
allocation. These copies were an edge case that regallocfast would
introduce dead flags on.
Co-authored-by: Claude Opus 5.5 <noreply at anthropic.com>
[libc][math] Add correctly rounded, float-only implementation of expf for GPUs (#231671)
This patch adds a GPU-oriented implementation of `expf`, correctly
rounded for all inputs in round-to-nearest, ties-to-even mode. It uses
float-only intermediate arithmetic and Horner evaluation, without lookup
tables, a Ziv test, or separate fast and accurate paths.
It requires single-precision FMA.
### Performance on NVIDIA GeForce RTX 5070 (Cycles/Call)
Results were collected using a locally adapted `expf` benchmark based on
the GPU benchmark infrastructure in `libc/benchmarks/gpu`.
Tables report median cycles/call across five per-run means, with a
per-thread batch size of `N = 128`. Lower is better; the lowest value in
each row is bold. `Relative` compares FloatEvalCrRn (this PR) with the
fastest alternative in each row: “faster” means fewer cycles/call;
“slower” means more.
[75 lines not shown]
[MLIR][Python] Only raise numpy/ml_dtypes minimums for Python 3.15
Use python_version markers instead of raising the numpy cap for everyone:
Python < 3.15 keeps numpy <= 2.1.2, and 3.15 gets numpy 2.5.x and
ml_dtypes 0.6.0 (the first releases with cp315 wheels).
[MLIR][Python] Only require nanobind 2.13 for Python 3.15
Keep the nanobind minimum at 2.9 for Python < 3.15 instead of raising it
for everyone; only 3.15 needs 2.13 (for PyFrozenDict_Type in
darwin-ld-cpython.sym on macOS).
Tighten snapshot rename and create events and refuse update with a validation error
## Problem
A recursive snapshot rename announced descendants by looking for the new name after the rename, so a child that already had the new name but never had the old one got a bogus REMOVED and a duplicate ADDED. A recursive `pool.snapshot.create` that excluded its own dataset sent `pool.snapshot.query` ADDED for a snapshot that was never created. `pool.snapshot.update` failed with a CallError although it is the requested change that cannot be honoured.
## Solution
Snapshot rename now announces only the named snapshot, matching how `zfs.resource.rename` announces only the named dataset, and the event description says descendants' snapshots emit nothing. `pool.snapshot.create` only sends ADDED when the snapshot actually exists. `pool.snapshot.update` raises a ValidationError, still with EOPNOTSUPP.
Standardize zfs.resource.snapshot on the zfs.resource design
## Problem
`zfs.resource.snapshot` only partly followed the design `zfs.resource` settled on. It still exposed `query` instead of `list`, raised on missing paths, emitted no events, took clone properties as an untyped dict passed straight to libzfs (so user properties failed and internal-only properties like `mountpoint` were reachable through clone), had no `force` acknowledgement on rename, keyed most validation errors on the bare method name, and had several wrong descriptions. Separately, the ZFS history hook ran the whole dataset-delete path for every snapshot destroy, sending bogus `pool.dataset.query` REMOVED events and, on HA, syncing encryption keys to the standby once per destroyed snapshot. `pool.snapshot.update` silently did nothing.
## Solution
- **list**: added `zfs.resource.snapshot.list`; `query` stays as a hidden alias for pre-v28 clients and `query_impl` is now `list_impl`. list, query and count skip a named path that does not exist; a path vanishing mid-walk still raises. `holds` is hidden from v28 in favour of `list` with `get_holds`. `pool.dataset.snapshot_count` keeps its existing errors.
- **events**: new `zfs.resource.snapshot.list` collection (SNAPSHOT_READ). ADDED for every snapshot created or renamed through the API, CHANGED with the holds after hold/release, REMOVED for the old name on rename. Destroys are reported from the ZFS history hook, which now handles snapshot names first and returns, so CLI, retention, rollback and recursive destroys are all covered and the dataset-delete path no longer runs for snapshots. `pool.snapshot.query` REMOVED moves to the hook as well and no longer carries `extra.recursive`. Clone sends `zfs.resource.list` ADDED for the new dataset.
- **clone**: properties are typed with the set vocabulary less `volsize`, plus a separate `user_properties` that is passed through to libzfs. The stateless create/set rules apply (type validity, user property names/values, `special_small_blocks` and tiering, recordsize, dedup entitlement, acl defaults). `pool.snapshot.clone` keeps its flat `dataset_properties` shape but now rejects internal-only, unknown and wrongly typed properties.
- **rename**: zr snapshot rename requires `force` like dataset rename; v27 callers are adapted to `force=True` and `pool.snapshot.rename` behaves as before.
- **errors and docs**: validation errors are keyed on the offending field with an explicit errno, `pool.snapshot` re-keys them onto its own attributes, the mutating argument models are named `*ArgsData` as in `zfs.resource`, and the wrong descriptions, docstrings and audit text are fixed.
- **update**: `pool.snapshot.update` raises EOPNOTSUPP instead of returning nothing.
User properties on clone require a truenas_pylibzfs with `clone(user_properties=...)` support.
Don't print newline after reading password if interrupted by signal.
Avoids an extra newline when the user presses ^C or ^\ at the
password prompt. OK deraadt@
[clang][CodeGen] Skip re-emission of already-defined globals in EmitDeferred
When a deferred decl was already emitted and its existing definition has a different LLVM type than the requested one (e.g. an inline variable whose initializer folded to an anonymous union type), EmitDeferred called GetAddrOfGlobal with ForDefinition, which replaced and erased the existing definition. Erasing the defined global dangles pointers held by callers, e.g. the AssociatedData of entries in llvm.global_ctors, leading to a use-after-free during EmitCtorList.
Check for an existing definition of the same entity before requesting a correctly typed value, and skip the re-emission. This keeps GetOrCreateLLVMGlobal's invariant that a ForDefinition request returns a global of exactly the requested type.
Add the OpenMP non-modules reproducer as a regression test alongside the header-unit test, and assert single emission via the position of the guard variable in both.
Co-authored-by: Michael Park <mcypark at gmail.com>
[mlir][scf] Preserve forall shared output order in promote (#222144)
Build promoted results in shared output order instead of the textual
order of `scf.forall.in_parallel` operations.
This preserves the correct result mapping when the orders differ.
Fixes #222143
Assisted-by: Codex
[CIR][OpenMP] Add support for omp teams
This patch adds support for the OpenMP 'teams' directive, both standalone
and as the combined `target teams` construct. isCombinableLeaf now also
recognizes teams, so an explicitly-nested `target` + `teams` pair gets
the same omp.combined marking as the combined case.
Assisted-by: Cursor / Claude Sonnet 5 High
[GlobalISel] Ignore debug uses in Localizer decisions (#231703)
Currently debug uses can affect Localizer decisions because they are
treated like all other uses.
Fix this by ignoring debug uses when deciding what to localize and where
to put it. When sinking a definition past a DBG_VALUE that uses it, move
the DBG_VALUE down to right after the definition, so that it stays with
it. If a later DBG_VALUE of the same variable replaces it first, make it
undef instead.
Assisted-by: Claude
[mlir][Vector] Add a dedicated Transform Dialect op for `UnrollContractPattern` (#230543)
Adds a dedicated Transform Dialect op to run `UnrollContractPattern`.
The new op is currently restricted to matmul-like `vector.contract` ops
and has limitations similar to those of:
`transform.apply_patterns.gpu.unroll_vectors_subgroup_mma`
We could consider merging the two ops in the future.
While the new `transform.apply_patterns.vector.unroll_contract` op is
quite constrained, it suffices for my use case, so I have refrained from
generalising it. It takes three unroll sizes, corresponding to the M, N,
and K dimensions in GEMM/matmul terminology.
There are also a couple of minor NFC changes. For example,
vector-multi-reduction-unrolling.mlir
[7 lines not shown]
[Mips] Rename GPR register records to R<n> (#230696)
Rename the Mips GPR TableGen records from their O32 role names (V0, T0,
SP, ...) to ABI-independent R0-R31, as suggested by the TODO in #224284.
Assembly syntax is unchanged; MIR uses the new names ($r2, $r29, ...).
The new register enum order changes some register allocation and
delay slot choices in tests.
Co-Authored-By: Claude Opus 5.5 <noreply at anthropic.com>
Co-authored-by: Vince Del Vecchio <vince.delvecchio at mediatek.com>
Co-authored-by: Anton Rapetov <anton.rapetov at mediatek.com>
[GlobalISel] Undef debug uses of erased instructions (#231716)
GlobalISel erases an instruction it calls salvageDebugInfo to rewrite
its debug users. Unsalvageable uses remain and refer to the erased
instruction's output register.
Targets whose instruction selector does not constrain debug operands
then carry a DBG_VALUE of a generic vreg past selection. On RISC-V, a
DBG_VALUE of a getelementptr that gets folded into a load's addressing
mode trips an assertion in the fast register allocator at -O0 and fails
the machine verifier at -O2.
This patch explicitly makes unsalvageable debug values undef instead.
Assisted-by: Claude
TargetParser: Clean up data layout string construction
Instead of building many small string fragments, use longer
concatenated literals. The mips case in particular was hard
to follow and had an unused enum value.
Co-authored-by: Claude Opus 5.5 <noreply at anthropic.com>
[flang][OpenMP][#225225] Add diagnosis on invalid list items in depend(depobj:) clauses (#227790)
Summary
Add diagnosis on invalid list items in depend(depobj:) clauses to
enforces the OpenMP 5.0 §2.17.11 restrictions on the depend clause with
the depobj dependence type in the semantic checker, so invalid programs
get a clear diagnostic instead of falling through to the not yet
implemented: DEPOBJ dependence-type lowering TODO.
Per the spec, with the depobj dependence type:
• Array sections cannot be specified in depend clauses with the depobj
dependence type.
• List items used in depend clauses with the depobj dependence type must
be depend objects in the initialized state.
Also adds a semantics test and updates the existing Todo lowering test
to use a valid depend object. Lowering remains unimplemented; this is
front-end checks only.
[2 lines not shown]
[VPlan] Factor out pointer add expansion in VPSCEVExpander (NFC). (#232391)
Move expansion of pointer-typed SCEVs as ptradd of pointer base and
offset to a separate helper, so it can be re-used for AddRecs.
