[lldb] Add a Deprecated attribute for settings, to discourage use (#243732)
I want to change all of the lldb-cache-index settings that exist today,
reorganizing them to reflect how I'm growing the DataFileCache system.
Users may have the old settings in their .lldbinit files, and I don't
want those to result in errors. I will mark the old settings Deprecated,
and if they are set, have them set the correct new setting names.
The goal of a deprecated setting is to make it undiscoverable by
accident -- `settings list`, `settings show` will not show the name
unless the full path is given, unless `--include-deprecated` is added.
When it is shown, the setting name will be followed by a deprecation
tag, "(deprecated)". If a user sets a setting with `settings set`, a
warning will be printed that this setting is deprecated - so their
.lldbinit file will give a warning each time it is sourced, but it will
continue to work.
I think the most important thing to consider with this PR are the UI of
all the different ways settings are accessed and viewed. This PR adds a
[128 lines not shown]
[MLIR][PDL][Test] Fix memory leaks in testNullPDLValueArg (#244344)
https://github.com/llvm/llvm-project/pull/228456 added
`testNullPDLValueArg` in `mlir/test/CAPI/pdl.c`, which fails under
LeakSanitizer on the ASan buildbot.
`mlirRewritePatternSetFromPDLPatternModule` and
`mlirFreezeRewritePattern` move the contents out of their input handles
without freeing the heap-allocated containers themselves, and
`FrozenRewritePatternSet` leaves the lowered `OwningOpRef<ModuleOp>`
inside the `RewritePatternSet`. Passing the `MlirRewritePatternSet` as
an unnamed temporary and omitting the destroy calls therefore leaked
`MlirPDLPatternModule` and `MlirRewritePatternSet`.
This PR destroies both `pdlModule` and the intermediate `patternSet`
after freezing. This is the same pattern in `mlir/test/CAPI/rewrite.c`.
Assisted-by: Gemini
[lldb] Add SBInitializationOptions (#244066)
Add SBInitializationOptions and an SBDebugger::Initialize overload that
takes it, for choices a host has to make before LLDB initializes. A
setting or an SBDebugger method comes too late for those.
The class has no options yet.
Assisted-by: Claude
[libc] Add a handful of missing includes (#244361)
This PR adds a few missing includes and their CMake dependencies.
I'm looking to add Bazel rules for these headers. Bazel surfaced these
missing includes because it parses/validates each header on its own.
nix: the platform names the nixpkgs-illumos commit it was built with
The pin moves to nixpkgs-illumos 432283b and records the commit's date;
default.nix gives the pin to the build when it fetched the recipes at
it, so gitstatus.json names that commit. A checkout of nixpkgs-illumos
standing in (NIX_PATH, -I or --arg nixpkgsIllumos) is named by its own.
Co-Authored-By: Claude Opus 5.5 <noreply at anthropic.com>
CSKY: Use LastSubtargetCache in getSubtargetImpl (#242778)
Migrate to the new common pattern for targets to cache the last
result.
Co-authored-by: Claude Opus 5.5 <noreply at anthropic.com>
NAS-145323 / 27.1.0 / Only accept a report file name in audit.download_report
audit.export creates each report directly in the user's report
directory, so report_name must be a single file name. Refuse a name
that is empty, is "." or "..", or contains "/" or a NUL byte.
Open the report with safe_open, which refuses a symlink anywhere in
the path, and serve it from that file once it is confirmed to be a
regular file. This replaces the separate existence and file type
checks on the path.
(cherry picked from commit 73b9dd025a1d75ed63fd21491629804e3107af6a)
[Offload][AMDGPU][NFC] Introduce per-device runtime options (#239816)
This PR:
- Introduce per-device runtime options;
- Enable flexible setting for default values;
- Move AMDGPU queue and SDMA settings into the new options structure to
show the usage;
- No changes to the existing behaviors and defaults;
- Can be extended to support configurations from profiles.
RFC can be found:
https://discourse.llvm.org/t/rfc-offload-amdgpu-device-specific-runtime-defaults-for-the-openmp-amdgpu-plugin/91613
Assisted by GPT5.6
[LLVMABI] Treat data member pointers as scalars (#244140)
Match Clang, which passes atomic data member pointers directly on x86-64
Required for https://github.com/llvm/llvm-project/pull/223259
CGExprCXX: emit family and allockind attributes (#239732)
This allows us to remove the special knowledge about C++ allocation from
LLVM's MemoryBuiltins.cpp, instead trusting attributes to communicate
the important properties.
Annoyingly, clang has to grow a little bit of hard-coded knowledge about
mangled symbol names in order to actually get the most-basic-matching
::operator::new when working out the alloc-family attribute. I spent
some time trying to do this "right" by looking up the available
operators new and finding the best one, but that's super tricky and this
has the virtue of working and being pretty obviously correct when
compared to the old code.
Happily, clang now emits allocator family attributes for custom
allocators like the `__hot_cold_t` overloads in `new_hot_cold.cpp`
(which `isReplaceableGlobalAllocationFunction` in clang recognizes),
allowing us to remove that special knowledge from LLVM.
[6 lines not shown]
NAS-145323 / 28.0.0-BETA.1 / Only accept a report file name in audit.download_report (#20266)
audit.export creates each report directly in the user's report
directory, so report_name must be a single file name.
Only accept a report file name in audit.download_report
audit.export creates each report directly in the user's report
directory, so report_name must be a single file name. Refuse a name
that is empty, is "." or "..", or contains "/" or a NUL byte.
Open the report with safe_open, which refuses a symlink anywhere in
the path, and serve it from that file once it is confirmed to be a
regular file. This replaces the separate existence and file type
checks on the path.
README: building with Nix
How to go from a SmartOS host to a platform: the nix-zone image, a
builder-brand zone from it, and tools/build_nix.
Co-Authored-By: Claude Opus 5.5 <noreply at anthropic.com>
[clang] Don't relocate DWARF on 32-bit ARM and x86 Mach-O (#244069)
On 32-bit ARM and x86, Mach-O uses scattered relocations, which identify
their target by address. Relocatable DWARF puts every __DWARF section at
address 0, so these relocations become ambiguous: a line table's
reference to a file name in __debug_line_str resolves to the first
function in __text instead.
Don't enable relocatable DWARF for these architectures.
Assisted-by: Claude
Build SmartOS with Nix from this checkout
default.nix is the package set of nixpkgs-illumos' SmartOS build, at the
commit nix/nixpkgs-illumos.json pins, with this checkout as the
smartos-live built and the identity the build is stamped from.
tools/build_nix makes a platform and its USB image in one step, through
nixpkgs-illumos' build-smartos.
Co-Authored-By: Claude Opus 5.5 <noreply at anthropic.com>