net/ieee_oui.h: clarify how `OUI_FREEBSD_BASE` is managed
Note that the FreeBSD Foundation manages the current value
associated with `OUI_FREEBSD_BASE`.
Trim trailing whitespace in comments in the change while here.
MFC after: 1 week
Pull Request: https://ron-dev.freebsd.org/FreeBSD/src/pulls/82
Attributor: Only use anchor instruction effects for call site positions (#231635)
AAMemoryBehavior initialized the known state of a position from the
mayReadFromMemory/mayWriteToMemory of its anchor instruction. This is
only correct when the anchor is the call. For a floating pointer value
defined by a load, the load does not write, but the pointer may still be
written through. AAInvariantLoadPointer then marked loads as invariant
that were clobbered in the same function, which miscompiled sqlite3 with
-attributor-enable=full.
Co-authored-by: Claude Opus 5.5 <noreply at anthropic.com>
[mlir][Presburger] Add PresburgerRelation::gist
Add PresburgerRelation::gist (and PresburgerSet forwarding overloads)
for a convex context and for a context that is itself a union of
disjuncts, following ISL's isl_map_gist / isl_map_gist_basic_map.
For a convex context, each disjunct is simplified separately with
IntegerRelation::gist; disjuncts that become empty are dropped and if any
disjunct becomes the universe, the universe is returned.
For a non-convex context, the trivial cases (universe set or context,
empty context, equal set and context, context being a subset of the
set) are handled first. Otherwise, the context is approximated by a
convex set. Instead of ISL's unshifted simple hull of the context and the
set, we use the universe together with all constraints of the disjuncts
of the context and of the set that are valid for every disjunct of the
context (checked with Simplex); including the constraints of the set
allows removing constraints that are implied by every disjunct of the
context even if they are not implied by the simple hull.
[mlir][Presburger] Add IntegerRelation::gist (context-based simplification)
Add IntegerRelation::gist(context), a port of ISL's isl_basic_map_gist
(uset_gist / uset_gist_full). It replaces the relation S by a relation
S' such that S' ∩ context == S ∩ context, with as few constraints as
possible: constraints of S that are implied by the context together with
the remaining constraints of S are removed, and the remaining constraints
may be rewritten using the equalities of the context. Outside of the
context S' may differ from S, so the result is only meaningful together
with the context. The result has at most as many constraints as S
(except that the constraints defining a division that is still used may
be restored, see below), never more local variables, and never involves
variables that S does not involve; in particular, locals of the context
are never introduced.
Trivial cases: an obviously empty context yields the universe; if the
intersection with the context is found to be empty later (inconsistent
combined equalities, a context that turns out to be rationally empty, or
an empty combined Simplex), the result is empty; an obviously empty S
[43 lines not shown]
[mlir][Presburger] Add IntegerRelation::reduceUsingEqualities helper
Add a protected helper that rewrites all constraints of a relation using
the equalities of another relation in the same space, without changing
the intersection of the two. This is a port of ISL's
isl_basic_set_reduce_using_equalities together with
project_onto_involved: the equalities are first projected onto the
variables that occur in the relation being reduced, so that no new
variables (in particular, no locals of the other relation) are
introduced, and each remaining equality is then used to eliminate its
last variable with a non-zero coefficient from every constraint, so that
later variables (locals) are eliminated in favor of earlier ones.
This is a building block for context-based simplification (gist) and is
exercised by the gist tests added in a follow-up commit, since there is
no existing pattern for unit-testing protected members of
IntegerRelation.
Report failover steps in vrrp_master progress
This commit adds changes to report the current failover step in the vrrp_master job's progress extra field so TrueNAS Connect can show users what a failover is doing. The existing progress descriptions are left untouched since the webUI and failover.status depend on them.
Remove the TNC-delivered license when leaving TrueNAS Connect
This commit adds changes to remove the license TrueNAS Connect delivered when the system leaves TNC, either because the user disabled it or because TNC de-registered the system. Only a community license carrying TNC_SUB is removed so paid licenses are left alone, and removal is best effort so it never fails the disable or de-registration.
test-runner: preserve command argument boundaries
Building sudo arguments by splitting a command string inserts an empty
argument when TMPDIR is unset and splits paths containing spaces.
Construct the argument list directly and add the optional environment
assignment only when TMPDIR is set.
Reviewed-by: Brian Behlendorf <behlendorf1 at llnl.gov>
Signed-off-by: ooonea <35407790+ooonea at users.noreply.github.com>
Assisted-by: OpenAI Codex
Closes #19575
ufshci: report the SCSI status and sense to CAM
A CHECK CONDITION was reported to CAM as a transport error without
valid sense, so CAM retried blindly. After a reset the device answers
NOT READY, and those retries ran out and detached the disk.
Report the SCSI status and sense with CAM_AUTOSNS_VALID, and freeze the
device queue on a SCSI status error. A GOOD status with a failed
response is still an error. Stop logging every CHECK CONDITION.
Reviewed by: imp
Sponsored by: Samsung Electronics
Differential Revision: https://reviews.freebsd.org/D61122
ufshci: try the link startup more than once
A device that is still powering on may not answer the first
DME_LINKSTARTUP, and the driver gave up after one try.
Try up to three times. Both attach and reset use this path.
Reviewed by: imp
Sponsored by: Samsung Electronics
Differential Revision: https://reviews.freebsd.org/D61121
ufshci: tell CAM when the controller is gone for good
When the controller failed for good, CAM was not told, so its disks
stayed and every command to them failed.
Post AC_LOST_DEVICE from the failure path so CAM removes them.
Reviewed by: imp
Sponsored by: Samsung Electronics
Differential Revision: https://reviews.freebsd.org/D61120
ufshci: fail the controller when a polled command never completes
The reset task waits on its own polled bring-up commands. If one was
lost, nothing could complete it, and the poll panicked after ten
seconds.
Fail the controller instead. The failure path completes every
outstanding request, including the polled one, so the poll returns an
error to its caller. A polled command is only sent while the controller
is being brought up or by the passthrough ioctl, and a lost one means
the controller is not usable anyway.
Reviewed by: imp
Sponsored by: Samsung Electronics
Differential Revision: https://reviews.freebsd.org/D61119
ufshci: hold back I/O during a reset
The disable path only claims what is in flight at that moment. An I/O
submitted after a reset was requested rang a doorbell that the reset
then wiped, so it was lost. An I/O sent as soon as the queue was back
reached the device before the bring-up had initialized it, and the
device answered NOT READY.
Keep such an I/O on a list instead, without a slot, from the moment a
reset is requested until the bring-up has finished, and send the list
in order then. A request that a reset returned to CAM comes back while
the list is still held, so it waits there too. A completion sends the
next one when the slots have run out. If the controller fails first,
the failure path completes the list with an error. Admin and task
management requests still go out, because the reset task waits on its
own commands and the watchdog sends the aborts. This is how nvme(4)
holds requests while a queue is in recovery.
Reviewed by: imp
[2 lines not shown]
ufshci: requeue requests that a reset aborted
A request taken back by a reset was reported to CAM as an error, which
used up a retry. A few resets in a row failed the I/O even though the
device never saw it.
Pass the overall command status to the completion callback and requeue
aborted requests. The polled completion carries it too, so the
passthrough ioctl reports it instead of a placeholder zero. The abort
path now reports an invalid status instead of aborted, so a command
that never finishes still uses up its retries.
Reviewed by: imp
Sponsored by: Samsung Electronics
Differential Revision: https://reviews.freebsd.org/D61117
ufshci: reclaim in-flight requests across a reset in SDB mode
A reset wipes the controller's request list, so a request that was in
flight never completes. Its slot stayed scheduled, the watchdog timed
it out again, and the next reset went round the same way. CAM never
got the request back.
Claim in-flight requests when the queue is disabled and return them as
aborted once it is back. If the reset fails first, the failure path
completes them instead.
Reviewed by: imp
Sponsored by: Samsung Electronics
Differential Revision: https://reviews.freebsd.org/D61116
ufshci: keep a slot for admin requests
The slot reserve step handed any free slot to whoever asked first, so
I/O could fill the queue and leave no slot for the driver's own admin
commands, which a reset sends through the same queue. A full queue was
also reported to CAM as busy, and CAM used up its retries on that
within microseconds.
Keep the last slot for admin requests and give CAM one opening fewer,
since letting CAM fill every I/O slot cut the throughput sharply. On a
full queue, freeze the device queue and requeue the request. Remove the
unused reserve_admin_slot hook.
Reviewed by: imp
Sponsored by: Samsung Electronics
Differential Revision: https://reviews.freebsd.org/D61114
ufshci: tear down the controller in a safe order
Detach freed the request queues while the interrupt, the watchdog or a
running reset could still use them. It also left the controller
running, so a pending interrupt could hit the next attach before its
queues existed.
Tear down the interrupt, stop the watchdogs, free the task queue,
disable the controller, and only then destroy the queues. A stopped
watchdog stays stopped, so a reset still running cannot arm it again.
A reset requested after the task queue is freed is ignored.
Reviewed by: imp
Sponsored by: Samsung Electronics
Differential Revision: https://reviews.freebsd.org/D61115
ufshci: claim a slot before completing it
A request is completed with the queue lock dropped, because the
completion callback may submit the next request and take that lock
again. The completion scan checked a slot under the lock, dropped the
lock, and only then completed the request, with the slot still marked
scheduled. The failure path and the abort completion look for such
slots under the same lock, so one of them could pick the same slot in
that window. The request was then completed twice, freed twice, and
its CCB went back to CAM twice. After a reset every in-flight slot
reads as done at once, so the window was easy to hit.
No existing state could mark that window. FREE would hand the slot to
a new request while the old completion still reads it, RESERVED means
a submit in progress, and NEED_ERROR_HANDLING is about to mean a
request that a reset has claimed but nobody has completed yet.
Add a completing state. Every path that completes a slot sets it
under the lock before dropping the lock, and every path skips a slot
[6 lines not shown]
ufshci: add debug aids for driving the recovery path
The reset and recovery paths only run when the hardware fails, so they
never ran on an emulated controller. The failure path also took the
controller offline without logging anything.
Add the force_reset, drop_next_ios and drop_next_admins sysctls to
drive these paths, and log when the controller fails. The aborts the
watchdog sends must go out, so the task management queue is never
dropped.
Reviewed by: imp
Sponsored by: Samsung Electronics
Differential Revision: https://reviews.freebsd.org/D61112
ufshci: detect completions with the completion notification register
The single doorbell completion scan took a cleared doorbell bit as a
completion. A bit that was never set reads the same, so a slot whose
doorbell was not rung yet, or one that a reset wiped, looked complete
and was finished with a stale descriptor.
UFSHCI 3.0 added UTRLCNR, which the controller sets when it completes
a request and the driver already clears afterwards. Use it to find
completed slots on a 3.0 or later controller. Older controllers keep
the doorbell check, and the task management list has no such register.
Reviewed by: imp
Sponsored by: Samsung Electronics
Differential Revision: https://reviews.freebsd.org/D61111
zdb: free unpacked pool history records
Free the history records and pointer array owned by dump_history after
printing them. Share cleanup with the read-error path while preserving
its return without printing partial history.
Reviewed-by: Brian Behlendorf <behlendorf1 at llnl.gov>
Signed-off-by: ooonea <35407790+ooonea at users.noreply.github.com>
Assisted-by: OpenAI Codex
Closes #19582
RuntimeLibcalls: Stop returning an attribute when getting libcall types
The attribute half of the pair has been empty since the extension
attributes moved to getIntExtAttr, so return just the type.
Co-authored-by: Claude Opus 5.5 <noreply at anthropic.com>
mii: fix the LINT-NOVIMAGE build for LAN867X
`sys/kernel.h` must be included for all kernel drivers, per driver(9).
`sys/kernel.h` provides defines for `SI_*`, which
`EARLY_DRIVER_MODULE(..)` in `sys/bus.h` relies on and the latter header
is not "self-standing".
Found when running `make tinderbox`.
Fixes: 83d0eed50106 ("lan867xphy: New driver for Microchip ...")
[mlir][Presburger] Add IntegerRelation::reduceUsingEqualities helper
Add a protected helper that rewrites all constraints of a relation using
the equalities of another relation in the same space, without changing
the intersection of the two. This is a port of ISL's
isl_basic_set_reduce_using_equalities together with
project_onto_involved: the equalities are first projected onto the
variables that occur in the relation being reduced, so that no new
variables (in particular, no locals of the other relation) are
introduced, and each remaining equality is then used to eliminate its
last variable with a non-zero coefficient from every constraint, so that
later variables (locals) are eliminated in favor of earlier ones.
This is a building block for context-based simplification (gist) and is
exercised by the gist tests added in a follow-up commit, since there is
no existing pattern for unit-testing protected members of
IntegerRelation.
Remove the TNC-delivered license when leaving TrueNAS Connect
This commit adds changes to remove the license TrueNAS Connect delivered when the system leaves TNC, either because the user disabled it or because TNC de-registered the system. Only a community license carrying TNC_SUB is removed so paid licenses are left alone, and removal is best effort so it never fails the disable or de-registration.
ZTS: resolve namespace fixture sleep through PATH
Resolve sleep through the constrained test PATH instead of assuming
/usr/bin/sleep exists. Alpine provides it in /bin. Keep namespace probes
and test assertions unchanged.
Reviewed-by: Brian Behlendorf <behlendorf1 at llnl.gov>
Signed-off-by: ooonea <35407790+ooonea at users.noreply.github.com>
Assisted-by: OpenAI Codex
Closes #19583
CI: install Alpine PAM development headers
Install linux-pam-dev so configure finds security/pam_modules.h and
builds pam_zfs_key in the Alpine VM. Keep the existing module source and
installation path.
Reviewed-by: Brian Behlendorf <behlendorf1 at llnl.gov>
Signed-off-by: ooonea <35407790+ooonea at users.noreply.github.com>
Co-authored-by: ooonea <ooonea at noreply.codeberg.org>
Assisted-by: OpenAI Codex
Closes #19584
games/py-fife: update the port to the latest version 0.4.3
This makes it ready for CMake 4.x, albeit still relying on the
old CMP0078 policy, and cleans up a bunch of "from __future__"
imports in the Python code.
Reported by: portscout
