NAS-141503 / 26.0.0-RC.1 / Skip individual domains that vanish while gathering libvirt state (by Qubad786) (#19190)
## Problem
`gather_pylibvirt_domains_states` wraps its whole loop in one
try/except. If a queried domain is destroyed between `list_domains()`
and reading its state (a TOCTOU race), libvirt raises
`VIR_ERR_NO_DOMAIN` and the exception unwinds the entire loop, so every
still-running domain after it is dropped from the result and reported as
STOPPED/`pid: null` until the next poll. It also logged a full WARNING
traceback for what is a benign, self-correcting race, and masked genuine
errors (e.g. a bug in the per-domain factory) behind that same generic
warning.
## Solution
Moved the try/except inside the loop so a vanished domain is skipped
individually while the rest of the batch is still reported correctly (a
missing entry falls back to STOPPED via `get_pylibvirt_domain_state`).
The failure is classified using the new `is_no_domain_error` helper from
truenas_pylibvirt: the no-domain race is logged at DEBUG, anything else
[5 lines not shown]
[Clang][Docs] Fixed typos of sentinel attribute (#205539)
I have previously documented the sentinel attribute but some typos have
been missed during the review process.
18157 NFSv4.1 backchannel slot negotiation bug
Reviewed by: Jason King <jason.brian.king+illumos at gmail.com>
Reviewed by: C Fraire <cfraire at me.com>
Reviewed by: Marco van Wieringen <marco.van.wieringen at planets.elm.net>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Robert Mustacchi <rm at fingolfin.org>
18159 NFSv4.1 panic in rfs4x_do_cb_recall
Reviewed by: Jerry Jelinek <gjelinek at racktopsystems.com>
Reviewed by: Matt Barden <mbarden at racktopsystems.com>
Reviewed by: Dan McDonald <danmcd at edgecast.io>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Robert Mustacchi <rm at fingolfin.org>
geography/py-gnssutils: Update to 1.2.5
Upstream NEWS:
## What's Changed
1. Further enhancements and bug fixes to RINEX conversion routines.
1. Add support for SBAS L1CA, QZSS LNAV/CNAV, IRNSS (NAVIC) LNAV.
**NB:** Rinex Conversion remains an experimental Alpha feature and contributions (including wider area testing and bug reports) and feedback are welcomed.
[libc++] Remove <features.h> include from <__config> (#205549)
The include was moved to `<__configuration/platform.h>` in #205548,
which was also supposed to remove the include in `<__config>`.
mimsc/libreoffice: Update to 26.2.4.2
* Fix build with GCC 14 in NetBSD 11.99.6 base.
Changelog:
26.2.4.2:
List of fixed bugs
Bugs fixed compared to 26.2.4 RC1:
ofz#513047070 return early before unnecessary dereference [Caolán McNamara]
ofz#513256641 null-dereference READ [Caolán McNamara]
tdf#170420 LibreOffice Base hangs if I convert a text box to a list box in a form. [Dan Williams]
tdf#172008 Blank Black Window in LibreOffice in Windows 11, skia Vulkan rendering (Intel Iris Xe Graphics) [Julien Nabet]
26.2.4.1:
List of fixed bugs
Bugs fixed compared to 26.2.3 RC2:
[45 lines not shown]
[NFC][analyzer] Remove the NodeBuilder from eagerly assume (#204371)
Part of my commit series to gradually eliminate the class `NodeBuilder`.
Admittedly this is one of the few places where the implementation with
the `NodeBuilder` is more concise than the new code.
This is caused by two factors:
1. This is an optional step in the analysis, so the "put source nodes in
destination unless we generate a child node from them" behavior of
`NodeBuilder` -- which is often completely useless -- was helpful on two
branches.
2. Making nodes with tags is very rare, so I intentionally did not
include support for tagging in `makeNodeWithBinding` -- but this is one
of the few places where tags are applied.
[libc++] Move <features.h> include to <__configuration/platform.h> (#205548)
Including `<features.h>` is platform-specific configuration and should
therefore be in `<__configuration/platform.h>`.
[offload][unittest] Set rpath to make sure tests use the correct lib (#205542)
Depending on system setup, the unit tests could not find the just built
libLLVMOffload.so. Set the BUILD_RPATH to make sure they correctly use
the library from the current build.
[libc++] Move _LIBCPP_CONCAT{,3} to <__configuration/utility.h> (#205533)
The macro is already used in `<__configuration/attributes.h>` and just
happens to work because we include both headers.
`<__configuration/utility.h>` seems like the obvious place to put the
macros.
[clang][test] Use `FileCheck` in `Rewriter/objc-modern-getclass-proto.mm` (#204272)
The test had `CHECK` directives that were never executed because no
`RUN` line invoked `FileCheck` on the output.
The test also used a fragile runtime, which invoked the fragile rewriter
instead of the modern one the test was written for.
Switch to a non-fragile runtime so the modern rewriter runs as the test
intended.
Extend multicast router counter.
ip_mforward() contained a static variable that poorly implements a
rate limited log message. Replace the log with a counter, which
is MP-safe.
Also count drops due to time-to-live and hop-limit. As the default
ttl is 1, this is the most common pitfall when configuring a multicast
router. This counter helps debugging.
OK claudio@ deraadt@
[LV] Vectorize uncountable early exit store loops with combined conditions
Support the case where both the countable and uncountable exit conditions
have been combined by earlier passes.
[flang][OpenMP] Lower task reduction modifier (#205124)
Adds Flang lowering and MLIR-to-LLVM IR translation support for the
OpenMP `task` modifier on reduction clauses for `parallel`,
`do`/`wsloop`, and `sections`.
Unsupported forms remain diagnosed/TODO-gated rather than silently
lowered.
Fixes #205123.
[NFC] use DenseMap/SmallPtrSet in CacheMetrics and TailDupli… (#205480)
…cation
Swap pointer-keyed std::unordered_map/std::set for their ADT equivalents
on hot paths.
