devel/got: update to 0.131
User-visible changes:
- remove support for .cvsignore files
- always print a tab after the file name in unidiff headers, for Larry patch(1)
[flang-rt] Consume the whole field in B/O/Z input (#238057)
EditBOZInput reads a fixed-width field twice: the first pass counts the
significant digits, then it rewinds to the first significant digit and
the second pass decodes exactly that many digits. Nothing moved the
position back to the end of the field afterwards, so the next edit
descriptor started reading right after the last significant digit:
s = '1F XY'; read (s, '(z6,a2)') i, c ! c was ' ', not 'XY'
s = '1f,2'; read (s, '(z4,i2)') i, j ! j was 0, not 2
The second pass also called GotChar() again for each character it
re-read, so READ(SIZE=) counted the significant digits twice (8 instead
of 6 for '(z6)' on ' 1F ').
Record the position reached at the end of the first pass, which is past
any trailing blanks and any separator that ended the field early, and
return to it after decoding. Undo the SIZE= count of the re-read
characters.
[8 lines not shown]
[dsymutil] Ignore relocations into DWARF sections (#242508)
With relocatable DWARF on Mach-O, a relocation from one DWARF section
into another holds an offset into the target section. dsymutil looked
these up in the debug map as object addresses, so an offset that
happened to equal a symbol's address was overwritten with that symbol's
linked address, breaking DW_FORM_ref_addr references.
Skip relocations whose target is a __DWARF section.
Four parallel-linker ODR tests depended on the old behavior. Their
hand-written objects carry a relocation into __debug_abbrev that exists
only so dsymutil sees a valid relocation and links the object; it
resolved to the debug-map symbol by accident. Make it an extern
relocation against that symbol instead.
rdar://192719765
Assisted-by: Claude
Reject "/" in nvmet NQNs and guard configfs entry names
NQNs are used as directory names below /sys/kernel/config/nvmet, but
validation only checked the part before the first colon, so a hostnqn
or subnqn (or a subsystem name used to generate one) containing "/.."
could create entries outside of it.
Reject "/" and control characters in NQNs, validate subnqns generated
from the subsystem name, and check that each name is a single entry
before the kernel render uses it in a path.
[Remarks] Return the error when the bitstream parser cannot enter a block (#242616)
`BitstreamBlockParserHelperBase::enterBlock` tested the `Error` from
`BitstreamCursor::EnterSubBlock` as a boolean and never consumed it. A
container that ends right after a block header makes `EnterSubBlock`
fail, and a build with `LLVM_ENABLE_ABI_BREAKING_CHECKS` then aborts
with "Program aborted due to an unhandled Error" instead of reporting a
parse error.
`enterBlock` now returns the error from `EnterSubBlock`, as the other
bitstream readers do. The new test cuts a container written by the
serializer after every 32-bit word and expects each prefix to fail.
Without the fix it aborts in a build with ABI-breaking checks.
Assisted-by: Claude Code (Claude Fable 5.2)
Reject "/" in nvmet NQNs and guard configfs entry names
NQNs are used as directory names below /sys/kernel/config/nvmet, but
validation only checked the part before the first colon, so a hostnqn
or subnqn (or a subsystem name used to generate one) containing "/.."
could create entries outside of it.
Reject "/" and control characters in NQNs, validate subnqns generated
from the subsystem name, and check that each name is a single entry
before the kernel render uses it in a path.
CGExprCXX: emit family and allockind attributes
This allows us to remove the special knowledge about C++ allocation from
LLVM's MemoryBuiltins.cpp, instead trusting attributes to communicate
the important properties.
Annoyingly, clang has to grow a little bit of hard-coded knowledge about
mangled symbol names in order to actually get the most-basic-matching
::operator::new when working out the alloc-family attribute. I spent
some time trying to do this "right" by looking up the available
operators new and finding the best one, but that's super tricky and this
has the virtue of working and being pretty obviously correct when
compared to the old code.
Happily, clang now emits allocator family attributes for custom
allocators like the `__hot_cold_t` overloads in `new_hot_cold.cpp`
(which `isReplaceableGlobalAllocationFunction` in clang recognizes),
allowing us to remove that special knowledge from LLVM.
[7 lines not shown]
clang: emit allocalign to LLVM for alloc_align attributes
LLVM is growing knowledge of this, so we should inform it when we have
the information available. As a bonus, since we now check return
alignments in the callee as of an earlier patch of mine, we can now drop
the redundant llvm.assume() that this previously emitted.
This patch is originally from 2023 and was rebased and revised with
assistance from an LLM. I have manually reviewed the diffs to the
limit of my abilities (I don't do much in LLVM, and this is my first
time touching clang in a meaningful way) and they appear sensible. The
commit messages are entirely written by me.
Differential Revision: https://reviews.llvm.org/D119271
SimplifyLibCalls: preserve allocation attributes in optimizeNew
When `LibCallSimplifier::optimizeNew` rewrites an `operator new` call into a
`__hot_cold_t` allocation call, forward the allocation attributes
(`allockind`, `allocsize`, `"alloc-family"`, and parameter `allocalign`) from
the original call onto the synthesized call instruction alongside its metadata.
This is a new patch since 2023 (unlike most of the rest of the stack)
and allows the next patch to remove more specialized C++ knowledge
from the LLVM layer, instead leaving it in clang where it seems more
sensible.
This patch was authored with the assistance of an LLM and was reviewed
by me before posting.
clang: also check alloc_align and assume_aligned claims in return
Prior to this patch, we only check alloc_align and assume_aligned claims
in the caller. We are about to thread alloc_align information down into
LLVM, which would then have a chance to defeat the sanitizer checks by
performing optimizations. To avoid that, we also check alignment claims
in the called function prior to return.
Per review feedback on D121629:
- Also verify the alignment required by `AssumeAlignedAttr` in
`EmitReturnValueCheck`.
- Add a new `ReturnAlignmentAssumption` (`return_alignment_assumption`)
sanitizer handler in clang and compiler-rt that accepts the dynamic
return statement `SourceLocation` pointer loaded from `ReturnLocation`.
- Only emit the sanitizer check (and not a redundant `llvm.assume`) in
`EmitReturnValueCheck`.
This patch is originally from 2023 and was rebased and revised with
assistance from an LLM. I have manually reviewed the diffs to the
[5 lines not shown]
[NFC] clang: simplify emitAlignmentAssumptionCheck
Move the alignment check condition (`ptrtoint`, optional offset subtraction,
mask, and `icmp eq 0`) into `CodeGenFunction::emitAlignmentAssumptionCheck`
and emit the sanitizer check before `Builder.CreateAlignmentAssumption`.
This removes the need to pass `TheCheck` and `Assumption` into
`emitAlignmentAssumptionCheck` (or temporarily unlink and re-insert
`Assumption`) and prepares `emitAlignmentAssumptionCheck` to be called
directly without an accompanying `@llvm.assume`.
This patch is new since this line of work was originally authored in
2023. It was largely written by an LLM in response to review feedback
for the next patch, but I hand-reviewed the content and it looks
reasonable enough (with the same disclaimer as other patches that I
know nothing about clang.)
CodeGen: hand assume_aligned tests to the care of update_cc_test_checks (#239726)
My previous change already landed upstream for the two alloc_align
tests. Since a later patch's review feedback requested also checking
AssumeAlignedAttr in EmitReturnValueCheck, convert the two corresponding
assume_aligned tests (and refresh the alloc_align tests) using
update_cc_test_checks.py first so that the functional changes in the
next patch are obvious.
This patch is originally from 2023 and was rebased and revised with
assistance from an LLM. I have manually reviewed the diffs to the limit
of my abilities (I don't do much in LLVM, and this is my first time
touching clang in a meaningful way) and they appear sensible. The commit
messages are entirely written by me.
Differential Revision: https://reviews.llvm.org/D152400
[lld][MachO][NFC] Make DylibFile::numReferencedSymbols atomic (#243209)
This is part of the ld64.lld performance improvements tracked by #222068
and #238939.
Referencing/unreferencing symbols from the same dylib needs to be thread
safe for parallel sharded symbol-table insertion.
[CIR] Mark vtables unnamed_addr when their address is insignificant (#239708)
Port classic codegen's vtable unnamed_addr rules to CIR:
* A vtable is marked unnamed_addr when no RTTI is emitted, since nothing
(e.g. dynamic_cast) relies on its address.
* On targets that may duplicate weak vtables, a weak vtable is marked
unnamed_addr even with RTTI.
AI help was used for this PR description and the commit itself.
Especially in testing.
---------
Co-authored-by: Claude Opus 5.5 <noreply at anthropic.com>
www/{nginx,nginx-devel,freenginx}: 3rd-party modules management
Build the mogilefs, push_stream, rtmp, tarantool and upstream_check
modules from their own source ports. The patches the mogilefs and
upstream_check sources needed live with those sources now, and the
tarantool config finds yajl and msgpuck through a feature test instead
of a patched path.
Sponsored by: Netzkommune GmbH
www/nginx-module-auth-pam: Update to 1.6.1
Fix the faults on the auth_pam_set_pam_env path: a request without a
Host header took the worker down, the buffer for a PAM environment
entry was a byte short of what was written into it, and a failed
pam_set_item left the transaction open.
Sponsored by: Netzkommune GmbH
www/nginx-module-geoip2: Update to 3.4.2
Fix the faults the sanitizers found, in the stream module as well as
the http one: a uint128 field wrote past its allocation on every
lookup, its byte-array form read no argument at all, a directive line
with one word read beyond the arguments it had, and auto_reload kept
the lookup cache pointing into the file it had just closed.
Bump epoch because of the versioning schema change.
Sponsored by: Netzkommune GmbH
www/nginx-module-tarantool: Add New Port
The tarantool module talks to a Tarantool database over its binary
protocol and exposes it as a REST or JSON-RPC endpoint, translating
between JSON on the HTTP side and msgpack on the database side.
yajl and msgpuck come from the system.
www: https://github.com/sysadmin-labs/nginx-tarantool-module
Sponsored by: Netzkommune GmbH
www/nginx-module-ajp: Update to 0.3.2
Resolve the merge conflicts the sources carried, and read the second
byte in the AJP message helper where one was added to the first.
Add LICENSE_FILE, the sources carry the terms as a file now.
Sponsored by: Netzkommune GmbH
www/nginx-module-rtmp: Add New Port
The RTMP modules turn nginx into a streaming server: they take a live
stream in over RTMP, relay it, record it, and serve it again as HLS or
MPEG-DASH. A statistics and a control endpoint are served over HTTP.
www: https://github.com/sysadmin-labs/nginx-rtmp-module
Sponsored by: Netzkommune GmbH
www/nginx-module-upstream-check: Add New Port
The upstream_check module adds active health checks to nginx upstreams:
nginx probes each backend on a timer and takes a failing one out of the
balancer before a request lands on it.
Unlike the other module ports this one also ships the patches for nginx
itself, one per server flavour, because the check state has to reach
every balancer and stock nginx offers a module no way in.
www: https://github.com/sysadmin-labs/nginx-upstream-check-module
Sponsored by: Netzkommune GmbH
www/nginx-module-push-stream: Add New Port
The push_stream module delivers server push out of nginx: a message
published into a channel over HTTP reaches whoever is subscribed, as
long polling, as an EventSource stream or over a WebSocket. The
channels live in nginx's own shared memory, so there is no broker beside
it.
www: https://github.com/sysadmin-labs/nginx-push-stream-module
Sponsored by: Netzkommune GmbH
www/nginx-module-mogilefs: Add New Port
The mogilefs module turns nginx into a MogileFS client: it asks a
tracker where a key lives and hands the answer to proxy_pass, so nginx
serves the file straight from the storage node that holds it. Writing
and deleting through the tracker work as well, and the copies a tracker
names beyond the first are available as variables.
www: https://github.com/sysadmin-labs/nginx-mogilefs-module
Sponsored by: Netzkommune GmbH