remove activate_extents — bind_alua handles vdisk file open
activate_extents wrote active=1 to each vdisk's sysfs attribute during
failover, intending to reopen the dev_vdisk file handle. With
bind_alua_state=1 (the SCST default for vdisk_blockio) that open is
already handled drain-free by the bind_alua _finish callback when
set_node_optimized transitions the target group to OPTIMIZED.
Writing to the active sysfs attribute instead goes through
vdev_sysfs_process_active_store, which calls scst_suspend_activity(90s)
— a global SCST drain.
Remove the activate_extents job and its associated instance variable
and wait block. The dev_vdisk file handle lifecycle is now owned
entirely by bind_alua.
[MLIR] Fix -Wunused-but-set-variable
Use a void cast given [[maybe_unused]] is a C23 extension and this is a
C file. The calls also have side effects so it does not make sense to
inline into the assertions.
[Support] [Windows] Silence warnings about anonymous unions (#188534)
When building in mingw mode with Clang, we currently get the
following warnings:
llvm-project/llvm/lib/Support/Windows/Path.inc:1720:5: warning: anonymous types declared in an anonymous union are an extension [-Wnested-anon-types]
1720 | struct {
| ^
llvm-project/llvm/lib/Support/Windows/Path.inc:1728:5: warning: anonymous types declared in an anonymous union are an extension [-Wnested-anon-types]
1728 | struct {
| ^
Since these declarations mirror parts of the Microsoft SDKs, we
don't want to deviate from it needlessly; instead add a pragma
to silence this diagnostic for this specific area.
[lldb] [windows] Fix warnings in ConnectionConPTYWindows (#188528)
This fixes the following warnings, when building in mingw mode:
llvm-project/lldb/source/Host/windows/ConnectionConPTYWindows.cpp:47:7: warning: field 'm_pty' will be initialized after base 'ConnectionGenericFile' [-Wreorder-ctor]
47 | : m_pty(pty), ConnectionGenericFile(pty->GetSTDOUTHandle(), false) {};
| ^~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| ConnectionGenericFile(pty->GetSTDOUTHandle(), false) m_pty(pty)
llvm-project/lldb/source/Host/windows/ConnectionConPTYWindows.cpp:47:74: warning: extra ';' outside of a function is incompatible with C++98 [-Wc++98-compat-extra-semi]
47 | : m_pty(pty), ConnectionGenericFile(pty->GetSTDOUTHandle(), false) {};
| ^
[lldb] Disallow SHARED_BUILD_TESTCASE for non-default self.build() (#188523)
Change `self.build(...)` to assert if called with arguments of any kind,
for tests which have `SHARED_BUILD_TESTCASE` enabled (the default).
This also changes all tests that began asserting with this change, tests
which call `self.build(...)` with arguments.
---------
Co-authored-by: Adrian Prantl <adrian.prantl at gmail.com>
[lldb] [windows] Fix warning about unused static functions (#188531)
This fixes warnings about unused static functions, if building without
LLDB_PYTHON_DLL_RELATIVE_PATH defined.
These two static functions are only used by the non-static function
AddPythonDLLToSearchPath below; include them in the ifdef enclosing it.
[SandboxVec] Fix -Wunused-variable
Mark it [[maybe_unused]] given it is only used if assertions are enabled
(i.e., NDEBUG is not defined). We don't inline it given the variable
being named provides tangibly more information to the reader.
pmc: Fix copyright in previous commits
Fix the copyright attribution to Netflix and the date and missing SPDX
line in pmc.ibs man page.
Sponsored by: Netflix
Reviewed by: imp
Pull Request: https://github.com/freebsd/freebsd-src/pull/2094
[DirectX] Handle byte type in DXILBitcodeWriter (#187157)
The byte type was introduced to LLVM IR in #186888. DXILBitcodeWriter
needs to handle this type by generating valid LLVM 3.7 era bitcode,
which is as simple as treating byte equivalently to an integer.
[libc][docs] Add guide for implementing a function (#188499)
Added implementing_a_function.rst providing a checklist for adding a new
function to LLVM-libc.
Updated dev/index.rst to include the new guide in the toctree.
[libc][math] Switch log1pf to use the same log_eval from inverse hyperbolic functions. (#188388)
- Switch log1pf to use the same log_eval from inverse hyperbolic
functions.
- Optimize log_eval to use the same range reduction scheme as double
precision log
- Reduce the table size needed for log range reduction.
- This lower the overall latency of log1pf and inverse hyperbolic
functions.
[DAG] Define computeConstantRange for VSCALE folding (#176027)
Resolves #175150
Defines computeConstantRange and computeConstantRangeIncludingKnownBits
in the SelectionDAG. Currently only handles `ISD::VSCALE` operation
related to #174708.
Test cases were constructed to test varying VSCALE ranges on AArch64.
Further testing can be implemented as needed by review.
[TargetLowering] Use APInt::setAllBits() instead of assigning -1. (#188566)
The -1 has 'int' type. The APInt assignment operator takes uint64_t.
Fortunately, due to C rules, the -1 will be converted to an all ones
uint64_t. Unfortunately, if the APInt has more than 64 bits, the upper
words will be zeroed. I don't think we have any testing of that today.
Use setAllBits to avoid the subtle cast and fix the bits > 64 issue.
K still has its own issue that needs to be fixed.
