initrd: Fix cryptsetup and tcplay rescue programs
My previous rescue.libcrypto merge commit
(250a8b4928d6d15bd3909848d72a595025c798b9) introduced a regression and
broke cryptsetup/tcplay. For example,
```
$ sudo /rescue/cryptsetup isLuks /dev/zero
ioctl deps call failed: No such file or directory
Cannot initialize device-mapper. Is dm kernel module loaded?
```
This was caused by that the libdm.a's symbols were hidden by
libdevmapper.a, which appeared before libdm.
To solve this conflict, separately link libdm.a for cryptsetup/tcplay,
and remove -ldm from the final link command, so there is no symbol
hiding problem.
[5 lines not shown]
initrd: Separate 'depend' and 'all' stages and chain with '&&'
Although the current makefile works, separate them to avoid races
between the 'depend' and 'all' stages to be future-proof.
bsd.crunchgen.mk: Fix crunchgen multiple exec issue in parallel mode
crunchgen(1) outputs three files:
OUTPUTS=${OUTMK} ${OUTC} ${PROG}.cache
In parallel mode (-jN), the ${OUTPUTS} target previously caused the
rules to be executed three times (if N>=3).
Fix this issue by introducing a cookie file and route the rules through
it to build the outputs.
Mix bits in FileID::getHashValue() (#224654)
FileID's identity hash was fine under DenseMap's old quadratic probing,
but #200595 switched DenseMap to linear probing with backward-shift
deletion. FileID's bucket index under an identity hash is just its low
bits, so two runs of file IDs can map to the same buckets, which can
turn into a long clustered probe chain under linear probing.
Multiply by 37 to spread the low bits, which matches
SourceLocation::getHashValue(). This fixes a 2.6x compile-time
regression observed with -Wdocumentation on an ObjC++ file.
Reapplies #223794, which was reverted because it broke tests in
clang/test/Analysis/html_diagnostics. It is safe to reapply now that
#224510 fixed the underlying issue.
rdar://187026883
Co-authored-by: Fred Riss <friss at apple.com>
[clang][SYCL] Implement address space attributes for SYCL (#200849)
This PR adds SYCL address space attributes. These attributes are
intended for use in the implementation of SYCL run-time libraries and
should not be used in any other context.
The following attributes were added - [[clang::sycl_private]],
[[clang::sycl_global]], [[clang::sycl_local]], [[clang::sycl_constant]]
and [[clang::sycl_generic]]. These correspond to the five address spaces
described by SYCL 2020 section 3.8.2, "SYCL device memory model" and
SYCL 2020 section 4.7.7, "Address space classes".
Assisted by Claude
---------
Co-authored-by: Tom Honermann <tom at honermann.net>
[CIR] Preserve padding bytes across a byval argument
Fill the byval slot at the call site, and the parameter's own slot in
the callee, with a copy from the object's address rather than a store
of a loaded record value. A store writes only the fields of the
record's type and leaves its padding unwritten, which for a union can
be another member's live data. A _BitInt keeps its load and store,
since those are its conversion to and from memory.
Assisted-by: Cursor / claude-opus-5
Pull up following revision(s) (requested by jdc in ticket #466):
sys/dev/i2c/adt7462reg.h: revision 1.1
sys/dev/i2c/adt7462.c: revision 1.1
sys/dev/i2c/files.i2c: revision 1.138 (patch)
sys/dev/i2c/nxp75areg.h: revision 1.1
sys/dev/i2c/lm95221.c: revision 1.1
sys/dev/i2c/nxp75a.c: revision 1.1
sys/dev/i2c/lm95221reg.h: revision 1.1
Add a driver for the Texas Instruments LM95221 temperature sensor.
The chip is used in the Sun Ultra 45.
Add a driver for the NXP LM75A temperature sensor.
The chip is used in the Sun Ultra 45.
Note, that this is not the same as the TI LM75A temperature sensor (lmtemp).
[7 lines not shown]
Pull up following revision(s) (requested by jdc in ticket #465):
sys/arch/sparc64/sparc64/autoconf.c: revision 1.248
sys/arch/sparc64/sparc64/autoconf.c: revision 1.249
sys/arch/sparc64/sparc64/ofw_patch.c: revision 1.11
sys/arch/sparc64/sparc64/ofw_patch.h: revision 1.6
sys/arch/sparc64/sparc64/autoconf.c: revision 1.250
sys/arch/sparc64/sparc64/autoconf.c: revision 1.251
sys/arch/sparc64/sparc64/autoconf.c: revision 1.252
- all via patch
Fix up PROM's where reg is encoded as a 64-bit and a 32-bit value
(e.g. 00000400 0fc62020 00000010), but we want 2 x 64-bit values.
U45 with OBP 4.21.2 has jbus-i2c configured like this.
fix the build.
More corrections...
[21 lines not shown]
[flang] Mark visible Cray pointer associations as aliasing (#221350)
A visible Cray pointer association (ptr = loc(x) in the same procedure)
can alias x and the pointee. Flang treated them as no-alias and
miscompiled some codes at -O2.
-funsafe-cray-pointers is too broad. Instead, lowering now marks x as
TARGET for that procedure so later FIR passes (including TBAA) see the
aliasing. Default behavior: no-alias is unchanged.
[BoundsSafety][test] Add late-parsed counted_by type-attribute coverage
New tests exercising the late-parse fill-in mechanism:
- Sema/attr-counted-by-weird-type-positions{,-late-parsed}.c: counted_by
in assorted type positions, nested pointers, and rejection cases.
- Sema/attr-bounds-safety-function-ptr-param.c: attributes on
function-pointer-typed members.
- Modules/ and PCH/ bounds-safety-attributed-type-late-parsed: the
resolved type round-trips through serialization.
- Sema/attr-counted-by-late-parsed-regressions.c: guards against the
double-free on a nested-record decl-spec attribute and the null-count
escape on a free-function parameter.
[BoundsSafety] Create incomplete counted_by types and wire up the refill
Activate late parsing for the counted_by family (counted_by / sized_by and
their _or_null variants) in type-attribute position, under
-fexperimental-late-parse-attributes, on top of the type-attribute handling,
the validation helper and the refill machinery added in the previous commits.
When such an attribute is seen during type construction and its argument
can't be resolved yet, build the CountAttributedType immediately with
getIncompleteCountAttributedType and record it against the enclosing record;
its count expression is filled in at the closing brace via the refill logic.
Because enclosing types refer to the node by pointer, completing it in place
leaves the type chain untouched -- no rebuild, no TypeLoc re-emission.
- Sema::ActOnLateParsedTypeAttr builds the incomplete node; the parser
callback stores it on the LateParsedTypeAttribute and records the
attribute in the record currently being parsed.
Parser::CompleteLateParsedTypeAttributes drains that list at the closing
brace; a nested anonymous record hands its pending attributes up to the
[9 lines not shown]
[BoundsSafety] Handle the counted_by family as a type attribute
counted_by / sized_by (and their _or_null variants) were handled in only one
way: a declaration-position attribute went through handleCountedByAttrField,
which validated it and then patched the field afterwards with
FieldDecl::setType. There was no type-position handling at all.
Build the type during type construction instead, from a single handler that
serves both positions:
- Add HandleCountedByAttrOnType and dispatch the counted_by family to it
from processTypeAttrs, going through the shared
validateBoundsAttrTypeForTypePosition leaf.
- Remove handleCountedByAttrField. Its FieldDecl-based type-shape checks in
Sema::CheckCountedByAttrOnField are superseded by
Sema::ValidateBoundsAttrTypeShape, added in the previous commit and now
reached from the type path, and are deleted; no diagnostic is dropped. The
checks that genuinely need the FieldDecl (union member, non-flexible
array, cross-struct count) stay in CheckCountedByAttrOnField and run from
[11 lines not shown]
[BoundsSafety][NFC] Thread a late-parsed attribute list through declarators
A late-parsed type attribute is written in the middle of a declarator, so the
list it lands in has to travel with the declarator pieces until the enclosing
record can supply its argument. Add that storage and plumbing, with nothing
producing or consuming it yet:
- Move CachedTokens and LateParsedAttrList earlier in DeclSpec.h so DeclSpec,
Declarator and DeclaratorChunk can hold one.
- Give DeclSpec, Declarator and DeclaratorChunk a LateParsedAttrList, and let
Declarator::AddTypeInfo carry one onto the chunk it appends.
- Give ParseSpecifierQualifierList and ParseTypeQualifierListOpt an optional
LateParsedAttrList parameter, passed down to ParseDeclarationSpecifiers.
No functional change: the lists stay empty and no caller passes one. The next
commit populates them.
[BoundsSafety][NFC] Add the Sema/Parser bridge for late-parsed type attributes
A late-parsed bounds attribute has to build its type when the attribute is
seen, but its argument isn't parseable until the enclosing record is complete.
Building that type needs the Parser (which owns the cached tokens) and Sema
(which owns type construction) to meet:
- Sema::ActOnLateParsedTypeAttr validates a counted_by-family attribute for
the type position and, if valid, wraps the type in a CountAttributedType
whose count is not yet known, handing the node back for completion.
- Parser::ProcessLateParsedTypeAttrCallback is the Parser-side entry point,
registered on Sema so Sema can call back without including Parser.h (the
same pattern as LateTemplateParserCallback). It reuses an already-built
node so several declarators sharing one attribute share one type.
No functional change: nothing records late-parsed type attributes yet, so the
callback is never invoked. The next commit wires it up.
[BoundsSafety][NFC] Add counted_by type-shape validation helper
Introduce the single "is this type valid for a counted_by-family attribute in
type position" leaf that both the eager type-attribute path and the
late-parsed path will call:
- Sema::ValidateBoundsAttrTypeShape holds the type-shape checks -- pointer
or flexible array member, void and function pointee, pointee that is a
struct with a flexible array member -- and their diagnostics.
- validateBoundsAttrTypeForTypePosition wraps it for type position and adds
the nested-pointer rejection, reported with the new
err_counted_by_on_nested_pointer diagnostic.
Supporting pieces: Sema::BoundsAttrFlags and Sema::getBoundsAttrKind,
getCountAttrKind, getPointerNestLevel, the CountedByInvalidPointeeTypeKind
enum, and LangOptions::hasBoundsSafetyAttributes(), a stub returning false so
the shared leaf can gate its -fbounds-safety-only branches with the same
predicate used downstream.
[2 lines not shown]
[X86] Fix `FastISel` crash on `GEP` with a constant index wider than `64` bits (#223432)
Fixes #220954
When FastISel folds a GEP into an X86 addressing mode, it reads each
constant index with `getSExtValue()` and adds it to the displacement.
That call asserts if the constant has more than 64 significant bits, so
a `getelementptr` with an `i128` index of `2^64` feeding a legal-typed
load crashes at `-O0`. The LangRef says a GEP index is sign-extended or
truncated to the pointer width, and both generic FastISel and
SelectionDAGBuilder already do exactly that (added in 2015 for this same
assertion). The X86 address folder was the one GEP lowering that never
got the same treatment.
The index is now truncated to 64 bits before it is folded, mirroring
`FastISel::selectGetElementPtr`. For the reproducer the index becomes
zero and the load addresses the alloca directly, which is also what
SelectionDAG produces for the same IR. The other integer conversions in
`X86SelectAddress` are already safe: struct indices are
verifier-enforced `i32`, and the folded-add and `Add` paths only match
values whose type already equals the pointer width.
Turn off ZVOL threading for NVMe-oF namespaces
Mirrors the existing iSCSI behavior: disable multi-threading on a zvol
while it's exposed as an NVMe-oF namespace, and restore it afterward.
Add test__zvol_namespace_volthreading
