Improved MSVC diagnostics, fixed some bugs identifier by (sigh) claude.
LLM usage:
Depressingly claude actually did something right:
- Identified align_val_t being cached alongside size_t was likely
unsound, which was easy enough to create a test for.
- It also noted that tryBuildStdTypeIdentity could be reentrant,
and was able to construct a test case when i could not. That is
now test #5 in type-aware-new-invalid-type-identity.cpp.
An invalid type_identity defined as:
```cpp
template <class T> struct type_identity {
using type = decltype(new T);
};
```
triggers re-entrant evaluation of getTypeIdentityArgument
invalidating the insertion slot.
Improved MSVC diagnostics, fixed some bugs identifier by (sigh) claude.
LLM usage:
Depressingly claude actually did something right:
- Identified align_val_t being cached alongside size_t was likely
unsound, which was easy enough to create a test for.
- It also noted that tryBuildStdTypeIdentity could be reentrant,
and was able to construct a test case when i could not. That is
now test #5 in type-aware-new-invalid-type-identity.cpp.
An invalid type_identity defined as:
```cpp
template <class T> struct type_identity {
using type = decltype(new T);
};
```
triggers re-entrant evaluation of getTypeIdentityArgument
invalidating the insertion slot.
math/py-pytanque: Fix build on 16
... by patching no longer valid C++ code.
Reported by: fallout
(cherry picked from commit 3a377391af47a9e4e4e91a1b81bc84f3e40c7945)
[lldb] Include `Debugger.h` in `ScriptedCommandPythonInterface.cpp` (NFC) (#212662)
Commit c35bdc99a36b passes a `lldb::DebuggerSP` to the
`ScriptedPythonInterface` base template, whose `Transform` overload is
constrained on `std::is_base_of_v` and so needs `Debugger` to be
complete. This patch includes `lldb/Core/Debugger.h` since the
translation unit only saw the forward declaration.
Signed-off-by: Med Ismail Bennani <ismail at bennani.ma>
mt76: mt7921: update man page
Adjust the man page to what other LinuxKPI wlan man pages say and look
like as it has been a while since I wrote it. The man page is not yet
hooked up to the build on purpose as the driver is not yet enabled in
the tree.
Sponsored by: The FreeBSD Foundation
MFC after: 3 days
Reviewed by: ziaee (earlier version)
Differential Revision: https://reviews.freebsd.org/D58479
make-pkg-package.sh: Fix build for pkg 2.8.0
We used to pass CONFIGURE_ARGS to the make command which builds pkg,
but ports/ports-mgmt/pkg/Makefile has its own CONFIGURE_ARGS and the
version we were providing at the command line didn't contain the
--mandir setting which was added to the port with pkg 2.8.0. This
broke release builds.
Instead of passing --prefix=${LOCALBASE} via CONFIGURE_ARGS, pass
PREFIX=${LOCALBASE}; the port Makefile passes that value through to
its configure script. We also used to pass a --host parameter, but
that seems to have become unnecessary at some point in the past decade.
MFC after: 1 day
Sponsored by: Amazon
(cherry picked from commit 8d92f32ae011719b322b9943d01529cebef741f0)
[lldb/script] Migrate ParsedCommand & raw commands onto ScriptedPythonInterface (#210430)
Give both `command script add -c` (raw class) and `-p` (ParsedCommand) a
single, shared
`ScriptedCommandInterface`/`ScriptedCommandPythonInterface`, built on
the existing `ScriptedPythonInterface` machinery: `CreatePluginObject`
delegates to the base template, and every other method goes through
`Dispatch`.
Add a lighter `ScriptedCommand` ABC template (`scripted_command.py`) for
raw mode; the existing `ParsedCommand`/`LLDBOptionValueParser` classes
are kept as-is.
Extend `ScriptedPythonInterface` with a few `Transform` overloads
(`DebuggerSP`, `std::vector<std::string>`, `CommandReturnObject &`) so
those argument types route through `Dispatch` without extra plumbing.
Delete the standalone SWIG bridge functions this plugin was the sole
caller of. `CommandObjectScriptingObjectRaw` and
[6 lines not shown]
