[NFC][clang][Serialization] Fix std::set_difference sorting mismatch in ASTReader (#219053)
Fixes a `std::set_difference` sorting violation in
`ASTReader::checkTargetOptions` that causes a crash when building clang
with `LLVM_ENABLE_EXPENSIVE_CHECKS` on libstdc++.
`accumulateFeaturesAsWritten` sorts target features using a custom
comparator that strips the `+`/`-` prefix (i.e. comparing `A.substr(1) <
B.substr(1)`). However, `std::set_difference` was being called with the
default `std::string::operator<` comparator, which does not match the
sorting order because `+` (ASCII 0x2B) is less than `-` (ASCII 0x2D).
For example, `["-cx16", "+sse2"]` is correctly sorted according to the
custom comparator, but incorrectly sorted according to the default
lexicographical comparator.
This patch fixes the issue by passing the same custom comparator used
for sorting to both `std::set_difference` calls.
Fixes #219046.
[SLP]Trim combined nodes only at their roots
Combined subnodes were added to the trimming worklist as independent
candidates, carrying their descendants' aggregated costs. Trimming such
a subnode on its own deleted operands still referenced by the combined
root, producing instructions that no longer dominated their uses.
Skip CombinedVectorize subnodes in subtree-cost aggregation and worklist
construction so only combined roots are evaluated as trim candidates.
Fixes #218974
Reviewers:
Pull Request: https://github.com/llvm/llvm-project/pull/219095
[lsan][llvm-profdata] Suppress leak check on abnormal exit (#219088)
This is common issue with lsan after exit().
`exit()` is no return, we can't expect that compiler
will preserve pointers to allocations done by callers.
Fixes new build bot report after upgrading base compiler to clang 23.1.0
https://lab.llvm.org/buildbot/#/builders/169/builds/26007
It probably has improved stack or registers re-use.
[flang][docs] Mention --driver-mode=flang in FlangDriver.md (#207659)
This patch adds a description about the `--driver-mode=flang` flag.
The behavior will be ensured by #207658.
---------
Co-authored-by: Tarun Prabhu <tarunprabhu at gmail.com>
[compiler-rt][cmake] Change orc-rt target names (#216901)
When configured with `LLVM_ENABLE_RUNTIMES=compiler-rt;orc-rt`,
following two CMake errors occur.
```
CMake Error at llvm-project/llvm/cmake/modules/AddLLVM.cmake:2245 (add_custom_target):
add_custom_target cannot create target "check-orc-rt" because another
target with the same name already exists. The existing target is a custom
target created in source directory
"llvm-project/compiler-rt/test/orc". See documentation
for policy CMP0002 for more details.
Call Stack (most recent call first):
llvm-project/llvm/cmake/modules/AddLLVM.cmake:2326 (add_lit_target)
llvm-project/orc-rt/test/CMakeLists.txt:24 (add_lit_testsuite)
CMake Error at llvm-project/orc-rt/test/unit/CMakeLists.txt:1 (add_custom_target):
add_custom_target cannot create target "OrcRTUnitTests" because another
target with the same name already exists. The existing target is a custom
[10 lines not shown]
[SSAF][clang-reforge] Add end-to-end clang-reforge tests
- Make CppBoundedBuffers adapt to flattened WPA results;
- Let CppBoundedBuffers use qualified EntityNames so that it can
associate ASTNodes with WPA results;
- Add end-to-end tests
Final step of:
rdar://185840466
firefox153: import Firefox 153.1 as www/firefox153
Mozilla Firefox is a free, open-source and cross-platform web browser
for Windows, Linux, MacOS X and many other operating systems.
It is fast and easy to use, and offers many advantages over other web
browsers, such as tabbed browsing and the ability to block pop-up
windows.
Firefox also offers excellent bookmark and history management, and it
can be extended by developers using industry standards such as XML,
CSS, JavaScript, C++, etc. Many extensions are available.
Note: Due to upstream's trademark policies, this package identifies as
"Nightly" rather than "Firefox" by default.
This package provides Firefox 153 Extended Support Release.
Stop reusing sc_frequency as the workqueue arg. In 11.99.3 or so,
doing that wasn't a problem, but now it appears to be trouble doing
that. Just provide a dedicated variable. The argument doesn't really
matter to this use case, but it can't be something used for something
else either.
[SSAF] Fix stage-2 clang build error on TestTransformationPlugin
The plugin code defines the extern variable
SSAFTestTransformationAnchorSource, which is supposed to be used to
force static linking, so not needed here.
The variable definition should undoubtedly be removed, as doing so
solves the build issue locally. The explanation below regarding why
this variable causes the issue was provided by Claude. I repeatedly
asked Claude questions, and he revised his reasoning several times
until it became consistent. However, we should still take the
following explanation with a grain of salt:
ASan created a private alias symbol for the extern variable
SSAFTestTransformationAnchorSource. The linker, when in
'-flat_namespace' mode, treated the symbol as a name-based bind, which
later failed to be resolved through name searching by the loader.
rdar://185749574
[2 lines not shown]
[mlir][IR] Require inherent symbol attributes for Symbol operations (#218920)
Require SymbolTable operations to implement SymbolOpInterface and store
symbol names and visibility as inherent attributes.
Add missing symbol properties/interfaces to GPU, OpenACC, OpenMP, EmitC,
and Toy operations, and update affected tests and the GPU Python
builder.
Assisted-by: Codex
[LV] Support EVL for partial reduction and VPExpressionRecipe. (#205741)
This patch adds the support for partial reduction with EVL tail-folding
by not creating a new VPExpressionEVLRecipes but just changing the last
expressionRecipes from VPReductionRecipe to VPReductionEVLRecipe.
Currently, all partial reductions will be converted to
VPExpressionRecipe
when construction. So this patch also supports the VPExpressionRecipe
for EVL.
