docs: Add some best practices documentation for codegen tests
Document common review feedback.
Co-authored-by: Claude Opus 5.5 <noreply at anthropic.com>
[libc] Make find_first_character_impl return const void*
This means we only have to const_cast in one place instead of in all the
implementations and I find const_cast annoying.
Assisted-By: LLM
Reviewers: jhuber6, michaelrj-google
Pull Request: https://github.com/llvm/llvm-project/pull/244468
[libc] Add simd_bitmask type
Just a thin wrapper around internal::get_as_integer_type. This is nicer
than using an internal type outside of the library implementation in
inline_strlen.h. Putting this up given I plan on using it more for an
optimized memchr implementation.
Assisted-By: LLM
Reviewers: jhuber6, michaelrj-google
Pull Request: https://github.com/llvm/llvm-project/pull/244467
BPF: Fix removing the blocks after the start of an unwind (#242856)
BPFUnwindLower erased each dead block as soon as it unlinked it, so a
dead block that was a successor of a later one was used after being
freed. It also kept an address-taken block but not the blocks it
branches to, leaving a branch to an erased block.
Co-authored-by: Claude Opus 5.5 <noreply at anthropic.com>
[CIR] Enable AArch64 calling convention lowering in CIR (#244014)
This change enables CIR calling convention lowering for AArch64 targets
by default. Lowering for va_args functions, matrix types, and SVE types
is left to be implemented in future changes, so programs using these
features will fail to compile after this change. The
-fno-clangir-call-conv-lowering option can be used to preserve the old
behavior.
Some AArch64 built-in tests that already had optional CIR run lines had
to be modified to use the -fno-clangir-call-conv-lowering option when
the test uses types that are not yet handled in the CIR lowering. These
will be updated later as the type handling is completed.
Assisted-by: Cursor / claude-opus-5.5
[llvm-profgen] Defer merging a context until its caller has decided
The CS pre-inliner goes over functions in top-down order (callers before
callees). For each function it first calls getBaseSamplesFor(), which
merges every context of that function that no caller has inlined into
the function's base (top-level) profile. Only then does it decide which
callees to inline. That merge is only correct if every caller has
already made its decision. In a recursive SCC no order can guarantee
that, so a callee can be processed first and take contexts that its
caller would have kept inlined.
Repro:
https://godbolt.org/z/5853ev7Mb
The source is two mutually recursive functions:
extern "C" unsigned long arith(unsigned long n) {
...
[116 lines not shown]
[ValueTracking] Propagate demanded lanes through TRUNC in sign-bit queries (#244295)
Use the demanded lanes when computing the sign bits of the input.
This matches the behavior in SDAG.
Assisted by: GPT 6.1 Sol
arm64: Add MediaTek SoC support skeleton
Add the SOC_MEDIATEK and SOC_MEDIATEK_MT7986 options, list them in
NOTES, add std.mediatek, include it in GENERIC and in a MEDIATEK kernel
configuration, and add a DTB module that builds the Banana Pi BPI-R3
(MT7986A) DTB.
Reviewed by: mmel
Approved by: markj (mentor)
Sponsored by: Alchemilla Ventures Private Limited
Differential Revision: https://reviews.freebsd.org/D61186
clk/mediatek: Add common MediaTek clock and reset support
MediaTek SoCs split their clock tree over several controllers built from
the same blocks. Add a base driver that maps a controller's registers
and registers its table of clocks, and the node types the tables use:
- PLL with the MT7986 register layout: the rate is set by the
frequency control word and the post divider. A new control word is
only taken over when the PLL is enabled, so a running PLL is stopped
while its rate is changed, and a PLL that cannot stop keeps its rate.
Without a lock bit, a PLL that was never programmed cannot be told
from a stopped one, so the node has no gate: firmware starts the
PLLs, and a PLL that is off reports 0 Hz and cannot be set.
- Mux with an optional gate bit and an optional update latch, changed
by read-modify-write or, where the mux register is read-only,
through set/clear registers.
- Gate, changed in the same two ways.
Clocks of other controllers are linked clocks, so the registration order
[15 lines not shown]
uart: Add a flags field to struct uart_bas
uart_bus_probe() sets UART_BAS_IN_PROBE in it while the hardware driver
probes. The softc is then still a plain struct uart_softc, so code that
the probe method shares with attached devices can check the flag before
using the class specific fields.
No functional change.
Reviewed by: mmel
Approved by: markj (mentor)
Sponsored by: Alchemilla Ventures Private Limited
Differential Revision: https://reviews.freebsd.org/D61620
uart: Factor out the ns8250 baud rate generator code
Move the code that programs the divisor latch out of ns8250_param()
into ns8250_set_baudrate(), and the code that computes the rate from
it out of the UART_IOCTL_BAUD handler into ns8250_get_baudrate().
ns8250_get_divisor() now returns the input clock cycles per bit,
prescaler included, in units of 1 / NS8250_DIVISOR_SCALE, and the
rate, the delays and the rclk guess are derived from it. This leaves
room for other prescalers and for fractional dividers.
ns8250_delay() is now computed in 64 bits with one formula. The old
code split at a divisor of 134 to keep 16000000 * divisor within an int
(ebecffe93038), and above 134 divided by rclk / 1000 rounded down. With
a clock that is not a multiple of 1 kHz this made the delay longer by
(rclk % 1000) / (rclk - rclk % 1000): 0.011% with a 1.8432 MHz clock,
e.g. 20002 instead of 20000 us at 50 baud. Up to a divisor of 134 the
result is the same. The delay is only a polling interval for
ns8250_drain() and the FIFO size probe.
[7 lines not shown]
clk/mediatek: Add MT7986 INFRACFG clock and reset controller
INFRACFG provides the clock muxes and gates of the infrastructure
peripherals, and is their reset controller (the binding requires
#reset-cells). It attaches after TOPCKGEN.
The gate and mux status registers are read-only (checked on a Banana
Pi BPI-R3), so gates and muxes are changed through their set and clear
registers.
The resets come in three banks, each with an assert register, a deassert
register at +4 and a status register at +8. Reset id n is bit n % 32 of
bank n / 32. Bank 0 at 0x70 is the one MediaTek's TF-A uses for the
TRNG [1]. Banks 1 (0x80) and 2 (0x90) were found on a Banana Pi BPI-R3
by resetting known blocks.
The clocks follow the MT7986 drivers of Linux [2] and U-Boot [3], which
were used for hardware facts only, with two changes:
[19 lines not shown]
uart: Add MediaTek UART driver
The MediaTek UART is a 16550 with 32-bit spaced registers and a
fractional baud rate generator. The driver gives that generator to the
ns8250 code through its set_baudrate, get_baudrate and get_divisor
functions, and uses the ns8250 code for everything else. The low-level
console uses the ns8250 code too, so it keeps the rate the firmware set.
For the 30 MHz clock of Table 2-6 of the reference manual [1], the
divisor, SAMPLE_COUNT, SAMPLE_POINT and the number of extended bits are
the table's, except at 7200 baud, where one extended bit is closer than
the table's two. Rates that need fewer than 8 samples per bit are
rejected: below that, the manual requires guard time from the sender.
Probe enables the clocks while it runs, attach applies the assigned
clocks and enables them, and detach releases them. The console is
probed on the clocks the firmware left running and keeps its clocks on
detach. Until there is an MT7986 pinctrl driver, UART1 and UART2 rely
on the firmware's pin setup.
[9 lines not shown]
uart: Let ns8250 drivers provide their own baud rate generator
Add set_baudrate, get_baudrate and get_divisor function pointers to
struct ns8250_softc. A driver for a UART with a baud rate generator of
its own sets them before calling ns8250_bus_attach(), which sets the
ones left NULL to the 16550 functions. The param, ioctl, flush and
transmit methods use them, and ns8250_delay(), ns8250_drain() and
ns8250_flush() now take the softc to reach them.
While probing, the softc is not yet an ns8250_softc, so ns8250_delay()
uses the 16550 divisor when UART_BAS_IN_PROBE is set. The low-level
console code, which has no softc, also uses the 16550 functions.
No functional change for existing drivers.
Reviewed by: mmel
Approved by: markj (mentor)
Sponsored by: Alchemilla Ventures Private Limited
Differential Revision: https://reviews.freebsd.org/D61611
arm64/pmap: Ignore pmap_advise() for stage 2 pmaps
When vm_fault() handles a sequential fault that needs pager I/O, it
calls vm_fault_dontneed(), which passes MADV_DONTNEED to pmap_advise()
for the pages behind the fault. For vmm(4) guest memory the pmap is a
stage 2 pmap, so a guest that reads paged-out memory sequentially
panics an INVARIANTS kernel on the stage 1 assertion in pmap_advise().
MADV_DONTNEED and MADV_FREE are only hints, so ignore them for stage 2
pmaps.
Reviewed by: markj
Approved by: markj (mentor)
Sponsored by: Alchemilla Ventures Private Limited
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D61622
[VectorCombine] Fold deinterleave2 with smaller element size on big-endian (#243356)
The fold bailed out on big-endian targets because the vector bitcast
puts element 0 of the narrow vector in the high half of each wide
element there. The merge pattern that can be folded is therefore
mirrored: the low half of each merged element comes from the second
deinterleaved field. Swap the roles of the two fields when matching the
merge and swap the field indices of the newly created deinterleave
accordingly, so the fold applies to that mirrored pattern instead of
being disabled.
Fix comment:
https://github.com/llvm/llvm-project/pull/238626#discussion_r4483976228