CodeGen: Drop dead LiveVariables optional-analysis paths (#230147)
Nothing queries the LiveVariables analysis anymore, so remove uses that only
ran when the analysis was available. Remove the verifier handling and the
update in SplitCriticalEdge.
Co-authored-by: Claude (Opus 4.8) <noreply at anthropic.com>
[DAG] Explicitly truncate splat operand in get_active_lane_mask expansion
x86 can't handle the implicit truncation of build_vector operands so the whilewr_8 test case crashes after expanding get_active_lane_mask (stemming from llvm.loop.dependence.war.mask). Fix it by explicitly truncating it.
[DAG] Use getLegalMaskAndStepVector in expandGetActiveLaneMask
Currently we will either use the mask vector type if it's big enough to fit the elements, or promote the element width to the scalar operand type.
In the latter case we will end up with a vector element type larger than strictly necessary, which means a v32i1 mask will get promoted to v32i64 on RISC-V, which isn't a legal type, and expansion fails.
We can use a legal vector type that's just small enough via getLegalMaskAndStepVector, which is already used by expandVectorFindLastActive, expandCttzElts etc. This fixes crashes on RISC-V and also uses a more compact step vector. It also means we can handle scalable vectors.
We need to move the function into TargetLowering.cpp to use the getLegalMaskAndStepVector, but this brings it inline with the other expansions.
[clangd][test] Move plugin examples and CMake rules to plugins directory (#230260)
Move FeatureModuleExample.cpp and StandaloneTweakExample.cpp into the
clangd/test/plugins directory.
jail: define well-known parameter names in sys/jail.h
Userland jail managers hardcode jail parameter name strings; nothing
in the headers has ever named them, even when sys/jail.h already
has JAIL_META_PRIVATE/JAIL_META_SHARED for the metadata pair.
Added JAIL_PARAM_* string constants for the static parameters registered
by the base kernel.
No functional change.
MFC After: 1 week
Reviewed by: jamie, adrian
Differential Revision: https://reviews.freebsd.org/D59572
(cherry picked from commit 1256447cbc21361ff5a6f9022b58ad6c1c43e59f)
[clang][Sema] Reject lax vector conversions involving `x87` long double (#228192)
Fixes #173254
Fixes #63548
On x86, `long double` is an 80-bit x87 value stored in 16 bytes (12 on
i386). `Sema::areVectorTypesSameSize` compares storage sizes, so it
treated a one-element `long double` vector and a two-element `long long`
vector as the same size, and the lax vector conversion rules inserted a
`CK_BitCast` between them. LLVM gives `x86_fp80` a width of 80 bits, so
CodeGen created an invalid `bitcast` and hit the `castIsValid`
assertion. In #173254 the cast is on the argument of
`__builtin_ia32_aesenc128`; in #63548 it is on the `return`, where the
`__int128` vector produced by the comparison is converted back to the
`long double` vector.
`areVectorTypesSameSize` now returns false when exactly one of the two
element types is x87 `long double`, so these conversions are diagnosed
as incompatible types instead of reaching CodeGen. Conversions where
[2 lines not shown]
[CodeGen] Place unsplittable blocks after the profiled blocks in BB sections (#228173)
With a basic block sections profile, a block which is not in the profile
but is not safe to split (TargetInstrInfo::isMBBSafeToSplitToCold) stays
in the default section, which is cluster 0's section. The comparator
uses FuncClusterInfo.lookup(), which returns PositionInCluster 0 for
such blocks, so they are placed right after the entry block, in the
middle of the hot cluster.
Use find() in the comparator instead, so that blocks without cluster
information are placed after all the profiled blocks of the section, in
their original order. This keeps the profiled blocks of the hot cluster
contiguous.
Only AArch64 overrides isMBBSafeToSplitToCold (for asm goto and jump
tables), so only AArch64 is affected. On a large AArch64 workload built
with a Propeller profile, this changed the layout of about 100 functions
and was performance-neutral.
[lld][MachO] Support Objective-C class selector stubs
Support Objective-C class selector stubs in lld's Mach-O backend.
This consumes the class-stub symbols emitted by Clang in [ObjC] Emit class
msgSend stub calls (#186433), using the form
`_objc_msgSendClass$<selector>$_OBJC_CLASS_$_<class>`.
Class stubs load the class object into `x0`, load the selector into `x1`, and
branch to `_objc_msgSend`. Local class symbols are materialized directly with
`adrp`/`add`; dylib or dynamic class symbols are loaded indirectly.
The implementation also tracks the resolved class symbol before dead stripping
so live class stubs can retain the needed class definition without keeping dead
dylib references alive.
[flang][cuda] Mark __ldXX helper functions as intrinsic (#230201)
Set `fir.proc_attrs<intrinsic>` on the external helper declarations and
calls generated for `__ldca/__ldcg/__ldcs/__ldlu/__ldcv`, so they are
not treated as user procedures.
RuntimeLibcalls: Only provide fp128 sincosl when long double is fp128 (#230232)
LibmHasSinCosF128 provided sincosl for any target with sincos, so
llvm.sincos.f128 called sincosl on aarch64 MinGW and hexagon-*-gnu,
where long double is double. Require fp128 long double, and rename it
to LibmHasSincoslF128 to distinguish it from sincosf128.
Co-authored-by: Claude Opus 5.5 <noreply at anthropic.com>
[lld][MachO] Fix ObjC stubs from autolinked archives
Move ObjC stub preparation after LC_LINKER_OPTION processing so archive
members loaded through autolink can contribute `_objc_msgSend$` selector stubs
before selector references are finalized.
Otherwise, stubs discovered from autolinked archives may not get matching
`__objc_methname` and `__objc_selrefs` entries needed during stub emission.
Lower iterator ranges in the iterator's own type
Flang converted iterator bounds and steps to index before building
omp.iterator. An integer(16) range such as
9223372036854775807:9223372036854775809 therefore wrapped and produced no
dependences or affinity entries.
Convert begin and end to the iterator variable's type, and build each
range in the wider of that type and the step's type so that a large step
can't change direction. Translation counts each range one bit wider than
its operands, so wide kinds keep all their entries.
Lowering now relies on the iterator being an integer, so DEPEND
iterators get the same semantic checks as the other clauses that take an
iterator modifier. The range warnings in those checks now skip constants
wider than 64 bits, which they used to truncate.
[mlir][OpenMP] Allow multi-block omp.iterator regions
Flang lowers a locator inside an omp.iterator region like any other
expression, so the region can contain control flow. For example, LEN_TRIM
in `depend(iterator(i=1:n), in: a(i+len_trim(s)))` becomes a loop, and SUM
or COUNT get inlined as loops at -O1. After control-flow conversion the
region has several blocks, which omp.iterator rejects.
Allow the region to have several blocks. Exactly one of them ends in
omp.yield, and every other block branches within the region. Translation
keeps the single-block path; for multi-block regions it converts the
blocks in dominance order and reads the yielded value after the yield,
relying on createIteratorLoop's support for multi-block bodies.
Translation also used the i64 induction value for each region argument,
whatever its declared type, so passing an i32 argument to another block
gave a badly typed PHI. Rebuild each induction value in its range's
declared type, and verify that the region arguments match the ranges in
number and type.
[2 lines not shown]
Build iterator ranges in their widest type and reject vector-subscript affinity
OpenMP 5.2 does not convert begin and end to the iterator type for Fortran,
but lowering did, which could change which values a range contains. For
example, integer(1) :: i = 0:n:-1 with n = 256 wrapped to 0:0:-1, and
0:150:100 became the empty 0:-106:100. Build each range in the widest of the
iterator, begin, end and step types instead, and narrow only the induction
value.
Lowering iterator affinity locators through the ordinary path let vector
subscripts through: the bounds helper only reports a non-fatal error, so the
affinity record pointed at a freed temporary. Report vector subscripts in
AFFINITY as not yet implemented, with or without an iterator.
Also anchor the expected dependence counts in the empty-range tests so they
cannot match the trailing noalias count.
[mlir][flang][OpenMP] Select depend and affinity iterators per locator
Flang expands each iterator-dependent depend or affinity locator over all
ranges in the clause, including iterators absent from that locator. For
example:
depend(iterator(i=1:2, j=3:m), in: a(i))
When m < 3, the unused empty j range suppresses both required dependences
on a. This can lose task ordering. A nonempty unused range instead repeats
entries unnecessarily; affinity locators have the same expansion problem.
Select ranges according to the iterator identifiers appearing in each
locator's source, preserving declaration order. Making this change safely
also requires preserving source occurrences and handling empty ranges:
- Record resolved iterator references before using the folded expression
for lowering. In a(j/d + 0*i), folding removes 0*i, but an empty i range
must still suppress the locator and prevent evaluation of j/d.
[17 lines not shown]
Fix per-locator iterator lowering regressions
Reuse ordinary locator lowering inside depend and affinity iterators to
preserve component and vector-subscript dependence support. Keep locator
evaluation and temporary cleanup inside the iterator region so empty
selected ranges suppress evaluation. Preserve affinity section lengths.
Reject iterated dependences on unsupported target-data operations during
translation.
Bind source-occurrence checks to each locator's ranges and yielded value.
Add locator, wide-range, empty-range, and target-data diagnostic coverage,
plus locators whose lowering adds control flow to the iterator region
(LEN_TRIM, allocatable function results, and SUM inlined at -O1).
[Target][NFC] Use SmallPtrSet instead of SmallSet for pointers (#230002)
Use `SmallPtrSet` instead of `SmallSet` due to transparent switch for
pointer types anyway.
Similar to #154068.
