[BOLT] Fix code section ordering comparator (#216725)
## Summary
`RewriteInstance::getCodeSections()` used a comparator that violated
strict weak ordering:
- Distinct special sections with the same name could each compare less
than the other.
- Different cold sections could each be equivalent to an `Other` section
while remaining ordered relative to one another.
This replaces that comparator with `CodeSectionOrder`, which assigns
explicit ranks to section kinds and orders cold-section suffixes
deterministically.
## Main-branch reproduction
[49 lines not shown]
Interfaces: Assignments - add interface configuration settings in new assignments page. for https://github.com/opnsense/core/issues/10568 (#10740)
Refactor NetworkInterface model to reuse existing property names as much as possible, move from/to legacy logic into a custom fieldtype and store all legacy settings in a container named "pending" to ease reconfiguration and updating legacy configurations.
Skip wireless and other advanced settings for now, only implement a minimal set of validations.
[Flang][OpenMP] Stop emitting implicit mappers for allocatable derived types (and arrays of them) unconditionally (#216184)
We should not be emitting these implicit mappers at the top level if the
contents of the derived type do not require mapping of allocatables. If
we do this, we negatively impact performance with unneccessary maps, in
certain cases (array of structs) this can be quite significant.
[Clang][Sema] Fix crash on default argument added after a parameter pack (#217386)
Fixes #216211
The DR1344 check that runs next locates "the
first defaulted parameter" as `getParamDecl(getMinRequiredArguments())`,
which is wrong when a parameter pack comes first: the pack is skipped by
the count but still occupies a slot. The lookup lands on the pack and
`assert(NewParam->hasDefaultArg())` fails. Without assertions, the
"makes this constructor a default constructor" error is emitted pointing
at the wrong parameter.
The DR1344 check now scans for the first parameter that actually has a
default argument, so the assertion holds and the diagnostic points at
the right parameter.
LLM tools were used for this contribution.
Set unicast_src_ip for VRRP instances so IPv6 adverts are received
keepalived binds the unicast receive socket to the advert source address.
Without unicast_src_ip it uses the first address it learns on the
interface, which for IPv6 is the link-local address. The peer sends
adverts to our configured address, so they are never delivered and both
controllers become MASTER for every IPv6 VIP. IPv4 only worked because the
first learned address is normally the configured one. Set unicast_src_ip to
the address the peer is configured to send to for every instance.
epoch: Fix epoch_drain_callbacks()
This function is supposed to wait until all pending callbacks have been
executed. This is useful in some contexts where we tear down some
context (like a VNET jail and its associated UMA zones) synchronously,
and we want to make sure that all pending asynchronous callbacks (which
may free objects to said UMA zones) have run first.
The implementation schedules a callback on each CPU and waits for them
all to run. This assumes that, on a given CPU, callbacks are executed
in the order that they are pushed. This assumption depends on the
implementation of epoch_call_task() and ck_epoch_poll_deferred(), and it
is not true in general.
Callbacks are pushed onto a per-CPU stack in LIFO order.
ck_epoch_poll_deferred() first pulls out the callbacks from epoch - 2,
which are always safe to execute, and in so doing reorders them such
that the oldest callback as at the top of the stack, so in this case,
epoch_call_task() will execute them in order. However,
[26 lines not shown]
[VPlan] Sink single-scalar VPI to replicate regions (#208906)
The newly-introduced scalar-casts are sunk. The patch also generalizes
the existing special cases correctly using
vputils::doesGeneratePerAllLanes.
ctl.4: Document the assumption that CTL HA runs only on trusted networks
The CTL High Availablity clustering feature allows a pair of hosts to
implement transparent failover. The implementation uses a TCP
connection to exchange messages. There is no authentication mechanism
and the protocol itself embeds kernel pointers in the messages exchanged
between HA hosts. This property (of CTL_MSG_DATAMOVE messages
specifically), as well as insufficient validation of inbound messages,
mean that anyone able to access a CTL HA port is able to remotely
execute code on that host.
Provide a warning to this effect in the CTL man page.
Approved by: re (cperciva)
Reported by: Ryan of Calif.io
Reviewed by: ziaee, ken, mav
MFC after: 3 days
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D58622
[3 lines not shown]
ppp: Reject invalid endpoint discriminator options
Per RFC1717 section 5.1.3, the option length must be at least three.
Processing an undersized option would trigger a large out-of-bounds
write.
Approved by: re (cperciva)
PR: 271910
Reported by: Robert Morris
Reported by: Décio Brandão (0xDBJ)
Reviewed by: emaste
MFC after: 1 week
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D58554
(cherry picked from commit b9d07a4308226b683b64827e0aaed1180e0da996)
(cherry picked from commit 30b4bdd451ad4ec2470f9a378bd62e948a85ef81)
ppp: Avoid overflow when formatting endpoint discriminator options
Each byte of the address is represented by a pair of characters, so we
should be multiplying len by 2 when figuring out how much buffer space
we have. Previously, a sufficiently large option could cause an
overflow of the global "result" buffer.
Approved by: re (cperciva)
Reported by: Joshua Rogers <joshua at joshua.hu>
Tested by: Décio Brandão (0xDBJ)
MFC after: 3 days
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D58555
(cherry picked from commit e004ff15f87e6aa8f2aa13cd5600ae13457b95f1)
(cherry picked from commit 607c41d8f869243db275a6b1bd6cc66bf58d0f36)
proc: Copy the p_reapsubtree field explicitly during fork
p_reapsubtree lives in the p_startcopy/p_endcopy block of struct proc,
which is copied during fork without any synchronization. However, the
field is not stable except when the proctree lock is held, and indeed
may change if p1's reaper exits or explicitly releases its reaper
status. This state change can race with fork() and leave the child with
an incorrect p_reapsubtree field.
Close the race: explicitly copy the field under the proctree lock during
fork.
Approved by: re (cperciva)
Reported by: syzkaller
Reviewed by: kib
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D58482
[2 lines not shown]
rawip: Fix handling of checksums in rip6_input()
A v6 raw socket may ask the kernel to validate the checksum of an
inbound packet. If it does, and the validation fails, we discard the
packet, but this isn't really right: other raw sockets may wish to
receive a copy of the packet anyway.
Rework checksum handling to address this problem, and use a flag to
avoid computing the checksum more than once for a given packet.
Approved by: re (cperciva)
Fixes: de2d47842e880281 ("SMR protection for inpcbs")
Reviewed by: pouria, glebius
Reported by: Yunzhi Ke
MFC after: 1 week
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D58559
(cherry picked from commit 196874ce2e97e3e6425493b1d501e716b356bc36)
(cherry picked from commit 1fe3a2897b4ad7a9b9128efd6ec0c24b371bf5bd)
in_mcast: Fix uninitialized variable usage in inm_merge()
When the first loop in inm_merge() hits an error, generally because it
hit some limit on the number of source filters for a multicast group,
inm_merge() tries to atomically roll back changes to the group source
filter list.
To roll back, it iterates over the global source filter list for the
multicast group, starting at the last entry that we updated ("nims").
But, if we have not yet updated any entries, this variable is
uninitialized. Initialize it to NULL, so that RB_FOREACH_REVERSE_FROM
doesn't visit any source filters in this case.
All of the above applies to the v6 case.
Approved by: re (cperciva)
Reported by: Daniel Birtwhistle
MFC after: 1 week
Sponsored by: The FreeBSD Foundation
[3 lines not shown]
[clang][lex] Fix repeated `#import` of a header missing from umbrella (#217691)
The PR https://github.com/llvm/llvm-project/pull/216704 fixed repeated
`#import` of a header that belongs to a module in textual builds. One
omission was not setting the boolean we now use to make the decision to
import or skip when we tried importing a submodule but figured out it's
not covered by the umbrella. This PR fixes that.
rdar://185417139
