[NFC][Clang] Apply Rule of Three to classes in ASTUnit.h (#182198)
Static analysis flagged that some classes in ASTUnit.h defined a
destructor but did not also define a copy constructor or copy
assignment. This is a bug and I am defining them as deleted to prevent
accidently copy or assigns.
[flang] Add Flang Call Notes documents (#180287)
This PR is the result of discussion in
https://discourse.llvm.org/t/rfc-what-to-do-regarding-the-flang-call-notes-document/89450.
The intent with this PR is to move away from the former Google Doc in
favor of keeping the call notes in the primary repository. This PR has
the boilerplate and the notes from the last few meetings. In future,
notes from previous calls could be added in as well, once recovered from
the corrupted document.
The intended flow going forward would be for the call organizer to draft
the meeting's agenda in the working Google Doc referenced in
MeetingNotes/README.md, post it on Slack the day before the meeting,
take notes in the document during the call, then translate those notes
into a new notes document in the correct folder after the call is
completed and create a PR.
ports-mgmt/poudriere-devel: Update to 3.3.0-2517-g1ee69405b
Changes:
- bulk shlib tracking: Don't consider base libprivate*.so as missing.
- bulk shlib tracking: Remove the 'misses all libraries' case;
always print a specific library that is missing.
17713 SMB 3.1.1 should support GMAC signing
Reviewed by: Gordon Ross <gordon.w.ross at gmail.com>
Reviewed by: Robert Mustacchi <rm+illumos at fingolfin.org>
Approved by: Patrick Mooney <pmooney at pfmooney.com>
17712 smb: support signing capabilities negotiation context
Reviewed by: Gordon Ross <gordon.w.ross at gmail.com>
Reviewed by: Robert Mustacchi <rm+illumos at fingolfin.org>
Approved by: Patrick Mooney <pmooney at pfmooney.com>
17711 SMB: use single-shot scatter/gather interfaces for signing
Reviewed by: Gordon Ross <gordon.w.ross at gmail.com>
Reviewed by: Robert Mustacchi <rm+illumos at fingolfin.org>
Approved by: Patrick Mooney <pmooney at pfmooney.com>
[RISCV] Consistently name AVL operands as $vl. NFC (#182174)
Looking into using getNamedOperandIndex so we need to be consistent.
To avoid a conflict, I renamed the $vl output of vleff pseudos to
$vl_out. Arguably the AVL inputs should be $avl, but that requires more
changes and may interact with out of tree vendor specific instructions.
[ProfCheck] Remove now passing tests
There were quite a few tests in the profcheck-xfail.txt list that now
pass, likely due to other fixes coincidentally helping or someone
forgetting to update the list. Remove them from the list to ensure we
have test coverage.
17710 SMB: want unified mac functions
Reviewed by: Gordon Ross <gordon.w.ross at gmail.com>
Reviewed by: Robert Mustacchi <rm+illumos at fingolfin.org>
Approved by: Patrick Mooney <pmooney at pfmooney.com>
tests/ipfw: fix log:bpf test flakyness
There were several problems:
o Using 'netstat -B' is not a reliable way to make sure that all tcpdumps
have attached to bpf(4). The problem is that tcpdump (via libpcap) does
several ioctl(2)s after the attach including two BIOCSETF. Each of them
flushes the input buffer. So we can see tcpdump attached in 'netstat -B'
and start sending packets and the packet will be captured by bpf(4)
before BIOCSETF and freed and tcpdump won't read anything. Instead of
using netstat(1), use ps(1) and make sure each tcpdump is blocked on the
"bpf" wait channel, which guarantees it is done with ioctl(2)s and is now
blocked in read(2).
o Using 'nc -w 0' sets timeout not only on the connect(2) (as documented)
but also on poll(2), which is not documented. There is a race in shell
that will make stdin not yet filled by 'echo foo' when nc(1) does
poll(2). With zero timeout, this poll(2) will immediately return and nc
will exit.
o The waiting loop had two errors: using wrong variable name as well as
[7 lines not shown]
