[Serialization] Hash inner template arguments
The code is applied from ODRHash::AddDecl with the reasoning given
in the comment, to reduce collisions. This was particularly visible
with STL types templated on std::pair where its template arguments
were not taken into account.
Reviewed as part of https://github.com/llvm/llvm-project/pull/133057
pkg: the script has the benefit of testing at the moment
pluginctl reaches into webgui.inc but the firmware and configd
use rc.restart_webgui which we want to hook into for now.
[ORC][MachO] Clean up incompatible-arch-in-object error message. (#176092)
Add missing spaces to error messages, use Triple::getArchName (gives
canonical arch name on Darwin, e.g. "arm64" rather than "aarch64").
No testcase for this one: the change is cosmetic, and the error message
format not relied upon anywhere.
[profcheck] Reorder the FileCheck substitution.
In the profcheck build, FileCheck commands are substituted with cat > /dev/null to disable output verification. In a test/Transforms/SamplePrfile/remarks-hotness.ll we have both "FileCheck" and "not FileCheck" statements. Replacing the positive one first results in "not cat".
https://github.com/llvm/llvm-project/blob/main/llvm/test/Transforms/SampleProfile/remarks-hotness.ll#L18
Run the not substitution first to fix this.
NAS-139294 / 26.04 / Make `pool.snapshottask` plugin return type-safe models (#18015)
To continue bringing type-safety to middleware, I made `query` and
`get_instance` methods return pydantic models. I made CRUDService a
generic class, parametrized with the corresponding model class.
Temporarily, we also have to specify `generic = True` in a converted
service config to distinguish such classes from non-parametrized
CRUDServices.
Includes https://github.com/truenas/middleware/pull/18005 so review only
after it is merged to minimize diff.
Tests pass
http://jenkins.eng.ixsystems.net:8080/job/master/job/custom/1868/
NAS-139307 / 26.04 / Remove the remaining `TypedDict` usage in ZFS plugin (#18025)
For static type checking purposes it's better for functions to accept
their parameters as normal parameters.
make aq_start check the link is up before putting packets on the ring.
without link the hardware seems to hold onto the packets. if you
keep pushing packets onto the interface then the driver goes oactive
and then the ifqs fill up and then the system ends up short of
mbufs.
reported by Alisdair MacLeod on misc@ and narrowed down with sthen@
ok jmatthew@
Do the same workaround for i2c as was done for spi...
XXX XXX Big, fat, ugly workaround for an unfortunate senario triggered
XXX XXX by the CI20 kernel where there isn't a SoC I2C controller driver
XXX XXX that carries the fdt_i2c config attribute
