[lldb] Fix dotest.py --help (#216131)
Fixes the following `--help` bug I ran into:
```
% python3 ./lldb/test/API/dotest.py --help
Traceback (most recent call last):
File "path/to/llvm-project/lldb/test/API/dotest.py", line 8, in <module>
lldbsuite.test.run_suite()
File "path/to/llvm-project/lldb/packages/Python/lldbsuite/test/dotest.py", line 1099, in run_suite
parseOptionsAndInitTestdirs()
File "path/to/llvm-project/lldb/packages/Python/lldbsuite/test/dotest.py", line 318, in parseOptionsAndInitTestdirs
configuration.cmake_build_type = args.cmake_build_type.lower()
AttributeError: 'NoneType' object has no attribute 'lower'
```
[NFC][DebugInfo] Fix a parameter name in calculateFragmentIntersect's docs (#216142)
The docs spell it VarFarg, and the parameter is VarFrag, so the \p
reference resolves to nothing. That line is the one saying when Result
comes back empty, which is the behavior callers most need to look up.
[lldb] Search for a corefile's images before loading any of them
A userland or kernel corefile can list hundreds of images, and searching for
one can shell out to a symbol server or fetch over the network. Searching for
them one at a time is where loading such a corefile spends its time.
Add a batch form of SymbolLocator::Locate that runs the searches on the
debugger's thread pool, gated on target.parallel-module-load. Results come
back in the order the requests were given, since that order decides the
Target's module order. Only the results are ordered, and anything a search
reports to the user arrives in whatever order the searches finish in.
Only the plugin searches run concurrently, so a platform hook does not have to
be thread safe to take part, and reading a binary's UUID out of memory stays
on the calling thread.
Setting up a platform binary can replace the Target's platform and dynamic
loader, and now happens for every image before any of them is searched for, so
the platform a corefile asks for is the one all of its images are searched
[4 lines not shown]
[lldb] Consult the platform before the symbol locator plugins (NFC)
A symbol locator plugin has no Platform to consult, so a platform that knows
where its binaries live cannot take part in a search. The only way to reach
one is Platform::GetSharedModule, which also creates the module and registers
it, so the lookup cannot be reused by a caller that wants to search for many
binaries before creating any.
Add a hook that only answers where the files are. An answer ends the search,
so an override owns what the plugins would otherwise have been asked for.
No platform overrides it yet. A follow-up moves PlatformDarwinKernel's kext
and kernel index lookups behind it.
Assisted-by: Claude
[lldb] Add a unified entry point for locating a binary and its symbols (#215391)
The three-plugin composition that finds a binary and its symbol file is open
coded in several places. Give it one home, as a pure function of a module
spec, so that a caller holding several binaries can search for all of them
before creating any.
Nothing on this path takes a lock, where ModuleList::GetSharedModule holds the
shared module list's lock across the plugin search. That is what will make
searching for several binaries at once worth doing.
A miss that nothing could explain gets its own error type rather than an error
code, because a Status carrying an errno converts to the same llvm::ECError,
and a caller composing its own message for a plain miss must not swallow a
failure to reach a symbol server.
DynamicLoader's search no longer runs twice for a binary that is not already
known, and a module created from a located binary is now registered in the
shared module list, so a second Target asking for the same binary reuses it.
Assisted-by: Claude
[Profile] Add a more descriptive message to the bad_header error (#211281)
At the moment, the raw profile reader diagnoses different problem with
the same error message "invalid instrumentation profile data (file
header is corrupt)". On AIX, we had users report such problems thinking
it's a compiler bug, while the real problem was truncated profiles.
The particular case they hit was the condition
[here](https://github.com/llvm/llvm-project/blob/668803fa73bdf2f8d095162a1f81c000d18458c9/llvm/lib/ProfileData/InstrProfReader.cpp#L652):
```
Error RawInstrProfReader<IntPtrT>::readHeader(...) {
...
if (Start + ValueDataOffset > DataBuffer->getBufferEnd())
return error(instrprof_error::bad_header);
```
This could indicate a corrupted header (large garbage values for some
sections) or a truncated file.
I figured if we print the values and sizes we read in the header, it
will give the user more info.
[12 lines not shown]
[libc][x86] Enable memcpy NTA stores by default. (#216149)
Set `LIBC_COPT_MEMCPY_X86_USE_NTA_STORES` by default, which would enable
NTA stores for `memcpy()` calls at some point when processing large
buffers. We've ran some experiment down-stream that show that this
change is performance-neutral on the majority of regular benchmarks /
server applications and have positive impact on ML workloads that need
to copy large tensors into shared memory.
Co-authored-by: Ilya Tokar <tokarip at google.com>
git-arc: Add a diff subcommand
Show the differences between local commits and their associated
Phabricator reviews, i.e., what "git arc update" would upload. For
each commit, the review's current raw diff is applied to the commit's
parent in a temporary index and the resulting tree is compared against
the commit itself. An empty diff means the commit and the review are
in sync.
This makes it easy to check whether local amendments have diverged
from the posted review before updating it, or to confirm that a
review is current before landing.
Reviewed by: markj
Differential Revision: https://reviews.freebsd.org/D58789
databases/mysql-shell: Add New Port
MySQL Shell is an advanced client and code editor for MySQL with
support for SQL and Python scripting, both the classic and the
X protocol, and the AdminAPI. It builds its own copy of the MySQL
9.7.1 source tree to obtain the static client libraries.
JavaScript mode is not available since the GraalVM polyglot runtime
has not been ported to FreeBSD; see pkg-message.
PR: 291004
Co-authored-by: Daniel van Eeden <freebsd at myname.nl>
Co-authored-by: Dan Langille <dvl at FreeBSD.org>
Sponsored by: Netzkommune GmbH
databases/mysql-shell: Add New Port
MySQL Shell is an advanced client and code editor for MySQL with
support for SQL and Python scripting, both the classic and the
X protocol, and the AdminAPI. It builds its own copy of the MySQL
[9 lines not shown]
graphics/py-svg.py: Add New Port
Type-safe SVG drawing library for Python.
Required as a runtime dependency of the upcoming
databases/mysql-shell port.
PR: 291004
Sponsored by: Netzkommune GmbH
unix: only treat an empty sun_path as a peer descriptor for connectat(2)connect(2) passes AT_FDCWD to unp_connectat(), so the empty-path
descriptor branch added in 6563dcb6b1f5 turned any sockaddr whose
sun_path begins with a NUL byte into getsock(AT_FDCWD), failing with
EBADF where the pathname lookup historically failed with ENOENT.
Linux abstract namespace names are exactly that: the linuxulator
passes them through with the leading NUL intact, and libxcb tries the
abstract socket first, falling back to the pathname socket only on
ENOENT or ECONNREFUSED. The EBADF made every Linux X11 client fail
at startup with "Missing X server or $DISPLAY".
Restrict the descriptor interpretation to fd != AT_FDCWD, matching
the contract stated in 6563dcb6b1f5's commit message ("Accept an
empty sun_path when fd is not AT_FDCWD"): connect(2) again reaches
the pathname lookup and fails with ENOENT as it always did.
Add a regression test: a NUL-leading, nonzero-length sun_path through
[7 lines not shown]
[VPlan] Use collectEphemeralRecipesForVPlan in calculateRegUse (NFC) (#216047)
Update calculateRegisterUsageForPlan to use
collectEphemeralRecipesForVPlan instead of relying on IR-based set of
instructions.
[mlir] [memref] [transform] Add alloc_to_global op. (#211141)
This adds a new transform op that creates a `memref.global` op for
each provided `memref.alloc` and replaces `memref.alloc`s with
`memref.get_global`. It also creates a new helper function that contains
the shared logic between the existing `alloca_to_global` op and
`alloc_to_global`. It also checks whether `memref.alloc`s and
`memref.alloca`s are statically shaped since `memref.global` requires
statically shaped buffers.
[CIR] Implement __builtin_clear_padding (#216126)
__builtin_clear_padding is lowered as an operation, which keeps the list
of the padding sections so that it knows how to clear them later. Rather
than trying to get the casting/etc right earlier to do clearing, this
patch chooses to do the conversion to load/and/store operations during
LowerToLLVM. This also yields identical IR to OGCG, whereas attempts to
do it earlier caused divergence that seemed unnecessary and causes
difficulty in assuring they are compatible.
[CIR] Implement the 'rest' of the TLS Model types (#215380)
Functionally, the only difference between these models is the tag that
goes onto the variable in the LLVM-IR. This patch changes our "==
GeneralDynamic" checks to just be whether they have a TLS Model defined,
so all the previous logic still holds.
This patch DOES have to add the 'default' model to the module, as the
top-level TLS guard needs to have this model, even if the individual
variables are overridden by the tls_model attribute.
Like the previous inline-printing patch, this ensures we print the
module result attribute as an enum value instead an integral. This
requires some custom parse/printing here, but is pretty routine. We
can't convert GlobalOp without vastly changing how it prints these, as
there isn't really a 'assemblyFormat' that works for this printed as an
'attribute' and a keyword.
We ALSO had to change the name of the enum to be TLSModel, because MLIR
is inconsistent in tablegen where it gets the name from on an enum, so
it would pick up the wrong spelling sometimes.
[lldb] Make SBFile::operator bool explicit (#215819)
Every other SB class in the API declares `explicit operator bool()`.
SBFile was the only one with an implicit conversion, which in general is
not something we want.
[lldb][test] Don't include all SB API headers in TestMultithreaded (#215551)
This test compiles 9 C++ test files and uses the `generateSource`
function to inject includes for every single SB API header. The
`generateSource` call also sets `SOURCE_DIR` so the test knows its
current source directory.
This patch removes the need for `generateSource` by including the SB API
headers we actually need. SOURCE_DIR is now specified using an
environment variable in the test.
The motivation for this patch is that I want to avoid recompiling these
source files unless their source or the included headers change.
Currently, this test is one of the slowest in the test suite and needs
about half a minute to run. In the future, I want to at least avoid the
recompilation time for each test file.
Note that we still have another test that includes all SB API headers
normally and as a framework, so this does not remove test coverage.
[Offload][Driver] Split frontend CUDA/HIP language assumptions from backend device (#212373)
CUDA and HIP offloading currently assumes that the source language also
implies the device backend: CUDA maps to NVPTX/CUDA and HIP maps to
AMDGPU/HSA. That is too restrictive for the LLVM offload path, where the
language frontend and the device backend can be separate choices.
Using `-foffload-via-llvm` we can split the kernel language from backend
assumptions. When enabled, the driver suppresses the vendor
runtime/header paths, injects the LLVM-provided generic GPU device
headers and language runtime headers, and links the LLVM CUDA/HIP
runtime libraries from #211694 instead. It also provides tests for
#211694 since they require the frontend to run.
Assisted by GPT-5.5, checked and reviewed manually
Co-authored-by: Johannes Doerfert <jdoerfert.llvm at gmail.com>
Co-authored-by: Jonas Greifenhain <cadivus at daverkomp.de>
[clang-tidy] Add `readability-redundant-zero-initializer` (#209367)
Add a check that finds explicit single-element zero initializers of
arrays and rewrites them to empty braces, e.g. `char a[12] = {0};`
becomes `char a[12] = {};`. Empty-brace initialization zero-initializes
every element, so the explicit `{0}` is redundant. The check is only
enabled in C++ and in C23 or later.
The check is conservative and only rewrites a single-element `{0}` list
whose sole element is the integer literal `0` and whose array has an
explicit bound. It leaves alone, among others:
- arrays whose bound is deduced from the initializer (`char a[] = {0};`)
- multi-dimensional arrays (`int m[2][3] = {0};`)
- initializers with more than one element (`int a[3] = {0, 0};`);
- scalars and class/struct types
- zero written in another form such as `'\0'`, `0.0` or `nullptr`
Closes #209139
[2 lines not shown]
[X86] extractsubvector-load.ll - basic test coverage for various extractsubvector(load) patterns (#216156)
Shows some poor codegen for non-aligned subvector indices
Basic frozen load test coverage for #216115
[CIR] Address reviewer feedback
The comments on isEmptyFieldForABI and isEmptyRecordForABI were too verbose. Adapt the comments on classic's isEmptyField and isEmptyRecord.
Add flexible array member tests.
Assisted-by: Cursor / claude-opus-5
