GlobalISel: Use MIPatternMatch to look up defs in CombinerHelper
Replace direct getVRegDef uses that were followed by an opcode check with
the mi_match idiom, mirroring the artifact combiner cleanup in
2e172cd38272124da30cc913f1a372ba9ea59dcf. This handles a subset of simple
cases, others call for some nicer mi_match support.
Co-authored-by: Claude (Opus 4.8) <noreply at anthropic.com>
RuntimeLibcalls: Fix AArch64 wrongly typed long-double libcalls (#215993)
Respect the triple's LongDoubleFormat.
AArch64SystemLibrary added the fp128-typed frexpl/ldexpl and exp10l
without a long-double-format guard, so triples where long double is IEEE double
(Darwin, Windows, Android) were emitting l suffixed calls with the wrong
type.
Co-authored-by: Claude (Claude-Opus-4.8) <noreply at anthropic.com>
[ADT] Add const and reverse iterators to SortedVectorMap (#216439)
This patch adds cbegin, cend, rbegin, rend, crbegin, and crend to
SortedVectorMap along with reverse_iterator and const_reverse_iterator
type aliases.
The motivation here is to support const and reverse iteration in
SortedVectorMap, which is needed by tools like llvm-profdata for the
ongoing sample profile migration to SortedVectorMap.
Assisted-by: Antigravity
[bazel] Fix bazelisk failures after ORC RTBridge removal and libc float128 (#216505)
…at128
Commit f406aaec5f6dcb8dbe5d7267afdfdf80cea29d32 removed the ORC/RTBridge
directory and relocated its headers directly under
include/llvm/ExecutionEngine/Orc/. This updates OrcJIT and OrcShared in
llvm/BUILD.bazel to remove the obsolete RTBridge header glob patterns.
Additionally, this adds the missing :__support_fputil_float128 target in
libc/BUILD.bazel and includes it in the dependencies of
:__support_math_ceilf128 and :shared_math_headers_for_apfloat.
TAG=agy
CONV=cdc6d2a4-4a43-464a-ae1b-a56f935ee140
[CIR] Mark bit-field access units as their own member kinds
A bit-field access unit is as wide as the compiler decides, which can be
narrower than the declared type of the bit-fields in it, and the member marks
say nothing about that: a unit with a named occupant is `data` and one with only
unnamed occupants is `empty`, the same marks a declared field gets. So a member
holding a 32-bit bit-field of `long long` looks exactly like an `unsigned`
field, and the two are not the same to the ABI. `BitsContainNoUserData`
recurses on the declared type, finds user data past bit 32 in the first and none
in the second, and classic CodeGen coerces the enclosing records to `i64` and
`i32`.
Split the unit cases out as `bitfield` and `empty_bitfield`. A unit holds data
exactly when a named bit-field lands in it, so `isEmptyForABI` answers the same
for every record once it asks `holdsDataForABI` instead of testing for `data`
alone, and padding is untouched. Nothing classifies on the new marks yet, so no
ABI treatment changes. What needs them is pad-aware eightbyte classification,
which cannot tell a record's declared extents from its access units without
them.
[2 lines not shown]
[APFloat][SelectionDAG] Support Float8E5M3FNU in convert.{to,from}.arbitrary.fp
Float8E5M3FNU was already accepted by the IR verifier, because
isValidArbitraryFPFormat is defined in terms of
getArbitraryFPFormatSizeInBits and that table covers it. It was missing
from getArbitraryFPSemantics, so SelectionDAGBuilder rejected
it with "not implemented format" and the verifier-clean IR failed to
compile. Add the mapping and the corresponding entries in the
expandCONVERT_{TO,FROM}_ARBITRARY_FP format allowlists.
Unlike every other format the expansions handle so far, Float8E5M3FNU is
unsigned: it has no sign bit, so all 8 bits go to a 5-bit exponent and a
3-bit significand.
Since an unsigned format cannot represent a negative value, a negative
input now saturates to zero when the saturate flag is set, and is poison
otherwise. -0.0 is excluded from that and still converts to +0, and the
check is ordered before the NaN case so a negative NaN still produces the
NaN encoding. APFloat treats constructing a negative value in an unsigned
[3 lines not shown]
[APFloat][NFC] Add unit test coverage for getArbitraryFPSemantics
isValidArbitraryFPFormat and getArbitraryFPFormatSizeInBits have unit
tests, but getArbitraryFPSemantics, the mapping the conversion
intrinsics actually lower through, had none. Cover the formats it
supports, the valid formats it does not support yet, and invalid format
strings, and check that the two tables agree on the size of every
format with lowerable semantics.
Also add the missing Float8E5M3FNU case to the
getArbitraryFPFormatSizeInBits test.
Change-Id: I8fa9580ca6f03fd5e7b1de5354b71283cebb0f95
[lldb][test] Skip the frame 0 stack expedite test with an out-of-tree debugserver (#216496)
test_threads_info_expedites_stopped_frame_stack asserts that
jThreadsInfo
carries frame 0's stack memory for the stopped thread. debugserver only
does
that since b631e0cbd1c9, so a system debugserver sends the backchain
alone and
the test fails with "no frame 0 stack memory for stopped thread".
[IR][Intrinsics] Fix llvm.powi to require a scalar integer exponent (#216160)
Fix llvm.powi intrinsic to enforce a scalar integer exponent,
aligning the implementation with the LangRef specification.
Merge main into the derive-record-padding branch
Main has moved 931 commits and both parents of this branch landed with it, the
mark list in #215174 and the CIRGen marks in #215175, so this branch keeps only
the change that drops the stored `padded` bit and derives it from the `pad`
marks instead.
Assisted-by: Cursor / claude-opus-5
[Object][Wasm] Guard relocation diagnostics against out-of-range indexes (#204872)
The badReloc lambda in parseRelocSection() accesses Symbols[Reloc.Index]
when building diagnostic messages, even after validation has determined
that Reloc.Index is out of range. This causes a heap out-of-bounds read
that can crash LLVM tools or produce unexpected diagnostic output.
Fix by checking Reloc.Index against Symbols.size() before dereferencing,
and emit the numeric index in the error message when out of range.
The vulnerable diagnostic path is shared across multiple relocation type
validation failures, including R_WASM_FUNCTION_INDEX_LEB,
R_WASM_TAG_INDEX_LEB, R_WASM_TABLE_NUMBER_LEB, and
R_WASM_MEMORY_ADDR_LEB.
Note: this is a minimal fix addressing the out-of-bounds access. The
R_WASM_TYPE_INDEX_LEB path validates against Signatures.size() but
badReloc() still references Symbols[Reloc.Index], which may warrant
a broader diagnostic refactoring separately.
[Hexagon] Fix KCFI check truncating type id (#211854)
The KCFI indirect-call check is lowered directly to MCInst in the
Hexagon AsmPrinter. It omitted the constant-extender, causing
mismatches.
Packet canonicalization is how we should apply constant extenders,
duplex, compounds, etc.
Assisted-by: Claude
(cherry picked from commit c88aeaf712c6694d0b29d312783d24cacc000a5a)
[DAGCombine] Fix alignment of store in replaceStoreOfInsertLoad. (#215895)
For the variable index case, the alignment of the original store was
used, which is too large.
Fixes #215530
(cherry picked from commit 2dd35f8ff91fbea3d898474851f78dfad2332c18)
[lldb] Fix crash when adding a python ParsedCommand (#215807)
The expected result of `ParsedCommand.get_args_definition` is a List of
Lists and should not crash when it is not the case.
(cherry picked from commit 58e4198eab3b7437b5ffc2e8adb21ed8fc2d8866)
[flang] To fix LIT test that AIX does not emit comdat. (#214950)
PR #213890 added this new LIT test.
However, AIX uses XCOFF and does not emit COFF COMDAT.
(cherry picked from commit 31749521e7b9f1cb93c9554133ab0a6d181fd8c7)
[RISCV] Fix prefetch ADDI-adjustment range upper bound (#215985)
SelectAddrRegImmLsb00000 folds a large constant offset into an ADDI plus
a simm12_lsb00000 prefetch immediate. The positive range [2017, 4065]
overflowed simm12 at the top end: CVal - 2016 reaches 2048/2049,
producing an invalid ADDI. Narrow it to 4063; 4064/4065 now fall through
to selectConstantAddr instead.
(cherry picked from commit 866bc8d6a9930a75b2b10a8f9d0a31982c5479bb)
[DWARFLinker] Consider module units when creating the type unit (#215731)
The parallel linker creates the artificial type unit only when some
compile unit uses an ODR language, but it looks for that language in the
compile units of the object files alone. A clang module unit decides its
own ODR availability from its own DW_AT_language, so a module built as
C++ or ObjC++ imported from an object file whose units are all C, ObjC
or Swift places DIEs in the type table which does not exist, asserting
in CompileUnit::cloneDIE and dereferencing null without assertions.
Scan the languages of the module units as well, so a module which
deduplicates types always has a type unit to hold them.
rdar://182719465
(cherry picked from commit 58599fe7d593ddd4d4e9f95cfd9348a48ddf8492)
[RISCV] Avoid pre-RA Zilsd pairs with same src/dst registers (#215575)
The pre-RA Zilsd optimizer previously allowed a special case for stores
where both source operands were the same vreg if that vreg was defined
by COPY $x0. This assumes register allocation will preserve the value as
x0, but that is not guaranteed. The vreg can be allocated to a normal
GPR, producing an invalid pair.
(cherry picked from commit 4ef2427b4c08fd28e4244c585ae0673711e4c0d6)
[DWARFLinker] Keep module type definitions in the parallel linker (#215435)
A Clang module compile unit carries the only definitions of the types
its module owns. No definition in it is reachable from a live address.
Similar to the classic linker, we need to mark everything as kept.
rdar://184559034
(cherry picked from commit ef04927f4a8b890504d770186f6002f487a6790e)
