[TableGen] Count errors reported via PrintError(const char *, ...) (#232271)
This overload called SrcMgr.PrintMessage directly instead of going
through PrintMessage, so it did not increment ErrorsPrinted. The lexer
uses it for several diagnostics, so e.g. an unterminated #ifdef printed
two errors followed by "1 errors.".
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply at anthropic.com>
[Offload][Omp] Remove OmpABIVersion from PluginInterface (#232337)
Move the ABI version check for host kernels from the host plugin to
libomptarget. This allows to remove the field from the KernelLaunchArgs
in the PluginInterface.
Assisted by Claude.
[flang][OpenACC] Hoist firstprivate loads of guarded optional variables (#231996)
`ACCOptimizeFirstprivateMap` did not optimize optional variables,
because loading an absent optional on the host is unsafe. When the
`acc.firstprivate_map` is in the then region of a `fir.if` on the
presence of the same variable, the variable is known to be present:
hoist its loads and fold the presence checks of the mapped value to
true.
[AMDGPU][NewInsertWaitcnt] Event Tracker (2/2)
See #226970 for context and history regarding this patch.
This is intended to begin review as a 1-1 equivalent of #226970 with only one change: a "Drain"
test that Claude added and I found useful, so I left it in.
Builds upon the previous patch to include the functionality needed to import
events from predecessor basic blocks into a basic block, so a MBB can be aware of
previous state.
This adds the "height" system, which is necessary to preserve chronology across control-flow edges,
especially in asymmetrical diamonds, alongside a way to import predecessor state via a `enterBlock`
function.
Assisted-by: AI Coding Assistants for basic boilerplate/research/etc. - no logic was written by LLMs except some unit tests.
[AMDGPU] Reserve addrspace 19 for downstream use (#232092)
Add RESERVED_ADDRESS_SPACE_19 to AMDGPUAS, following the existing
reservations for address spaces 10, 11, 14, and 16-18. Address spaces
above MAX_AMDGPU_ADDRESS are already treated conservatively (global-like
in isFlatGlobalAddrSpace, may-alias in addrspacesMayAlias), so no
behavior changes; this only documents the number as taken so upstream
does not later assign it.
Codegen for addrspace(19) is already covered by
llvm/test/CodeGen/AMDGPU/nullptr.ll.
NFC
Assisted-by: Claude Code:claude-opus-5[1m]
[AMDGPU][NewInsertWaitcnt] Event Tracker (1/2)
See #226970 for context and history regarding this patch.
Adds the basic infrastructure needed to track in-flight records for each InstCounterType.
This is not a full functional replacement of SIInsertWaitcnts::WaitcntBrackets and it does not
aim to be one, as we'd like to break up its functionality into multiple different pieces.
This patch only contains the functionality needed for tracking events in one block, without importing events from previous blocks.
Assisted-by: Claude Opus 5.5
After requests to split the patch, I used Claude to help me create this patch which is a subset of #226970 with all functionality pertaining to importing incoming events removed.
[llvm-readobj][docs] Update the --stack-sizes description
The description said that --stack-sizes is only implemented for GNU
style output, which hasn't been the case for a while. Describe the LLVM
and JSON output instead: each entry also identifies its function as
--call-graph-info does, by its address in a linked file, or by the
relocation that applies to it in a relocatable file.
Assisted-by: Gemini
[llvm-readobj][ELF] Print the relocation of each --stack-sizes entry
In a relocatable file, print the relocation that applies to each
.stack_sizes entry as a Relocation object in the LLVM and JSON output,
with the same fields as in --call-graph-info. The code that prints the
object is shared with --call-graph-info, so the addend of a SHT_REL
relocation is again the value stored in the address field.
Assisted-by: Gemini
[llvm-readobj][ELF] Print the address of each --stack-sizes entry
In a linked file, print the function address that each .stack_sizes
entry holds as Address in the LLVM and JSON output. The entries can then
be matched with --call-graph-info output by address, without looking up
function names.
Assisted-by: Gemini
[llvm-readobj][ELF] Clear the Thumb bit from --stack-sizes addresses
On ARM, the address of a Thumb function has bit 0 set, but that bit is
not part of the function's address. --stack-sizes looked up function
symbols at the address with the bit set, so Thumb functions were
reported as unknown, with a warning. Clear the bit, as --call-graph-info
does, both from the address stored in a linked file and from the address
that a relocation resolves to in a relocatable file.
Assisted-by: Gemini
[llvm-readobj][docs] Update the --stack-sizes description
The description said that --stack-sizes is only implemented for GNU
style output, which hasn't been the case for a while. Describe the LLVM
and JSON output instead: each entry also identifies its function as
--call-graph-info does, by its address in a linked file, or by the
relocation that applies to it in a relocatable file.
Assisted-by: Gemini
[libc] Use a syscall wrapper for `sched_rr_get_interval` (#232310)
This PR move `sched_rr_get_interval` behind the centralized syscall
wrappers, following `libc/docs/dev/syscall_wrapper_refactor.md`.
[ValueTracking] Check noundef before applying square (fmul_self) (#232178)
`computeKnownFPClass` for `ValueTracking.cpp` will now test
`isGuaranteedNotToBeUndef` before determining that `fmul %x, %x` is
squaring.
I also added a test for maybe-undef squaring for `computeKnownFPClass`
for `GISelValueTracking.cpp`
Resolves
https://github.com/llvm/llvm-project/pull/227248#discussion_r4207466257
[SCEVExpander] Simplify expanding AddRecs from the canonical IV (NFC). (#232287)
In canonical mode, visitAddRecExpr expands AddRecs with more than 2
operands literally, so all AddRecs handled afterwards are affine. Remove
the trivially true isAffine() checks and the unreachable expansion of
chains of recurrences via evaluateAtIteration.
When {0,+,F} is expanded from the canonical IV, the IV has the type of
the AddRec, so the truncate and extend are no-ops, and {0,+,1} needs no
special case, as the multiply by 1 folds away.
Also handle pointer AddRecs before splitting off the start, as the start
of a pointer AddRec is never zero, and build {0,+,F} directly from its
step, as S is affine.
[SCEVExpander] Simplify expanding AddRecs from the canonical IV (NFC). (#232287)
In canonical mode, visitAddRecExpr expands AddRecs with more than 2
operands literally, so all AddRecs handled afterwards are affine. Remove
the trivially true isAffine() checks and the unreachable expansion of
chains of recurrences via evaluateAtIteration.
When {0,+,F} is expanded from the canonical IV, the IV has the type of
the AddRec, so the truncate and extend are no-ops, and {0,+,1} needs no
special case, as the multiply by 1 folds away.
Also handle pointer AddRecs before splitting off the start, as the start
of a pointer AddRec is never zero, and build {0,+,F} directly from its
step, as S is affine.
[flang] Check SIMPLE on every IEEE_ARITHMETIC elemental function family (#231952)
Follow-up to #223254, test only.
`simple-ieee-arithmetic-functions.f90` checks that one specific,
`ieee_is_finite_a4`, is SIMPLE. The prefix is applied by 29 independent
`#define` macros in `flang-rt/lib/runtime/ieee_arithmetic.f90`, one per
elemental function family, so removing it from any other family passes
the test.
This references one specific per family and checks each with
`-fdebug-dump-symbols`, the same style as
`simple-ieee-arithmetic-operators.f90`. The CHECK lines follow the
dump's alphabetical order.
Assisted-by: AI
[llvm-readobj][ELF] Print the relocation of each --stack-sizes entry
In a relocatable file, print the relocation that applies to each
.stack_sizes entry as a Relocation object in the LLVM and JSON output,
with the same fields as in --call-graph-info. The code that prints the
object is shared with --call-graph-info.
As in --call-graph-info, clear the Thumb bit from the address that the
relocation resolves to on ARM, so that Thumb functions are found.
Assisted-by: Gemini
[llvm-readobj][ELF] Print the address of each --stack-sizes entry
In a linked file, print the function address that each .stack_sizes
entry holds as Address in the LLVM and JSON output. The entries can then
be matched with --call-graph-info output by address, without looking up
function names.
As --call-graph-info does, clear the Thumb bit from the address on ARM.
This also lets Thumb functions be found: they were reported as unknown,
with a warning.
Assisted-by: Gemini
ARM, X86: Test code after noreturn calls against the exception model
Add ARM and X86 versions of the AArch64 windows-trap-unreachable test
from #229681
Co-authored-by: Claude Opus 5.5 <noreply at anthropic.com>
[Offload][omp] Move is_accessible_ptr to liboffload (#231801)
Implement a new method in liboffload to access isAccessiblePtr method in
GenericDeviceTy and use it in libomptarget to substitute the direct call
to GenericPluginTy.
Assisted by Claude.
AMDGPU: Keep argument live in vgpr-large-tuple-alloc-error.ll (#232308)
The register pressure in this test comes from exporting the argument
to virtual registers. The export is only needed when the argument is
used outside the entry block, so use it in a second block. This avoids
breaking the test in a future patch which avoids emitting the
unnecessary copies.
Co-authored-by: Claude Opus 5.5 <noreply at anthropic.com>
[llvm-readobj][ELF] Print Names for call graph relocations (#230654)
In a relocatable object file, an entry identified by a relocation had no
Names. Compute the address that the relocation resolves to with
RelocationResolver, look up the functions at that address in the section
of the relocation's symbol, and print them as Names before the
Relocation object.
As with Names for an Address, the names follow --demangle. Nothing is
printed for an undefined symbol, or when no function is at the address.
A relocation type that RelocationResolver doesn't support, or a symbol
whose section can't be found, gets a warning.
Assisted-by: Gemini
[llvm-readobj][ELF] Fall back to Address when no single relocation applies (#230653)
In a relocatable object file, --call-graph-info identifies a function by
the relocation that applies to its address field. If a field had no
relocation, nothing in the output identified the function. If the
relocation section had an invalid sh_link, the dump stopped. If a field
had more than one relocation, the first one was used silently.
In all of these cases, print the value stored in the field as Address,
as for linked files. Warn once if a call graph section has no relocation
section, and warn about each field with no relocation or more than one.
If the relocations can't be read, only that is reported.
Assisted-by: Gemini
[llvm-readobj][ELF] Print implicit addends of call graph relocations (#230652)
A SHT_REL relocation, or a SHT_CREL relocation without explicit addends,
keeps its addend in the field that it applies to. Print the
sign-extended field value as the Addend of such a relocation instead of
dropping it. The ARM test now uses SHT_REL and covers the same cases as
the SHT_RELA tests: named symbols, a negative addend, and a section
symbol with an addend.
Assisted-by: Gemini
[llvm-readobj][ELF] Print a Relocation object instead of Name in --call-graph-info (#230651)
In a relocatable file, the address fields of a call graph section hold
placeholders, and the relocation that applies to each field identifies
the function. Name showed only the relocation's symbol name, made up
from the section name for an unnamed section symbol, and dropped the
addend. So entries that refer to a function through a section symbol
couldn't be told apart.
Print a Relocation object instead, with the symbol index, the symbol
name exactly as recorded in st_name, and the addend if it is non-zero.
With --demangle, the demangled symbol name is printed as DemangledName.
If the symbol can't be read, the existing warning is reported and only
the symbol index is printed.
Assisted-by: Gemini
DebugInfo: Fix contradictory dead flags in MIR tests
Remove the duplicate implicit-def dead $pc from Hexagon L4_return, and
drop the dead flag from sub-register defs that also have a live
super-register implicit-def. These will fail a future verifier rule.
Co-authored-by: Claude Opus 5.5 <noreply at anthropic.com>
