[clang][ssaf] Add source-transformation library scaffolding (#204214)
Introduces the abstract base classes, registries, and force-linker
anchor for the SSAF source-transformation library.
A `Transformation` is an `ASTConsumer` that consumes a previously
computed `WPASuite` and emits source edits and findings through two
sinks: `SourceEditEmitter` (accumulates `clang::tooling::Replacement`s)
and `TransformationReportEmitter` (accumulates `(ruleId, level, range,
message)` tuples). The accumulated state is then handed to a
`SourceEditFormat` and a `TransformationReportFormat` for serialization.
Three `llvm::Registry`-backed registries — keyed by transformation name
and by file extension respectively — let transformations and formats be
linked in statically (with a force-linker anchor) or loaded dynamically
as a clang plugin. Each registry exposes the standard `is*Registered` /
`make*` / `printAvailable*` helpers used elsewhere in SSAF.
No transformation or format ships yet; this commit only adds the
[4 lines not shown]
[lldb] Only run libc++ tests when the architecture matches (#204267)
It does not make sense to run the libc++ tests when the libc++ dylib has
an architecture that does not match the test binary.
I ran into this when running the test suite with arm64e test binaries
and the locally-built libc++ is built arm64.
---------
Co-authored-by: Dave Lee <davelee.com at gmail.com>
[mlir][emitc] Set operator precedence for `GetFieldOp` (#203416)
This sets the precedence for the `GetFieldOp`, preventing an unsupported
operation error. The precedence is set to 18, the same as `GetGlobalOp`,
because `GetFieldOp` behaves the same way.
[AArch64][llvm] Deduplicate hint alias parsing code (NFC)
The code which handles instructions that are aliased in the `HINT`
encoding space is very similar and repetitive.
Move common code into templated functions, so that it's consistent and
simpler, whilst still remaining readable.
This also means any future instructions added in the `HINT` space will
be simpler to implement. Net removal of ~53 lines of code.
[SSAF] Properly handle contributors with multiple declarations
A contributor entity can have multiple declarations all contributing
interesting facts. For example, a function declaration (not
definition) may have default arguments, which may provide pointer flow
or unsafe buffer usage facts. This commit groups declarations by their
canonical decls. The entity summary of a contributor will be
collected from all its decls.
In addition, this commit includes the following minor changes:
- Factor the common procedure of summary extraction and insertion
into a template function in SSAFAnalysesCommon.h.
- Convert the no-duplicate contributor assertion into a debug
warning. In corner cases, there might be an EntityName conflict on
distinct entities. Sometimes, just keeping one of those entities is
fine (see benign-entity-name-conflict.cpp). More importantly, we
need the release build to not crash.
rdar://179150798
[Flang] Match additional CMake Fortran detection probes (#204438)
Support the following additional patterns that CMake may use to
introspect the Fortran compiler:
1. `__GNUC__` may be tested before `__flang__` which results in the
compiler to be identified as "GNU" instead of "LLVMFlang"
2. Invoke with `-E -cpp` to explicitly use the preprocessor
Fakeflang was added in #203481 to not have to build all of flang just to
pass CMake's compiler detection.
Tested with CMake 3.20, 3.28, and 4.4-rc.
Should fix the
[flang-aarch64-rel-assert](https://lab.llvm.org/buildbot/#/builders/29)
and [flang-aarch64-dylib](https://lab.llvm.org/buildbot/#/builders/50)
buildbots.
workflows/release-binaries: Use Wix to create Windows installer (#200734)
The NSIS based installer had a limit of 2GB, and we started going over
that, so we needed to move to Wix which supports much larger installer
sizes.
[SSAF] Properly handle contributors with multiple declarations
A contributor entity can have multiple declarations all contributing
interesting facts. For example, a function declaration (not
definition) may have default arguments, which may provide pointer flow
or unsafe buffer usage facts. This commit groups declarations by their
canonical decls. The entity summary of a contributor will be
collected from all its decls.
In addition, this commit includes the following minor changes:
- Factor the common procedure of summary extraction and insertion
into a template function in SSAFAnalysesCommon.h.
- Convert the no-duplicate contributor assertion into a debug
warning. In corner cases, there might be an EntityName conflict on
distinct entities. Sometimes, just keeping one of those entities is
fine (see benign-entity-name-conflict.cpp). More importantly, we
need the release build to not crash.
rdar://179150798
[WebAssembly] Default to 0 shadow offset for wasm64 ASan (#204437)
For Wasm64, ASan instrumentation was defaulting to a 16TB shadow offset,
while the runtime configures it to 0. Align them by defaulting to 0 for
all WebAssembly targets.
[WebAssembly] Add support for R_WASM_MEMORY_ADDR_LOCREL_I64 relocation (#204055)
This relocation is needed for WASM64 to support location-relative memory
addresses, which are used e.g. in profile instrumentation (for
CounterPtr in __llvm_profile_data).
Without this, the compiler falls back to absolute relocations and drops
the subtraction, resulting in malformed profile data.
Fixes: https://github.com/emscripten-core/emscripten/issues/26865
[DirectX] Fix IO sandbox violation in DXContainerPDB pass (#204461)
`DXContainerPDB::runOnModule` writes a PDB file to disk via
`PDBFileBuilder::commit`, which calls through `MSFBuilder::commit` ->
`FileOutputBuffer::create` -> `llvm::sys::fs::status()`. These are raw
filesystem APIs that trigger a fatal "IO sandbox violation" when the IO
sandbox is enabled.
The sandbox is enabled in `CC1Command::Execute` (Job.cpp) to enforce
that all filesystem access goes through the VFS. Since `PDBFileBuilder`
doesn't support VFS-based output, bypass the sandbox for the commit call
using `scopedDisable()`, matching the established pattern used in
`raw_ostream.cpp`, `VirtualFileSystem.cpp`, `BackendUtil.cpp`, and
others.
This crash occurs on any clang invocation targeting the DirectX backend
with PDB emission enabled, e.g.:
`Target: dxilv1.7-unknown-shadermodel6.7-library`
[17 lines not shown]
[RISCV][P-ext] Fold (PSRL/PSRA (trunc (PSRL X, C1)), C2) -> (trunc (PSRL/PSRA X, C1+C2)) (#204385)
when C1 equals the number of bits discarded by the truncate. This
matches an existing DAGCombine for ISD::SRA/SRL which doesn't get
a chance to fire before the inner PSRL is formed.
Assisted-by: Claude Sonnet 4.6
[clang][ssaf] Make TUSummary, LUSummary, and WPASuite JSON representations self-describing (#204409)
This commit introduces the following changes:
- Add a self-describing `"type"` field (`"TUSummary"`, `"LUSummary"`, or
`"WPASuite"`) to the root of every artifact JSON file written by
`JSONFormat`. Kind-specific readers (`readTUSummary`, `readLUSummary`,
`readWPASuite`, plus the encoding flavors) validate that the field is
present and matches the expected value.
- Introduce two variant aliases on `SerializationFormat`: `Artifact =
std::variant<TUSummary, LUSummary, WPASuite>` and `ArtifactEncoding =
std::variant<TUSummaryEncoding, LUSummaryEncoding>`. Each gets a generic
`read*/write*` pair that peeks the `type` field once and dispatches to
the matching reader/writer; the file is read and parsed only once per
call.
- Refactor every kind-specific reader into `read{Kind}` (loads file +
validates type) plus a private `read{Kind}FromObject(const Object&)`
helper. `readArtifact`/`readArtifactEncoding` reuse those helpers
directly, avoiding the file-and-parse-twice pattern.
[5 lines not shown]
[NFC][VPlan] Add initial tests for future VPlan-based stride MV
I tried to include both the features that current
LoopAccessAnalysis-based transformation supports (e.g., trunc/sext of
stride) but also cases where the current implementation behaves poorly,
e.g., https://godbolt.org/z/h31c3zKxK; as well as some other potentially
interesting scenarios I could imagine.
The are two test files with the same content. One is for VPlan dump change of
the future transformation alone (I'll update `-vplan-print-after` in the next
PR), another is for the full vectorizer pipeline. The latter have two `RUN:`
lines:
* No multiversioning, so the next PR diff can show the transformation itself
* Stride multiversionin performed in LAA, so that we can compare future
VPlan-based transformation vs old behavior.
[ConstraintElim] Do not model negative nuw-only GEP offset as signed. (#203620)
decomposeGEP added the GEP's constant offset to the unsigned
decomposition using its signed value (getSExtValue()). For a GEP that
only carries nuw (without nusw/inbounds), the indices must be
interpreted as unsigned.
Alive2 Proof of mis-compile https://alive2.llvm.org/ce/z/7G8uE3
PR: https://github.com/llvm/llvm-project/pull/203620
