BSD Commit Log Search

Revert "[mlir][tensor] Add ValueBoundsOpInterface for ExpandShapeOp and CollapseShapeOp (#173356)"

This reverts commit 5154a05ef2c44697af0f51ef9e26e84422fd2d91.
It broke sanitizer build bots -- see
https://lab.llvm.org/buildbot/#/builders/52/builds/13831

Revert "[mlir][acc] Add ACCSpecializeForDevice and ACCSpecializeForHost passes (#173407)"

This reverts commit 51253b31551796c6857e56f48531e15923aa49c5.
It introduced a user-after-free reported by ASan -- see
https://github.com/llvm/llvm-project/pull/173407#issuecomment-3690793823

Revert "[mlir][acc] Add ACCIfClauseLowering pass (#173447)"

This reverts commit f64bc988959f1ac028d2b64500791014537d3706.

The revert is needed because this commit depends on a previous commit
(PR #173407) that is about to be reverted due to a use-after-free -- see
https://github.com/llvm/llvm-project/pull/173407#issuecomment-3690793823

[clang-tidy] Add fine-grained options to `misc-use-internal-linkage` (#173310)

There were several requests in #172797 to add fine-grained configuration
for this check: here it is. By default, everything is enabled.

Note: I think the tests could be better expressed if they were all in
the same file and used combinations of
`-check-suffixes={VAR,FUNC,TYPE}`, but I imagine merging all the tests
would have made reviewing confusing. Maybe a future PR?

[RISCV] Use TargetConstant for intrinsic IDs (#173517)

These should always use TargetConstant.

[BPF] Use Register instead of MCRegister for virtual reg. NFC

[IR] Change PHINode::removeIncomingValueIf() to loop incoming values backwards (#173444)

See discussion in
https://github.com/llvm/llvm-project/pull/172639#issuecomment-3686893143

If someone did `PN->removeIncomingValueIf([](unsigned Idx) { return Idx
== 0; })` to remove the first incoming value, current implementation
will remove all incoming values.

There are purely index based predicate use cases in:
-
https://github.com/llvm/llvm-project/blob/8c5a0f74a12d69d2fb7d6ed59f91759f18273bcd/llvm/lib/Transforms/Utils/LoopSimplify.cpp#L429
-
https://github.com/llvm/llvm-project/blob/8c5a0f74a12d69d2fb7d6ed59f91759f18273bcd/llvm/lib/Transforms/Utils/LoopUtils.cpp#L562

This patch makes `PHINode::removeIncomingValueIf()` to loop incoming
values backwards, to ensure `PHINode::removeIncomingValueIf()` working
as expected.

remove registerError

try moving MLIR_BINDINGS_PYTHON_NB_DOMAIN compile defn

ValueTracking: Avoid calling computeKnownFPClass on matched constant (#173248)

The fmul case already tries to match a literal value, we don't
need to match it twice.

[VPlan] Support binary add/sub in getSCEVExprForVPValue. (NFCI)

Handle binary add/sub in getSCEVExprForVPValue. This means we are able
to compute more replicate recipe costs in the VPlan cost model. It
should produce the same costs.

ValueTracking: Avoid calling computeKnownFPClass on matched constant

The fmul case already tries to match a literal value, we don't
need to match it twice.

ValueTracking: Improve computeKnownFPClass fmul handling (#173247)

Improve known non-nan sign bit tracking. Handle cases with
a known 0 or inf input of indeterminate sign.

The tails of some library functions have sign management
for special cases.

[SLP]Recalculate dependencies for all cleared entries

Need to recalculate the dependencies for all cleared items to avoid
a crash, if the entry is used in other vector nodes

Fixes #173469

InstCombine: Add baseline tests for exp SimplifyDemandedFPClass

Make KnownFPClass::exp not side-effecting

InstCombine: Handle exp/exp2/exp10 in SimplifyDemandedFPClass

I'm working on optimizing out the tail sequences in the
implementations of the 4 different flavors of pow. These
include chains of selects on the various edge cases.

Related to #64870

positive values never denormal

ValueTracking: Improve handling of exp intrinsic for overflow

Teach exp handling that positive inputs cannot introduce overflow,
and negative inputs cannot introduce underflow.

Remove redundant check

ValueTracking: Add baseline tests for computeKnownFPClass exp

This is already handled, but misses opportunities. Test cases
where the input is known positive or negative.

ValueTracking: Avoid calling computeKnownFPClass on matched constant

The fmul case already tries to match a literal value, we don't
need to match it twice.

Address comment

Always inf or nan

Make KnownFPClass::canonicalize not side-effecting

ValueTracking: Improve computeKnownFPClass fmul handling

Improve known non-nan sign bit tracking. Handle cases with
a known 0 or inf input of indeterminate sign.

The tails of some library functions have sign management
for special cases.

InstCombine: Handle canonicalize in SimplifyDemandedFPClass

Doesn't try to handle PositiveZero flushing mode, but I
don't believe it is incorrect with it.

ValueTracking: Add baseline tests for fmul computeKnownFPClass (#173246)

ValueTracking: Avoid calling computeKnownFPClass on matched constant

The fmul case already tries to match a literal value, we don't
need to match it twice.

Always inf or nan