[flang][OpenMP] Implement checks for rectangular loops (#190648)
Detect non-rectangular loops, emit diagnostic messages when the
construct requires that the affected loops are rectangular. Delete
similar checks from resolve-directive.cpp.
Issue: https://github.com/llvm/llvm-project/issues/185287
[pdb] Fix public symbol hashing in GSIHashStreamBuilder::finalizeBuckets (#190133)
BulkPublic.Name is not necessarily null terminated, so make sure not to
hash past its actual length.
In practice it would often be null terminated, but in the cases where it
was not, we would compute the wrong hash here, put it in the wrong hash
bucket, preventing debuggers from looking up the symbol by name, causing
issues such as
https://discourse.llvm.org/t/pdb-generated-by-lld-link-doesnt-point-to-correct-entry-point-when-debugged-using-visual-studio/90349
[mlir][lsp] Use rootUri and rootPath for source files (#185479)
When looking up source files, consider the rootUri and rootPath (if set) and filename is non local path.
[PowerPC] Optimize bitcast(truncate) patterns using vbpermq (#181233)
Use vbpermq and vbpermd to efficiently pack i1 vector bits into scalar
integers, avoiding stack operations during type legalization.
Fixes https://github.com/llvm/llvm-project/issues/171879
[ConstantFolding] Fix bitcasting vectors with non-integer ratios (#179640)
For both downcast and upcast this patch introduces support for
bitcasting vectors with non-integer ratios [1, 2]. Also this patch
increases the coherence between casts [3].
1. Fixes a crash on downcast where the ratio is not an integer (e.g., <3
x i32> to <4 x i24>). Previously this led to leading to an incorrect
number of result elements and subsequent crashes in RAUW.
Fixes #179626
2. Fixes a miscompilation on upcast where ratio is not an integer (e.g.,
<4 x i24> to <3 x i32>). Previously this led to wrong result.
Fixes #181195
3. Fix incoherent value emitting between down/up cast
a. When upcasting, emit Poison and Undef not only if the source vector
consists of only one of these values. (e.g., `bitcast <4 x i32> <i32
undef, i32 undef, i32 1, i32 undef> to <2 x i64>` returns `<2 x i64>
[3 lines not shown]
[lldb] Add setting to specify (by name) which module's scripting resources can be auto-loaded (#188722)
* Depends on: https://github.com/llvm/llvm-project/pull/189696
This is part of [this
RFC](https://discourse.llvm.org/t/rfc-lldb-moving-libc-data-formatters-out-of-lldb/89591)
which is about turning the libc++ data-formatters into auto-loadable
Python scripts.
Eventually we want the Python data-formatters for `libc++` to be
automatically loaded without requiring user opt-in (since that's how the
builtin formatters have always worked and, in my opinion, we can't
transition to an opt-in model if users have always had the
data-formatters available). To do so we need a way to distinguish which
modules we can *always* auto-load from safe-paths, and which require
`target.load-script-from-symbol-file` to be set to `true`.
This patch adds a setting (`target.auto-load-modules`) that is a
dictionary from module-name to the `LoadScriptFromSymFile` enum,
[21 lines not shown]
[lldb] Make argument to ConstString::AsCString explicit (#190183)
This patch makes the default parameter to ConstString::AsCString
explicit. Currently it defaults to `nullptr`. However, there a bunch of
callsites that do `printf("%s", foo.AsCString())`, which is UB (I have
at least 1 crash on me where this was the root cause).
Alternatively we could change the default to `""` instead of `nullptr`,
but code that did `if (foo.AsCString())` would then change meaning.
Command I ran to generate this patch:
```
rg "\.AsCString\(\)" lldb -l | xargs sed -i '' 's/\.AsCString()/.AsCString(nullptr)/g'
```
There's also a commonly used `Status::AsCString` with a default
parameter. So I added a temporary:
```
const char *AsCString(std::nullptr_t) const = delete;
[7 lines not shown]
Revert "[Driver] Update SYCL runtime library name and path for target-specific directories" (#190715)
Reverts llvm/llvm-project#189053
Needs to go together with
https://github.com/llvm/llvm-project/pull/188770/
[Offload] Fix trailing '\0' in ISA name (#190791)
Summary:
Recent changes broke this handling by creating a string-ref that
included the null byte. This made the StringRef compare for the
environemtn ISA with the user ISA fail trivially due to mismatching
sizes.
[CIR] Implement constructor 'try-body' lowering (#190613)
C++ supports the ability to have the 'body' of a constructor be a 'try'
block. The effect of this is that base construction and initializers are
also within the same try/catch chain. This patch implements this
lowering.
Classic codegen does this by just emitting the 'begin' and 'end' try as
their own functions, then can emit the body separately between calls.
However, CIR doesn't really afford us that ability, so this patch
extracts a function that takes a callback object that is used to emit
the function body. This allows us to do a simple 'emitStmt' in the
normal cases, plus a `emitCtorPrologue` followed by `emitStmt` in the
try-body case.
[flang][OpenMP] Introduce `semantics::omp::LoopControl` (#190647)
This structure will contain the symbol for the iteration variable, the
lower and upper bounds, and the increment if present in the form of
evaluate::Expr. A source construct (such as DO CONCURRENT) may have
several iteration variables, each with its own bounds and increment,
represented by a list of LoopControl structures.
For loop-transformation constructs that produce additional loops the
current code returns an empty list of LoopControls, but it may be
extended in the future to represent the yet-nonexistent loops for more
accurate semantic analysis.
The code introduced in this PR is not executed yet, but will be used in
an upcoming PR.
Issue: https://github.com/llvm/llvm-project/issues/185287
---------
Co-authored-by: Michael Kruse <llvm-project at meinersbur.de>
[SPIR-V] Use OpDecorateId instead of OpDecorate for memory aliasing decorations (#190731)
AliasScopeINTEL and NoAliasINTEL decorations take ID operands, so they
must use OpDecorateId rather than OpDecorate per the SPIR-V spec
related to #190736
[CIR] Implement aggregate-expr-init with a const-expr lowering (#190631)
An aggregate initialized by a ConstantExpr happens when you have a
consteval constructor. This patch implements this lowering.
There is a bit of a difference in decisions between classic-codegen and
cir lowering, where classic-codegen will do init-via-GEP, whereas CIR
does either a struct-store, or a memcpy, otherwise these seem identical.
There IS a branch (if emitting a constant-expr fails) that appears dead
to the best of my knowledge, but since classic-codegen does it, I left
the version there. It is at most a pessimisation of the constant-emit
(just emitting the expression), so it shouldn't cause problems.
[CIR] Implement lowering for member-expr of function decl type (#190655)
This patch ends up being pretty trivial to reproduce, and the
implementation is just to call an already implemented function, however
this shows up a few times in various test suites. So I've implemented
it.
