[SampleProf][test] Precommit test: loaded profile is re-read on incremental read with a remapper (#231339)
Precommit test showing that `SampleProfileReaderExtBinaryBase::readFuncProfiles` decodes an already-loaded function profile a second time, and merges it into itself, when an incremental read happens while a symbol remapping file is in use.
A follow-up change intends to fix this.
Assisted by: Gemini and Claude
[MemProf] Handle missing alloc contexts in backend assertion checking (#232422)
The combined index only serializes the MIB stack ids for allocation
records when -combined-index-memprof-context is enabled, which defaults
to false in NDEBUG builds. When the thin link is performed by a release
build but the ThinLTO backends are compiled with assertions enabled, the
distributed indexes contain empty MIB contexts, and checkAllocContextIds
in the backend asserts because the summary context is shorter than the
IR metadata context.
Since the MIB context in the summary can never be empty after trimming
the allocation's callsite context, treat an empty context as not
serialized and skip the stack id checking for that MIB.
Add a regression test to memprof-basic.ll that performs a distributed
thin link with -combined-index-memprof-context=false and then runs the
backend.
Assisted-by: Gemini
[HLSL][DirectX] Handles GEPs in dxil resource access pass (#224754)
Add support to traverse through GEPs in dxil resource access pass, as
well as support getbasepointer which is used by cbuffers.
Closes #224102
Assisted by GPT-5.6 Sol, Claude Opus 5.5 and @inbelic
---------
Co-authored-by: joaosaffran <joaosaffran at gmail.com>
[flang][OpenMP] Switch clause verification to descriptor-based
Delete all the scattered pieces of clause verification that are now
replaced by the unified handling.
[mlir][Arith] Move ceil/floor div expansion to Conversion/ArithCommon. NFC (#231064)
MLIRArithToLLVM depends on MLIRArithTransforms, which pulls in
Bufferization, SCF, Shard, SparseTensor, Tensor, and Vector, only for
populateCeilFloorDivExpandOpsPatterns (#118839). ClangIR reaches
MLIRArithToLLVM through MLIROpenMPToLLVM.
Move the patterns to a new library, MLIRArithCommonConversion. The
declaration moves from Arith/Transforms/Passes.h to
Conversion/ArithCommon/CeilFloorDivExpansion.h.
LLM-aided. With -DCLANG_ENABLE_CIR=ON, clang links 14 fewer MLIR
libraries (89 -> 75).
[DebugInfo] Emit DW_AT_LLVM_address_space for AMDGPU (#220789)
LLVM emits a pointer type's DWARF address space as DW_AT_address_class,
but the
AMDGPU DWARF extensions define DW_AT_LLVM_address_space for exactly
this, so emit
that attribute on AMDGPU targets. Other targets keep
DW_AT_address_class; NVPTX in
particular fills it in via translateToNVVMDWARFAddrSpace() for cuda-gdb.
The choice
goes through a new getTypeAddressSpaceAttribute() hook on DwarfDebug
that
AMDGPUDwarfDebug overrides, installed via createDwarfDebug() as NVPTX
does, so
DwarfUnit.cpp stays target independent.
Depends on: https://github.com/llvm/llvm-project/pull/220728
[asan] Adopt sanitizer_common operator-new framework (#196388)
This completes the series that makes AddressSanitizer's `operator new`
conform to [new.delete.single]/3-4 (google/sanitizers#295), building on
#196413, #200719, #201151, #202816, #213077, #225847, #231994 and
#226832.
ASan's eight `operator new` overrides now use the shared framework in
`sanitizer_new_operators.inc`. On allocation failure they call the
current `std::new_handler` until allocation succeeds or the chain is
exhausted. After that:
- `allocator_may_return_null=0` (default): report out-of-memory and
abort once the handler chain is exhausted. Programs that install a
`std::new_handler` now see it run first; previously ASan never called
it.
- `allocator_may_return_null=1`: throwing `new` throws `std::bad_alloc`
(aborts if the runtime is built without exceptions, e.g. on Windows);
nothrow `new` returns `nullptr`.
[26 lines not shown]
[Clang][Sema] Add fortify warnings for vsprintf (#230672)
Extend the `sprintf` `-Wfortify-source` format overflow check in `Sema::checkFortifiedBuiltinMemoryFunction` to also cover `vsprintf`, `__builtin_vsprintf`, `__builtin___vsprintf_chk`, and `__builtin_sprintf`.
Also translate the format string argument index via `Checker.TranslateIndex`, fixing a latent bug when `sprintf` or `__builtin___sprintf_chk` is wrapped with `__attribute__((diagnose_as_builtin(...)))`.
Part of #142230
Assisted-by: Gemini
[TableGen][AArch64] Check the inner operator name before folding (any_of FeatureAll, (any_of ...)) to (any_of FeatureAll, ...). (#232116)
We only checked the outer operator was any_of, we didn't check the inner
operator.
Allow (any_of FeatureAll, (all_of FeatureX)) if the inner all_of has a
single feature. This supports the AArch64 usage of
AssemblerPredicateWithAll.
DAG: Don't export arguments for FastISel if it won't be used (#232309)
LowerArguments decided whether to export arguments to virtual
registers based on TM.Options.EnableFastISel. That option is set at
-O0 even for targets that have no FastISel implementation. This is
unnecessary without fast isel, so stop doing that.
The unneeded CopyToReg was an extra use of every argument, which
blocked some combines. The dead copies also survived to register
allocation. These copies were an edge case that regallocfast would
introduce dead flags on.
Co-authored-by: Claude Opus 5.5 <noreply at anthropic.com>
[LiveDebugValues] Add a limit on the number of stack slot indexes (#225950)
MLocTracker reserves a machine location for every subregister index of
every tracked stack slot, so on targets with a large number of
subregister indexes the memory and time cost of spill tracking grows
sharply.
Add -livedebugvalues-max-stack-slot-idxes as a counterpart to the
existing -livedebugvalues-max-stack-slots, stopping spill tracking when
a target exceeds it.
[flang][OpenMP] Improve diagnostics about modifier properties
Use OpenMPDeprecated and OpenMPFuture warning categories for modifier
diagnostics as well, analogously to how they are used for clauses.
[flang][OpenMP] Account for using different versions for modifier checks
When a modifier from a past/future version is accepted, use its properties
from the nearest version in which it is allowed.
[flang][OpenMP] Create generic interfaces for "container" entities
In short, clauses are containers of modifiers, and directives are
containers of clauses. With the abstractions in place, clauses and
modifiers look almost the same from the point of view of syntactic
properties.
Use these functions to implement generic GetAllowedElements and
GetElementVersionRange functions.
[flang][OpenMP] Properly use GetAllowedElements
Allowed elements are not just those explicitly listed, but also those
from the union of allowed sets.
For example, the set of modifiers allowed on a clause are those that
are listed on a given clause, plus the union of all modifier sets that
the clause allows.
[AMDGPU][CodeGen] Split downward RP tracker auto/manual modes (NFC) (#231862)
Many of the core methods of `GCNDownwardRPTracker` use a combination of
a `*MI` and `UseInternalIterator` arguments to determine whether they
should rely on program order or use user-provided instructions to
determine the next instruction to advance over to compute RP changes.
This ties two different use cases together that should never mix, and I
find that it makes it hard to track what is happening.
This splits the two use cases cleanly using different classes inheriting
from a new base class `GCNDownwardRPTrackerBase`.
- `GCNDownwardRPTracker` (same class name as before) now only supports
iteration following program order (`UseInternalIterator==true`).
- `GCNManualDownwardRPTracker` only supports iteration following
user-provided MIs. This only has one usage, in the scheduler.
I find this simplifies the code significantly. It also eliminates a
useless call to `advanceBeforeNext` that happened when
`UseInternalIterator==false` in the `advance` method.
[bazel][libc] Add missing deps to __support_printf_core_printf_converter (#232407)
#230246 (509679cf9c9d) added includes of
src/__support/CPP/type_traits.h, src/__support/wctype_utils.h, and
hdr/types/size_t.h to printf_core converter headers.
Add the corresponding :__support_cpp_type_traits,
:__support_wctype_utils, and :types_size_t dependencies to
__support_printf_core_printf_converter in libc/BUILD.bazel.
