[MemProf] Make the early inliner ignore the sample profile (#235975)
For MemProf we use the early inliner to aid matching, in particular to
better handle allocation contexts with missing leaf debug frames.
For iPGO the early inliner runs before profile annotation so there is no
existing profile data. But with SamplePGO, there will be profile info in
the IR when the early inliner is run, which will affect the inlining
decisions. If a new SamplePGO profile contains additional hot functions
beyond those in the binary that was memprof-profiled, this can result in
the early inliner performing additional inlines. Because of the way the
memprof profile is structured (profile information for calls and
allocations are included for each function up through the first
non-inline frame), additional inlining means we will not find the
profile information for a call or allocation when matching.
Add a new InlineParams to ignore the profile, which we set when
performing early inlining for MemProf after SamplePGO loading.
Assisted-by: Gemini
[libc][unistd] Add getgroups syscall wrapper. (#237020)
Unlike `initgroups` and `setgroups`, `getgroups` is standardized in
POSIX.1-2024, and should
be provided by `<unistd.h>` header. Implement it as a simple syscall
wrapper around `getgroups32` syscall,
similar to `setgroups`. Since it's a getter function, it doesn't need
setxid propagation across threads,
and thus can be added to regular (non-experimental) entrypoints list on
various Linux platforms.
Assisted by: Gemini, human-verified.
[LICM] Refactor common parameters for LICM and LoopSink APIs (NFC) (#236798)
We pass around a whole bunch of analyses and adding a new one becomes a
massive chore.
[mlir][transform] Add linalg.fold_reshape_ops_by_expansion transform op (#233732)
Exposes `linalg::populateFoldReshapeOpsByExpansionPatterns` as a
transform dialect op `linalg.fold_reshape_ops_by_expansion`.
The op collects patterns that fold reshape operations into their
producers or consumers by expanding dimensions, including patterns for
`linalg` and `tensor.pad` operations.
The op has a single bool argument `fold_single_use_only`, defaulting to
`false`. If set, only ops whose producer has only one use are
considered.
Assisted-by: Claude
[flang] Fix REAL(10) Read() endianness for big-endian hosts (#234842)
On big-endian hosts (e.g. AIX), for REAL(10), the 80-bit value sits in
the low-order bytes of the `uint128_t`. `X87IntegerContainer` stores its
16-bit parts from byte 0, so only the top 32 bits of the value were
read, into the low bits of the word. The result was always a subnormal
(or zero) with the sign lost, instead of the correct value.
Build Word from lo/hi `uint64_t` halves via the `Integer<>` integer
constructor, which uses `SetLEPart()` and is endian-portable. Also
remove the AIX_WARNING test expectations, which only reflected the bug.
https://github.com/llvm/llvm-project/pull/216958 exposes this bug and
cause the following failures on AIX:
```
Failed Tests (3):
flang-Unit :: Evaluate/./FlangEvaluateTests/RealValueKind/RealValueKind/AsFortran/REAL_10
flang-Unit :: Evaluate/./FlangEvaluateTests/RealValueKind/RealValueKind/FromIntegerPowersOfTwo/REAL_10
flang-Unit :: Evaluate/./FlangEvaluateTests/RealValueKind/RealValueKind/Read/REAL_10
[9 lines not shown]
[SystemZ][z/OS] Refactor lowerConstant() (#236945)
The `lowerConstant` implementation is hard to read, and this refactor
should improve it.
- Getting the symbol now only depends an `GA` (Alias), `FV` (Function),
and `GV` (Variable), making it clear that `Sym` is never `nullptr` in
these cases.
- Early exit for all other cases.
- Condition to identify if the constant is a function is moved inside
the `if` condition, as this is the only user left.
- No `MCSA_ELF_TypeFunction` set. This is either set at the
function/alias in the local case, or when external references are
declared.
- ADA is set for MCSA_ELF_TypeObject, because it is required for data
objects.
The test case is updated to reflect all 3 possibilities.
Assisted by: IBM Bob
[AArch64] Sink interleave operation near store (#234893)
Sinking profitable interleave operation near store, so dag combine can
form stN instruction.
It is only profitable when both operation is inside a same loop.
Revert "[lldb][test] Disable TestFrameProviderStepping.py on Windows temporarily" (#237221)
Reverts llvm/llvm-project#234889
#234888 has been fixed by #235909.
[CIR] Shard generated operation definitions (NFC) (#232894)
`CIRDialect.cpp` includes the TableGen-generated definitions of all CIR
operations (`CIROps.cpp.inc`, ~5.1 MB). It is the slowest translation
unit in a ClangIR-enabled build and sits on the critical path to linking
`clang`. Nothing in the source is slow by itself: the time is spread
over ~23k generated functions, ~80% of it in the optimizer and code
generation.
This patch splits the generated definitions into eight shards. It
follows the approach used for the
LLVM, NVVM, ROCDL, and SPIR-V dialects (#221813, #221812, #221729,
#221811):
- `CIROps.{h,cpp}.inc` are generated with `-op-shard-count=8`.
- `mlir-src-sharder` produces `CIROpDefinitions.{0..7}.cpp` from a new
`CIROpDefinitions.cpp` template, and these are compiled as part of
`MLIRCIR`.
- `CIRDialect::initialize()` uses the generated
[25 lines not shown]
[libc++] Remove unused type_info constructor (#235739)
We have a constructor taking a `const char*` since the initial import.
It's unused in the library and neither the C++ standard nor the Itanium
ABI require it. Since all `type_info` instances are magicked into
existence by the compiler it doesn't make a ton of sense to have a
constructor either.
[mlir][tosa] Add integer bitwidth conversion pass (#232853)
Add tosa-convert-integer-types-bitwidth to convert i4 to i8 and/or i48
to i64. This is useful to facilitate lowering to backends that do not
support i4 and/or i48.
Add a host byte-order lit feature to gate tests with little-endian
resource data.
Assisted-by: Codex
[SLP] Freeze undef operand of shl X, 1 expanded to add X, X
add X, X reads X twice, so it does not refine shl X, 1 when X is
undef. Freeze the operand and blend the frozen lanes into the other
operand, unless X is proven not undef or undef X triggers UB.
Assisted-by: Cursor
Reviewers:
Pull Request: https://github.com/llvm/llvm-project/pull/237207
[CIR][AMDGPU] Lower cir.offload.printf to AMDGPU printf (#231563)
Add lowering for cir.offload.printf to the AMDGPU printf logic employed
by OGCG. Most of the functions added in
clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVMOffloadPrintf.cpp are CIR
equivalents to the functions in
llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp.
Assisted-by: Claude Opus 5.5
---------
Signed-off-by: Steffen Holst Larsen <sholstla at amd.com>
[libc++] Add a few _LIBCPP_HIDE_FROM_ABI which have been accidentally removed in #201722 (#236733)
These annotations should have stayed, since the functions are in a spot
where explicit annotation are required.
[libc++][NFC] Move checks whether mutex/condition_variable are trivial to their headers (#236806)
The moved macros are only used as implementation details of `mutex` and
`condition_variable` aren't used widely within the library, so they can
be moved to be more local.
