[IR][GC] Remove leftover typed pointer handling for gc.relocate (#235783)
There is various handling for pointer bitcasts of the result, which can
be dropped now that we have opaque pointers and the verifier ensures
that the return type of gc.relocate returns the same type as the derived
pointer. The verifier is adjusted to check that explicitly -- the
previous check incorrectly allowed the types to differ in element count.
LLM generated patch.
[Clang][ABI][X86] Don't extend _BitInt returns to 64-bits (#234872)
For X86, _BitInt(N) with N <= 32 is passed iN, while for 32 < N <= 64
it's passed as i64. I don't think there is any good reason for this
difference in behavior, and we should always use iN.
Nominally, this does not change the ABI. The previous Direct pass as i64
implied that the high bits are unspecified. In practice, the callee
zero-extended the value (independent of _BitInt signedness), but the
caller did not rely on that zero-extension. With CIR it was zero or sign
extended, depending on signedness. Both are ultimately correct (because
the high bits are unspecified).
This still leaves behind a peculiarity for 64 < N < 128, which gets
returned as `{ i64, i64 }`, until we reach N=128, when it switches to
`i128`. I believe all of those should also use iN, but I'll leave that
for a separate change. I'm also not changing argument passing here.
Followup to https://github.com/llvm/llvm-project/pull/232729.
[mlir][NFC] Fix some different sign comparison warnings (#234999)
I saw these doing a build on Arm 32-bit, but I don't think they're
specific to it.
* OperationSupport.h: std::distance returns a signed type but
kSmallAttributeList is unsigned. I assume first is always before last,
so it's safe to cast std::distance to size_t.
* In MemRefOps.cpp: srcStaticCount is created using llvm::count_if, but
the type is changed. Then later compared to another llvm::count_if.
Fixed that by using auto to keep the same type.
* ModuleTranslation.cpp: numArguments is unsigned, and by using
llvm::range_size we get a size_t we can compare to.
[AMDGPU] Update check lines with extra text at the start or end. NFC. (#236029)
This comes from re-autogenerating the checks, but only committing a
specific kind of change where the check line gets extra text at the
start or end. These are cases where the existing check line only worked
because it did not have {{^}} or {{$}} anchors.
[mlir][tosa] Move ResizeOp shape checks from verifier to tosa-validate (#234101)
Part of #233457.
`ResizeOp::verify()` reads `scale`/`offset`/`border` from their
`tosa.const_shape` producers and checks their values. That is not local
to the
operation, so these `ERROR_IF` conditions move to `tosa-validate`.
Changes:
- `ResizeOp::verify()`: drop the constant-value checks (non-positive
scale,
output size divisibility / calculated size); keep only the local check
that
block-scaled input requires `NEAREST_NEIGHBOR` mode.
- `checkErrorIfResize()`: add the missing `scale > 0` check.
- `levelCheckResize()` and `ResizeOp::inferReturnTypeComponents()`: bail
out on
[2 lines not shown]
[ARM] Don't map ISD::STRICT_FRINT to vector VRINTX (#234644)
The VRINTX instruction on a scalar float respects the rounding mode in
FPSCR, but on a vector of floats, it rounds to nearest always. That
makes it the wrong choice for ISD::STRICT_FRINT, which must use the
dynamic rounding mode. It's only acceptable for ISD::FRINT.
This applies to both MVE and NEON. (The latter only for Armv8 and above:
Armv7 NEON doesn't have that instruction in the first place).
[OpenMP][offload] Trade threads for blocks in Generic-SPMD kernels (#234191)
For Generic-SPMD mode, the trip count refers to the outer distribute
loop, the per-iteration cost is unknown. So, prefer more blocks and less
threads for this exec mode. This prevents large blocks with only few
active threads.
This is an upstream port of the corresponding downstream.
Claude assisted with this patch.
[CODEOWNERS] Drop all notifications (#236030)
The author would like to drop all CODEOWNERS notifications added in
c4e40dc23 ([CODEOWNERS] Request notifications, #227742) as they have
realized a sharp downside: it is impossible to distinguish cases where
their review was explicitly requested.
See also: #228086.
[InstCombine] Remove redundant separate_storage assumes (#233736)
When it can already be proven that two pointers don't alias without the
`separate_storage` assume there is no point in keeping
`separate_storage` assumptions around.
[AMDGPU] Restore gfx90a predicate on V_MUL_LEGACY_F32_e64_gfx90a. NFCI. (#232035)
#116288 removed both the AssemblerPredicate and SubtargetPredicate of
isGFX90APlus that applied to V_MUL_LEGACY_F32_e64_gfx90a, leaving it
with no predicates at all. Since it has a different encoding from the
GFX6-GFX10 versions of v_mul_legacy_f32_e64, this meant that the asm
matcher could have selected the wrong encoding on those targets. It
only selected the right one because V_MUL_LEGACY_F32_e64_gfx90a is
defined last.
Restore an AssemblerPredicate of isGFX90APlus on just this instruction,
and fix the stale closing comment on the let block that used to set it
for all of the gfx90a multiclasses.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply at anthropic.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply at anthropic.com>
use getDeviceBlockLimit instead of OMP_NUM_TEAMS
Trade threads for blocks only while the doubled number of blocks stays within
the device's block limit, which OMP_NUM_TEAMS may lower, instead of not trading
at all if OMP_NUM_TEAMS is set. This keeps every trade a pure one and leaves
getDeviceBlockLimit as it was.
Claude assisted with this patch.
[flang][MIF] Adding lowering for EVENT POST/WAIT statements (#210283)
Add lowering of EVENT POST and EVENT WAIT statements to the MIF dialect
(mif.event_post / mif.event_wait), and lowering of coarray references in
hlfir.designate.
- The event variable is passed to PRIF together with the byte offset of
the event inside its coarray, computed in MIFOpConversion
- The default initialization of event_type coarrays after
prif_allocate_coarray.
- Add lowering tests for EVENT POST / WAIT.
Nonallocatable coarrays are allocated by PRIF, so their storage is on
the heap. This
patch lowers them like allocatable variables:
- `ConvertTyp`e: the type of a coarray is now a !fir.box<!fir.heap<...>,
corank:N> so every descriptor for coarrays carries
CFI_attribute_allocatable.
[12 lines not shown]
[NFC][analyzer] Replace generateErrorNode with addSink (#235749)
This change replaces use of `CheckerContext::generateErrorNode` with
`getSink`, then deletes `generateErrorNode`. Textually replacing
`generateErrorNode` with `addSink` will correctly update _most_
downstream checkers; but calls of the form `C.generateErrorNode(State,
Tag)` (if there are any – there wasn't any in upstream) would need to be
updated to `C.addSink(State, C.getPredecessor(), Tag)`.
This change was motivated by the fact that `addSink` and
`generateErrorNode` did the same thing, so their separate existence
caused lots of confusion (e.g. it implied that an "error node" is
somehow different from a regular node, which was completely false).
`generateErrorNode` was the more widespread among them (roughly 80 vs 40
call sites in checkers), but its name isn't suitable for the dozens of
cases where the sink is not used for an "error" (bug report), so I
decided to keep `addSink` as the only sink-making method.
[3 lines not shown]
[clang][CodeGen] Use the primary base chain for virtual method IDs
Identify a virtual method in the call graph section after the method it
overrides along the primary base chain of its class, as given by the record
layout. That is the vtable entry the method is placed in, which is not always
the first method it overrides.
Assisted-by: Jetski
[Support] Check whether a file is local by its handle on Windows (#233727)
To tell whether an open file is on a local disk, `is_local` resolved
its handle to a path with `GetFinalPathNameByHandleW`, found the volume
with `GetVolumePathNameW` and checked it with `GetDriveTypeW`.
This chain is pretty expensive. `GetVolumePathNameW` alone
takes 0.2-0.4 ms. `mapped_file_region` does this check on every unmap,
slowing down the on-disk CAS.
Ask the volume through the handle first. `NtQueryVolumeInformationFile`
returns its device type and characteristics in one call. A disk device
that is neither removable nor remote is a fixed local disk. Any other
answer, or a failed query, falls back to the path-based check as before.
A cache hit of a single-file compile is 2.1% faster through the
dependency scanning daemon and 1.4% faster in-process. Measured with
clang compile caching on the on-disk CAS in the swiftlang/llvm-project
fork.
[RISCV][P-ext] Add isel pattern for maccu.h01/maccu.h11 (#235998)
`maccu.h01` multiplies the zero-extended lower half word of rs1 by the
zero-extended upper half word of rs2 and adds the product to rd.
`maccu.h11` does the same with the zero-extended upper half words of
both.
Previously, (srl X, 16) was selected as a separate srli feeding
`maccu.h00`. Match it directly so the shift is folded. As with
`maccu.h00`, the patterns require the multiply to have a single use.
[libc++] Implement LWG4245: Operators that interact with counted_iterator and default_sentinel_t should be noexcept (#235445)
Mark `counted_iterator`'s `operator-` overloads and `operator==` taking
`default_sentinel_t` as `noexcept`, as required by the resolution of
LWG4245. They only read the stored count. Applied as a defect report to
every mode where `counted_iterator` exists (C++20 and later).
The existing `minus.default_sentinel.pass.cpp` and `compare.pass.cpp`
now check `noexcept` for both argument orders and the rewritten `!=`
forms. They fail without the header change and pass in C++20 and later.
Fixes #148226
[sanitizer_common][test] Require Android API 26 for variadic-open and allow_user_segv (#236010)
On Android API 24 emulators:
- `Posix/variadic-open.cpp` fails on `O_TMPFILE` because the older
kernel returns `EISDIR` when `O_TMPFILE` is not supported.
- `Linux/allow_user_segv.cpp` fails flakily across API 24 targets (not
just `i386`) due to the legacy `debuggerd` daemon racing on `waitpid`.
Require `android-26` when running on Android for both tests.
https://lab.llvm.org/buildbot/#/builders/sanitizer-x86_64-linux-android
Assisted-by: Gemini
[llvm] Remove incorrect IRMover assert (#221758)
The IRMover had an assertion that failed on modules with correct code.
The assert fired in an out-of-tree frontend.
Remove the assertion to fix that.
The assertion has been there for a long time (10 years if I read git
blame correctly) as the failing case cannot be hit when loading
completely separated modules (i.e. this is not reproducible with
`llvm-link`). It is however reproducible when generating modules from
code. One peculiarity is that a named struct type needs to be used in
both, the source and target module that are linked. As types are stored
in the LLVMContext, not in the Module, I believe this is still correct
IR and the IRLinker/Mover should be able to handle that correctly.
Concretely, the assert fired when filling `MappedTypes`. The dst Module
contains `%SharedTy`,
the src Module contains `%SharedTy` (exact same type) and `%Ty2`
(structurally equivalent to `%SharedTy`).
[9 lines not shown]
[clang][test] Add `--normalize=` parameter to ast_dump_json_test.py (#235789)
To replace the value of the matching json field with a regex.
Also update the output to list more passed command line parameters.
I've updated two test files as examples and to test the output doesn't
change otherwise.
Assisted by claude.
[RISCV] Reassociate exts in ext/add reduction tree (#230928)
With an ext-add-ext-add pattern, the second ext can be pushed to after
the final add if the first ext adds enough bits to guarantee that the
second add won't overflow even without the second ext.
Further optimize ext-add reduction in x264 sad_NxN, building on #230657.
AI Usage: Assisted by Codex
