sockets: repair sctp_peeloff(2)
The shim function soattach() may be passed a non-listening socket by SCTP.
NB: the change makes soattach() more hairy, but long term plan is that
this function goes away.
PR: 293010
Fixes: 64f7e3c9c178ab35cb1f8fdf791aec74ede6f6b2
net/mosquitto: Update pkg-plist
The PR reports that consumers of the client library were missing
include files.
PR: 293004
Reported by: alexander at wittig.name
qlnxe: Overhaul setting the multicast MAC filters
When operating the multicast MAC filters, the current usage of
ECORE_FILTER_ADD and ECORE_FILTER_REMOVE are rather misleading.
ECORE_FILTER_ADD reads "adding new filter", but it actually removes
any existing filters and then addes a new one. ECORE_FILTER_REMOVE
reads "removing a filter", but it actually removes all filters.
Let's use ECORE_FILTER_REPLACE and ECORE_FILTER_FLUSH instead to
avoid confusion.
In the current implementation, only one MAC address is passed to
ecore_sp_eth_filter_mcast() and any previously installed filters are
removed, hence it breaks the multicast function. That can be observed
via either assigning new IPv6 addresses to the interface or putting
the interface as a member of lagg(4) interface with LACP aggregation
protocol. Fix that by calculating the multicast filter bins directly
from multicast MAC addresses and replace the filters every time
the bins changes.
[18 lines not shown]
qlnxe: Allow tapping the TX packets
Currently only the packets in the RX path can be captured by tcpdump
as the ETHER_BPF_MTAP call in the TX path is missing. Add it so that
packets in both directions can be captured.
PR: 290973
Reviewed by: kbowling
MFC after: 5 days
Differential Revision: https://reviews.freebsd.org/D54891
qlnxe: Refactor setting the promiscuous and allmulti mode
There are two entry points to set the promiscuous and allmulti mode.
One is ioctl, and another is the init routine. Given they share almost
the identical logic, refactor a little to make the code more clear.
While here, for the ioctl, translate the error to EINVAL to avoid
confusing the net stack.
Reviewed by: kbowling
MFC after: 5 days
Differential Revision: https://reviews.freebsd.org/D54890
qlnxev: Remove now unneeded include for opt_inet.h
Since the change [1], this is not required anymore.
This change partially reverts commit 8a847947153e.
[1] 4012b63889e4 qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl
Reviewed by: kbowling
MFC after: 5 days
Differential Revision: https://reviews.freebsd.org/D54889
qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl
Since the change [1], the init routine qlnx_init() works as intended.
Let ether_ioctl() handle SIOCSIFADDR to simplify the code.
Combined with the change [1], this shall be a better fix for PR 287445.
[1] c10e6bc0f007 qlnxe: Avoid reinitializing the interface when it is already initialized
PR: 287445
Reviewed by: kbowling
MFC after: 5 days
Differential Revision: https://reviews.freebsd.org/D54888
qlnxe: Avoid reinitializing the interface when it is already initialized
qlnx_init_locked() unconditionally uninitialize the interface thus is
actually reinitializing the interface. Well the init routine qlnx_init()
is to initialize the interface by net stack when assigned with the first
inet or inet6 address. The ioctl SIOCSIFADDR for the first inet6 address
is handled by ether_ioctl() thus the interface is reinitialized no matter
it was initialized or not.
Add a driver status check for that to avoid reinitializing. Further plan
is removing SIOCSIFADDR ioctl from the driver and let ether_ioctl() handle
it.
Reviewed by: kbowling
MFC after: 5 days
Differential Revision: https://reviews.freebsd.org/D54887
qlnxe: Fix setting the unicast MAC filter of RX path
When an Ethernet interface is added to lagg(4) as a child interface, its
type, aka if_type, is changed from IFT_ETHER to IFT_IEEE8023ADLAG. Well
changing the link-layer address of the lagg(4) interface will be
propagated to all child interfaces, hence the drivers of child interfaces
shall not presume the type of the interface will not be changed.
Meanwhile, on initializing, an ifnet has been fully attached and it is
guaranteed to have non-null link-layer address so stop NULL checking for
it.
Reviewed by: kbowling
Fixes: 792226e53023 qlnxe: Allow MAC address override
MFC after: 5 days
Differential Revision: https://reviews.freebsd.org/D54885
qlnxe: Remove a pointless copy back from the link-layer address
On ifnet attaching, ether_ifattach() makes the link-layer address by
shadow copying the ha->primary_mac. Well, the link-layer address will
not be altered during attaching, thus it is pointless to copy it back.
No functional change intended.
Reviewed by: kbowling
MFC after: 5 days
Differential Revision: https://reviews.freebsd.org/D54883
qlnxe: Prevent potential concurrency between ioctls
The driver-managed status flags should be lock protected to be touched.
Also this can serialize ioctls those check the IFF_DRV_RUNNING status.
Reviewed by: kbowling
MFC after: 5 days
Differential Revision: https://reviews.freebsd.org/D54886
qlnxe: Avoid memcpy with same source and destination
In case the device is VF, qlnx_get_mac_addr() returns ha->primary_mac
hence it ends up memcpy with same source and destination. Refactor
slightly to avoid that.
Reviewed by: kbowling
MFC after: 5 days
Differential Revision: https://reviews.freebsd.org/D54884
devel/transient: Update 0.11.0 => 0.12.0, take maintainership, improve port
Changelog:
https://github.com/magit/transient/blob/v0.12.0/CHANGELOG
Improve port:
- Add option INFO.
- DOCS, INFO and PDF build-depend on GNU sed.
- Fix build with DOCS off.
- BUILD_DEPENDS==RUN_DEPENDS => move dependencies to _BR_DEPENDS and use:
BUILD_DEPENDS=_BR_DEPENDS
RUN_DEPENDS=_BR_DEPENDS
- Move makeinfo from USES to DOCS_USES.
- Split long line MAKE_ENV and remove "+".
- Move pkg-plist to PLIST_FILES in Makefile - 3 files in list only.
- Remove CONFLICTS_INSTALL=transient-devel-emacs* -
devel/transient-devel remove from tree 2025-09-01.
PR: 292945
Co-authored-by: Vladimir Druzenko <vvd at FreeBSD.org>
lang/gcc16-devel: Update to 16.0.1.s20260201
Also introduces a fix for upstream bug
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=123366, authored by
Mark Millard <marklmi at yahoo.com>.
Co-authored-by: Mark Millard <marklmi at yahoo.com>
hwpstate_amd(4): Revamp the softc
As the new CPPC and old P-states modes are exclusive, put their
respective data in a union.
Rename the field containing the content of the CPPC_REQUEST register.
It it now to be accessed using 'cppc.request'.
Use an 'unsigned int' instead of 'uint32_t' for 'flags'. This is an
internal field whose width could be changed at will. We only have one
flag at the moment.
No functional change intended.
Reviewed by: aokblast
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D55004
hwpstate_amd(4): Assert PSTATE_CPPC is on in corresponding sysctl handlers
No functional change intended.
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D55001
hwpstate_amd(4): Rename EPP handler, convert to unsigned int
'val' is supposed to be the storage for a sysctl knob of an 'unsigned
int', so consistently don't specify its width.
While here, rename variables in the handler. The new names feel
clearer, and the 'ret' => 'error' rename is to be more in line with our
tradition.
No functional change intended.
Reviewed by: aokblast
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D55002
hwpstate_amd(4): Rename register dump sysctl handler
While here, rename the callback function and structure to a more
immediately informative name.
While here, remove a superfluous cast and rename the variable containing
the callback data to just 'data' instead of 'req' which can be confusing
(because of CPPC_REQUEST but also the fact that 'req' is a parameter of
sysctl handlers).
No functional change intended.
Reviewed by: aokblast
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D55000
hwpstate_amd(4): Factor out printing CPPC registers, fix CPPC_REQUEST's
Factor out these printing, so they can be called from other places than
just the register dump handler. This also makes surrounding code
clearer.
Fix inverted printing of minimum and maximum performance.
For better diagnostic, print the full raw content of each register
before printing the value of fields we know about.
As fields are printed in decimal, remove 0-padding, which could give the
impression that the numbers are printed in octal or hexadecimal.
While here, remove superfluous blank lines when printing (we use TABs
for the different registers' fields).
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D54999
hwpstate{_amd,intel}(4): Move common knobs to a separate file
Reason for doing this right now is to resolve the conflict on
'machdep.hwpstate_pkg_ctrl' between the Intel and AMD drivers, even
though I expect to remove it for hwpstate_amd(4) at some point.
More generally, this is going to be useful for some future code
factorization. Also, the 'debug.hwpstate_verbose' knob was moved there,
as we'll likely want to use it for the Intel driver as well (which is
currently not the case).
Note for MFC: Will be partial, since `hwpstate_amd(4)` does not support
CPPC in stable/15 nor stable/14.
Reviewed by: emaste
Fixes: 3e6e4e4a0d42 ("hwpstate: add CPPC support for pstate driver on AMD")
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D54528
