linuxkpi: Take const root in read-only radix tree functions
This is a preparation step for a future addition to this file. This is
also closer to what Linux does.
Reviewed by: emaste
Sponsored by: The FreeBSD Foundation
HBSD: Unlock the sound mutex on error
Commit 095caf887fdde311caa5a7e3abd767fe33d76406 removed a call to a
now-nonexistant function (snd_mtxunlock). FreeBSD removed that function
in favor of using the normal mutex API directly (mtx_unlock).
This commit re-adds a call to unlocking the mutex, but using the normal
mutex API as required.
Signed-off-by: Shawn Webb <shawn.webb at hardenedbsd.org>
Reported-by: @0x1eef
See-Also: !115
Fixes: 095caf887fdde311caa5a7e3abd767fe33d76406
MFC-to: 15-STABLE
MFC-to: 14-STABLE
(cherry picked from commit 291d74e65f44d04bc41243e51212ebe2e6e1975e)
Signed-off-by: Shawn Webb <shawn.webb at hardenedbsd.org>
HBSD: Unlock the sound mutex on error
Commit 095caf887fdde311caa5a7e3abd767fe33d76406 removed a call to a
now-nonexistant function (snd_mtxunlock). FreeBSD removed that function
in favor of using the normal mutex API directly (mtx_unlock).
This commit re-adds a call to unlocking the mutex, but using the normal
mutex API as required.
Signed-off-by: Shawn Webb <shawn.webb at hardenedbsd.org>
Reported-by: @0x1eef
See-Also: !115
Fixes: 095caf887fdde311caa5a7e3abd767fe33d76406
MFC-to: 15-STABLE
MFC-to: 14-STABLE
kgssapi: Remove broken MOD_UNLOAD code
The module panicked at unload with "recursing but non-recursive rw".
There is a comment that "Unloading of the kgssapi module is not
currently supported" and the MOD_UNLOAD case falls through to returning
EOPNOTSUPP anyway. Just #if 0 the code in the unload path, leaving it
as a hint in case someone implements unload support later on.
PR: 291249
Reviewed by: rmacklem
Fixes: ad704a34bc2c ("Use syscall_helper_register(9) rather than syscall_register().")
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53949
(cherry picked from commit 6901376f59b870ddbb0d922e3455a388333cd460)
(cherry picked from commit ab4f4f4efaac85bbf235e60f2ced4876a9e916f2)
vt: Allow VT_SETMODE with frsig=0
Linux does not check that any of the signals in vt_mode VT_SETMODE ioctl
(relsig, acqsig, frsig) are valid, but FreeBSD required that all three
are valid. frsig is unusued in both Linux and FreeBSD, and software
typically leaves it unset. To improve portability, allow frsig to be
set to zero.
PR: 289812
Reported by: Dušan Gvozdenović
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D52835
(cherry picked from commit 5198c32210039d8dc92554647384eee75688848c)
Deprecate fdc(4) and floppy utilities
Floppies have been obsolete for over a decade. Add a deprecation note
now and plan to remove fdc(4) support in 16.
Reviewed by: ziaee
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D41549
(cherry picked from commit 4c736cfc69a7ef81c48c8431b31c7e31746fe816)
kgssapi: Remove broken MOD_UNLOAD code
The module panicked at unload with "recursing but non-recursive rw".
There is a comment that "Unloading of the kgssapi module is not
currently supported" and the MOD_UNLOAD case falls through to returning
EOPNOTSUPP anyway. Just #if 0 the code in the unload path, leaving it
as a hint in case someone implements unload support later on.
PR: 291249
Reviewed by: rmacklem
Fixes: ad704a34bc2c ("Use syscall_helper_register(9) rather than syscall_register().")
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53949
(cherry picked from commit 6901376f59b870ddbb0d922e3455a388333cd460)
diff3: Use logical-not, not bitwise for booleans
And compare impcompat != 0 as it's actually an integer incremented on
each use of one of the AeExX3 options.
Reviewed by: fuz
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53808
(cherry picked from commit abcb80f46c2607fc16564ca87cc25f0908f29f99)
diff3: Remove bespoke getopt.h
diff3's getopt.h included a function declaration without a prototype,
which produces a compiler warning. Just remove the bespoke getopt.h
and use the system header.
Reported by: Mark Millard
Reviewed by: fuz
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53802
(cherry picked from commit 38829592dc77e9ead4259785e0bfb93bd4c2fe34)
mqueue: Export kern_kmq_* symbols from kernel module
linux.ko supports POSIX message queues using these symbols, so they need
to be exported rather than relying on the kernel linker's misfeature of
linking against debug or local symbols (which will soon be disabled by
default).
Reported by: mav
Reviewed by: zlei
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53907
(cherry picked from commit e00a781c216cb12603a0a71c9ca293dde3e06250)
(cherry picked from commit eb90470f5f2a0e5c820c47be329423f5c60ca247)
