libarchive: Staticize some variables
This code was not being built due to errors in our libarchive
configuration. Now that those have been addressed, staticize some
variables that trip a “no previous extern declaration” error. This
is a subset of upstream PR 2962.
MFC after: 1 week
Reviewed by: mm
Differential Revision: https://reviews.freebsd.org/D56471
kshim/usb: Add build option.
Add WITH{,OUT}_LOADER_USB to build the kshim usb library. Nothing
in-tree uses it, but this will make it easier to keep building. Updated
src.conf.5 with a few extra changes...
Sponsored by: Netflix
LinuxKPI wlan drivers: update makefiles to not use WITH_
Up to now the LinuxKPI wlan drivers were using local variables starting
with a WITH_ prefix in their Makefiles.
That is likely to collide with other mechanisms like WITH_ and WITHOUT_
from src.conf.
Adjust the local variables to use a driver name prefix for now to control
what is built and what is not.
These variables are mainly for the time of development so we can
turn off/on a feature or bus attachment while working on it. Otherwise
they are there for documentation purposes. The only reason one would
change them locally would be if someone was to build a very custom
image and not want certain bits (e.g., USB support) being compiled into
the modules.
While here, try to harmonize some parts of the Makefiles.
Suggested by: imp
Discussed with: imp
[5 lines not shown]
ath11k: restore module Makefile
During the subtree merge and checking out the updated version of ath12k
parts of the previous ath11k merge were accidentally undone.
Retore the ath11k Makefile as well after 3c4eef5d838b restored the
driver bits.
Fixes: a96550206e4b ("ath12k: update Atheros/QCA's ath12k ..")
Sponsored by: The FreeBSD Foundation
(cherry picked from commit f9795615415074b23faf8e5d937c2ef31045d3d0)
LinuxKPI: implement devm_kmemdup_array()
Implement devm_kmemdup_array() using devm_kmemdup() in order to
prepare for Linux v7.0 based drivers.
Sponsored by: The FreeBSD Foundation
MFC after: 3 days
Reviewed by: dumbbell
Differential Revision: https://reviews.freebsd.org/D56396
LinuxKPI: sync overflow.h from Linux v7.0
overflow.h was imported directly from Linux in 3208d4ad2b8320a.
Update the file to the newer version as needed for v7.0 driver updates.
Sponsored by: The FreeBSD Foundation
MFC after: 3 days
Obtained from: git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
028ef9c96e96197026887c0f092424679298aae8 (tag: v7.0)
Reviewed by: emaste, dumbbell
Differential Revision: https://reviews.freebsd.org/D56394
LinuxKPI: add kmalloc_obj[s], kzalloc_obj[s], and kzalloc_flex
Drivers in Linux v7.0 seem to have changed to the new allocation
macros using a sweep. Add the ones I encountered with wireless
drivers so far. They all take an optional argument for a gfp_t,
which default_gfp() deals with.
The plural version "objs" takes an extra nitems argument in addition
to the size. We use size_mul() to possibly detect overflows.
The "flex" version uses an extra variable to track the variable sized
array allocations and if supported by the compiler will use
__builtin_counted_by_ref() to properly track bounds.
Sponsored by: The FreeBSD Foundation
MFC after: 3 days
Reviewed by: dumbbell
Differential Revision: https://reviews.freebsd.org/D56395
LinuxKPI: conditionally add __flex_counter()
__flex_counter() is used by overflow.h and needed for "flex allocations".
It is either a void * typed 0 (NULL) (like this for _Generic checks),
or uses __builtin_counted_by_ref.
The latter was added to gcc and llvm fairly recently and while for gcc
the __has_builtin() check suffices, clang had parts broken until recently
so needs an extra check for the next major version. The fixed hash is
currently not part of any tag to use, so we play it save (and hope 23
will have it). It will be a while until we will see the builting to be
used but at least we will be prepared for it. See inline comments for
the commit hashes and versions which added the feature.
Sponsored by: The FreeBSD Foundation
MFC after: 3 days
Reviewed by: dumbbell
Differential Revision: https://reviews.freebsd.org/D56393
net80211: radiotap: add more VHT flags, and struct
Add the struct for VHT information and flags for the known and flag
field as documented on radiotap.org. iwlwifi has started filling in
these details.
While here, add Copyright information for all the additions in the
last years.
Sponsored by: The FreeBSD Foundation
MFC after: 3 days
LinuxKPI: add default_gfp()
Various new allocation macros can take an optional gfp_t argument.
If the argument is not given we need to set the GFP_KERNEL default.
While this is only internally used and I initialy called it differently,
should this spread elsewhere having the same name as in Linux will be
good.
Sponsored by: The FreeBSD Foundaton
MFC after: 3 days
Reviewed by: dumbbell
Differential Revision: https://reviews.freebsd.org/D56392
LinuxKPI: move hex2bin() from kernel.h to new hex.h
New Linux v7.0 drivers include hex.h. Rather than adding a dummy
header, migrate the kernel.h hex2bin() into hex.h, where it belongs.
Care needs to be taken as the _h2b() helper function is still used by
other bits in kernel.h.
Sponsored by: The FreeBSD Foundation
MFC after: 3 days
Reviewed by: emaste, dumbbell
Differential Revision: https://reviews.freebsd.org/D56391
bnxt_en: fix module Makefile for LinuxKPI
Rather than manually including the include directory for LinuxKPI
use the provided macro. Before there was no -I for the dummy
directory and as files synced from Linux under a permissive license
may include them the build would fail. overflow.h will include
linux/const.h which only exists as a dummy header at this point
on FreeBSD.
Sponsored by: The FreeBSD Foundation
Fixes: 35b53f8c989f6
MFC after: 3 days
Reviewed by: emaste
Differential Revision: https://reviews.freebsd.org/D56424
rtw89: add a warn about beacon_int or dtim_period being 0
While after the changes to LinuxKPI 802.11 we should never be assoc
and not have dtim_period set, we have seen before that this could
happen. Add a WARN as that will help debugging the following DIV 0.
Sponsored by: The FreeBSD Foundation
MFC after: 3 days
LinuxKPI: 802.11: make sure dtim_period is set
When going from ASSOC to RUN LinuxKPI based wireless drivers have
certian expectations written in various ways. I believe mac80211
waits to see a beacon before setting the vif to assoc (or the sta
to AUTHORIZED). We have some comments in lkpi_update_dtim_tsf()
for that.
In practice we can filter out the beacons already and know when
they came in as we count them but it is hard to split up the
state machine and defer the work.
So we make sure that dtim_period is set to at least 1 before
calling the (*vif_cfg_change) after setting assoc to true;
0 is a reserved value according to the standards.
We will update it once we see a beacon and in case the value
differs from 1 shortly afterwards from the recv_mgmt callback.
While iwlwifi seems to have coped with our initial implementation,
[5 lines not shown]
LinuxKPI: 802.11: start filling vif->cfg.ap_addr
vif->cfg.ap_addr is used by various drivers now and is the BSSID for
non-MLO or the AP addr for MLO configurations.
If this is unset rtw89 gets cranky and certain packets are likely not
going out correctly (also for iwlwifi).
Sponsored by: The FreeBSD Foundation
MFC after: 3 days
LinuxKPI: 802.11: improve emulate chanctx implementation
Now that all dependencies are implemented improve our chanctx emulation.
Some drivers still rely on chandef information for channel work.
In order to only do chanctx updates within mac80211 in Linux and
likewise in the LinuxKPI 802.11 compat layer, emulation functions
were introduced which claim to support chanctx driver operation but
in reality convert these to chandef field updates and (*config)
downcalls.
This is relevant to several mt76 chipsets (at least 7615, 7915),
and rtw88 and certain rtw89 chipsets (8851b, and the ones not supporting
SCAN_OFFLOAD or BEACON_FILTER) for us.
Migrate the logic out of the header and improve it.
Make use of the introduced dflt_chandef and scan_chandef fields,
add comparison of chandefs to see if we have to update, etc.
[13 lines not shown]
LinuxKPI: 802.11: add chandef tracing
Add chandef tracing so we can follow what is set and unset in the
chanctx emulation for drivers still needing this.
Sponsored by: The FreeBSD Foundation
MFC after: 3 days
LinuxKPI: 802.11: factor out getting and setting a chanctx
Further factor out acquiring the chanctx (either set or new),
as well as populating a chanctx with information.
This further simplifies lkpi_sta_scan_to_auth() and gives us
more reusable function blocks.
Sponsored by: The FreeBSD Foundation
MFC after; 3 days
LinuxKPI: 802.11: rework lkpi_ic_set_channel()
We are called by net80211 when channel changes are happening and
we have to map this to LinuxKPI 802.11. There are multiple cases:
(1) it is a hardware scan and net80211 still changes the channel;
we do not need to;
(2) it is a software scan (the magic fallback case) in which case
we let net80211 drive the scan channel and we need to keep
a copy of the scan_chandef (see follow-up commit);
(3) no scanning but a normal channel change triggerd by net80211;
in that case we could (should?) setup the full flags right away
but deferred LinuxKPI logic currently handle this for us as not
in all cases the information was fully available from net80211
in times we would have needed it. We only do this in order
to handle the emulate chanctx cases but do not change the
channel otherwise; scan_to_auth will set the correct chanctx.
(3a) we have no (active) chanctx for that, create/set one,
(3b) we do have an (active) chanctx for this, use it but reset to
defaults.
[3 lines not shown]
LinuxKPI: 802.11: save the default channel
Add a field to struct lkpi_hw to save the default channel for later
reuse.
Sponsored by: The FreeBSD Foundation
MFC after: 3 days
LinuxKPI: 802.11: keep chanctx on a reserved list
Keep the chanctx around as we may swap them.
In the future (11be) these lists likely need to be (a) limited to
maximum number of chanctx possible (see struct ieee80211_iface_limit),
and (b) with that also by radio.
For the moment keep this simple and start with a single chanctx
and build up from there when we get there.
Sponsored by: The FreeBSD Foundation
MFC after: 3 days
