pf(4): pf_state_insert() should update stack side key
pf_state_insert() should treat stack side state key (sks) in the same way
as it treats wire side state key (skw). The call to pf_state_key_attach()
may replace the sks with key which is present already in state tree.
Issue noticed and reported by Acts-1631
OK henning@ OK bluhm@
rpki-client: reject CustomerASID 0 in ASPAs
The customerASID element has type CAS ::= INTEGER (1..4294967295) with
section 3.2 of draft-ietf-sidrops-aspa-profile-30 explicitly saying
"The customerASID field contains a positive integer [...]".
as_id_parse() accepts all values in [0, UINT32_MAX], so we need to
exclude 0 explicitly.
ok claudio rcovelli
Move the carepo tree and its accounting to the parser process.
To properly account the validity of a MFT it requires that the carepo
tree is moved to the parser process. This is the first step. It moves
the tree add basic functions to add and check the count per repo and
it adds the required locking around the shared structure since the
parser is multithreaded.
OK tb@ job@
iked(8): Ignore IKEv1 messages when not configured
When there are no ikev1 rules in iked.conf defined, just drop ikev1
packets right away; no need to forward them to the ikev1 sub-process.
That matches the original iked behaviour.
ok op@ henning@
tcpdump(8): Do not loop infinitely on malformed OSPF packets
When printing a Link State Update with -v, the LSU loop trusts the
advertised LSA count and advances to the next LSA by the length field
of the LSA header. An LSA header with a length smaller than the
header itself makes the loop re-parse the same header up to 2^31
times, pinning tcpdump on one packet.
Reject an LSA whose length is smaller than the mandatory 20 byte
header in ospf_print_lsa() and ospf6_print_lsa(), where the length
is used to advance. The DD and LSAck printers only walk fixed size
headers and are unaffected.
Reported by Acts1631, thanks!
ok dlg@
vmd(8): Do not leak vm_kernel_path
When vm.conf is reloaded, vm_register() returns EALREADY and hands
back the existing VM, whose vm_kernel_path the parser then overwrites
without freeing the old string. Free it first. While there, also free
the parsed path when vm_register() fails or when running with -n, as it
is never handed over to a VM in those cases.
vm_remove() freed vm_kernel_path only if vm_from_config was not set.
However, the parser is the only place that assigns vm_kernel_path, and
it sets vm_from_config at the same time, so the path was never freed.
Free it unconditionally.
ok dv@
vmd(8): Keep SEV memory segments within a single memrange
sev_register_encryption() derived the host VA from find_gpa_range()
plus its own offset arithmetic and recorded the caller's length as
a flat span. A segment crossing a memrange boundary thus produced
a host VA range extending past the mapping it was taken from, which
was then handed to the PSP for in-place encryption.
Translate through hvaddr_mem() instead, which enforces that the
whole span lies within one memrange, and align address and length
to the AES-XTS block size before validating so the checked length
is the one sent to the PSP.
Also sort the recorded segments and merge overlapping ones before
LAUNCH_UPDATE_DATA. Segments sharing a 16-byte block (e.g. .symtab
and .strtab) or fully contained in another (.openbsd.randomdata
inside the rodata PT_LOAD) were otherwise encrypted twice, corrupting
the data. Adjacent but non-overlapping segments are kept apart,
as they may live in different memranges.
[4 lines not shown]
update orthanc framework/server to 1.13.0, and postgresql-plugin to 11.0
and simplify the patching process
attempt updating webviewer, but it doesn't build with newer framework.
I believe this is the Osimis Web Viewer which is deprecated upstream and
probably wants replacing with Stone Web Viewer, however it looks like
this is an emscripten build about which I know nothing atm, so not doing
that now. at least one of the broken subdirs now builds.
