DNS names are not proper C strings, they can contain NUL octets.
If we want to use string functions (e.g. for comparison) we first need
to convert them.
with dgl some time ago
OK dlg
pmtiles uses gobs of RAM when working with larger zoom levels, add a quick
MESSAGE warning about this (it's better to find out before you download
100GB+).
Rework the IdleHoldTimer and how fast reconnects are implemented.
On first error bgpd should allow a fast reconnect - this is especially
helpful for passive sessions. The way this was implemented was error
prone with a special case in session_accept().
Adjust the FSM so that on the first IDLE transistion the session uses
a IdleHoldTime of 0 sec but then increased to INTERVAL_IDLE_HOLD_INITIAL.
At the same time the outgoing connection is delatyed via ConnectRetryTimer.
Doing this moves the session quickly into active state and allows new
connections in but delays the reconnect like before.
Additionally the STATE_ACTIVE / EVNT_START FSM case is adjusted to initiate
a connect immediatly. This allows a 'bgpctl nei X up' to work also for
sessions in ACTIVE state. Also passive sessions will initiate a connection
in this case, which is a new behaviour.
OK tb@
Use peer_dump_done() in the EXPORT_NONE and EXPORT_DEFAULT_ROUTE cases of
peer_dump().
peer_dump_done() calls peer_blast_done() and it issues the End-Of-RIB
marker. This unifies all the peer_dump finalizers to use peer_dump_done().
OK tb@
Switch a few uint32_t to unsigned int where it makes sense.
Instead of mixing uint32_t with unsigned long long use unsigned int for
those. In most cases those are simple counts that can't get too big.
The same is the case for max_prefix and max_out_prefix. There is no good
reason to use uint32_t there.
OK tb@
Don't use SCSI_DATA_IN for patrol read commands that don't have a data
buffer. Noticed while looking into crashes reported by job@ but doesn't
fix anything.
ok dlg@
relayd: add ECDSA support to the CA privsep engine
Add an EC_KEY_METHOD that forwards the sign operation to the CA process,
clone the existing RSA engine. ssl_load_pkey() now handles both RSA
and EC keys and attaches the cert hash accordingly.
The engine and signing code was migrated from smtpd from (op@) with
some tweaks by me.
OK op@
vmd(8): validate memory ranges in vmd before vmm(4).
While vmm(4) does its own check on the number of memory ranges, do
the check in vmd(8) to fail fast and provide feedback to the user.
Report and diff by Andrew Griffiths.
ok @hshoexer