when getnetby*(3) family were refactored by schwarze in 2018 as a
wrapper on gethostby*(3), the ip address in the structure was
mistakenly considered a pointer to an ip address, and a dereference
was attempted. The long survival of this bug tells us that
getnetby*(3) is used extremely rarely. In fact it was noticed by
afresh1@ on a strict-alignment architecture which inspected a HOST
with an odd ip address (byte order can also matter)
ok millert
u_obj.uo_refs must be managed using atomic_inc_int_nv() and friends
or the reference counting and inspection can evaluate incorrect.
This affecs kbind.
ok claudio, krw
diff from openai
stop trying to refuse a whole bunch of ioctls when securelevel > 1, which
was advertised as "pf filter and NAT rules may not be altered" - however,
there are numerous other ways, like turning pf of per-interface using set
skip, removing/adding interfaces from/to groups etc etc etc
root is root, period. pf doesn't have anything securelevel-dependent now.
"set skip" reported by acts1631kjv at proton
support deraadt, ok sashan claudio sthen
Remove sm_transactionid. This was originally intended to hook messages to
when sending requests to AgentX backends, but this functionality ended up
fully in application.c.
OK op@
devel/libnotify: check notify_get_server_info() return code and exit early if there's no notification daemon
silences vfprintf NULL messages when notify-send is run without dbus running.
ok ajacoutot@ (MAINTAINER)
Remove mrt6_mrouter_ver since it is unused and will never be used.
Our MRT6 code has no compat fallback for the old (> 25year) mrt6msg
format. We only use the fixed version with the alignment fix.
So there is no need to track mrt6_mrouter_ver since it is always MRT6_INIT
and that will never change. So burn this bridge for good.
OK bluhm@
fallback to PCI reset on x86
Attempt system reset with writes to a memory region used for PCI.
Both Intel and AMD document reset at the 0xcf9 address.
Adapted from FreeBSD by Gert-Jan Vons to fix reset on a
Fujitsu Futro S940.
ok deraadt@
Don't free the io queue memory when suspending, so it doesn't have to be
reallocated on resume. This removes a potential sleep point in the resume
path. The queue is still recreated on the controller, so its software state
has to be reset instead.
ok dlg@ deraadt@