[InferAddressSpaces] Use a new value map for each rewritten constant
When the pass rewrites a flat constant expression, it remaps the
instructions that use it through other constant expressions with a
`ValueMapper`. All rewritten constants shared one map, and the mapper
caches every constant that it visits, including the ones that it maps to
themselves. So when one instruction uses two rewritten constants, the
remap for the first one caches the part with the second one as
unchanged, and the remap for the second one reuses that entry. For
example, if a call has `addrspacecast`s of two flat pointers that are
based on the same `addrspace(3)` global, only one argument is folded.
This PR uses a new map for each rewritten constant.
This PR was assisted by AI but I reviewed all the changes.
[InferAddressSpaces] Don't replace uses in other functions
`performPointerReplacement` visits every use of a value in the postorder
list. When the value is a constant expression, some of these uses can be
in other functions. It already skipped such uses, but only after
`replaceIfSimplePointerUse`, so when the pass ran on one function, it
could still rewrite a load, store, `atomicrmw`, or `cmpxchg` in another
function, even in an `optnone` function.
This PR skips a use in another function before any replacement, like
#70611 did for the other users of a constant.
This PR was assisted by AI but I reviewed all the changes.
tests/sys/capsicum: restore test coverage with root user
This change builds capsicum_test and installs/runs it as an unprivileged
user ("tests" in vanilla FreeBSD) and root.
This required adjusting logic in the Makefile in order to build two
binaries with the same sources and running them as separate binaries.
Moreover, in order to restore coverage and ensure that some tests which
require `other_uid` (typically specified via `-u` on the CLI with the
test program) don't fail, become the "tests" user when run as root. This
technically doesn't honor unprivileged_user property in kyua.conf: the
property needs to be passed via a command-line parameter to the test
program.
MFC after: 1 week
Reported by: markj
Fixes: 3fb03fb35b20 ("[tests] switch GoogleTest tests ...")
[2 lines not shown]
capsicum-test: make the code WARNS=6 clean
Make the code WARNS=6 clean by doing the following:
- Renaming variables (-Wshadow).
- Use memcpy instead of assigning the result of CMSG_DATA to a variable
(-Wcast-align).
- Wrap some macros with do-while(0) to avoid variable collisions
(-Wshadow).
- Push one of the TRACE statements up by 1 layer to avoid a collision
between 2 calls of TRACE via the same overarching macro.
This was needed in order for the code to build properly with D61066,
since the code was not compiling with WARNS set to 3 at the testcase
level.
MFC after: 1 week
Reviewed by: markj
Differential Revision: https://reviews.freebsd.org/D61080
[lldb][test] Report the attach error in API tests that attach by pid (#239412)
`test_module_is_file_backed`, `test_with_attach_to_process_with_id_api`
and `test_setpgid` attach with `target.AttachToProcessWithID`, then
`self.assertTrue(error.Success() and process, PROCESS_IS_VALID)`, when
the attach fails, the failure names no cause, the text in `error` is
dropped
```
[2026-11-05T21:51:50.444Z] Traceback (most recent call last):
[2026-11-05T21:51:50.444Z] File "/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake/llvm-project/lldb/test/API/python_api/sbmodule/TestSBModule.py", line 106, in test_module_is_file_backed
[2026-11-05T21:51:50.444Z] self.assertTrue(error.Success() and process, PROCESS_IS_VALID)
[2026-11-05T21:51:50.444Z] AssertionError: False is not true : Process is valid
```
Use `self.assertSuccess(error)` instead so the attach error can be seen.
Revert "capsicum-test: make the code WARNS=6 clean"
The wrong patch got committed somehow from one of my git clones. Revert the
change so I can reapply the correct patch >:(.
This reverts commit 5bae837f316ca96b69c61bae15bd61da76e7f3ea.
Revert "tests/sys/capsicum: restore test coverage with root user"
The wrong patch was applied for D61080. Both changes must go.
This reverts commit dda15b669d021346682009f38acc6db2639fb99f.
[CGP] Mark profiles in foldURemOfLoopIncrement
Mark these as unknown given we are creating a select with a value
conditioned on runtime variables that we are not easily able to infer at
compile time.
Reviewers: mtrofin
Pull Request: https://github.com/llvm/llvm-project/pull/238967
[CGP] Mark branch weights unknown for BypassSlowDivision
The branch weights are dependent on the value distribution of the
divisor/dividend, so we cannot know them at compile time. Just mark the
weights explicitly unknown.
Reviewers: mtrofin
Pull Request: https://github.com/llvm/llvm-project/pull/238954
[AMDGPU] Ignore meta instructions in pre-RA exec-copy scan limit (#237521)
Debug instructions currently count against the ten-instruction backward
scan used to fold an `exec` copy into its only non-debug user. At the
scan boundary, adding debug information can therefore retain an extra
`exec` copy. A source-level OpenCL reproducer shows the debug build
retaining an extra `s_mov_b32 ..., exec_lo`, increasing the function
size by four bytes compared with `-g0`.
Ignore meta instructions when counting the existing scan limit. Meta
instructions produce no executable output and cannot be the EXEC copy
sought by the scan. This also prevents other meta instructions, such as
`SCHED_BARRIER`, from consuming the budget.
Fixes #229042
This issue was found by a non-AI automated testing tool. AI assisted
with the analysis and development of the fix.
[LFI][X86] Add memory access rewrites (#227511)
This adds memory access rewriting for the x86-64 LFI target using `%gs`
as the base register for rewrites. By using 32-bit register combined
with the sandbox base in `%gs`, memory accesses can be rewritten to be
confined to an LFI sandbox with little overhead. See the documentation
in `LFI.md` for details on exact rewrite sequences.
[LowerMemIntrinsics] Propagate VP metadata to branch weights (#239901)
In #228420, a new transform was introduced that lowered constant range
memsets inline. Then #239159 landed to fix the profcheck failure, but
was wrong in the reasoning that there is no way to come up with branch
weights.
This patch makes a reasonable attempt at propagating branch weights from
VP metadata that will likely be attached to the memset for instrumented
PGO builds. This patch doesn't handle some cases effectively,
particularly with incomplete profile information (e.g., the top 4
buckets that we put in the VP metadata are all above the constant given
inlining exposed the range optimization). Handling those more
effectively adds considerable complexity thought that I do not think is
worth it.
tests/sys/capsicum: restore test coverage with root user
This change builds capsicum_test and installs/runs it as an unprivileged
user ("tests" in vanilla FreeBSD) and root.
This required adjusting logic in the Makefile in order to build two
binaries with the same sources and running them as separate binaries.
Moreover, in order to restore coverage and ensure that some tests which
require `other_uid` (typically specified via `-u` on the CLI with the
test program) don't fail, become the "tests" user when run as root. This
technically doesn't honor unprivileged_user property in kyua.conf: the
property needs to be passed via a command-line parameter to the test
program.
MFC after: 1 week
Reported by: markj
Fixes: 3fb03fb35b20 ("[tests] switch GoogleTest tests ...")
[2 lines not shown]
capsicum-test: make the code WARNS=6 clean
Make the code WARNS=6 clean by doing the following:
- Renaming variables (-Wshadow).
- Use memcpy instead of assigning the result of CMSG_DATA to a variable
(-Wcast-align).
- Wrap some macros with do-while(0) to avoid variable collisions
(-Wshadow).
- Push one of the TRACE statements up by 1 layer to avoid a collision
between 2 calls of TRACE via the same overarching macro.
This was needed in order for the code to build properly with D61066,
since the code was not compiling with WARNS set to 3 at the testcase
level.
MFC after: 1 week
Reviewed by: markj
Differential Revision: https://reviews.freebsd.org/D61080
AMDGPU: Check address alignment when merging TBUFFER accesses (#239852)
SILoadStoreOptimizer only checked the alignment of the immediate
offset when merging TBUFFER accesses, ignoring the rest of the
address. This could undo splitting done for alignment and cause
hangs. This is a theoretically stronger fix to piglit failures with
mesa which were previously hidden by conditioning this transform on
relaxed OOB mode.
Check the alignment of the whole address from the memory operand, and
assume each access is already aligned to its component size. Since the
buffer intrinsics don't provide any alignment information, accesses
with 8-bit or 16-bit components can no longer be merged from IR.
Co-authored-by: Claude Opus 5.5 <noreply at anthropic.com>
[flang][OpenACC] Emit NYI for unsupported scalar CHARACTER mappings. (#240551)
Automatic and assumed-length scalar CHARACTER variables, as well as
fixed-length host-associated scalars, can reach data-clause lowering as
fir.boxchar. This type is not currently mappable, causing an assertion
failure.
Emit an NYI diagnostic instead until the support for mapping `boxchar`
is implemented.
Assisted-by: Codex
RuntimeLibcalls: Add helper methods to insert declarations
Add methods to get or insert the declaration of a libcall
implementation in a module with the appropriate type and
annotations. A (potentially incorrectly declared) global that already
has the name is returned unmodified
Use them in DeclareRuntimeLibcalls, which no longer merges attributes
into or replaces the calling convention of existing functions, and no
longer crashes on a global variable with the name of a libcall
function.
Co-authored-by: Claude Opus 5.5 <noreply at anthropic.com>
SafeStack: Take libcall declarations from RuntimeLibcallsInfo
Stop declaring __stack_chk_fail and __safestack_pointer_address
manually and construct them with the correct type automatically.
A function with the variable's name is now reported as not being a
global variable, rather than a renamed copy of the variable being
inserted. -safestack-use-pointer-address now requires
__safestack_pointer_address to be available for the target, instead of
unconditionally emitting a call to it. The tests using it on
non-Android triples move to Android.
Co-authored-by: Claude Opus 5.5 <noreply at anthropic.com>
