[MLIR][linalg] Remove discarded failure conversion (#221826)
Silence warning for unused result with a `(void)` cast instead of
converting its result with failed() and then discarding the converted
value.
Fix a Coverity warning, and it's cleaner about the intent.
Assisted-by: Codex
[mlir][AMDGPU] Move gather index vectors at final use (NFC) (#221825)
The gather lowering copies two temporary vectors into the next
construction stage and never reads the source vectors again. Move their
storage instead.
Found by Coverity.
Assisted-by: Codex
linuxkpi: Add `hrtimer_setup()`
`hrtimer_setup()` replaces `hrtimer_init()` in Linux 6.15. The API and
the role are the same, except:
* it takes the `function` callback as argument
* if `function` is NULL, it assigns a default callback
At the same time, we hide `hrtimer_init()` if LINUXKPI_VERSION is
greater than or equal to 61500 because it was dropped in Linux 6.15.
Reviewed by: bz
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D58757
linuxkpi: Add `timer64_to_tm()`
The function converts a number of seconds since Epoch to a `struct tm`.
The implementation was copied from `contrib/tzcode/localtime.c`.
The amdgpu DRM driver started to use it in Linux 6.15.
Reviewed by: bz
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D58758
NAS-143041 / 26.0.0 / Remove dead `force_remove_ix_volumes` app delete option (by Qubad786) (#19611)
## Problem
`app.delete` accepts `options.force_remove_ix_volumes`, validates it as
a bool and documents it in the method docstring, but nothing reads it.
It was live when introduced in 0c4381a2b4, where it picked which kwarg
to hand to `zfs.dataset.delete` — `recursively_remove_dependents` when
set, `recursive` otherwise. 9712dc3084 ("remove zfs.dataset.delete
(replace w/ zfs.resource.destroy)") swapped that call for an
unconditional `recursive=True, bypass=True` destroy and dropped the
conditional along with it, leaving the flag accepted but inert. The
capability it selected is gone too: `zfs.resource.destroy_impl` has no
dependents-removal parameter, so there is nothing left to wire it back
up to.
## Solution
Dropped the field from `AppDelete` in both v26_0_0 and v27_0_0 and
removed the docstring paragraph describing it. `remove_ix_volumes` is
unaffected — it is still the live gate on ix-volume deletion.
[8 lines not shown]
[CIR][CMake] Limit MLIR dependencies to used components
CIR libraries and tools consume MLIR's global dialect, conversion, and
translation library collections. This makes every library in those collections
reachable from Ninja's all target even when MLIR is configured only as a CIR
dependency.
Replace the collections with target-specific dependencies. Register only the
CIR, LLVM, and MemRef dialects in cir-lsp-server, and replace the all-LLVM
translation registration in cir-translate with the Builtin, LLVM, and OpenMP
interfaces used by CIR lowering.
For a dependency-only MLIR configuration with tests enabled, archives reachable
from Ninja all fall from 511 to 314. The libMLIR*.a subset falls from 333 to
136, and Ninja dry-run edges fall from 6,925 to 6,277.
Validation:
- Configured CIR with dependency-only MLIR, with and without tests.
- Configured Clang and MLIR explicitly with CIR and tests enabled.
[5 lines not shown]
[Flang][CMake] Limit MLIR dependencies to registered dialects
Flang currently consumes MLIR_DIALECT_LIBS and MLIR_EXTENSION_LIBS in many
libraries and tools. These global collections include every configured MLIR
dialect and extension, including test-only components when MLIR tests are
available.
Define Flang-specific dialect and extension lists matching the registry in
InitFIR.h, and use them in place of the global collections. Remove the unused
InitAllDialects include and register-all libraries. List MemRef explicitly for
fir-opt's additional registration.
For a dependency-only MLIR configuration with tests enabled, archives reachable
from Ninja all fall from 500 to 355. The libMLIR*.a subset falls from 317 to
172, and Ninja dry-run edges fall from 6,969 to 6,493.
Validation:
- Configured Flang with dependency-only MLIR, with and without tests.
- Configured Flang and MLIR explicitly with tests.
[4 lines not shown]
[CIR][CMake] Configure MLIR as a dependency-only project
ClangIR requires MLIR, but enabling CIR currently requires users to list MLIR
explicitly in LLVM_ENABLE_PROJECTS. That also attaches all MLIR build, install,
unit-test, and lit targets to the corresponding LLVM aggregates.
When Clang is selected and CLANG_ENABLE_CIR is enabled, append MLIR to the
effective LLVM_ENABLE_PROJECTS list. The common project setup compares that
list with the cached user selection, so an explicit MLIR selection retains its
normal behavior while an implicit selection is configured with EXCLUDE_FROM_ALL.
This makes MLIR targets available for CIR dependency resolution without adding
MLIR's aggregate targets. Keep the existing standalone ClangIR restriction and
do not configure MLIR when CIR is disabled.
Validation:
- Configured Clang with CIR and implicit MLIR test support.
- Configured Clang and MLIR explicitly with CIR and tests enabled.
- Configured Clang without CIR and verified that MLIR remains disabled.
[4 lines not shown]
[CMake] Infer dependency-only projects from the cache
LLVM_ENABLE_PROJECTS historically treats projects enabled to satisfy another
project's dependency the same as projects selected by the user. Consequently,
implicit projects attach their complete build, install, and test suites to
LLVM's aggregate targets.
Keep the cache entry as the user-requested project roots and use the normal
LLVM_ENABLE_PROJECTS variable as the effective dependency closure. Projects in
the effective list but not the cache entry are configured with EXCLUDE_FROM_ALL.
Normalize the special all value before comparing the two sets.
This makes Flang's MLIR and Clang dependencies dependency-only without a second
project collection. It also applies the same rule to Clang when it is added for
LLDB. Forward the cached roots to cross-compilation and bootstrap configurations
so implicit projects do not become explicit in nested builds.
Let MLIR own its dependency-only test policy: configure test support libraries
for downstream consumers without creating MLIR unit tests or registering its
[10 lines not shown]
[CIR] Register only the LLVM IR translations CIR lowers to (#221797)
The ClangIR tests reach LLVM IR through mlir-translate, which links
every MLIR dialect and translation, so building check-clang builds most
of MLIR. Register mlir-to-llvmir in cir-translate over the same three
dialects and use it instead. Remove the dependency on `mlir-translate`
to run CIR tests.
ninja check-clang drops from 6499 to 5853 build edges.
LLM-aided
[MLIR][LLVM] Shard generated operation definitions (NFC) (#221813)
LLVMDialect.cpp includes both the 55,078-line core operation definitions
and the 95,769-line intrinsic operation definitions. Generate the
combined operation set in eight shards, use the generated registration
hook, and expose only the parser, printer, and type-inference helpers
needed by generated code.
Assisted-by: Codex
[CMake] Link only the MLIR dialects ClangIR uses (#221616)
CIR's sources reference Arith, DLTI, Func, LLVM, OpenACC, OpenMP and
Ptr, and cir-opt registers only the CIR dialects plus MemRef and LLVM.
Link those instead, which keeps Linalg, Vector, SPIRV, SparseTensor,
Tosa and GPU out of the clang build graph.
CLANG_ENABLE_CIR=ON adds 2135 build edges to the clang target; this
removes 694 of them.
LLM-aided
[CIR] Handle __declspec(noalias) as argmem side effects
Match classic codegen: NoAliasAttr becomes nounwind plus
memory(argmem: readwrite, inaccessiblemem: readwrite).
[CIR] Match OGCG noalias and memory effects on operator new
Sane replaceable operator new calls now get return noalias and
memory(inaccessiblemem: readwrite, errnomem: write), matching classic
codegen. -fno-assume-sane-operator-new drops both.
[analyzer] Fix crash destructing element of a sugared array type
ExprEngine::makeElementRegion falls short trying to determine the
element type of an array that involves a type aliasing a static array
type.
This leads to a crash in ExprEngine::ProcessMemberDtor where it assumes
that element type is a CXXRecordDecl, while it is still a type alias to
a static array type.
getBaseElementType is the canonical way to desugar and peel off the
array dimensions.
Assisted by Claude Opus 5
--
CPP-8838
nfsuserd.c: Fix handling where pw_name/gr_name differ from lookup name
When an NSS backend returns a canonical pw_name or gr_name that differs from
the lookup name supplied by the NFSv4 upcall, nfsuserd stores the successful
mapping in the kernel cache under the canonical name instead of the requested
name.
This causes the retry lookup performed by nfsv4_strtouid() or
nfsv4_strtogid() to miss the newly inserted cache entry, resulting in the
default UID/GID being returned although the NSS lookup itself succeeded.
PR: 296753
Reviewed by: rmacklem
Tested by: Emanuel Helms <emanuel at nfv.cc>
MFC after: 2 weeks
[CIR] Add noalias on malloc-like function returns
Mirror classic RestrictAttr handling so __attribute__((malloc)) and
__declspec(restrict) stamp llvm.noalias on the return, matching OGCG.
security/gost-engine: update
openssl111 has gone from Ports and we have no supported
FreeBSD versions having it in base, so drop 1.1.x support here too.
Update the code upto latest commit targeting OpenSSL 3.0.
Also, this makes it compatible with CMake 4.
Reported by: arrowd
Tested by: arrowd
[OMPIRBuilder] Restore the debug location after the reduction alloca (#221253)
`createReductions` emits the array of type-erased pointers to the
private reduction values in the alloca block, which means leaving the
current insertion point and coming back. The insertion point is
re-established but the debug location is not. Everything emitted
afterwards like the `__kmpc_reduce` and the matching __kmpc_end_reduce
inherits whatever the terminator happened to carry, which is usually
nothing. This could result in a verifier error if program is linked with
openmp runtime that has debug information.
Fix it by restoring the debug location along with the InsertPoint.
linuxkpi: Fix assertion in `lkpi_vmf_insert_pfn_prot_locked()`
Before this change, the assertion would not catch a page index matching
the end address, even though the end address of a mapping is outside of
that mapping.
While here, add another assertion to catch page indexes outside of the
expected range earlier.
Also, pagefaulting an address outside of the mapping range should return
`VM_FAULT_SIGBUS` instead of panicing.
Reviewed by: bz
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D58194
sysutils/lsd: Adopt port
While here:
- Seperate DEPENDS field from USES field (pet portlint).
- Remove increment from LIB_DEPENDS.
- Ignore failing tests.
PR: 296864
Approved by: osa, vvd (Mentors, implicit)
