NAS-141901 / 26.0.0-RC.1 / Add attachment-delegate regression tests for type-safe snapshot tasks (#19378)
Adds integration coverage for the attachment-delegate paths that break
when a delegate returns type-safe models instead of dicts — the
fragility behind the recent `pool.export` crash. `pool.snapshottask` is
the only delegate returning models
([NAS-139294](https://ixsystems.atlassian.net/browse/NAS-139294)), and
no existing test exercised it through these paths.
- `test_attachment_delegate_toggle` is parametrized over a replication
task (dict delegate) and a periodic snapshot task (model delegate). The
snapshot-task case covers the non-cascade `pool.export` disable /
`enable_on_import` bookkeeping and the re-import re-enable step.
- `test_attachment_name_for_snapshot_task` lists a snapshot task via
`pool.dataset.attachments_with_path`, exercising the `getattr`
(non-dict) branch of the base delegate's `get_attachment_name`.
Verified on a 26/INCREMENTAL VM: all three cases pass on current code,
and both regression guards fail with
`'PeriodicSnapshotTaskQueryResultItem' object is not subscriptable` when
their respective fix is reverted.
[libunwind][AArch64] Support .cfi_set_ra_state (#209950)
This new CFI directive directly assigns an RA signing state to the RA_SIGN_STATE DWARF pseudo-register for use when unwinding, to indicate whether the value of PC has been used as a diversifier for return address signing. The new directive subsumes and replaces .cfi_negate_ra_state_with_pc, which was found to be unsuitable for descibing some block layouts [1], particularly in hot-cold-split functions.
1: https://github.com/ARM-software/abi-aa/pull/346
[Clang] [Sema] Added a check for `NameInfo` not being empty after template instantiation (#210610)
Fixes #210234
As per my investigation (mostly following stack traces and dumping
variable values), a default empty `DeclarationNameInfo` was being
returned after template substitution [over
here](https://github.com/llvm/llvm-project/blob/c45b4e4d00bed488d6ece5608560561732ae5b9e/clang/lib/Sema/SemaTemplateInstantiateDecl.cpp#L3270).
```cpp
// D-.>getNameInfo() has actual data here
DeclarationNameInfo NameInfo
= SemaRef.SubstDeclarationNameInfo(D->getNameInfo(), TemplateArgs);
// NameInfo has default values
```
This was being passed on directly to `CXXDestructorDecl::Create` leading
[3 lines not shown]
AMDGPU: Migrate assembler tests to subarch triples with error changes (#211592)
Since these cases dropped the -mcpu argument, the error messages changed
to use the canonical name.
[BoundsSafety] Introduce LateParsedAttrType AST placeholder type (#204125)
Split out from #179612 to make review easier. No functional change.
This introduces `LateParsedAttrType`, a new AST placeholder type used
during late parsing of type attributes. The actual late parsing
mechanism that uses this type is in #179612 and will be split into a
follow-up PR.
system: service widget based on community feedback #10553
Tiles are still there but markup is more "native" to the dashboard.
Header is back. The columns have a bigger minimum size.
It all leads to being less readable, useful and compact. Not sure
about it.
[acc] Refine launch-dim handling for sequential block-redundant ancestors (#211153)
Sequential `gpu_block_redundant` ancestors need selective launch-dim
handling in `getAncestorParDims`: including them always widens
gang-private to per-thread; omitting them always can predicate
block-redundant bodies on `blockIdx` after partition.
Include launch dims when the block-redundant loop is worksharing or is
the innermost parallel parent; skip them for an outer sequential
block-redundant wrapper around nested worksharing.
modify the serializeToConfig to set the uuid of the new network ident… (#10600)
* modify the serializeToConfig to set the uuid of the new network identifier instead of the internal random generated uuid
* Update src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.php
Co-authored-by: Ad Schellevis <AdSchellevis at users.noreply.github.com>
* remove the exception if the node reference is not found
---------
Co-authored-by: kemoycampbell <ksc2650 at rit.edu>
Co-authored-by: Ad Schellevis <AdSchellevis at users.noreply.github.com>
Fix ProcessELFCore::GetProcessInfo() to return expected results. (#210807)
Getting the process info from ProcessELFCore would always return the
information from the prpsinfo.pr_psargs from the NT_PRPSINFO. This meant
if the process was launched with a symlink, the process info would
always claim the main executable was the symlink. We want the process
info's executable to always be the resolved executable when possible.
The DynamicLoaderPOSIXDYLD was using the process info to load the main
executable if it wasn't set, or it was comparing if the main
executable's module spec matched the process info, and if it didn't
match it would end up trying to load the main executable using the
process info. We also ask for the UUID from the process before trying to
use the process info to replace the executable in
DynamicLoaderPOSIXDYLD::ResolveExecutableModule().
[AMDGPU] Consult AA for non-atomic clobbers in isReallyAClobber
isReallyAClobber (used by AMDGPUAnnotateUniformValues to decide whether a uniform
load may be marked !amdgpu.noclobber) only queried alias analysis for atomics;
every other memory-writing MemoryDef (plain stores, memory intrinsics, calls)
fell through to an unconditional "return true", declaring it a clobber without
asking AA.
As a result a uniform, read-only load is denied !amdgpu.noclobber whenever
MemorySSA's clobber walk surfaces such a def through a loop MemoryPhi, even when
AA can trivially prove NoAlias (e.g. an LDS/addrspace(3) write vs a
global/addrspace(1) load). Without noclobber the load is selected as a vector
GLOBAL_LOAD instead of a scalar s_load, adding a v_readfirstlane round-trip when
the value feeds a scalar operand.
Query AA generally via getModRefInfo for the fall-through case, while keeping the
fence/barrier whitelist and the pointer-level atomic special case (getModRefInfo
over-reports Mod for an atomic's ordering effects). The load's MemoryLocation is
threaded through so addressing/size precision applies.
[NVPTX] Lower allocas to the local address space (#204346)
Alternative to #201772.
When SelectionDAG expands a small memcpy/memmove/memset it can raise the
alignment of the
destination stack object, but only when the destination is a bare
FrameIndex. Since #121710,
NVPTX treats allocas as assumed-local, and InferAddressSpaces rewrites
the intrinsic
operands to addrspacecasts. ISel no longer sees the frame index, the
alignment isn't raised,
and small unaligned copies are expanded byte-by-byte. We observed up to
1.9x slower kernels
in JuliaGPU/CUDA.jl#3162.
#201772 fixed this in SelectionDAG by looking through addrspacecasts to
recover the stack
object. Per review feedback there, this PR takes a different approach:
[39 lines not shown]
[clang][test] Add Darwin pragma weak alias IR coverage (#211499)
Add Clang IR coverage for `#pragma weak alias = target` on Darwin.
The test verifies that Clang:
- emits the alias with weak linkage;
- keeps calls referencing the alias instead of replacing them with the
aliasee.
This is a test-only follow-up to #198148 and covers the Clang lowering
path used by #111321.
Clarify metadirective local DSA check
- Evaluate non-static locals directly where references under DEFAULT(NONE) are
checked.
- Keep using the ultimate symbol so a nested data-sharing clause other than
PRIVATE still creates the required reference in the enclosing construct.
llvm-mca: Stop defaulting to "native" for the CPU (#211612)
This would warn whenever using a triple that isn't for the host
architecture. Other tools don't do this. Copy what llc does and
default to no cpu.
[flang][OpenMP] Switch TableGen generation to use llvm::EnumSet
Replace the remaining uses of the common::EnumSet-based OmpClauseSet to
llvm::omp::ClauseSet.
Specialize IterateOverMembers instead of ClauseSetToString
There was still a use of common::EnumSet::IterateOverMembers left
over after the prior changes. Get rid of it via the specialization,
and revert the specialization of ClauseSetToString, which was
originally implemented using IterateOverMembers.
[flang] Provide "clause set" type as parameter to DirectiveStructureChecker
This will remove the hardcoded dependence of DirectiveStructureChecker on
the common::EnumSet class. Both consumers of it will be able to use their
own type for the clause set.
The only complication was the ClauseSetToString member function, whose
implementation depended on the specifics of common::EnumSet, namely the
IterateOverMembers member function. It was moved out of the class, and
turned into a function template to make it possible to provide different
specializations for common::EnumSet and llvm::EnumSet.
[flang][OpenMP] Use llvm::omp::DirectiveSet instead of common::EnumSet
Replace uses of OmpDirectiveSet (defined in terms of common::EnumSet)
with the common llvm::omp::DirectiveSet (defined via llvm::EnumSet).
The llvm::omp::DirectiveSet class will also be used in openmp-parsers,
where OmpDirectiveSet was an instance of llvm::Bitset.
