FreeBSD/src 94f86eftests/sys/kern exterr_test.c

uexterror_gettext: add tests for invalid formats

Verify that unsupported, unterminated, and overly long formats output
expected messages.

Reviewed by:    kib
Effort:         CHERI upstreaming
Sponsored by:   Innovate UK
Differential Revision:  https://reviews.freebsd.org/D58413
DeltaFile
+66-0tests/sys/kern/exterr_test.c
+66-01 files

FreeBSD/src ddf6065tests/sys/kern exterr_test.c

exterr(9): add a few tests of new message formats

This is enough to show that the idea works (and to exercise
uexterr_set()), but isn't complete by any means.

Reviewed by:    kib
Effort:         CHERI upstreaming
Sponsored by:   Innovate UK
Differential Revision:  https://reviews.freebsd.org/D58060
DeltaFile
+34-0tests/sys/kern/exterr_test.c
+34-01 files

FreeBSD/src 95e3309include uexterror.h, lib/libc/gen uexterr_gettext.c uexterr_init.c

runtime: add the ability to set exterrors in userspace

The UEXTERROR(3) macro is a partial analog to EXTERROR(9) that sets
the current user exterror state and errno.  The main difference is
that it returns no value and sets errno directly since that's the
typical pattern in libraries.

While here move the storage and constructor for single-threaded
program's uexterr to its own file.

Reviewed by:    kib
Effort:         CHERI upstreaming
Sponsored by:   Innovate UK
Differential Revision:  https://reviews.freebsd.org/D58059
DeltaFile
+135-0lib/libc/gen/uexterror.3
+65-0include/uexterror.h
+50-0lib/libc/gen/uexterr_set.c
+26-0lib/libc/gen/uexterr_init.c
+0-18lib/libc/gen/uexterr_gettext.c
+13-0lib/libthr/thread/thr_syscalls.c
+289-186 files not shown
+304-1912 files

FreeBSD/src 2f024a7lib/libc/gen uexterr_format.c, share/man/man9 exterror.9

exterr: relax format restrictions

Rather than passing the format string to printf and forcing the
arguments to be (u)intmax_t, partially parse format strings and cast
p1 and p2 to the correct type before running the individual format
though printf.  This restructure has a couple motivatations:
 - We can skip formats that make no sense (floating point, %n, etc.).
 - It is possible to special case the printing of pointers in the
   CHERI case.

The first case is motivated by a suggestion from the audiance at
one of Kirk's BSDCan talks on exterr to allow userspace to set exterr
status.  Allowing arbitrary format strings including %n creates a
write-what-where gadget so we need to not do that.

The second case is motivated by our experinces with CHERI and debugging
mmap issues using a different textual error reporting framework.  With
CHERI, pointers are more than integer addresses and it's useful to
include more details.  Doing so will follow in a future commit.

    [8 lines not shown]
DeltaFile
+165-2lib/libc/gen/uexterr_format.c
+10-7share/man/man9/exterror.9
+175-92 files

FreeBSD/src d58ca84tools/test/stress2/misc socketpair3.sh

Fix zombie leak in test using pdfork()
DeltaFile
+1-1tools/test/stress2/misc/socketpair3.sh
+1-11 files

FreeBSD/src 8eb77a5tools/test/stress2/misc all.exclude

stress2: Enable two hwpmc tests that now run as expected
DeltaFile
+0-2tools/test/stress2/misc/all.exclude
+0-21 files

FreeBSD/src 2296f35sys/fs/nullfs null_vnops.c

nullfs(4): Fix a typo in a source code comment

- s/modifing/modifying/

(cherry picked from commit 27c70deb3d260b48bee8f3c4c975fd2de64264fb)
DeltaFile
+1-1sys/fs/nullfs/null_vnops.c
+1-11 files

FreeBSD/src 10e3185sys/dev/ichwd i6300esbwd.c

ichwd(4): Fix a typo in a source code comment

- s/modifing/modifying/

(cherry picked from commit 8362aecdeb2548813942a7e604543c71f5a10271)
DeltaFile
+1-1sys/dev/ichwd/i6300esbwd.c
+1-11 files

FreeBSD/src 8402cf6sys/dev/fxp rcvbundl.h

fxp(4): Fix a typo in a source code comment

- s/modifing/modifying/

(cherry picked from commit c47b430c6ea3aa8d133af0af426d018bae3b7018)
DeltaFile
+1-1sys/dev/fxp/rcvbundl.h
+1-11 files

FreeBSD/src 05f4908sys/netpfil/ipfw dn_sched_fq_pie.c

ipfw(4): Fix a typo in a source code comment

- s/varaiables/variables/

(cherry picked from commit 251e6ef40203a6f911d7f4daacf3075de7f870c0)
DeltaFile
+1-1sys/netpfil/ipfw/dn_sched_fq_pie.c
+1-11 files

FreeBSD/src 06c3e7clib/msun/src catrig.c

msun: Fix a typo in a source code comment

- s/uneccessarily/unnecessarily/

Obtained from:  NetBSD

(cherry picked from commit cd4aae2fa9d35015248c445752e23800e75e8517)
DeltaFile
+1-1lib/msun/src/catrig.c
+1-11 files

FreeBSD/src 259c45dsys/vm swap_pager.c

swap_pager: Fix a typo in a source code comment

- s/errornous/erroneous/

(cherry picked from commit 88293bdd1eefb4bf518e1764d370b4a2321afdd1)
DeltaFile
+1-1sys/vm/swap_pager.c
+1-11 files

FreeBSD/src 1c4f2a6sys/dev/ppbus ppb_msq.h

ppbus(4): Fix a typo in a source code comment

- s/predifined/predefined/

(cherry picked from commit 709bd45a1b3a5ca21e05995c0c01f0ee8e7e8c38)
DeltaFile
+1-1sys/dev/ppbus/ppb_msq.h
+1-11 files

FreeBSD/src aeec956sys/fs/nullfs null_vnops.c

nullfs(4): Fix a typo in a source code comment

- s/modifing/modifying/

(cherry picked from commit 27c70deb3d260b48bee8f3c4c975fd2de64264fb)
DeltaFile
+1-1sys/fs/nullfs/null_vnops.c
+1-11 files

FreeBSD/src 4fb09e9sys/dev/ichwd i6300esbwd.c

ichwd(4): Fix a typo in a source code comment

- s/modifing/modifying/

(cherry picked from commit 8362aecdeb2548813942a7e604543c71f5a10271)
DeltaFile
+1-1sys/dev/ichwd/i6300esbwd.c
+1-11 files

FreeBSD/src 4054710sys/dev/fxp rcvbundl.h

fxp(4): Fix a typo in a source code comment

- s/modifing/modifying/

(cherry picked from commit c47b430c6ea3aa8d133af0af426d018bae3b7018)
DeltaFile
+1-1sys/dev/fxp/rcvbundl.h
+1-11 files

FreeBSD/src 9e62481sys/netpfil/ipfw dn_sched_fq_pie.c

ipfw(4): Fix a typo in a source code comment

- s/varaiables/variables/

(cherry picked from commit 251e6ef40203a6f911d7f4daacf3075de7f870c0)
DeltaFile
+1-1sys/netpfil/ipfw/dn_sched_fq_pie.c
+1-11 files

FreeBSD/src bbf2339lib/msun/src catrig.c

msun: Fix a typo in a source code comment

- s/uneccessarily/unnecessarily/

Obtained from:  NetBSD

(cherry picked from commit cd4aae2fa9d35015248c445752e23800e75e8517)
DeltaFile
+1-1lib/msun/src/catrig.c
+1-11 files

FreeBSD/src 352cf5bsys/vm swap_pager.c

swap_pager: Fix a typo in a source code comment

- s/errornous/erroneous/

(cherry picked from commit 88293bdd1eefb4bf518e1764d370b4a2321afdd1)
DeltaFile
+1-1sys/vm/swap_pager.c
+1-11 files

FreeBSD/src c3b7f92sys/dev/ppbus ppb_msq.h

ppbus(4): Fix a typo in a source code comment

- s/predifined/predefined/

(cherry picked from commit 709bd45a1b3a5ca21e05995c0c01f0ee8e7e8c38)
DeltaFile
+1-1sys/dev/ppbus/ppb_msq.h
+1-11 files

FreeBSD/src aec0f1bsys/dev/e1000 if_em.c

e1000: Report 82571 packet buffer ECC errors

The 82571 PBA_ECC register contains a 12-bit count of packet buffer ECC
detections.  The shared code enables single-bit correction, but neither
FreeBSD nor the DPDK base driver consumes the counter.

Sample it with the ordinary statistics timer, accumulate the value under
dev.em.N.memory_errors.detected_packet_buffer, and clear the hardware
counter while preserving correction and reserved register state.  Do not
enable its shared interrupt: the register does not distinguish corrected
from uncorrectable events and does not provide a safe fatal recovery
policy.

Validated on a dual port 82571EB.  Both functions reported zero after a
clean boot, and a controlled link down/up cycle left the counter at zero
while the management link recovered at 1 Gb/s without issue.

MFC after:      2 weeks
Sponsored by:   BBOX.io
DeltaFile
+47-7sys/dev/e1000/if_em.c
+47-71 files

FreeBSD/src 8d83b10share/examples/jails rc.conf.jails rcjail.xxx.conf

New version of jng (9.1)

Update examples and comments to return eifaces in exec.prestop
with ifconfig -vnet (before jng shutdown in poststop).

Reported by:    jlduran
PR:             268397
MFC after:      1 week
Reviewed by:    kfv, jlduran
Differential Revision:  https://reviews.freebsd.org/D58939
DeltaFile
+12-6share/examples/jails/jng
+2-1share/examples/jails/rcjail.xxx.conf
+2-1share/examples/jails/jail.xxx.conf
+2-0share/examples/jails/rc.conf.jails
+18-84 files

FreeBSD/src ba99013sys/fs/tarfs tarfs_vfsops.c, usr.sbin/jail jail.8

tarfs: allow mounting inside jails

Reviewed by:    des
MFC after:      1 week
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D58833
DeltaFile
+9-1usr.sbin/jail/jail.8
+1-1sys/fs/tarfs/tarfs_vfsops.c
+10-22 files

FreeBSD/src 4d52491sys/fs/tarfs tarfs_vfsops.c

tarfs: remove PRIV_VFS_MOUNT_PERM check

The backing file is already opened successfully, so there is
no need to override the permissions.

Reviewed by:    des
MFC after:      1 week
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D58832
DeltaFile
+0-5sys/fs/tarfs/tarfs_vfsops.c
+0-51 files

FreeBSD/src 60c0a07sbin/route route_netlink.c, sys/netlink netlink_snl_route_parsers.h netlink_snl_generic.h

netlink: Parse repeated nested attributes

Modern Netlink arrays encode their elements as repeated attributes of
the same type rather than as children of an additional array container.

Add an SNL callback that parses one nested element for each occurrence
and appends it to a geometrically grown parser array.  Retain the
existing parray callback for protocols that use the legacy container
form.

Store the growth capacity in struct snl_parray, appended after its
existing public count and items fields so their offsets remain stable
on LP64 and ILP32.  Require parser targets to be real snl_parray
objects, and convert bitset, generic Netlink, and route multipath arrays
accordingly.  This avoids relying on layout aliases for private growth
state.

Add regression coverage for a nested bit array that grows beyond its
initial allocation, while preserving replacement semantics when a

    [5 lines not shown]
DeltaFile
+78-28sys/netlink/netlink_snl.h
+65-0tests/sys/netlink/test_snl.c
+31-28usr.bin/genl/genl.c
+11-11sbin/route/route_netlink.c
+8-10sys/netlink/netlink_snl_generic.h
+4-7sys/netlink/netlink_snl_route_parsers.h
+197-845 files not shown
+211-10011 files

FreeBSD/src fdcb52dsys/ofed/drivers/infiniband/ulp/ipoib ipoib_ib.c

ofed/ipoib: convert to timer_setup linuxKPI

Reviewed by:    bz
Sponsored by:   NVidia networking
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D58941
DeltaFile
+6-4sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_ib.c
+6-41 files

FreeBSD/src 814cd91sys/dev/mlx5/mlx5_core mlx5_health.c, sys/dev/mlx5/mlx5_ib mlx5_ib_mr.c

mlx5(4): convert to timer_setup() linuxKPI

Reviewed by:    bz
Sponsored by:   NVidia networking
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D58941
DeltaFile
+3-3sys/dev/mlx5/mlx5_ib/mlx5_ib_mr.c
+3-3sys/dev/mlx5/mlx5_core/mlx5_health.c
+6-62 files

FreeBSD/src 241df6asys/kern uipc_usrreq.c

unix: fix comment

Noticed by:     mckusick
Fixes:          6563dcb6b1f57e51db63854f3774b52e672232ed
DeltaFile
+1-1sys/kern/uipc_usrreq.c
+1-11 files

FreeBSD/src ba27b63sys/compat/linux linux.h linux_netlink.c

linux: Add STF type and convert some if_type to ARPHRD

Convert IFT_BRIDGE and IFT_L2VLAN to ARPHRD_ETHER, and IFT_LOOP
to ARPHRD_LOOPBACK in linux netlink.
Also, add ARPHRD_SIT and convert IFT_STF to it.

Reviewed by:    kfv
Differential Revision:  https://reviews.freebsd.org/D58573
DeltaFile
+8-0sys/compat/linux/linux_netlink.c
+1-0sys/compat/linux/linux.h
+9-02 files

FreeBSD/src a6e9e4cshare/man/man9 Makefile rtentry.9

nhop.9: Rewrite relics of rtentry.9 into nhop.9

Parts of rtentry.9 information such as information related to
the nexthop is outdated.
Remove those relics and add the new design into separate
manual instead.

Reviewed by:    bcr
Discussed with: ziaee
Differential Revision: https://reviews.freebsd.org/D58564
DeltaFile
+123-0share/man/man9/nhop.9
+16-40share/man/man9/rtentry.9
+2-0share/man/man9/Makefile
+141-403 files