FreeBSD/src 04fcf30sbin/ipfw dummynet.c

dummynet: do not overflow the points[ED_MAX_SAMPLES_NO] array

Otherwise, the following would segfault

dnctl pipe 1 config bw 1Mbit/s profile 1025points.txt

Found with:     Claude Code Sonnet 5
MFC after:      2 weeks
DeltaFile
+3-0sbin/ipfw/dummynet.c
+3-01 files

FreeBSD/src 30c20catools/build/mk OptionalObsoleteFiles.inc

Remove Dtrace/ZFS tests if their knobs are disabled

Prior to this change, Dtrace and ZFS tests and their respective
directories would remain installed even if `${MK_DTRACE_TESTS}` == no or
`${MK_ZFS_TESTS}` == no.

This change enhances the logic to remove the tests when the respective
knobs are disabled so the tests will be removed when `make delete-old`
is run.

MFC after:      2 weeks
DeltaFile
+25-0tools/build/mk/OptionalObsoleteFiles.inc
+25-01 files

FreeBSD/src 5a2328arelease/tools vmimage.subr

vmimage.subr: Include dangling symlinks in images

When creating VM images, we filter the METALOG file created by pkg(8)
when installing non-base packages, rejecting any lines which correspond
to files which don't exist; this solves a problem which arose when a
package was installed and then deinstalled (or upgraded) later in the
image-building process.

Unfortunately [ -e ... ] follows symlinks and is not basedir-aware, so
an absolute symlink which is valid *inside* the image is omitted from
the image if it points to something which isn't present in the build
host system.

Replace [ -e ... ] with [ -e ... ] || [ -L ... ] so that symlinks are
included even if dangling.

While I'm here, add quoting in case future paths become problematic.

Sponsored by:   Amazon
MFC after:      3 days
DeltaFile
+2-1release/tools/vmimage.subr
+2-11 files

FreeBSD/src 8a0cab2sys/dev/hwpmc hwpmc_amd.h hwpmc_amd.c

hwpmc/amd: replace static pmcdesc[] and pc_amdpmcs[] with dynamic allocation

AMD_NPMCS_MAX = 342 (16 core + 6 L3 + 64 DF + 256 UMC). On a Zen 4
EPYC 9654 with 6 core, 6 L3, 16 DF, and 4 UMC counters, only 32
descriptors are needed; the static arrays over-allocate by ~10x.

Replace both amd_pmcdesc[AMD_NPMCS_MAX] and per-CPU pc_amdpmcs[AMD_NPMCS_MAX]
with mallocarray() sized to the actual registered PMC count:
  - amd_pmcdesc: allocated in pmc_amd_initialize()
  - pc_amdpmcs:  allocated per-CPU in amd_pcpu_init(), freed in fini()

Normalize amd_l3_npmcs and amd_df_npmcs against the AMDID2_PTSCEL2I
and AMDID2_PNXC feature bits before computing npmcs_total, so that
allocation, registration, and amd_get_msr() row offsets are all derived
from the same values.  Previously the ternary in npmcs_total excluded
L3/DF from the allocation while the globals retained their defaults,
causing amd_get_msr() to miscompute DF row offsets when L3 is absent.

amd_umc_npmcs comes from CPUID Fn8000_0022h EBX[23:16] (NumUMCCounters)

    [14 lines not shown]
DeltaFile
+41-2sys/dev/hwpmc/hwpmc_amd.c
+2-1sys/dev/hwpmc/hwpmc_amd.h
+43-32 files

FreeBSD/src c745fccsys/riscv/conf GENERIC

riscv: enable gpiopower driver

It is functional, and there are some RISC-V platforms which can benefit
from it.

Requested by:   Brian Scott <bscott at bunyatech.com.au>
Sponsored by:   The FreeBSD Foundation
DeltaFile
+1-0sys/riscv/conf/GENERIC
+1-01 files

FreeBSD/src e676978sys/dev/eqos if_eqos.c

eqos: Reduce RX error noisiness

Reduce very common console messages:
        Receive error rdes3=30208000

As observed on the VisionFive v2 hardware after some large transfers.

Differentiate between overflow errors and others. Report the errors when
the length is non-zero (overflow errors).

Also, count errors for netstat purposes.

Reviewed by:    mhorne
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D59479
DeltaFile
+9-1sys/dev/eqos/if_eqos.c
+9-11 files

FreeBSD/src 9257ae7. MAINTAINERS, .github CODEOWNERS

Add entries for third-party projects I maintain

Add myself formally as the "maintainer" for atf, kyua, and lutok, both
in the GitHub CODEOWNERS and MAINTAINERS files.

This change matches the herald rules I recently setup for these
third-party components.
DeltaFile
+2-0MAINTAINERS
+2-0.github/CODEOWNERS
+4-02 files

FreeBSD/src b952821share/man/man4 ulpt.4

ulpt.4: Canonicalize SYNOPSIS, tag SPDX

MFC after:      3 days
DeltaFile
+6-11share/man/man4/ulpt.4
+6-111 files

FreeBSD/src 2784767share/man/man4 umct.4

umct.4: Canonicalize SYNOPSIS, HARDWARE, tag SPDX

MFC after:      3 days
DeltaFile
+8-14share/man/man4/umct.4
+8-141 files

FreeBSD/src 71a0ea7share/man/man4 umcs.4

umcs.4: Describe better, canonicalize SYNOPSIS

+ tag SPDX
+ improve apropos and hardware notes context
+ canonicalize SYNOPSIS

MFC after:      3 days
DeltaFile
+13-18share/man/man4/umcs.4
+13-181 files

FreeBSD/src 6204c60share/man/man4 uled.4

uled.4: Canonicalize SYNOPSIS, tag SPDX

MFC after:      3 days
DeltaFile
+6-11share/man/man4/uled.4
+6-111 files

FreeBSD/src 46d383ausr.sbin/pciconf pciconf.8 pciconf.c

pciconf: Add -C option to filter by class name

Differential Revision:  https://reviews.freebsd.org/D59602
MFC after:      3 weeks
PR:             289923
Reviewed by:    bnovkov
DeltaFile
+35-5usr.sbin/pciconf/pciconf.c
+8-2usr.sbin/pciconf/pciconf.8
+43-72 files

FreeBSD/src 64a73d1sys/amd64/amd64 sigtramp.S, sys/amd64/ia32 ia32_sigtramp.S

amd64/*sigtramp.S: re-enable some cfi annotations for special registers

Also explicitly specify .cfi_sections to emit the cfi bytecode into the
loadable .eh_frame section.

Reviewed by:    mchoo
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D59838
DeltaFile
+27-17sys/amd64/amd64/sigtramp.S
+13-6sys/amd64/ia32/ia32_sigtramp.S
+40-232 files

FreeBSD/src 1b9aea3usr.bin/gh-bc/tests dc_tests.sh bc_tests.sh

gh-bc/tests: run tests in parallel

Helps to mitigate failures due to timeout in CI on emulated architectures:
https://ci.freebsd.org/job/FreeBSD-main-riscv64-test/16565/testReport/usr.bin.gh-bc/

MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D59547
DeltaFile
+1-1usr.bin/gh-bc/tests/dc_tests.sh
+1-1usr.bin/gh-bc/tests/bc_tests.sh
+2-22 files

FreeBSD/src f1a4ac4share/man/man4 uipaq.4

uipaq.4: Canonicalize SYNOPSIS, tag SPDX

MFC after:      3 days
DeltaFile
+8-13share/man/man4/uipaq.4
+8-131 files

FreeBSD/src f4e7e5eshare/man/man4 ukbd.4

ukbd.4: Canonicalize SYNOPSIS, tag SPDX

Also add a missing Cd tag for consistency.

MFC after:      3 days
DeltaFile
+24-14share/man/man4/ukbd.4
+24-141 files

FreeBSD/src b27a221usr.sbin/bhyve pci_emul.c

bhyve: fix boot device ordering

EDK2's QemuBootOrderLib inspects the bootorder file provided
via fw_cfg and requires it to be NUL-terminated. Otherwise,
it rejects the supplied bootorder and falls back to its
default boot order.

Currently, bhyve registers bootorder with qemu_fwcfg_add_file()
using bootorder_len returned by open_memstream(), which excludes
the trailing NUL byte.

Fix that by passing bootorder_len + 1 to qemu_fwcfg_add_file() so
the fw_cfg payload is properly NUL-terminated.

PR:             279720
Reviewed by:    markj
Found with:     codex (gpt-5.6-sol)
MFC after:      1 week
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D59859
DeltaFile
+1-1usr.sbin/bhyve/pci_emul.c
+1-11 files

FreeBSD/src 00d693eshare/man/man4 ufoma.4

ufoma.4: Improve HARDWARE introductory sentence

MFC after:      3 days
DeltaFile
+2-2share/man/man4/ufoma.4
+2-21 files

FreeBSD/src 7d1edc5share/man/man4 uhid.4

uhid.4: Canonicalize SYNOPSIS, tag SPDX

MFC after:      3 days
DeltaFile
+14-13share/man/man4/uhid.4
+14-131 files

FreeBSD/src 2407b84share/man/man4 uhso.4

uhso.4: describe better, SYNOPSIS, HARDWARE, SPDX

+ Update SYNOPSIS to the new standard format
+ Give this a clearer description in apropos
+ Give this a clearer description in hardware note
+ Spinoff SYSCTL VARIABLES from HARDWARE
+ Pet linter for long lines and trailing punctuation
+ Tag SPDX

MFC after:      3 days
DeltaFile
+33-22share/man/man4/uhso.4
+33-221 files

FreeBSD/src 6a07579share/man/man4 ugold.4

ugold.4: Canonicalize SYNOPSIS, HARDWARE, tag SPDX

MFC after:      3 days
DeltaFile
+11-15share/man/man4/ugold.4
+11-151 files

FreeBSD/src fc44154sys/amd64/vmm/io vatpit.c

vmm: Re-arm the PIT callout for square wave mode

The 8254's square wave mode (mode 3) is periodic, with the same
interrupt rate as the rate generator mode (mode 2), but
vatpit_callout_handler() only re-arms the channel 0 callout for
TIMER_RATEGEN.  A guest that programs mode 3 therefore receives a
single IRQ0 and no further timer interrupts.

Re-arm the callout for TIMER_SQWAVE as well, matching illumos
change 13301.

Reviewed by:    markj
Obtained from:  illumos 93d78aba5b32996fc2ae893a6237a0d3972f86b2
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D59816
DeltaFile
+1-1sys/amd64/vmm/io/vatpit.c
+1-11 files

FreeBSD/src ce5b706sys/amd64/vmm vmm_instruction_emul.c

vmm: Fix a page wiring leak in MOVS emulation

When emulating a MOVS from MMIO to guest RAM, the kernel's
vm_copy_setup() wires the destination pages.  If the subsequent
MMIO read fails, emulate_movs() skips vm_copy_teardown(), leaking
the page wire references acquired during setup.

Run vm_copy_teardown() regardless of the MMIO read result, and
only copy the value to guest memory if the read succeeds.
Preserve the existing error return.

This matches illumos change 13309.

Reviewed by:    markj
Obtained from:  illumos 83cd75bb2949d26e6eb38ddefc60fdeed1909643
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D59823
DeltaFile
+9-3sys/amd64/vmm/vmm_instruction_emul.c
+9-31 files

FreeBSD/src d400b1csys/amd64/vmm/intel vmx.c

vmm: Synchronize long-mode state when emulating CR0 writes

vmx_emulate_cr0_access() sets EFER.LMA and the IA-32e guest VM-entry
control when enabling paging with EFER.LME set, but does not clear them
when disabling paging.  This can leave an inconsistent guest state that
fails VM entry.

Update both fields in either direction based on EFER.LME and the CR0
value written to the VMCS.  Use the mask-adjusted CR0 value so the
resulting state remains consistent with the VMX fixed-bit requirements.

Reviewed by:    markj
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D59756
DeltaFile
+15-17sys/amd64/vmm/intel/vmx.c
+15-171 files

FreeBSD/src 3330226sys/amd64/vmm/io vatpit.c

vmm: Normalize a zero PIT count before starting channel 0

pit_timer_start_cntr0() does not schedule a callout when the initial
count is zero.  The counter write handler normalizes a programmed zero
count only after calling it, leaving an initially unarmed channel 0
without a scheduled timer event.

Move the existing normalization before the timer-start call.  Retain the
historical 0xffff representation of a zero count.

Reviewed by:    markj
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D59749
DeltaFile
+2-2sys/amd64/vmm/io/vatpit.c
+2-21 files

FreeBSD/src 5123453usr.sbin/bhyveload bhyveload.c

bhyveload: validate character disk devices

Currently, bhyveload(8) does not validate the supplied disk
image path. For example, it allows passing the /dev/null
device, which later fails in userboot because it does not
support DIOCGSECTORSIZE and DIOCGMEDIASIZE ioctls (see
userdisk_init() in stand/userboot/userboot/userboot_disk.c).

Fix that by checking DIOCGSECTORSIZE and DIOCGMEDIASIZE ioctls early.
A similar check already exists in bhyve(8). While here, make
cb_diskioctl() report the obtained sector size instead of
hard-coding 512.

Reviewed by:    markj
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D59253
DeltaFile
+31-3usr.sbin/bhyveload/bhyveload.c
+31-31 files

FreeBSD/src 8943d47share/man/man4 ugen.4

ugen.4: Canonicalize SYNOPSIS + tag SPDX

MFC after:      3 days
DeltaFile
+11-4share/man/man4/ugen.4
+11-41 files

FreeBSD/src 0a81077share/man/man4 ufshci.4

ufshci.4: Canonicalize SYNOPSIS, LOADER TUNABLES

+ Update SYNOPSIS to the new standard format
+ Rename CONFIGURATION to the usual LOADER TUNABLES
+ Adjust tunable markup for inclusion in the search index
+ Editorial nit: Unwind a parenthetical

MFC after:      3 days
DeltaFile
+18-28share/man/man4/ufshci.4
+18-281 files

FreeBSD/src acaab48share/man/man4 ufoma.4

ufoma: Describe better, short SYNOPSIS, tag SPDX

This driver is for NTT DoCoMo 3G cellular equiment, which afaict all
went offline six months ago. Tidy up the entry until we can remove it.

MFC after:      3 days
DeltaFile
+10-15share/man/man4/ufoma.4
+10-151 files

FreeBSD/src 6a34abbsys/netpfil/pf if_pfsync.c, tests/sys/netpfil/pf pfsync.sh

pfsync: when importing a state clear take the interface name into account

When one pfsync host clears states it informs its peers about this.
While processing such messages, in pfsync_in_clr() we failed to take the
interface name into account.
This meant that if one host cleared states on one interface the peers
would clear all states, not just those on the affected interface.

Actually check for the interface in pfsync_in_clr()

Sponsored by:   Rubicon Communications, LLC ("Netgate")
DeltaFile
+86-0tests/sys/netpfil/pf/pfsync.sh
+10-6sys/netpfil/pf/if_pfsync.c
+96-62 files