Revert "nda: Filter non-storage nvme drives"
This reverts commit b40205855e100a4bd95f89e97c15d268ef5b3a35. There's an
aparent path lifetime issue in it that needs to be investigated.
Sponsored by: Netflix
nullfs: Clear inotify flags during reclaim
The inotify flags are copied from the lower vnode into the nullfs vnode
so that the INOTIFY() macro will invoke VOP_INOTIFY on the nullfs vnode;
this is then bypassed to the lower vnode. However, when a nullfs vnode
is reclaimed we should clear these flags, as the vnode is now doomed and
no longer forwards VOPs to the lower vnode.
Add regression tests. Remove a test in vn_inotify_revoke() which is no
longer needed after this change.
PR: 292495
Reviewed by: kib
Reported by: Jed Laundry <jlaundry at jlaundry.com>
Fixes: f1f230439fa4 ("vfs: Initial revision of inotify")
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D56639
netbsd-tests: Fix the mmap_truncate_signal test
Add a volatile qualifier in the loop which triggers SIGBUS, as otherwise
the compiler is smart enough to elide it, replacing it with a check for
page != 0.
MFC after: 1 week
tests/ipfw: Make tests run more reliably in parallel
- Don't use /dev/null as the pidfile for inetd, that doesn't work
properly. Create a pidfile in the per-test scratch directory.
- Use atf_check to validate results from setup commands.
MFC after: 1 week
sound: Remove some forward declarations from sound.h and uaudio.h
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
(cherry picked from commit 602249f033d146d9c731d8b1cb4b2e0899c61ad9)
mixer(3): Rename _mixer_readvol() to mixer_readvol()
No functional change intended.
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
(cherry picked from commit c39237a4fd2b1472e452052103156c915942d070)
vt_core: make sure the driver's functions exist
These are NULL if they're not implemented. Make sure all the functions
we need are there before doing anything.
Also invert the first if statment to lessen the indentation a bit.
Reported by: Quentin Thébault <quentin.thebault at defenso.fr>
MFC after: 3 days
vt_core: delay the shutdown splash event handler
Even though the functions are currently executed in the correct order,
there's no garuntee that this will always be the case.
Reported by: kevans
Discussed with: kevans
Fixes: 4b862c713ac5556ab4bd1828b47c5eb9cb28e067
MFC after: 3 days
ifnet: if_detach(): Fix races with vmove operations
The rationality is that the driver private data holds a strong reference
to the interface, and the detach operation shall never fail. Given the
vmove operation, if_vmove_loan(), if_vmove_reclaim() or vnet_if_return()
is not atomic and spans multiple steps, acquire ifnet_detach_sxlock only
for if_detach_internal() and if_vmove() is not sufficient. It is possible
that the thread running if_detach() sees stale vnet, or the vmoving is
in progress, then if_unlink_ifnet() will fail.
Fix that by extending coverage of ifnet_detach_sxlock a bit to also
cover if_unlink_ifnet(), so that the entire detach and vmove operation
is serialized.
Given it is an error when the if_unlink_ifnet() fails, and if_detach()
is a public KPI, prefer panic() over assertion on failure, to indicate
explicitly that bad thing happens. That shall also prevent potential
corrupted status of the interface, which is a bit hard to diagnose.
[4 lines not shown]
ifinfo: improve output of hwassist value
In addition to print the hexadecimal number hwassist, also print
the symbolic names of the corresponding CSUM_* flags.
Reviewed by: tuexen
Differential Revision: https://reviews.freebsd.org/D55055
Event: Wiesbaden Hackathon 2026
(cherry picked from commit d84870d90bafe75eb87759df0ab41ff0214c866e)
pkgconf: fix the build with GCC 14
Building pkgconf with GCC 14 currently fails with:
no option '-Wincompatible-pointer-types-discards-qualifiers'
This relaxes warnings for libpkgconf, pkgconf(1), and bomtool(1) until
the improvements are published upstream (see PR #444).
Co-authored-by: ngie
Approved by: ngie
Sponsored by: The FreeBSD Foundation
Event: Wiesbaden Hackathon 202604
Differential Revision: https://reviews.freebsd.org/D56591
packages: Register pkgconf
This should fix the creation of the new packages introduced by the
import of pkgconf into the base system.
Fixes: b8352da33f34 ("pkgconf: import into the base system")
Sponsored by: The FreeBSD Foundation
Differential revision: https://reviews.freebsd.org/D56589
printenv: Clean up
* Error out if more than one argument is given.
* Check for stdio errors.
* Clean up the code.
* Clean up and expand the tests.
MFC after: 1 week
Reviewed by: ngie
Differential Revision: https://reviews.freebsd.org/D56506
(cherry picked from commit abdf2a711cabebc107a04fd286e441e2030827f0)
ident: Clean up
* Use libcasper instead of reinventing it.
* Add long option support.
* Drop pointless use of temporary locales.
* Consistently check for stdio errors.
* Clean up the code.
* Clean up and expand the tests.
MFC after: 1 week
Reviewed by: ngie
Differential Revision: https://reviews.freebsd.org/D56505
(cherry picked from commit 394f6b1b0a658755a9420906fb7a459c3d9501a5)
tests.7: Provide better examples
Previous authors appear to have prioritized brevity over clarity. This
unfortunately resulted in a manual page that left its reader with the
false impression that Kyua is difficult to use. Attempt to correct
this by providing more and simpler examples with longer explanations.
While here, correct outdated information about where Kyua stores its
logs and results.
MFC after: 1 week
Reviewed by: ziaee, ngie
Differential Revision: https://reviews.freebsd.org/D56475
(cherry picked from commit 3d00db6b8b73ef7f89654a2928d247d62d39ee29)
Revert "Tentative fix for powerpc boot1.chrp linking problem."
This reverts base 4822a2cf990048c6eed7822fd34a1aeeb7c39cdf. The change
in base aa0bc7cca153f67f8becec8a8fb259ff5fd30fd0 already fixed the
original issue, which is that newer versions of lld complain "section
'.text' address (0x38000) is smaller than image base (0x10000000);
specify --image-base".
Reported by: ivy
PR: 292067
MFC after: 1 month
build.7: Improve make delete-old example
Be more explicit that deleting old files and libraries needs to be
really after you're rebooted a third time and you're really actually
sure your applications aren't using old libs, following irc discussion.
Also adjust an example slightly to fit on 80 character console.
MFC after: 3 days
Discussed with: emaste, fuz, jhb
Differential Revision: https://reviews.freebsd.org/D54079
(cherry picked from commit 1d69c8e4ac7da648f63a830b23b872582469ba37)