FreeBSD/src 1d02c25tests/sys/fs/fusefs mockfs.cc

fusefs: proofread an error message in the tests

Reported by:    otis
Fixes:          2c1482e3053 ("fusefs: fix a race in the pre-init tests")
Sponsored by:   ConnectWise

(cherry picked from commit 381ebe25f0b9fae5b3470e9c6e0767909e0fa85a)
DeltaFile
+1-1tests/sys/fs/fusefs/mockfs.cc
+1-11 files

FreeBSD/src c57b054tests/sys/fs/fusefs mockfs.cc pre-init.cc

fusefs: fix a race in the pre-init tests

These tests allow the user to customize the INIT response.  But it's
necessary to block the daemon's service loop from running until those
expectations have been set.  This race has never caused failures before
simply due to luck.  But now it's failing on slower platforms.

PR:             296236
Reported by:    siva
Sponsored by:   ConnectWise
Reviewed by:    siva
Differential Revision: https://reviews.freebsd.org/D57781

(cherry picked from commit 2c1482e305368af182a7bde0e53d0d180b319326)
DeltaFile
+8-3tests/sys/fs/fusefs/mockfs.cc
+6-0tests/sys/fs/fusefs/pre-init.cc
+3-0tests/sys/fs/fusefs/mockfs.hh
+17-33 files

FreeBSD/src ed15ec6sys/fs/fuse fuse_vnops.c

fusefs: only search for FREAD fufh in readdir

The extra search for an FEXEC fufh shall be removed, since readdir
is only supposed to be called on a directory opened with FREAD.  The
sole exception is NFS, which will call VOP_READDIR with directories that
aren't open at all.  fuse already has special code to handle that.

Also remove the fuse_filehandle_get_dir() function, since it's not
used anywhere else.

Signed-off-by:  CismonX <admin at cismon.net>
Reviewed by:    asomers
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1729

(cherry picked from commit 4179f1d9deed83977f159c8afea204293ef4c7d7)
DeltaFile
+1-11sys/fs/fuse/fuse_vnops.c
+1-111 files

FreeBSD/src 2da045asys/fs/fuse fuse_vnops.c, tests/sys/fs/fusefs default_permissions.cc

fusefs: fix error handling when reading a directory's sticky bit

When trying to delete or rename a file, fuse_vnop_lookup must check
whether its parent directory's sticky bit is set.  Realistically, the
parent directory's attributes will almost always be cached.  But it's
possible that they won't be, and in that case we must send a new
FUSE_GETATTR request to the server.  If that request fails for some
reason, then we must fail the lookup.  Prior to this change fusefs would
ignore failure of that request.

Reported by:    Yuxiang Yang, Yizhou Zhao, Ao Wang, Xuewei Feng, Qi Li,
                and Ke Xu of Tsinghua University
Reviewed by:    markj
Differential Revision: https://reviews.freebsd.org/D57588

(cherry picked from commit b4af6a4cccc3b4b0ea461463196c258eb92ad2e5)
DeltaFile
+53-0tests/sys/fs/fusefs/default_permissions.cc
+6-4sys/fs/fuse/fuse_vnops.c
+59-42 files

FreeBSD/src b72397dsys/kern sys_generic.c

kern_filewrite(): unconditionally calculate cnt, it is used by callers

Reported by:    dhw, madpilot
Tested by:      dhw
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Fixes:  dfad790c8cca ("sendfile: stop abusing kern_writev()")
DeltaFile
+1-1sys/kern/sys_generic.c
+1-11 files

FreeBSD/src ed7e0ebusr.sbin/bhyve snapshot.c bhyve_config.5, usr.sbin/bhyve/amd64 bhyverun_machdep.c

bhyve: allow overriding snapshot socket directory

By default bhyve(8) creates a snapshot socket in
"/var/run/bhyve/" (BHYVE_RUN_DIR).
As this is a system directory not writable by users,
this does not work when bhyve(8) is being started
as a non-root user.

Address that by allowing to override this directory.
In bhyve(8) it is done by setting 'rundir' option
with '-o rundir=<path>'.

In bhyvectl(8) it is done with '--rundir=<path>'.

MFC after:              1 month
Reviewed by:            bcr (manpages), bnovkov
Sponsored by:           The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D57494
DeltaFile
+25-7usr.sbin/bhyvectl/bhyvectl.c
+10-4usr.sbin/bhyve/snapshot.c
+8-1usr.sbin/bhyve/bhyve_config.5
+7-1usr.sbin/bhyvectl/bhyvectl.8
+6-0usr.sbin/bhyve/amd64/bhyverun_machdep.c
+1-1usr.sbin/bhyve/snapshot.h
+57-141 files not shown
+58-157 files

FreeBSD/src e75fa2asys/compat/freebsd32 freebsd32_sysent.c, sys/kern init_sysent.c

Regen syscalls tables.

This catches up with 692b0ef1506ba which added CAPENABLED to
clock_nanosleep(). Curiously recent additions of the pdopenpid(2) and
pddupfd(2) were done before the cited commit, and that regen did not
included the change.

Sponsored by:   The FreeBSD Foundation
DeltaFile
+1-1sys/kern/init_sysent.c
+1-1sys/compat/freebsd32/freebsd32_sysent.c
+2-22 files

FreeBSD/src 7e1245asys/compat/linuxkpi/common/include/linux pm_runtime.h

linuxkpi: Add pm_runtime_resume_and_get

pm_runtime_resume_and_get is used by new versions of amdgpu, and began
use between Linux kernel version 6.12, and 6.14.

Reviewed by:    dumbbell
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D57463
DeltaFile
+6-0sys/compat/linuxkpi/common/include/linux/pm_runtime.h
+6-01 files

FreeBSD/src 1cce5efsys/net if_lagg.c

lagg: re-check port caps after bringing up a port

Some nic drivers (including iflib) do not initialize if_hwassist
until after the interface is brought up.  If a lagg member is included
in a lagg when its not yet been brought up, that will cause lagg to see
if_hwassist=0 and will disable all checksum offload, etc, on the interface.
This is almost impossible to debug without kgdb or dtrace, as ifconfig does
not surface if_hwassist.

Fix this by re-calculating lagg caps (including if_hwassist) after adding a port.

I encountered this problem when I had a commented-out if_foo1=up entry in
my rc.conf that i neglected to uncomment when I was re-configuring a lagg.

Sponsored by: Netflix
Reviewed by: markj, zlei
Differential Revision: https://reviews.freebsd.org/D58062
DeltaFile
+2-0sys/net/if_lagg.c
+2-01 files

FreeBSD/src c38abd6sys/net if_epair.c, tests/sys/common vnet.subr

if_epair: support IFCAP_MEXTPG

Enable IFCAP_MEXTPG by default, which may bring performance benefits.
Allow it to be disabled, and when disabled assert that we do not receive
any mbufs with M_EXTPG set. This is useful for testing.
Default the tests to disabling MEXTPG support.

Reviewed by:    zlei
Sponsored by:   Rubicon Communications, LLC ("Netgate")
Differential Revision:  https://reviews.freebsd.org/D58054
DeltaFile
+6-1sys/net/if_epair.c
+3-1tests/sys/common/vnet.subr
+9-22 files

FreeBSD/src 8a14fcdsys/netpfil/pf pf.c, tests/sys/netpfil/pf unmapped_mbuf.sh Makefile

pf: fix a crash on sendfile()

The network layer must not pass unmapped (M_EXTPG) mbufs to if_output()
of network interfaces without IFCAP_MEXTPG. pf should convert these
mbufs by mb_unmapped_to_ext() for such interfaces but it didn't.
The problem had occurred on sendfile because sendfile system call
uses unmapped mbufs for the file data.

Reported by:    feld
Reviewed by:    kp, glebius
Differential Revision:  https://reviews.freebsd.org/D58021
DeltaFile
+145-0tests/sys/netpfil/pf/unmapped_mbuf.sh
+35-0sys/netpfil/pf/pf.c
+2-1tests/sys/netpfil/pf/Makefile
+182-13 files

FreeBSD/src 2039fe8tests/sys/common sendfile_helper.c

tests/sendfile_helper: support remote connection

In order to use the sendfile_helper program in a pf test script that
requires non-loopback interfaces, add functionality to sendfile with a
TCP socket that is connected to a remote host.
The behavior for unix sockets and TCP loopback sockets is unchanged.

Reviewed by:    glebius
Differential Revision:  https://reviews.freebsd.org/D58041
DeltaFile
+64-6tests/sys/common/sendfile_helper.c
+64-61 files

FreeBSD/src 6a5ba65. ObsoleteFiles.inc, tests/sys/common sendfile_helper.c Makefile

tests/sendfile: move the helper program to common

In order to reuse the sendfile_helper program in pf tests, move it
to tests/sys/common directory, indicatint that it is also used from
another places than sys/kern.
Also make the readlen variable static.

Reviewed by:    gelbius, kp
Differential Revision:  https://reviews.freebsd.org/D58040
DeltaFile
+177-0tests/sys/common/sendfile_helper.c
+0-177tests/sys/kern/sendfile_helper.c
+4-0tests/sys/common/Makefile
+3-0ObsoleteFiles.inc
+0-2tests/sys/kern/Makefile
+1-1tests/sys/kern/sendfile_test.sh
+185-1806 files

FreeBSD/src a2426d1lib/libsys pdfork.2

pdfork.2: grammar

Submitted by:   des
MFC after:      1 week
DeltaFile
+2-2lib/libsys/pdfork.2
+2-21 files

FreeBSD/src 4e0fc4dsys/dev/firewire fwcam.c

fwcam: set ISO speed from device link speed

iso_speed was never initialized, defaulting to S100 regardless of the
camera's actual link speed. Some cameras firmwares reject ISO_EN
when the speed field in the ISO_CHANNEL register
does not match their capabilities.

Reviewed by:    adrian
Differential Revision:  https://reviews.freebsd.org/D58091
DeltaFile
+1-0sys/dev/firewire/fwcam.c
+1-01 files

FreeBSD/src 84044a7sys/dev/firewire fwcam.c fwcam.h

fwcam: write video mode registers before enabling ISO streaming

The IIDC spec (s3.1) requires the video mode to be programmed before ISO
enable. Without this, cameras that power up with invalid default
mode/rate combinations reject the ISO_EN write.

This can happen when the firmware of teh camera is outdated or
vendor never updated it.

Differential Revision:  https://reviews.freebsd.org/D58092
DeltaFile
+37-3sys/dev/firewire/fwcam.c
+7-0sys/dev/firewire/fwcam.h
+44-32 files

FreeBSD/src 94f24c0sys/dev/firewire fwcam.h fwcam.c, usr.sbin Makefile

fwcamctl: add control utility for fwcam(4) IIDC FireWire cameras

fwcamctl provides userland access to /dev/fwcam0.  Supported
subcommands: info (camera state, format, mode, rate, features),
snap (capture a frame as PPM), mode (set format/mode/rate), and
feat (get/set camera feature registers).

snap converts YUV422, YUV411, YUV444, RGB8, and Mono8 pixel
formats to RGB24 PPM with no external dependencies.  A configurable
frame skip (default 5) allows auto-exposure and auto-white-balance
to settle before capture.

(from adrian - yes, I've successfully captured images from an
Apple isight camera on firewire with this tool and in-tree support.)

Reviewed by:    adrian
Differential Revision:  https://reviews.freebsd.org/D57914
DeltaFile
+450-0usr.sbin/fwcamctl/fwcamctl.c
+156-0usr.sbin/fwcamctl/fwcamctl.8
+64-0sys/dev/firewire/fwcam.h
+0-21sys/dev/firewire/fwcam.c
+9-0usr.sbin/fwcamctl/Makefile
+1-0usr.sbin/Makefile
+680-216 files

FreeBSD/src 4b3d035sys/dev/firewire fwohci.c fwohcivar.h

fwohci: fix LPS delay, PHY_INT storm, and SID timeout recovery

Fixed the post-LPS delay from 500us to the IEEE 1394a-2000 s6.1 mandated
10ms ceiling. Handled PHY_INT by clearing W1C status bits in register 5
(masked ISBR to avoid spurious bus resets). Added a SID timeout callout
that recovers the state machine when a remote device fails to complete
self-ID. Fixed FW_PHY_SPD operator precedence and gated noisy messages
behind bootverbose/firewire_debug.

Reviewed by:    adrian
Differential Revision:  https://reviews.freebsd.org/D58033
DeltaFile
+51-8sys/dev/firewire/fwohci.c
+3-0sys/dev/firewire/fwohcivar.h
+54-82 files

FreeBSD/src f4825e9sys/dev/firewire fwcam.c fwcam.h

fwcam: add dynamic resolution and frame rate support

Read V_MODE_INQ and V_RATE_INQ registers for all supported formats
during probe, caching the camera's actual capabilities.  Use these
to validate SMODE ioctl requests before writing to the camera.

Writing an unsupported combination caused the camera to
stop responding, requiring a physical power cycle.

Tested with: Apple iSight (external FireWire)

Reviewed by:    adrian
Differential Revision:  https://reviews.freebsd.org/D58090
DeltaFile
+30-3sys/dev/firewire/fwcam.c
+2-0sys/dev/firewire/fwcam.h
+32-32 files

FreeBSD/src 3eb80d8sys/ufs/ffs ffs_vfsops.c ffs_subr.c

ufs: Allow read-only mounting of NetBSD FFSv2 WAPBL filesystems

Skip UFS2 fs_metaspace upper-bound validation that rejects NetBSD FFSv2
WAPBL filesystems due to differing superblock layouts.

Detect the condition during mount instead and permit read-only mounts
while rejecting read-write mounts with EROFS.  This follows NetBSD's
recommendation for systems without WAPBL support and avoids modifying
unsupported journal metadata.

PR: 296022
Signed-off-by: Ricardo Branco <rbranco at suse.de>
Reviewed by: imp, kirk
Pull Request: https://github.com/freebsd/freebsd-src/pull/2279
DeltaFile
+27-0sys/ufs/ffs/ffs_vfsops.c
+13-1sys/ufs/ffs/ffs_subr.c
+40-12 files

FreeBSD/src f723b28sbin/reboot reboot.c

reboot: fix openlog(3) calls

LOG_CONS was OR'd into the facility argument instead of logopt, leaving
logopt as 0.  The correct call is openlog(ident, LOG_CONS, LOG_AUTH),
as shutdown(8) and init(8) already do.

PR:     296315
Signed-off-by: Ricardo Branco <rbranco at suse.de>
Reviewed by: imp, des
Pull Request: https://github.com/freebsd/freebsd-src/pull/2300
DeltaFile
+5-5sbin/reboot/reboot.c
+5-51 files

FreeBSD/src f5329a0sys/kern imgact_elf.c kern_exec.c, sys/sys imgact.h

kern: imgact: fix imgp->interpreted

This is a mask, so the new value should have taken the next bit to avoid
breaking a shell script that's interpreted by a binmisc-activated
interpreter.

Add a brief note that the new value is only used within the ELF
activator.

Fixes:  389c124fecb0 ("imgact_elf.c indicate that interpreter [...]")
Reported by:    "polyduekes" on discord, madpilot
Reviewed by:    kib, sjg (both previous version)
Differential Revision:  https://reviews.freebsd.org/D58063
DeltaFile
+2-2sys/kern/imgact_elf.c
+1-2sys/kern/kern_exec.c
+1-1sys/sys/imgact.h
+4-53 files

FreeBSD/src 407c7c3sys/compat/linux linux_futex.c

linux/futex: Don't load a timeout when try-locking a mutex

linux_sys_futex() does not copyin a timespec for the timeout if the
operation is LINUX_FUTEX_TRYLOCK_PI, presumably because it doesn't make
sense to specify a timeout for a try-lock operation.  However, this
means that we pass a userspace timespec pointer to
linux_umtx_abs_timeout_init().

Modify linux_futex_lock_pi() to not initialize the timeout if we're
try-locking.

Reviewed by:    kib, dchagin
Reported by:    Yuxiang Yang, Yizhou Zhao, Ao Wang, Xuewei Feng, Qi Li,
                and Ke Xu from Tsinghua University using GLM-5.2 from Z.ai
MFC after:      1 week
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D58061
DeltaFile
+8-5sys/compat/linux/linux_futex.c
+8-51 files

FreeBSD/src 23e94b0tests/sys/kern procdesc.c

pddupfd(2): add basic test

Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D57163
DeltaFile
+74-0tests/sys/kern/procdesc.c
+74-01 files

FreeBSD/src f87f97dsys/kern sys_process.c

kern/sys_process.c: clean up includes

Order them alphabetically.
Remove redundand sys/param.h.

Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
DeltaFile
+9-10sys/kern/sys_process.c
+9-101 files

FreeBSD/src 2a41a8flib/libsys Symbol.sys.map, sys/sys procdesc.h

libsys: export pddupfd(2)

Reviewed by:    markj
Tested by:      pho
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D57163
DeltaFile
+1-0lib/libsys/Symbol.sys.map
+1-0sys/sys/procdesc.h
+2-02 files

FreeBSD/src c20558elib/libsys pdfork.2 Makefile.sys

pdfork.2: document pddupfd()

Reviewed by:    markj
Tested by:      pho
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D57163
DeltaFile
+53-4lib/libsys/pdfork.2
+2-1lib/libsys/Makefile.sys
+55-52 files

FreeBSD/src 1ad21a6sys/kern sys_procdesc.c kern_descrip.c

kern: add pddupfd(2)

Reviewed by:    markj
Tested by:      pho
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D57163
DeltaFile
+82-0sys/kern/sys_procdesc.c
+6-2sys/kern/kern_descrip.c
+7-0sys/kern/syscalls.master
+95-23 files

FreeBSD/src 080a7fesys/compat/freebsd32 freebsd32_systrace_args.c freebsd32_syscall.h, sys/kern systrace_args.c

Regen.
DeltaFile
+30-0sys/compat/freebsd32/freebsd32_systrace_args.c
+30-0sys/kern/systrace_args.c
+7-0sys/sys/sysproto.h
+2-1sys/sys/syscall.h
+2-1sys/compat/freebsd32/freebsd32_syscall.h
+2-1sys/sys/syscall.mk
+73-36 files not shown
+81-312 files

FreeBSD/src 046a4efsys/kern subr_capability.c, sys/sys capsicum.h caprights.h

Add CAP_PDDUPFD capability

Reviewed by:    markj
Tested by:      pho
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D57163
DeltaFile
+4-2sys/sys/capsicum.h
+1-0sys/sys/caprights.h
+1-0sys/kern/subr_capability.c
+6-23 files