OpenBSD/src 1IrouM8bin/ed io.c

   Be precise in checking for errors. pclose(3) returns -1 and fclose(3)
   EOF in case of errors, not any negative number.
   EOF corner case spotted while reviewing a much bigger diff by deraadt

   OK deraadt, millert
VersionDeltaFile
1.23+3-3bin/ed/io.c
+3-31 files

OpenBSD/src LNdVd4Nusr.bin/ssh sshkey.c

   fix NULL deference (bzero) on error path added in last commit;
   spotted by Reynir Björnsson

   ok deraadt@ markus@ tb@
VersionDeltaFile
1.78+2-2usr.bin/ssh/sshkey.c
+2-21 files

OpenBSD/src XxolBZ1lib/libc/asr gethostnamadr_async.c

   If we don't receive a reply packet the res_send subquery will already have
   set subq_h_errno and ar_count. Remove the ar_datalen == -1 check, so we
   set ar_h_errno and don't have to (wrongly) guess that
   ar_h_errno = HOST_NOT_FOUND.

   This makes sure that if no nameserver responds the h_errno value is set to
   TRY_AGAIN instead of HOST_NOT_FOUND.

   OK eric@, deraadt@
VersionDeltaFile
1.45+5-7lib/libc/asr/gethostnamadr_async.c
+5-71 files

OpenBSD/src Lw8fDOJusr.sbin/smtpd smtpd.c lka_proc.c

   Allow filters to log information through stderr. This simplifies and
   unifies the way filters need to get their logging to the right location.

   Log-messages are read line by line and are logged at LOG_ERR level via
   the lookup process.

   OK gilles@

OpenBSD/src t5Ph2sVregress/lib/libcrypto/base64 base64test.c

   check for asprintf failing allocation

OpenBSD/src O0Tzz2Hlib/libc/stdio printf.3

   an -> a;
VersionDeltaFile
1.81+3-3lib/libc/stdio/printf.3
+3-31 files

OpenBSD/src fIvCweLusr.bin/ssh clientloop.c

   Remove unneeded unlink of xauthfile on error path.  From Erik Sjölund via
   github, ok djm@ deraadt@
VersionDeltaFile
1.325+1-2usr.bin/ssh/clientloop.c
+1-21 files

OpenBSD/src 7fufR2Zlib/libc/stdio printf.3

   The POSIX-compatible way of checking for {v,}{f,s,sn,d}printf(3)
   failure is with < 0, not the more specific -1 from C
   discussed at length with millert, nicm, schwarze
VersionDeltaFile
1.80+5-4lib/libc/stdio/printf.3
+5-41 files

OpenBSD/src sSlnFXmsys/dev/pci if_iwm.c

   Use timeout_add_msec(9)

   To initiate LED blinking, simply kick of the timer after the blinking
   rate's period rather than one tick to get red of the last hardclock(9)
   based timeout in this driver.  The now increased delay is compensated by
   also turning on the LED immediately.

   OK stsp
VersionDeltaFile
1.242+6-3sys/dev/pci/if_iwm.c
+6-31 files

OpenBSD/src sDHvoJfusr.bin/tmux layout.c window.c

   Fix a typo in window_pane_find_down (w not wp) and a missing PANE_STATUS_TOP.
VersionDeltaFile
1.45+3-3usr.bin/tmux/layout.c
1.239+2-2usr.bin/tmux/window.c
+5-52 files

OpenBSD/src N54ytyJusr.bin/tmux server-client.c cmd-display-panes.c

   Pass keys that aren't 0-9 on to normal key processing when display-panes
   is active (restores previous behaviour).

OpenBSD/src B4L4eNGsys/kern kern_pledge.c

   allow more video(4) ioctls for the video pledge (required by chromium)

   ok deraadt@
VersionDeltaFile
1.254+14-1sys/kern/kern_pledge.c
+14-11 files

OpenBSD/src zn492Lxusr.bin/mg log.c log.h

   Add some key and map logging.
VersionDeltaFile
1.9+81-3usr.bin/mg/log.c
1.4+3-3usr.bin/mg/log.h
1.32+2-2usr.bin/mg/kbd.c
+86-83 files

OpenBSD/src BCavELVusr.bin/mg dired.c

   This diff uses the existing filename as the new filename if none is
   specified while copying in dired mode.
VersionDeltaFile
1.86+14-1usr.bin/mg/dired.c
+14-11 files

OpenBSD/src axPfK9busr.bin/mg match.c funmap.c

   This diff makes blink-and-insert do as the man page says it should do.
   If you do 'M-x blink-and-insert', you are asked for a character. mg
   will then insert it at the current cursor position and then search
   backwards for a corresponding match.
VersionDeltaFile
1.20+24-3usr.bin/mg/match.c
1.56+2-2usr.bin/mg/funmap.c
1.160+2-1usr.bin/mg/def.h
+28-63 files

OpenBSD/src 6hiZPtJgnu/llvm/tools/clang/lib/Driver/ToolChains Gnu.cpp

   In LLVM 8 somebody had the glorious idea to enable the integrated assembler
   for OpenBSD sparc64. The problem is that the integrated assembler is not
   even able to compile the .S files in lib/csu or lib/libc so revert this
   and use gas again. Fixes build issues with clang on sparc64.
   Issue identified by jca@
   OK deraadt@, patrick@, jca@

OpenBSD/src 693Rg9Ksys/arch/sparc64/fpu fpu_explode.c

   Fix sign handling in emulated FP operations on sparc64

   Adapted from FreeBSD revision 146673 by Stephen Paskaluk and
   stefanf at FreeBSD.

   ok deraadt@

OpenBSD/src a6RKhblsys/kern kern_descrip.c

   Return EINVAL, not EBADF for fcntl(fd, F_GETLK) of a non-vnode.
   Matches the recent F_SETLK change, POSIX and the man page.
VersionDeltaFile
1.187+2-2sys/kern/kern_descrip.c
+2-21 files

OpenBSD/src MmmDn2yusr.bin/tmux window.c

   Log window and pane resizes.
VersionDeltaFile
1.238+3-1usr.bin/tmux/window.c
+3-11 files

OpenBSD/src VJ72o96usr.bin/tmux tty.c

   Fix some comments (top/bottom not left/right).
VersionDeltaFile
1.327+4-4usr.bin/tmux/tty.c
+4-41 files

OpenBSD/src jjUGCfYusr.bin/tmux window.c layout.c

   Add #define for the pane status line option position numbers.

OpenBSD/src bjtSex9usr.sbin/relayd relay.c relayd.c

   Add support for OCSP stapling

   Many thanks to Bruno Flueckiger who independently sent a very similar
   patch.  He also tested the one I'm committing that it works as
   expected.

   OK tb@

OpenBSD/src bHoch9rsys/dev/usb if_umb.c, sys/net if_var.h

   Create IF_WWAN_DEFAULT_PRIORITY which is lower than
   IF_WIRELESS_DEFAULT_PRIORITY and use it in umb(4) as default prio.
   OK kettenis@, sthen@
VersionDeltaFile
1.23+2-1sys/dev/usb/if_umb.c
1.100+2-1sys/net/if_var.h
+4-22 files

OpenBSD/src dWPpVjZsys/dev/pci/drm drm_mode_config.c

   Fix IPL of connector_list_lock.

   ok jsg@
VersionDeltaFile
1.2+1-1sys/dev/pci/drm/drm_mode_config.c
+1-11 files

OpenBSD/src iqF9zRDusr.sbin/smtpd smtp_session.c

   reject DATA containing <CR> that's not part of <CRLF> line terminators
   as they are not allowed by RFC, have never been generated by a regular
   MUA/MTA and can cause issues with some filters if we let them through.

   ok jung@ on an earlier version of the diff, eric@ suggested the new diff
VersionDeltaFile
1.392+10-1usr.sbin/smtpd/smtp_session.c
+10-11 files

OpenBSD/src FudwU66sys/net if_mpe.c if_mpip.c

   The MPLS edge devices get the packets from the MPLS stack which never
   passed though pf_test(). So there is no need to try to call
   pf_pkt_addr_changed() instead just check that the PF statekey is NULL.
   Initial problem of not including pf.h found by jsg@
   OK jsg@ sashan@
VersionDeltaFile
1.94+3-4sys/net/if_mpe.c
1.8+3-4sys/net/if_mpip.c
1.55+3-4sys/net/if_mpw.c
+9-123 files

OpenBSD/src LAil3plsys/arch/sparc64/dev iommu.c pyro.c, sys/arch/sparc64/include pci_machdep.h

   add support for bypassing iommu translation

   managing the translation table entries (TTEs) on an iommu is not
   free, and is in fact extremely expensive on some platforms. the
   flip side of this is that forcing dma through TTEs does provide
   some safety and can help during the development of drivers. however,
   this has been less true in recent years than it used to be and is
   less of a concern now, especially considering the performance
   differences on some platforms.

   devices have to create dmamaps with BUS_DMA_64BIT to bypass the
   iommu because the memory window presented to hardware with direct
   access to memory is at an extremely high address. there's no 32bit
   bypass access to memory, it has to go through TTEs otherwise.

   on an m4000 there are several orders of magnitude performance
   difference between a driver with BUS_DMA_64BIT set and one without
   it.

   hilariously, sun used a pci bridge on a whole generation of machines
   that had broken support for dma addresses over 40 bits (or around
   there), so devices behind those pci bridges need to have their
   dmamap_creates intercepted and any potential BUS_DMA_64BIT flags
   cleared on the way to the iommu drivers. this affects at least v215,
   v245, and v445, and probably u25s and u45s. it probably explains

    [5 lines not shown]

OpenBSD/src GQsOtWqusr.sbin/bgpd mrt.c

   ibuf_write() returns -1 on error.
   ok claudio@
VersionDeltaFile
1.97+2-2usr.sbin/bgpd/mrt.c
+2-21 files

OpenBSD/src 3rGVOqWusr.sbin/bgpd pfkey.c

   cleanup return code checks for the pfkey_*() functions.
   ok claudio@
VersionDeltaFile
1.58+31-31usr.sbin/bgpd/pfkey.c
+31-311 files

OpenBSD/src aSJYswhlib/libc/sys flock.2

   Use the same text for EOPNOTSUPP as we do in fcntl(2) and lockf(3).
   In fcntl(2) and lockf(3) the error is EINVAL but the condition is
   the same.  OK anton@
VersionDeltaFile
1.21+5-3lib/libc/sys/flock.2
+5-31 files

OpenBSD/src 6yry3wDdistrib/sets/lists/man mi

   sync
VersionDeltaFile
1.1508+1-0distrib/sets/lists/man/mi
+1-01 files

OpenBSD/src ve4Qx4clib/libc/locale newlocale.3

   POSIX.1-2008 TC3 is going to clarify how newlocale(3) uses oldloc.
   Explicitly state that our implementation now complies with the
   stricter requirements of TC3 because the newlocale(3) in old OpenBSD
   releases only complied with the weaker requirements of the old text
   of the standard.  The complaints from our users resulted in both
   our implementation and the standard being improved.
   For details, see: http://austingroupbugs.net/view.php?id=1243#c4347
VersionDeltaFile
1.3+4-3lib/libc/locale/newlocale.3
+4-31 files

OpenBSD/src oMHakkVsys/arch/amd64/include pci_machdep.h, sys/arch/amd64/pci pci_machdep.c

   Implement suspend/resume support for MSI-X interrupts.  Loosely based on
   an earlier diff from sf@.

   ok jmatthew@, also ok mlarkin@, sf@ for a slightly different earlier version

OpenBSD/src 31KbN8ksys/kern kern_descrip.c

   Return EINVAL not EBADF when trying to lock a non-vnode.
   This behavior matches POSIX and our own fnctl(2) man page.
   OK anton@ deraadt@
VersionDeltaFile
1.186+2-2sys/kern/kern_descrip.c
+2-21 files

OpenBSD/src F2af41Bsys/dev/ic ahci.c

   Turn off the code which waits for AHCI_PREG_CMD_CR to be set by the
   HBA after ahci_default_port_start() sets AHCI_PREG_CMD_ST. The AHCI
   spec. rev. 1.3 only requires the inverse to be true, i. e. that a
   HBA clears AHCI_PREG_CMD_CR when AHCI_PREG_CMD_ST gets cleared by
   software/driver. In fact, some HBAs will not raise AHCI_PREG_CMD_CR
   as an immediate consequence of AHCI_PREG_CMD_ST being set. Actually
   neither the FreeBSD, Linux nor NetBSD counterpart of ahci(4) has an
   analogous check. Disabling that wait fixes "failed to start command
   DMA on port N, disabling" bails during attach.

   From Marius Strobl
   ok deraadt@ jmatthew@
VersionDeltaFile
1.33+1-6sys/dev/ic/ahci.c
+1-61 files

OpenBSD/src ORYQh1Nsys/sys sysctl.h

   move new element p_pledge to the tailof kinfo_proc to increase
   backwards-compat handling.
   pointed out by sthen, ok millert
VersionDeltaFile
1.192+3-2sys/sys/sysctl.h
+3-21 files

OpenBSD/src FrTFRtVusr.bin/mg dired.c

   Add 'dired-revert' to the dired funmap, the 'g' command already works
   but I missed adding the command name.  Also, list the commands in
   alphabetical order.
VersionDeltaFile
1.85+4-3usr.bin/mg/dired.c
+4-31 files

OpenBSD/src R1LU6o1sys/dev/usb ukspan.c

   avoid uninitialised var access

   Cody Cutler author of ukspan(4) agrees
   ok deraadt@
VersionDeltaFile
1.2+1-1sys/dev/usb/ukspan.c
+1-11 files

OpenBSD/src 7NvI8Xbusr.sbin/bgpd rde.c

   Initialize the peer id of peerself to PEER_ID_SELF before adding it to
   peer table. Fixes an endless loop of peer_down errors on shutdown.
VersionDeltaFile
1.474+2-1usr.sbin/bgpd/rde.c
+2-11 files

OpenBSD/src sk7nIn0usr.sbin/bgpctl parser.c bgpctl.8

   Remove irrfilter from bgpctl. The current code is not very useful.
   Trying to parse RPSL has shown to be impossible. For now tools like
   bgpq3 (in ports) can be used to generate AS and prefix sets based on
   IRR data.
   OK job@ deraadt@ sthen@ benno@

OpenBSD/src KJA3Ucjsys/net route.c

   Since the recent recursion fix in rtable_walk(), deleting an interface
   address could trigger the "rt->rt_ifidx == ifp->if_index" assertion.
   In rtflushclone() the ifp that is passed to rtdeletemsg() has been
   changed from the route interface to the ifa interface.  Restore the
   old behavior and get the route ifp.
   found by regress/sys/netinet/carp; OK mpi@
VersionDeltaFile
1.387+13-6sys/net/route.c
+13-61 files

OpenBSD/src v9uqtJNsys/net if_spppsubr.c if_sppp.h

   Use timeout_add_sec(9)

   Re-challenge timeouts are made up of single scalar factors which are
   multiplied with the time unit lcp.timeout to compute the timeout period.

   Simply reduce that unit of 1 * hz [ticks] to 1 [s] and use the appropiate
   API.

   OK mpi
VersionDeltaFile
1.179+4-4sys/net/if_spppsubr.c
1.27+2-2sys/net/if_sppp.h
+6-62 files

OpenBSD/src orwFJczshare/man/man4 glkgpio.4 acpi.4, sys/arch/amd64/conf GENERIC

   Add glkgpio(4), a driver for the GPIO controllers found on Intel's Gemini
   Lake SoC.  From James Hastings.

OpenBSD/src xciVMbplib/libc/sys getitimer.2

   add missing RETURN VALUES section;
   also checked that POSIX requires exactly this behaviour
VersionDeltaFile
1.33+4-2lib/libc/sys/getitimer.2
+4-21 files

OpenBSD/src 8a1frThshare/man/man1 portgen.1

   The PyPI module for portgen is very useful now, so we should mention it
   in the portgen(1) man page.

   ok afresh1@ phessler@
VersionDeltaFile
1.2+4-2share/man/man1/portgen.1
+4-21 files

OpenBSD/src YLaslrrregress/usr.bin/openssl appstest.sh

   Add more options test to ocsp in appstest.sh
VersionDeltaFile
1.21+30-7regress/usr.bin/openssl/appstest.sh
+30-71 files

OpenBSD/src eio0Qerusr.sbin/smtpd mta_session.c

   rename wait queues
VersionDeltaFile
1.118+9-9usr.sbin/smtpd/mta_session.c
+9-91 files

OpenBSD/src IANlqg6bin/ksh ksh.1

   Fix spelling
VersionDeltaFile
1.207+3-3bin/ksh/ksh.1
+3-31 files

OpenBSD/src NEDXEvJusr.bin/mg buffer.c

   switch-to-buffer (C-x b) doesn't cancel properly if C-g is pressed.
   It doesn't show 'Quit'. By returning ABORT, it behaves as expected
   when C-g is pressed (like all other functions that use the
   minibuffer).
VersionDeltaFile
1.107+2-2usr.bin/mg/buffer.c
+2-21 files

OpenBSD/src vSGDeQ6usr.bin/doas doas.conf.5

   add an example hint that shows how original path can be retained
VersionDeltaFile
1.40+5-4usr.bin/doas/doas.conf.5
+5-41 files