Anchor mount path in wxallowed fallback logic to avoid substring match
Otherwise /portsroot/usr/local gets the option set although it should
only be set on the filesystem containing /usr/local.
from Crystal Kolipe
OK halex
Stop initalizing the return pointer in the various proc_parser_mft functions.
Instead add the missing crlfile initalization at the top of proc_parser_mft.
There is a maze of pointers that are passed around here and those extra
assignments don't make the code easier to read.
OK tb@
Implement a different fix for the use-after-free in filt_procattach
from rev 1.207.
Instead of shuffling locks around take a process reference in this
code to prevent the process from exiting under us while sleeping
for the kqueue_ps_list_lock rwlock. This is the same solution that
was used for a similar issue in fork1.
Reported by Acts1631 and OpenAI
Patch provided by OpenAI
from claudio@; OK mvs@
this is errata/8.0/022_kqueue.patch.sig
Implement a different fix for the use-after-free in filt_procattach
from rev 1.207.
Instead of shuffling locks around take a process reference in this
code to prevent the process from exiting under us while sleeping
for the kqueue_ps_list_lock rwlock. This is the same solution that
was used for a similar issue in fork1.
Reported by Acts1631 and OpenAI
Patch provided by OpenAI
from claudio@; OK mvs@
this is errata/7.9/057_kqueue.patch.sig
Do not allow TIOCSCTTY, TIOCNOTTY, or TIOCSPGRP on the pty master. Return
ENOTTY for all 3 of these. They could create incoherent session states,
leading to dangerous UAF reported by openai (unfortunately their proposed
patch was batshit crazy and made the situation worse, due to not identifying
this as root cause, and writing code to support the condition).
from deraadt@ with claudio@ various versions; OK kettenis@ kirill@ and others
this is errata/8.0/021_pty.patch.sig
Do not allow TIOCSCTTY, TIOCNOTTY, or TIOCSPGRP on the pty master. Return
ENOTTY for all 3 of these. They could create incoherent session states,
leading to dangerous UAF reported by openai (unfortunately their proposed
patch was batshit crazy and made the situation worse, due to not identifying
this as root cause, and writing code to support the condition).
from deraadt@ with claudio@ various versions; OK kettenis@ kirill@ and others
this is errata/7.9/056_pty.patch.sig
libcrypto: fix a long-standing quirk in CCM mode
For some reason it was decided that in CCM mode the caller should not be
allowed to set the tag length before setting the tag, which is the natural
order. This required various contortions in downstream, at least in Ruby
and rust-openssl.
This pulls in 9cca7be1 (before license change) and makes a trivial change
functionally equivalent to (but different from) 67c81ec3 from OpenSSL.
From William T. Nelson
libcrypto: add missing AEAD flag to AES-CCM
The AES-CCM ciphers aren't marked as AEAD ciphers, so openssl enc allows
them even though it shouldn't. OpenSSL has set the flag since adding CCM
support to libssl in e75c5a79.
From William T. Nelson
rpki-client: handle {0} ASPAs up front
The semantics of merging mean that merging {0} into an already existing
CAS does nothing, so if aspa->providers[] is the set {0}, we can return
early. If v->providers[] is the set {0}, drop the 0 and adjust counters
then copy aspa->providers[] into it.
This approach would have worked before, but it's now a bit easier to see
why it works.
ok claudio
rpki-client: rework aspa_insert_vaps()
The merge loop in aspa_insert_vaps() is too smart and has tripped us all up
repeatedly. While it won't matter much due to size constraints, its worst
case is O(n*m), which isn't great.
Let's make this easier to follow and reason about. A linear sweep merges
and deduplicates the two arrays question until one of them is consumed,
then fill in the tail of the one that remains non-empty. Both arrays are
strictly monotonic, and this property is clearly preserved by the new
approach.
The other bit that is obvious is that the merge loop is O(n + m). The price
we pay is a bit more code and an extra allocation.
ok claudio job
In tlv_decode_fec_elm add missing initial len and prefixlen check
Ensure that fec_elm have at least the one byte needed for the type
and also check that the encoded prefixlen actually matches with the
address family.
Reported by Yang Hailong
OK deraadt@ tb@
rpki-client: fix merging of ASPA objects
Prompted by a question by Yangyang WANG, draft-ietf-sidrops-aspa-profile-29
added new wording regarding 0 handling when merging two ASPAs with the same
customer ASID and clarified that 0 should be discarded:
https://mailarchive.ietf.org/arch/msg/sidrops/TToTScyLiVXdyJzf-kgzv5XMy3U/
Implement this and adjust the accounting when dropping the 0.
Found by job because this case now appears in the wild.
ok claudio