BSD Commit Log Search

[AArch64][CodeGen] match (or x (not y)) to generate mov+orn (#191145)

Fixes: #100045

Adds a tablegen pattern that matches (or x (not y)) and generates a
mov+orn instead of the original mvn+orr.

The number of instructions still stay the same but mov+orn can be
considered better than mvn+orr for two reasons:
1. Symmetry: For the same input with an 'and' instead of 'or', mov+bic
is generated.
2. Optimzation through register rename: If mov is immediate (for
example, 'mov x1, #0x4'), it can be retired early by the register
renamer and never issued for execution.

This patch was reverted as I wanted to change my email associated with
the patch.

Original patch: #190769

    [2 lines not shown]

refactor: update variable names in uniformity analysis

[LV] NFCI: Create VPExpressions in transformToPartialReductions.

With this change, all logic to generate partial reductions and
recognising them as VPExpressions is contained in
`transformToPartialReductions`, without the need for a second
transform pass.
The PR intends to be a non-functional change.

[CIR][Aarch64] upstream scalar & vector intrinsics (FP16) (#190310)

This PR upstreams the following fp16 intrinsics as part of #185382:

- vaddh_f16, 
- vsubh_f16, 
- vmulh_f16, 
- vdivh_f16

This is my first PR to LLVM, so any feedback is greatly appreciated!

[clang][CIR] Add lowering for vcvt_n_ and vcvtq_n_ conversion intrinsics

This PR adds lowering for the conversion intrinsics with an immediate
argument (identified by `_n_` in the intrinsic name), excluding FP16
variants.

It also moves the corresponding tests from:
  * clang/test/CodeGen/AArch64/neon_intrinsics.c

to:
  * clang/test/CodeGen/AArch64/neon/intrinsics.c

The lowering follows the existing implementation in
CodeGen/TargetBuiltins/ARM.cpp and adds the `getFloatNeonType` helper
to support it. The remaining changes are code motion and refactoring.

Reference:
[1] https://arm-software.github.io/acle/neon_intrinsics/advsimd.html#conversions

Revert "[mlir][CSE] Delete dead code immediately in CSE pass" (#191146)

Reverts llvm/llvm-project#190926 ; this is crashing on simple examples
like:

```
func.func @test(%arg0: i1) {
  %c0_i32 = arith.constant 0 : i32
  %0 = arith.select %arg0, %c0_i32, %c0_i32 : i32
  %1 = scf.if %arg0 -> (i32) {
    %c0_i32_0 = arith.constant 0 : i32
    scf.yield %c0_i32_0 : i32
  } else {
    %c0_i32_0 = arith.constant 0 : i32
    scf.yield %c0_i32_0 : i32
  }
  return
}
```

[lldb] Handle simulator printout in TestSimulatorPlatform (#189571)

This test invokes a binary in a simulator and then reads the first line
of stderr to parse the PID of the invoked binary.

This approach fails when the simulator itself prints a warning/error on
startup. In this case, we try to parse the error as the PID and fail.

This patch just removes the line limit. It doesn't seem to add any value
as we anyway need to search until we find the PID line, and if there is
no PID line we cannot do anything but time out eventually.

See also rdar://169799464

[VPlan] Add ::getSingleVF() helper and use it (NFC). (#191055)

Suggested as follow-up during recent reviews, including
https://github.com/llvm/llvm-project/pull/190393.

[GlobalISel] Prevent hoisting of CheckIsSameOperand from creating invalid match tables (#190963)

Fixes #188513

This patch adds logic to ask PredicateMatchers whether they'd like to be
hoisted out of a specific Matcher or not.
SameOperandMatcher can use it to check if it's being hoisted out of the
RuleMatcher that defines the operand it relies on.

Assisted-By: Claude Opus 4.6
Context of Use: Claude was only used to add LLVM-style RTTI to the
matcher class (repetitive work). I then reviewed and cleaned up the code
it generated.

Revert "[mlir][CSE] Delete dead code immediately in CSE pass (#190926)"

This reverts commit f73f8754cabd4caf3c9989d8f542d2b9a9f85d07.

fix + better MLIR use

Created using spr 1.3.8-wip

[SeparateConstOffsetFromGEP] Fix incorrect inbounds flag in case of non-negative index but negative offset (#190192)

Fixes #190187 

Currently, SeparateConstOffsetFromGEP preserves inbounds attribute if
new sequence of GEPs from the same base pointer has non-negative offsets
in each GEP (this was mentioned in
https://github.com/llvm/llvm-project/pull/159515). This statement seems
correct for me (if the sequence consists from 2 GEPs), but current
implementation has a flaw: it checks that constant byte offset and GEP
indices are non-negative. However, in some corner cases we can have a
situation when the index is non-negative, but its offset (in bytes) is
negative, so we can't preserve inbounds attribute. In the example, GEP
index after transformation can have values
`0x7ffffffffffffffd`/`0x7ffffffffffffffe`/`0x7fffffffffffffff`; they are
all non-negative (sign bit is zero), however, after multiplication on
sizeof(i64) they become negative and inbounds can't be preserved
anymore.

The proposed fix is to check that Idx * ElementStride is non-negative
(instead of checking Idx only).

[analyzer] Canonicalize _Atomic pointers in makeNullWithType (#190131)

Fixes #187925

[GlobalISel] Add G_STEP_VECTOR to computeKnownBits. (#190598)

This code is adapted from SelectionDAG::computeKnownBits.
part of https://github.com/llvm/llvm-project/issues/150515.
ticks off STEP_VECTOR.

Revert "[AArch64][CodeGen] match (or x (not y)) to generate mov+orn" (#191138)

Reverts llvm/llvm-project#190769

[Need to change email for the commit]

[clang][docs] Improve documentation of [[ownership_returns]] attribute (#191005)

The 2 parameter use of this attribute wasn't documented.

This clarification is based of the following two commits:
 - https://github.com/llvm/llvm-project/commit/d21139a34f51
 - https://github.com/llvm/llvm-project/commit/893a303962608

[DA] Remove "FIXME" for a test that has been fixed

[InstCombine] Simplify `floor`/`ceil` to `trunc` for integral tests (#190620)

Partially fix https://github.com/llvm/llvm-project/issues/188035

Some proof checks:

`fcmp oeq ceil(x), x` -> `fcmp oeq trunc(x), x`
[Proof](https://alive2.llvm.org/ce/z/kLQeFQ)
`fcmp one floor(x), x` -> `fcmp one trunc(x), x`
[Proof](https://alive2.llvm.org/ce/z/vyVAUX)
`fcmp ueq ceil(x), x` -> `fcmp ueq trunc(x), x`
[Proof](https://alive2.llvm.org/ce/z/DbFMZb)
`fcmp une floor(x), x` -> `fcmp une trunc(x), x`
[Proof](https://alive2.llvm.org/ce/z/QVLQLw)

This may be useful for CSE (due to `trunc(x) == x` is quite common
integral test) or further simplifications specific to `trunc`. Also,
`trunc` is cheaper if it lowered to
[libm](https://git.musl-libc.org/cgit/musl/tree/src/math/trunc.c) /
[libc](https://github.com/llvm/llvm-project/blob/b4f50cfd4a3a086db3f88271c9595056a877ef90/libc/src/__support/FPUtil/NearestIntegerOperations.h#L25)
call

Revert "[AArch64][CodeGen] match (or x (not y)) to generate mov+orn (#190769)"

This reverts commit 42629d7a174a62b98835e2e4c738ccdce027590b.

[Polly] Remove pipeline-level Oz handling for LoopRotate (#191137)

This handling was moved fully into the pass in
1662c200a5b151ad15b7efc82837076d8967dc11. However, that changed
missed the usage of LoopRotate in polly.

[LLVM][GlobalISel] Implement G_STRICT_FCMP in IRTranslator (#190754)

- `G_STRICT_FCMP` and `G_STRICT_FCMPS` are constrained operations in
gMIR.

refactor: update variable names in uniformity analysis

[Flang][OpenMP] Data-sharing restrictions on assumed-size arrays (#189324)

Per `OpenMP 5.0 2.19.1 Data-Sharing Attribute Rules`, assumed-size
arrays are predetermined shared and may not appear in a data-sharing
clause besides `shared`.

Patch adds a semantics check for assumed-size arrays appearing in
clauses where they aren't allowed.

[clang-tidy] Fix false positive in readability-non-const-parameter with dependent array subscripts (#190936)

Fixes #60163

---------

Co-authored-by: Zeyi Xu <zeyi2 at nekoarch.cc>

refactor: update variable names in uniformity analysis

[orc-rt] Move RedundantAsyncShutdown to SessionTest suite. NFCI. (#191130)

RedundantAsyncShutdown is a Session test, not a ControllerAccess test.

[UniformityAnalysis] Skip CycleAnalysis on targets without branch divergence (#189948)

UniformityAnalysis unconditionally computes CycleAnalysis even on
targets that don't care about divergence, causing measurable
compile-time overhead (see [#99878
(comment)](https://github.com/llvm/llvm-project/pull/175167#issuecomment-4156230947)).

---------

Co-authored-by: padivedi <padivedi at amd.com>

Fix Clang+MLIR

Created using spr 1.3.8-wip

[orc-rt] Remove Session::waitForShutdown. (#191124)

The existing implementation triggered Session shutdown and then blocked
on a std::future that would be unblocked by an on-shutdown callback that
waitForShutdown had installed. Since there is no guarantee that this
callback would be the last one run, the result was that waitForShutdown
only guaranteed that it would not return until the shutdown sequence had
started (rather than completed).

This could have been fixed, but the Session destructor is already
supposed to block until the Session can be safely destroyed, so a
"working" waitForShutdown would be effectively redundant. Since it was
also a potential footgun (calling it from an on-detach or on-shutdown
callback could deadlock) it was safer to just remove it entirely.

Some Session unit tests do rely on testing properties of the Session
after the shutdown sequence has started, so a new utility has been added
to SessionTests.cpp to support this.

update temp file name in test