[ARM] Replace reg in preheader when reverting WhileLoopStartLR (#229754)
As we revert a wls loop to a dls loop, we remove the t2WhileLoopStartLR
to a t2DoLoopStart at the start of the preheader. In finding the
t2WhileLoopStartLR we might have looked through a copy that is still
using the t2WhileLoopStartLR def. Make sure we replace the use with the
Src to remain valid.
Fixes #229400
[IR] Remove unused GEPOperator::countNonConstantIndices (NFC) (#235233)
The last callers of GEPOperator::countNonConstantIndices were removed
on April 26, 2024 in commit cbe1760f02882328c91e5764648f97fe644f44c9.
Assisted-by: Antigravity
[clang] Replace PointerUnion::dyn_cast with llvm::dyn_cast (NFC) (#235232)
PointerUnion::dyn_cast has been soft-deprecated in favor of
llvm::dyn_cast and llvm::dyn_cast_if_present. This patch replaces
PointerUnion::dyn_cast with llvm::dyn_cast at 17 call sites across 11
files under clang/.
All tests in check-clang pass with these changes, and LLM-based static
analysis of the surrounding data structures and call sites confirms that
the PointerUnion operand at each site is nonnull either by construction
or because callers ensure it is nonnull before reaching llvm::dyn_cast.
Assisted-by: Antigravity
Revert "[SelectionDAG] Implement SDTCisSameAs in verifyNode." (#235329)
M68k is failing on the bots. I'll need to fix it or waive the broken
node, but I need time to investigate.
Reverts #235157
[TLI][SimplifyLibCalls] Accept [2 x iN] return type for __size_returing_new (#234856)
On AArch64 (AAPCS64), Clang lowers `struct __sized_ptr_t { void *p;
size_t n; }` as `[2 x i64]` (`llvm::ArrayType`), whereas on x86_64 it is
lowered as `{ ptr, i64 }` (`llvm::StructType`).
Additionally, `emitHotColdSizeReturningNew` and
`emitHotColdSizeReturningNewAligned` in `BuildLibCalls.cpp` previously
hardcoded `StructType::get(B.getContext(), {B.getPtrTy(), SizeTTy})` as
the return type of the newly emitted `_hot_cold` call, which would fail
`replaceAllUsesWith` when replacing a call returning `[2 x i64]`.
Assisted-by: Gemini Argon
[CodeGen] Move BasicBlockMatchingAndInference options to CodeGenOptions.td (#235180)
Move -propeller-match-bbid and -propeller-infer-threshold from cl::opt
in BasicBlockMatchingAndInference.cpp to CodeGenOptions.td. This avoids
exposing PropellerMatchBBID in BasicBlockMatchingAndInference.h and
including that header in TargetPassConfig.cpp.
CodeGen: Consolidate MachinePipeliner controls (#235311)
This pass followed the anti-pattern of having a cl::opt in the pass
which early returned instead of not adding the pass to the pipeline in
the first place. Additionally several targets had their own cl::opts
used from the subtarget enablement hook.
Consolidate this into one generic control with a subtarget hook to
enable the pipeliner, following the example of enable-misched /
enableMachineScheduler.
Adding the nop pass still had the side effect of running the required
analyses which exposed issues. In particular this hides failures in
PPC with the defaults. The LiveIntervals dependency would assert if
there were unreachable blocks which was possible with the point PPC
inserted the pass.
Hexagon's hardware loop passes move to the end of
addMachineSSAOptimization so they still run before the pipeliner.
[6 lines not shown]
[AMDGPU] Use addressable arch VGPR count for CFI
emitPrologueEntryCFI assumed 1024 arch VGPRs on targets with VGPR
MSBs, regardless of wave size. In wave64 only 512 are addressable, and
VGPRs above that have no DWARF number. Use
getAddressableNumArchVGPRs, as whole wave function handling already
does.
No upstream target with VGPR MSBs supports wave64. NFC.
Change-Id: Ic65c4bb284e8583395bbe98ceeccd0f46b877538
Co-Authored-By: Claude Opus 5.5 <noreply at anthropic.com>
[SandboxVec] Remove empty test directory (NFC) (#235015)
This removes `Passes/BundleVec/AMDGPU/` as there are no tests left in
this directory after https://github.com/llvm/llvm-project/pull/234432
[AMDGPU] Derive addressable VGPRs from encoding width
The addressable VGPR count is bounded by both the operand encoding
width and the register file size. Compute it as the smaller of the two
instead of listing per-target values. Wave64 on targets with VGPR MSBs
was already min(1024, 512). NFC.
Change-Id: Ia0e030a9005fb2e915ef09e4ac7fd5ded22ab9b2
Co-Authored-By: Claude Opus 5.5 <noreply at anthropic.com>
[AMDGPU] Rename 1024AddressableVGPRs to VGPRMSBs
Most users of this feature ask whether the target has VGPR MSBs:
S_SET_VGPR_MSB, VGPR encoding lowering, MSB decoding and inline asm
register classes. 1024 follows from an 8-bit operand field plus 2 MSBs.
Name the feature after the capability so VGPR counts can be derived
from the encoding width. NFC.
Change-Id: I4da9b113260bb73cc60119836918ad16c09687ba
Co-Authored-By: Claude Opus 5.5 <noreply at anthropic.com>
[runtimes][Fortran] No introspection in bootstrapping build (#234424)
In a bootstrapping build, flang is only built for the runtime's build
step, but not the configure step. That means the the result of Fortran
compiler introspection is unreliable. Don't attempt
`check_fortran_builtins_available()` in a bootstrapping configure.
One may think that any compiler introspection will just fail as intended
if flang is not even available, but
https://github.com/llvm/llvm-project/pull/209482#issuecomment-6202154199
describes how it may pass: `fakeflang` just runs the preprocessor (which
is sufficient for CMake to detect LLVMFlang), but
`check_fortran_builtins_available`'s check is intended to fail during
symbol resolution.
AMDGPU: Don't reserve the implicit buffer pointer with architected flat scratch (#235258)
Mesa shaders always had s[0:1] reserved for the implicit buffer
pointer, which is only needed to set up the scratch buffer
resource. With architected flat scratch, scratch is initialized by the
hardware and the pointer is unused. The driver stopped passing this
pointer so all user SGPRs were off by 2.
Don't reserve it on targets with architected flat scratch, so the user
SGPRs of Mesa shaders start at s0. Diagnose the use in the unsupported
contexts. This fixes many test failures on my system when running
piglit.
Co-authored-by: Claude Opus 5.5 <noreply at anthropic.com>
RegAlloc: Only def the subregister regunits of a failed subregister def (#235307)
After an allocation failure, cleanupFailedDefs added each failed def to
the live ranges of all regunits of the assigned register. A subregister
def only writes the subregister, so the remaining units got a def from
an instruction that does not modify them, which the verifier rejects.
Fixes ran-out-of-registers-errors.ll with EXPENSIVE_CHECKS after
#233796.
Co-authored-by: Claude Opus 5.5 <noreply at anthropic.com>
[SelectionDAG][RISCV][X86] Keep jump table range checks with cf-protection-branch (#234733)
When the default of a switch is unreachable, SelectionDAGBuilder elides
the jump table range check, except when ARM branch-target-enforcement is
enabled, since an unchecked table branch can be a JOP gadget.
Extend this to the cf-protection-branch module flag used by RISC-V
Zicfilp and X86 IBT. The module flag is merged with Module::Min
behavior, so a value of 0 is treated as not enabled.
Assisted-by: Claude
[RISCV] Use vector getConstant. NFC (#235152)
It will eventually be legalized to a splat_vector and constant, but we
usually use a vector getConstant so let's be consistent.
CodeGen: Consolidate MachinePipeliner controls
This pass followed the anti-pattern of having a cl::opt in the pass
which early returned instead of not adding the pass to the pipeline in
the first place. Additionally several targets had their own cl::opts
used from the subtarget enablement hook.
Consolidate this into one generic control with a subtarget hook to
enable the pipeliner, following the example of enable-misched /
enableMachineScheduler.
Adding the nop pass still had the side effect of running the required
analyses which exposed issues. In particular this hides failures in
PPC with the defaults. The LiveIntervals dependency would assert if
there were unreachable blocks which was possible with the point PPC
inserted the pass.
Hexagon's hardware loop passes move to the end of
addMachineSSAOptimization so they still run before the pipeliner.
[7 lines not shown]
[mlir][linalg] Handle `DropPadUnitDims` when padding value is defined inside the pad body (#223712)
`DropPadUnitDims` reused the pad's padding value as-is when building the
replacement `tensor.pad`.
If that value was defined inside the original pad's own body, the new op
ended up referencing it from outside its region, and erasing the
original pad then hit an assertion.
This PR clone the defining op when the padding value lives inside the
pad body.
Fixes #203813
---------
Signed-off-by: Federico Bruzzone <federico.bruzzone.i at gmail.com>
[clang-tidy] Don't suggest const on `std::moved` locals in templates … (#226577)
[clang-tidy] Don't suggest const on std::moved locals in templates
Skip diagnostics in template instantiations for locals that are used as
arguments of std::move.
Reason: for some instantiations the move may be converted to copy so the
variable may look unmutated and flagged, whereas for other template
instantiations the real move semantics may apply.
Fixes: #225395
Assisted by Gemini for constructing the matcher.
---------
Co-authored-by: Zeyi Xu <zeyi2 at nekoarch.cc>
[AMDGPU][NFC] Harden sched_mfma_rewrite_copies.mir rewrite cases
The only functions in this test that are rewritten to AGPR form are
noncandidate_mfma_def_feeds_candidate_src2 and
av_mov_imm_src2_def_escapes_to_vgpr_user, added by #200972. Both are
balanced exactly on the RewriteMFMAFormStage cost threshold. Any
change that lowers the measured region pressure removes the rewrites
and the original intention of this test is lost.
The spill reduction is bounded by the number of rewrite-candidate
lanes live at the region's peak pressure. Keep more chain values live
through MFMA operands and keep the chain members rewrite candidates.
The properties under test are unchanged: the first MFMA in the first
function is still a non-candidate whose result feeds a candidate's
src2, and the AV_MOV_B64_IMM_PSEUDO in the second still escapes to a
VGPR user, so both still need bridge copies.
Co-authored-by: Cursor <cursoragent at cursor.com>
[mlir] Find the pattern dump root only when IR debugging is enabled (#233771)
Extracted from https://github.com/llvm/llvm-project/pull/231423
`PatternApplicator` debug printing was unconditionally calling
`getDumpRootOp` which walks nested ops chains. This was taking a
noticeable time in synthetic 1000-nested test. Call `getDumpRootOp` only
if printing is actually enabled.
