[IR] Verify that VP !prof does not have duplicate prof values
Follows on #193077. We should not have duplicate values as they should
be merged before being moved into IR. Add this to the verifier so that
we can actually enforce this constraint.
Reviewers: david-xl, teresajohnson
Pull Request: https://github.com/llvm/llvm-project/pull/193083
[flang][OpenMP] Add diagnostic for bare DECLARE TARGET in invalid scopes (#198039)
The bare form of `!$omp declare target` (without arguments or clauses)
is only permitted in the specification part of a subroutine, function,
or interface body (OpenMP 5.2, section 7.8.2). Flang previously accepted
it silently in BLOCK DATA, PROGRAM, MODULE, SUBMODULE, and BLOCK
constructs.
This patch:
- Adds a semantic check rejecting the bare form outside Subprogram
scopes.
- Adds MpSubprogramStmt/EndMpSubprogramStmt scope tracking to avoid
false positives in separate module subprograms (MODULE PROCEDURE).
- Fixes pre-existing BlockConstruct scope tracking bugs: the Leave
handler was pushing instead of popping (stack corruption), and the
Enter handler used blockStmt.source which resolves to the parent
scope. Now uses endBlockStmt.source (walked inside the block scope
during name resolution) for correct BlockConstruct scope identity.
[4 lines not shown]
[ELF] Fix imprecise --why-live message for exported symbols (#198139)
The "; may interpose" suffix is imprecise: a symbol is preserved because
it is exported into the dynamic symbol table, regardless of whether it
is interposable (preemptible).
Fix #192035 and add a test (previously uncovered)
[FileCheck] Refactor -dump-input test
This patch refactors `llvm/test/FileCheck/dump-input/annotations.txt`
to improve maintainability and coverage and to prepare for the
upcoming implementation of search range annotations.
Lit substitutions
=================
The test repeats the same basic set of RUN lines *many* times. This
patch encapsulates those in lit substitutions to improve
maintainability. By doing so, it also helps to ensure more consistent
coverage of all cases and thus slightly expands coverage.
-strict-whitespace
==================
Via those substitutions, this patch adds `-strict-whitespace`
throughout the test, and it drops the initial `-strict-whitespace`
[27 lines not shown]
[FileCheck] Resurrect overflow tests
D150880 (landed as 0726cb004718) uses `APInt` to eliminate most
integer overflow issues from FileCheck numeric variables. It also
removes the 4 tests in
`llvm/test/FileCheck/match-time-error-propagation`.
While the elimination of overflow issues reduces the importance of
those tests, the tests still seem worthwhile. Without them, I see no
test that exercises the "unable to substitute variable or numeric
expression: overflow error" diagnostic in FileCheck input dumps.
This patch resurrects those tests and updates them to exercise the
remaining unsigned underflow case.
[ELF] Remove redundant memset in SymbolTable::insert. NFC (#198132)
make<SymbolUnion>() value-initializes the union, zero-initializing all
sizeof(SymbolUnion) bytes. The following memset(sym, 0, sizeof(Symbol))
is therefore redundant.
This placeholder path runs no Symbol constructor, so it was not covered
by the constructor initialization in
905a88b923433eb8cd83677ea55bee82eb9ba498.
[X86] isExtractSubvectorCheap - fix typo in vXi1 extraction test (#198127)
Fix typo in check for ResVT subvector being half the size of the SrcVT vector (instead of vice-versa).
Fixes #195695
[ELF] Initialize Symbol fields in the constructor instead of via memset (#198129)
`initSectionsAndLocalSyms` and `makeDefined` memset the storage to zero
and then placement-new a Symbol-derived object into it. Placement new
begins a new object's lifetime. The standard does not seem to guarantee
the memset bytes carry into members the constructor leaves
uninitialized.
lld built by GCC 16 can make Valgrind report reads of Symbol::flags
(via getSymSectionIndex during finalizeSections) as uses of
uninitialized values (ClangBuiltLinux/linux#2162).
This patch reinstates the per-field initialization that commit
778742760534 ("[ELF] Avoid redundant assignment to Symbol fields. NFC")
had replaced with a bulk memset.
[VPlan] Refine plain CFG iterator name and strengthen assert (NFC). (#198124)
Address post-commit comments for
https://github.com/llvm/llvm-project/pull/197499:
* add rpo prefix the name to indicate traversal (similar to other
vp_depth_first_ helpers)
* Added comment about skipped VPIRBBs + assert.
[VPlan] Add blocksAs helper (NFC). (#198122)
Add new blocksAs helper which casts all blocks in the provided range to
the specified type, instead of filtering out non-matching blocks.
Migrate a number of users that expect only VPBasicBlocks.
Pointed out post-commit in
https://github.com/llvm/llvm-project/pull/197499.
[RISC-V][RVY] Introduce pure-capability ABI names
Adding this will allow updating #177249 to define the datalayout only
based on the triple and ABI instead of inspecting the feature string
which is a per-function property and not a per-module one.
The RVY ABIs are currently under review at this psABI pull request:
https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/499
Pull Request: https://github.com/llvm/llvm-project/pull/194270
[SLP][REVEC] Fix crash on scalable vector types with -slp-revec
isValidElementType incorrectly called toScalarizedTy for scalable vector
types because isVectorizedTy returns true for all vector types. This let
scalable types pass as valid revectorization elements, causing a fatal
"Cannot implicitly convert a scalable size to a fixed-width size" error
in getNumElements when it called getVectorizedTypeVF(Ty).getFixedValue().
Fixes #198076
Reviewers:
Pull Request: https://github.com/llvm/llvm-project/pull/198123
[VPlan] Split out adding canonical IV recipes to separate transform. (#197541)
Introduce canonical IV recipes after initial scalar
transformations/simplifications. Conceptually it is a separate
transformation and moving it later simplifies initial construction The
canonical IV is only needed once we handle early exits/introduce
regions.
This is needed to compute costs of scalar VPlans, where we need to
compare the cost of the original loop control instructions.
PR: https://github.com/llvm/llvm-project/pull/197541
[AArch64] Decompose constant multiplies used only by memory addresses (#194584)
AArch64 currently avoids decomposing a constant multiply when the
multiply has
a single ADD/SUB user, preserving the opportunity to form MADD/MSUB.
That heuristic is too conservative when the ADD/SUB is used only as a
memory
address. In that case the ADD/SUB is selected as part of load/store
address
mode selection, so preserving the multiply does not produce MADD/MSUB
and
prevents the existing constant-multiply decomposition from exposing
ADD/LSL
forms usable by AArch64 register-offset addressing.
Relax the bailout for ADD/SUB users that are only used as unindexed
load/store
base addresses.
Fixes #161446.
[SLP] Prefer VF-matching scalar-set match in gather-shuffle lookup
In isGatherShuffledSingleRegisterEntry, the perfect-match search accepted
an entry that isSame(TE->Scalars) regardless of the entry's vector factor.
isSame can succeed via ReuseShuffleIndices on an entry whose actual VF is
smaller than TE->Scalars.size(); the subsequent mask construction then
copies TE->getCommonMask() indices that overrun the chosen source's lanes,
producing wrong shufflevector masks and a more-poisonous result than the
scalar code.
Fixes #197765
Reviewers:
Pull Request: https://github.com/llvm/llvm-project/pull/198120
[LV] Update stale comment for partial reduction operands (NFC)
The `neg` form was removed in #187228 (this case now uses the out-of-loop sub, which is preferable, see #189739).
[FileCheck][NFC] Introduce MarkerRange for -dump-input (#196800)
`MarkerRange` makes the computation of marker ranges clearer because it
encapsulates handling of several subtle boundary cases:
- It handles adjustments to line numbers when a range boundary appears
at a line boundary.
- It avoids related mistakes in determining whether the range is
contained within a single line.
- It avoids the mistake of producing no marker in an input annotation
for an empty range.
It will be used more in a future patch that extends `-dump-input` to
present search ranges for all errors.
This PR is stacked on PR #196799.
[AArch64][GlobalISel] Improve multiplication with multiple registers (#197943)
When working on codegen for `llvm.umul.fix.sat` I have recognized that
among for many things, GISel also generates worse code for mul when the
data is in multiple registers (for example when the register length is
64 bits but you want to multiply two 128 bit values).
Here is the example ll:
```
define i128 @i128(i128 %a, i128 %b) {
entry:
%s = mul i128 %a, %b
ret i128 %s
}
```
This is what GISel gave:
```
mul x9, x0, x3
[19 lines not shown]
[X86] LowerVECREDUCE - add AllowScalarization operand (#198109)
Pull out scalarization control from LowerVECREDUCE call to allow
different decisions based on the VECREDUCE opcode in future patches
[AtomicExpand] Add bitcasts when expanding store atomic vector
AtomicExpand fails for aligned \`store atomic <n x T>\` because it
does not find a compatible library call. This change adds appropriate
ptrtoint + bitcast so that the call can be lowered, mirroring the
load-side handling from #148900.
Remove default setting signaling_nan attribute for strictfp functions
We cannot describe such behavior in Clang User Manual, strictfp is not
visible for a user.
[lldb] Make CommandObject::GetTarget filter out the dummy target (#198026)
Follow-up to #197805. Make CommandObject::GetTarget the canonical target
accessor for command code, and tighten its semantics so that DoExecute
methods can't accidentally operate on the dummy target.
GetTarget now returns Target* instead of Target&. The result is the
target from the command's frozen execution context, falling back to the
interpreter's execution context. The dummy target is filtered out and
replaced with nullptr unless the command opts in via one of the
eCommandRequires{Target,Process,Thread,Frame} flags (in which case
CheckRequirements has already guaranteed a real target) or via the new
eCommandAllowsDummyTarget flag.
This is the first half of the cleanup discussed at the end of #197805. A
follow-up will audit DoExecute methods that still reach for
GetSelectedTarget or m_exe_ctx.GetTargetPtr() directly and migrate them
to GetTarget.
