[MLIR][ACC] Fix -Wunused-variable in dfe7738
There was a variable only used in an assertion which causes warnings in
non-assertions builds. Fix the issue by inlining the variable into the
assertion given it is only used in one place.
[Clang][NFC] Apply Rule of Three to AttrScopedAttrEquivalenceContext (#184905)
Static analysis flagged AttrScopedAttrEquivalenceContext as having a
user defined destructor but not having copy ctor or copy assignment. I
set them as deleted since they are not needed.
[ORC] Refactor some WaitingOnGraph loops into named methods. NFCI. (#184775)
Adds new methods to SuperNode for updating ElemToSuperNodeMap values,
use it to tidy up some loops.
[SYCL] SYCL host kernel launch support for the sycl_kernel_entry_point attribute. (#152403)
The `sycl_kernel_entry_point` attribute facilitates the generation of an
offload kernel entry point function based on the parameters and body
of the attributed function. This change extends the behavior of that
attribute to support integration with a SYCL runtime library through
an interface that communicates symbol names and kernel arguments
for the generated offload kernel entry point functions.
Consider the following function declared with the
`sycl_kernel_entry_point` attribute with a call to this function
occurring in the implementation of a SYCL kernel invocation function
such as `sycl::handler::single_task()`.
```c++
template<typename KernelName, typename KernelType>
[[clang::sycl_kernel_entry_point(KernelName)]]
void kernel_entry_point(KernelType kernel) {
kernel();
}
[49 lines not shown]
[clang-tidy][NFC] Add missing Option tests in `readability` [2/N] (#184708)
This PR adds testcases for untested Options in `readability` module for
better test coverage, specifically:
- `readability-identifier-length`: `IgnoredExceptionVariableNames`,
`IgnoredLoopCounterNames`, `IgnoredParameterNames`,
`MinimumExceptionNameLength`, `MinimumLoopCounterNameLength`,
`MinimumParameterNameLength`, `MinimumVariableNameLength`.
- `readability-magic-numbers`: `IgnoreAllFloatingPointValues`.
- `readability-qualified-auto`: `AddConstToQualified`.
- `readability-redundant-parentheses`: `AllowedDecls`.
- `readability-suspicious-call-argument`: `MinimumIdentifierNameLength`.
- `readability-use-std-min-max`: `IncludeStyle`.
As of AI Usage: Assisted by Gemini 3 and Claude (Writing part of the
testcases and pre-commit reviewing).
[clang][modules] -Wmodule-import-in-extern-c should not be an error by default (#184530)
Importing a module inside of an `extern "C" {...}` section doesn't have
any effect, i.e. the imported module is not treated as `extern "C"`,
it's built independent of the includer state. The warning is akin to
`-Wconfig-macros`, it's trying to say that the behavior will be
different (and unexpected) when compiling with modules. That doesn't
need to be an error, a warning is enough. As an error, it makes it
difficult to support and test modules in C++ mode while dependencies
still have includes in `extern "C" {...}`.
rdar://171677028
[clang] Enable wrapping the FrontendAction for module builds (#184907)
This PR upstreams a piece of infrastructure from Swift's LLVM fork. This
allows adding custom wrappers around the `FrontendAction` that compiles
Clang modules from a module map into a PCM file. This will be used to
implement modules support in the CAS-based compilation caching mode.
[AMDGPU] Enabled GCN trackers (amdgpu-use-amdgpu-trackers) by default.
The LIT tests have been generally updated in one of the following ways:
(1) If the above option was not present and the test was auto-generated,
the test has now been auto-generated.
(2) If the above option was not present and the test was not
auto-generated, added the option -amdgpu-use-amdgpu-trackers=0 so as to
preserve any specific attributes the test was already checking.
(3) If the above option was present in a test, then its value has been
updated to reflect the change in the default.
Currently, there are 4 tests in category (2). They are:
CodeGen/AMDGPU/
addrspacecast.ll
schedule-regpressure-limit.ll
schedule-regpressure-limit2.ll
sema-v-unsched-bundle.ll
There are 8 tests in category (3). They are:
[15 lines not shown]
libclc: Define work_group_barrier (#184780)
Previously only the old barrier name was implemented. Define this
as an indirection around the new name, and move it to common code.
The target implementations are already provided by
__clc_work_group_barrier,
so targets were unnecessarily duplicating these.
This also fixes the default scope, which should be
memory_work_group_scope. Previously this was guessing that
if the flags included global memory, it makes the scope
device which is not the case.
[libc][math] Fix FP add/sub for signed-zero operands (#183243)
(-0.0) + (-0.0) and (-0.0) - (+0.0) returned +0.0 instead of -0.0.
Ensure these cases comply with IEEE 754 §6.3 rule.
