PowerPC: Drop AllowFPOpFusion from isProfitableToHoist
Exclusively rely on the contract flags on individual instructions
to enable the removal of AllowFPOpFusion. This had no test coverage
anyway.
Co-authored-by: Claude (Claude-Opus-4.8) <noreply at anthropic.com>
[flang][cuda] Unify locking regime for the allocation table (#221341)
The lock was acquired in insertAsyncDeviceAllocation but not in other
function. Move the lock outside of the function so the locking regime is
homogeneous.
[clang-format] Add FilesBeforeFolders option to SortIncludes (#208954)
Add a new `SortIncludes.FilesBeforeFolders` boolean option that, when
enabled, sorts includes so that files in a directory appear before
subdirectories at each level, recursively. Within a level, files and
subdirectories are each sorted alphabetically.
For example:
```
true: false (default):
#include "x.h" vs. #include "bar/alpha/e.h"
#include "y.h" #include "bar/alpha/f.h"
#include "z.h" #include "bar/beta/d.h"
#include "bar/g.h" #include "bar/g.h"
#include "bar/h.h" #include "bar/h.h"
#include "bar/i.h" #include "bar/i.h"
#include "bar/alpha/e.h" #include "foo/a.h"
#include "bar/alpha/f.h" #include "x.h"
[4 lines not shown]
[memprof] check path in opendir interceptor (#221309)
The sanitizer `opendir` interceptor unconditionally calls
`internal_strlen(path)` before forwarding to the real function.
Passing `nullptr` therefore causes the sanitizer runtime itself to
dereference address zero.
Add a unit test using a `LD_PRELOAD` shim to verify that a null path
reaches the real implementation without crashing the interceptor.
---------
Co-authored-by: Sharon Xu <sharonxu at fb.com>
[flang][cuda] Make sure that CUDA is enabled when adding PINNED implicit attribute (#221334)
PINNED was not guarded like MANAGED. Just make a general guard for both.
[compiler-rt][ubsan] Fix trailing whitespace in SUMMARY line when function is unknown (#221335)
Fixes #30851. ReportErrorSummary always rendered "%L %F", but %F expands
to nothing when the function name is unknown, leaving a dangling space
at the end of the line. Instead, oly add the function name if it is
known.
ARM: Form fused VFMA/VFMS from the contract flag
Select the fused VFMA/VFMS/VFNMA/VFNMS from the per-node contract fast-math
flag instead of the global AllowFPOpFusion == Fast. This is one of the
few remaining consumers of the TargetOption field.
Co-authored-by: Claude (Claude-Opus-4.8) <noreply at anthropic.com>
[SLP]Fix narrowing of icmp with mismatched operand extensions
Keep the narrow compare only if the predicate matches the operand
signedness; otherwise extend the operands back to the original
compared type.
Fixes #221240
Reviewers:
Pull Request: https://github.com/llvm/llvm-project/pull/221336
[VPlan] Extend induction cost test coverage (NFC). (#221323)
Widen induction-cost.ll's filter to cover all induction recipes and the
canonical IV increment, run it for two VFs, and add the FP and pointer
induction shapes it was missing entirely: scalarized
FAdd/FSub/invariant-step inductions, a dead induction in the vector
loop, one with both wide and scalar users, one inside a replicate
region, a fully unrolled one, and FP-plus-pointer and pointer-only
loops.
[DAG] SplitVecRes_VECTOR_COMPRESS - rename MaskVT -> LoMaskVT. NFC. (#221285)
MaskVT refers to LoMask's type not the original Mask type.
Noticed in #215772 - avoids some potential Wshadow confusion.
[VPlan] Preserve nneg when expanding SCEVZeroExtendExpr. (#221322)
Add nneg to ZExt when expanding a SCEV where SCEV can prove it is
non-negative, matching behavior of IR SCEVExpander::visitZeroExtendExpr.
[libc] Add CMake formatting utility (#213102)
Added libc/utils/cmake_format.py and libc/utils/cmake_format_test.py to
format LLVM and subproject CMake files according to LLVM-libc formatting
conventions.
The formatter operates in three passes:
* Lexer: Tokenises input using the cmake-language(7) EBNF specification
into typed Token objects with line and column position tracking.
* Dynamic Schema Scanner: Pre-scans repository CMake modules and
function blocks to learn option, single-value, and multi-value keyword
argument schemas from cmake_parse_arguments and set calls.
* Token-Stream Formatter: Applies 2-space control block nesting, keyword
casing, comment buffering, and multi-line list indentation in a single
pass.
The utility supports parallel multi-core execution (-j/--jobs) and
in-place file formatting (-i/--inplace). Added 44 unit tests covering
[2 lines not shown]
[CIR] Emit Memset in emitNullInitialization for default inits case (#221029)
Emit the cir.libc.memset op in emitNullInitialization for the default
inits case, which ends up with emitted IR identical to the original
codegen and eliminates the need to create a private global instance of a
struct with zero init
Mips: Drop use of AllowFPOpFusion
Fuse MSA fmadd/fmsub based on the contract flag. Fix a few
places dropping the flags during legalization.
The handling here of fusion isn't ideal. isFMAFasterThanFMulAndFAdd
is not implemented, so these patterns are doing a lot heavier and
less optimal work than the DAGCombiner logic will do.
Co-authored-by: Claude (Claude-Opus-4.8) <noreply at anthropic.com>
NVPTX: Drop global AllowFPOpFusion read from allowFMA (#221313)
We're near the end of the decade long effort to eliminate the
fast math fields from TargetOptions. This is one of the few
remaining consumers, so remove it. Update incidentally
changed tests by adding contract flags.
Co-authored-by: Claude (Claude-Opus-4.8) <noreply at anthropic.com>
[OMPIRBuilder] Keep the target construct's location for the deinit call (#221303)
#217407 gave __kmpc_target_init and __kmpc_target_deinit a debug
location by setting the outlined function's location once, before
generating the target body. The init call is emitted before the body and
keeps it, but the deinit call is emitted after, and by then the body may
have replaced it.
The body callback builds the body with its own IRBuilder, so nothing it
emits can disturb the one createOutlinedFunction() uses for the
epilogue. But a body holding another OpenMP construct, a nested parallel
say, calls OpenMPIRBuilder::createParallel, and that leaves the builder
pointing at the wrong debug location, or at none at all. The deinit call
then silently loses its !dbg again.
The test added with #217407 uses a target region whose body is a single
store. Such a body never calls back into OpenMPIRBuilder, the location
survives, and the gap was not visible.
[8 lines not shown]
[cmake] Fix ninja clean failure for cross-compilation native build dir (#200641)
Ninja clean treats every build OUTPUT as a path to remove(). When NATIVE
(the cross-compilation host sub-build directory) was registered directly
as the OUTPUT of the CREATE_<project>_<target> custom command, ninja
tried to remove() it as if it were a file and failed with "Directory not
empty".
Fixed by introducing a stamp file (NATIVE/created.stamp) as the sole
CMake OUTPUT of that custom command. The stamp file is what ninja cleans
(a single file removal), while make_directory remains idempotent on
subsequent builds.
[include-cleaner] Support Objective-C toll-free bridged casts (#216158)
Handle `CK_CPointerToObjCPointerCast` in `WalkAST` to report implicit
case when converting id/void to an Objective-C type (non-arc only). Also
adds unit tests for various bridged cast types (these were already
covered, but this verifies that they work).
[LV] Add VPlan printing tests for memory runtime check generation (NFC) (#221232)
Add VPlan printing tests with runtime check blocks, as well as coverage
for checks where one of the bounds involves an AddRec.
[lit] Apply --filter-out to GoogleTest shard results (#220410)
[lit] Apply --filter-out to tests expanded from GoogleTest shards
A GoogleTest shard is a single lit test at discovery time, so
`--filter-out` can only match the shard's name and has no way to
deselect individual gtest cases. The cases only get real names once
`post_process_shard_results` expands the shard's JSON output.
Apply the filter there instead: mark expanded subtests whose full name
matches `--filter-out` as EXCLUDED. Record `has_failure_in_shard` before
the filter is applied, so a shard whose only failing cases were filtered
out is still considered accounted for and is not additionally reported as
a failure of the parent shard.
Add a test which filters out the failing and unresolved cases of the
googletest-format inputs and checks that the run reports 2 excluded
and no failures.
Assisted-By: Claude Opus 5.
