[SupportTests] Ignore STATUS_DLL_NOT_FOUND errors with MSVC (#230726)
When the unittests are linked with LLVM.dll, the
TestExecuteEmptyEnvironment fails because there are no library paths to
search. There was already a workaround for this issue on MINGW, and this
patch just extends it to work in MSVC mode environments too.
perf(AMDGPU): fold extended boolean AND/OR
Accept ANY_EXTEND in the AND-to-select combine and add the matching
OR fold. Guard OR folds for shared extensions and uniform conditions
to avoid code-size regressions.
[Attributor] Skip the dead-internal-function walk for AAs that will not be updated (#227187)
AAIsDeadFunction::initialize calls isAssumedDeadInternalFunction, which
runs checkForAllCallSites and so creates an AAIsDead for every internal
caller, each of which repeats the walk. Initialization therefore
recurses through the whole cone of internal callers.
When the AA will not be updated (outside of deduction, or for a function
the Attributor is not run on), getOrCreateAAFor fixes it pessimistically
right after initialize returns, discarding the walk's result. Skip the
walk in that case and assume the entry block live.
This is the dominant cost of the CGSCC OpenMPOpt pass, whose cleanupIR
queries the liveness of callers outside the current SCC on every SCC,
giving (#SCCs) x (depth of the internal caller chain). #222226 removed
the callee-seeding half of this cost; this removes the walk itself.
* The cleanup-no-seeding.ll change drops a debug check that only the
removed walk printed.
[30 lines not shown]
[BOLT] Handle the indexed DWARF address forms by class (#227591)
DWARF's address class covers DW_FORM_addr plus DW_FORM_addrx,
addrx1 through addrx4 and DW_FORM_GNU_addr_index, where the
indexed ones store an index into .debug_addr rather than the
address itself. Several places enumerated a subset of those
forms instead of testing the class, so addrx1 through addrx4
took wrong code path.
The local getHighPC() helper compared against DW_FORM_addr
alone, so every indexed form was read as an offset, yielding
"LowPC + index". It also never resolved an index at all,
unlike the getLowPC() directly above it.
Add isAddressForm() and isIndexedAddressForm(), and route all
of the above through them. getHighPC() now takes a DWARFUnit
argument so it can resolve an index through .debug_addr the
way getLowPC() does.
[15 lines not shown]
AMDGPU: Stop setting kill flags before FinalizeISel (#229009)
Work on removing all pre-RA flag management. Kill flags should
eventually be
removed. Pre-regalloc passes no longer depend on them, LiveIntervals
strips them
and VirtRegRewriter re-introduces them.
Co-authored-by: Claude Opus 5.5 <noreply at anthropic.com>
[mlir][SCFToControlFlow] Mark the scf.for increment as non-wrapping (#230891)
`scf.for` makes it undefined behavior for `LB + n*Step` not to be
representable in the induction variable type (#203713), so no increment
of the induction variable can wrap under the interpretation of the
bounds. Emit the increment with `overflow<nsw>`, or `overflow<nuw>` for
loops with `unsignedCmp`.
Without the flag, LLVM cannot prove that an induction variable that
starts non-negative and has a non-negative step stays non-negative.
Assisted-by: Cursor
[mlir][DataLayout] Add getTypeAllocSize
Add DataLayout::getTypeAllocSize, the type's size rounded up to its ABI
alignment, as in llvm::DataLayout. Use it for the three places that
computed this by hand: LLVM dialect arrays and structs, and the OpenMP
offload privatization pass. ClangIR's type layout hooks also need it.
Assisted-by: Cursor / Claude Opus 5.5
[lldb][Windows] Support TLS variables with PDB (#229894)
This implements `DynamicLoaderWindowsDYLD::GetThreadLocalData` which
resolves a TLS offset for a module on a thread into an address. This is
called when `DW_OP_form_tls_address` is evaluated.
On Windows, the address for a thread local is resolved by reading from
the TLS array at the module's `_tls_index`.
It only works with PDB right now, because of a bug in LLVM where it uses
the wrong relocation for the offset (#196083).
Closes #196288.
[GitHub] Fix PR code lint workflow (#231252)
After 192e44b58239, expect JSON from compute_projects.py rather than
being able to source the output to set env variables.
[BOLT] Expand builtin_unreachable recognition heuristics
A jump to the address right past the end of a function (the result of
__builtin_unreachable()) was replaced with a nop only when the target
was within the function's padding (MaxSize). However, there is a
corner case for the very last function in a section: MaxSize equals
Size, so BOLT would see __builtin_unreachable() instead as as an
interprocedural reference to an address outside of any section,
tripping the "cannot get section for referenced address" assertion in
processInterproceduralReferences(). Fix this.
[GitHub] Trigger code lint workflow on changes to compute_projects (#231250)
192e44b58239 adjusted the script but broke this workflow. No one noticed
given this workflow was not triggered on those changes. Make the
workflow trigger on these changes so we can catch such breakages.
Associate a BLOCK across compiler directives that emit no code
A named INLINEALWAYS, unnamed inlining directives, and loop directives
between a standalone METADIRECTIVE and its BLOCK still ended the search,
so a selected TARGET was empty and the BLOCK was lowered outside it.
Use the DO path's classification of compiler directives that emit no
executable operations for the BLOCK path too, and rename it accordingly.
The directives move with the BLOCK and are still lowered, so a matching
INLINEALWAYS still marks the procedure always-inline, a mismatched one
stays ignored, and loop and inlining directives see the same following
statement as before. PREFETCH still ends the search.
[mlir][ptr] Preserve broadcasts when folding zero pointer offsets (#231077)
ptr.ptr_add accepts a scalar base with a shaped offset and returns a
shaped pointer value. Its zero-offset fold currently returns the scalar
base even when the offset is a zero splat, producing a value with the
wrong type and triggering an assertion during canonicalization.
Only fold to the base when its type matches the result type. Add
regression coverage for fixed vectors, scalable vectors, and tensors,
and check that type-preserving zero-offset folds still apply to shaped
bases.
[Attributor] Skip the dead-internal-function walk for AAs that will not be updated
AAIsDeadFunction::initialize calls isAssumedDeadInternalFunction, which
runs checkForAllCallSites and so creates an AAIsDead for every internal
caller, each of which repeats the walk. Initialization therefore recurses
through the whole cone of internal callers.
When the AA will not be updated (outside of deduction, or for a function
the Attributor is not run on), getOrCreateAAFor fixes it pessimistically
right after initialize returns, discarding the walk's result. Skip the
walk in that case and assume the entry block live.
This is the dominant cost of the CGSCC OpenMPOpt pass, whose cleanupIR
queries the liveness of callers outside the current SCC on every SCC,
giving (#SCCs) x (depth of the internal caller chain). #222226 removed
the callee-seeding half of this cost; this removes the walk itself.
cleanup-no-seeding.ll drops a debug check that only the removed walk
printed.
[2 lines not shown]
[CIR] Add HLSL to LangOptions in #cir.lowering_lang_options (#230964)
Add HLSL LangOptions to the lowering_lang_options to be used when
lowering the built-in matrix type
[CodeGen] Merge MachineFunctionSplitter into BasicBlockSections (#230365)
Function splitting was done by two passes: MachineFunctionSplitter split
functions using their PGO/AutoFDO profile, and BasicBlockSections split
functions which have a basic block sections profile.
MachineFunctionSplitter had to skip functions in the basic block
sections profile, and both passes renumbered, sorted and fixed up the
blocks of a function.
Move the PGO/AutoFDO splitting logic into BasicBlockSections, so that a
single pass does all function splitting. For every function,
BasicBlockSections now uses the basic block sections profile where it is
available, and otherwise, with -function-splitting=all, the PGO/AutoFDO
profile. The pass is added to the pipeline when function splitting is
enabled, and createBasicBlockSectionsPass() takes a SplitWithPGO
argument which makes it require MachineBlockFrequencyInfo and
ProfileSummaryInfo.
The splitting decisions and the resulting layout are unchanged. The
[2 lines not shown]
[BOLT] Restore -relax-plt as a deprecated no-op option (#230729)
c6ee71d5e8a5 removed -relax-plt from the AArch64 relaxation pass, which
makes llvm-bolt reject existing command lines that still pass it. Re-add
the option as a hidden no-op that only prints a deprecation warning, so
scripts using it keep working.
[Mips] Declare command line options in TableGen (#230738)
Move the cl::opts of MipsCodeGen into MipsOptions.td, and those of
MipsDesc into MCTargetDesc/MipsMCOptions.td, registered by
LLVMInitializeMipsTargetMC().
CompactBranchPolicy becomes an enum class, and
MipsSubtarget::useConstantIslands() becomes a non-static member.
Aided by Opus 5.5
[libc] Improve nearest_integer for non-AVX x86 targets. (#230529)
Without AVX, _mm_round_ss and _mm_round_sd introduce false dependency of
the upper lanes that causes significant regressions for non-AVX x86
targets.
We call roundss and roundsd directly with inline asm to prevent the
false dependency for such targets.
[AMDGPU] CallInst -> CallBase for divergence analysis (#228744)
This handles non-call instructions like callbr.
The test changes in infinite-loop.ll, where there are now two return
blocks (the original one + the dummy) instead of the unified return
block is a symptom of the callbr in those functions being not marked as
divergent anymore.
This patch was hand-manufactured using Neovim.
---------
Co-authored-by: Matt Arsenault <Matthew.Arsenault at amd.com>
Passes: Replace FunctionAttrs with attributor-light when it is enabled (#231157)
attributor-light is meant to replace FunctionAttrs, but with
-attributor-enable=light both ran. Use AttributorLightCGSCCPass in
place of each PostOrderFunctionAttrsPass, and AttributorLightPass in
place of each ReversePostOrderFunctionAttrsPass, in the default,
ThinLTO and full LTO pipelines.
Co-authored-by: Claude Opus 5.5 <noreply at anthropic.com>
[Coroutines] Avoid line 0 locations for async context projections (#231221)
CoroSplit inlines a call to the async context projection function, which
usually has line zero location as it is compiler generated boilerplate.
If that location has line zero, DwarfDebug skips the projection when it
places prologue_end, so the projection ends up in the prologue. This is
the same problem that 2cf550a04041 ([DebugInfo] Force early line-zero
calls to have meaningful locations, #156850) fixed for line 0 calls:
someone entering the function at prologue_end breaks in after the call
has completed.
If the suspend point has a line 0 location, give the projection the
location of the first instruction after the suspend point with a
non-zero line. We already do this for other intrinsics here.
Assisted by claude
