[mlir][ROCDL] Enable useStrictPropertiesInAssemblyFormat
**Migration note:** Separate out inherent and discardable attributes
on your `rocdl.*` operations and put a `<>` around the inherent ones.
This commit adds `prop-dict` clauses to all the ROCDL-dialect
operations that have inherent attributes but don't have better syntax
for them.
I looked at creating better syntaxes here, but these are fairly
low-level operations and it was hard to put together comma-separated
lists of optional arguments in tablegen. So I've gone with the rather
straightforward and consistent fix of adding in `prop-dict`s.
AI note: Claude did the changes here, I reviewed the designs.
Co-Authored-By: Claude Opus 5 (1M context) <noreply at anthropic.com>
[mlir][AMDGPU] Enable useStrictPropertiesInAssemblyFormat
This is part of the migration to keeping inherent and discardable
attributes separate touched.
**Migration note:** this'll change the syntax of a bunch of `amdgpu`
dialect ops to keep inherent attributes out of the `attr-dict`.
Syntax changes:
1. Operations like the dpp operations have had their inherent operands
turned into oilists that use `name(value)` syntax, such as
`bound_ctrl(false)`, which also leads to the elision of default
values.
2. Buffer operations now use `boundsCheck(true/false)` before the main
operation (keeping the visibility from the old attr-dict) and have
moved to `sgprOffset(%offset)` and `indexOffset(constant)` as optional
syntax alements after the main specification.
3. WMMA operations also now have the same `attribute[(value)]` element
[15 lines not shown]
[mlir] Don't print a stray space for a fully-elided prop-dict (#216810)
**Migration note**: if you have a custom `prop-dict` printer, add a
leading space into the format - it'll no longer be printed implicitly.
The `prop-dict` printer generated by mlir-tblgen would always print
a space before dispatching to printProperties(). When every property is
elided (because it is bound elsewhere in the assembly format or matches
its default value) printProperties() prints nothing, leaving a stray
space in the output. We had a test TODO about this.
This PR makes the leading space the responsibility of the properties
printer, so
it's emitted only when needed. The generic
printer in OpState::genericPrintProperties() and all in-tree custom
printers have been updated accordingly.
XeGPU had worked around the stray space by writing an empty space
directive (``) after prop-dict to suppress the space before ':'. Those
[14 lines not shown]
[SimpleLoopUnswitch] Tweak token live-out behavior (#217916)
The previous check (moved into Loop::isSafeToCloneConditionally in the
preceding NFC commit) rejected any token instruction with a use outside
its defining basic block. This is both too strict and too lax:
- Too strict: cloning only requires forming phis for values that are
live-out of the *loop*. Token uses that cross blocks but stay within the
loop are cloned along with their defs and need no phis, so they do not
inhibit non-trivial unswitching.
- Too lax: `isTokenTy()` misses token-like target extension types
(`isTokenLikeTy()`), which cannot be used in phi nodes either. A
live-out token-like value would have made unswitching produce invalid
IR.
Switch the check to reject exactly the token-like values that are
live-out of the loop, reusing the same use-scanning logic as
`isBlockInLCSSAForm` (`loopContainsUser`): a use in a phi is treated as
[4 lines not shown]
[DAG] Remove trivial VP SDNodes. NFC
This removes the codegen parts of the trivial VP intrinsics. It's quite far reaching, but the general categories of code removed are:
- Removing definitions from VPIntrinsics.def
- Legalization and expansion code
- MatchContext used to match over both VP and non-VP nodes
- Some dead DAGCombines and folds in SelectionDAGBuilder
There are still more things to be cleaned up after this, e.g. removing more of the VPIntrinsic class hierarchy, removing ExpandVectorPredication/moving expansion into other places, removing MatchContext from SDPatternMatch
[DAG] Expand vp.*rem and vp.cttz.elts with non-vp nodes.
Trivial VP SDNodes will be removed in an upcoming patch. The division is still predicated so we avoid UB.
[IR] Remove trivial VP intrinsics. NFC (#217863)
Trivial VP intrinsics are now all autoupgraded to their non-VP
counterparts, so the intrinsics themselves are dead.
This removes the intrinsics and their corresponding LangRef definitions,
as well as the VPIntrinsic subclasses and some methods in
ExpandVectorPredication which are now dead. Removing the SDNodes is
deferred to a separate patch.
RFC: https://discourse.llvm.org/t/rfc-remove-trivial-vp-intrinsics/90972
[SCEV] Fix wrap-flags typo in sext-addrec (#217927)
The change is obviously correct, but is very difficult to test.
Proof sketch: https://alive2.llvm.org/ce/z/Tj9Z-c
[libc++] Give the LNT tooling its own requirements.txt (#217889)
The LNT tooling alone has way fewer dependencies. Using a smaller
requirements.txt should speed up the "request historical benchmark data"
cron job that runs every 30 minutes and needs to install them.
[bazel][mlir] Fix lit.site.cfg substitution for MLIR_RUN_ARM_NEON_TESTS (#217973)
Follow-up to ee0f7ff7e697 which renamed MLIR_RUN_ARM_I8MM_TESTS to
MLIR_RUN_ARM_NEON_TESTS in lit.site.cfg.py.in.
[clang] Move the diagnostic of unexpected token after module name from phase 4 to phase 7 (#187846)
The PR https://github.com/llvm/llvm-project/pull/107168 implement
[CWG2947](https://cplusplus.github.io/CWG/issues/2947.html). And clang
checks next pp-token after module name in phase 4.
This PR move the check to phase 7, there are three main motivations:
1. We already convert the module name pp-tokens sequence into a
annot_module_name token, so for the following case, macro expansion will
be disabled.
2. In the original implementation, we need to look ahead a token even if
we already hit an `eod` token, but in phase7, we don't need to look
ahead a token.
3. The original implementation checked and emit a diagnosis in phase 4,
and then skipped these unexpected tokens in phase 7. Now we've merged
them into one step and are able to get a diagnosis approximate as
before.
```cpp
[18 lines not shown]
Revert "[mlir][IR] Add SymbolUserTypeInterface (#198435)" (#217959)
Looking forward to this feature, but the verification cost presently is
much too high: 2-3x+ end-to-end for CIRCT production workloads, as well
as a noticeable bump to MaxRSS. A user has reported their workload is
now 1.85x (#212160).
This verifier performance hit impacts all MLIR projects using the common
SymbolTable regardless of whether they make use of this interface.
Presently there are no in-tree users.
Promising work to reduce this cost (#212160, #212354) is underway, but
neither are ready yet.
Since the entire purpose of this interface is to support this
verification, revert this entirely for now while the performance story
is worked out.
This reverts commit 8c2d7cc3a9983459628c028d8537eaf79551f396.
[lldb][test] Fix 64-bit register assumption in wrapped frame test (#217659)
Added in #216840 / b0e9c530b5f0206de4a4f59f6728dbd5f10a5ca2.
This is failing on our downstream Arm 32-bit Linux bot:
```
* thread #1, name = 'a.out', stop reason = breakpoint 1.1
* frame #0: 0x013d0630 a.out`compute(a=<unavailable>, b=<unavailable>) at main.c:3:10 [synthetic]
frame #1: 0x013d065c a.out`main at main.c:6:25
frame #2: 0xea2b739a libc.so.6`
frame #3: 0xea2b743e libc.so.6`__libc_start_main + 94
frame #4: 0x013d0538 a.out`_start + 40
Expecting sub string: "compute(a=3, b=4)" (was not found)
```
I have not had time to reproduce it locally, but I did notice that the
test packs a struct of registers using `Q` (8 bytes) regardless of
register size.
[6 lines not shown]
[DWARFLinker] Fix getContaingFile typo (NFC) (#217957)
Rename CompileUnit::getContaingFile to getContainingFile and update its
call sites in the parallel DWARF linker.
[CIR] Allow only CIR types in function signatures (#215922)
The calling convention lowering pass expects cir.func operations to
contain only CIR types in the signature. This change adds verifier
support to enforce that.
In the process, I discovered that it wasn't possible to walk the
subtypes of a CIR struct or union. The `AttrTypeSubElementHandler`
implementation to handle that (including the TODO comment) is copied
from the LLVM struct type handling.
Adding tests for this revealed a problem where if the `FuncType`
verifier reports an error, the `FuncOp` parser asserted. This change
fixes that by using `FuncType::getChecked()` to catch and report the
error.
[LLVMABI][AARCH64] Support transparent union arguments (#217686)
This adds support for using the first field in a transparent union for
the purposes of argument classification.
The `useFirstFieldIfTransparentUnion` function was already implemented
for the `X86_64TargetInfo` class. I moved it to the `TargetInfo` base
class because there is nothing target-specific about it.
Assisted-by: Cursor / various models
[llvm-objcopy] Stream ELF output to regular files
Write ELF output directly to seekable regular files instead of first allocating a buffer for the entire output. Keep buffered output for stdout and other non-seekable streams.
Use separate buffered and file-backed output implementations. Serialize regenerated metadata sequentially, seeking once per output range, and report sticky file errors after writing finishes. Truncate and extend seekable output up front so unwritten layout gaps read as zero without being materialized; explicitly overwrite only removed section contents within copied segments.
On a synthetic stamping-style ELF containing a 1 GiB payload, three warm-cache no-op copies had median peak RSS of 2,102,916 KiB before and 1,053,844 KiB after (49.9% lower). Median wall time improved from 1.06 s to 0.77 s, and the outputs were byte-identical.
Co-authored-by: Jeremy Braun <jtbraun at meta.com>
Assisted-by: OpenAI Codex
[Support] Support seekable temporary output streams
Use raw_fd_stream for temporary outputs so callbacks can perform positioned writes and resize the destination. Add raw_fd_ostream::takeError and raw_fd_stream::resize, and return stream failures through Error while preserving an existing destination.
Co-authored-by: Jeremy Braun <jtbraun at meta.com>
Assisted-by: OpenAI Codex
