BSD Commit Log Search

   Use shared socket lock for NFS.

   The socket functions that are called by NFS code are MP safe.
   Shared net lock together with socket lock is sufficient.

   OK mvs@

   remove unneeded includes
   ok miod@ mpi@

   Move solock() down to sosetopt(). A part of standalone sblock() work.
   This movement required because buffers related SO_SND* and SO_RCV*
   socket options should be protected with sblock(). However, standalone
   sblock() has different lock order with solock() and `so_snd' and
   `so_rcv' buffers. At least sblock() for `so_snd' buffer will always be
   taken before solock() in the sosend() path.

   The (*pr_ctloutput)() call was removed from the SOL_SOCKET level 'else'
   branch. Except the SO_RTABLE case where it handled in the special way,
   this is null op call.

   For SO_SND* and SO_RCV* cases solock() will be replaced by sblock() in
   the future.

   Feedback from bluhm

   Tested by bluhm naddy

   ok bluhm

   Simplify solock() and sounlock(). There is no reason to return a value
   for the lock operation and to pass a value to the unlock operation.
   sofree() still needs an extra flag to know if sounlock() should be called
   or not. But sofree() is called less often and mostly without keeping the lock.
   OK mpi@ mvs@

   The kernel interpreted bogus lengths in RPC calls during NFS boot.
   A malicious rpc.bootparamd could corrupt memory, but the kernel has
   to trust the local network anyway in a diskless environment.  Now
   in case of an RPC error, the kernel will stop booting with a specific
   panic.
   OK claudio@ beck@

   Instead of calculating the mbuf packet header length here and there,
   put the algorithm into a new function m_calchdrlen().  Also set an
   uninitialized m_len to 0 in NFS code.
   OK claudio@

   Use FNONBLOCK instead of SS_NBIO to check/indicate that the I/O mode
   for sockets is non-blocking.

   This allows us to G/C SS_NBIO.  Having to keep the two flags in sync
   in a mp-safe way is complicated.

   This change introduce a behavior change in sosplice(), it can now
   always block.  However this should not matter much due to the socket
   lock being taken beforhand.

   ok bluhm@, benno@, visa@

   Pass the socket to sounlock(), this prepare the terrain for per-socket
   locking.

   ok visa@, bluhm@

   Change sosetopt() to no longer free the mbuf it receives and change
   all the callers to call m_freem(9).

   Support from deraadt@ and tedu@, ok visa@, bluhm@

   Move the solock()/sounlock() dance outside of sobind().

   ok phessler@, visa@, bluhm@

   Move the socket lock "above" sosetopt(), sogetopt() and sosplice().

   Protect the fields modifieds by sosetopt() and simplify the dance
   with the stars.

   ok bluhm@

   In kernel initialize struct sockaddr_in and sockaddr_in6 to zero
   everywhere to avoid passing around pointers to uninitialized stack
   memory.  While there, fix the call to in6_recoverscope() in
   fill_drlist().
   OK deraadt@ mpi@

   m_freem() can handle NULL, do not check for this condition beforehands.
   ok stsp mpi

   Store a unique ID, an interface index, rather than a pointer to the
   receiving interface in the packet header of every mbuf.

   The interface pointer should now be retrieved when necessary with
   if_get().  If a NULL pointer is returned by if_get(), the interface
   has probably been destroy/removed and the mbuf should be freed.

   Such mechanism will simplify garbage collection of mbufs and limit
   problems with dangling ifp pointers.

   Tested by jmatthew@ and krw@, discussed with many.

   ok mikeb@, bluhm@, dlg@

   Remove some includes include-what-you-use claims don't
   have any direct symbols used.  Tested for indirect use by compiling
   amd64/i386/sparc64 kernels.

   ok tedu@ deraadt@

   delete a whole mess of unnecessary caddr_t casts

   move arc4random prototype to systm.h. more appropriate for most code
   to include that than rdnvar.h. ok deraadt dlg

   bzero -> memset

   Replace most of our formating functions to convert IPv4/6 addresses from
   network to presentation format to inet_ntop().

   The few remaining functions will be soon converted.

   ok mikeb@, deraadt@ and moral support from henning@

   Manipulate timevals seperately, not inside a mbuf.  Alignment constraints
   miod ran into.
   ok miod matthew

   antsy
   no binary change apart from nfsm_reqhead() which is clearly correct.

   ok thib@

   fix PR 6082: do not create more fd's than will fit in the message on
   the receiving side when passing fd's. ok deraadt@ kettenis@

   make sure the from mbuf gets freed on error to.

   from David <dunnoseriously _att_ gmail.com>
   ok blambert@

   Remove redundant code that only leaked an mbuf.

   ok krw@, deraadt@, thib@

   earlier commit for some reason did not go through
   prodded by nfs buddy

   Introduce a facility to generate unpredictable 32 bit numbers with
   near maximal (2^32) cycle times. These are useful for network
   IDs in cases where there are negative consequences to ID prediction
   and/or reuse.

   Use the idgen32() functions to generate IPv6 IDs and NFS client/server
   XIDs.

   Pseudorandom permutation code in crypto/idgen.c based on public
   domain skip32.c from Greg Rose.

   feedback & ok thib@ deraadt@

   Deal with the situation when TCP nfs mounts timeout and processes
   get hung in nfs_reconnect() because they do not have the proper
   privilages to bind to a socket, by adding a struct proc * argument
   to sobind() (and the *_usrreq() routines, and finally in{6}_pcbbind)
   and do the sobind() with proc0 in nfs_connect.

   OK markus@, blambert@.
   "go ahead" deraadt@.

   Fixes an issue reported by bernd@ (Tested by bernd@).
   Fixes PR5135 too.

   clarify RPC timeout messages so regular people can understand; ok various

   enable receive() accounting and use uio_procp for send() accounting, too
   ok deraadt, jared, djm

   Merge in -current

   allow swaples diskless configs; deradt@ ok