BSD Commit Log Search

   uaudio: Drop UAUDIO_DEBUG defined by mistake in the last commit

   Fixes excessive noise on the console. From weerd@, thanks!

   uaudio: Fix devices that don't support sample rate changes

   Parse the class-specific endpoint descriptor to determine if the
   device supports sample rate changes (i.e. the frequency control
   attribute is set). Then, send the frequency change request only
   to devices that support it.

   For instance this fixes the Dell Slim soundbar that would freeze
   upon a frequency change request.

   With help from Joel Carnat <joel at carnat.net>, thanks!

   spelling; checked by jmc@, ok miod@ mglocker@ krw@

   uaudio: Fix confusion between interface numbers and interface indexes

   There is rare hardware for which the interface numbers and indexes are
   not equal. Such devices couldn't attach because the driver claimed the
   wrong interface.

   Skip interfaces already claimed by other uaudio(4) instances.

   Fixes support of devices that attach multiple uaudio(4) drivers.

   Every uaudio(4) instance parses the full set of device descriptors
   because there are multiple interfaces per driver instance. If there is
   a second uaudio(4) instance (i.e. a second control & stream interfaces
   combo), the latter must skip the interfaces already used by the first
   one (if it didn't, multiple uaudio(4) would try to use the same
   interface and neither would work).

   Help from and ok armani@.

   Return error if the USB request to get the sample rate fails.

   found by mlarkin

   Make audio(9) get_props() optional, remove it from duplex drivers

   The property bits of audio(9) are obsolete and ought to be removed
   completely.

   sys/dev/audio.c:audio_open() currently uses get_props() to bail out if
   read *and* write was requested on a non-duplex driver.

   Drivers that currently support playing but not recording need adjustment
   before the API can be cleaned up.

   Drivers that advertise themselves as full duplex, i.e. those that always
   return AUDIO_PROP_FULLDUPLEX unconditionally in their get_props() currently
   always succeed this check.

   As this is the only property, losen audio_open()'s DIAGNOSTIC check and only
   do the duplex check if the driver provides get_props().

   This allows for simple removal of get_props() from full-duplex drivers

    [15 lines not shown]

   Use C99 struct init for struct audio_hw_if

   This audio(9) struct will lose a member, but drivers init their struct quite
   inconsistently, most pre-C99 style.

   Use C99 style everywhere, to get rid of all annoying differences and allow
   for easy member removals/additions:
   - don't change current order of members
   - no explicit NULL members
   - no comments or blank lines
   - trailing comma in last member line

   GENERIC.MP builds fine with this on arm64, amd64, i386 and sparc64.

   macppc and alpha build-tested by miod
   OK ratchov miod

   Constify global tables only used in lookups, OK ratchov

   Constify struct {audio,midi,radio,video}_hw_if. No functional change.

   ok mpi@ ratchov@ "More const is good" deraadt@

   ambigus -> ambiguous

   Currently, wskbd_set_mixervolume() only adjusts the volume of the first
   attached audio device, i.e. audio0. This approach does not work well
   while using additional audio devices equipped with physical volume keys
   since those would only affect the volume of audio0.

   Instead, correlate audio and ucc devices attached over USB in order to
   adjust the volume of the correct audio device. This is done by passing a
   cookie from the common point of attachment which is later used to
   correlate the audio and wskbd device.

   The same approach could be adopted for audio and wskbd devices attaching
   on a different bus. Keep in mind that it's of importance to make use of
   and increment the same global cookie identifier to avoid collisions.

   Makes the volume keys on my Logitech G435 Headset do the right thing.

   ok ratchov@

   Make room for a cookie argument passed to audio_attach_mi(). Currently
   unused but intended to be used to correlate audio and wskbd devices.

   ok ratchov@

   When it's the possessive of 'it', it's spelled "its", without the
   apostrophe.

   spelling
   feedback and ok tb@ jmc@ ok ratchov@

   spelling
   ok ratchov@

   Align memory allocation for USB device drivers and USB HC drivers:

   * USB device drivers use M_USBDEV instead of M_DEVBUF.
   * USB HC drivers use M_USBHC instead of M_DEVBUF.

   In a vanilla setup, this enlarges the USB memory pool.

   ok anton@

   Add pre-DMA-write barrier after data is stored to memory

   There's already such a barrier in usbd_transfer() code-path, but this
   one is called when the frames are queued to the HC ring. The audio
   samples are stored in memory by userland later, *after* the frames are
   scheduled (but before they are sent on the wire) so a barrier is
   needed there. Without this change, the data produced by userland may
   stay in the CPU caches and is not "seen" by the HC's DMA engine, in
   turn the device plays noise on certain arm64 machines (RPI4, for
   instance).

   Fix mostly from Luca Castagnini with few tweaks from me. OK patrick@

   When detaching uaudio, wait for device ref counter to drop to 0

   To maintain the correct refs count, blocking calls to uaudio are
   wrapped in usbd_ref_incr() and usbd_ref_decr() calls.

   suggested by mpi@ and ok visa@

   Remove redundant code testing if a terminal is a usb stream.

   Fixes coverity CID 1492830.

   ok sthen, deraadt

   If there's only one input (output) name it simply "input" ("output")

   Besides making things simpler, this allows libsndio to figure out that
   this is a control affecting all inputs (outputs) that needs to be
   exposed.

   Use "inputs" class instead of "record"

   There's no reliable way to decide whether a control must belong
   to "inputs" or to "record". In other words both classes were
   used for the same thing. Furthermore we've no "play" class which
   tends to make things more confusing.

   Use "dac" instead of "play" in mixer control names

   All other drivers use "dac" and libsndio needs the control name to
   be "dac" for the control to be exposed.

   Set terminal and clock names after all units are parsed

   Makes the code simpler and more flexible as the naming is done in a
   single place where the full units list is available.

   Use macros instead of hardcoded "play" and "record" string constants

   No object change.

   Skip "all-channels" controls if there are equivalend per-channel ones

   Hardware may expose per-channel controls and equivalent ones affecting
   all channels, which is redundant. In this case expose only the
   per-channel ones as they are more flexible.

   Suffix per-channel non-numeric controls with channel number

   The audio(9) mixer API can't represent such per-channel controls with
   a single entry, so we've to expose one mixer entry (with an unique
   name) per control.

   Fixes name clashes on usb audio devices with per-channel mute
   controls.

   If samples per frame is larger than the device usb packet size,
   fail early in uaudio(4).  This prevents negative safe_blksz and
   integer overflow in nframes_max in case of a bad call to
   uaudio_stream_open() or a hardware bug.
   OK ratchov@

   If an USB audio device supports less rates for recording than for
   playing, the uaudio(4) driver selected a wrong rate.  Then recording
   failed with "block size too large".  The v1_rates field of the
   parameters contains the correct intersection of valid rates.  Use
   it for v1 devices.
   OK ratchov@

   Fix use of uninitilized variable in case of emty AC descriptor.

   USB audio devices with empty AC descriptor (i.e. emtpy devices) don't
   exist as they would be of no use. So this fix is mostly to properly
   skip broken hardware.

   Found by coverity.