nrelease: Simplify the setting of disklabel packid/label
The packid (i.e., label name) can be directly set upon the label
creation; no need to edit the disklabel dump file.
pc64: Remove duplicate defines *_SLICE
Code that requires these defines should include <sys/diskslice.h>. For
example, 'stand/boot/pc32/boot2/boot2.c' already did this.
kernel: Fix GPT partition start/end check in gptinit()
The GPT partition ending LBA is inclusive, so it's valid to have a GPT
partition with start == end, i.e., the partition size is 1 block. Fix
gptinit() to support this case. In addition, improve the kprintf()
debug message to show the value of start and ending LBAs.
<sys/diskslice.h>: Fix a comment in 'struct partinfo'
The 'GPT_ENT_TYPE_DRAGONFLY_DISKLABEL32' macro should be
'GPT_ENT_TYPE_DRAGONFLY_LABEL64', as defined in <sys/gpt.h>.
<sys/diskslice.h>: Improve comments for MAX_SLICES
While there, fix the comment for COMPATIBILITY_SLICE, which should be
'<disk>s0' on DragonFly (at least since many years ago).
bsd.kern.mk: Always set '-Wno-unused-but-set-variable'
The check was useful for GCC <4.7, which we no longer has, so just
remove the unnecessary check and always set
'-Wno-unused-but-set-variable'.
Discussed-with: swildner
bsd.{sys,kern}.mk: Fix syntax error in pattern 'gcc[5-]*'
If ${_WCCVER} doesn't match the 'gcc[5-]*' pattern, bmake would generate
this fatal error:
```
Unfinished character list in pattern 'gcc[5-]*' of modifier ':M'
while evaluating variable "_WCCVER" with value "gcc100"
make: Fatal errors encountered -- cannot continue
```
Interestingly, this pattern works as expected if there is match. This
is because bmake matches the pattern along the parsing; it doesn't
validate the pattern syntax before matching it. The bmake code requires
that both the range begin and end be specified. So this is actually a
bug in the bmake code. See also contrib/bmake/str.c:Str_Match().
Reported-by: sparlane (IRC)
Discussed-with: swildner
bsd.{sys,kern}.mk: Fix syntax error in pattern 'gcc[5-]*'
If ${_WCCVER} doesn't match the 'gcc[5-]*' pattern, bmake would generate
this fatal error:
```
Unfinished character list in pattern 'gcc[5-]*' of modifier ':M'
while evaluating variable "_WCCVER" with value "gcc100"
make: Fatal errors encountered -- cannot continue
```
Interestingly, this pattern works as expected if there is match. This
is because bmake matches the pattern along the parsing; it doesn't
validate the pattern syntax before matching it. The bmake code requires
that both the range begin and end be specified. So this is actually a
bug in the bmake code. See also contrib/bmake/str.c:Str_Match().
Reported-by: sparlane (IRC)
Discussed-with: swildner
