[Attributor][NFC] Only look for callback arguments of call site arguments (#240912)
`getArgNo` looked for a callback callee argument for every position
kind, e.g. for the attribute index of every argument.
Only call site arguments can map to a different argument.
Attributor passes on CTMark files, on top of the other pending
Attributor compile-time changes: -0.1% to -0.4% instructions.
Co-authored-by: Matt Arsenault <Matthew.Arsenault at amd.com>
Co-authored-by: Shilei Tian <i at tianshilei.me>
Assisted-by: Claude Opus 5.5
[Offload][AMDGPU] Return the real user count from getUserCount (#241301)
This patch fixes the return type of AMDGPUQueueTy::getUserCount, which
currently returns bool: that collapses the count to 0 or 1, which upsets
the occupancy measurement in assignNextQueue.
A new test checks that work is queued appropriately across hardware
queues.
Assisted-By: Claude
Record the info of functions defaulted outside class templates
A function defaulted outside its class template returned from
SetDeclDefaulted before it recorded the floating-point features in
effect at its definition. Its instantiation then had no info to reuse
and took the features in effect at its point of instantiation instead,
which also crashed codegen when those were strict but the function was
not.
Always record the info for such a pattern, so that its instantiation
reuses it. Also don't record it twice for a postfix operator defaulted
under non-default floating-point features: its info, including those
features, is recorded along with the lookup of its prefix operator.
[clang][C23] Delay thread storage recovery for constexpr diagnostics (#236758)
When a thread storage specifier conflicts with another storage class,
DeclSpec clears it before diagnosing a C23 constexpr conflict. The
second diagnostic then reports "unspecified" and loses the specifier's
source range.
For a block-scope declaration:
Before:
```
a:2:22: error: cannot combine with previous 'register' declaration specifier
2 | constexpr register _Thread_local int x = 1;
| ~~~~~~~~ ^
a:2:3: error: cannot combine with previous 'unspecified' declaration specifier
2 | constexpr register _Thread_local int x = 1;
| ^
2 errors generated.
```
[13 lines not shown]
[Offload][AMDGPU] Return the real user count from getUserCount
This patch fixes the return type of AMDGPUQueueTy::getUserCount, which
currently returns bool: that collapses the count to 0 or 1, which upsets
the occupancy measurement in assignNextQueue.
A new test checks that work is queued appropriately across hardware
queues.
Assisted-By: Claude
[clang][Sema][NFC] Consolidate checking for vector reduction builtins (#238663)
Share argument conversion, element type extraction, and result type
assignment across the single-argument reduction builtins. Preserve each
builtin's element type restrictions and diagnostics, and reuse
getVectorElementType for fixed-size and sizeless vectors.
[NFC][OpenMP] Track Fortran OpenMP support status only in the Flang docs (#240917)
The Clang OpenMP support page had a "Fortran Status" column in its 5.2,
6.0 and 6.1 tables that was not kept up to date with the Flang page. For
OpenMP 5.2 alone it disagreed with flang/docs/OpenMPSupport.md on 13
rows (e.g. "if clause on teams", "otherwise clause" and "pure procedure
support" were listed as unclaimed for Fortran but are done in Flang).
Make the Flang page the only place Fortran status is recorded. The Clang
page now covers Clang (C/C++) and the LLVM OpenMP runtimes, whose status
applies to both languages.
[Offload][AMDGPU] Return the HSA queue as a queue's native handle (#241300)
Implement getNativeQueueHandle (introduced by #234186) for AMDGPU, so
that olGetQueueInfo can report OL_QUEUE_INFO_NATIVE_HANDLE for an AMDGPU
queue instead of UNSUPPORTED. The handle is the hsa_queue_t the queue's
stream is bound to; a stream is bound on first use, so querying binds
one if necessary. Several streams may share an HSA queue, in which case
their queues report the same handle.
Assisted-By: Claude
[libc] Use a syscall wrapper for symlinkat (#241205)
This PR move symlinkat behind the centralized syscall wrappers,
following libc/docs/dev/syscall_wrapper_refactor.md.
[libc] Use a syscall wrapper for symlink (#241204)
This PR move symlink behind the centralized syscall wrappers, following
libc/docs/dev/syscall_wrapper_refactor.md.
[libc] Use a syscall wrapper for linkat (#241203)
This PR move linkat behind the centralized syscall wrappers, following
libc/docs/dev/syscall_wrapper_refactor.md.
[libc] Use a syscall wrapper for getsid (#241202)
This PR move getsid behind the centralized syscall wrappers, following
libc/docs/dev/syscall_wrapper_refactor.md.
[libc] Ignore `-Wliteral-range` in FP tests that deliberately use out-of-range literals (#237261)
Some checks in `sprintf_test.cpp` use `long double` literals that are
out of the type's usual range of 64-bit long double on purpose to test
that they are parsed to "inf" and the likes.
C23 §5.2.5.3.3 ¶19 and §F.2.2 ¶1 state that if infinity is supported
then the range of representable values is extended to cover all real
numbers with the same sign of that infinity. The need for a diagnostic
message is less clear however. The standard requires a diagnostic if the
constant falls outside the range, but in this case it doesn't because
the range is extended.
In any case, clang does emit a diagnostic warning, which gets in the way
of builds that treat warnings as errors.
This patch silences the warnings in these cases. The ultimate goal is to
re-enable `-Werror` in 32-bit builds.
[AMDGPU] IGLP: introduce instruction cache and fix static variables (#237774)
Replace global / class-level static variables with a small cache that is
directly attached to the iglp pseudo instruction.
This has been suggested in
https://github.com/llvm/llvm-project/pull/137549#discussion_r3076970527
and the following comment in that thread.
Note that this patch is intended to be NFC and doesn't fix broader
issues with the analysis re-use.
Some tests have been stolen from
https://github.com/llvm/llvm-project/pull/232728.
Claude assisted with this patch.
[AArch64] Load CC-widened vector stack arguments as their value type (#237946)
A CC-widened vector argument (<N x i1>, odd Lane counts like <3 x i32>)
passed on the stack was loaded as its bitconverted LocVT instead of the
CC value type, producing a part of the wrong type for getCopyFromParts –
a crash or silently wrong values, on either end for <3 x float>. Load
the value type instead; the memory image is the same either way.
Fixes #237850
[CHR] Don't attempt to fixup selects we can't handle (#236454)
CHR attempts to merge selects with integer and vector typed condition
without type verification, which triggers assertion in some LTO + PGO
builds.
[flang] Keep switch successor operand counts in sync (#234126)
FIR switch operations fail to update target_operand_offsets when
successor operands are added or removed through MutableOperandRange.
Declare the attribute in ODS so it can be updated by setInherentAttr,
which MutableOperandRange has used since ad9dc60252ed (#218907).
Add regression tests for operand insertion and removal.
[LifetimeSafety] Analyze blocks that cannot reach the exit in liveness (#240890)
The backward liveness analysis was seeded only at the exit block, so
blocks that cannot reach it, e.g., the body of an infinite loop, were
never analyzed and uses in them were missed.
Fixes #222273
Assisted-by: Claude Opus 5.5
Co-authored-by: Gabor Horvath <gaborh at apple.com>
[mlir][vector] Don't drop out-of-bounds leading unit dims of transfers (#239699)
`CastAwayTransferReadLeadingOneDim` and
`CastAwayTransferWriteLeadingOneDim` drop the leading unit dims of a
transfer and keep `in_bounds` only for the remaining dims. A dropped dim
becomes a non-vector dim, and those must always be in bounds, so an
out-of-bounds leading unit dim was lost:
```mlir
%r = vector.transfer_read %A[%i, %j], %pad {in_bounds = [false, true]} : memref<?x?xf32>, vector<1x4xf32>
```
became
```mlir
%0 = vector.transfer_read %A[%i, %j], %pad {in_bounds = [true]} : memref<?x?xf32>, vector<4xf32>
%r = vector.broadcast %0 : vector<4xf32> to vector<1x4xf32>
```
[5 lines not shown]
[libc++][pstl] Added tests for corner cases of calling __apply() (#240398)
Add a couple of tests that check non-trivial usage of
`__apply()`, which is not currently covered by any of "conventional"
PSTL tests. Any parallelism provider behind `__apply()` must allow for
these tests to pass, so that the overall PSTL offering is sound.
Added tests include:
- Calling `__apply` before the `main` function has started.
- Calling `__apply` after the `main` function has finished.
- Calling `__apply` concurrently from multiple threads.
- Calling `__apply` recursively and fanning out, nesting up to three
levels.
- Calling `__apply` recursively, nesting up to ten levels.
- Calling `__apply` recursively while holding a mutex.
[libc][stdfix] Implement expuhk and expuk functions (#240631)
Implement `expuhk` and `expuk` functions with unit tests.
```c
unsigned short accum expuhk(unsigned short accum);
unsigned accum expuk(unsigned accum);
```
[MLIR][Vector] Fix ShapeCastBroadcastFolder when shape_cast changes non-unit dim strides (#227574)
### Summary
`ShapeCastBroadcastFolder` previously checked whether
`vector.shape_cast(vector.broadcast)` could be folded into a single
`vector.broadcast` by comparing the scalar product of stretched unit
dimensions (`getBroadcastStretchingFactor`).
However, a single scalar product is insufficient when `srcShape` has
multiple unit dimensions across different sides of a non-unit dimension,
and the `shape_cast` shifts the broadcast factor from an inner unit
dimension to an outer unit dimension.
For example:
```mlir
%0 = vector.broadcast %arg0 : vector<1x4x1xf32> to vector<1x4x4xf32>
%1 = vector.shape_cast %0 : vector<1x4x4xf32> to vector<4x4x1xf32>
```
[26 lines not shown]
[clang-tidy] Fix false negative for binary logical expressions for tw… (#230846)
Fixes #230601
This PR addresses the false-negative scenario where
`bugprone-redundant-branch-condition` fails to trigger on simple
two-variable logical conjunction expressions (e.g., `if (x && y) { if
(y) ... }`).
Note: This is a partial fix. As noted in the code's `// FIXME` comments,
handling longer conjunctive and disjunctive chain clauses (3 or more
variables) requires further extension is not yet touched.
---------
Co-authored-by: EugeneZelenko <eugene.zelenko at gmail.com>
Co-authored-by: Zeyi Xu <zeyi2 at nekoarch.cc>
[llvm-dwarfdump] Fix --error-display=summary and --error-display=quiet (#234308)
Before the patch `--error-display=summary` printed every error in detail
and no summary, and `--error-display=quiet` printed the aggregated
summary.
This patch adds `DIDumpOptions::ShowErrorDetails` to control per-error
output, and make `DIDumpOptions::ShowAggregateErrors` switch only the
"Aggregated error counts" summary. `DIDumpOptions::ShowErrorDetails`
defaults to true, so other DWARFVerifier users keep printing details.
Verbose no longer affects which verifier output is printed.
`llvm-dwarfdump --verify` sets `Verbose = true` unconditionally again,
and it only selects the format of the DIEs dumped in error details.
The duplicate .debug_line file name warning, which was gated on Verbose
to keep it out of the summary and quiet modes, is now gated on
ShowErrorDetails. As a consequence, dsymutil, DWARFLinker and
llvm-dwarfutil, which verify with default options, report this warning
[2 lines not shown]
