[lldb][Windows] Fix "Invalid register name" for eax on x86_64 attach (#203498)
On Windows, when attaching to a process with no pre-existing target,
lldb reports "Invalid register name" for sub-registers like eax.
This is due to a bug in `ABIX86::AugmentRegisterInfo`, which determines
the GPR base size by reading
`Target::GetArchitecture().GetAddressByteSize()`. During attach, the
target's architecture has not yet been set when `AugmentRegisterInfo`
runs, so the lookup returns 0, the process is treated as 32-bit, and the
x86_64 sub-registers are never added.
This patch removes the dependency on the target's architecture: the X86
ABI plugins already know their own bitness, so `ABIX86_64` and
`ABIX86_i386` now report it directly via a new `Is64Bit()` virtual.
This patch fixes
`TestRegisters::test_convenience_registers_with_process_attach` and
`TestRegisters::test_convenience_registers_16bit_with_process_attach` on
[2 lines not shown]
[flang][openacc] Fix DEFAULT(NONE) errors for array sections (#204248)
ResolveAccObject skipped DSA registration when
GetDesignatorNameIfDataRef returned nullptr (i.e. for subscripted
designators like copyin(a(1:n))). The DEFAULT(NONE) post-visitor then
found the base variable unregistered and emitted a false error even
though it was explicitly listed in a data clause.
Unify the path using GetFirstName, which extracts the base symbol from
both bare data references and array sections. Continue not registering component references. This will need to be followed up with more accurate designator checking in the near future.
[Clang][SYCL] Remove unnecessary null pointer check (#206813)
Static analysis identified a null pointer check in a control flow path
that unconditionally dereferences the checked pointer. This patch
removes the unnecessary check.
[lldb] Remove ConstString getters from FileSpec (#206802)
This finishes the removal of ConstString from FileSpec's interface. Note
that FileSpec is still _backed_ by ConstStrings, that will be changed in
a follow-up.
A non-goal for this change is to rewrite business logic, so I kept the
type of some variables as ConstString where a refactor would necessary
to change that. I converted printf-style formatting to formatv-style
formatting where required, and otherwise tried to leave callsites alone
to the extent that was possible.
[flang][OpenMP][NFC] Move variant-matching context to semantics
Move FlangOMPContext from lower into semantics as the MLIR-independent
OmpVariantMatchContext. This enables reuse of the matcher for upcoming
semantic checks that can skip metadirective variant validation when a
variant cannot match the current target.
Assisted with copilot.
[CIR] Skip int_to_bool when value is already bool (#206582)
A conversion to bool from a type whose representation is already boolean --
most commonly an enum with a `bool` underlying type -- reaches
`emitIntToBoolConversion`, which always emits `cir.cast int_to_bool`. Since
[#205880](https://github.com/llvm/llvm-project/pull/205880) made such enums
load as `!cir.bool`, that cast now receives a `!cir.bool` source and the
`int_to_bool` verifier (which requires a `!cir.int` source) rejects the
module. It shows up across the libcxx `std/` hash tests, whose shared
`poisoned_hash_helper.h` hashes an `enum : bool` by `static_cast`-ing it to
its underlying type.
The fix returns the value unchanged when it is already `!cir.bool`: a boolean
is its own truth value, so no conversion is needed. The guard sits in
`emitIntToBoolConversion`, the choke point shared by the
`CK_IntegralToBoolean` cast path and the integer branch of
`emitConversionToBool`. This is the cast-side companion to
[#205880](https://github.com/llvm/llvm-project/pull/205880), which handled
the load side.
[2 lines not shown]
[CIR] Lower add/sub-with-carry builtins (#206598)
[CIR] Lower add/sub-with-carry builtins (#206598)
The multiprecision add/sub-with-carry builtins -- `__builtin_addc{b,s,,l,ll}`
and `__builtin_subc{b,s,,l,ll}` -- were stubbed with errorNYI in CIRGen, so
any translation unit that uses them fails to compile. They are used by
128-bit fallback arithmetic in libraries such as libfmt (its
`uint128_fallback` add path calls `__builtin_addcll`).
The lowering mirrors classic CodeGen in `CGBuiltin.cpp`: emit two chained
checked-overflow operations (`sum1 = x +/- y`, then `result = sum1 +/-
carryin`), OR the two overflow flags for the carry-out, widen that to the
operand type, and store it through the carry-out pointer. CIR already has
the checked-overflow ops that `__builtin_add_overflow` uses
(`AddOverflowOp` / `SubOverflowOp`), so this reuses that path rather than
adding anything new.
The new `builtin-multiprecision.c` exercises add and sub across i8/i32/i64
and checks both the CIR ops and the lowered unsigned
`uadd`/`usub.with.overflow` form against classic CodeGen.
[ORC] Add InProcessEPC: orc_rt::InProcessControllerAccess partner. (#206725)
Adds an ExecutorProcessControl implementation for in-process JIT setups
that use the new ORC runtime (orc-rt). This is the LLVM-side partner of
orc_rt::InProcessControllerAccess (introduced in d1744cf76fbe) and is
intended to be constructed from orc_rt::InProcessControllerAccess's
OnConnect callback.
The two sides communicate through a shared refcounted C-ABI Connection
struct exchanged at connect time: the fields intended for use by the
controller side are populated by InProcessControllerAccess before
OnConnect fires, and the fields intended for use by the executor side
(IPEPC pointer, CallJITDispatch, ReturnWrapperResult) are populated by
InProcessEPC::Create. A parallel BootstrapInfoAccess struct exposes
page-size, target triple, and bootstrap key/value and symbol iterators
across the same C-only boundary.
Create returns an Expected<std::unique_ptr<InProcessEPC>> and reports
errors for missing page-size, missing triple, duplicate bootstrap keys,
[13 lines not shown]
[clang] __has_feature(modules) should only be true for Clang modules (#206199)
Before this patch `__has_feature(modules)` is true for any compilation
with `-std=c++20` as it was trigged by `LangOpts.Modules`. This is
unexpected and breaks some usages of `__has_feature(modules)`, which is
intended to only be true when Clang modules are in use. Public code
contains many examples of the form:
```
#if __has_feature(modules)
@import Foundation;
#else
#import <Foundation/Foundation.h>
#endif
```
which will never work if module maps are not in use, but is still
evaluated as true.
[10 lines not shown]
[VPlan] Extract IV exit value from vector loop if predicates are needed. (#200020)
When an IV needs predicates (e.g. to make sure it does not wrap in a
narrower range), the precomputed end value would use the inductions
narrowed step, which can lead to incorrect results for the exiting value
outside the loop. For example consider a loop where IV has a predicate
to not wrap in i16 with the top 16 bits stripped (something like
https://llvm.godbolt.org/z/nzfoWbcEG).
Building on top of tracking the predicates per-IV
(https://github.com/llvm/llvm-project/pull/192876), we can simply
extract the exit values from the vector values in the loop.
Depends on https://github.com/llvm/llvm-project/pull/192876
PR: https://github.com/llvm/llvm-project/pull/200020
[lldb] Add accelerator plugin connection support (#201449)
Summary
This builds on the accelerator plugin protocol
(https://github.com/llvm/llvm-project/pull/201489) by letting a plugin
ask the client to create and connect a second
target — the mechanism a real backend (e.g. a GPU debug stub) uses to
surface
the accelerator alongside the CPU process being debugged.
### What this adds
**Protocol** — a new `AcceleratorConnectionInfo` describing how the
client
should bring up the accelerator target.
**Client** — when an `AcceleratorActions` carries `connect_info`,
`ProcessGDBRemote` creates a new (empty) target, reverse-connects it to
[143 lines not shown]
[SandboxVec][PassBuilder] Add support for RegionPass aux args (#205643)
Pass auxiliary string arguments are used as a way to pass additional
information to a pass upon construction, which can be particularly
helpful with passes that support more than one mode/functionality.
You can specify an aux argument in the pass pipeline using the syntax:
`<pass>(<aux arg>)`.
FunctionPass already supports aux arguments (and are used in the
SeedCollection pass). This patch adds support for RegionPass too.
To help with testing this I modified the NullPass to add the ability to
echo the aux arg.
Revert "[lldb] Move common functionality out of Itanium ABI runtime (#191275)" (#206816)
This reverts commit 0f51760a342cd8fed1c657e6ca134097c9e8f88c.
A test fails with the commit
(https://github.com/llvm/llvm-project/pull/191275#issuecomment-4846936554):
```
Traceback (most recent call last):
File "/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/functionalities/scripted_frame_provider/TestScriptedFrameProvider.py", line 596, in test_python_source_frames
self.assertNotIn("0xffffffffffffffff", output.lower())
AssertionError: '0xffffffffffffffff' unexpectedly found in "* thread #2, name = 'a.out', stop reason = breakpoint 1.1\n * frame #0: compute_fibonacci at python_helper.py:7 [synthetic]\n frame #1: process_data at python_helper.py:16 [synthetic]\n frame #2: main at python_helper.py:27 [synthetic]\n frame #3: 0x0000badc2de81358 a.out`thread_func(thread_num=0) at main.cpp:44:13\n frame #4: 0x0000badc2de81f9c a.out`void std::__invoke_impl<void, void (*)(int), int>((null)=__invoke_other @ 0x0000f1555ebae74f, __f=0x0000badc66845ec0, __args=0x0000badc66845eb8) at invoke.h:61:14\n frame #5: 0x0000badc2de81f18 a.out`std::__invoke_result<void (*)(int), int>::type std::__invoke<void (*)(int), int>(__fn=0x0000badc66845ec0, __args=0x0000badc66845eb8) at invoke.h:96:14\n frame #6: 0x0000badc2de81ee4 a.out`void std::thread::_invoker<std::tuple<void (*)(int), int>>::_m_invoke<0ul, 1ul>(this=0x0000badc66845eb8, (null)=_index_tuple<0ul, 1ul> @ 0x0000f1555ebae7af) at std_thread.h:259:13\n frame #7: 0x0000badc2de81e98 a.out`std::thread::_invoker<std::tuple<void (*)(int), int>>::operator()(this=0x0000badc66845eb8) at std_thread.h:266:11\n frame #8: 0x0000badc2de81d70 a.out`std::thread::_state_impl<std::thread::_invoker<std::tuple<void (*)(int), int>>>::_m_run(this=0xffffffffffffffff) at std_thread.h:211:13\n frame #9: 0x0000f1555ef029cc libstdc++.so.6`___lldb_unnamed_symbol_d29b0 + 28\n frame #10: 0x0000f1555ec30398 libc.so.6`___lldb_unnamed_symbol_800c0 + 728\n frame #11: 0x0000f1555ec99e9c libc.so.6`___lldb_unnamed_symbol_e9e90 + 12\n"
```
I don't know why this test fails with the PR, but I don't have time to
fix it now, so revert it to unblock CI.
The backtrace was
```
[14 lines not shown]
