[lldb][NativePDB] Implement FindFunctions with a regular expression (#233467)
`SymbolFileNativePDB::FindFunctions(const RegularExpression &, ...)` is
an empty stub, so regex breakpoints never find a `Function` and fall
back to the symbol table. Symbols carry no language, so a breakpoint's
language filter cannot find anything
(`BreakpointCreateByRegex("func_from", eLanguageTypeC_plus_plus)`
resolves to both the C and the C++ function).
This patch matches the regex against the function basenames and full
names (which also contain the mangled names), as `SymbolFileDWARF` does
with its index.
Fixes `TestBreakpointLanguage` with PDB.
rdar://190426286
[mlir][tosa] Don't broadcast non-constant mul shift and negate zero points (#233121)
When the `tosa.mul` shift or the `tosa.negate` zero points are not
constants,
the TosaToLinalg lowering passed them to the elementwise broadcasting
helpers,
which assume every operand has the rank of the input. These operands are
always
`tensor<1xT>`, so the lowering asserted for rank-0 inputs, for dynamic
shapes,
and for inputs with a size-1 dimension after the first (e.g. `3x1`).
Separately, when only one negate zero point was non-constant, the body
read both
zero points as block arguments although neither was passed to the
`linalg.generic`.
This patch keeps these single-element operands out of broadcasting and
passes
them to the `linalg.generic` with an indexing map that always reads
element 0.
[12 lines not shown]
[clangd][NFC] Add regression coverage for current clang-tidy integration (#231461)
While moving clang-tidy into a FeatureModule, I found coverage gaps that
made it easy to accidentally change existing behavior.
This PR adds several tests to address this gap to make sure following
clang-tidy integration move into feature module won't lead to any
regressions.
The following functionalities are covered with with tests from this PR:
- Compiler warnings with no tidy checks enabled: `NOLINT` and
`WarningsAsErrors` must not affect them.
- Warning options from `clang-tidy` configuration: both `ExtraArgs` and
`ExtraArgsBefore` lists must affect warnings emitted during frontend
initialization.
- Configuration lookup: use `clangd`s requested filename, even when the
frontend input has a relative or different spelling.
- Consumer initialization: running `clang-tidy` must not reinitialize an
already initialized AST consumer.
These changes prepare moving the clang-tidy implementation into a
[2 lines not shown]
[libc] Enable baremetal Armv7-M pre-merge tests
The tests are run using QEMU system emulation on AArch64 GitHub runners.
No strong reason to use AArch64 instead of x86_64 as it is via emulation
anyway. But AArch64 runners are cheaper, so that might prove beneficial.
[libc] Application and testing support in baremetal Armv7-M CMake cache file
This patch adds support for linking and running applications, including
tests, targeting baremetal Armv7-M to the corresponding CMake cache
file.
The cache file takes into consideration if compiler-rt is enabled or
not. If it is, then linking applications is possible, and the relevant
CMake variables are set to enable test runs. If not, then only the libc
build is possible and enabled.
Particular libc configuration options, memory mappings, and QEMU options
are based on what Arm Toolchain for Embedded uses in its fully working
downstream testing.
[libc] Add qemu-system-arm to libc Dockerfile for Arm baremetal testing
This patch adds `qemu-system-arm` to the packages installed into the
Docker image so that we can run Arm baremetal tests.
It is only installed on the AArch64 platforms because we intend to run
the tests on AArch64 GitHub runners. Therefore there is no need to
install on x86_64.
[lldb][NativePDB] Parse static variables declared in functions (#230561)
A static or `thread_local` variable declared in a function is an
`S_LDATA32`/`S_LTHREAD32` record in the scope of its procedure (or
block) in the module stream. `ParseVariablesForBlock` only handles
locals, register/frame-relative records and constants, so these
variables don't exist (`fr v static_var` fails).
This patch creates a static (or thread-local) variable owned by the
enclosing block for those records, with the same location expression as
a global.
Fixes `TestGetVariables` with PDB debug info.
rdar://190424226
[lldb][test] Fill out tsan-suppressions.txt with bot failures (#234155)
With this suppressions file, the bot should turn green and can actually
serve its purpose of prevent further regressions.
I decided to add both optimized and unoptimized markers as it only seems
to be necessary for one race. If this will become necessary for more
tests, then I think we need to come up with a policy where we only
maintain this file for unoptimized builds.
assisted-by: claude
[SCEV] Derive x >=s 0 from x <u y and y <=u 2^(n-1)
Let n be the bit width of x and y. If x <u y and y <=u 2^(n-1), then
x <u 2^(n-1), so x >=s 0. Here y <=u 2^(n-1) means y >=s 0 or
y == INT_MIN. In the same way, if x <=u y and y <u 2^(n-1), then
x >=s 0.
This lets a guard like x <u len prove x >=s 0 when len is non-negative.
Co-Authored-By: Claude Opus 5.5 <noreply at anthropic.com>
[SCEV] Prove signed/unsigned implications in either operand order
SCEV could prove these implications only with the operands in the same
order:
- If a <u b and a, b have the same sign, then a <s b.
- If a <s b and a, b have the same sign, then a <u b.
- If a <u b and b >=s 0, then a <s b.
- If a <s b and b <s 0, then a <u b.
For example, it proved a <s b from a <u b and b >=s 0, but not b >s a.
Now it proves them in either order.
Co-Authored-By: Claude Opus 5.5 <noreply at anthropic.com>
[SCEV][NFC] Factor isImpliedCondViaSignFlippedPred out of isImpliedCondBalancedTypes
Move the code that proves a condition from a found condition with the
other signedness into a new private function.
Co-Authored-By: Claude Opus 5.5 <noreply at anthropic.com>
[mlir][affine] Fix SuperVectorizer crash on uniforms from multi-result ops (#234531)
`registerValueVectorReplacement` registered the defining op of a uniform
as replaced by its broadcast, which led to an assert when said op had
several results. Since the defining op is outside the vectorized loop
and not replaced, only register the value replacement.
Fixes an assert on e.g.:
```mlir
// mlir-opt -affine-super-vectorize="virtual-vector-size=128"
func.func @uniform_multi_result(%in: memref<512xi32>, %a: i32, %b: i32) {
%sum, %overflow = arith.addui_extended %a, %b : i32, i1
affine.for %i = 0 to 512 {
%ld = affine.load %in[%i] : memref<512xi32>
%add = arith.addi %ld, %sum : i32
}
return
}
```
Reland "[mlir] Fix false positive loops in RegionBranchOpInterface::hasLoop"
Relands #233784, reverted in #234573 because it broke two CIR unit
tests.
Those tests expected hasLoop() to be true for cir.await and
cir.coroutine, although neither has a cycle: resume is reachable from
ready both directly and through suspend, and the coroutine reaches exit
and destroy along several paths. That was the false positive this change
fixes. The relanded change updates both expectations to false.
Original description:
`RegionBranchOpInterface::hasLoop` reported a loop whenever its
traversal popped a region it had already visited. The worklist gets one
entry per successor of each terminator, so a region reachable along two
paths was popped twice even without a cycle, for example when two
terminators of a region branch to the same successor region.
[8 lines not shown]
[IRBuilder] Remove insertion block (#234245)
The insertion point already stores the block it belongs to, so we should
not be storing a separate insertion block.
Removing this requires some fixes, because there are a few places where
the insertion point gets invalidated, and the insertion block is still
accessed afterwards. In cases like this, we should save the insertion
block before iterator invalidation occurs.
Completes the work started in
https://github.com/llvm/llvm-project/pull/228117.
[SCEV] Try other implications when sign-flipped ones fail
SCEV's isImpliedCondBalancedTypes tries to prove an implication
through several rules. There are rules for when a predicate to prove
is sign-flipped from the found predicate, and also there are other
rules, which, for example, try to prove the implication through
ranges.
Before, if a proof for a sign-flipped rule implication returned false,
we wouldn't check other rules and just bail out with false result too.
Now make those rules fall-through - if one rule couldn't be proven,
try other rules in the function.
An example query is x - 5 <s 5 with x <u 10 known.
The implication "a <u b and b >=s 0 --> a <s b" matches it,
but x - 5 <u 5 with x <u 10 known does not hold (e.g. x = 0),
so SCEV gave up.
[5 lines not shown]
[Loads] Avoid exit when mul/shl look-through fails (#234564)
Fixes a logical error introduced by #222574 where
decomposeLinearExpression would exit early if mul/shl look-through fails
to find a match.
In this fix, we instead avoid applying the constant index scale factor
to VarIndex.
[clang-repl] Emit an AMDGPU object for the HIP device module (#234498)
This PR adds code generation to the `IncrementalHIPDeviceParser`. It
takes the last PTU's device module and converts it into an AMDGPU device
object in the memory. `GenerateOffloadBinary()` is updated to call it
and after that it returns the same error as before.
[clang][CodeGen] Emit return after musttail call to noreturn function
A musttail call to a noreturn function (`__attribute__((noreturn))`,
`_Noreturn`, `exit()`, `longjmp()`, ...) gets `unreachable` after it
instead of `ret`, which fails the verifier with "musttail call must
precede a ret". Release builds skip the verifier, so -O2 crashes with
"failed to perform tail call elimination on a call site marked musttail"
and -O0 silently emits a regular call. Sema only rejects `[[noreturn]]`
callees (#77727), so all other spellings get through.
Implicit musttail calls produce the same invalid IR: `swiftasynccall`,
and the `-fptrauth-calls` thunk for a pointer to a noreturn virtual
member function. The latter crashes even at -O0, without any `musttail`
in the source.
The noreturn path in `EmitCall` runs before the musttail one. This patch
skips it for musttail calls, so they get a `ret` like any other musttail
call. As a side effect, the musttail checks there (e.g. the noexcept
mismatch error) now apply to noreturn callees too.
[15 lines not shown]
[LSR] Refine equality loop exit replacement
Add coverage for an exit count that reaches the recurrence period.
Simplify cleanup of the replaced comparison.
Assisted-by: TRAE CLI (GPT-5.6-Sol)
