OPNSense/core 15a0918. plist, src/opnsense/mvc/app/models/OPNsense/Radvd Radvd.xml Radvd.php

radvd: MVC/API WIP #8351
DeltaFile
+82-0src/opnsense/mvc/app/models/OPNsense/Radvd/Radvd.xml
+76-0src/opnsense/mvc/app/models/OPNsense/Radvd/Migrations/M1_0_0.php
+35-0src/opnsense/mvc/app/models/OPNsense/Radvd/Radvd.php
+3-0plist
+196-04 files

OPNSense/core 8d89a6csrc/opnsense/scripts/filter update_tables.py, src/opnsense/scripts/filter/lib/alias __init__.py bgpasn.py

Firewall: Aliases - add has_parser() to check if an alias has a valid parser available (get_parser() may throw an exception when failed) and re-throw requests.exceptions.ConnectionError as IOError in BGPASN, likely closes https://github.com/opnsense/core/issues/9505
DeltaFile
+9-2src/opnsense/scripts/filter/lib/alias/__init__.py
+6-1src/opnsense/scripts/filter/lib/alias/bgpasn.py
+1-1src/opnsense/scripts/filter/update_tables.py
+16-43 files

OPNSense/core 21a0fb7src/etc/inc util.inc

backend: remove mwexecf_bg() which is already unused
DeltaFile
+0-5src/etc/inc/util.inc
+0-51 files

OPNSense/core 4aba405src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogOneToOneRule.xml, src/opnsense/mvc/app/views/OPNsense/Firewall onat_rule.volt

The interface formatter is useless here since only one interface is allowed and there is no inversion allowed
DeltaFile
+0-25src/opnsense/mvc/app/views/OPNsense/Firewall/onat_rule.volt
+0-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogOneToOneRule.xml
+0-262 files

OPNSense/core 4810ad6src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogNptRule.xml, src/opnsense/mvc/app/views/OPNsense/Firewall npt_rule.volt

The interface formatter is useless here since only one interface is allowed and there is no inversion allowed
DeltaFile
+0-25src/opnsense/mvc/app/views/OPNsense/Firewall/npt_rule.volt
+0-2src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogNptRule.xml
+0-272 files

OPNSense/core 5a48dacsrc/opnsense/mvc/app/controllers/OPNsense/Firewall NptController.php, src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api NptController.php

Fix copyright date
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/NptController.php
+1-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/NptController.php
+2-22 files

OPNSense/core bc5e670. plist, src/opnsense/mvc/app/controllers/OPNsense/Firewall NptController.php

nat: Refactor network prefix translation (NPT) view
DeltaFile
+532-0src/opnsense/mvc/app/views/OPNsense/Firewall/npt_rule.volt
+88-28src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogNptRule.xml
+33-9src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/NptController.php
+3-24src/opnsense/mvc/app/controllers/OPNsense/Firewall/NptController.php
+3-3src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
+1-0plist
+660-646 files

OPNSense/core 18205c7src/etc/inc/plugins.inc.d dhcrelay.inc

dhcrelay: some style in the pugin file
DeltaFile
+14-12src/etc/inc/plugins.inc.d/dhcrelay.inc
+14-121 files

OPNSense/core 9dd1bd1src/etc/rc.subr.d php var, src/opnsense/mvc/tests/app/config config.php

mvc: now that config.xml behaviour is fixed change tests to own directory
DeltaFile
+3-4src/opnsense/mvc/tests/app/config/config.php
+1-1src/etc/rc.subr.d/php
+1-0src/etc/rc.subr.d/var
+5-53 files

OPNSense/core 7cbda13src/opnsense/mvc/app/config config.php, src/opnsense/mvc/app/controllers/OPNsense/Core/Api TunablesController.php DefaultsController.php

mvc: introduce defaultConfig property for AppConfig

Related to testing there is a side effect from snatching the
default config.xml if no other configuration was found.  We
want the tests to be independent of runtime so this is a first
step towards it.  While here replace other uses of the default
file acquire and almost completely fix the permission issue
on default bootstrap.
DeltaFile
+10-4src/opnsense/mvc/app/library/OPNsense/Core/Config.php
+9-3src/opnsense/mvc/app/controllers/OPNsense/Core/Api/TunablesController.php
+6-2src/opnsense/mvc/app/controllers/OPNsense/Core/Api/DefaultsController.php
+1-0src/opnsense/mvc/app/config/config.php
+1-0src/opnsense/mvc/tests/app/config/config.php
+27-95 files

OPNSense/core 00583b4src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogOneToOneRule.xml

Simplify labels
DeltaFile
+2-2src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogOneToOneRule.xml
+2-21 files

OPNSense/core 7eaf080src/opnsense/mvc/tests/app/library/OPNsense/Core ConfigTest.php

tests: ConfigTest: we can cast and do not need save
DeltaFile
+1-2src/opnsense/mvc/tests/app/library/OPNsense/Core/ConfigTest.php
+1-21 files

OPNSense/core 6e634f6. plist, src/opnsense/mvc/tests/app/library/OPNsense/Core ConfigTest.php

tests: add a Core\Config class test for toArray/fromArray
DeltaFile
+83-0src/opnsense/mvc/tests/app/library/OPNsense/Core/ConfigTest.php
+48-0src/opnsense/mvc/tests/app/library/OPNsense/Core/ConfigConfig/backup/config.xml
+2-0plist
+133-03 files

OPNSense/core b9d7cf3src/opnsense/mvc/tests/app/models/OPNsense/Base BaseModelTest.php, src/opnsense/mvc/tests/app/models/OPNsense/Base/BaseModelConfig/backup config.xml

tests: BaseModelTest: disable backups and mock revision

Change class invokes to self and add a $configDir variable.
DeltaFile
+79-78src/opnsense/mvc/tests/app/models/OPNsense/Base/BaseModelTest.php
+3-3src/opnsense/mvc/tests/app/models/OPNsense/Base/BaseModelConfig/backup/config.xml
+82-812 files

OPNSense/core 18b3e24src/etc config.xml.sample, src/opnsense/mvc/tests/app/models/OPNsense/ACL/AclConfig config.xml

system: remove long obsolete snmpd section from default config
DeltaFile
+0-5src/opnsense/mvc/tests/app/models/OPNsense/ACL/AclConfig/config.xml
+0-5src/etc/config.xml.sample
+0-102 files

OPNSense/core 69d8515src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api OneToOneController.php

Apply suggestions from code review

Co-authored-by: Franco Fichtner <franco at opnsense.org>
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/OneToOneController.php
+1-11 files

OPNSense/core fdf52dc. Makefile plist, src/opnsense/mvc/tests/app/models/OPNsense/Base BaseModelTest.php

tests: unwind BaseModel test side effect on AclConfig

Give the test its own empty config to migrate into, which makes
resetting it irrelevant.  A tiny bit of magic is needed to bootstrap
a config.xml so it's not the one that is checked in and we also
remove the temporary files from the tree so it does not confuse git.

save() is a far-reaching side effect in the test, but more or less
necessary for better test coverage.  But I'd still want a simpler
test around Core\Config and this offers merely offers the groundwork
also removing the need to reset this from make commands.
DeltaFile
+37-35src/opnsense/mvc/tests/app/models/OPNsense/Base/BaseModelTest.php
+8-0src/opnsense/mvc/tests/app/models/OPNsense/Base/BaseModelConfig/backup/config.xml
+1-7Makefile
+1-0plist
+47-424 files

OPNSense/core 28ea98asrc/opnsense/mvc/app/models/OPNsense/Core ACL.php

mvc: advertise use of Config instead of just using it in ACL
DeltaFile
+1-0src/opnsense/mvc/app/models/OPNsense/Core/ACL.php
+1-01 files

OPNSense/core c7fc716src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogDNatRule.xml dialogOneToOneRule.xml

Change general header in dialog to organization, to be in line with firewall filter dialog
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogDNatRule.xml
+1-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogOneToOneRule.xml
+2-22 files

OPNSense/core e0bfc35src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogOneToOneRule.xml

Using / in labels messes with the label in column headers
DeltaFile
+3-3src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogOneToOneRule.xml
+3-31 files

OPNSense/core 472f17fsrc/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterBaseController.php OneToOneController.php

Turn moveRuleBeforeAction() and toggleRuleLogAction() into shared based methods
DeltaFile
+101-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php
+4-78src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/OneToOneController.php
+2-73src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/DNatController.php
+1-25src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+108-1764 files

OPNSense/core 0b86124src/opnsense/scripts/unbound-dnsbl/lib dnsbl.py

unbound: ditch dnsbl_available and bind around self.dnsbl
DeltaFile
+6-11src/opnsense/scripts/unbound-dnsbl/lib/dnsbl.py
+6-111 files

OPNSense/core 3b01394src/opnsense/scripts/unbound-dnsbl dnsbl_module.py

Services: Unbound DNS - fix "configctl unbound check" as it doesn't use a chroot.

ref: https://forum.opnsense.org/index.php?topic=49989.0
DeltaFile
+1-0src/opnsense/scripts/unbound-dnsbl/dnsbl_module.py
+1-01 files

OPNSense/core d4567fesrc/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogOneToOneRule.xml

These labels are not needed in grid_view
DeltaFile
+0-2src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogOneToOneRule.xml
+0-21 files

OPNSense/core fb2cbffsrc/opnsense/mvc/app/views/OPNsense/Firewall onat_rule.volt

nat/one-to-one: Refactor UI part to be in line with other firewall components
DeltaFile
+2-2src/opnsense/mvc/app/views/OPNsense/Firewall/onat_rule.volt
+2-21 files

OPNSense/core 5a0fadbsrc/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogOneToOneRule.xml

nat/one-to-one: Refactor UI part to be in line with other firewall components
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogOneToOneRule.xml
+1-11 files

OPNSense/core cceaf1asrc/opnsense/mvc/app/controllers/OPNsense/Firewall/Api OneToOneController.php, src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogOneToOneRule.xml

nat/one-to-one: Refactor UI part to be in line with other firewall components
DeltaFile
+23-3src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/OneToOneController.php
+4-5src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogOneToOneRule.xml
+27-82 files

OPNSense/core b8e5cfcsrc/opnsense/scripts/unbound-dnsbl/lib dnsbl.py

unbound: clean up marker and size files, closes #9489
DeltaFile
+32-26src/opnsense/scripts/unbound-dnsbl/lib/dnsbl.py
+32-261 files

OPNSense/core cc9159fsrc/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogOneToOneRule.xml, src/opnsense/mvc/app/views/OPNsense/Firewall onat_rule.volt

nat/one-to-one: Refactor UI part to be in line with other firewall components
DeltaFile
+138-61src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogOneToOneRule.xml
+2-2src/opnsense/mvc/app/views/OPNsense/Firewall/onat_rule.volt
+140-632 files

OPNSense/core a7564c2src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api OneToOneController.php, src/opnsense/mvc/app/models/OPNsense/Firewall Filter.xml

nat/one-to-one: Refactor UI part to be in line with other firewall components
DeltaFile
+88-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/OneToOneController.php
+4-4src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
+2-2src/opnsense/mvc/app/views/OPNsense/Firewall/onat_rule.volt
+1-1src/opnsense/mvc/app/models/OPNsense/Firewall/Menu/Menu.xml
+95-74 files