OPNSense/core 1170806src/opnsense/scripts/suricata/lib downloader.py

IDS: rule downloader, catch UnicodeDecodeError and log, unescape file name

PR: https://github.com/opnsense/plugins/issues/1585

(cherry picked from commit 10a3012520ef637d23d5c0648ffe855c88c68fcc)
(cherry picked from commit 16eca2b9006b1f4a64001dbfb1a6d615caf9e83c)

OPNSense/core 11daec2src/opnsense/scripts/OPNsense/CaptivePortal test.py

oops, test file

OPNSense/core de98d99src/opnsense/scripts/unbound wrapper.py

Unbound: exit wrapper when process not running. closes 
https://github.com/opnsense/core/pull/3553

(cherry picked from commit 715319b1c0145615cd744315a87e228794249f12)

OPNSense/core 5cabbf5src/opnsense/mvc/app/views/OPNsense/Diagnostics systemhealth.volt

System health: minor cleanups, show dialog when RRD is disabled. closes 
https://github.com/opnsense/core/issues/3141

(cherry picked from commit 5f32b0788a8a307cb1650d2c4e5d9d74df6e4647)

OPNSense/core 5668c28src/opnsense/mvc/app/library/OPNsense/Core Config.php

fix forceReload() closes https://github.com/opnsense/core/issues/3801

(cherry picked from commit d547bc48bce7051472934b5b53cf2f65302b405c)

OPNSense/core 2cf2fd6src/etc/inc/plugins.inc.d pf.inc

HASync, add interface groups for https://github.com/opnsense/core/issues/3779

(cherry picked from commit c6cb6df8ff4bee60f8a2c868a54baffb1a607817)
(cherry picked from commit 63769daaa96127f44015dfd118afe56fe22db2b8)
(cherry picked from commit 9cbc0aa5afee7ea08864e30e7506232e2f69fba9)

OPNSense/core 396efafsrc/etc/inc/plugins.inc.d dhcpd.inc

DHCPv6, fix for domain-search option

The "domain-search" option in dhcpdv6.conf must be prefixed with "dhcp6". This fixes one 
of the issues from #2336 which are still open.

(cherry picked from commit 502e6c709c2961454011cc9db6de3b020531f21f)

OPNSense/core ae043b0contrib/google-api-php-client/Google/Service Dfareporting.php Compute.php

Switch backup to Google api php client v2 (#3778)


OPNSense/core 16eca2bsrc/opnsense/scripts/OPNsense/CaptivePortal test.py, src/opnsense/scripts/suricata/lib downloader.py

IDSi / rule download, unescape filename , closes 
https://github.com/opnsense/plugins/issues/1585

OPNSense/core 02caac7src/etc/inc certs.inc, src/www system_certmanager.php system_camanager.php

Support ECC Certificate Creation (#3823)

Support ECC Certificate Creation (https://github.com/opnsense/core/pull/3649)

OPNSense/core 502e6c7src/etc/inc/plugins.inc.d dhcpd.inc

DHCPv6, fix for domain-search option

The "domain-search" option in dhcpdv6.conf must be prefixed with "dhcp6". This fixes one 
of the issues from #2336 which are still open.

OPNSense/core 018149csrc/etc/inc certs.inc, src/etc/inc/plugins.inc.d/openvpn wizard.inc

OPNSense/core cb75a8fsrc/etc/inc certs.inc, src/etc/inc/plugins.inc.d/openvpn wizard.inc

Merge branch 'ec-certs' of https://github.com/johnaheadley/core into johnaheadley-ec-certs

OPNSense/core 10a3012src/opnsense/scripts/suricata/lib downloader.py

IDS: rule downloader, catch UnicodeDecodeError and log.

OPNSense/core 8c2b52fsrc/etc/inc certs.inc, src/www system_camanager.php

fixed formatting

OPNSense/core d640b52src/etc/inc certs.inc, src/etc/inc/plugins.inc.d/openvpn wizard.inc

change to using shared variable keylen_curve

OPNSense/core e9ba42asrc/www services_dnsmasq.php

Dnsmasq: unable to configure on empty config data

(cherry picked from commit aa1a3886cd6096d01742706bee38a1af40bb4a9d)

OPNSense/core a48c4d2src/opnsense/scripts/filter read_log.py

filter live log, ignore tag keyword in pfctl output. closes 
https://github.com/opnsense/core/issues/3796

(cherry picked from commit 8a83b3bb123c9f8a12a637693509a29f149699bf)

OPNSense/core 06aff4asrc/opnsense/scripts/filter list_counters.py

filter-list_counters skip empty lines, for https://github.com/opnsense/core/issues/3798

(cherry picked from commit 196d46238336aec125a865b1e2dc78fc4570f1d3)

OPNSense/core 5e6021esrc/opnsense/mvc/app/views/layout_partials form_input_tr.volt

Add "type" field to self-doc. SPlit from PR#3812 (#3813)


(cherry picked from commit 0c35ffbb8dd70bb332cd1a9e884dfce0450a9456)

OPNSense/core 76f16cfsrc/opnsense/mvc/app/models/OPNsense/Proxy Proxy.xml

Added check on SNI field checkbox (#3338)

(cherry picked from commit 2a9bc8fe494da0cd7549a7f92319e25fd5d05892)

OPNSense/core f2a2280src/etc/inc interfaces.inc, src/www interfaces.php

interfaces: remove the "Directly send SOLICIT" option

We already do a more-or-less hybrid approach by starting rtsold
even if it isn't used at all.  Now we also have ISPs which do
not seem to send router advertisements after successful connect
so that the reconnect misses the HUP for dhcp6c to fix the
connectivity again.

To change that remove the option and its only conditional to
behave unconditionally which has few reasons to cause regressions.

(cherry picked from commit 48e0c47a968b4f55bbe299d6b961613fa8d86802)

OPNSense/core 532f397src/etc config.xml.sample, src/etc/inc system.inc

sysctl: maxdgram --> 8192. closes https://github.com/opnsense/core/issues/3806

(cherry picked from commit 8917f1c06f18931bb52cc0fdb005c651bccc9f4b)
(cherry picked from commit 4a4d72afd8f482813ccd9057f33f1269f03ddf9d)
(cherry picked from commit 548932a71a3755050e3767050afe90dc0782c836)

OPNSense/core 3d6a8a2src/opnsense/service/templates/OPNsense/IDS suricata.yaml

IDS: eve syslog, lower payload-buffer-size to prevent syslog size limit. for 
https://github.com/opnsense/core/issues/3806

(cherry picked from commit 188c517a262d8ebd9752dc0a12acfab73bc4786a)
(cherry picked from commit fba3861477bc1b7f66eddb3fe95725ee459802c6)

OPNSense/core 0e7b20fsrc/etc/inc/plugins.inc.d dpinger.inc

dpinger: back to where it was in April 2019

PR: #3693
(cherry picked from commit ee73840e9c6460cb85f3de81ada0c17dbc4fe2a5)

OPNSense/core 928e9a7. Makefile

system: Syslog-ng 3.24

(cherry picked from commit 953ada87610d4eae224a633e01f684e5fa870cbc)
DeltaFile
+1-1Makefile
+1-11 files

OPNSense/core f9a250f. CONTRIBUTING.md

Update CONTRIBUTING.md

add explicit timeout period

(cherry picked from commit e39474de90f699a0434368783b4ca094184a2395)
DeltaFile
+1-1CONTRIBUTING.md
+1-11 files

OPNSense/core 5f32b07src/opnsense/mvc/app/views/OPNsense/Diagnostics systemhealth.volt

System health: minor cleanups, show dialog when RRD is disabled. closes 
https://github.com/opnsense/core/issues/3141

OPNSense/core 1bdef70src/opnsense/www index.php

MVC: route to default page when controller or acion not found, closes 
https://github.com/opnsense/core/issues/2435

OPNSense/core 715319bsrc/opnsense/scripts/unbound wrapper.py

Unbound: exit wrapper when process not running. closes 
https://github.com/opnsense/core/pull/3553

OPNSense/core aa1a388src/www services_dnsmasq.php

Dnsmasq: unable to configure on empty config data

OPNSense/core 375f931src/www diag_pf_info.php

Translate diag_pf_info (#3491)

OPNSense/core 548932asrc/etc/inc system.inc

system: honour defaults for non-config sysctls as well #3806

OPNSense/core 4a4d72asrc/etc config.xml.sample, src/etc/inc system.inc

system: bootstrap a default value and always apply #3806

So that users are not seeing issues because they haven't done a
config reset yet.  It also allows us to bump the default again
if needed.

OPNSense/core 8917f1csrc/etc config.xml.sample

sysctl: maxdgram --> 8192. closes https://github.com/opnsense/core/issues/3806

OPNSense/core b1702d0src/opnsense/mvc/app/controllers/OPNsense/Core/Api FirmwareController.php

firmware: duplicates stay in the config #1663

When we install "os-debug" it will deinstall "os-debug-devel" so
we should update our logic.

OPNSense/core fba3861src/opnsense/service/templates/OPNsense/IDS suricata.yaml

IDS/syslog, missed a spot for https://github.com/opnsense/core/issues/3806

OPNSense/core 7fe5fe5src/etc rc

rc: whitespace noise
DeltaFile
+1-1src/etc/rc
+1-11 files

OPNSense/core 16efb9asrc/etc rc

use freebsd built in growfs script (#3810)
DeltaFile
+5-9src/etc/rc
+5-91 files

OPNSense/core ee73840src/etc/inc/plugins.inc.d dpinger.inc

dpinger: back to where it was in April 2019

PR: #3693

OPNSense/core 188c517src/opnsense/service/templates/OPNsense/IDS suricata.yaml

IDS: eve syslog, lower payload-buffer-size to prevent syslog size limit. for 
https://github.com/opnsense/core/issues/3806

OPNSense/core 0c35ffbsrc/opnsense/mvc/app/views/layout_partials form_input_tr.volt

Add "type" field to self-doc. SPlit from PR#3812 (#3813)

OPNSense/core f0b348bsrc/etc rc

rc: since 11.2 fsck_ffs will actually return ERERUN error
DeltaFile
+4-3src/etc/rc
+4-31 files

OPNSense/core 8507604. plist

pkg: fix plist
DeltaFile
+9-0plist
+9-01 files

OPNSense/core a219bf1src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/Api SettingsController.php

Traffic shaper: safeguard deletes, using https://github.com/opnsense/core/issues/1897

OPNSense/core d19ad59src/opnsense/mvc/app/controllers/OPNsense/Base ApiMutableModelControllerBase.php

MVC: on ApiMutableModelControllerBase add opt-in parameter $internalModelUseSafeDelete to 
check for referential integrity before delete, throwing a UserException when the uuid is 
found inside a tag which logically originates from a model. (has a uuid attribute and a 
version attribute in one of its parents)

closes https://github.com/opnsense/core/issues/1897

OPNSense/core e1883f3src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes JsonKeyValueStoreField.php

MVC: refactor JsonKeyValueStoreField type, skip unit test since it depends on configd. for 
https://github.com/opnsense/core/issues/3252

OPNSense/core 5324f35src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes InterfaceField.php, src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes InterfaceFieldTest.php CountryFieldTest.php

MVC: refactor InterfaceField and add unit tests for 
https://github.com/opnsense/core/issues/3252

OPNSense/core 10be0e4src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes CountryField.php, src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes CountryFieldTest.php

MVC: refactor CountryField and add unit test for 
https://github.com/opnsense/core/issues/3252

OPNSense/core 50da9e3src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes BaseListField.php

MVC: fix a validation bug while working on https://github.com/opnsense/core/issues/3252

InclusionIn() validation only works when using string, php seems to convert keys 
automatically, in which case the following input:

$data = ["101" => "abc", "102" => "cde"];

would lead to these keys:

array_keys($data) ==> [101, 102]

when validating if 101,100 is a valid item in the list InclusionIn() seems to think so....