OPNSense/core e0f0cbfsrc/etc/inc filter.lib.inc, src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogDNatRule.xml

Firewall: NAT: Destination NAT - change "pass" into an option field, which chooses between "manual" (do nothing), add a pass flag or register a rule at the bottom of our interface ruleset.

Should be the last piece of the puzzle for https://github.com/opnsense/core/issues/8401
DeltaFile
+29-0src/etc/inc/filter.lib.inc
+7-1src/opnsense/mvc/app/models/OPNsense/Firewall/DNat.xml
+3-3src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogDNatRule.xml
+1-1src/opnsense/mvc/app/library/OPNsense/Firewall/ForwardRule.php
+1-1src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/DNatAssociatedRuleField.php
+41-65 files

OPNSense/core f49ac84. plist, src/opnsense/mvc/app/controllers/OPNsense/Firewall NptController.php

mvc: style
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/NptController.php
+1-1plist
+0-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/NptController.php
+0-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/OneToOneController.php
+2-44 files

OPNSense/core 2f8e32asrc/opnsense/mvc/app/controllers/OPNsense/Firewall SourceNatController.php, src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api SourceNatController.php

nat/snat: Refactor source nat view (#9507)

* nat/snat: Refactor source nat view

* filter.volt has no consumer left and can be removed

* Adjust parameters

* Multi select is not possible in source and destination, remove net_selector_multi

* The snatrules validation issue has been solved in https://github.com/opnsense/core/commit/f372161b4cfa68733e272a3c754edc49fee49999

* use isEmpty() and getValues()
DeltaFile
+623-0src/opnsense/mvc/app/views/OPNsense/Firewall/snat_rule.volt
+200-81src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogSNatRule.xml
+0-159src/opnsense/mvc/app/views/OPNsense/Firewall/filter.volt
+34-4src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/SourceNatController.php
+4-16src/opnsense/mvc/app/controllers/OPNsense/Firewall/SourceNatController.php
+3-3src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
+864-2632 files not shown
+868-2678 files

OPNSense/core 5e393da. plist, src/opnsense/mvc/app/controllers/OPNsense/Firewall NptController.php

nat/npt: Refactor network prefix translation view (#9504)

* nat: Refactor network prefix translation (NPT) view

* Fix copyright date

* The interface formatter is useless here since only one interface is allowed and there is no inversion allowed

* Adjust parameters

* use isEmpty() and getValues()
DeltaFile
+507-0src/opnsense/mvc/app/views/OPNsense/Firewall/npt_rule.volt
+86-28src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogNptRule.xml
+33-9src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/NptController.php
+4-25src/opnsense/mvc/app/controllers/OPNsense/Firewall/NptController.php
+3-3src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
+1-0plist
+634-656 files

OPNSense/core 21faf2csrc/opnsense/mvc/app/controllers/OPNsense/Firewall OneToOneController.php, src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterBaseController.php DNatController.php

nat/one-to-one: Refactor one-to-one nat view, refactor two controller methods as base methods (#9492)

* nat/one-to-one: Refactor UI part to be in line with other firewall components

* These labels are not needed in grid_view

* Turn moveRuleBeforeAction() and toggleRuleLogAction() into shared based methods

* Using / in labels messes with the label in column headers

* Change general header in dialog to organization, to be in line with firewall filter dialog

* Apply suggestions from code review

Co-authored-by: Franco Fichtner <franco at opnsense.org>

* Simplify labels

* The interface formatter is useless here since only one interface is allowed and there is no inversion allowed

    [15 lines not shown]
DeltaFile
+597-0src/opnsense/mvc/app/views/OPNsense/Firewall/onat_rule.volt
+134-61src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogOneToOneRule.xml
+94-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php
+2-73src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/DNatController.php
+37-3src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/OneToOneController.php
+3-33src/opnsense/mvc/app/controllers/OPNsense/Firewall/OneToOneController.php
+867-1706 files not shown
+875-20212 files

OPNSense/core ef74949src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api OneToOneController.php

use isEmpty() and getValues()
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/OneToOneController.php
+1-11 files

OPNSense/core 63fe135src/opnsense/mvc/app/views/OPNsense/Diagnostics fw_log.volt

firewall: live log: make sure we default to src/dst columns on page load

if hostname lookup is selected, bootgrid persistence will make the
srchostname/dsthostname columns the default on page load, so reset these.

both column groups are still entirely separate, so width changes
on one will not affect the other. There is no easy way to tie these
together at the moment.
DeltaFile
+2-0src/opnsense/mvc/app/views/OPNsense/Diagnostics/fw_log.volt
+2-01 files

OPNSense/core 5f1b2bbsrc/www interfaces_assign.php

Interfaces: Assignments - ditch broken $is_ppp validation, the device should exist before allowing assignments (always).
DeltaFile
+1-9src/www/interfaces_assign.php
+1-91 files

OPNSense/core 07e0ba8src/opnsense/mvc/app/views/OPNsense/Diagnostics fw_log.volt

firewall: live view: add bigger table size options and simplify table update (#9518)

DeltaFile
+7-5src/opnsense/mvc/app/views/OPNsense/Diagnostics/fw_log.volt
+7-51 files

OPNSense/core d25a8acsrc/opnsense/mvc/app/views/OPNsense/Kea dhcpv4.volt, src/opnsense/www/js opnsense_bootgrid.js

bootgrid: extend commands structure for generalized usage (#9510)

DeltaFile
+162-118src/opnsense/www/js/opnsense_bootgrid.js
+35-39src/opnsense/mvc/app/views/OPNsense/Kea/dhcpv4.volt
+197-1572 files

OPNSense/core 9e0cbf2src/etc rc.newwanipv6

interfaces: reload test for #9521
DeltaFile
+1-0src/etc/rc.newwanipv6
+1-01 files

OPNSense/core cf868a1. plist, src/opnsense/mvc/app/models/OPNsense/Radvd Radvd.xml Radvd.php

radvd: MVC/API WIP #8351
DeltaFile
+170-0src/opnsense/mvc/app/models/OPNsense/Radvd/Migrations/M1_0_0.php
+85-0src/opnsense/mvc/app/models/OPNsense/Radvd/Radvd.xml
+35-0src/opnsense/mvc/app/models/OPNsense/Radvd/Radvd.php
+3-0plist
+293-04 files

OPNSense/core 502c542src/opnsense/mvc/app/views/OPNsense/Diagnostics fw_log.volt

firewall: live view: add bigger table size options and simplify table update
DeltaFile
+7-5src/opnsense/mvc/app/views/OPNsense/Diagnostics/fw_log.volt
+7-51 files

OPNSense/core 07d4da2src/opnsense/www/js opnsense_bootgrid.js

bootgrid: return was ditched, swap needs a check now
DeltaFile
+13-12src/opnsense/www/js/opnsense_bootgrid.js
+13-121 files

OPNSense/core e257b63src/opnsense/www/js opnsense_bootgrid.js

bootgrid: simplify tooltip handling
DeltaFile
+41-57src/opnsense/www/js/opnsense_bootgrid.js
+41-571 files

OPNSense/core 40e7f66src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api DNatController.php

Adjust parameters
DeltaFile
+2-2src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/DNatController.php
+2-21 files

OPNSense/core c6ffd18src/www firewall_rules_edit.php

firewall: fix typo in previous

(cherry picked from commit 559701cbc0df0c39abaf85102eca098164fe575d)
DeltaFile
+1-1src/www/firewall_rules_edit.php
+1-11 files

OPNSense/core 559701csrc/www firewall_rules_edit.php

firewall: fix typo in previous
DeltaFile
+1-1src/www/firewall_rules_edit.php
+1-11 files

OPNSense/core 6423241src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogDNatRule.xml

nat/dnat: Source and destination cannot be multi select (#9513)

DeltaFile
+2-2src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogDNatRule.xml
+2-21 files

OPNSense/core d3ada54src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogDNatRule.xml

nat/dnat: Source and destination cannot be multi select
DeltaFile
+2-2src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogDNatRule.xml
+2-21 files

OPNSense/core 446c268src/opnsense/scripts/filter update_tables.py, src/opnsense/scripts/filter/lib/alias __init__.py bgpasn.py

Firewall: Aliases - add has_parser() to check if an alias has a valid parser available (get_parser() may throw an exception when failed) and re-throw requests.exceptions.ConnectionError as IOError in BGPASN, likely closes https://github.com/opnsense/core/issues/9505

(cherry picked from commit 8d89a6cf6c2fd7072162136d3bc7037d438fbf88)
DeltaFile
+9-2src/opnsense/scripts/filter/lib/alias/__init__.py
+6-1src/opnsense/scripts/filter/lib/alias/bgpasn.py
+1-1src/opnsense/scripts/filter/update_tables.py
+16-43 files

OPNSense/core 820e877src/opnsense/scripts/unbound-dnsbl dnsbl_module.py

Services: Unbound DNS - fix "configctl unbound check" as it doesn't use a chroot.

ref: https://forum.opnsense.org/index.php?topic=49989.0
(cherry picked from commit 3b01394d561e0f012973af67e494cbb4f36307a1)
DeltaFile
+1-0src/opnsense/scripts/unbound-dnsbl/dnsbl_module.py
+1-01 files

OPNSense/core a9c0227src/opnsense/service/templates/OPNsense/Unbound/core safesearch.conf

dns/unbound: Fix condition in safesearch template (#9512)

(cherry picked from commit 91a09fee426d54fc22663af0cbd1607324037fde)
DeltaFile
+1-1src/opnsense/service/templates/OPNsense/Unbound/core/safesearch.conf
+1-11 files

OPNSense/core 7caf759src/www firewall_rules_edit.php

Firewall: Rules - cleanup cancel button action

(cherry picked from commit 71a2139f54b73ddb884f793a9e1bc42097689ae5)
DeltaFile
+10-3src/www/firewall_rules_edit.php
+10-31 files

OPNSense/core 91a09fesrc/opnsense/service/templates/OPNsense/Unbound/core safesearch.conf

dns/unbound: Fix condition in safesearch template (#9512)

DeltaFile
+1-1src/opnsense/service/templates/OPNsense/Unbound/core/safesearch.conf
+1-11 files

OPNSense/core 94df7cdsrc/opnsense/service/templates/OPNsense/Unbound/core safesearch.conf

dns/unbound: Fix condition in safesearch template
DeltaFile
+1-1src/opnsense/service/templates/OPNsense/Unbound/core/safesearch.conf
+1-11 files

OPNSense/core 67ee20fsrc/opnsense/service/templates/OPNsense/Unbound/core safesearch.conf

dns/unbound: Fix condition in safesearch template
DeltaFile
+1-1src/opnsense/service/templates/OPNsense/Unbound/core/safesearch.conf
+1-11 files

OPNSense/core ccaf281src/opnsense/mvc/app/controllers/OPNsense/Trust/Api CertController.php

stylefix: crashing our doc lexer

(cherry picked from commit b806142823caa700afcc9a648ca7c7739a44a63b)
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CertController.php
+1-11 files

OPNSense/core b806142src/opnsense/mvc/app/controllers/OPNsense/Trust/Api CertController.php

stylefix: crashing our doc lexer
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CertController.php
+1-11 files

OPNSense/core 6b8d37dsrc/opnsense/mvc/app/models/OPNsense/Firewall Filter.php

The snatrules validation issue has been solve in https://github.com/opnsense/core/commit/f372161b4cfa68733e272a3c754edc49fee49999
DeltaFile
+0-1src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.php
+0-11 files