OPNSense/core 6b6e3edsrc/opnsense/mvc/app/models/OPNsense/TrafficShaper TrafficShaper.xml

firewall: give "none" values a valid translation; closes #3552

OPNSense/core 99bd86d. Makefile

make: try to invalidate the cache, but only if the system looks like it

`install' has the same issue as `upgrade' and maybe we need to be careful
about use of `-[pP]' so that we are not stuck with a hash that does not
invalidate when installing a new version anymore.

(cherry picked from commit ac303690efcb231f5a489d4cc2457ce4ad449bff)
DeltaFile
+7-0Makefile
+7-01 files

OPNSense/core ac30369. Makefile

make: try to invalidate the cache, but only if the system looks like it

`install' has the same issue as `upgrade' and maybe we need to be careful
about use of `-[pP]' so that we are not stuck with a hash that does not
invalidate when installing a new version anymore.
DeltaFile
+7-0Makefile
+7-01 files

OPNSense/core 5dc345bsrc/opnsense/mvc/app/controllers/OPNsense/Syslog/Api ServiceController.php, src/opnsense/mvc/app/library/OPNsense/Auth/Services Squid.php

src: style and whitespace sweep

OPNSense/core d7f5097src/opnsense/mvc/app/models/OPNsense/Diagnostics Netflow.php, src/opnsense/mvc/app/views/OPNsense/Diagnostics netflow.volt

reporting: improve NetFlow validation and form behaviour #3547

OPNSense/core dea7824src/opnsense/www/js opnsense_ui.js

ui: add a fail callback to e.g. disable progress spinners

OPNSense/core 139f529src/etc/inc/plugins.inc.d core.inc

system: syslog is syslogd really

OPNSense/core bc3623dsrc/opnsense/mvc/app/controllers/OPNsense/IDS/Api SettingsController.php, src/opnsense/mvc/app/models/OPNsense/IDS IDS.php

IDPS, when toggling rules, keep current action. closes 
https://github.com/opnsense/core/issues/3513

(cherry picked from commit 3af744e03dd8191fa239b2a91823657f1c87e735)

OPNSense/core 24511fesrc/opnsense/mvc/app/controllers/OPNsense/Proxy/Api ServiceController.php, src/opnsense/mvc/app/views/OPNsense/Proxy index.volt

Proxy, add support tab with reset button, which clears all stored cache data and restarts 
squid. Since a squid stop can take long and consistency isn't very important on files 
bound to be deleted, its faster to killall -9. closes 
https://github.com/opnsense/core/issues/3545

(cherry picked from commit cdaa275fff06d0e1a9a9eb48c8fc654e8e6ea56a)

OPNSense/core 7544175src/etc/inc/plugins.inc.d squid.inc, src/www diag_logs_proxy.php

Proxy, access log over syslog. This is at the moment the best I can think of, since we 
can't combine clog and plain log it's better to make the choices explicit in our code.
Access log over syslog will write to /var/log/squid.log, where the normal plain log would 
write to /var/log/squid/access.log

For https://github.com/opnsense/core/issues/3454

(cherry picked from commit 464495b58e9d600a76f14c25e5959112426c4e48)

OPNSense/core 20d6adesrc/etc rc.filter_synchronize, src/www system_hasync.php

HASync- add dashboard widgets, closes https://github.com/opnsense/core/issues/3482

(cherry picked from commit b87761029672802f3bdfc6bb070a3ca71ff39143)

OPNSense/core d3eb4c9src/etc/inc/plugins.inc.d/openvpn auth-user.php

style fix, missing brackets

(cherry picked from commit 5ff6dd228cae1111e4603b08206b9bdbd26de492)

OPNSense/core e91af44src/etc/inc auth.inc

auth.inc local_sync_accounts(), missing -g in groupdel. for 
https://github.com/opnsense/core/issues/3519

(cherry picked from commit ebcd30c97135d62d2c568185318fd4bbb812c9fe)

OPNSense/core 612eb74. Makefile

make: lint pass also checks rc.syshook.d now

(cherry picked from commit 4728a64a1b047119e52bc061db4d873eda76a131)
DeltaFile
+1-1Makefile
+1-11 files

OPNSense/core 4728a64. Makefile

make: lint pass also checks rc.syshook.d now
DeltaFile
+1-1Makefile
+1-11 files

OPNSense/core 67b404fsrc/opnsense/mvc/app/controllers/OPNsense/IDS/Api SettingsController.php

intrusion detection: try to fix $data['row'] handling #3474

Is this a browser-specific bug?

OPNSense/core c0fe5cesrc/etc/inc/plugins.inc.d dhcpd.inc, src/www services_router_advertisements.php

IPv6 Router Advertisements, add advanced options, closes 
https://github.com/opnsense/core/issues/3366

OPNSense/core 658e3d0src/opnsense/mvc/app/models/OPNsense/Diagnostics Netflow.php

Netflow, WAN|Egress interfaces should be in All / Listening interfaces list. for 
https://github.com/opnsense/core/issues/3547

OPNSense/core bc34ae1src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/forms netflow_capture.xml

reporting: small tweak on help label

OPNSense/core 95e70f3src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/forms netflow_capture.xml

Netflow, minor addendum https://github.com/opnsense/core/issues/2197, in order for netflow 
to listen, all interfaces should be accounted for.

OPNSense/core 58c3e6csrc/www system_usermanager_import_ldap.php

Auth/ldap, use authentication factory for user import, might fix 
https://github.com/opnsense/core/issues/3445

OPNSense/core 5ff6dd2src/etc/inc/plugins.inc.d/openvpn auth-user.php

style fix, missing brackets

OPNSense/core b877610src/etc rc.filter_synchronize, src/www system_hasync.php

HASync- add dashboard widgets, closes https://github.com/opnsense/core/issues/3482

OPNSense/core 9dcacabsrc/www services_dhcp.php

services_dhcp.php, ddnsdomainprimary validation (looks like a typo)

OPNSense/core 9bf0756src/www services_dhcpv6.php

services_dhcpv6.php, validation issue in ddnsdomainprimary 
https://github.com/opnsense/core/issues/3546

OPNSense/core c5c6bb1src/www services_dhcpv6.php

services_dhcpv6.php, fix typo in validation message , ref 
https://github.com/opnsense/core/issues/3546

OPNSense/core ebcd30csrc/etc/inc auth.inc

auth.inc local_sync_accounts(), missing -g in groupdel. for 
https://github.com/opnsense/core/issues/3519

OPNSense/core cdaa275src/opnsense/mvc/app/controllers/OPNsense/Proxy/Api ServiceController.php, src/opnsense/mvc/app/views/OPNsense/Proxy index.volt

Proxy, add support tab with reset button, which clears all stored cache data and restarts 
squid. Since a squid stop can take long and consistency isn't very important on files 
bound to be deleted, its faster to killall -9. closes 
https://github.com/opnsense/core/issues/3545

OPNSense/core 04e543esrc/opnsense/mvc/app/controllers/OPNsense/Core/Api/repositories opnsense.xml

Add homelab.no repository

(cherry picked from commit 283d62a007b71666f4e3e1cd59d0f0e96be963a3)

OPNSense/core d954ec6src/opnsense/mvc/app/views/OPNsense/IDS index.volt

IDPS, show sid in alert view. closes https://github.com/opnsense/core/issues/3527

(cherry picked from commit f32816d53a26dd37046d8ab025b46676711d35bf)

OPNSense/core 78e28e0. CONTRIBUTING.md

CONTRIBUTING: small updates and label explanations

(cherry picked from commit 3aa89a9bc2dbe63ab452bf4ee5b69df7c621d20d)
DeltaFile
+23-4CONTRIBUTING.md
+23-41 files

OPNSense/core b62b34fsrc/www interfaces_ppps_edit.php

interfaces: fix "OR hostname" validation message after latest change

Some style updates while here.

OPNSense/core 5898f2bsrc/opnsense/mvc/app/controllers/OPNsense/Firewall/Api AliasController.php

Alias. import alias reference issue, we need to make sure our newly imported items are 
considered valid options as well. closes https://github.com/opnsense/core/issues/3522

(cherry picked from commit 0e8d1fb39e94352775e7dadf989240276bdf582b)

OPNSense/core 335100fsrc/www system_certmanager.php

Trust, import csr. move csr_info and csr_info_json  commands to post to prevent sending 
large / possible illegal blobs of data in uri. closes 
https://github.com/opnsense/core/issues/3538

(cherry picked from commit 6b92b8170271335a80a8beb971c3fdf63160478f)

OPNSense/core d4cf429src/www interfaces_ppps_edit.php

Only IP-address allowed in PPTP gateway. (#3499)

OPNSense/core f2769fesrc/www interfaces_groups.php interfaces_groups_edit.php

Sort interface groups in GUI to match firewall rule order (#3537)

This now makes it easy and predictable to add interfaces to multiple
groups.

Before this change, the interfaces_groups GUI was sorted by the
order that interface groups were added. However, this was not the order
that the actual pf rules would then be generated making it unpredictable
when adding interfaces to multiple groups.

The filter_rules_sort function already took care of the actual pf rule
order.

I also took care of only marking the filter subsystem dirty when needed.
I tested this patch quite a bit on 19.1.8. When updating, users only
need to make one change to the interface groups to have them sorted in
the GUI.

I hope I did not miss anything because this patch is against master. In
it’s current state, the patch can be directly applied to 19.1.x or
master.

OPNSense/core 464495bsrc/etc/inc/plugins.inc.d squid.inc, src/www diag_logs_proxy.php

Proxy, access log over syslog. This is at the moment the best I can think of, since we 
can't combine clog and plain log it's better to make the choices explicit in our code.
Access log over syslog will write to /var/log/squid.log, where the normal plain log would 
write to /var/log/squid/access.log

For https://github.com/opnsense/core/issues/3454

OPNSense/core 1a86b31src/opnsense/mvc/app/models/OPNsense/Syslog Syslog.xml

Syslog-NG, sort programs by name in destination field

OPNSense/core 18be821src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes JsonKeyValueStoreField.php

MVC, JsonKeyValueStoreField type, add SortByValue option to influence sorting order.

OPNSense/core dbdfc72. plist

pkg: fix plist
DeltaFile
+10-0plist
+10-01 files

OPNSense/core b62de24src/opnsense/mvc/app/controllers/OPNsense/IDS/forms generalSettings.xml, src/opnsense/mvc/app/models/OPNsense/IDS IDS.xml

IDPS, duplicate eve logging section when syslog_eve is checked to support eve logging over 
syslog. Requires current syslog-ng work in master to be functional. closes 
https://github.com/opnsense/core/issues/3401

OPNSense/core 25df4f2src/opnsense/mvc/app/controllers/OPNsense/Syslog IndexController.php, src/opnsense/mvc/app/controllers/OPNsense/Syslog/Api ServiceController.php SettingsController.php

Syslog-NG destination setup (#3539)

Syslog-NG add user customizable target destinations using our standard model grid.

* registers on all source feeds (s_all)
* adds udp(4|6), tcp(4|6) transport options.
* use persist-name() to avoid collisions
* basic filters (program, level, facility)
* statistics grid for debugging and traceability

OPNSense/core 0b49bfcsrc/opnsense/mvc/app/controllers/OPNsense/Syslog/Api ServiceController.php, src/opnsense/mvc/app/views/OPNsense/Syslog index.volt

Syslog-NG, add statistics page + services controller

OPNSense/core 82788bdsrc/opnsense/mvc/app/controllers/OPNsense/Syslog IndexController.php, src/opnsense/mvc/app/controllers/OPNsense/Syslog/Api SettingsController.php

Syslog-NG work in progress customizable destinations.

OPNSense/core c928f5fsrc/opnsense/mvc/app/models/OPNsense/Syslog Syslog.xml

Syslog-NG custom destinations, add levels and set default to all but debug

OPNSense/core 3b2f4besrc/opnsense/mvc/app/models/OPNsense/Syslog Syslog.xml, src/opnsense/service/templates/OPNsense/Syslog +TARGETS

Syslog-NG, work in progress, align application property name

OPNSense/core 5e33d95src/opnsense/service/templates/OPNsense/Syslog syslog-ng-destinations.conf

missing file, work in progress.

OPNSense/core c830e2asrc/opnsense/mvc/app/controllers/OPNsense/Syslog/forms dialogDestination.xml

Syslog-NG, missed some renames

OPNSense/core 393a36asrc/opnsense/mvc/app/controllers/OPNsense/Syslog/forms dialogDestination.xml, src/opnsense/mvc/app/models/OPNsense/Syslog Syslog.php Syslog.xml

Syslog-NG fix destination template and finish frontend grid

OPNSense/core b7cb5a2src/opnsense/mvc/app/controllers/OPNsense/Syslog/forms dialogDestination.xml, src/opnsense/mvc/app/models/OPNsense/Syslog Syslog.xml

Syslog-NG destination model and input laout, add relevant fields