Captive Portal: remove redirection on HTTPS, ditch non-functional pass statement as well
In theory, clients only use HTTP to detect the presence of a portal.
If they were to use HTTPS, the 302 redirect would in most cases
not be accessible, as the certificate presented is most likely not
valid, cutting off the communication before any redirect to a login
page can happen.
The portal itself can and should remain accessible on HTTPS, as this
is the URL the redirect is pointing to. This may be attached to a
valid certificate as well, but the key point is that access to
this URL doesn't strictly need redirection for everything on port
443.
This should prevent clients opening bogus connections to the
captive portal, which consumes a lot of TLS traffic on the network
stack, bogging down lighttpd in bigger setups and creating
a lot of established states in pf.
[2 lines not shown]
bootgrid: replace 'append' with 'replace' for ajax: false grids
Noticed while documenting.
replaceData() is a lot more performant through Tabulator, and since
there are only 3 callers and all of them expect a clear before
updating any data, use a replace instead.
In time these pages should use the default search endpoint anyway,
but this requires an API change.
make sure to keep the append() function for compatibility
(cherry picked from commit d8b07eb02eba635fc253a948b7800cfa40a2be60)
bootgrid: clean up converter compatibility code
Only other consumer is Nginx in plugins, but worst case scenario
these timestamps will render as... timestamps, which in that form
are sortable anyway. It's likely this was throwing an error anyway
The "sorters" weren't actually accounted for in the compat
translation, so this wasn't overridable. Fix this here.
(cherry picked from commit a7ec18550d8cbb4b2a750a5860c3da52bd1d81d7)
ui: clean up useRequestHandlerOnGet usage
This has no use anymore with the current bootgrid code. If a
handler should be overridden, simply defining the function is enough
(cherry picked from commit 4a67e91f0b32f78a2a4de2a792ffba0da4a4e2d2)
Services: Kea DHCPv4/6: Add decline_probation_period and set lower default to mitigate faulty client implementations to consume the whole pool (#10294)
* Services: Kea DHCPv4/6: Add decline_probation_period and set lower default to mitigate faulty client implementations to consume the whole pool.
* Use isSet() since 0 is allowed
(cherry picked from commit b80995f2135476b7fbeb2f650d74eebca55ad5b3)
Services: Kea DHCPv4/6: Some cleanup regarding isEmpty) usage when 0 is allowed in IntegerFields, and ensure no IntegerField accepts negative values. (#10295)
(cherry picked from commit 5aa76c203035d41b1b9de10f61367f668ec8be4c)
Services: Kea DHCPv6: Always start the prefix watcher when DHCPv6 is enabled. A reservation with a prefix but without a configured pd_pool is also valid, it's more pragmatic to allow it than doing some complex validation gymnastics to prevent it. (#10329)
(cherry picked from commit f7c1d8339837a63dd176ae5373dab0860418e5c1)
