OPNSense/core e64b71dsrc/opnsense/www/js opnsense.js

mvc: form handling, html decode <select> values, closes https://github.com/opnsense/core/issues/8735
DeltaFile
+4-2src/opnsense/www/js/opnsense.js
+4-21 files

OPNSense/core 2d2781c. plist, src/opnsense/mvc/app/models/OPNsense/Dnsmasq Dnsmasq.xml

dnsmasq: strict hostname and domain validation (#9232)

* Strict hostname validation in Hosts tab using legal_hostname() function of upstream source code as baseline.
* Use HostnameField for "host", "domain", "cnames" and "aliases" field, merge former AliasesField logic into HostnameField for LegacyXML configs
* Remove AliasesField
* Add php unit test for HostnameField
DeltaFile
+174-0src/opnsense/mvc/app/models/OPNsense/Dnsmasq/FieldTypes/HostnameField.php
+150-0src/opnsense/mvc/tests/app/models/OPNsense/Dnsmasq/FieldTypes/HostnameFieldTest.php
+0-64src/opnsense/mvc/app/models/OPNsense/Dnsmasq/FieldTypes/AliasesField.php
+9-13src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.xml
+2-1plist
+335-785 files

OPNSense/core abb4b44src/opnsense/scripts/interfaces capture.py

diagnostics/packetcapture: Fix permission of capture zip file for wwwonly strict security mode (#9255)

* diagnostics/packetcapture: Fix permission of capture zip file when wwwonly strict security mode is enabled

* Unconditionally set wwwonly:wheel

* Also set permissions to 640
DeltaFile
+6-0src/opnsense/scripts/interfaces/capture.py
+6-01 files

OPNSense/core 75310e8src/opnsense/scripts/interfaces capture.py

Also set permissions to 640
DeltaFile
+1-0src/opnsense/scripts/interfaces/capture.py
+1-01 files

OPNSense/core 0d1d112src/opnsense/scripts/interfaces capture.py

Unconditionally set wwwonly:wheel
DeltaFile
+2-9src/opnsense/scripts/interfaces/capture.py
+2-91 files

OPNSense/core 9c5c48asrc/opnsense/scripts/interfaces capture.py

diagnostics/packetcapture: Fix permission of capture zip file when wwwonly strict security mode is enabled
DeltaFile
+12-0src/opnsense/scripts/interfaces/capture.py
+12-01 files

OPNSense/core 2998219src/opnsense/mvc/app/controllers/OPNsense/Wireguard/forms dialogEditWireguardServer.xml, src/opnsense/mvc/app/models/OPNsense/Wireguard Server.xml

vpn/wireguard: Add debug flag to instances, can be set without restarting service, send logs to wireguard log (#9236)

* vpn/wireguard: Add debug flag to instances, can be set without restarting service, send logs to wireguard log

* Add debug as comment into wireguard-server.conf, so the file hash changes and wg_start() is triggered

* Update src/opnsense/mvc/app/controllers/OPNsense/Wireguard/forms/dialogEditWireguardServer.xml

Co-authored-by: Franco Fichtner <franco at opnsense.org>

---------

Co-authored-by: Franco Fichtner <franco at opnsense.org>
DeltaFile
+11-0src/opnsense/mvc/app/controllers/OPNsense/Wireguard/forms/dialogEditWireguardServer.xml
+5-1src/opnsense/mvc/app/models/OPNsense/Wireguard/Server.xml
+2-0src/opnsense/scripts/wireguard/wg-service-control.php
+1-0src/opnsense/service/templates/OPNsense/Syslog/local/wireguard.conf
+1-0src/opnsense/service/templates/OPNsense/Wireguard/wireguard-server.conf
+20-15 files

OPNSense/core 9ec43d2src/opnsense/mvc/tests/app/models/OPNsense/Dnsmasq/FieldTypes LegalHostnameFieldTest.php

Since AsList is used add a test for it, also add one more value to the ValidLabels
DeltaFile
+17-1src/opnsense/mvc/tests/app/models/OPNsense/Dnsmasq/FieldTypes/LegalHostnameFieldTest.php
+17-11 files

OPNSense/core 51d52d4src/opnsense/mvc/app/models/OPNsense/Dnsmasq/FieldTypes LegalHostnameField.php

Fix one small issue the unit test found
DeltaFile
+3-1src/opnsense/mvc/app/models/OPNsense/Dnsmasq/FieldTypes/LegalHostnameField.php
+3-11 files

OPNSense/core 7b19fbe. plist, src/opnsense/mvc/tests/app/models/OPNsense/Dnsmasq/FieldTypes LegalHostnameFieldTest.php

Add php unit test for LegalHostnameField
DeltaFile
+134-0src/opnsense/mvc/tests/app/models/OPNsense/Dnsmasq/FieldTypes/LegalHostnameFieldTest.php
+1-0plist
+135-02 files

OPNSense/core 55f4726src/etc/inc filter.inc system.inc, src/www system_advanced_firewall.php

firewall: adapt default table size for #9110

While here simplify the code and rename the functions.
DeltaFile
+27-18src/etc/inc/filter.inc
+0-15src/etc/inc/system.inc
+2-2src/www/system_advanced_firewall.php
+29-353 files

OPNSense/core f1e0bbc. plist, src/opnsense/mvc/app/models/OPNsense/Dnsmasq Dnsmasq.xml

Use LegalHostnameField for Cname and Aliases field, merge AliasesField logic into LegalHostnameField for LegacyXML configs
DeltaFile
+85-31src/opnsense/mvc/app/models/OPNsense/Dnsmasq/FieldTypes/LegalHostnameField.php
+0-64src/opnsense/mvc/app/models/OPNsense/Dnsmasq/FieldTypes/AliasesField.php
+8-7src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.xml
+0-1plist
+93-1034 files

OPNSense/core 9f29b3f. plist, src/opnsense/mvc/app/models/OPNsense/Dnsmasq Dnsmasq.xml

Change approach for validation, reduce code duplication
DeltaFile
+64-44src/opnsense/mvc/app/models/OPNsense/Dnsmasq/FieldTypes/LegalHostnameField.php
+0-106src/opnsense/mvc/app/models/OPNsense/Dnsmasq/FieldTypes/LegalDomainField.php
+3-1src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.xml
+0-1plist
+67-1524 files

OPNSense/core 604b9b1src/opnsense/scripts/wireguard wg-service-control.php

reduce diff
DeltaFile
+1-0src/opnsense/scripts/wireguard/wg-service-control.php
+1-01 files

OPNSense/core 06341cdsrc/opnsense/mvc/app/controllers/OPNsense/Wireguard/forms dialogEditWireguardServer.xml

Update src/opnsense/mvc/app/controllers/OPNsense/Wireguard/forms/dialogEditWireguardServer.xml

Co-authored-by: Franco Fichtner <franco at opnsense.org>
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/Wireguard/forms/dialogEditWireguardServer.xml
+1-11 files

OPNSense/core 55ccb74src/opnsense/scripts/wireguard wg-service-control.php, src/opnsense/service/templates/OPNsense/Wireguard wireguard-server.conf

Add debug as comment into wireguard-server.conf, so the file hash changes and wg_start() is triggered
DeltaFile
+1-12src/opnsense/scripts/wireguard/wg-service-control.php
+1-0src/opnsense/service/templates/OPNsense/Wireguard/wireguard-server.conf
+2-122 files

OPNSense/core 2e06f24src/opnsense/service/modules processhandler.py, src/opnsense/service/modules/actions script_output.py base.py

configd: add ! operator to execute and flush cache when it exists, closes https://github.com/opnsense/core/issues/9170

Fix a small unnoticed bug in ActionHandler.find_action(), which flushed the action parameter after use.
Refactor HandlerClient so it extracts "preludes" like spaces, &, ! which it will then use to determine command operation mode.

Leading spaces are removed on purpose so we support actions like "&!cmd" "& ! cmd", since the first parameter is always a file on disk, leading spaces can't exist in current callers.

(cherry picked from commit 27bd8125c3868be56f11a7d91b00f6ec5b187abe)
DeltaFile
+17-6src/opnsense/service/modules/processhandler.py
+11-0src/opnsense/service/modules/actions/script_output.py
+3-0src/opnsense/service/modules/actions/base.py
+31-63 files

OPNSense/core dd32a27src/etc/inc auth.inc, src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api OverviewController.php

Merge remote-tracking branch 'origin/master' into firewall-automation-responsiveness
DeltaFile
+20-5src/opnsense/mvc/app/views/OPNsense/Core/hasync_status.volt
+2-2src/opnsense/mvc/app/models/OPNsense/Unbound/Unbound.xml
+2-2src/etc/inc/auth.inc
+3-0src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/OverviewController.php
+27-94 files

OPNSense/core 165c945src/opnsense/mvc/app/models/OPNsense/Unbound Unbound.xml

unbound: minor change on record labels

(cherry picked from commit b033d87ce27afc965294ad84581a101d9da12588)
DeltaFile
+2-2src/opnsense/mvc/app/models/OPNsense/Unbound/Unbound.xml
+2-21 files

OPNSense/core b033d87src/opnsense/mvc/app/models/OPNsense/Unbound Unbound.xml

unbound: minor change on record labels
DeltaFile
+2-2src/opnsense/mvc/app/models/OPNsense/Unbound/Unbound.xml
+2-21 files

OPNSense/core ab3cf5asrc/opnsense/mvc/app/views/OPNsense/Core hasync_status.volt

core/hasync: Fix reconfigure control on small viewports (#9250)

(cherry picked from commit efed0ea116349f3f7b650175f69bd9918a3a3242)
DeltaFile
+20-5src/opnsense/mvc/app/views/OPNsense/Core/hasync_status.volt
+20-51 files

OPNSense/core d20c51dsrc/opnsense/mvc/app/models/OPNsense/Base/FieldTypes ModelRelationField.php

mvc: do the same for ModelRelationField as https://github.com/opnsense/core/pull/9174 (https://github.com/opnsense/core/issues/9224)

(cherry picked from commit 35d5fcd834d55652de81067172e60f5a0adec7ac)
DeltaFile
+0-13src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ModelRelationField.php
+0-131 files

OPNSense/core 2c0b2desrc/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api OverviewController.php

interfaces/overview: Fix flags in interface details, do not show hex code but parsed flags (#9243)

(cherry picked from commit 3ced76c9ab31311a7f715705cf170be6c32dc932)
DeltaFile
+3-0src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/OverviewController.php
+3-01 files

OPNSense/core 7a4d7b4src/opnsense/www/js opnsense_ui.js

ui: do not add an option into an empty optgroup fixes GIF/GRE local address

(cherry picked from commit b2bcedbe5d4e6f53fabf465e6620b49008e4d5d3)
(cherry picked from commit 5eddbce452d36dad8883a785f1f2fa7f42820c6c)
DeltaFile
+1-1src/opnsense/www/js/opnsense_ui.js
+1-11 files

OPNSense/core 04da9easrc/etc/inc auth.inc

auth: safeguard legacy local_sync_accounts() (ref: https://forum.opnsense.org/index.php?topic=48797.msg247935#msg247935)
DeltaFile
+2-2src/etc/inc/auth.inc
+2-21 files

OPNSense/core efed0easrc/opnsense/mvc/app/views/OPNsense/Core hasync_status.volt

core/hasync: Fix reconfigure control on small viewports (#9250)

DeltaFile
+20-5src/opnsense/mvc/app/views/OPNsense/Core/hasync_status.volt
+20-51 files

OPNSense/core 78b86ddsrc/opnsense/mvc/app/views/OPNsense/Core hasync_status.volt

Fix review comments
DeltaFile
+1-5src/opnsense/mvc/app/views/OPNsense/Core/hasync_status.volt
+1-51 files

OPNSense/core 969d048src/opnsense/mvc/app/views/OPNsense/Core hasync_status.volt

core/hasync: Fix reconfigure control on small viewports
DeltaFile
+24-5src/opnsense/mvc/app/views/OPNsense/Core/hasync_status.volt
+24-51 files

OPNSense/core a829f5esrc/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

This style is not needed
DeltaFile
+0-3src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+0-31 files

OPNSense/core eac65fasrc/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

Make header even more responsive by allowing selectpickers to shrink and stretch in a flexbox, but only to a certain limit
DeltaFile
+48-6src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+48-61 files