OPNSense/core b8356e8src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterBaseController.php

filter / style - remove excess comma leading to parse errors in our api documentation parser (collect_api_endpoints.py)

(cherry picked from commit 12aab2a9e02eea34949aec9122368d8948ba9db6)
(cherry picked from commit 172759231107bed18e65bfda54b03d6a5ed64880)
DeltaFile
+1-3src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php
+1-31 files

OPNSense/core 1727592src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterBaseController.php

firewall: style for previous
DeltaFile
+1-3src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php
+1-31 files

OPNSense/core f87eb7asrc/etc config.xml.sample

system: move to old location for better diff

(cherry picked from commit 1ddc661a496ffe125da9217a95b4a5cc0788a6f5)
DeltaFile
+1-1src/etc/config.xml.sample
+1-11 files

OPNSense/core a5a1678src/etc/inc config.inc, src/opnsense/mvc/app/library/OPNsense/Core Syslog.php

mvc: support verbose logging in run_migrations.php

PR: https://github.com/opnsense/core/issues/9666

(cherry picked from commit 816fd574c9113d836363ab989d120b1856827097)
(cherry picked from commit be4900b112f122a8e2d90efe4aaff05ea9e4a033)
(cherry picked from commit 5cc95f47a6e43abdf1158511408a53570d12d1d8)
(cherry picked from commit ffe3b4087263e50e884768a8b18512f894f13226)
(cherry picked from commit 60deb9d8c4c2e5071ceacb1a0233af10556397bd)
DeltaFile
+20-0src/opnsense/mvc/app/library/OPNsense/Core/Syslog.php
+18-1src/opnsense/mvc/script/run_migrations.php
+7-4src/sbin/pluginctl
+1-1src/etc/inc/config.inc
+46-64 files

OPNSense/core 2b6b3e0src/opnsense/mvc/app/library/OPNsense/Core ConfigMaintenance.php, src/www interfaces.php

interfaces: check dhcpdv6.enabled for -1 and add legacy config sections

PR: https://forum.opnsense.org/index.php?topic=50580.0

(cherry picked from commit 35575f9446e4ef41b8830d83e3fc0b3fb8ac154f)
(cherry picked from commit c264c905042ec7e06b96a1f1d0f082826ec2ccd7)
DeltaFile
+3-1src/opnsense/mvc/app/library/OPNsense/Core/ConfigMaintenance.php
+2-2src/www/interfaces.php
+5-32 files

OPNSense/core c6540bfsrc/opnsense/mvc/app/controllers/OPNsense/Diagnostics/forms ping.xml, src/opnsense/mvc/app/models/OPNsense/Diagnostics Ping.xml

Interfaces: Diagnostics: Ping - add optional interval (seconds), closes https://github.com/opnsense/core/issues/9695
DeltaFile
+7-0src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/forms/ping.xml
+4-0src/opnsense/mvc/app/models/OPNsense/Diagnostics/Ping.xml
+3-0src/opnsense/scripts/interfaces/ping.py
+14-03 files

OPNSense/core 35c0ef5src/etc/inc interfaces.inc, src/opnsense/scripts/interfaces rtsold_script.sh

interfaces: multi-dhcp6c support and custom PD association #7647

This splits off rtsold and dhcp6c into separate processes
which frees us from the restrictions of faked iterative IDs
for PD associations.  For NA we simply default to 0 now.

I'm not entirely sure why we settled for a single deamon of
dhcp6c back in the day, but there are certianly downsides to
it and I don't see something that wasn't fixed in the meantime
that makes this not work.
DeltaFile
+22-58src/etc/inc/interfaces.inc
+58-4src/www/interfaces.php
+6-6src/opnsense/scripts/interfaces/rtsold_script.sh
+86-683 files

OPNSense/core d31faf7src/opnsense/mvc/app/library/OPNsense/Core Shell.php

mvc: shield exec_safe() against "fatal" type errors

Allows the system to boot in the worst case and replaces the
command with a simple dummy command.

Formatters are still a work in progress as I'm not sure how
much preprocessing we should add here to fish for vsprintf()
doing type casts to int/float which is not something the command
line can/should support.
DeltaFile
+10-1src/opnsense/mvc/app/library/OPNsense/Core/Shell.php
+10-11 files

OPNSense/core eeb93a7src/opnsense/mvc/app/library/OPNsense/Firewall Plugin.php

firewall: fix 2f60fcb062cff removing anchor rendering

PR: https://forum.opnsense.org/index.php?topic=50520.0
(cherry picked from commit 311184daa8bdbe2ff5cfc54fdf69841d84655216)
DeltaFile
+2-0src/opnsense/mvc/app/library/OPNsense/Firewall/Plugin.php
+2-01 files

OPNSense/core 05b6330src/opnsense/scripts/health/library/OPNsense/RRD/Types Base.php

reporting: render RRD integer as string

PR: https://github.com/opnsense/core/issues/9686

(cherry picked from commit ca06d54676942764b352339611c3ad9cfcf6906f)
(cherry picked from commit 70629923bb6aef9a9f3a983725c830f021bd4178)
DeltaFile
+1-1src/opnsense/scripts/health/library/OPNsense/RRD/Types/Base.php
+1-11 files

OPNSense/core 94cabd9src/etc/inc/plugins.inc.d radvd.inc

radvd: When Base6Interface is set, use its primary WAN IPv6 address and always prefer its IPv6 address before the advertising interfaces IPv6 address.
DeltaFile
+11-4src/etc/inc/plugins.inc.d/radvd.inc
+11-41 files

OPNSense/core f76921asrc/etc/inc/plugins.inc.d radvd.inc

radvd: In case of Base6Interface constructor, use link-local address as there will not be a primary address on the same interface. This will also cause the automatic rdnss option to become a link local IP address.
DeltaFile
+3-1src/etc/inc/plugins.inc.d/radvd.inc
+3-11 files

OPNSense/core 6933841src/opnsense/scripts/health/library/OPNsense/RRD/Types Base.php

reporting: render RRD integer as string

PR: https://github.com/opnsense/core/issues/9686

(cherry picked from commit ca06d54676942764b352339611c3ad9cfcf6906f)
(cherry picked from commit 70629923bb6aef9a9f3a983725c830f021bd4178)
DeltaFile
+1-1src/opnsense/scripts/health/library/OPNsense/RRD/Types/Base.php
+1-11 files

OPNSense/core 7062992src/opnsense/mvc/app/library/OPNsense/Core Shell.php, src/opnsense/scripts/health/library/OPNsense/RRD/Types Base.php

reporting: render as string instead for #9686

Revert ca06d54676942764b3.  A command line is a string and
don't offer exceptions to escaping.

We may consider replacing %[^s%] with %s in the format
string but there aren't many cases where it matters either.
Should just be part of the documentation we need to offer
soon.
DeltaFile
+2-1src/opnsense/mvc/app/library/OPNsense/Core/Shell.php
+1-1src/opnsense/scripts/health/library/OPNsense/RRD/Types/Base.php
+3-22 files

OPNSense/core ca06d54src/opnsense/mvc/app/library/OPNsense/Core Shell.php

backend: fix regression in https://github.com/opnsense/core/commit/796a5c725bc6dd90a5f425e3b0ebf89054606a02, when using %d or %f as formatters, we can't push them through escapeshellarg() as it will mangle the data unneeded. closes https://github.com/opnsense/core/issues/9686
DeltaFile
+1-2src/opnsense/mvc/app/library/OPNsense/Core/Shell.php
+1-21 files

OPNSense/core 311184dsrc/opnsense/mvc/app/library/OPNsense/Firewall Plugin.php

firewall: fix 2f60fcb062cff removing anchor rendering

PR: https://forum.opnsense.org/index.php?topic=50520.0
DeltaFile
+2-0src/opnsense/mvc/app/library/OPNsense/Firewall/Plugin.php
+2-01 files

OPNSense/core 5cbec07src/etc/inc interfaces.inc, src/opnsense/scripts/interfaces rtsold_script.sh

interfaces: multi-dhcp6c support and custom PD association #7647

This splits off rtsold and dhcp6c into separate processes
which frees us from the restrictions of faked iterative IDs
for PD associations.  For NA we simply default to 0 now.

I'm not entirely sure why we settled for a single deamon of
dhcp6c back in the day, but there are certianly downsides to
it and I don't see something that wasn't fixed in the meantime
that makes this not work.
DeltaFile
+22-58src/etc/inc/interfaces.inc
+58-4src/www/interfaces.php
+6-6src/opnsense/scripts/interfaces/rtsold_script.sh
+86-683 files

OPNSense/core cd653ddsrc/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogFilterRule.xml, src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

Firewall: Rules [new]: Statistics column is responsive now
DeltaFile
+13-9src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+0-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
+13-102 files

OPNSense/core 0f6cc03src/opnsense/mvc/app/models/OPNsense/Firewall DNat.xml, src/opnsense/mvc/app/views/OPNsense/Firewall dnat_rule.volt

Firewall: NAT: Destination NAT: The local-port field does not support range and well-known name (#9668)

* Make validation messages clearer
* Use selector in loop to determine where to replace the data (just the label is changed)
DeltaFile
+9-1src/opnsense/mvc/app/views/OPNsense/Firewall/dnat_rule.volt
+3-3src/opnsense/mvc/app/models/OPNsense/Firewall/DNat.xml
+12-42 files

OPNSense/core c264c90src/opnsense/mvc/app/library/OPNsense/Core ConfigMaintenance.php, src/www interfaces.php

interfaces: check dhcpdv6.enabled for -1 and add legacy config sections

PR: https://forum.opnsense.org/index.php?topic=50580.0
DeltaFile
+2-2src/www/interfaces.php
+2-0src/opnsense/mvc/app/library/OPNsense/Core/ConfigMaintenance.php
+4-22 files

OPNSense/core 889098csrc/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterBaseController.php

Firewall: Rules [new]: FilterBaseController requires Base\UserException (#9669)

(cherry picked from commit ec20be4dd42be415d44b1373c49ce7e336944de9)
DeltaFile
+1-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php
+1-01 files

OPNSense/core ec20be4src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterBaseController.php

Firewall: Rules [new]: FilterBaseController requires Base\UserException (#9669)

DeltaFile
+1-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php
+1-01 files

OPNSense/core ae22620src/etc/inc filter.lib.inc

firewall: fix typo with sprintf(); closes #9664

(cherry picked from commit 476ad93d6f380c18ee766353c15235e462864398)
DeltaFile
+1-1src/etc/inc/filter.lib.inc
+1-11 files

OPNSense/core dcef846src/opnsense/service/conf/actions.d actions_hostwatch.conf

interfaces: host discovery: make sure the full dump includes NDP output if hostwatch is disabled

(cherry picked from commit f7fac5a6f4ac9ba502acab688a6d8092d942d77d)
DeltaFile
+1-1src/opnsense/service/conf/actions.d/actions_hostwatch.conf
+1-11 files

OPNSense/core 96dd059src/opnsense/mvc/app/models/OPNsense/Interfaces/Migrations SET1_0_0.php

interfaces: fix migration for no-release option

This was introduced in d87ce014d96f storing the enabled value as "yes"
instead of true.  Threat it the same as the debug option.

PR: https://forum.opnsense.org/index.php?topic=50575.0 (and others)
(cherry picked from commit 7a11458ea23424dd475d394cb2f64015df257849)
DeltaFile
+1-1src/opnsense/mvc/app/models/OPNsense/Interfaces/Migrations/SET1_0_0.php
+1-11 files

OPNSense/core 8ecd344src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterBaseController.php

Firewall: Rules [new]: FilterBaseController requires Base\UserException
DeltaFile
+1-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php
+1-01 files

OPNSense/core 1a087bfsrc/opnsense/mvc/app/views/OPNsense/Firewall dnat_rule.volt

Use selector in loop to determine where to replace the data
DeltaFile
+9-3src/opnsense/mvc/app/views/OPNsense/Firewall/dnat_rule.volt
+9-31 files

OPNSense/core 7a11458src/opnsense/mvc/app/models/OPNsense/Interfaces/Migrations SET1_0_0.php

interfaces: fix migration for no-release option

This was introduced in d87ce014d96f storing the enabled value as "yes"
instead of true.  Threat it the same as the debug option.

PR: https://forum.opnsense.org/index.php?topic=50575.0 (and others)
DeltaFile
+1-1src/opnsense/mvc/app/models/OPNsense/Interfaces/Migrations/SET1_0_0.php
+1-11 files

OPNSense/core 32b37dfsrc/opnsense/mvc/app/models/OPNsense/Firewall DNat.xml

Make validation messages clearer
DeltaFile
+3-3src/opnsense/mvc/app/models/OPNsense/Firewall/DNat.xml
+3-31 files

OPNSense/core ac0e0dcsrc/opnsense/mvc/app/models/OPNsense/Firewall DNat.xml, src/opnsense/mvc/app/views/OPNsense/Firewall dnat_rule.volt

Firewall: NAT: Destination NAT: The local-port field does not support range and well-known name
DeltaFile
+5-3src/opnsense/mvc/app/views/OPNsense/Firewall/dnat_rule.volt
+1-1src/opnsense/mvc/app/models/OPNsense/Firewall/DNat.xml
+6-42 files