BSD Commit Log Search

tests: ConfigTest: we can cast and do not need save

tests: add a Core\Config class test for toArray/fromArray

tests: BaseModelTest: disable backups and mock revision

Change class invokes to self and add a $configDir variable.

system: remove long obsolete snmpd section from default config

Apply suggestions from code review

Co-authored-by: Franco Fichtner <franco at opnsense.org>

tests: unwind BaseModel test side effect on AclConfig

Give the test its own empty config to migrate into, which makes
resetting it irrelevant.  A tiny bit of magic is needed to bootstrap
a config.xml so it's not the one that is checked in and we also
remove the temporary files from the tree so it does not confuse git.

save() is a far-reaching side effect in the test, but more or less
necessary for better test coverage.  But I'd still want a simpler
test around Core\Config and this offers merely offers the groundwork
also removing the need to reset this from make commands.

mvc: advertise use of Config instead of just using it in ACL

Change general header in dialog to organization, to be in line with firewall filter dialog

Using / in labels messes with the label in column headers

Turn moveRuleBeforeAction() and toggleRuleLogAction() into shared based methods

unbound: ditch dnsbl_available and bind around self.dnsbl

Services: Unbound DNS - fix "configctl unbound check" as it doesn't use a chroot.

ref: https://forum.opnsense.org/index.php?topic=49989.0

These labels are not needed in grid_view

nat/one-to-one: Refactor UI part to be in line with other firewall components

nat/one-to-one: Refactor UI part to be in line with other firewall components

nat/one-to-one: Refactor UI part to be in line with other firewall components

unbound: clean up marker and size files, closes #9489

nat/one-to-one: Refactor UI part to be in line with other firewall components

nat/one-to-one: Refactor UI part to be in line with other firewall components

System/Logging - bugfix for https://github.com/opnsense/core/commit/803a2615b381e679dfb69e7f5b833f19f53b6e4a, record should be None when not matched.

(cherry picked from commit 8cf3898282561e55c05849e00db69579bbe520f7)

nat/one-to-one: Refactor UI part to be in line with other firewall components

System/Logging - bugfix for https://github.com/opnsense/core/commit/803a2615b381e679dfb69e7f5b833f19f53b6e4a, record should be None when not matched.

firewall: slight simplification in filter sync script

Usually we can let static command line switches live in the format
string.  While here omit the use of the first $output assignment.

interfaces: unbreak neighbor apply

isc-dhcp: interalize interfaces_staticarp_configure(); closes #9476

Instead of making the interface code pluggable, push the code that
causes the persistent side effect to the ISC DHCP plugin which then
gets to fix the stuck static ARP flag after disable/deinstall and a
reboot.  The situation isn't ideal, but much better than before.

dnsmasq: Add DHCP logging flags which can influence log verbosity (#9480)

mvc: annotate previous too

Simplify and add a SingleSelectConstraint

mvc: FilterRuleField: remove the other strpos() and reformat

We don't actually know what the separator char is although it's very
likely the default getValues() will always do the right thing and
make the following test a tiny bit easier.

While unwiwnding the if-else we can do a few simplifications along
the way.

Split log-dhcp and the quiet-* flags into two options