OPNSense/core 7fcbb22src/etc/inc util.inc, src/etc/inc/plugins.inc.d dhcpd.inc

dhcp: merge_ipv6_address() was too intrusive

Testing 3582242d0fe10 it appeared that link-local addresses were
rewritten as GUAs in the dhcpd configuration.  The static map part
does this right, but all the other callers are not.  Flip this
around as it was intended.  The DHCPv6 page will now throw an out
of range error when it previously adjusted the explit prefix anyway.

dhcpd config with link local seems fine too, but more testing is
always good.
DeltaFile
+4-8src/etc/inc/plugins.inc.d/dhcpd.inc
+5-0src/etc/inc/util.inc
+9-82 files

OPNSense/core 066d836src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes TextFieldTest.php, src/opnsense/scripts/interfaces mpd.script

Multiple text corrections (#6867)

DeltaFile
+5-5src/opnsense/service/templates/OPNsense/IDS/suricata.yaml
+3-3src/opnsense/www/js/jquery.bootgrid.js
+3-3src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/TextFieldTest.php
+2-2src/opnsense/www/js/tokenize2.js
+2-2src/opnsense/www/themes/opnsense/assets/stylesheets/bootstrap/_forms.scss
+2-2src/opnsense/scripts/interfaces/mpd.script
+17-1714 files not shown
+31-3120 files

OPNSense/core b5c285fsrc/opnsense/mvc/app/models/OPNsense/Interfaces Vip.xml

interfaces: VIP model style update

(cherry picked from commit 32f490b7e0b1890f678bfdcf7a966cbc3c7aaae3)
DeltaFile
+11-11src/opnsense/mvc/app/models/OPNsense/Interfaces/Vip.xml
+11-111 files

OPNSense/core d167da1src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper ServiceController.php, src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes Base64Field.php ArrayField.php

mvc: style updates

(cherry picked from commit bca764d307f65068cd15fd65c0b8e6445fa752a1)
DeltaFile
+22-24src/opnsense/mvc/app/models/OPNsense/Unbound/FieldTypes/UnboundServerField.php
+21-23src/opnsense/mvc/app/models/OPNsense/IPsec/FieldTypes/VTIField.php
+21-23src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/ServiceController.php
+20-22src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/Base64Field.php
+3-3src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ArrayField.php
+2-2src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/NetworkAliasField.php
+89-972 files not shown
+92-1008 files

OPNSense/core 1081b52src/opnsense/mvc/app/library/OPNsense/Firewall Util.php

mvc: add isLinkLocal() for #6775

(cherry picked from commit e29a4e009dfc461d91268ca3e320973288dcbb91)
DeltaFile
+11-1src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php
+11-11 files

OPNSense/core d945c1bsrc/opnsense/mvc/app/controllers/OPNsense/IPsec/forms dialogPool.xml

ipsec: help text update
DeltaFile
+1-5src/opnsense/mvc/app/controllers/OPNsense/IPsec/forms/dialogPool.xml
+1-51 files

OPNSense/core 11bbafesrc/opnsense/mvc/app/controllers/OPNsense/IPsec/forms dialogPool.xml

ipsec: improve new help texts
DeltaFile
+2-7src/opnsense/mvc/app/controllers/OPNsense/IPsec/forms/dialogPool.xml
+2-71 files

OPNSense/core e90ea22src/etc rc.bootup

system: start gateway monitors after firewall rules are in place (#6874)

During bootup the gateway monitors were started before the firewall rules
were finished setting up. Under some circumstances this could lead to
incorrect data being reported by dpinger instances.

(cherry picked from commit 79355e36411bfd74745b81b2d353d08d0d07b624)
DeltaFile
+1-1src/etc/rc.bootup
+1-11 files

OPNSense/core 58c50f4src/opnsense/mvc/app/models/OPNsense/OpenVPN OpenVPN.php

openvpn: add up and down scripts to vpn instance configs (#6879)

(cherry picked from commit f53a60c91182d892c1bb0227da5804a1cace2ac9)
DeltaFile
+2-0src/opnsense/mvc/app/models/OPNsense/OpenVPN/OpenVPN.php
+2-01 files

OPNSense/core 0995fabsrc/opnsense/mvc/app/models/OPNsense/Interfaces Vip.php Vip.xml

interfaces: make link-local vips unique per interface #6775
DeltaFile
+27-3src/opnsense/mvc/app/models/OPNsense/Interfaces/Vip.php
+0-6src/opnsense/mvc/app/models/OPNsense/Interfaces/Vip.xml
+27-92 files

OPNSense/core f53a60csrc/opnsense/mvc/app/models/OPNsense/OpenVPN OpenVPN.php

openvpn: add up and down scripts to vpn instance configs (#6879)

DeltaFile
+2-0src/opnsense/mvc/app/models/OPNsense/OpenVPN/OpenVPN.php
+2-01 files

OPNSense/core 45c940fsrc/opnsense/mvc/app/models/OPNsense/Base/FieldTypes CSVListField.php

mvc: style update
DeltaFile
+0-1src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/CSVListField.php
+0-11 files

OPNSense/core a4b9e92src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes IntegerField.php

mvc: IntegerField validation message update
DeltaFile
+14-10src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/IntegerField.php
+14-101 files

OPNSense/core 8d340ffsrc/opnsense/mvc/app/models/OPNsense/Base/FieldTypes NetworkField.php

mvc: NetworkField validation message update
DeltaFile
+11-8src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/NetworkField.php
+11-81 files

OPNSense/core b300595src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes HostnameField.php

mvc: HostnameField validation message
DeltaFile
+12-9src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/HostnameField.php
+12-91 files

OPNSense/core 7fab024src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes EmailField.php

mvc: EmailField validation msg
DeltaFile
+6-3src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/EmailField.php
+6-31 files

OPNSense/core 90c5db7src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes CSVListField.php

mvc: CSVListField validation message update

MaskPerItem=Y needs work and the preg_match() shoudldn't be used
to look inside the match which creates the initial problem:

/usr/local/opnsense/mvc/app/controllers/OPNsense/Base/ApiControllerBase.php:176:
Error at /usr/local/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/CSVListField.php:162 - Undefined array key 0 (errno=2)
DeltaFile
+11-7src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/CSVListField.php
+11-71 files

OPNSense/core 5d89666src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes AutoNumberField.php

mvc: AutoNumberField validation message update
DeltaFile
+15-10src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/AutoNumberField.php
+15-101 files

OPNSense/core cf80131src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes BooleanField.php

mvc: BooleanField validation message and faulty regex fix
DeltaFile
+9-7src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BooleanField.php
+9-71 files

OPNSense/core 3363fa9src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes Base64Field.php

mvc: Base64Field validation message update
DeltaFile
+8-2src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/Base64Field.php
+8-21 files

OPNSense/core 8aff5a9src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes NumericField.php, src/opnsense/mvc/app/models/OPNsense/Firewall Alias.xml

mvc: NumericField validation message update
DeltaFile
+17-12src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/NumericField.php
+1-1src/opnsense/mvc/app/models/OPNsense/Firewall/Alias.xml
+18-132 files

OPNSense/core 2cd5fcasrc/opnsense/mvc/app/models/OPNsense/Base/FieldTypes UniqueIdField.php

mvc: UnqiueIdField special validation message

If we ever derive from UnqiueIdField we would end up overwriting
this message and there is no data validation involved which the
message would be for so it can be null as per BaseField.
DeltaFile
+4-7src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/UniqueIdField.php
+4-71 files

OPNSense/core 8d8cc03src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes UrlField.php, src/opnsense/mvc/app/models/OPNsense/Firewall Alias.xml

mvc: UrlField validation message cleanup
DeltaFile
+6-3src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/UrlField.php
+1-2src/opnsense/mvc/app/models/OPNsense/Firewall/Alias.xml
+0-1src/opnsense/mvc/app/models/OPNsense/Proxy/Proxy.xml
+7-63 files

OPNSense/core c8afb0f. plist, src/opnsense/mvc/app/controllers/OPNsense/Gateways/Api ServiceController.php SettingsController.php

remove serviceController
DeltaFile
+0-59src/opnsense/mvc/app/controllers/OPNsense/Gateways/Api/ServiceController.php
+0-26src/opnsense/service/conf/actions.d/actions_gateways.conf
+12-0src/opnsense/mvc/app/controllers/OPNsense/Gateways/Api/SettingsController.php
+1-3src/opnsense/mvc/app/views/OPNsense/Gateways/configuration.volt
+0-2plist
+13-905 files

OPNSense/core 465f7fasrc/opnsense/mvc/app/models/OPNsense/Firewall Group.xml, src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes GroupNameField.php

mvc: set Required=Y for GroupNameField

The validation message is never seen anymore and can't be overridden.
While the field made sure to emit a message on empty the result is
that if we ever have to use this group field as optional we would have
to pivot to this approach anyway.
DeltaFile
+1-6src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/GroupNameField.php
+1-0src/opnsense/mvc/app/models/OPNsense/Firewall/Group.xml
+2-62 files

OPNSense/core ac0fcaasrc/opnsense/mvc/app/models/OPNsense/Base/FieldTypes ConfigdActionsField.php AuthenticationServerField.php, src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes AliasContentField.php AliasNameField.php

mvc: remove special validation messages likely never seen

We could use defaultValidationMessage() but the BaseListField message
is fitting enough and the GUI itself cannot cause this to happen.
The reason for stripping is also that the variable is not handled by
the field so there is no special validation meaning attached either.

For BaseField derivates the idea was to set a custom required validation
message which is no longer possible or possibly not even reachable.
DeltaFile
+0-7src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/AliasContentField.php
+0-5src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ConfigdActionsField.php
+0-5src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/AuthenticationServerField.php
+0-5src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/AliasNameField.php
+0-224 files

OPNSense/core 9cb123csrc/www interfaces_assign.php

interfaces: fix a PHP warning and make a comment about floating rules
DeltaFile
+2-1src/www/interfaces_assign.php
+2-11 files

OPNSense/core 896ade7. plist, src/opnsense/mvc/tests/app/models/OPNsense/Base/Constraints UniqueConstraintTest.php

src: sweep
DeltaFile
+1-1src/opnsense/mvc/tests/app/models/OPNsense/Base/Constraints/UniqueConstraintTest.php
+1-0plist
+2-12 files

OPNSense/core 7dcb31csrc/opnsense/mvc/app/models/OPNsense/Base/FieldTypes BaseListField.php TextField.php

mvc: improve field validation message handling (#6872)

* provide defaultValidationMessage() to inject gettext-supported string
* assume $internalValidationMessage can only be set by XML now
* the goal here is to translate and improve all the field validation messages
DeltaFile
+10-16src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseListField.php
+12-7src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/TextField.php
+18-0src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php
+5-9src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/PortField.php
+2-9src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/NetworkAliasField.php
+47-415 files

OPNSense/core d2eb2fcsrc/opnsense/mvc/tests/app/models/OPNsense/Base/Constraints UniqueConstraintTest.php

UniqueConstraint: add test cases (#6875)

Since UniqueConstraint was worked on recently, some test cases to accomodate all scenarios
DeltaFile
+182-0src/opnsense/mvc/tests/app/models/OPNsense/Base/Constraints/UniqueConstraintTest.php
+182-01 files