OPNSense/core 7bb4008src/opnsense/scripts/filter/lib/alias __init__.py

Firewall: Aliases - expire geoip aliases when there's either no database installed or its newer than the alias contents populated. closes https://github.com/opnsense/core/issues/9374

In the long run we should probably refactor the alias class so different types can have their own implementations, but this has a lot more impact than injecting a specific expire() implementation for geoip information at its current spot.

The additional advantage of this change is it will update aliases before their TTL expires when the geoip database is newer than the alias content.
DeltaFile
+13-0src/opnsense/scripts/filter/lib/alias/__init__.py
+13-01 files

OPNSense/core 33e2961src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api DNatController.php, src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes ProtocolField.php BaseField.php

mvc: add ChangeCase support to ProtocolField for DNAT special case (#9643)

Use the ChangeCase BaseField extension because it's already being tested
and add more tests and safeguards so that the cache knows which case is
going on (also if 'any' needs to be used).

The 'any' value is a bit tricky here.  Force it to lowercase in all cases
since it wasn't uppercased before either.

Also fix the display of anti-lockout protocol for consistency.
DeltaFile
+48-32src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ProtocolFieldTest.php
+53-8src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ProtocolField.php
+20-17src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php
+2-1src/opnsense/mvc/app/models/OPNsense/Firewall/DNat.xml
+1-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/DNatController.php
+124-585 files

OPNSense/core 1f30870src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes ProtocolFieldTest.php

Apply suggestion from @fichtner
DeltaFile
+1-1src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ProtocolFieldTest.php
+1-11 files

OPNSense/core 6481ac7src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes ProtocolField.php

Apply suggestion from @fichtner
DeltaFile
+1-1src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ProtocolField.php
+1-11 files

OPNSense/core d0b3d00src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes BaseField.php

Apply suggestion from @fichtner
DeltaFile
+1-1src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php
+1-11 files

OPNSense/core 3a32bf9src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes BaseField.php

Apply suggestion from @fichtner
DeltaFile
+1-1src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php
+1-11 files

OPNSense/core 2b19239. plist, src/etc/rc.syshook.d/start 90-hostwatch

rc: hostwatch glitch should be gone in RC2 with latest package

PR: https://github.com/opnsense/hostwatch/issues/7
DeltaFile
+0-4src/etc/rc.syshook.d/start/90-hostwatch
+0-1plist
+0-52 files

OPNSense/core 23cdeb0src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes ProtocolField.php BaseField.php

mvc: small tweaks in CaseChange behaviour esp. for ProtocolField
DeltaFile
+32-11src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ProtocolField.php
+6-5src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php
+38-162 files

OPNSense/core 254f798src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes ProtocolFieldTest.php

mvc: add setAddOptions() to ProtocolField test
DeltaFile
+6-4src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ProtocolFieldTest.php
+6-41 files

OPNSense/core b136be9src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api DNatController.php, src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes ProtocolField.php BaseField.php

firewall: lowercase for protocol values required for DNAT

Use the ChangeCase BaseField extension because it's already being tested
and add more tests and safeguards so that the cache knows which case is
going on (also if 'any' needs to be used).

The 'any' value is a bit tricky here.  Force it to lowercase in all cases
since it wasn't uppercased before either.

Also fix the display of anti-lockout protocol for consistency.
DeltaFile
+45-31src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ProtocolFieldTest.php
+31-7src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ProtocolField.php
+16-14src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php
+2-1src/opnsense/mvc/app/models/OPNsense/Firewall/DNat.xml
+1-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/DNatController.php
+95-535 files

OPNSense/core fe145d9src/opnsense/service/templates/OPNsense/Hostdiscovery rc.conf.d

interfaces: do not handle hostwatch user/group from here
DeltaFile
+1-1src/opnsense/service/templates/OPNsense/Hostdiscovery/rc.conf.d
+1-11 files

OPNSense/core 24e42ccsrc/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes ProtocolFieldTest.php

mvc: add setAddOptions() to ProtocolField test
DeltaFile
+6-4src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ProtocolFieldTest.php
+6-41 files

OPNSense/core 5109d91src/opnsense/mvc/app/views/OPNsense/Firewall firewall_migration.volt

Firewall: Rules: Migration assistant: Fix typos and improve clarity in migration instructions

(cherry picked from commit a1404a24954f721b355ea4b7d2a11ba1a47a9e53)
DeltaFile
+5-5src/opnsense/mvc/app/views/OPNsense/Firewall/firewall_migration.volt
+5-51 files

OPNSense/core a1404a2src/opnsense/mvc/app/views/OPNsense/Firewall firewall_migration.volt

Firewall: Rules: Migration assistant: Fix typos and improve clarity in migration instructions
DeltaFile
+5-5src/opnsense/mvc/app/views/OPNsense/Firewall/firewall_migration.volt
+5-51 files

OPNSense/core 4516d41src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

Firewall: Rules [new]: Escape selector in rule_protocol (#9642)

(cherry picked from commit b3fa25ee01d7b3050cb1a0149236901fbb20ea82)
DeltaFile
+5-3src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+5-31 files

OPNSense/core 4f784d0src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

Firewall: Rules [new]: Escape selector in rule_protocol (#9642)

(cherry picked from commit b3fa25ee01d7b3050cb1a0149236901fbb20ea82)
DeltaFile
+5-3src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+5-31 files

OPNSense/core d398482src/etc/inc/plugins.inc.d hostwatch.inc

Interfaces: Neighbors: Automatic Discovery - add xmlrpc registration, closes https://github.com/opnsense/core/issues/9628

(cherry picked from commit 63c3fe33f6b734373fa6a20a6843456843721bdf)
DeltaFile
+12-0src/etc/inc/plugins.inc.d/hostwatch.inc
+12-01 files

OPNSense/core bfd819fsrc/opnsense/scripts/openvpn ovpn_service_control.php

openvpn: account for CARP status in start and restart cases as well (#9634)

(cherry picked from commit 0b7c06f3a6d86c362ab9c9d81b6220d0c5a29814)
DeltaFile
+11-7src/opnsense/scripts/openvpn/ovpn_service_control.php
+11-71 files

OPNSense/core 32178f6src/opnsense/mvc/app/views/OPNsense/Firewall firewall_migration.volt

Firewall: Rules: Migration assistant: Fix typos and improve clarity in migration instructions
DeltaFile
+5-5src/opnsense/mvc/app/views/OPNsense/Firewall/firewall_migration.volt
+5-51 files

OPNSense/core 28ff02fsrc/opnsense/mvc/app/controllers/OPNsense/Firewall/Api DNatController.php, src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes ProtocolField.php BaseField.php

firewall: lowercase for protocol values required for DNAT

Use the ChangeCase BaseField extension because it's already being tested
and add more tests and safeguards so that the cache knows which case is
going on (also if 'any' needs to be used).

The 'any' value is a bit tricky here.  Force it to lowercase in all cases
since it wasn't uppercased before either.

Also fix the display of anti-lockout protocol for consistency.
DeltaFile
+45-31src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ProtocolFieldTest.php
+31-7src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ProtocolField.php
+16-14src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php
+2-1src/opnsense/mvc/app/models/OPNsense/Firewall/DNat.xml
+1-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/DNatController.php
+95-535 files

OPNSense/core da4883asrc/opnsense/mvc/app/models/OPNsense/Base/FieldTypes ProtocolField.php BaseField.php, src/opnsense/mvc/app/models/OPNsense/Firewall DNat.xml

firewall: lowercase for protocol values required for DNAT

Use the ChangeCase BaseField extension because it's already being tested
and add more tests and safeguards so that the cache knows which case is
going on (also if 'any' needs to be used).
DeltaFile
+45-31src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ProtocolFieldTest.php
+31-7src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ProtocolField.php
+16-14src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php
+2-1src/opnsense/mvc/app/models/OPNsense/Firewall/DNat.xml
+94-534 files

OPNSense/core 811a2f3src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes ProtocolField.php

fix
DeltaFile
+2-0src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ProtocolField.php
+2-01 files

OPNSense/core 6e0c447src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes ProtocolFieldTest.php

sfd
DeltaFile
+1-1src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ProtocolFieldTest.php
+1-11 files

OPNSense/core 7f52f4csrc/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes ProtocolFieldTest.php

fix and extend test case
DeltaFile
+38-24src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/ProtocolFieldTest.php
+38-241 files

OPNSense/core 826c29esrc/opnsense/mvc/app/models/OPNsense/Base/FieldTypes ProtocolField.php

of
DeltaFile
+1-1src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ProtocolField.php
+1-11 files

OPNSense/core 77ad946src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes ProtocolField.php

my mistake
DeltaFile
+2-2src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ProtocolField.php
+2-21 files

OPNSense/core e786aafsrc/opnsense/mvc/app/models/OPNsense/Base/FieldTypes ProtocolField.php

any is very special
DeltaFile
+16-0src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ProtocolField.php
+16-01 files

OPNSense/core 34cc30fsrc/opnsense/mvc/app/models/OPNsense/Base/FieldTypes ProtocolField.php

another
DeltaFile
+2-1src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ProtocolField.php
+2-11 files

OPNSense/core f3f36besrc/opnsense/mvc/app/models/OPNsense/Base/FieldTypes ProtocolField.php

any is in there twice when not required, also uppercase
DeltaFile
+4-1src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ProtocolField.php
+4-11 files

OPNSense/core e6a583asrc/opnsense/mvc/app/models/OPNsense/Base/FieldTypes BaseField.php ProtocolField.php

change inheritance
DeltaFile
+1-1src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php
+1-1src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ProtocolField.php
+2-22 files