OPNSense/core 25521f0src/opnsense/mvc/app/views/layout_partials base_form.volt

MVC:ui - refactor base_dialog and parseFormNode to simplify the template for https://github.com/opnsense/core/issues/9955 [2]

bugfix https://github.com/opnsense/core/commit/3d9cccfe4038802807219621ddd49cf668a05144
DeltaFile
+2-2src/opnsense/mvc/app/views/layout_partials/base_form.volt
+2-21 files

OPNSense/core bb78d31src/opnsense/mvc/app/controllers/OPNsense/Base ControllerBase.php

src: style sweep
DeltaFile
+6-4src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php
+6-41 files

OPNSense/core 3d9cccfsrc/opnsense/mvc/app/controllers/OPNsense/Base ControllerBase.php, src/opnsense/mvc/app/views/layout_partials base_form.volt base_dialog.volt

MVC:ui - refactor base_dialog and parseFormNode to simplify the template for https://github.com/opnsense/core/issues/9955 (#10410)

Move defaults to parseFormNode() and introduce "sections" with children to avoid some more magic in the volt templates.

Set default title on multi selectpickers as these sometimes seem to miss the "Nothing selected" phrase for some odd reason.

Functionally this should be a backward compatible change.
DeltaFile
+69-80src/opnsense/mvc/app/views/layout_partials/base_form.volt
+32-81src/opnsense/mvc/app/views/layout_partials/base_dialog.volt
+31-3src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php
+2-2src/opnsense/mvc/app/views/layout_partials/form_input_tr.volt
+134-1664 files

OPNSense/core c822d0esrc/opnsense/mvc/app/views/OPNsense/Diagnostics packetcapture.volt dns_diagnostics.volt

mvc/templates - remove direct apply_btn_id usage in favor of base_apply_button template partial. discussed in https://github.com/opnsense/core/pull/10410

Eventually we want to remove apply_btn_id from base_form completely, but since base_tabs_content is using the same construct and appears in quite some plugins, we have to postpone that action.
At least aim for consistency in the forms that only depend on base_form in core.
DeltaFile
+7-7src/opnsense/mvc/app/views/OPNsense/Diagnostics/packetcapture.volt
+7-7src/opnsense/mvc/app/views/OPNsense/Diagnostics/dns_diagnostics.volt
+7-7src/opnsense/mvc/app/views/OPNsense/Diagnostics/traceroute.volt
+7-7src/opnsense/mvc/app/views/OPNsense/Diagnostics/portprobe.volt
+7-5src/opnsense/mvc/app/views/OPNsense/Diagnostics/ping.volt
+35-335 files

OPNSense/core 86ac515src/opnsense/scripts/firmware config.sh

firmware: fix return value masking during updates

This caused reboots when updates not supposed to reboot
in case base/kernel could not install.  This way since
26.1.8.

(cherry picked from commit 2e90e6fbf77202efdbd599697951e6da12b78e26)
DeltaFile
+3-4src/opnsense/scripts/firmware/config.sh
+3-41 files

OPNSense/core 8d78389src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterController.php

Firewall: Rules: use strnatcasecmp() for interface list (#10412)

(cherry picked from commit 0fe799f7872cd8436fa896394dd3bb5fa03397ef)
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+1-11 files

OPNSense/core 7d65e57src/opnsense/mvc/app/controllers/OPNsense/Base ControllerBase.php, src/opnsense/mvc/app/views/layout_partials base_form.volt base_dialog.volt

MVC:ui - refactor base_dialog and parseFormNode to simplify the template for https://github.com/opnsense/core/issues/9955

Move defaults to parseFormNode() and introduce "sections" with children to avoid some more magic in the volt templates.

Set default title on multi selectpickers as these sometimes seem to miss the "Nothing selected" phrase for some odd reason.

Functionally this should be a backward compatible change.
DeltaFile
+69-80src/opnsense/mvc/app/views/layout_partials/base_form.volt
+32-81src/opnsense/mvc/app/views/layout_partials/base_dialog.volt
+31-3src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php
+2-2src/opnsense/mvc/app/views/layout_partials/form_input_tr.volt
+134-1664 files

OPNSense/core 8bd91cbsrc/opnsense/mvc/app/controllers/OPNsense/Base ControllerBase.php, src/opnsense/mvc/app/views/layout_partials base_form.volt base_dialog.volt

MVC:ui - refactor base_dialog and parseFormNode to simplify the template for https://github.com/opnsense/core/issues/9955

Move defaults to parseFormNode() and introduce "sections" with children to avoid some more magic in the volt templates.

Set default title on multi selectpickers as these sometimes seem to miss the "Nothing selected" phrase for some odd reason.

Functionally this should be a backward compatible change.
DeltaFile
+69-80src/opnsense/mvc/app/views/layout_partials/base_form.volt
+32-81src/opnsense/mvc/app/views/layout_partials/base_dialog.volt
+31-3src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php
+2-2src/opnsense/mvc/app/views/layout_partials/form_input_tr.volt
+134-1664 files

OPNSense/core 2e90e6fsrc/opnsense/scripts/firmware config.sh

firmware: fix return value masking during updates

This caused reboots when updates not supposed to reboot
in case base/kernel could not install.  This way since
26.1.8.
DeltaFile
+3-4src/opnsense/scripts/firmware/config.sh
+3-41 files

OPNSense/core 0fe799fsrc/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterController.php

Firewall: Rules: use strnatcasecmp() for interface list (#10412)
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+1-11 files

OPNSense/core 39ffacfsrc/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterController.php

Firewall: Rules: use strnatcasecmp() for interface list
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+1-11 files

OPNSense/core 8ff00fasrc/opnsense/mvc/app/views/layout_partials base_apply_button.volt, src/opnsense/www/js opnsense_ui.js

ui: fix excessive padding on apply section (#10409)

(cherry picked from commit 7a53cf1547beac857393ef97f4008bb91b5d4a52)
(cherry picked from commit 70853ba8ac3f6ec0e80cf639539e3da1b141d6bb)
DeltaFile
+2-2src/opnsense/www/js/opnsense_ui.js
+1-1src/opnsense/mvc/app/views/layout_partials/base_apply_button.volt
+3-32 files

OPNSense/core 96fa955src/opnsense/mvc/app/views/OPNsense/IPsec connections.volt, src/opnsense/www/js opnsense_bootgrid.js

ipsec: disable scroll in authentication and children grids (#10407)

Since the grids live on a lower position on the screen, the height calculation may squash the entries. This should be solved by enforcing a minimum row constraint, but for ipsec specifically being able to see all children at all times is more important, which is what this commit aims to solve.

(cherry picked from commit d2affcf0c0d14724237fd2a4aecc741f4ed2fd68)
DeltaFile
+1-0src/opnsense/mvc/app/views/OPNsense/IPsec/connections.volt
+1-0src/opnsense/www/js/opnsense_bootgrid.js
+2-02 files

OPNSense/core 3011649src/opnsense/mvc/app/views/OPNsense/Syslog index.volt, src/opnsense/mvc/app/views/OPNsense/TrafficShaper index.volt

ui: button padding when injecting next to apply button

Perhaps these fit another location much better, but keep them for now
and make sure that they are "primary" since they do a thing with a
confirmation button.

pull-right doesn't do much anymore and insertAfter already makes it
the rightmost button.

(cherry picked from commit d521d7d5293e5c63227e9dc6f8d986b70959da84)
DeltaFile
+1-1src/opnsense/mvc/app/views/OPNsense/Syslog/index.volt
+1-1src/opnsense/mvc/app/views/OPNsense/TrafficShaper/index.volt
+2-22 files

OPNSense/core d521d7dsrc/opnsense/mvc/app/views/OPNsense/Syslog index.volt, src/opnsense/mvc/app/views/OPNsense/TrafficShaper index.volt

ui: button padding when injecting next to apply button

Perhaps these fit another location much better, but keep them for now
and make sure that they are "primary" since they do a thing with a
confirmation button.

pull-right doesn't do much anymore and insertAfter already makes it
the rightmost button.
DeltaFile
+1-1src/opnsense/mvc/app/views/OPNsense/Syslog/index.volt
+1-1src/opnsense/mvc/app/views/OPNsense/TrafficShaper/index.volt
+2-22 files

OPNSense/core 70853basrc/opnsense/mvc/app/views/layout_partials base_apply_button.volt, src/opnsense/www/js opnsense_ui.js

ui: simplify previous
DeltaFile
+2-3src/opnsense/www/js/opnsense_ui.js
+1-1src/opnsense/mvc/app/views/layout_partials/base_apply_button.volt
+3-42 files

OPNSense/core c26e4dasrc/opnsense/mvc/app/views/layout_partials base_apply_button.volt, src/opnsense/www/js opnsense_ui.js

ui: simplify previous
DeltaFile
+2-3src/opnsense/www/js/opnsense_ui.js
+1-1src/opnsense/mvc/app/views/layout_partials/base_apply_button.volt
+3-42 files

OPNSense/core 7a53cf1src/opnsense/mvc/app/views/layout_partials base_apply_button.volt, src/opnsense/www/js opnsense_ui.js

ui: fix excessive padding on apply section (#10409)
DeltaFile
+3-2src/opnsense/www/js/opnsense_ui.js
+1-1src/opnsense/mvc/app/views/layout_partials/base_apply_button.volt
+4-32 files

OPNSense/core ebfe40fsrc/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterBaseController.php, src/opnsense/mvc/app/models/OPNsense/Firewall Filter.php

Firewall: Rules: Remove safepoint actions, no consumers in GUI are left, and we don't know of any external API consumers
DeltaFile
+0-69src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php
+0-25src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.php
+0-942 files

OPNSense/core d8c9fa4src/opnsense/mvc/app/views/OPNsense/Core firmware.volt

firmware: put clickable trailer for community plugins; closes #10379

This is the same apprach as changelogs.  People may be more
inclined to see it below.

(cherry picked from commit 274edbb7308fbf687d8da094e52410d29e4b075c)
DeltaFile
+16-14src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt
+16-141 files

OPNSense/core a3f2573src/opnsense/mvc/app/views/layout_partials base_form.volt

mvc: static header support for forms same as f8af03c8ecf8c

(cherry picked from commit 74c9f98cc3771ea2eef83dbaef860b35c4d1a51c)
DeltaFile
+6-4src/opnsense/mvc/app/views/layout_partials/base_form.volt
+6-41 files

OPNSense/core fcacf66Scripts dashboard-acl.sh, src/opnsense/www/js/widgets/Metadata Core.xml

system: revisit dashboard linting
DeltaFile
+12-14Scripts/dashboard-acl.sh
+6-1src/opnsense/www/js/widgets/Metadata/Core.xml
+18-152 files

OPNSense/core 8eb8380src/opnsense/www/themes/opnsense-auto/build css.link fonts.link

pkg: repackage actual links as ".link" package build trick

So "make lint-php" woud cause the spurious PHP errors showing
up in the GUI on my end with some command line too reading a
directory.  Turned out to be these links and we have this nice
trick to deal with it.
DeltaFile
+1-0src/opnsense/www/themes/opnsense-auto/build/css.link
+1-0src/opnsense/www/themes/opnsense-auto/build/fonts.link
+1-0src/opnsense/www/themes/opnsense-auto/build/images.link
+0-1src/opnsense/www/themes/opnsense-auto/build/css
+0-1src/opnsense/www/themes/opnsense-auto/build/fonts
+0-1src/opnsense/www/themes/opnsense-auto/build/images
+3-36 files

OPNSense/core cf506a2src/opnsense/mvc/app/controllers/OPNsense/Base ControllerBase.php, src/opnsense/mvc/app/views/layout_partials base_form.volt base_dialog.volt

MVC:ui - refactor base_dialog and parseFormNode to simplify the template for https://github.com/opnsense/core/issues/9955

Move defaults to parseFormNode() and introduce "sections" with children to avoid some more magic in the volt templates.

Set default title on multi selectpickers as these sometimes seem to miss the "Nothing selected" phrase for some odd reason.

Functionally this should be a backward compatible change.
DeltaFile
+69-80src/opnsense/mvc/app/views/layout_partials/base_form.volt
+32-81src/opnsense/mvc/app/views/layout_partials/base_dialog.volt
+31-3src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php
+2-2src/opnsense/mvc/app/views/layout_partials/form_input_tr.volt
+134-1664 files

OPNSense/core 4614679src/opnsense/mvc/app/controllers/OPNsense/Base ControllerBase.php, src/opnsense/mvc/app/views/layout_partials base_form.volt base_dialog.volt

MVC:ui - [WIP] refactor base_dialog and parseFormNode to simplify the template for https://github.com/opnsense/core/issues/9955
DeltaFile
+69-80src/opnsense/mvc/app/views/layout_partials/base_form.volt
+32-81src/opnsense/mvc/app/views/layout_partials/base_dialog.volt
+31-3src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php
+2-2src/opnsense/mvc/app/views/layout_partials/form_input_tr.volt
+134-1664 files

OPNSense/core fc58ebasrc/opnsense/mvc/app/controllers/OPNsense/Base ControllerBase.php, src/opnsense/mvc/app/views/layout_partials base_form.volt base_dialog.volt

MVC:ui - [WIP] refactor base_dialog and parseFormNode to simplify the template for https://github.com/opnsense/core/issues/9955
DeltaFile
+69-80src/opnsense/mvc/app/views/layout_partials/base_form.volt
+32-81src/opnsense/mvc/app/views/layout_partials/base_dialog.volt
+31-3src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php
+1-1src/opnsense/mvc/app/views/layout_partials/form_input_tr.volt
+133-1654 files

OPNSense/core 308aa51src/opnsense/mvc/app/controllers/OPNsense/Base ControllerBase.php, src/opnsense/mvc/app/views/layout_partials base_dialog.volt

MVC:ui - [WIP] refactor base_dialog and parseFormNode to simplify the template for https://github.com/opnsense/core/issues/9955
DeltaFile
+32-81src/opnsense/mvc/app/views/layout_partials/base_dialog.volt
+31-3src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php
+63-842 files

OPNSense/core 274edbbsrc/opnsense/mvc/app/views/OPNsense/Core firmware.volt

firmware: put clickable trailer for community plugins; closes #10379

This is the same apprach as changelogs.  People may be more
inclined to see it below.
DeltaFile
+16-14src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt
+16-141 files

OPNSense/core d2affcfsrc/opnsense/mvc/app/views/OPNsense/IPsec connections.volt, src/opnsense/www/js opnsense_bootgrid.js

ipsec: disable scroll in authentication and children grids (#10407)

Since the grids live on a lower position on the screen, the height calculation may squash the entries. This should be solved by enforcing a minimum row constraint, but for ipsec specifically being able to see all children at all times is more important, which is what this commit aims to solve.
DeltaFile
+1-0src/opnsense/www/js/opnsense_bootgrid.js
+1-0src/opnsense/mvc/app/views/OPNsense/IPsec/connections.volt
+2-02 files

OPNSense/core 9d0e4bfsrc/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes TextFieldTest.php

src: style update
DeltaFile
+0-1src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/TextFieldTest.php
+0-11 files