OPNSense/core 47bcff3src/opnsense/mvc/app/library/OPNsense/Core Shell.php, src/opnsense/mvc/app/library/OPNsense/Trust Store.php

mvc: style tweaks
DeltaFile
+3-3src/opnsense/mvc/app/library/OPNsense/Trust/Store.php
+1-1src/opnsense/mvc/app/library/OPNsense/Core/Shell.php
+4-42 files

OPNSense/core f0da2b6src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes NetworkAliasField.php

firewall: test said 'no'
DeltaFile
+1-1src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/NetworkAliasField.php
+1-11 files

OPNSense/core 7e0600asrc/etc/inc legacy_bindings.inc, src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterBaseController.php

firewall: simplify port alias check loosely refs #8806

We used to have a port URL table but that has been gone for a while.
DeltaFile
+2-2src/etc/inc/legacy_bindings.inc
+2-2src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php
+2-2src/opnsense/mvc/app/library/OPNsense/Firewall/Util.php
+2-2src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/PortField.php
+1-1src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/NetworkAliasField.php
+1-1src/opnsense/mvc/app/library/OPNsense/Firewall/Rule.php
+10-106 files

OPNSense/core 69aa1dbsrc/opnsense/service/templates/OPNsense/IDS suricata.yaml

Services: Intrusion Detection - increase maintainability of suricata.yaml file.

The initial idea was to use php-yaml, parse/merge defaults and overlay the model options, but this doesn't seem to be very feasible due to the structure of the file.
Next best seems to be to remove all comments and default disabled options to make our options more clear, adding the additional + to inline if statements "{% ... +%}" decreases the chance of accidental breakage.
DeltaFile
+21-1,767src/opnsense/service/templates/OPNsense/IDS/suricata.yaml
+21-1,7671 files

OPNSense/core 0b8d5c0src/etc/inc/plugins.inc.d dpinger.inc, src/www interfaces.php

interfaces: commit essence of discussion; coses #9259

Suggested by: Serhat Rencber
DeltaFile
+13-13src/www/interfaces.php
+1-1src/etc/inc/plugins.inc.d/dpinger.inc
+14-142 files

OPNSense/core aaa3de7src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogFilterRule.xml, src/opnsense/mvc/app/library/OPNsense/Firewall FilterRule.php

Firewall: Rules [new]: Add per rule state timeouts for udp.first, udp.multiple and udp.single (#9414)

* Firewall: Rules [new]: Add per rule state timeouts for udp.first, udp.multiple and udp.single

* Add subheaders to base_dialog.volt and use them in dialogFilterRule.xml

* whitespace

* Set a maximum value of 2^31 for all integer fields that handle states

* The list is long, put State into the subheader names to indicate relationship

(cherry picked from commit 9697631b03e961b7aa2f5344cb0d6a013a9cbe68)
DeltaFile
+59-14src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
+21-0src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
+10-0src/opnsense/mvc/app/views/layout_partials/base_dialog.volt
+9-0src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php
+99-144 files

OPNSense/core 2bf1eedsrc/opnsense/mvc/app/library/OPNsense/System/Status LiveMediaStatus.php

system: move comment for better grepping
DeltaFile
+1-2src/opnsense/mvc/app/library/OPNsense/System/Status/LiveMediaStatus.php
+1-21 files

OPNSense/core dfd31a0src/sbin carp_service_status

interfaces: minor safe command chnage in carp_service_status
DeltaFile
+2-5src/sbin/carp_service_status
+2-51 files

OPNSense/core 83de6d6Mk git.mk

make: not really git but vim is a helpful target
DeltaFile
+10-1Mk/git.mk
+10-11 files

OPNSense/core 7d94da6src/sbin pluginctl

pluginctl: backport these minor changes, tested ok
DeltaFile
+3-3src/sbin/pluginctl
+3-31 files

OPNSense/core 1af287dsrc/etc/inc interfaces.inc, src/etc/inc/plugins.inc.d dhcrelay.inc

interfaces: add suport to get "any" interface assigned to an interface #9369

Use it in the Dhcrelay code.  It doesn't really care about the returned
address.  It just wants to see if the interface has a good configuration.
DeltaFile
+37-13src/etc/inc/interfaces.inc
+2-2src/etc/inc/plugins.inc.d/dhcrelay.inc
+39-152 files

OPNSense/core 2cd226csrc/opnsense/scripts/health/library/OPNsense/RRD/Stats Ntp.php Mbuf.php

reporting: replace RRD stuff for #9325
DeltaFile
+17-16src/opnsense/scripts/health/library/OPNsense/RRD/Stats/Ntp.php
+10-12src/opnsense/scripts/health/library/OPNsense/RRD/Stats/Mbuf.php
+5-12src/opnsense/scripts/health/library/OPNsense/RRD/Stats/Base.php
+10-3src/opnsense/scripts/health/library/OPNsense/RRD/Stats/Temperature.php
+5-2src/opnsense/scripts/health/library/OPNsense/RRD/Stats/Memory.php
+2-0src/opnsense/scripts/health/library/OPNsense/RRD/Stats/States.php
+49-451 files not shown
+51-457 files

OPNSense/core 97daa52src/opnsense/scripts/health/library/OPNsense/RRD/Types Base.php

reporting: replace RRD Base class use with Shell class
DeltaFile
+21-18src/opnsense/scripts/health/library/OPNsense/RRD/Types/Base.php
+21-181 files

OPNSense/core 6eff3a7Mk lint.mk

make: ignore errors of course
DeltaFile
+1-1Mk/lint.mk
+1-11 files

OPNSense/core 17a3ff3Mk lint.mk

make: add grepping from #9325 to lint-exec pass

No error, but visibility.
DeltaFile
+10-0Mk/lint.mk
+10-01 files

OPNSense/core b987638src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterController.php, src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes FilterRuleField.php

Firewall: Rules [new]: Fix handling of interfacenot, evaluate as floating rules in correct prio_group
DeltaFile
+10-2src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+5-1src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/FilterRuleField.php
+15-32 files

OPNSense/core 5df1f19src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterController.php, src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes FilterRuleField.php

Firewall: Rules [new]: Fix handling of interfacenot, evaluate as floating rules in correct prio_group
DeltaFile
+10-2src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+6-0src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/FilterRuleField.php
+16-22 files

OPNSense/core c81e78fsrc/etc/inc util.inc

firewall_rule_lookup.php - support 0 as valid ruleid (2), for https://github.com/opnsense/core/pull/9423

(cherry picked from commit 7fe42e78c5bd4fdfbb3c95bbe29caf9856a6da43)
DeltaFile
+1-1src/etc/inc/util.inc
+1-11 files

OPNSense/core 7fe42e7src/etc/inc util.inc

firewall_rule_lookup.php - support 0 as valid ruleid (2), for https://github.com/opnsense/core/pull/9423
DeltaFile
+1-1src/etc/inc/util.inc
+1-11 files

OPNSense/core beb2429src/www firewall_rule_lookup.php

firewall_rule_lookup.php - support 0 as valid ruleid, closes https://github.com/opnsense/core/issues/9422

(cherry picked from commit 35dc4de80ce1017702eb2ef77191231462ff6fde)
DeltaFile
+1-1src/www/firewall_rule_lookup.php
+1-11 files

OPNSense/core de4d4aasrc/opnsense/www/js opnsense_ui.js

 mvc: setFormData / tokenize - pressing the clear button seems to trigger excessive events as well, for https://github.com/opnsense/core/issues/9408

(cherry picked from commit f3291e23dd3f42efc19acda5da735b045f799bb6)
DeltaFile
+5-0src/opnsense/www/js/opnsense_ui.js
+5-01 files

OPNSense/core f3291e2src/opnsense/www/js opnsense_ui.js

 mvc: setFormData / tokenize - pressing the clear button seems to trigger excessive events as well, for https://github.com/opnsense/core/issues/9408
DeltaFile
+5-0src/opnsense/www/js/opnsense_ui.js
+5-01 files

OPNSense/core 35dc4desrc/www firewall_rule_lookup.php

firewall_rule_lookup.php - support 0 as valid ruleid, closes https://github.com/opnsense/core/issues/9422
DeltaFile
+1-1src/www/firewall_rule_lookup.php
+1-11 files

OPNSense/core 7ee3b2csrc/opnsense/mvc/app/library/OPNsense/Core Config.php

Config - ditch isArraySequential() in favor of the new array_is_list() introduced in PHP 8.1. closes https://github.com/opnsense/core/pull/9424

This impacts $config usage in legacy code, a before and after comparison of the $config output shows no difference on a larger config file.
As mentioned by @swhite2, the performance of the internal check is much better than the one we're replacing now.

closes https://github.com/opnsense/core/pull/9424
DeltaFile
+2-12src/opnsense/mvc/app/library/OPNsense/Core/Config.php
+2-121 files

OPNSense/core 29e9defsrc/opnsense/mvc/app/library/OPNsense/Core Config.php

mvc: optimize isArraySequential()
DeltaFile
+2-2src/opnsense/mvc/app/library/OPNsense/Core/Config.php
+2-21 files

OPNSense/core f2f3391src/opnsense/www/js opnsense_ui.js

mvc: setFormData / tokenize - switching back and forth between text edit and tokenize seem to trigger excessive events as well, for https://github.com/opnsense/core/issues/9408

(cherry picked from commit 1129ea9b44d4ec6e64c9f234a4d4b3f8df1eb811)
DeltaFile
+5-0src/opnsense/www/js/opnsense_ui.js
+5-01 files

OPNSense/core b6b61f9src/opnsense/mvc/app/controllers/OPNsense/Kea DhcpController.php

dhcp/kea: Fix Dhcpv6 endpoints in DhcpController.php for cc2fa5f (#9421)

DeltaFile
+4-4src/opnsense/mvc/app/controllers/OPNsense/Kea/DhcpController.php
+4-41 files

OPNSense/core e0ff7c3src/opnsense/mvc/app/controllers/OPNsense/Kea DhcpController.php

dhcp/kea: Fix Dhcpv6 endpoints in DhcpController.php for cc2fa5f
DeltaFile
+4-4src/opnsense/mvc/app/controllers/OPNsense/Kea/DhcpController.php
+4-41 files

OPNSense/core cc2fa5fsrc/opnsense/mvc/app/controllers/OPNsense/Kea DhcpController.php, src/opnsense/mvc/app/controllers/OPNsense/Kea/Api LeasesController.php

dhcp/kea: Add lease commands, tabulator GroupBy, URL hashes (#9409)

This commit introduces the same features to Kea as already available in the Dnsmasq GUI:

- Lease commands added
- GroupBy will allow simpler filtering by subnet
- URL hashes to better reference the individual tabs
- Frontend code same style as Dnsmasq

dhcp/kea: Prepare dhcpv4.volt for URL hash reservation insertion

* dhcp/kea: Also group by subnet
* The group key is different for both grids due to model relation field
* Move data service widget update to apply button
* Refactor dhcpv6.volt the same way to introduce tabulator GroupBy, URL hashes and reservation autofill via hash
* Add lease commands and tabulator groupBy to leases4 and leases6 templates
* baseURL was wrong for reservations
* Add is_reserved key to LeasesController so leases can show different commands based on their reservation status
* Move upload_reservations and download_reservtions into layout_partial for dhcpv6.volt

    [7 lines not shown]
DeltaFile
+122-75src/opnsense/mvc/app/views/OPNsense/Kea/dhcpv6.volt
+100-40src/opnsense/mvc/app/views/OPNsense/Kea/dhcpv4.volt
+47-1src/opnsense/mvc/app/views/OPNsense/Kea/leases4.volt
+46-0src/opnsense/mvc/app/views/OPNsense/Kea/leases6.volt
+25-0src/opnsense/mvc/app/controllers/OPNsense/Kea/Api/LeasesController.php
+3-3src/opnsense/mvc/app/controllers/OPNsense/Kea/DhcpController.php
+343-1191 files not shown
+345-1217 files

OPNSense/core cbb309esrc/opnsense/mvc/app/controllers/OPNsense/Kea/Api LeasesController.php

Style
DeltaFile
+0-1src/opnsense/mvc/app/controllers/OPNsense/Kea/Api/LeasesController.php
+0-11 files