OPNSense/core 4d3ea7asrc/opnsense/www/js opnsense_ui.js

mvc: slightly improve replaceInputWithSelector() to support an empty placeholder, which should help for https://github.com/opnsense/core/pull/9158

This change uses a token for the single/manual input, in which case callers may use definitions like:

......
            'networks' => [
                'label' => gettext("Networks"),
                'items' => [
                    '' => gettext('any'),
                    '(self)' => gettext("This Firewall")
                ]
            ]
.....

When empty is offered, "any" will be choosen in this case. In theory we could change the filter model as well as "any" has no functional meaning anyway, but for simplicty this only changes the javascript part.
DeltaFile
+18-14src/opnsense/www/js/opnsense_ui.js
+18-141 files

OPNSense/core baa1730src/opnsense/mvc/app/views/OPNsense/Diagnostics log.volt, src/opnsense/mvc/app/views/OPNsense/Dnsmasq settings.volt

bootgrid: Raise rowCount default to 50 as y-overflow handles this gracefully (#9162)

* bootgrid: Raise rowCount default to 50 as y-overflow handles this gracefully, ensure low initial rowcount for master detail grids, clean up some scattered rowcounts in views
DeltaFile
+0-2src/opnsense/mvc/app/views/OPNsense/IDS/index.volt
+2-0src/opnsense/mvc/app/views/OPNsense/Unbound/overrides.volt
+1-1src/opnsense/www/js/opnsense_bootgrid.js
+0-2src/opnsense/mvc/app/views/OPNsense/Dnsmasq/settings.volt
+2-0src/opnsense/mvc/app/views/OPNsense/IPsec/tunnels.volt
+0-1src/opnsense/mvc/app/views/OPNsense/Diagnostics/log.volt
+5-62 files not shown
+5-88 files

OPNSense/core e4bc455src/opnsense/mvc/app/models/OPNsense/Monit Monit.xml

mvc: monit model whitespace

(cherry picked from commit 3d983ba403e14086e0849523d58597fce71f633c)
DeltaFile
+326-326src/opnsense/mvc/app/models/OPNsense/Monit/Monit.xml
+326-3261 files

OPNSense/core 3d983basrc/opnsense/mvc/app/models/OPNsense/Monit Monit.xml

mvc: monit model whitespace
DeltaFile
+326-326src/opnsense/mvc/app/models/OPNsense/Monit/Monit.xml
+326-3261 files

OPNSense/core a73a086src/opnsense/mvc/app/models/OPNsense/Trust Cert.xml Ca.xml

mvc: trust model style

(cherry picked from commit f9f5c2fc0c1c6da202675600bd58c328857b4f2a)
DeltaFile
+6-7src/opnsense/mvc/app/models/OPNsense/Trust/Cert.xml
+0-1src/opnsense/mvc/app/models/OPNsense/Trust/Ca.xml
+6-82 files

OPNSense/core f9f5c2fsrc/opnsense/mvc/app/models/OPNsense/Trust Cert.xml Ca.xml

mvc: trust model style
DeltaFile
+6-7src/opnsense/mvc/app/models/OPNsense/Trust/Cert.xml
+0-1src/opnsense/mvc/app/models/OPNsense/Trust/Ca.xml
+6-82 files

OPNSense/core dd3e312src/opnsense/mvc/app/models/OPNsense/Firewall Filter.xml Alias.xml

mvc: firewall model style updates
DeltaFile
+13-13src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
+8-8src/opnsense/mvc/app/models/OPNsense/Firewall/Alias.xml
+1-1src/opnsense/mvc/app/models/OPNsense/Firewall/Category.xml
+22-223 files

OPNSense/core 0ab86f4src/opnsense/mvc/app/models/OPNsense/Firewall Alias.php

Firewall: Aliases - allow alias nesting for urltable type

PR: https://github.com/opnsense/core/issues/9160

(cherry picked from commit d73260c87e8b0a623a310461c1fb2cc58136823f)
(cherry picked from commit d9ea39fdbda543b9c73ee6e228747cdaff5a56e3)
DeltaFile
+1-1src/opnsense/mvc/app/models/OPNsense/Firewall/Alias.php
+1-11 files

OPNSense/core 3e20795src/opnsense/mvc/app/models/OPNsense/Firewall Alias.xml Filter.xml

mvc: firewall model whitespace
DeltaFile
+8-8src/opnsense/mvc/app/models/OPNsense/Firewall/Alias.xml
+4-4src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
+12-122 files

OPNSense/core 5449253src/opnsense/mvc/app/models/OPNsense/Interfaces Lagg.xml Vlan.xml

mvc: indent sweep on Interface models

(cherry picked from commit a332af8a09d2d30c661f1cee67c264468a8d9557)
DeltaFile
+15-15src/opnsense/mvc/app/models/OPNsense/Interfaces/Lagg.xml
+7-7src/opnsense/mvc/app/models/OPNsense/Interfaces/Vlan.xml
+1-1src/opnsense/mvc/app/models/OPNsense/Interfaces/Bridge.xml
+23-233 files

OPNSense/core a332af8src/opnsense/mvc/app/models/OPNsense/Interfaces Lagg.xml Vlan.xml

mvc: indent sweep on Interface models
DeltaFile
+15-15src/opnsense/mvc/app/models/OPNsense/Interfaces/Lagg.xml
+7-7src/opnsense/mvc/app/models/OPNsense/Interfaces/Vlan.xml
+1-1src/opnsense/mvc/app/models/OPNsense/Interfaces/Bridge.xml
+23-233 files

OPNSense/core 850c686src/opnsense/mvc/app/models/OPNsense/Diagnostics DnsDiagnostics.xml Traceroute.xml

mnvc: new model indent sweep on diagnostics (no changes except whitespace)

(cherry picked from commit 4f7de1bf7f103a43a7bfd5414a40be87e74a9090)
DeltaFile
+4-4src/opnsense/mvc/app/models/OPNsense/Diagnostics/DnsDiagnostics.xml
+4-4src/opnsense/mvc/app/models/OPNsense/Diagnostics/Traceroute.xml
+4-4src/opnsense/mvc/app/models/OPNsense/Diagnostics/Portprobe.xml
+3-3src/opnsense/mvc/app/models/OPNsense/Diagnostics/Netflow.xml
+2-2src/opnsense/mvc/app/models/OPNsense/Diagnostics/Ping.xml
+2-2src/opnsense/mvc/app/models/OPNsense/Diagnostics/PacketCapture.xml
+19-196 files

OPNSense/core 4606fd8Mk sweep.mk

make: reindent model files using xmllint

(cherry picked from commit daae0ac553784ac2562379d1c5de96a8c1786d8f)
DeltaFile
+2-0Mk/sweep.mk
+2-01 files

OPNSense/core 35bdae9src/opnsense/mvc/app/views/OPNsense/Dnsmasq settings.volt, src/opnsense/mvc/app/views/OPNsense/Firewall alias_util.volt

bootgrid: Raise rowCount default to 50 as y-overflow handles this gracefully, ensure low initial rowcount for master detail grids, clean up some scattered rowcounts in views
DeltaFile
+0-2src/opnsense/mvc/app/views/OPNsense/Dnsmasq/settings.volt
+0-2src/opnsense/mvc/app/views/OPNsense/IDS/index.volt
+2-0src/opnsense/mvc/app/views/OPNsense/IPsec/tunnels.volt
+2-0src/opnsense/mvc/app/views/OPNsense/Unbound/overrides.volt
+1-1src/opnsense/www/js/opnsense_bootgrid.js
+0-1src/opnsense/mvc/app/views/OPNsense/Firewall/alias_util.volt
+5-62 files not shown
+5-88 files

OPNSense/core 4f7de1bsrc/opnsense/mvc/app/models/OPNsense/Diagnostics DnsDiagnostics.xml Traceroute.xml

mnvc: new model indent sweep on diagnostics (no changes except whitespace)
DeltaFile
+4-4src/opnsense/mvc/app/models/OPNsense/Diagnostics/DnsDiagnostics.xml
+4-4src/opnsense/mvc/app/models/OPNsense/Diagnostics/Traceroute.xml
+4-4src/opnsense/mvc/app/models/OPNsense/Diagnostics/Portprobe.xml
+3-3src/opnsense/mvc/app/models/OPNsense/Diagnostics/Netflow.xml
+2-2src/opnsense/mvc/app/models/OPNsense/Diagnostics/PacketCapture.xml
+2-2src/opnsense/mvc/app/models/OPNsense/Diagnostics/Ping.xml
+19-196 files

OPNSense/core daae0acMk sweep.mk

make: reindent model files using xmllint
DeltaFile
+2-0Mk/sweep.mk
+2-01 files

OPNSense/core d9ea39fsrc/opnsense/mvc/app/models/OPNsense/Firewall Alias.php

Firewall: Aliases - allow alias nesting for urltable type, closes https://github.com/opnsense/core/issues/9160

minor refactor
DeltaFile
+1-1src/opnsense/mvc/app/models/OPNsense/Firewall/Alias.php
+1-11 files

OPNSense/core d73260csrc/opnsense/mvc/app/models/OPNsense/Firewall Alias.php

Firewall: Aliases - allow alias nesting for urltable type, closes https://github.com/opnsense/core/issues/9160
DeltaFile
+1-1src/opnsense/mvc/app/models/OPNsense/Firewall/Alias.php
+1-11 files

OPNSense/core 1de96b6src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterController.php FilterBaseController.php, src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogFilterRule.xml

firewall/automation: Add port alias selection to source_port and destination_port
DeltaFile
+41-2src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+34-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php
+8-0src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+2-2src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
+85-44 files

OPNSense/core 7198e0dsrc/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterController.php FilterBaseController.php, src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogFilterRule.xml

firewall/automation: Add port alias selection to source_port and destination_port
DeltaFile
+41-2src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+34-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php
+8-0src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+2-2src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
+85-44 files

OPNSense/core 85cf874src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

firewall/automation: Do not allow source_net destination_net selectpickers to grow infinitely (#9157)

DeltaFile
+6-0src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+6-01 files

OPNSense/core bf60f48src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes ModelRelationField.php

mvc: ModelRelationField - keep array structure in memory to avoid reinitiating object construction

PR: https://github.com/opnsense/core/issues/9032

(cherry picked from commit b8fde8ee86eba3d38549b3acdf2b8a399145bf0d)
(cherry picked from commit 2df8e410fa6461145e82e2fa8ba11d0f407f4eda)
DeltaFile
+24-15src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/ModelRelationField.php
+24-151 files

OPNSense/core a3b2f5bsrc/opnsense/mvc/app/models/OPNsense/Base BaseModel.php

mvc:model - minor non functional cleanups in BaseModel

(cherry picked from commit ec1a7a30f1573dfd32bf07921f3c15cf62416029)
DeltaFile
+30-42src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php
+30-421 files

OPNSense/core 4ebd43asrc/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogSNatRule.xml, src/opnsense/mvc/app/models/OPNsense/Firewall Filter.xml

Firewall: Automation: Source NAT - support tags (tagged keyword), closes https://github.com/opnsense/core/issues/9108

(cherry picked from commit db0b43ca26f88f36da4ed626e0d16e2a0031057c)
DeltaFile
+11-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogSNatRule.xml
+3-0src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
+14-02 files

OPNSense/core 30f7eb3src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes BaseField.php

mvc: remove getCurrentValue() wrapper

(cherry picked from commit 903b1db87d1d312ead7933f798bc8fa4854c95f3)
DeltaFile
+2-11src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseField.php
+2-111 files

OPNSense/core f0c8b38src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes BaseListField.php

mvc: BaseListField - always map values in getDescription() and prevent usage of getNodeOptions() when not needed which should be less work for the cpu.

If a leaf object wants to render its own description, it can still do so by overwriting getDescription(), the cases we have implemented just trust the data of the BaseListField at the moment anyway.

closes https://github.com/opnsense/core/issues/9127

(cherry picked from commit 5875c18758853a6f1eaf2941bf83b443442bb623)
DeltaFile
+4-11src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/BaseListField.php
+4-111 files

OPNSense/core 7b5c25dsrc/opnsense/mvc/app/models/OPNsense/Diagnostics Portprobe.xml Traceroute.xml

interfaces: update validation messages in diagnostics
DeltaFile
+2-2src/opnsense/mvc/app/models/OPNsense/Diagnostics/Portprobe.xml
+2-2src/opnsense/mvc/app/models/OPNsense/Diagnostics/Traceroute.xml
+2-2src/opnsense/mvc/app/models/OPNsense/Diagnostics/DnsDiagnostics.xml
+2-2src/opnsense/mvc/app/models/OPNsense/Diagnostics/Netflow.xml
+2-2src/opnsense/mvc/app/models/OPNsense/Diagnostics/Ping.xml
+10-105 files

OPNSense/core 87497efsrc/opnsense/mvc/app/models/OPNsense/IPsec IPsec.xml

vpn/ipsec: Add default value to make_before_break that retains original behavior before strongswan 6.0.0 (#9080)

Co-authored-by: Franco Fichtner <franco at opnsense.org>
(cherry picked from commit 2c0ad5833736f6136a7d7cd865f05dc18f2c4339)
DeltaFile
+5-2src/opnsense/mvc/app/models/OPNsense/IPsec/IPsec.xml
+5-21 files

OPNSense/core 4ca06b1src/opnsense/mvc/app/models/OPNsense/Wireguard Server.xml

wireguard: update validation message
DeltaFile
+1-1src/opnsense/mvc/app/models/OPNsense/Wireguard/Server.xml
+1-11 files

OPNSense/core eddac46src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterController.php, src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

firewall/automation: Implement alias description tooltip (#9121)

(cherry picked from commit dbcb15033af14647e756820e84f1724f7e153be5)
(cherry picked from commit 177e8420736c0c6678f4d8626d0881b0159f0739)
DeltaFile
+21-14src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+21-5src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+42-192 files