Interfaces/DHCP - Further tighten security for https://github.com/opnsense/core/security/advisories/GHSA-5rx3-w735-74wm
As advanced fields should always require high level access, we should prevent accidental mistakes from administrators allowing non-admins from changing these items.
In the long run, we likely want to drop these options, but that requires at least bringing back some common options which we are able to validate properly.
system: non-canonical cast (binary) is deprecated
May need to revisit this again, but for now PHP suggests that
(string) is equivalent to (binary) although the code reads
strange.
MVC:ui - refactor base_dialog and parseFormNode to simplify the template for https://github.com/opnsense/core/issues/9955 (#10410)
Move defaults to parseFormNode() and introduce "sections" with children to avoid some more magic in the volt templates.
Set default title on multi selectpickers as these sometimes seem to miss the "Nothing selected" phrase for some odd reason.
Functionally this should be a backward compatible change.
mvc/templates - remove direct apply_btn_id usage in favor of base_apply_button template partial. discussed in https://github.com/opnsense/core/pull/10410
Eventually we want to remove apply_btn_id from base_form completely, but since base_tabs_content is using the same construct and appears in quite some plugins, we have to postpone that action.
At least aim for consistency in the forms that only depend on base_form in core.
firmware: fix return value masking during updates
This caused reboots when updates not supposed to reboot
in case base/kernel could not install. This way since
26.1.8.
(cherry picked from commit 2e90e6fbf77202efdbd599697951e6da12b78e26)
MVC:ui - refactor base_dialog and parseFormNode to simplify the template for https://github.com/opnsense/core/issues/9955
Move defaults to parseFormNode() and introduce "sections" with children to avoid some more magic in the volt templates.
Set default title on multi selectpickers as these sometimes seem to miss the "Nothing selected" phrase for some odd reason.
Functionally this should be a backward compatible change.
