OPNSense/core 213abd1src/etc/inc interfaces.inc

interfaces: fixes found during backport audit
DeltaFile
+6-1src/etc/inc/interfaces.inc
+6-11 files

OPNSense/core c3aaa45src/etc/inc interfaces.inc

interfaces: safer interfaces_pfsync_configure() handling
DeltaFile
+20-12src/etc/inc/interfaces.inc
+20-121 files

OPNSense/core f000e6bsrc/etc/inc util.inc, src/etc/inc/plugins.inc.d kea.inc dpinger.inc

backend: extend mwexecfb() to take pidfile and/or logfile

This allows to hide the daemon command completely making the calls
look like normal mwexecf() invokes.
DeltaFile
+17-3src/etc/inc/util.inc
+5-8src/etc/inc/plugins.inc.d/kea.inc
+4-3src/etc/inc/plugins.inc.d/dpinger.inc
+26-143 files

OPNSense/core b10962asrc/etc/inc interfaces.inc

interfaces: to shell_safe to mwexecf(b)
DeltaFile
+2-2src/etc/inc/interfaces.inc
+2-21 files

OPNSense/core 19b9fc3src/etc/inc interfaces.inc

interfaces: interface_carp_configure() conversion

The use of str_replace+addslashes+escapeshellarg is very odd:

https://github.com/pfsense/pfsense/commit/942fdd555964d48
https://redmine.pfsense.org/issues/213

To avoid bugs leave this for now.  escapeshellarg should be able
to handle this on its own.  The password parsing is not more special
than anything else passed to the command line unless there is a bug
somewhere else which I doubt.
DeltaFile
+35-16src/etc/inc/interfaces.inc
+35-161 files

OPNSense/core b044f74src/etc/inc interfaces.inc

interfaces: convert interface_ipalias_configure()
DeltaFile
+14-6src/etc/inc/interfaces.inc
+14-61 files

OPNSense/core 321d85dsrc/www interfaces_ppps_edit.php

interfaces: limit execution of sysctl scope in PPP device code

(cherry picked from commit 14658bd794376075d0ad4b8ba9130269b82d27a7)
DeltaFile
+20-19src/www/interfaces_ppps_edit.php
+20-191 files

OPNSense/core 320c712src/opnsense/mvc/app/library/OPNsense/Core Shell.php

mvc: edge case comments and shims for exec() and shell_safe()

(cherry picked from commit c380799cd4e27af80db4edac19a79aabded6df6a)
DeltaFile
+13-3src/opnsense/mvc/app/library/OPNsense/Core/Shell.php
+13-31 files

OPNSense/core 14658bdsrc/www interfaces_ppps_edit.php

interfaces: limit execution of sysctl scope in PPP device code
DeltaFile
+20-19src/www/interfaces_ppps_edit.php
+20-191 files

OPNSense/core c380799src/opnsense/mvc/app/library/OPNsense/Core Shell.php

mvc: edge case comments and shims for exec() and shell_safe()
DeltaFile
+13-3src/opnsense/mvc/app/library/OPNsense/Core/Shell.php
+13-31 files

OPNSense/core 456416asrc/sbin opnsense-beep

rc: do not error on impossible beep

(cherry picked from commit 1b7a970304d8d90e83ba62713535461737b2aa7e)
DeltaFile
+2-2src/sbin/opnsense-beep
+2-21 files

OPNSense/core 1b7a970src/sbin opnsense-beep

rc: do not error on impossible beep
DeltaFile
+2-2src/sbin/opnsense-beep
+2-21 files

OPNSense/core cdcf29fsrc/opnsense/scripts/shell banner.php

shell: make HTTPS fingerprint command more readable and fix lower case "sha256"

This makes it match the OpenSSH fingerprint output.

(cherry picked from commit d6031bf593161b1fa79ef5971a188056a7de75d5)
DeltaFile
+6-1src/opnsense/scripts/shell/banner.php
+6-11 files

OPNSense/core d6031bfsrc/opnsense/scripts/shell banner.php

shell: make HTTPS fingerprint command more readable and fix lower case "sha256"

This makes it match the OpenSSH fingerprint output.
DeltaFile
+6-1src/opnsense/scripts/shell/banner.php
+6-11 files

OPNSense/core af59123src/opnsense/scripts/shell password.php halt.php

shell: script consolidation and safety changes
DeltaFile
+9-8src/opnsense/scripts/shell/password.php
+1-3src/opnsense/scripts/shell/halt.php
+2-2src/opnsense/scripts/shell/banner.php
+1-3src/opnsense/scripts/shell/reboot.php
+1-2src/opnsense/scripts/shell/setaddr.php
+1-1src/opnsense/scripts/shell/ping.php
+15-196 files

OPNSense/core a74198bsrc/opnsense/scripts/shell setaddr.php

shell: it was so nice they require_once'd it twice
DeltaFile
+0-1src/opnsense/scripts/shell/setaddr.php
+0-11 files

OPNSense/core 4e6ecf3src/opnsense/mvc/app/views/OPNsense/Diagnostics ping.volt

Interfaces: Diagnostics: Ping - move grid init/reload to tab show event, https://forum.opnsense.org/index.php?topic=49693.0

Ideally we should also move the button actions, but as that feature is not yet available, let's make sure we fix the current situation first with minimal changes.

(cherry picked from commit d9d3a548414748be9b7b18a03328ba16a76d1970)
DeltaFile
+48-45src/opnsense/mvc/app/views/OPNsense/Diagnostics/ping.volt
+48-451 files

OPNSense/core 9c228e5src/opnsense/mvc/app/views/OPNsense/CaptivePortal index.volt

captive portal: move grid init to tab show event

(cherry picked from commit bc8e2a7f61e9cb353937a65fff96954f5bb830ed)
DeltaFile
+55-49src/opnsense/mvc/app/views/OPNsense/CaptivePortal/index.volt
+55-491 files

OPNSense/core 955d8ecsrc/opnsense/mvc/app/models/OPNsense/Wireguard Client.xml

VPN: WireGuard - fix wrong max PersistentKeepalive (1...65535), closes https://github.com/opnsense/core/issues/9406

(cherry picked from commit f31afb436d42de089e48a66098a3c0095a08fea8)
DeltaFile
+2-2src/opnsense/mvc/app/models/OPNsense/Wireguard/Client.xml
+2-21 files

OPNSense/core f8b6a89src/opnsense/mvc/app/models/OPNsense/OpenVPN OpenVPN.xml

VPN: OpenVPN: Instances / Static Keys - require description to prevent items being lost easily. closes https://github.com/opnsense/core/issues/9287

(cherry picked from commit f4d29ca734aca6407d1b95a733990fe70f309686)
DeltaFile
+3-1src/opnsense/mvc/app/models/OPNsense/OpenVPN/OpenVPN.xml
+3-11 files

OPNSense/core 588973fsrc/opnsense/mvc/app/models/OPNsense/Base/Constraints UniqueConstraint.php, src/opnsense/mvc/app/models/OPNsense/Kea KeaDhcpv4.xml

Services: Kea DHCP: Kea DHCPv4 - case insensitive mac address comparison

PR: https://github.com/opnsense/core/issues/9199
PR: https://github.com/opnsense/core/pull/9202

(cherry picked from commit c06452de79b219af7a2c4deb0a17e3e008e9462c)
(cherry picked from commit fbc403bcf8eba0389b6812140b66432000e8859f)
(cherry picked from commit 1d060380a56153f62609be01573b2399a6b4cc70)
DeltaFile
+34-0src/opnsense/mvc/tests/app/models/OPNsense/Base/Constraints/UniqueConstraintTest.php
+3-0src/opnsense/mvc/app/models/OPNsense/Base/Constraints/UniqueConstraint.php
+1-0src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.xml
+38-03 files

OPNSense/core 78f36e9src/opnsense/mvc/app/library/OPNsense/Trust Store.php

system: missed array return in trust store call
DeltaFile
+2-1src/opnsense/mvc/app/library/OPNsense/Trust/Store.php
+2-11 files

OPNSense/core d83290fsrc/opnsense/mvc/app/controllers/OPNsense/IPsec/forms settings.xml

ipsec: style
DeltaFile
+0-1src/opnsense/mvc/app/controllers/OPNsense/IPsec/forms/settings.xml
+0-11 files

OPNSense/core dd5ec8bsrc/etc rc.configure_firmware

firmware: use exec() instead of shell_exec() for post-update sync call
DeltaFile
+6-2src/etc/rc.configure_firmware
+6-21 files

OPNSense/core f571779src/etc/inc/xmlrpc legacy.inc

xmlrpc: replace realif with device

(cherry picked from commit b166a44efd0c35c29d82a9e26c539c19e0e7f1d7)
DeltaFile
+3-3src/etc/inc/xmlrpc/legacy.inc
+3-31 files

OPNSense/core 940a76fsrc/etc/inc/plugins.inc.d webgui.inc

system: add a user for pass_safe()
DeltaFile
+1-1src/etc/inc/plugins.inc.d/webgui.inc
+1-11 files

OPNSense/core 4339c81src/etc/inc/plugins.inc.d ntpd.inc unbound.inc

backend: replace mwexecf_bg() with mwexecfb() for clarity
DeltaFile
+1-1src/etc/inc/plugins.inc.d/ntpd.inc
+1-1src/etc/inc/plugins.inc.d/unbound.inc
+2-22 files

OPNSense/core 78cf3b7src/etc/inc/plugins.inc.d core.inc

system: reduce diff to master
DeltaFile
+1-1src/etc/inc/plugins.inc.d/core.inc
+1-11 files

OPNSense/core 4cc810csrc/www interfaces_ppps_edit.php interfaces.php

interfaces: replace a few shell executions in static pages
DeltaFile
+3-4src/www/interfaces_ppps_edit.php
+1-3src/www/interfaces.php
+1-1src/www/interfaces_wireless_edit.php
+1-1src/www/services_dhcp.php
+6-94 files

OPNSense/core 850c070src/www interfaces_ppps_edit.php

interfaces: inline this shell execution as well
DeltaFile
+3-3src/www/interfaces_ppps_edit.php
+3-31 files