OPNSense/core 8623a2dsrc/etc/inc filter.inc

Firewall: Settings: Schedules - cleanup the mess in filter_get_time_based_rule_status(), closes https://github.com/opnsense/core/issues/7291

The legacy schedules are implemented quite messy. To find if a schedule matches, the following logic should apply (according to what you can enter in the ui).

1] Is the current time within the specified range, if not --> no match
2] (option 1) does (one of) the day(s) of the week matches the one specified in the schedule. if yes --> match
3] (option 2) does (one of) the date(s) [DDMM] match the one specified in the schedule. if yes --> match
DeltaFile
+27-86src/etc/inc/filter.inc
+27-861 files

OPNSense/core b01adb4src/opnsense/mvc/app/controllers/OPNsense/Trust/Api CertController.php, src/opnsense/mvc/app/library/OPNsense/Trust Store.php

mvc: style sweep
DeltaFile
+2-2src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CertController.php
+1-1src/opnsense/mvc/app/library/OPNsense/Trust/Store.php
+3-32 files

OPNSense/core e2e365dsrc/opnsense/mvc/app/controllers/OPNsense/Trust/Api CertController.php, src/opnsense/mvc/app/library/OPNsense/Trust Store.php

System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248

* add download file dialog (key,cert or p12)
DeltaFile
+67-1src/opnsense/mvc/app/views/OPNsense/Trust/cert.volt
+39-0src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CertController.php
+22-0src/opnsense/mvc/app/library/OPNsense/Trust/Store.php
+128-13 files

OPNSense/core f25adffsrc/etc/inc/plugins.inc.d dhcpd.inc

Services: ISC DHCPv4: Relay - do not add interfaces for virtual types.

missed a spot in previous
DeltaFile
+2-3src/etc/inc/plugins.inc.d/dhcpd.inc
+2-31 files

OPNSense/core a6a6affsrc/etc/inc/plugins.inc.d dhcpd.inc

Services: ISC DHCPv4: Relay - do not add interfaces for virtual types.

This is a temporary fix as our new mvc module should not have this same issue anymore where we automagically try to piggybag on top of unassigned interfaces.
DeltaFile
+5-1src/etc/inc/plugins.inc.d/dhcpd.inc
+5-11 files

OPNSense/core 00cf727src/opnsense/mvc/app/controllers/OPNsense/Core/Api BackupController.php

System: Configuration: History - fix php deprecation messages.

(cherry picked from commit dca47d1c7fcf5a79837b84057fd1c54a70053a02)
DeltaFile
+2-2src/opnsense/mvc/app/controllers/OPNsense/Core/Api/BackupController.php
+2-21 files

OPNSense/core d1b4156src/opnsense/mvc/app/views/OPNsense/Core dashboard.volt, src/opnsense/www/js/widgets BaseTableWidget.js Carp.js

dashboard: base table widget cleanup
DeltaFile
+15-9src/opnsense/www/js/widgets/BaseTableWidget.js
+1-7src/opnsense/www/js/widgets/Carp.js
+0-2src/opnsense/mvc/app/views/OPNsense/Core/dashboard.volt
+16-183 files

OPNSense/core 734d908src/opnsense/www/themes/opnsense/assets/stylesheets main.scss, src/opnsense/www/themes/opnsense/assets/stylesheets/bootstrap _scaffolding.scss

ui: move the layout modification over here
DeltaFile
+7-2src/opnsense/www/themes/opnsense/build/css/main.css
+5-0src/opnsense/www/themes/opnsense/assets/stylesheets/main.scss
+2-2src/opnsense/www/themes/opnsense/assets/stylesheets/bootstrap/_scaffolding.scss
+14-43 files

OPNSense/core b7136e7src/www firewall_rules.php

firewall/rules: fix display of ICMP tooltip (#7289)

The tooltip was missing when the ICMP type is all.
DeltaFile
+4-4src/www/firewall_rules.php
+4-41 files

OPNSense/core 68003e7src/opnsense/mvc/app/views/OPNsense/Core dashboard.volt, src/opnsense/www/js smoothie.js

dashboard: poc
DeltaFile
+1,176-0src/opnsense/www/js/smoothie.js
+633-0src/opnsense/mvc/app/views/OPNsense/Core/dashboard.volt
+223-0src/opnsense/www/js/widgets/Gateways.js
+202-0src/opnsense/www/js/widgets/InterfaceStatistics.js
+172-0src/opnsense/www/js/widgets/TrafficWidget.js
+154-0src/opnsense/www/js/widgets/BaseTableWidget.js
+2,560-016 files not shown
+3,161-322 files

OPNSense/core b588dedsrc/opnsense/mvc/app/models/OPNsense/Syslog/ACL ACL.xml, src/opnsense/mvc/app/views/OPNsense/Syslog index.volt

system: switch "destination" tab to "remote" for consistency #6830
DeltaFile
+5-4src/opnsense/mvc/app/views/OPNsense/Syslog/index.volt
+2-2src/opnsense/mvc/app/models/OPNsense/Syslog/ACL/ACL.xml
+7-62 files

OPNSense/core f87bc9asrc/opnsense/www/themes/opnsense/assets/stylesheets/bootstrap _scaffolding.scss, src/opnsense/www/themes/opnsense/build/css main.css

ui: make hr padding match __mX helpers

$line-height-computed only appears once in scaffolding template
so just switch it to the hardcoded defaults of the __mX class
stylers.  This is done to match MVC forms between use of consistent
margin and horizontal lines as dividers as seen on the MVC logging
settings page.
DeltaFile
+2-2src/opnsense/www/themes/opnsense/assets/stylesheets/bootstrap/_scaffolding.scss
+2-2src/opnsense/www/themes/opnsense/build/css/main.css
+4-42 files

OPNSense/core c2260f6src/opnsense/mvc/app/controllers/OPNsense/Trust/Api CertController.php, src/opnsense/mvc/app/library/OPNsense/Trust Store.php

mvc: style sweep
DeltaFile
+5-2src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CertController.php
+0-2src/opnsense/mvc/app/library/OPNsense/Trust/Store.php
+5-42 files

OPNSense/core 4211e54src/opnsense/mvc/app/controllers/OPNsense/Trust/Api CertController.php, src/opnsense/mvc/app/models/OPNsense/Trust Cert.xml

System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248

* handle externally managed certificates (manual action)
DeltaFile
+5-0src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CertController.php
+3-1src/opnsense/mvc/app/models/OPNsense/Trust/FieldTypes/CertificatesField.php
+1-0src/opnsense/mvc/app/models/OPNsense/Trust/Cert.xml
+9-13 files

OPNSense/core 35b866fsrc/opnsense/mvc/app/controllers/OPNsense/Trust/Api CertController.php, src/opnsense/mvc/app/views/OPNsense/Trust cert.volt

System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248

* add download private key logic (using an ajaxComplete handler)
DeltaFile
+22-0src/opnsense/mvc/app/views/OPNsense/Trust/cert.volt
+11-1src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CertController.php
+33-12 files

OPNSense/core 875fb5dsrc/opnsense/mvc/app/controllers/OPNsense/Trust/Api CertController.php, src/opnsense/mvc/app/library/OPNsense/Trust Store.php

System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248

* add certificate purpose according to rfc3280
* add info button for raw (readable) certificate and csr output
DeltaFile
+86-0src/opnsense/mvc/app/library/OPNsense/Trust/Store.php
+38-4src/opnsense/mvc/app/views/OPNsense/Trust/cert.volt
+16-1src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CertController.php
+1-0src/opnsense/mvc/app/models/OPNsense/Trust/Cert.xml
+141-54 files

OPNSense/core dbd80f3src/www system_certmanager.php

System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248

Make sure legacy page can still handle the new model data (csr always exists, but is empty when not used)
DeltaFile
+1-1src/www/system_certmanager.php
+1-11 files

OPNSense/core 9495214src/opnsense/mvc/app/controllers/OPNsense/Trust/Api CertController.php, src/opnsense/mvc/app/controllers/OPNsense/Trust/forms dialogCert.xml

System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248

Implement certificate actions, further optimize certificate store to limit code duplication.
DeltaFile
+106-76src/opnsense/mvc/app/library/OPNsense/Trust/Store.php
+85-1src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CertController.php
+13-5src/opnsense/mvc/app/controllers/OPNsense/Trust/forms/dialogCert.xml
+10-4src/opnsense/mvc/app/models/OPNsense/Trust/Cert.xml
+5-1src/opnsense/mvc/app/views/OPNsense/Trust/cert.volt
+219-875 files

OPNSense/core b8bd667src/opnsense/mvc/app/controllers/OPNsense/Trust/forms dialogCert.xml, src/opnsense/mvc/app/views/OPNsense/Trust cert.volt

System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248

expand PEM output section when importing data
DeltaFile
+6-0src/opnsense/mvc/app/views/OPNsense/Trust/cert.volt
+1-0src/opnsense/mvc/app/controllers/OPNsense/Trust/forms/dialogCert.xml
+7-02 files

OPNSense/core 006be3asrc/opnsense/mvc/app/controllers/OPNsense/Syslog/Api ServiceController.php, src/opnsense/mvc/app/views/OPNsense/Syslog index.volt

system: patch in reset option #6830
DeltaFile
+24-4src/opnsense/mvc/app/views/OPNsense/Syslog/index.volt
+19-1src/opnsense/mvc/app/controllers/OPNsense/Syslog/Api/ServiceController.php
+6-0src/opnsense/service/conf/actions.d/actions_syslog.conf
+49-53 files

OPNSense/core 6f9fc2dsrc/opnsense/mvc/app/views/OPNsense/Syslog index.volt

system: appropriate GUI styling and functional save #6830
DeltaFile
+15-8src/opnsense/mvc/app/views/OPNsense/Syslog/index.volt
+15-81 files

OPNSense/core 7d3fa10src/opnsense/mvc/app/models/OPNsense/Trust Cert.xml

models: style pass
DeltaFile
+11-11src/opnsense/mvc/app/models/OPNsense/Trust/Cert.xml
+11-111 files

OPNSense/core 73d1000src/opnsense/mvc/app/models/OPNsense/Trust Cert.xml

System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248

require country to satisfy lint :)
DeltaFile
+1-0src/opnsense/mvc/app/models/OPNsense/Trust/Cert.xml
+1-01 files

OPNSense/core ed1bd09. plist, src/opnsense/mvc/app/controllers/OPNsense/Syslog IndexController.php

system: add local settings tab (read only) to logging #6830
DeltaFile
+20-0src/opnsense/mvc/app/controllers/OPNsense/Syslog/forms/local.xml
+13-6src/opnsense/mvc/app/views/OPNsense/Syslog/index.volt
+4-0src/opnsense/mvc/app/controllers/OPNsense/Syslog/IndexController.php
+1-0plist
+38-64 files

OPNSense/core 0e63a68src/opnsense/mvc/app/library/OPNsense/Trust Store.php, src/opnsense/mvc/app/models/OPNsense/Trust/FieldTypes CertificatesField.php

mvc: style sweep
DeltaFile
+11-10src/opnsense/mvc/app/models/OPNsense/Trust/FieldTypes/CertificatesField.php
+3-3src/opnsense/mvc/app/library/OPNsense/Trust/Store.php
+14-132 files

OPNSense/core 945bd66src/opnsense/mvc/app/models/OPNsense/Core/ACL ACL.xml, src/opnsense/mvc/app/models/OPNsense/Syslog/Menu Menu.xml

system: remove the old syslog logging page #6830

New tab is still to be added to the MVC page.  Move it in place
for now and deal with nagivgation and wording later.
DeltaFile
+0-205src/www/diag_logs_settings.php
+0-6src/opnsense/mvc/app/models/OPNsense/Core/ACL/ACL.xml
+3-3src/www/firewall_nat_out_edit.php
+2-2src/www/firewall_nat_edit.php
+1-1src/www/firewall_rules_edit.php
+1-1src/opnsense/mvc/app/models/OPNsense/Syslog/Menu/Menu.xml
+7-2182 files not shown
+7-2208 files

OPNSense/core cf4f97dsrc/www firewall_nat_out_edit.php firewall_rules_edit.php

firewall: fix PHP warnings
DeltaFile
+2-2src/www/firewall_nat_out_edit.php
+2-2src/www/firewall_rules_edit.php
+2-2src/www/firewall_scrub_edit.php
+2-2src/www/firewall_nat_edit.php
+1-1src/www/firewall_scrub.php
+1-1src/www/firewall_nat.php
+10-106 files

OPNSense/core 65b21d8src/opnsense/mvc/app/controllers/OPNsense/Trust/forms dialogCert.xml, src/opnsense/mvc/app/models/OPNsense/Trust/FieldTypes CertificatesField.php

System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248
DeltaFile
+22-1src/opnsense/mvc/app/views/OPNsense/Trust/cert.volt
+5-0src/opnsense/mvc/app/controllers/OPNsense/Trust/forms/dialogCert.xml
+1-1src/opnsense/mvc/app/models/OPNsense/Trust/FieldTypes/CertificatesField.php
+28-23 files

OPNSense/core 7f09889src/opnsense/mvc/app/controllers/OPNsense/Trust/Api CertController.php, src/opnsense/mvc/app/models/OPNsense/Trust Cert.xml

System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248
DeltaFile
+71-1src/opnsense/mvc/app/models/OPNsense/Trust/FieldTypes/CertificatesField.php
+4-1src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CertController.php
+0-3src/opnsense/mvc/app/views/OPNsense/Trust/cert.volt
+1-2src/opnsense/mvc/app/models/OPNsense/Trust/Cert.xml
+76-74 files

OPNSense/core 2baca32src/opnsense/mvc/app/controllers/OPNsense/Trust/Api CertController.php, src/opnsense/mvc/app/controllers/OPNsense/Trust/forms dialogCert.xml

System: Trust: Certificates - work in progress for https://github.com/opnsense/core/issues/7248
DeltaFile
+176-44src/opnsense/mvc/app/library/OPNsense/Trust/Store.php
+76-10src/opnsense/mvc/app/views/OPNsense/Trust/cert.volt
+42-1src/opnsense/mvc/app/controllers/OPNsense/Trust/Api/CertController.php
+19-8src/opnsense/mvc/app/models/OPNsense/Trust/FieldTypes/CertificatesField.php
+25-0src/opnsense/mvc/app/controllers/OPNsense/Trust/forms/dialogCert.xml
+10-1src/opnsense/mvc/app/models/OPNsense/Trust/Cert.xml
+348-646 files