OPNSense/core dad25b5src/opnsense/mvc/app/controllers/OPNsense/CaptivePortal/Api AccessController.php, src/opnsense/service/conf/actions.d actions_hostwatch.conf

Services: Captive Portal - use new hostwatch service introduced in https://github.com/opnsense/core/pull/9354 to collect mac addresses for 26.1
DeltaFile
+7-5src/opnsense/mvc/app/controllers/OPNsense/CaptivePortal/Api/AccessController.php
+8-0src/opnsense/service/conf/actions.d/actions_hostwatch.conf
+15-52 files

OPNSense/core 1894c61src/opnsense/mvc/app/models/OPNsense/Hostdiscovery Hostwatch.xml

Interfaces: Neighbors: Automatic Discovery - by default, only use non-promiscuous mode, final point for https://github.com/opnsense/core/pull/9354

Added to the roadmap as well, as it seemed to be missing.

This new service is a prerequisite for the new (and faster) mac type aliases (https://github.com/opnsense/core/commit/b2a30fc5606ce2d6c781ae9b7282b83e8ec35ac3) and is a requirement for IPv6 captive portal in a future release.
DeltaFile
+1-1src/opnsense/mvc/app/models/OPNsense/Hostdiscovery/Hostwatch.xml
+1-11 files

OPNSense/core 7192016src/opnsense/mvc/app/controllers/OPNsense/CaptivePortal/Api AccessController.php

captiveportal - assign empty array when "interface list arp json" returns invalid json. ref https://forum.opnsense.org/index.php?topic=50177.0
DeltaFile
+3-1src/opnsense/mvc/app/controllers/OPNsense/CaptivePortal/Api/AccessController.php
+3-11 files

OPNSense/core 1de8b3csrc/opnsense/mvc/app/controllers/OPNsense/OpenVPN/Api ExportController.php, src/opnsense/mvc/app/models/OPNsense/Trust/FieldTypes CertificatesField.php

VPN: OpenVPN: Client Export - add "lazy loading" model support on Trust\Cert type and skip dynamic content when loading the model in our export. closes https://github.com/opnsense/core/pull/9552
DeltaFile
+5-1src/opnsense/mvc/app/models/OPNsense/Trust/FieldTypes/CertificatesField.php
+1-1src/opnsense/mvc/app/controllers/OPNsense/OpenVPN/Api/ExportController.php
+6-22 files

OPNSense/core 5f19a26src/opnsense/mvc/app/controllers/OPNsense/Firewall FilterController.php, src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogFilterRule.xml

Firewall: Rules [new]: Add multiselect icmp6type options (#9547)

* Firewall: Rules [new]: Add multiselect icmp6type options

* These should not be ignored in the grid.

* Firewall: Rules [new] - Add multiselect icmp6type options (minor cleanups)

Use icmpv6 parameter codes as defined in https://www.iana.org/assignments/icmpv6-parameters/icmpv6-parameters.xhtml#icmpv6-parameters-codes-8

---------

Co-authored-by: Ad Schellevis <ad at opnsense.org>
DeltaFile
+24-0src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
+11-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
+4-4src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php
+4-4src/opnsense/mvc/app/controllers/OPNsense/Firewall/FilterController.php
+7-0src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.php
+50-95 files

OPNSense/core 8a5b717src/opnsense/mvc/app/views/OPNsense/OpenVPN export.volt

vpn/openvpn: Add simple search functionality for accounts table (#9549)

DeltaFile
+24-2src/opnsense/mvc/app/views/OPNsense/OpenVPN/export.volt
+24-21 files

OPNSense/core 5c1af76src/opnsense/mvc/app/views/OPNsense/OpenVPN export.volt

vpn/openvpn: Add simple search functionality for accounts table
DeltaFile
+20-2src/opnsense/mvc/app/views/OPNsense/OpenVPN/export.volt
+20-21 files

OPNSense/core a0c974dsrc/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogFilterRule.xml

These should not be ignored in the grid.
DeltaFile
+2-2src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
+2-21 files

OPNSense/core ebc7e06src/opnsense/mvc/app/controllers/OPNsense/Firewall FilterController.php, src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogFilterRule.xml

Firewall: Rules [new]: Add multiselect icmp6type options
DeltaFile
+31-0src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
+10-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
+4-4src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php
+7-0src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.php
+3-2src/opnsense/mvc/app/controllers/OPNsense/Firewall/FilterController.php
+55-65 files

OPNSense/core 367712fsrc/opnsense/mvc/app/controllers/OPNsense/Firewall/Api DNatController.php, src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogDNatRule.xml

Firewall: NAT: Destination NAT: Add commands, category to Anti-Lockout rules (#9544)

* Add command to Anti-Lockout rules to redirect to the page they originate from for parity with old view. Add category to Anti-Lockout rules so they pool under Automatically generated rules for parity with the new firewall view. Change position of No RDR and hide it in advanced mode, for parity with the reworked SNAT views comparable option.

* Add sequence number so it appears behind enabled in grid, like in SNAT view
DeltaFile
+13-13src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogDNatRule.xml
+11-1src/opnsense/mvc/app/views/OPNsense/Firewall/dnat_rule.volt
+2-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/DNatController.php
+26-153 files

OPNSense/core 663ec45src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogDNatRule.xml

Add sequence number so it appears behind enabled in grid, like in SNAT view
DeltaFile
+1-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogDNatRule.xml
+1-01 files

OPNSense/core cc00e08src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api DNatController.php, src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogDNatRule.xml

Add command to Anti-Lockout rules to redirect to the page they originate from for parity with old view. Add category to Anti-Lockout rules so they pool under Automatically generated rules for parity with the new firewall view. Change position of No RDR and hide it in advanced mode, for parity with the reworked SNAT views comparable option.
DeltaFile
+12-13src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogDNatRule.xml
+11-1src/opnsense/mvc/app/views/OPNsense/Firewall/dnat_rule.volt
+2-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/DNatController.php
+25-153 files

OPNSense/core 1db3193. plist, src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes RegexField.php

Revert "mvc: Add RegexField and RegexFieldTest that validate PCRE2 engine regular expressions (#9291)"

This reverts commit 03c8d0a36ffd374a0a93ee4eda7d688800577438.

It is a nice idea but it is not going to be used due to technical
complications.  If this is needed later we can always bring it back.
DeltaFile
+0-156src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/RegexFieldTest.php
+0-106src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/RegexField.php
+0-2plist
+0-2643 files

OPNSense/core 16fbc09src/opnsense/mvc/app/views/OPNsense/Unbound dot.volt overrides.volt, src/opnsense/www/css opnsense-bootgrid-layout.css

ui: infosection larger than table width, adjust to bootgrid-footer

While here, bootgrid-footer only existed in the jquery bootgrid
files. Since we plan to drop these at some point, better make
sure they exist in out layout file
DeltaFile
+1-5src/opnsense/mvc/app/views/OPNsense/Unbound/dot.volt
+1-5src/opnsense/mvc/app/views/OPNsense/Unbound/overrides.volt
+5-0src/opnsense/www/css/opnsense-bootgrid-layout.css
+7-103 files

OPNSense/core c2f076fsrc/www interfaces_assign.php

Revert "Interfaces: Assignments - ditch broken $is_ppp validation, the device should exist before allowing assignments (always)."

This reverts commit 5f1b2bb08847ee0c4da29846f7f06887dc0fef68.

Does not work as intended.  PPP devices are not created before assignment.

(cherry picked from commit 9b8d8f4b8c9aa1c84ca776932a61e9a43f501425)
DeltaFile
+9-1src/www/interfaces_assign.php
+9-11 files

OPNSense/core 9b8d8f4src/www interfaces_assign.php

Revert "Interfaces: Assignments - ditch broken $is_ppp validation, the device should exist before allowing assignments (always)."

This reverts commit 5f1b2bb08847ee0c4da29846f7f06887dc0fef68.

Does not work as intended.  PPP devices are not created before assignment.
DeltaFile
+9-1src/www/interfaces_assign.php
+9-11 files

OPNSense/core 01ff149src/opnsense/mvc/app/views/OPNsense/DHCRelay relay.volt

dhcrelay: reload table to update relay status
DeltaFile
+5-1src/opnsense/mvc/app/views/OPNsense/DHCRelay/relay.volt
+5-11 files

OPNSense/core d2d7322src/etc/inc interfaces.lib.inc

interfaces: consistent typing in new p/vltime
DeltaFile
+2-2src/etc/inc/interfaces.lib.inc
+2-21 files

OPNSense/core 8d6439asrc/opnsense/mvc/app/views/OPNsense/Hostdiscovery settings.volt

interfaces: swap columns; closes #9541
DeltaFile
+2-2src/opnsense/mvc/app/views/OPNsense/Hostdiscovery/settings.volt
+2-21 files

OPNSense/core 5e60145. plist, src/opnsense/mvc/app/controllers/OPNsense/Unbound/forms dialogHostOverride.xml

Services: Unbound DNS: Overrides - add refcount for aliases, closes https://github.com/opnsense/core/issues/9540
DeltaFile
+53-0src/opnsense/mvc/app/models/OPNsense/Unbound/FieldTypes/AliasRefCount.php
+5-0src/opnsense/mvc/app/controllers/OPNsense/Unbound/forms/dialogHostOverride.xml
+1-0plist
+1-0src/opnsense/mvc/app/models/OPNsense/Unbound/Unbound.xml
+60-04 files

OPNSense/core 528e074src/etc/rc.subr.d php var

rc: bootstrap /var/lib/php/tests for upcoming test case use

(cherry picked from commit 9dd1bd14a7a15e1b0eca9e0817032bf002f17d23)
DeltaFile
+1-1src/etc/rc.subr.d/php
+1-0src/etc/rc.subr.d/var
+2-12 files

OPNSense/core 8d128a0. plist, src/etc/suricata/conf.d README

intrusion prevention: add README as discussed

(cherry picked from commit 2a02b6f21f344a609ff5467113a97dbb8020c35b)
DeltaFile
+1-0src/etc/suricata/conf.d/README
+1-0plist
+2-02 files

OPNSense/core 3856973src/etc rc.filter_synchronize

firewall: slight simplification in filter sync script

Usually we can let static command line switches live in the format
string.  While here omit the use of the first $output assignment.

(cherry picked from commit 4859bcbb90c40ef6b34b6287e2dc17003522cf53)
DeltaFile
+2-5src/etc/rc.filter_synchronize
+2-51 files

OPNSense/core f70a953src/etc/inc interfaces.inc

interfaces: revisit lifetime deferral #9521
DeltaFile
+32-5src/etc/inc/interfaces.inc
+32-51 files

OPNSense/core 9004219src/etc/inc interfaces.inc

interfaces: revisit lifetime deferral #9521
DeltaFile
+28-5src/etc/inc/interfaces.inc
+28-51 files

OPNSense/core f1e4b5esrc/opnsense/mvc/app/controllers/OPNsense/Firewall/Api DNatController.php

mvc: style
DeltaFile
+2-2src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/DNatController.php
+2-21 files

OPNSense/core 2fb9be1src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api DNatController.php, src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogDNatRule.xml

Firewall: NAT: Destination NAT - add anti-lockout rules on top (static), closes https://github.com/opnsense/core/issues/9514

While here, also add nordr field which seemed to be missing
DeltaFile
+23-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/DNatController.php
+13-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogDNatRule.xml
+1-1src/opnsense/mvc/app/views/OPNsense/Firewall/dnat_rule.volt
+37-13 files

OPNSense/core 3abe6d5src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogFilterRule.xml, src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

Firewall: Rules [new]: Only show icmp type when protocol is icmp (#9535)

DeltaFile
+6-0src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+1-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
+7-12 files

OPNSense/core b892442src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogFilterRule.xml, src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

Add toLowerCase() so the style can be lower case
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
+1-1src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+2-22 files

OPNSense/core 85517c1src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogFilterRule.xml, src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

Firewall: Rules [new]: Only show icmp type when protocol is icmp
DeltaFile
+6-0src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+1-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
+7-12 files