OPNSense/core eeb93a7src/opnsense/mvc/app/library/OPNsense/Firewall Plugin.php

firewall: fix 2f60fcb062cff removing anchor rendering

PR: https://forum.opnsense.org/index.php?topic=50520.0
(cherry picked from commit 311184daa8bdbe2ff5cfc54fdf69841d84655216)
DeltaFile
+2-0src/opnsense/mvc/app/library/OPNsense/Firewall/Plugin.php
+2-01 files

OPNSense/core 05b6330src/opnsense/scripts/health/library/OPNsense/RRD/Types Base.php

reporting: render RRD integer as string

PR: https://github.com/opnsense/core/issues/9686

(cherry picked from commit ca06d54676942764b352339611c3ad9cfcf6906f)
(cherry picked from commit 70629923bb6aef9a9f3a983725c830f021bd4178)
DeltaFile
+1-1src/opnsense/scripts/health/library/OPNsense/RRD/Types/Base.php
+1-11 files

OPNSense/core 94cabd9src/etc/inc/plugins.inc.d radvd.inc

radvd: When Base6Interface is set, use its primary WAN IPv6 address and always prefer its IPv6 address before the advertising interfaces IPv6 address.
DeltaFile
+11-4src/etc/inc/plugins.inc.d/radvd.inc
+11-41 files

OPNSense/core f76921asrc/etc/inc/plugins.inc.d radvd.inc

radvd: In case of Base6Interface constructor, use link-local address as there will not be a primary address on the same interface. This will also cause the automatic rdnss option to become a link local IP address.
DeltaFile
+3-1src/etc/inc/plugins.inc.d/radvd.inc
+3-11 files

OPNSense/core 6933841src/opnsense/scripts/health/library/OPNsense/RRD/Types Base.php

reporting: render RRD integer as string

PR: https://github.com/opnsense/core/issues/9686

(cherry picked from commit ca06d54676942764b352339611c3ad9cfcf6906f)
(cherry picked from commit 70629923bb6aef9a9f3a983725c830f021bd4178)
DeltaFile
+1-1src/opnsense/scripts/health/library/OPNsense/RRD/Types/Base.php
+1-11 files

OPNSense/core 7062992src/opnsense/mvc/app/library/OPNsense/Core Shell.php, src/opnsense/scripts/health/library/OPNsense/RRD/Types Base.php

reporting: render as string instead for #9686

Revert ca06d54676942764b3.  A command line is a string and
don't offer exceptions to escaping.

We may consider replacing %[^s%] with %s in the format
string but there aren't many cases where it matters either.
Should just be part of the documentation we need to offer
soon.
DeltaFile
+2-1src/opnsense/mvc/app/library/OPNsense/Core/Shell.php
+1-1src/opnsense/scripts/health/library/OPNsense/RRD/Types/Base.php
+3-22 files

OPNSense/core ca06d54src/opnsense/mvc/app/library/OPNsense/Core Shell.php

backend: fix regression in https://github.com/opnsense/core/commit/796a5c725bc6dd90a5f425e3b0ebf89054606a02, when using %d or %f as formatters, we can't push them through escapeshellarg() as it will mangle the data unneeded. closes https://github.com/opnsense/core/issues/9686
DeltaFile
+1-2src/opnsense/mvc/app/library/OPNsense/Core/Shell.php
+1-21 files

OPNSense/core 311184dsrc/opnsense/mvc/app/library/OPNsense/Firewall Plugin.php

firewall: fix 2f60fcb062cff removing anchor rendering

PR: https://forum.opnsense.org/index.php?topic=50520.0
DeltaFile
+2-0src/opnsense/mvc/app/library/OPNsense/Firewall/Plugin.php
+2-01 files

OPNSense/core 5cbec07src/etc/inc interfaces.inc, src/opnsense/scripts/interfaces rtsold_script.sh

interfaces: multi-dhcp6c support and custom PD association #7647

This splits off rtsold and dhcp6c into separate processes
which frees us from the restrictions of faked iterative IDs
for PD associations.  For NA we simply default to 0 now.

I'm not entirely sure why we settled for a single deamon of
dhcp6c back in the day, but there are certianly downsides to
it and I don't see something that wasn't fixed in the meantime
that makes this not work.
DeltaFile
+22-58src/etc/inc/interfaces.inc
+58-4src/www/interfaces.php
+6-6src/opnsense/scripts/interfaces/rtsold_script.sh
+86-683 files

OPNSense/core cd653ddsrc/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogFilterRule.xml, src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

Firewall: Rules [new]: Statistics column is responsive now
DeltaFile
+13-9src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+0-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
+13-102 files

OPNSense/core 0f6cc03src/opnsense/mvc/app/models/OPNsense/Firewall DNat.xml, src/opnsense/mvc/app/views/OPNsense/Firewall dnat_rule.volt

Firewall: NAT: Destination NAT: The local-port field does not support range and well-known name (#9668)

* Make validation messages clearer
* Use selector in loop to determine where to replace the data (just the label is changed)
DeltaFile
+9-1src/opnsense/mvc/app/views/OPNsense/Firewall/dnat_rule.volt
+3-3src/opnsense/mvc/app/models/OPNsense/Firewall/DNat.xml
+12-42 files

OPNSense/core c264c90src/opnsense/mvc/app/library/OPNsense/Core ConfigMaintenance.php, src/www interfaces.php

interfaces: check dhcpdv6.enabled for -1 and add legacy config sections

PR: https://forum.opnsense.org/index.php?topic=50580.0
DeltaFile
+2-2src/www/interfaces.php
+2-0src/opnsense/mvc/app/library/OPNsense/Core/ConfigMaintenance.php
+4-22 files

OPNSense/core 889098csrc/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterBaseController.php

Firewall: Rules [new]: FilterBaseController requires Base\UserException (#9669)

(cherry picked from commit ec20be4dd42be415d44b1373c49ce7e336944de9)
DeltaFile
+1-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php
+1-01 files

OPNSense/core ec20be4src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterBaseController.php

Firewall: Rules [new]: FilterBaseController requires Base\UserException (#9669)

DeltaFile
+1-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php
+1-01 files

OPNSense/core ae22620src/etc/inc filter.lib.inc

firewall: fix typo with sprintf(); closes #9664

(cherry picked from commit 476ad93d6f380c18ee766353c15235e462864398)
DeltaFile
+1-1src/etc/inc/filter.lib.inc
+1-11 files

OPNSense/core dcef846src/opnsense/service/conf/actions.d actions_hostwatch.conf

interfaces: host discovery: make sure the full dump includes NDP output if hostwatch is disabled

(cherry picked from commit f7fac5a6f4ac9ba502acab688a6d8092d942d77d)
DeltaFile
+1-1src/opnsense/service/conf/actions.d/actions_hostwatch.conf
+1-11 files

OPNSense/core 96dd059src/opnsense/mvc/app/models/OPNsense/Interfaces/Migrations SET1_0_0.php

interfaces: fix migration for no-release option

This was introduced in d87ce014d96f storing the enabled value as "yes"
instead of true.  Threat it the same as the debug option.

PR: https://forum.opnsense.org/index.php?topic=50575.0 (and others)
(cherry picked from commit 7a11458ea23424dd475d394cb2f64015df257849)
DeltaFile
+1-1src/opnsense/mvc/app/models/OPNsense/Interfaces/Migrations/SET1_0_0.php
+1-11 files

OPNSense/core 8ecd344src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterBaseController.php

Firewall: Rules [new]: FilterBaseController requires Base\UserException
DeltaFile
+1-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php
+1-01 files

OPNSense/core 1a087bfsrc/opnsense/mvc/app/views/OPNsense/Firewall dnat_rule.volt

Use selector in loop to determine where to replace the data
DeltaFile
+9-3src/opnsense/mvc/app/views/OPNsense/Firewall/dnat_rule.volt
+9-31 files

OPNSense/core 7a11458src/opnsense/mvc/app/models/OPNsense/Interfaces/Migrations SET1_0_0.php

interfaces: fix migration for no-release option

This was introduced in d87ce014d96f storing the enabled value as "yes"
instead of true.  Threat it the same as the debug option.

PR: https://forum.opnsense.org/index.php?topic=50575.0 (and others)
DeltaFile
+1-1src/opnsense/mvc/app/models/OPNsense/Interfaces/Migrations/SET1_0_0.php
+1-11 files

OPNSense/core 32b37dfsrc/opnsense/mvc/app/models/OPNsense/Firewall DNat.xml

Make validation messages clearer
DeltaFile
+3-3src/opnsense/mvc/app/models/OPNsense/Firewall/DNat.xml
+3-31 files

OPNSense/core ac0e0dcsrc/opnsense/mvc/app/models/OPNsense/Firewall DNat.xml, src/opnsense/mvc/app/views/OPNsense/Firewall dnat_rule.volt

Firewall: NAT: Destination NAT: The local-port field does not support range and well-known name
DeltaFile
+5-3src/opnsense/mvc/app/views/OPNsense/Firewall/dnat_rule.volt
+1-1src/opnsense/mvc/app/models/OPNsense/Firewall/DNat.xml
+6-42 files

OPNSense/core 60deb9dsrc/etc/inc config.inc, src/opnsense/mvc/app/library/OPNsense/Core Syslog.php

mvc: support verbose logging in run_migrations.php

PR: https://github.com/opnsense/core/issues/9666

(cherry picked from commit 816fd574c9113d836363ab989d120b1856827097)
(cherry picked from commit be4900b112f122a8e2d90efe4aaff05ea9e4a033)
(cherry picked from commit 5cc95f47a6e43abdf1158511408a53570d12d1d8)
(cherry picked from commit ffe3b4087263e50e884768a8b18512f894f13226)
DeltaFile
+20-0src/opnsense/mvc/app/library/OPNsense/Core/Syslog.php
+18-1src/opnsense/mvc/script/run_migrations.php
+7-4src/sbin/pluginctl
+1-1src/etc/inc/config.inc
+46-64 files

OPNSense/core ffe3b40src/opnsense/mvc/script run_migrations.php, src/sbin pluginctl

mvc: migration tweaks again for #9666
DeltaFile
+2-0src/opnsense/mvc/script/run_migrations.php
+1-1src/sbin/pluginctl
+3-12 files

OPNSense/core 5cc95f4src/opnsense/mvc/app/library/OPNsense/Core Syslog.php

mvc: minor logging tweak for stdout
DeltaFile
+1-1src/opnsense/mvc/app/library/OPNsense/Core/Syslog.php
+1-11 files

OPNSense/core be4900bsrc/etc/inc config.inc, src/sbin pluginctl

pluginctl: use verbose migration mode #9666
DeltaFile
+6-3src/sbin/pluginctl
+1-1src/etc/inc/config.inc
+7-42 files

OPNSense/core 816fd57src/opnsense/mvc/app/library/OPNsense/Core Syslog.php, src/opnsense/mvc/script run_migrations.php

mvc: support verbose logging in run_migrations.php, closes https://github.com/opnsense/core/issues/9666

This might be practical for some other system tools eventually too, since Syslog() is our own wrapper, we can echo output to stdout when requested. By making the callout static, each component can still have its own logger instance (and verbose log to stdout)

usage: /usr/local/opnsense/mvc/script/run_migrations.php -v
DeltaFile
+20-0src/opnsense/mvc/app/library/OPNsense/Core/Syslog.php
+16-1src/opnsense/mvc/script/run_migrations.php
+36-12 files

OPNSense/core 9e70ee7. plist, src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api ManualSPDController.php ManualSpdController.php

mvc: use linter to find two wrong file names; closes #9638
DeltaFile
+71-0src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/ManualSPDController.php
+0-71src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/ManualSpdController.php
+39-0src/opnsense/mvc/app/controllers/OPNsense/Interfaces/VxLanController.php
+0-39src/opnsense/mvc/app/controllers/OPNsense/Interfaces/VxlanController.php
+2-2plist
+112-1125 files

OPNSense/core cff4c08Mk lint.mk, Scripts class-filename.sh

make: add a linter for PHP class name consistency #9638
DeltaFile
+52-0Scripts/class-filename.sh
+4-1Mk/lint.mk
+56-12 files

OPNSense/core 9a522fcsrc/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

Firewall: Rules [new]: Remember the last selected interface and restore it inside the selectpicker automatically on load
DeltaFile
+10-5src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+10-51 files