OPNSense/core a515840src/etc/inc/plugins.inc.d kea.inc

Apply suggestion from @Monviech
DeltaFile
+0-1src/etc/inc/plugins.inc.d/kea.inc
+0-11 files

OPNSense/core 2db56bfsrc/etc/inc interfaces.inc, src/opnsense/scripts/interfaces rtsold_script.sh

interfaces: multi-dhcp6c support #7647

This splits off rtsold and dhcp6c into separate processes.

I'm not entirely sure why we settled for a single deamon of
dhcp6c back in the day, but there are certianly downsides to
it and I don't see something that wasn't fixed in the meantime
that makes this not work.
DeltaFile
+6-20src/etc/inc/interfaces.inc
+6-6src/opnsense/scripts/interfaces/rtsold_script.sh
+12-262 files

OPNSense/core affea84src/opnsense/mvc/app/models/OPNsense/Kea KeaDhcpv4.xml KeaDhcpv6.xml

Add a DependConstraint for ddns_domain_key_secret instead of making it a required field, saves on model migrations
DeltaFile
+10-3src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.xml
+10-3src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.xml
+20-62 files

OPNSense/core f7b6149src/opnsense/mvc/app/models/OPNsense/Kea KeaDdns.php KeaDhcpv4.php

Review comments, add trailing commas for diff control reasons
DeltaFile
+3-3src/opnsense/mvc/app/models/OPNsense/Kea/KeaDdns.php
+1-1src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php
+1-1src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php
+5-53 files

OPNSense/core c6f245esrc/opnsense/mvc/app/models/OPNsense/Kea KeaDdns.php

Update src/opnsense/mvc/app/models/OPNsense/Kea/KeaDdns.php

Co-authored-by: Franco Fichtner <franco at opnsense.org>
DeltaFile
+1-1src/opnsense/mvc/app/models/OPNsense/Kea/KeaDdns.php
+1-11 files

OPNSense/core 541a1ecsrc/opnsense/mvc/app/models/OPNsense/Kea KeaDdns.php

fix DDNS config generation to place key-name at domain level and deduplicate DNS servers
DeltaFile
+13-6src/opnsense/mvc/app/models/OPNsense/Kea/KeaDdns.php
+13-61 files

OPNSense/core 9562579src/etc/rc.subr.d php var

rc: speed up file deletes

PR: https://forum.opnsense.org/index.php?topic=51232.0
DeltaFile
+1-1src/etc/rc.subr.d/php
+1-1src/etc/rc.subr.d/var
+2-22 files

OPNSense/core 958794bsrc/opnsense/mvc/app/controllers/OPNsense/Kea/Api DdnsController.php

Copyright date
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/Kea/Api/DdnsController.php
+1-11 files

OPNSense/core 33f229esrc/opnsense/mvc/app/models/OPNsense/Kea KeaDdns.xml

Add newline to model
DeltaFile
+1-1src/opnsense/mvc/app/models/OPNsense/Kea/KeaDdns.xml
+1-11 files

OPNSense/core fe71428src/etc/inc/plugins.inc.d kea.inc

Lets not offer manual config at the beginning
DeltaFile
+2-4src/etc/inc/plugins.inc.d/kea.inc
+2-41 files

OPNSense/core 2059cc0src/opnsense/mvc/app/models/OPNsense/Kea KeaDdns.php

Now that we tightened validation in the model we can drop some guards in the config generator
DeltaFile
+3-3src/opnsense/mvc/app/models/OPNsense/Kea/KeaDdns.php
+3-31 files

OPNSense/core d2dfd36src/opnsense/mvc/app/models/OPNsense/Kea KeaDhcpv4.xml KeaDhcpv6.xml

Validate dependency between forward zone and DNS server
DeltaFile
+18-0src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.xml
+18-0src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.xml
+36-02 files

OPNSense/core 34468ffsrc/opnsense/mvc/app/controllers/OPNsense/Kea/forms dialogSubnet6.xml

Fix labels in dialogs
DeltaFile
+2-2src/opnsense/mvc/app/controllers/OPNsense/Kea/forms/dialogSubnet6.xml
+2-21 files

OPNSense/core ed2882esrc/opnsense/mvc/app/models/OPNsense/Kea KeaDhcpv4.xml KeaDhcpv6.xml

key_algorithm is required due to the default
DeltaFile
+1-0src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.xml
+1-0src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.xml
+2-02 files

OPNSense/core de1cc53src/opnsense/mvc/app/models/OPNsense/Kea KeaDhcpv6.xml KeaDhcpv4.xml

Small tweak on validation message, push default of key_algorithm to model
DeltaFile
+5-4src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.xml
+5-4src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.xml
+1-1src/opnsense/mvc/app/models/OPNsense/Kea/KeaDdns.php
+11-93 files

OPNSense/core f8df792src/opnsense/mvc/app/models/OPNsense/Kea KeaDhcpv6.xml KeaDhcpv4.xml

Use single validation string
DeltaFile
+3-3src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.xml
+2-2src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.xml
+5-52 files

OPNSense/core 632dda5src/opnsense/mvc/app/controllers/OPNsense/Kea/forms dialogSubnet4.xml dialogSubnet6.xml, src/opnsense/mvc/app/models/OPNsense/Kea KeaDhcpv6.xml KeaDhcpv4.xml

Add constraints for key_name and key_secret to be used together, adjust some property names for clarity, extend ddns_domain_key_algorithm with all supported values per documentation
DeltaFile
+27-5src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.xml
+27-4src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.xml
+3-3src/opnsense/mvc/app/models/OPNsense/Kea/KeaDdns.php
+2-2src/opnsense/mvc/app/controllers/OPNsense/Kea/forms/dialogSubnet4.xml
+2-2src/opnsense/mvc/app/controllers/OPNsense/Kea/forms/dialogSubnet6.xml
+61-165 files

OPNSense/core 838873asrc/opnsense/service/modules/actions script_output.py

configd: change https://github.com/opnsense/core/commit/c8cd5565ec135a0111497fde2e20e3cb79324f0d seemed to have uncovered another issue when it comes to file generation, as each call generates a new tempfile, we're now keeping a lot of them.

In order to fix this behavoir, only generate the filename and reuse it when serving cached commands, which was the intention from the beginning.

(cherry picked from commit 914e5a20e172200593190e12a7c83670fe22ce1a)
DeltaFile
+15-3src/opnsense/service/modules/actions/script_output.py
+15-31 files

OPNSense/core d68d14asrc/opnsense/scripts/shell restore.sh

shell: fix the alignment in latest code

(cherry picked from commit 16dd293e913227eefb4390185500b5328be2f423)
(cherry picked from commit 633255aab2d64e94040fe07878c94157bffbda47)
DeltaFile
+4-2src/opnsense/scripts/shell/restore.sh
+4-21 files

OPNSense/core 633255asrc/opnsense/scripts/shell restore.sh

shell: the former calculation was correct but forgot about the whitespaces

Use the full screen with a clear for listing. 80x25 is the bare minimum.
DeltaFile
+6-4src/opnsense/scripts/shell/restore.sh
+6-41 files

OPNSense/core 5754449src/opnsense/mvc/app/models/OPNsense/Kea KeaDdns.xml KeaDhcpv4.xml

It looks like a trailing dot validation is not necessary as the configuration is valid regardless, kea does not crash or log any error here
DeltaFile
+1-1src/opnsense/mvc/app/models/OPNsense/Kea/KeaDdns.xml
+0-1src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.xml
+0-1src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.xml
+1-33 files

OPNSense/core 2baf559src/opnsense/mvc/app/controllers/OPNsense/Kea/forms ddnsSettings.xml, src/opnsense/mvc/app/models/OPNsense/Kea KeaDhcpv4.php KeaDdns.php

More terminology changes for ddns server ip and port
DeltaFile
+2-2src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php
+2-2src/opnsense/mvc/app/models/OPNsense/Kea/KeaDdns.php
+2-2src/opnsense/mvc/app/models/OPNsense/Kea/KeaDdns.xml
+2-2src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php
+1-1src/opnsense/mvc/app/controllers/OPNsense/Kea/forms/ddnsSettings.xml
+9-95 files

OPNSense/core 16dd293src/opnsense/scripts/shell restore.sh

shell: fix the alignment in latest code

Not sure how this happened.  Was supposed to fit 80 character
console screen.
DeltaFile
+3-3src/opnsense/scripts/shell/restore.sh
+3-31 files

OPNSense/core 56997dfsrc/opnsense/mvc/app/views/OPNsense/Kea ddns.volt

Update service controls via data_service_widget
DeltaFile
+1-4src/opnsense/mvc/app/views/OPNsense/Kea/ddns.volt
+1-41 files

OPNSense/core 8b7a365src/opnsense/mvc/app/controllers/OPNsense/Kea/forms dialogSubnet4.xml dialogSubnet6.xml, src/opnsense/mvc/app/models/OPNsense/Kea KeaDdns.xml

Some updates to ddns model and dialogs
DeltaFile
+9-12src/opnsense/mvc/app/controllers/OPNsense/Kea/forms/dialogSubnet4.xml
+9-12src/opnsense/mvc/app/controllers/OPNsense/Kea/forms/dialogSubnet6.xml
+4-4src/opnsense/mvc/app/controllers/OPNsense/Kea/forms/ddnsSettings.xml
+4-4src/opnsense/mvc/app/models/OPNsense/Kea/KeaDdns.xml
+26-324 files

OPNSense/core 561e73esrc/opnsense/mvc/app/models/OPNsense/Kea KeaDdns.php

The control socket is not needed right now. It would only be required to directly query the ddns server
DeltaFile
+0-5src/opnsense/mvc/app/models/OPNsense/Kea/KeaDdns.php
+0-51 files

OPNSense/core 914e5a2src/opnsense/service/modules/actions script_output.py

configd: change https://github.com/opnsense/core/commit/c8cd5565ec135a0111497fde2e20e3cb79324f0d seemed to have uncovered another issue when it comes to file generation, as each call generates a new tempfile, we're now keeping a lot of them.

In order to fix this behavoir, only generate the filename and reuse it when serving cached commands, which was the intention from the beginning.
DeltaFile
+15-3src/opnsense/service/modules/actions/script_output.py
+15-31 files

OPNSense/core 2c473f8src/opnsense/mvc/app/models/OPNsense/Kea KeaDdns.php KeaDhcpv4.xml

Add a default for ddns_domain_algorithm inside the config generator
DeltaFile
+5-5src/opnsense/mvc/app/models/OPNsense/Kea/KeaDdns.php
+1-2src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.xml
+1-1src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.xml
+7-83 files

OPNSense/core 1ffaff8src/www firewall_nat_out.php

firewall: use safe config iteration in outbound NAT page
DeltaFile
+3-4src/www/firewall_nat_out.php
+3-41 files

OPNSense/core 378b291src/www system_advanced_admin.php

system: use safe config iteration in admin settings page
DeltaFile
+2-2src/www/system_advanced_admin.php
+2-21 files