OPNSense/core 2e90e6fsrc/opnsense/scripts/firmware config.sh

firmware: fix return value masking during updates

This caused reboots when updates not supposed to reboot
in case base/kernel could not install.  This way since
26.1.8.
DeltaFile
+3-4src/opnsense/scripts/firmware/config.sh
+3-41 files

OPNSense/core 0fe799fsrc/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterController.php

Firewall: Rules: use strnatcasecmp() for interface list (#10412)
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+1-11 files

OPNSense/core 39ffacfsrc/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterController.php

Firewall: Rules: use strnatcasecmp() for interface list
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+1-11 files

OPNSense/core 8ff00fasrc/opnsense/mvc/app/views/layout_partials base_apply_button.volt, src/opnsense/www/js opnsense_ui.js

ui: fix excessive padding on apply section (#10409)

(cherry picked from commit 7a53cf1547beac857393ef97f4008bb91b5d4a52)
(cherry picked from commit 70853ba8ac3f6ec0e80cf639539e3da1b141d6bb)
DeltaFile
+2-2src/opnsense/www/js/opnsense_ui.js
+1-1src/opnsense/mvc/app/views/layout_partials/base_apply_button.volt
+3-32 files

OPNSense/core 96fa955src/opnsense/mvc/app/views/OPNsense/IPsec connections.volt, src/opnsense/www/js opnsense_bootgrid.js

ipsec: disable scroll in authentication and children grids (#10407)

Since the grids live on a lower position on the screen, the height calculation may squash the entries. This should be solved by enforcing a minimum row constraint, but for ipsec specifically being able to see all children at all times is more important, which is what this commit aims to solve.

(cherry picked from commit d2affcf0c0d14724237fd2a4aecc741f4ed2fd68)
DeltaFile
+1-0src/opnsense/www/js/opnsense_bootgrid.js
+1-0src/opnsense/mvc/app/views/OPNsense/IPsec/connections.volt
+2-02 files

OPNSense/core 3011649src/opnsense/mvc/app/views/OPNsense/Syslog index.volt, src/opnsense/mvc/app/views/OPNsense/TrafficShaper index.volt

ui: button padding when injecting next to apply button

Perhaps these fit another location much better, but keep them for now
and make sure that they are "primary" since they do a thing with a
confirmation button.

pull-right doesn't do much anymore and insertAfter already makes it
the rightmost button.

(cherry picked from commit d521d7d5293e5c63227e9dc6f8d986b70959da84)
DeltaFile
+1-1src/opnsense/mvc/app/views/OPNsense/Syslog/index.volt
+1-1src/opnsense/mvc/app/views/OPNsense/TrafficShaper/index.volt
+2-22 files

OPNSense/core d521d7dsrc/opnsense/mvc/app/views/OPNsense/Syslog index.volt, src/opnsense/mvc/app/views/OPNsense/TrafficShaper index.volt

ui: button padding when injecting next to apply button

Perhaps these fit another location much better, but keep them for now
and make sure that they are "primary" since they do a thing with a
confirmation button.

pull-right doesn't do much anymore and insertAfter already makes it
the rightmost button.
DeltaFile
+1-1src/opnsense/mvc/app/views/OPNsense/Syslog/index.volt
+1-1src/opnsense/mvc/app/views/OPNsense/TrafficShaper/index.volt
+2-22 files

OPNSense/core 70853basrc/opnsense/mvc/app/views/layout_partials base_apply_button.volt, src/opnsense/www/js opnsense_ui.js

ui: simplify previous
DeltaFile
+2-3src/opnsense/www/js/opnsense_ui.js
+1-1src/opnsense/mvc/app/views/layout_partials/base_apply_button.volt
+3-42 files

OPNSense/core c26e4dasrc/opnsense/mvc/app/views/layout_partials base_apply_button.volt, src/opnsense/www/js opnsense_ui.js

ui: simplify previous
DeltaFile
+2-3src/opnsense/www/js/opnsense_ui.js
+1-1src/opnsense/mvc/app/views/layout_partials/base_apply_button.volt
+3-42 files

OPNSense/core 7a53cf1src/opnsense/mvc/app/views/layout_partials base_apply_button.volt, src/opnsense/www/js opnsense_ui.js

ui: fix excessive padding on apply section (#10409)
DeltaFile
+3-2src/opnsense/www/js/opnsense_ui.js
+1-1src/opnsense/mvc/app/views/layout_partials/base_apply_button.volt
+4-32 files

OPNSense/core ebfe40fsrc/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterBaseController.php, src/opnsense/mvc/app/models/OPNsense/Firewall Filter.php

Firewall: Rules: Remove safepoint actions, no consumers in GUI are left, and we don't know of any external API consumers
DeltaFile
+0-69src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterBaseController.php
+0-25src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.php
+0-942 files

OPNSense/core d8c9fa4src/opnsense/mvc/app/views/OPNsense/Core firmware.volt

firmware: put clickable trailer for community plugins; closes #10379

This is the same apprach as changelogs.  People may be more
inclined to see it below.

(cherry picked from commit 274edbb7308fbf687d8da094e52410d29e4b075c)
DeltaFile
+16-14src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt
+16-141 files

OPNSense/core a3f2573src/opnsense/mvc/app/views/layout_partials base_form.volt

mvc: static header support for forms same as f8af03c8ecf8c

(cherry picked from commit 74c9f98cc3771ea2eef83dbaef860b35c4d1a51c)
DeltaFile
+6-4src/opnsense/mvc/app/views/layout_partials/base_form.volt
+6-41 files

OPNSense/core fcacf66Scripts dashboard-acl.sh, src/opnsense/www/js/widgets/Metadata Core.xml

system: revisit dashboard linting
DeltaFile
+12-14Scripts/dashboard-acl.sh
+6-1src/opnsense/www/js/widgets/Metadata/Core.xml
+18-152 files

OPNSense/core 8eb8380src/opnsense/www/themes/opnsense-auto/build css.link fonts.link

pkg: repackage actual links as ".link" package build trick

So "make lint-php" woud cause the spurious PHP errors showing
up in the GUI on my end with some command line too reading a
directory.  Turned out to be these links and we have this nice
trick to deal with it.
DeltaFile
+1-0src/opnsense/www/themes/opnsense-auto/build/css.link
+1-0src/opnsense/www/themes/opnsense-auto/build/fonts.link
+1-0src/opnsense/www/themes/opnsense-auto/build/images.link
+0-1src/opnsense/www/themes/opnsense-auto/build/css
+0-1src/opnsense/www/themes/opnsense-auto/build/fonts
+0-1src/opnsense/www/themes/opnsense-auto/build/images
+3-36 files

OPNSense/core cf506a2src/opnsense/mvc/app/controllers/OPNsense/Base ControllerBase.php, src/opnsense/mvc/app/views/layout_partials base_form.volt base_dialog.volt

MVC:ui - refactor base_dialog and parseFormNode to simplify the template for https://github.com/opnsense/core/issues/9955

Move defaults to parseFormNode() and introduce "sections" with children to avoid some more magic in the volt templates.

Set default title on multi selectpickers as these sometimes seem to miss the "Nothing selected" phrase for some odd reason.

Functionally this should be a backward compatible change.
DeltaFile
+69-80src/opnsense/mvc/app/views/layout_partials/base_form.volt
+32-81src/opnsense/mvc/app/views/layout_partials/base_dialog.volt
+31-3src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php
+2-2src/opnsense/mvc/app/views/layout_partials/form_input_tr.volt
+134-1664 files

OPNSense/core 4614679src/opnsense/mvc/app/controllers/OPNsense/Base ControllerBase.php, src/opnsense/mvc/app/views/layout_partials base_form.volt base_dialog.volt

MVC:ui - [WIP] refactor base_dialog and parseFormNode to simplify the template for https://github.com/opnsense/core/issues/9955
DeltaFile
+69-80src/opnsense/mvc/app/views/layout_partials/base_form.volt
+32-81src/opnsense/mvc/app/views/layout_partials/base_dialog.volt
+31-3src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php
+2-2src/opnsense/mvc/app/views/layout_partials/form_input_tr.volt
+134-1664 files

OPNSense/core fc58ebasrc/opnsense/mvc/app/controllers/OPNsense/Base ControllerBase.php, src/opnsense/mvc/app/views/layout_partials base_form.volt base_dialog.volt

MVC:ui - [WIP] refactor base_dialog and parseFormNode to simplify the template for https://github.com/opnsense/core/issues/9955
DeltaFile
+69-80src/opnsense/mvc/app/views/layout_partials/base_form.volt
+32-81src/opnsense/mvc/app/views/layout_partials/base_dialog.volt
+31-3src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php
+1-1src/opnsense/mvc/app/views/layout_partials/form_input_tr.volt
+133-1654 files

OPNSense/core 308aa51src/opnsense/mvc/app/controllers/OPNsense/Base ControllerBase.php, src/opnsense/mvc/app/views/layout_partials base_dialog.volt

MVC:ui - [WIP] refactor base_dialog and parseFormNode to simplify the template for https://github.com/opnsense/core/issues/9955
DeltaFile
+32-81src/opnsense/mvc/app/views/layout_partials/base_dialog.volt
+31-3src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php
+63-842 files

OPNSense/core 274edbbsrc/opnsense/mvc/app/views/OPNsense/Core firmware.volt

firmware: put clickable trailer for community plugins; closes #10379

This is the same apprach as changelogs.  People may be more
inclined to see it below.
DeltaFile
+16-14src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt
+16-141 files

OPNSense/core d2affcfsrc/opnsense/mvc/app/views/OPNsense/IPsec connections.volt, src/opnsense/www/js opnsense_bootgrid.js

ipsec: disable scroll in authentication and children grids (#10407)

Since the grids live on a lower position on the screen, the height calculation may squash the entries. This should be solved by enforcing a minimum row constraint, but for ipsec specifically being able to see all children at all times is more important, which is what this commit aims to solve.
DeltaFile
+1-0src/opnsense/mvc/app/views/OPNsense/IPsec/connections.volt
+1-0src/opnsense/www/js/opnsense_bootgrid.js
+2-02 files

OPNSense/core 9d0e4bfsrc/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes TextFieldTest.php

src: style update
DeltaFile
+0-1src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/TextFieldTest.php
+0-11 files

OPNSense/core c34b778. plist, src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes TextField.php StrictTextField.php

mvc: add new validators to TextField: AllowSpaces, AllowNewlines, AllowSpecial and introduce new StrictTextField (#10398)

* mvc: add new validators to TextField: AllowSpaces, AllowNewlines, AllowSpecial

* Introduce a StrictTextField that inherits TextField but changes all defaults to their strictest preset
DeltaFile
+127-0src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/StrictTextFieldTest.php
+82-0src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/TextFieldTest.php
+61-2src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/TextField.php
+51-0src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/StrictTextField.php
+2-0plist
+323-25 files

OPNSense/core 5e9ddd5. plist, src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes StrictTextField.php TextField.php

Introduce a StrictTextField that inherits TextField but changes all defaults to their strictest preset
DeltaFile
+127-0src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/StrictTextFieldTest.php
+51-0src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/StrictTextField.php
+6-6src/opnsense/mvc/tests/app/models/OPNsense/Base/FieldTypes/TextFieldTest.php
+2-0plist
+1-1src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/TextField.php
+187-75 files

OPNSense/core 74c9f98src/opnsense/mvc/app/views/layout_partials base_form.volt

mvc: static header support for forms same as f8af03c8ecf8c
DeltaFile
+6-4src/opnsense/mvc/app/views/layout_partials/base_form.volt
+6-41 files

OPNSense/core 18e623csrc/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

Firewall: Rules: add banner if no rules defined (#10396)

(cherry picked from commit 84ae8875d439fa8a2ae402e89ecf811eeee9fd31)
DeltaFile
+22-0src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+22-01 files

OPNSense/core bcaee51src/etc/inc filter.lib.inc, src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterController.php

Firewall: Rules [new]: Always show automatic and legacy rules, and a few more UI tweaks (#10355)

(cherry picked from commit 18533b4c60c27253f8c2ebbdfd9bc11d6450da1d)
(cherry picked from commit 6402be8a5420f26192474f01af552b6617421513)
(cherry picked from commit 446ef1aef945029c4bd7b90b6bfd318abcfceb00)
DeltaFile
+229-88src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+19-43src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+6-3src/opnsense/www/js/opnsense_bootgrid.js
+5-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
+1-1src/etc/inc/filter.lib.inc
+260-1365 files

OPNSense/core 56da1bbsrc/opnsense/mvc/app/models/OPNsense/OpenVPN OpenVPN.xml

VPN: OpenVPN: Instances - require at least 1 for vpnid field, same as auto-number should use. closes https://github.com/opnsense/core/issues/10394

(cherry picked from commit b243971aed52c6106881f6142765930e220e1dac)
DeltaFile
+1-0src/opnsense/mvc/app/models/OPNsense/OpenVPN/OpenVPN.xml
+1-01 files

OPNSense/core 3b9b69bsrc/opnsense/www/js opnsense_bootgrid.js

bootgrid: allow column selection exclusions

(cherry picked from commit 3507ecffc4ad7ae30932a189c89d5646d7b0be5e)
DeltaFile
+5-3src/opnsense/www/js/opnsense_bootgrid.js
+5-31 files

OPNSense/core 9c4d4efsrc/opnsense/mvc/app/views/OPNsense/IDS index.volt

Services: Intrusion Detection: Administration - fix regression in https://github.com/opnsense/core/commit/9271d08bf3ff3eedfa069c2d0b6c5c6f428ccfe4, closes https://github.com/opnsense/core/issues/10393

It looks like the action buttons lost their bindings, this commit restores the function, although it removes the batch function which previously splitted the set in parts.
Usually the size of the url shouldn't be that much of an issue.

(cherry picked from commit 932f2747e945ab382cc3d2274d4ae524f25b2369)
DeltaFile
+20-1src/opnsense/mvc/app/views/OPNsense/IDS/index.volt
+20-11 files