OPNSense/core 31d0c9csrc/opnsense/www/js opnsense.js

ui: improve form validation error append (#10333)

Since this iterates over a lot of irrelevant IDs and then mismatches
with the target change this by safeguarding against fields that are
likely not going to work without help_block_<id> and switch target
to a suffix match.

One spot where this matters: under kea v6 subnet add "DNS servers"
entry e.g. "::", click auto collect for check mark, click save. Interface
and subnet validation is red, the DNS server one shown is not.

(cherry picked from commit 546de351d7eed21ae1f0464938ca1743c1d1b865)
DeltaFile
+10-5src/opnsense/www/js/opnsense.js
+10-51 files

OPNSense/plugins c6024d0net/frr/src/opnsense/mvc/app/controllers/OPNsense/Quagga/Api BgpController.php, net/frr/src/opnsense/mvc/app/controllers/OPNsense/Quagga/forms dialogEditBGPNeighbor.xml dialogEditBGPRouteMaps.xml

net/frr: Improve visibility in ModelRelationFields and enable internalModelUseSafeDelete
DeltaFile
+52-49net/frr/src/opnsense/mvc/app/models/OPNsense/Quagga/BGP.xml
+5-5net/frr/src/opnsense/mvc/app/controllers/OPNsense/Quagga/forms/dialogEditBGPNeighbor.xml
+3-6net/frr/src/opnsense/mvc/app/controllers/OPNsense/Quagga/forms/dialogEditBGPRouteMaps.xml
+4-4net/frr/src/opnsense/mvc/app/controllers/OPNsense/Quagga/forms/dialogEditBGPPeergroups.xml
+1-0net/frr/src/opnsense/mvc/app/controllers/OPNsense/Quagga/Api/BgpController.php
+65-645 files

OPNSense/core 7dabdc3src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt nat_rule.volt, src/opnsense/mvc/app/views/OPNsense/Unbound acl.volt dot.volt

ui: use space in apply box for the apply reminder (#10103)

Co-authored-by: Stephan de Wit <stephan.de.wit at deciso.com>

(cherry picked from commit 854238a1fc0bfa6a206543e585af2fc5a555e209)
(cherry picked from commit 2edab3dbff3ee07a1439429b6963a71bf708687e)
(cherry picked from commit 9b2132159336e094e1981342b780c2d49fbff2dd)
(cherry picked from commit 1d404f97f84e4f19bcc44fc59190a591859e2793)
DeltaFile
+12-16src/opnsense/mvc/app/views/layout_partials/base_apply_button.volt
+1-6src/opnsense/mvc/app/views/OPNsense/Unbound/acl.volt
+6-0src/opnsense/www/js/opnsense_ui.js
+3-2src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+2-2src/opnsense/mvc/app/views/OPNsense/Firewall/nat_rule.volt
+3-1src/opnsense/mvc/app/views/OPNsense/Unbound/dot.volt
+27-273 files not shown
+32-299 files

OPNSense/plugins 95a71ednet/isc-dhcp Makefile pkg-descr, net/isc-dhcp/src/opnsense/mvc/app/models/OPNsense/DHCPv4/Menu Menu.php

net/isc-dhcp: sync with master
DeltaFile
+98-0net/isc-dhcp/src/opnsense/mvc/app/models/OPNsense/DHCPv4/Menu/Menu.php
+1-1net/isc-dhcp/Makefile
+1-0net/isc-dhcp/pkg-descr
+100-13 files

OPNSense/plugins 53896e6security/netbird Makefile pkg-descr, security/netbird/src/opnsense/mvc/app/controllers/OPNsense/Netbird/Api AuthenticationController.php

security/netbird: sync with master
DeltaFile
+5-3security/netbird/src/opnsense/mvc/app/controllers/OPNsense/Netbird/Api/AuthenticationController.php
+1-1security/netbird/Makefile
+1-0security/netbird/pkg-descr
+7-43 files

OPNSense/plugins 37562c3security/netbird pkg-descr

security/netbird: annotate hotfix
DeltaFile
+1-0security/netbird/pkg-descr
+1-01 files

OPNSense/plugins e2e4ecc. README.md, net/ndproxy Makefile

net/ndproxy: set EoL

(cherry picked from commit b495e6b00155539e9527e5b66be1975c23569526)
DeltaFile
+2-1net/ndproxy/Makefile
+1-1README.md
+3-22 files

OPNSense/plugins 212536csecurity/strongswan-legacy Makefile, security/strongswan-legacy/src/www vpn_ipsec_phase1.php

security/strongswan-legacy: sync with master
DeltaFile
+2-2security/strongswan-legacy/src/www/vpn_ipsec_phase1.php
+1-0security/strongswan-legacy/Makefile
+3-22 files

OPNSense/plugins 191dff0security/strongswan-legacy Makefile

security/strongswan-legacy: bump revision
DeltaFile
+1-0security/strongswan-legacy/Makefile
+1-01 files

OPNSense/plugins 37691f3security/tinc Makefile, security/tinc/src/opnsense/service/templates/OPNsense/Tinc tinc_deploy.xml

security/tinc: sync with master
DeltaFile
+1-1security/tinc/src/opnsense/service/templates/OPNsense/Tinc/tinc_deploy.xml
+1-0security/tinc/Makefile
+2-12 files

OPNSense/plugins 6d3cc0bsecurity/tinc Makefile

security/tinc: bump revision after fix
DeltaFile
+1-0security/tinc/Makefile
+1-01 files

OPNSense/core 2185cc0src/opnsense/mvc/app/models/OPNsense/Base/Menu MenuSystem.php MenuItem.php, src/opnsense/mvc/app/models/OPNsense/Firewall/Menu Menu.php

MVC: add support for pluggable dynamic menu items and move some existing parts out of the MenuSystem class (#10113)

(cherry picked from commit 8b13deac0e98733b850420e036e7d2eed9ac8184)
(cherry picked from commit dfdadb627430f4377b62ac14befa3208fdba2c7f)
(cherry picked from commit 4a94e60a42ff99c60dacb57b88ffbe298fa4fa4e)
(cherry picked from commit 5452c5bc90e09bce03cad692e89dd2983bdcfe2a)
(cherry picked from commit 1216d603f9ce823d6a19088397a5e866744adfef)
(cherry picked from commit 7cfb03be5d7ff77b3692a3ba4c7d532828b7f414)
DeltaFile
+48-203src/opnsense/mvc/app/models/OPNsense/Base/Menu/MenuSystem.php
+128-0src/opnsense/mvc/app/models/OPNsense/Interfaces/Menu/Menu.php
+84-0src/opnsense/mvc/app/models/OPNsense/Firewall/Menu/Menu.php
+61-4src/opnsense/mvc/app/models/OPNsense/Base/Menu/MenuItem.php
+63-0src/opnsense/www/js/opnsense_menusystem.js
+49-0src/opnsense/mvc/app/models/OPNsense/Base/Menu/MenuContainer.php
+433-2074 files not shown
+455-22310 files

OPNSense/plugins 6a8edb9dns/rfc2136 pkg-descr Makefile, dns/rfc2136/src/etc/inc/plugins.inc.d rfc2136.inc

dns/rfc2136: allow "*." prefix in hostname for wildcard updates (#5460)

When using rfc2136 dynamic DNS, users may want the same address
record to apply to every subdomain of the configured hostname (e.g.
for host.example.org and *.host.example.org to resolve to the same IP).
DeltaFile
+7-3dns/rfc2136/src/www/services_rfc2136_edit.php
+4-1dns/rfc2136/src/etc/inc/plugins.inc.d/rfc2136.inc
+4-0dns/rfc2136/pkg-descr
+1-2dns/rfc2136/Makefile
+16-64 files

OPNSense/plugins 13ed9a2dns/rfc2136 pkg-descr

dns/rfc2136: add missing changelog
DeltaFile
+6-0dns/rfc2136/pkg-descr
+6-01 files

OPNSense/core 3f78821src/opnsense/mvc/app/models/OPNsense/Dnsmasq Dnsmasq.xml

dnsmasq: fix option values
DeltaFile
+12-12src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.xml
+12-121 files

OPNSense/core 5629b00src/opnsense/mvc/app/models/OPNsense/Monit Monit.xml

monit: remove duplication from these strange test types

tests.xml doesn't list the field so none of this is ever shown
and most could probably be removed, but I have no idea how this
is supposed to work.  The default type is pinned to Custom.
DeltaFile
+20-19src/opnsense/mvc/app/models/OPNsense/Monit/Monit.xml
+20-191 files

OPNSense/core 672ebf5src/opnsense/mvc/app/models/OPNsense/Trust General.xml

system: simplify option values in trust
DeltaFile
+15-15src/opnsense/mvc/app/models/OPNsense/Trust/General.xml
+15-151 files

OPNSense/core 336ac4esrc/opnsense/mvc/app/models/OPNsense/IDS IDS.xml

intrusion detection: clean up option values
DeltaFile
+16-16src/opnsense/mvc/app/models/OPNsense/IDS/IDS.xml
+16-161 files

OPNSense/core a9dee3dsrc/opnsense/mvc/app/models/OPNsense/OpenVPN OpenVPN.xml

openvpn: clean up these option values

Push flags not always mention "push" in label but their
context is clear and keys do not change so simplify.
DeltaFile
+32-32src/opnsense/mvc/app/models/OPNsense/OpenVPN/OpenVPN.xml
+32-321 files

OPNSense/core 72403e4src/opnsense/mvc/app/models/OPNsense/Interfaces Vlan.xml

interfaces: simplify VLAN type selection

Although 802.1Q is correct we don't need the translation
and can make all of it a bit shorter.
DeltaFile
+3-3src/opnsense/mvc/app/models/OPNsense/Interfaces/Vlan.xml
+3-31 files

OPNSense/plugins d3c3e79net/frr/src/opnsense/mvc/app/controllers/OPNsense/Quagga/forms dialogEditOSPF6Network.xml dialogEditOSPFNetwork.xml, net/frr/src/opnsense/mvc/app/models/OPNsense/Quagga OSPF6.xml OSPF.xml

net/frr: OSPF/OSPF6 More visibility and safety for ModelRelationField references (#5459)

* Allow multiple prefix list selections in a route map in OSPF6 as well

* Improve visibility for route-maps and prefix-lists in OSPF/OSPF6 and enable internalModelUseSafeDelete
DeltaFile
+17-15net/frr/src/opnsense/mvc/app/models/OPNsense/Quagga/OSPF6.xml
+12-12net/frr/src/opnsense/mvc/app/models/OPNsense/Quagga/OSPF.xml
+7-3net/frr/src/opnsense/service/templates/OPNsense/Quagga/ospf6d.conf
+2-2net/frr/src/opnsense/mvc/app/controllers/OPNsense/Quagga/forms/dialogEditOSPF6Network.xml
+2-2net/frr/src/opnsense/mvc/app/controllers/OPNsense/Quagga/forms/dialogEditOSPFNetwork.xml
+1-2net/frr/src/opnsense/mvc/app/controllers/OPNsense/Quagga/forms/dialogEditOSPF6RouteMaps.xml
+41-364 files not shown
+45-3810 files

OPNSense/plugins 23cca9cnet/frr/src/opnsense/mvc/app/controllers/OPNsense/Quagga/forms dialogEditOSPF6Network.xml dialogEditOSPFNetwork.xml, net/frr/src/opnsense/mvc/app/models/OPNsense/Quagga OSPF.xml OSPF6.xml

Improve visibility for route-maps and prefix-lists in OSPF/OSPF6 and enable internalModelUseSafeDelete
DeltaFile
+12-12net/frr/src/opnsense/mvc/app/models/OPNsense/Quagga/OSPF.xml
+12-12net/frr/src/opnsense/mvc/app/models/OPNsense/Quagga/OSPF6.xml
+2-2net/frr/src/opnsense/mvc/app/controllers/OPNsense/Quagga/forms/dialogEditOSPF6Network.xml
+2-2net/frr/src/opnsense/mvc/app/controllers/OPNsense/Quagga/forms/dialogEditOSPFNetwork.xml
+1-1net/frr/src/opnsense/mvc/app/controllers/OPNsense/Quagga/forms/dialogEditOSPF6RouteMaps.xml
+1-1net/frr/src/opnsense/mvc/app/controllers/OPNsense/Quagga/forms/dialogEditOSPFRouteMaps.xml
+30-303 files not shown
+33-319 files

OPNSense/core ac55f10src/opnsense/mvc/app/models/OPNsense/Unbound Unbound.xml

unbound: trim option values

This works since https://github.com/opnsense/core/commit/b187227683de93cb705d6290090aaa708354edf1
DeltaFile
+11-11src/opnsense/mvc/app/models/OPNsense/Unbound/Unbound.xml
+11-111 files

OPNSense/core 7484d4bsrc/opnsense/mvc/app/models/OPNsense/TrafficShaper TrafficShaper.xml

firewall: this works and I don't get it
DeltaFile
+1-1src/opnsense/mvc/app/models/OPNsense/TrafficShaper/TrafficShaper.xml
+1-11 files

OPNSense/core 251559esrc/opnsense/mvc/app/models/OPNsense/Firewall Filter.xml, src/opnsense/mvc/app/models/OPNsense/Interfaces Lagg.xml

src: expand lint and fix a few easy ones
DeltaFile
+16-16src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
+13-13src/opnsense/mvc/app/models/OPNsense/TrafficShaper/TrafficShaper.xml
+6-6src/opnsense/mvc/app/models/OPNsense/Trust/General.xml
+6-6src/opnsense/mvc/app/models/OPNsense/Interfaces/Lagg.xml
+5-5src/opnsense/mvc/app/models/OPNsense/Syslog/Syslog.xml
+4-4src/opnsense/mvc/app/models/OPNsense/Monit/Monit.xml
+50-504 files not shown
+58-5810 files

OPNSense/core 2769ae5src/opnsense/mvc/app/views/OPNsense/Diagnostics netflow.volt

trim this as well
DeltaFile
+1-1src/opnsense/mvc/app/views/OPNsense/Diagnostics/netflow.volt
+1-11 files

OPNSense/core e05881csrc/opnsense/mvc/app/controllers/OPNsense/Unbound/forms dnsreporting.xml

trim this
DeltaFile
+1-3src/opnsense/mvc/app/controllers/OPNsense/Unbound/forms/dnsreporting.xml
+1-31 files

OPNSense/core 87784f0src/opnsense/mvc/app/views/OPNsense/Unbound overview.volt

leftover here
DeltaFile
+0-1src/opnsense/mvc/app/views/OPNsense/Unbound/overview.volt
+0-11 files

OPNSense/core 37ff114src/opnsense/mvc/app/models/OPNsense/Diagnostics/Migrations M1_0_0.php

safeguard post as well
DeltaFile
+4-0src/opnsense/mvc/app/models/OPNsense/Diagnostics/Migrations/M1_0_0.php
+4-01 files

OPNSense/core 73df876src/opnsense/mvc/app/controllers/OPNsense/Kea/forms generalSettings4.xml, src/opnsense/mvc/app/models/OPNsense/Kea KeaDhcpv4.xml KeaDhcpv4.php

Services: Kea DHCPv4: Add DHCP4 compatibility options (#10336)

Refs: https://kea.readthedocs.io/en/stable/arm/dhcp4-srv.html#dhcp4-compatibility"

Co-authored-by: Franco Fichtner <franco at lastsummer.de>
Co-authored-by: Monviech <79600909+Monviech at users.noreply.github.com>
DeltaFile
+10-0src/opnsense/mvc/app/controllers/OPNsense/Kea/forms/generalSettings4.xml
+9-0src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.xml
+4-0src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php
+23-03 files