OPNSense/src b4ddb3eusr.sbin/bsdinstall/scripts bootconfig

bsdinstall: fix EFI boot entry creation

update_uefi_bootentry assumes that the caller sets FREEBSD_BOOTNAME and
mntpt, which isn't the case anymore. The result is that there is no
"FreeBSD" boot entry created/updated after install. Most machines manage
to boot from the removable media path (if the loader is installed there
too), but some don't.

Take the loader's path as an argument and rename the variable used in
the ZFS mirror loop so mntpt can be reused below.

Also mark nentries as a local variable so it doesn't leak out of the
function.

PR:             293385
Fixes:          494de51bc0074472d1b01604f085daea0844f240
MFC after:      2 days
Reviewed by:    imp
Differential Revision:  https://reviews.freebsd.org/D55469

    [2 lines not shown]
DeltaFile
+14-11usr.sbin/bsdinstall/scripts/bootconfig
+14-111 files

OPNSense/plugins 155aa2ewww/caddy pkg-descr Makefile

www/caddy: Add changelog and bump plugin version to v2.1.0 (#5270)

DeltaFile
+28-17www/caddy/pkg-descr
+1-2www/caddy/Makefile
+29-192 files

OPNSense/plugins bac0289databases/redis pkg-descr Makefile, databases/redis/src/opnsense/mvc/app/views/OPNsense/Redis index.volt

databases/redis: sync with master
DeltaFile
+4-7databases/redis/src/opnsense/mvc/app/views/OPNsense/Redis/index.volt
+1-3databases/redis/pkg-descr
+1-1databases/redis/Makefile
+6-113 files

OPNSense/plugins 1e2acfddatabases/redis pkg-descr Makefile

databases/redis: bump for latest change
DeltaFile
+1-3databases/redis/pkg-descr
+1-1databases/redis/Makefile
+2-42 files

OPNSense/plugins d150698.github pull_request_template.md

Contributing: Add plugin pull-request template (#5269)

(cherry picked from commit 4f7655a0ae15097915de070d6a6d275f46153060)
DeltaFile
+28-0.github/pull_request_template.md
+28-01 files

OPNSense/plugins 4f7655a.github pull_request_template.md

Contributing: Add plugin pull-request template (#5269)

DeltaFile
+28-0.github/pull_request_template.md
+28-01 files

OPNSense/plugins 67dfd23security/openvpn-legacy Makefile, security/openvpn-legacy/src/www vpn_openvpn_server.php

security/openvpn-legacy: sync with master
DeltaFile
+1-1security/openvpn-legacy/src/www/vpn_openvpn_server.php
+1-0security/openvpn-legacy/Makefile
+2-12 files

OPNSense/plugins ff0a8e1security/netbird Makefile, security/netbird/src/opnsense/mvc/app/controllers/OPNsense/Netbird/forms settings.xml

security/netbird: sync with master
DeltaFile
+30-0security/netbird/src/opnsense/mvc/app/controllers/OPNsense/Netbird/forms/settings.xml
+21-1security/netbird/src/opnsense/mvc/app/models/OPNsense/Netbird/Settings.xml
+5-0security/netbird/src/opnsense/mvc/app/models/OPNsense/Netbird/Settings.php
+1-1security/netbird/Makefile
+57-24 files

OPNSense/plugins 1d92df1security/acme-client pkg-descr, security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/forms dialogAction.xml

security/acme-client: sync with master
DeltaFile
+108-294security/acme-client/src/opnsense/mvc/app/views/OPNsense/AcmeClient/certificates.volt
+30-216security/acme-client/src/opnsense/mvc/app/views/OPNsense/AcmeClient/accounts.volt
+18-18security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/forms/dialogAction.xml
+0-25security/acme-client/src/opnsense/mvc/app/views/OPNsense/AcmeClient/logs.volt
+7-0security/acme-client/pkg-descr
+1-1security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeValidation/DnsGoogledomains.php
+164-5541 files not shown
+165-5557 files

OPNSense/plugins dc93f8d.github pull_request_template.md

Update .github/pull_request_template.md

Co-authored-by: Franco Fichtner <franco at opnsense.org>
DeltaFile
+1-5.github/pull_request_template.md
+1-51 files

OPNSense/plugins d003610net/haproxy/src/opnsense/mvc/app/views/OPNsense/HAProxy maintenance.volt index.volt, net/haproxy/src/opnsense/scripts/OPNsense/HAProxy exportMapFiles.php

net/haproxy: sync with master
DeltaFile
+104-147net/haproxy/src/opnsense/mvc/app/views/OPNsense/HAProxy/maintenance.volt
+56-105net/haproxy/src/opnsense/mvc/app/views/OPNsense/HAProxy/index.volt
+69-89net/haproxy/src/opnsense/mvc/app/views/OPNsense/HAProxy/statistics.volt
+66-11net/haproxy/src/opnsense/service/templates/OPNsense/HAProxy/haproxy.conf
+27-31net/haproxy/src/opnsense/mvc/app/views/OPNsense/HAProxy/export.volt
+49-5net/haproxy/src/opnsense/scripts/OPNsense/HAProxy/exportMapFiles.php
+371-3884 files not shown
+400-39310 files

OPNSense/plugins ce48b31. CONTRIBUTING.md

Update contributing with a small section about new plugins (#5231)

(cherry picked from commit a6acffd7fe2038492aa55ecadce2168a09f0f0b6)
DeltaFile
+13-0CONTRIBUTING.md
+13-01 files

OPNSense/plugins 189ea53security/q-feeds-connector pkg-descr, security/q-feeds-connector/src/opnsense/mvc/app/controllers/OPNsense/QFeeds/forms settings.xml

security/q-feeds-connector: sync with master
DeltaFile
+44-6security/q-feeds-connector/src/opnsense/scripts/unbound/blocklists/qfeeds_bl.py
+39-1security/q-feeds-connector/src/opnsense/mvc/app/controllers/OPNsense/QFeeds/forms/settings.xml
+16-0security/q-feeds-connector/src/opnsense/mvc/app/models/OPNsense/QFeeds/Connector.xml
+7-0security/q-feeds-connector/pkg-descr
+7-0security/q-feeds-connector/src/opnsense/mvc/app/views/OPNsense/QFeeds/index.volt
+7-0security/q-feeds-connector/src/opnsense/service/templates/OPNsense/QFeeds/qfeeds-blocklists.conf
+120-71 files not shown
+121-97 files

OPNSense/plugins 542c5e8security/q-feeds-connector pkg-descr

security/q-feeds-connector: style
DeltaFile
+0-1security/q-feeds-connector/pkg-descr
+0-11 files

OPNSense/plugins 3987affsecurity/tailscale pkg-descr Makefile, security/tailscale/src/opnsense/mvc/app/controllers/OPNsense/Tailscale/forms authentication.xml

security/tailscale: sync with master
DeltaFile
+1-4security/tailscale/src/opnsense/mvc/app/models/OPNsense/Tailscale/Authentication.xml
+4-0security/tailscale/pkg-descr
+2-1security/tailscale/src/opnsense/mvc/app/controllers/OPNsense/Tailscale/forms/authentication.xml
+1-1security/tailscale/Makefile
+8-64 files

OPNSense/plugins b79a473net/isc-dhcp Makefile, net/isc-dhcp/src/etc/inc/plugins.inc.d dhcpd.inc

net/isc-dhcp: sync with master
DeltaFile
+58-0net/isc-dhcp/src/opnsense/mvc/app/models/OPNsense/Interfaces/Neighbor/dhcpd.php
+18-0net/isc-dhcp/src/etc/inc/plugins.inc.d/dhcpd.inc
+1-1net/isc-dhcp/src/www/services_dhcp_edit.php
+1-1net/isc-dhcp/Makefile
+1-1net/isc-dhcp/src/www/services_dhcp.php
+79-35 files

OPNSense/plugins e6ed910www/caddy/src/opnsense/mvc/app/controllers/OPNsense/Caddy/Api ServiceController.php

www/caddy: style
DeltaFile
+0-1www/caddy/src/opnsense/mvc/app/controllers/OPNsense/Caddy/Api/ServiceController.php
+0-11 files

OPNSense/plugins c50bf65.github pull_request_template.md

Contributing: Add plugin pull-request template
DeltaFile
+32-0.github/pull_request_template.md
+32-01 files

OPNSense/core 8cc3418src/opnsense/scripts/shell restore.sh

shell: make a note here otherwise done
DeltaFile
+2-0src/opnsense/scripts/shell/restore.sh
+2-01 files

OPNSense/plugins daff8c4www/caddy/src/opnsense/scripts/OPNsense/Caddy caddy_certs.php

www/caddy: Use BaseField cast helpers in certificate extraction script (#5268)

DeltaFile
+27-38www/caddy/src/opnsense/scripts/OPNsense/Caddy/caddy_certs.php
+27-381 files

OPNSense/core c847661. plist, src/opnsense/mvc/app/models/OPNsense/Interfaces/Neighbor dhcpd.php README

interfaces: move dhcpd neighbor entry feed to plugin

(cherry picked from commit adf02f8359b902594da4eb56c1b8c84d5bb51a85)
DeltaFile
+0-58src/opnsense/mvc/app/models/OPNsense/Interfaces/Neighbor/dhcpd.php
+1-1plist
+1-0src/opnsense/mvc/app/models/OPNsense/Interfaces/Neighbor/README
+2-593 files

OPNSense/core adf02f8. plist, src/opnsense/mvc/app/models/OPNsense/Interfaces/Neighbor dhcpd.php README

interfaces: move dhcpd neighbor entry feed to plugin
DeltaFile
+0-58src/opnsense/mvc/app/models/OPNsense/Interfaces/Neighbor/dhcpd.php
+1-1plist
+1-0src/opnsense/mvc/app/models/OPNsense/Interfaces/Neighbor/README
+2-593 files

OPNSense/plugins f9fb06enet/isc-dhcp/src/opnsense/mvc/app/models/OPNsense/Interfaces/Neighbor dhcpd.php

net/isc-dhcp: add pluggable neighbor file here
DeltaFile
+58-0net/isc-dhcp/src/opnsense/mvc/app/models/OPNsense/Interfaces/Neighbor/dhcpd.php
+58-01 files

OPNSense/core 9f8cb9dsrc/opnsense/mvc/app/controllers/OPNsense/Base ApiMutableModelControllerBase.php

mvc: sweep

(cherry picked from commit 6bd41d3e18263629d414fc542439a3d1c8f354f6)
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableModelControllerBase.php
+1-11 files

OPNSense/core 5f2ba48src/etc/inc filter.lib.inc, src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterController.php DNatController.php

Firewall: Rules [new] - default ipprotocol mismatch, when not specified, both are indicated

PR: https://github.com/opnsense/core/issues/9858

(cherry picked from commit d348a53d03f54b3b1429b7b61daf1b67adf3486d)
(cherry picked from commit ab7e80abe1cd4b6d4b4822a09606530f9df27766)
(cherry picked from commit 0c3a937cccc478285f2360ad9526bd29abc9be5e)
(cherry picked from commit c7a8884a2a97034e625edcf3dd90ee76bba99d28)
DeltaFile
+4-4src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+1-2src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/DNatController.php
+3-0src/etc/inc/filter.lib.inc
+1-1src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+1-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
+0-1src/opnsense/scripts/filter/list_non_mvc_rules.php
+10-86 files

OPNSense/core a36b6f1src/opnsense/mvc/app/views/OPNsense/Diagnostics log.volt, src/opnsense/www/js opnsense_bootgrid.js

log files: fix 'go to page' edge case and row count persistence/max

The log controller defines 5000 rows as the limit to prevent OOM
issues, however, since the front-end knows nothing about this,
setting the row count to "all" will only show the first
5000 result without a way to paginate, even if there are more
log entries. Logically, if the controller defines 5000 as a limit,
the view shouldn't allow "all" as a selection, so override it here.

Furthermore, row count "all" was a boolean, which broke the "go to page"
button. While "all" isn't allowed anymore now, we should check
if the value is a boolean regardless. Also, the grid wasn't
indexing on "rnum" properly, so the grid had no idea where to scroll
to once clicked.

(cherry picked from commit 13f45bca921f66b3ecba731b701a8f63e99ddd0e)
DeltaFile
+6-2src/opnsense/mvc/app/views/OPNsense/Diagnostics/log.volt
+2-1src/opnsense/www/js/opnsense_bootgrid.js
+8-32 files

OPNSense/core a9cf88fsrc/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt, src/www firewall_rule_lookup.php

Firewall: Rules [new]: Reduce complexity in url hash handling and when using firewall_rule_lookup (#9773)

* Reduce complexity of firewall_rule_lookup, we have an all rules entrypoint now, so potentially we could just search for the UUID of the rule without concerning us with interfaces anymore

* Clean up URL hash logic, we only allow #search and #interface now and need no special handling

* Only get the hash once, use it everywhere, re-add missing null fallback and initialized interface variable

* The hash was consumed too early now, fix it by shifting to the new spot where the variable is used last

(cherry picked from commit d976ae7b6b0f06c235d22de087e4904c28b1286c)
DeltaFile
+7-17src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+1-12src/www/firewall_rule_lookup.php
+8-292 files

OPNSense/core 903c250. plist, src/opnsense/mvc/app/controllers/OPNsense/Base ApiMutableModelControllerBase.php

mvc: collect uuid field so it can be searched, but only if the searchPhrase contains a valid UUID (#9780)

(cherry picked from commit 7738d7e865025022035025c8b65578a57c94feab)
(cherry picked from commit 6ae73e8406b83c92630a184884707a0b92c949b3)
DeltaFile
+58-0src/opnsense/mvc/app/library/OPNsense/Core/Type.php
+17-9src/opnsense/mvc/app/library/OPNsense/Base/UIModelGrid.php
+11-14src/opnsense/mvc/app/controllers/OPNsense/Base/ApiMutableModelControllerBase.php
+3-2src/opnsense/mvc/app/controllers/OPNsense/Routing/Api/SettingsController.php
+1-0plist
+90-255 files

OPNSense/core 83c82d5src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

Firewall: Rules [new]: Move download and upload commands out of partial into global commands (#9781)

(cherry picked from commit d5a50a98c21eb592348cfb293986f3f0c06906aa)
DeltaFile
+27-23src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+27-231 files

OPNSense/core 23440edsrc/opnsense/mvc/app/views/OPNsense/Diagnostics fw_log.volt, src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt dnat_rule.volt

Firewall: Rules [new]: Add a command button to open the live log with prefilled rule ID (#9770)

fw_log.volt:
Uses a url hash inside fw_log.volt to set a filter when opening it through a link from filter_rule.volt
The url hash can set any type of a single filter, so it can be reused in other pages as well.
Combine entry point of addCombinedFilter and addFilter, decide via array in field what type it is.
Change init entrypoint to always go through the filterChange() pipeline, but have a fast path in there that initializes without a filter. This adds the filter immediately when loading with the page with the URL hash
Make sure we want for tableBuilt to prevent replaceData errors

filter_rule.volt
Only show the log search button when row.log is 1 or true
Change fa icon in the lookup rule reference button in dnat as well for consistency
Use URLSearchParams()

---------

Co-authored-by: Stephan de Wit <stephan.de.wit at deciso.com>
(cherry picked from commit 63e0b92278ad4c5e4b0db9746599903089bf14dd)
DeltaFile
+30-24src/opnsense/mvc/app/views/OPNsense/Diagnostics/fw_log.volt
+36-17src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+3-3src/opnsense/mvc/app/views/OPNsense/Firewall/dnat_rule.volt
+69-443 files