qlnxe: Report speeds in decimal format
It is more natural to read the speed in decimal format than hexadecimal
one.
Spotted this while diagnosing PR 287445,
```
[__ecore_configure_pf_max_bandwidth:6864(qlnx-0)]Configured MAX bandwidth to be 000061a8 Mb/sec
[__ecore_configure_pf_min_bandwidth:6922(qlnx-0)]Configured MIN bandwidth to be 750 Mb/sec
```
Reviewed by: kbowling
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D52376
qlnxe: Unconditionally enable extended media types
Those extended media types are available since about 2015 [1]. All
supported branches already have them defined.
No functional change intended.
[1] eb7e25b22f1c ifmedia changes: Extend the number of available subtypes for Ethernet media ...
Reviewed by: kbowling
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D52374
qlnxe: Support SIOCGIFXMEDIA ioctl
ifconfig(8) will try SIOCGIFXMEDIA first and then retry SIOCGIFMEDIA if
that fails. Since the driver reports extended media types, support
SIOCGIFXMEDIA ioctl directly rather than doing another round.
Reviewed by: kbowling
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D52375
bsdinstall: Drop outdated comments about ZFS dataset compression
All datasets on zroot pool are compressed by default since FreeBSD 11.0 [1],
no need to mention that on some specific datasets these days.
[1] 47206692f2cca020891d1eec5028e02c3e6f56c5
Reviewed by: jrm (mentor), ziaee
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D52304
vm_domainset: Refactor iterators, multiple fixes
vm_domainset_iter_first() would not check if the initial domain selected
by the policy was effectively valid (i.e., allowed by the domainset and
not marked as ignored by vm_domainset_iter_ignore()). It would just try
to skip it if it had less pages than 'free_min', and would not take into
account the possibility of no domains being valid.
Factor out code that logically belongs to the iterator machinery and is
not tied to how allocations (or impossibility thereof) are to be
handled. This allows to remove duplicated code between
vm_domainset_iter_page() and vm_domainset_iter_policy(), and between
vm_domainset_iter_page_init() and _vm_domainset_iter_policy_init().
This also allows to remove the 'pages' parameter from
vm_domainset_iter_page_init().
This also makes the two-phase logic clearer, revealing an inconsistency
between setting 'di_minskip' to true in vm_domainset_iter_init()
(implying that, in the case of waiting allocations, further attempts
[24 lines not shown]
vm_domainset: Simplify vm_domainset_iter_next()
As we are now visiting each domain only once, the test in
vm_domainset_iter_prefer() about skipping the preferred domain (the one
initially visited for policy DOMAINSET_POLICY_PREFER) becomes redundant.
Removing it makes this function essentially the same as
vm_domainset_iter_rr().
Thus, remove vm_domainset_iter_prefer(). This makes all policies behave
the same in vm_domainset_iter_next().
No functional change (intended).
PR: 277476
MFC after: 10 days
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D51250
vm_domainset: Only probe domains once when iterating, instead of up to 4 times
Because of the 'di_minskip' logic, which resets the initial domain, an
iterator starts by considering only domains that have more than
'free_min' pages in a first phase, and then all domains in a second one.
Non-"underpaged" domains are thus examined twice, even if the allocation
can't succeed.
Re-scanning the same domains twice just wastes time, as allocation
attempts that must not wait may rely on failing sooner and those that
must will loop anyway (a domain previously scanned twice has more pages
than 'free_min' and consequently vm_wait_doms() will just return
immediately).
Additionally, the DOMAINSET_POLICY_FIRSTTOUCH policy would aggravate
this situation by reexamining the current domain again at the end of
each phase. In the case of a single domain, this means doubling again
the number of times domain 0 is probed.
[16 lines not shown]
geom: only set TDP_GEOM for user threads
For kernel threads, ASTs are not handled at all, so there is no reason
to expect that g_waitidle() would be called through AST scheduling.
PR: 289204
Reviewed by: markj
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D52421
iommu_get_requester(): make it more resilient against arbitrary dev arg
If passed the parent of a device instead of the device, the loop might
end up with the host bridge in the pci local variable. If the passed
device is not from the pci hierarchy, any of the calculated parents
might be NULL.
Change the interface to allow the caller to receive error.
Instead of asserting, just issue a message and return ENXIO,
allowing the caller to select appropriate action.
PR: 289318
Reviewed by: jah
Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks
Differential revision: https://reviews.freebsd.org/D52406
net80211: add support for drivers to disable sending NULL data frames
net80211 has various places where null data / null qos data frames
are sent. However plenty of NICs shouldn't be sending them from
net80211 and it may even upset their 802.11n window / sequence number
tracking.
So add support here.
Differential Revision: https://reviews.freebsd.org/D52297
Reviewed by: bz
rsu: implement A-MPDU TX; add TODO items for further work
* Enable A-MPDU TX by fixing the A-MPDU TX establish routine;
always assign sequence numbers from net80211 (for now); and
fix the descriptor programming.
* Add TODO items around CAM allocation for keys, MAC ID stuff which
we likely need to fix for working IBSS/AP behaviour, and whatever
other bits and pieces I noticed.
* Disable amsdu2ampdu, we can decap A-MSDU just fine in net80211,
doubly so if we somehow get A-MSDU inside an A-MPDU.
I've tested / verified that A-MPDU TX and A-MPDU RX is correctly
established and functioning by using rtwn in monitor mode.
I used an old r92su linux out of tree driver for comparison.
Differential Revision: https://reviews.freebsd.org/D50748
Okayed by: bz
rsu: enable seqno offload
Enable sequence number offload.
This should both enable the sequence number offloading and disable
the net80211 TX lock from being acquired/released/checked.
Differential Revision: https://reviews.freebsd.org/D50749
Okayed by: bz
run: enable seqno offload
Enable sequence number offload.
This should both enable the sequence number offloading and disable
the net80211 TX lock from being acquired/released/checked.
Differential Revision: https://reviews.freebsd.org/D50747
Okayed by: bz
exports.5: Add a paragraph clarifying the use of "V4:"
The exports.5 man page is a bit of a monster.
One place of common confusion is the use of
the "V4:" line(s) for defining the location of the
root of the NFSv4 export subtree.
This patch adds a paragraph in an attempt to
clarify this.
This is a content change.
(cherry picked from commit 200730f29dbc8da2aa9392b35518bf77b8899f89)
exports.5: Add a paragraph clarifying the use of "V4:"
The exports.5 man page is a bit of a monster.
One place of common confusion is the use of
the "V4:" line(s) for defining the location of the
root of the NFSv4 export subtree.
This patch adds a paragraph in an attempt to
clarify this.
This is a content change.
(cherry picked from commit 200730f29dbc8da2aa9392b35518bf77b8899f89)
tcp: micro-optimize SYN-cookie expansion
Only compute wscale when it is actually used. While there, change the
type of wscale to u_int as suggested by glebius.
No functional change intended.
Reviewed by: glebius, rscheff (older version)
Sponsored by: Netflix, Inc.
Differential Revision: https://reviews.freebsd.org/D52296
(cherry picked from commit 341d1aabc13e47911d2eb38e857b90f7d356134e)
nvme: Linux compat: don't filter & 0x3.
Strictly speaking, opc & 0x3 == 3 is input and output at the same
time. This is undefined, in general. But for vendor commands, it's
vendor specific. Linux allows it generally and treats it as a read,
which is what we do too, so remove this check to be more compatible with
Linux's behavior (which we're trying to emulate).
Sponsored by: Netflix
src.opts.mk: Remove REPRODUCIBLE_BUILD from the default list
It was added to the list in bsd.opts.mk in commit 4f81c42fbd76, so
should have been removed here.
On stable/15, this also fixes a problem in commit
6e7cc49f94cf ("Make stable/15 a stable branch"), which made
REPRODUCIBLE_BUILD a default-yes option. It modified src.opts.mk
instead of bsd.opts.mk. This change modifies the latter accordingly.
Reported by: cperciva
Approved by: re (cperciva)
Fixes: 4f81c42fbd76 ("share/mk: Substitute reproducible prefixes in dwarf info")
MFC after: 3 days
Sponsored by: The FreeBSD Foundation
Sponsored by: Klara, Inc.
(cherry picked from commit b2f5dc591ef2547ee2e9b68e58a263cd34948db1)
vtnet: improve checksum offloading
When transmitting a packet over the vtnet interface, map the
csum flags CSUM_DATA_VALID | CSUM_PSEUDO_HDR to the virtio
flag VIRTIO_NET_HDR_F_DATA_VALID.
When receiving a packet over the virtio network channel, translate
the virtio flag VIRTIO_NET_HDR_F_NEEDS_CSUM not to CSUM_DATA_VALID |
CSUM_PSEUDO_HDR, but to CSUM_TCP, CSUM_TCP_IPV6, CSUM_UDP, or
CSUM_UDP_IPV6.
The second change fixes a series of issue related to checksum
offloading for if_vtnet.
While there, improve the stats counters to allow a detailed view
on what is going on in relation to checksum offloading.
PR: 165059
Reviewed by: tuexen, manpages
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D51686
src.opts.mk: Remove REPRODUCIBLE_BUILD from the default list
It was added to the list in bsd.opts.mk in commit 4f81c42fbd76, so
should have been removed here.
Reported by: cperciva
Fixes: 4f81c42fbd76 ("share/mk: Substitute reproducible prefixes in dwarf info")
MFC after: 3 days
Sponsored by: The FreeBSD Foundation
Sponsored by: Klara, Inc.
random: Allow pure entropy sources to provide a min-entropy estimate
The current implementation of the NIST health tests assumes a
min-entropy estimate of one bit per sample, which is quite conservative.
For so-called "pure" sources (e.g., virtio-random, TPM) it might be nice
to support larger estimates so that the tests catch failed devices more
quickly.
Thus:
- let each pure random source provide an estimate, so that downstreams
or driver implementors can override defaults if they want to;
- increase the default estimate for pure sources;
- for pure sources initialize the state machine at source registration
time.
Reviewed by: cem
MFC after: 2 weeks
Sponsored by: Stormshield
Sponsored by: Klara, Inc.
Differential Revision: https://reviews.freebsd.org/D52232
