pkgbase: Fix building packages
When updating a jail we first make buildworld/buildkernel and then
we make update-packages.
Since the src.conf/make.conf is now clean after building, if a user have
some custom option in them make update-packages will not know this and will
try to build packages with some non-existant files.
Fixes: 256f4f17a120 ("jail -cu: Don't include build-time make.conf files into jail's clean snapshot")
(cherry picked from commit 50f21876f11ef7703494d3083715653b7df90fbd)
Conflicts:
src/share/poudriere/jail.sh
Issue #1317
write_atomic: Add a C implementation.
This allows SH=/bin/sh to combine several fork+exec into 1, and cuts
down the test suite time to 1/3rd the time.
mktemp(3) implementation is copied from FreeBSD libc commit 9911028f5.
This is to allow a tempfile created respecting umask, without requiring
excess syscalls to fix the mode.
It replaces these exec patterns:
- mktemp
- chmod
- cmp
- ln or rename
- unlink
This utility is only meant for regular files. It does a rename(2) over
the destination file so special files don't make sense.
logclean: Fix empty build log directory removal with multiple jails
When multiple jails are configured, the "Removing empty build log
directories" step fails because the script incorrectly processes the
space-separated MASTERNAMES_LOCKED list.
The issue is that sed appends "/latest-per-pkg" to the end of the
entire space-separated string rather than to each jail name individually.
This results in a malformed path like:
"neptune-amd64-default odin-amd64-default saturn-amd64-default/latest-per-pkg"
Fix by converting spaces to newlines before the sed operation, ensuring
each jail name gets the suffix appended correctly.
Fixes #1157
jail -d: Tweaks; Allow rerunning and multiple -C flags.
- jail -d can now be reran to cleanup any leftover files.
- -C can be specified multiple times.
- Display each dir as it is cleaned up.
- Stop force deleting the cache dir.
- Speedup finding logs by separating out the latest-per-pkg traversal.
- Support cleaning up images.
Issue #694
do_confirm_delete: Cleanup the return statuses.
Make this return either 0 or 1 as normal functions do. This fixes
errors not being detectable.
Add 2 output vars that can communicate what was done.
This also fixes the `pkgclean done` hook to properly pass in whether
files were deleted.
tests: Simplify OVERLAYSDIR handling.
This removes the MASTERMNT symlink hacks that were shadowed and
not cleaned up properly.
The behavior was only that way because MASTERMNTREL is referenced
in _lookup_port_dir(). It can just be blank though and read from
the git checkout.
