BSD Commit Log Search

Revert "testport/bulk -t: Make stage-qa library dependencies check fatal."

This reverts commit 24aa0dda088c08aafd2f317c67dc4c271177157c.

The qa check needs more work. There are at least 2 cases:
1. A library happens to be installed by a dependency, _is needed_,
   and gets linked in without a `LIB_DEPENDS`.
2. A library happens to be installed by a dependency, _is not needed_,
   and is _overlinked_. The qa check suggests to add a `LIB_DEPENDS`
   which is not the right advice.

Update the shlib warnings to note the stage-qa failure is silent.

jail -d: Don't try destroyfs if JAILMNT is not set

Fix some utilities writing to stdout on SIGINFO where stdout is read.

siginfo_handler: Set +u as it may have been set before calling the trap.

Not everything is set -u safe; don't suddenly expose it in unexpected places.

jail -d: Don't try destroyfs if JAILMNT is not set

(cherry picked from commit d5e410697d0802f624e90267cec70c63613e9582)

testport: Fix testing of an IGNORE/BROKEN port.

- Also fixes old bulk bug with empty repo, on an IGNORED port, resulting in an
  error trying to build repo without pkg having been built yet.
- Also fixes old testport bug with -P leftover error of /prefix.
- Also fixes old testport bug of empty repo on BROKEN port not building pkg.
- Add several new tests covering these cases and more.
- testport on an IGNORED port no longer consider it as a "failure"
  for stats.

Fixes:  b95a9ee02 ("testport: Don't spin up a builder if not needed")
Fixes:  bac5acb8f ("build_port: Can fetch NEED_ROOT upfront.")

getpid: Don't build with --static

This isn't needed and breaks WITH_PIE in ports build.

dev_assert: Fix alias for lines ending in \

`nop` is used rather than `:` so that `VAR=x dev_assert` keeps the
variable scope to that line only.

jail -c -m pkgbase: Default URL has changed to pkg.freebsd.org

(cherry picked from commit 7849c70c61b1f302a1eb113aa3b86f21a7ec9e9e)

jail -c -m pkgbase: Default URL has changed to pkg.freebsd.org

bulk/testport logger should be a protected job.

stack_size: Fix eargs error

poudriere / runtest: Allow MALLOC_CONF from environment

_spawn_wrapper: Add comment about async lists

_kill_job: Add debug output for pwait return

sh: Don't assume EINTR means SIGALRM

Taken from FreeBSD https://reviews.freebsd.org/D53761

test jobs.sh SH=/bin/sh: Improve racy test

commit 3085e8acd748dd tweaked this check to deal with Running
or Done, but needs to deal with the %- job being different
as well.

PKG_HASH: Fix pkg cache using wrong timestamp.

This affects build performance only.

testport/bulk -t: Make stage-qa library dependencies check fatal.

This now forces PROXYDEPS_FATAL on for stage-qa when in test mode.
The PKG_NO_VERSION_FOR_DEPS feature depends on packages having proper
dependencies recorded. Pkg likely does too.

sh: Allow vfork in child with mflag set

Traps: avoid forking to carry along exit status to child handlers.

- Also allow signal handlers to modify return status.
- Add more tests.

mapfile/readlines/readlines_file: Deal with reads without EOL newline

tests cleanup: print jobs warning to stderr

bulk: Fix ref jail not being unmounted when detecting a crashed builder

parallel_exec: Simplify; avoid a fork.

Like build_queue_runner() we can avoid needing to mess
with subshells or set -e by using an exit trap to write
back to the job pipe.

jobs_with_statuses: Avoid requiring a pipe to use this

This also avoids creating a giant multi-line string as the result
and instead returns 1 line at a time. This will allow an optimal
builtin.

shash_remove_var: optimize to not need find(1)

Using shash_unset() allows using rm(builtin).

_build_queue_check_jobs: Use more efficient jobs_with_statuses()

tests expect_error_on_stderr: try to allow the child to error.

That is, before if the child threw an error we might never
see stderr. Now we should.

This requires disabling a few assertions that check for no job %1 which
now exists within here.

bulk: Avoid an injail ls: use builtin stat(1)