tests: use 14.5-RELEASE for test jail
This fixes `make check`.
(cherry picked from commit a2dbc12484f41cc482f1caa2d0c1cb0e022270f7)
Conflicts:
test/common.bulk.sh
shash_get: Remove globbing support.
This support is not needed to function and adds complexity for
alternative backends for shash.
Still allow _shash_unset() to use globbing as an implementation detail
of shash_remove_var().
shash: some style changes
- Prefer "set" to match existing styles
- Add some :? to match existing assertions
- Use `|| return` to avoid, and not rely on, `set -e` handler
jail, ports: Avoid set -e trap in quiet-mode "done" idiom
4cb78962 introduced `[ -n "${quiet}" ] && echo " done"` in the svn/git
checkout and update paths of install_from_vcs() (jail.sh) and ports.sh.
When quiet is unset the test is false, so the statement returns exit 1;
under set -e a bare call to the enclosing function/case arm would abort
the script right after that line runs, as seen with the identical
pattern in image.sh (PR #1378). None of these 8 occurrences are
currently a function's last statement, so they don't trip today, but
the pattern is fragile under refactoring. Use an if/fi block instead,
matching the idiom already used for the preceding header line, so the
statement always returns 0.
This closes #1387
jail: Reject a period in the new name on rename
create_jail() rejects a period in JAILNAME since jail(8) names cannot
contain one, but rename_jail() never validated NEWJAILNAME at all, so
'poudriere jail -r' could rename a jail to a name jail(8) itself would
reject. Apply the same check used at creation.
This closes #1388
pkg: Add trailing ellipsis to repository signing status messages
Each of these msg() calls is immediately followed by an unredirected
injail pkg-repo invocation whose own output streams directly to the
console right after the header, the same shape as other "action
followed by unbuffered command output" status lines that already use
a trailing "...". pkg repo has no quiet/verbose toggle in play here
(PKG_REPO_FLAGS only carries --hash/--symlink), so this is a plain
ellipsis fix, not an idiom conversion.
This closes #1381
