BSD Commit Log Search

mapfile sh compat: Allow >1 writable files.

We only need an fd for reading.

hash_isset_var: mapfile can break since specializing /dev/stdin

Add stack_isset()

tests: Only source expected files.

. by itself searches PATH.

mapfile sh: Clarify a function/feature name.

runtest jobs: Fix job issue with keeping slots busy

It was possible to wait for 1, or more, jobs to finish
while there were available slots open.

Add shellcheck test for files that currently pass

eargs: Support showing passed in vars

Requires adding to the end of the eargs line:
        EARGS: "$@"
This passes in the positional parameters which allows seeing them
properly grouped.

        # ./poudriere api 'hash_get'
        Error: hash_get: 3 arguments expected, got 0:
                Expected: hash_get var key var_return
                Missing:  var key var_return
        # ./poudriere api 'hash_get 1'
        Error: hash_get: 3 arguments expected, got 1:
                Expected: hash_get var key var_return
                Received: hash_get "1"
                Missing:  key var_return
        # ./poudriere api 'hash_get 1 2'
        Error: hash_get: 3 arguments expected, got 2:
                Expected: hash_get var key var_return

    [6 lines not shown]

Add generic deprecated(funcname, reason)

mapfile sh compat: append should create file.

fopen(2) with a/w both create the file if they do not
exist.

mapfile: Treat stdout/stderr special.

Don't open these, just write to them directly. This
allows redirects to work as expected.

issetvar(): Rename to more consistent 'isset'

read_blocking test sh: Fixes were upstreamed long ago

mapfile_write sh compat: Fix data being read unset

shash_write: Fix invalid flag err

shlibs: Cache basd on JAIL_OSVERSION too.

Because we inspect the provided base libs, we need to cache based
on the jail version too.

setvar can fail, return error if so

pkg_get_dep_origin_pkgnames/pkg_version: Avoid globbing

display: Fix odd syntax

__package_deps_provided_libs: Slightly optimize mapfile use.

This allows mapfile -F to be used internally.

shlibs can be checked for fetching PORTTESTING

assert_{ret,true,fase}: Allow passing in a REASON

shared_hash.sh: Run through shellcheck

Avoid || return on last line.

This may change behavior since || disables set -e. The
caller can control this if it cares about the error.

parallel.sh: Run through shellcheck

package_libdeps_satisfied: Avoid unneeded $()

setvar compat: Add tests and make better.

The old method used a pipe(2) and ate spaces badly

getvar: Show value fetched with set -x

eargs: Tell [] vars as a range

mapfile_read_loop sh compat: stdin should use read_blocking