bhyve/riscv: fix PCIe FDT interrupt-map entry stride
In bhyve arm64, each PCIe interrupt-map entry spans 10 cells because the
ARM GIC specifies #interrupt-cells = 3. On RISC-V, the APLIC uses
#interrupt-cells = 2, so each entry spans only 9 cells.
When the PCIe FDT code was originally adapted from arm64, the property
allocation size and cell assignments were reduced to 9 cells per entry,
but the loop multiplier retained the 10-cell stride. This caused the
interrupt-map array to be packed incorrectly with gaps, breaking PCI
interrupt routing in guest operating systems and overflowing the
allocation by 16 cells.
Correct the loop stride to 9 cells so the interrupt map is properly
formed.
Approved by: re (cperciva)
Reviewed by: jrtc27
Fixes: 7ab1a32cd43c ("bhyve/riscv: Initial import")
[28 lines not shown]
contrib/kyua: update config.h for 0.15.1 -> 0.15.2
This was accidentally missed in the prior commit.
This commit addresses a largely cosmetic issue.
MFC after: 6 days
MFC with: c16da33701d0
Fixes: c16da33701d0 contrib/kyua: update to 0.15.2
Remove {ATF,PLAIN}_REQUIRE_KERNEL_MODULE macros
These macros predated the `require.kmod` (ATF) and `required_kmods`
(kyua) test metadata and are no longer needed.
Add a hint to freebsd_test_suite/macros.h about the `*FEATURE*` macros
going away soon. See [this kyua issue][kyua-issue] for more details.
MFC after: 1 month
Differential Revision: https://reviews.freebsd.org/D61082
[kyua-issue]: https://github.com/freebsd/kyua/issues/346
mii: call only PHY_STATUS() from mii_pollstat()
When we are in mii_pollstat() which effectively is called only from
ue_mii_sts methods of various drivers, we are interested in polling the
status and not making any actions.
What PHY_SERVICE(,, MII_POLLSTAT) effectively did was PHY_STATUS()
followed by mii_phy_update(). The latter is undesired, as we already may
be servicing a link state change event and posting a second one is not
what we want. Usually mostly harmless, this second event would panic when
device is calling into mii during its detach (e.g. USB device).
NB: there are few drivers that would do extra stuff between PHY_STATUS()
and mii_phy_update() in their mii_service methods. This seems irrelevant
to me when we are in ue_mii_stat/mii_pollstat. But I could be wrong.
See the PR for longer discussion.
PR: 290417
tests/ssl_sendfile: size socket buffers before connecting
The :grow, :truncate and :eagain_vs_eof cases rely on the socket buffers
filling up before the whole file has been sent. :grow and :truncate shrank
SO_SNDBUF and SO_RCVBUF only after the connection was established, when
the receiver had already advertised a window based on the default buffer
size; TCP does not shrink an advertised window. :eagain_vs_eof used the
default, autosized buffers. With a large net.inet.tcp.recvspace, or once
autosizing has grown the buffers, the whole 2 MB file fits in the socket
buffers:
:grow and :truncate: sendfile(2) returns before the file is resized, and
the poll loop that waits for the sender to block spins forever on a
writable socket.
:eagain_vs_eof: the loop that keeps writing until
EAGAIN never sees it, since sendfile(2) returns 0 at EOF.
Either way kyua reports a timeout, which is why doubling the timeouts did
not help. Apply a 128 KB buffer size to the listening socket, which the
[12 lines not shown]
databases/postgresql19-*: Update to 19.0
First production release of the 19 series.
This release introduces the REPACK (CONCURRENTLY) command so users can
optimize tables for their current workload without disruption to ongoing
operations. PostgreSQL 19 gives users better control over plan stability
and query performance with the new pg_plan_advice extension. Developers
will find many delightful features in this release, from support for
"read-your-writes" consistency on standbys to "get or create" behavior
that saves a network round trip.
Upgrading from 18 or earlier requires a dump/restore or pg_upgrade.
Release notes: https://www.postgresql.org/docs/19/release-19.html
(cherry picked from commit 5fa58ac8856ff5bbf8d6b65a0769cdba11e336ed)
databases/postgresql1[45678]-*: Update to latest patch releases
Update to 18.7, 17.12, 16.16, 15.20 and 14.25, fixing 53 CVEs and
a large number of other bugs.
A dump/restore is not required, but some indexes may be corrupt and
should be rebuilt with REINDEX after updating:
- btree indexes on bpchar columns declared without a length
(CHAR(n) is not affected)
- GiST indexes using gist_trgm_ops (contrib/pg_trgm)
- GIN indexes and TOAST-table indexes, if corruption is suspected
For 17 and 18, existing incremental backups should not be trusted.
Take a new full backup after updating and base subsequent
incremental backups on that.
Release notes: https://www.postgresql.org/about/news/postgresql-187-1712-1616-1520-1425-and-19-rc-2-released-3442/
Security: 1a672925-de93-11f1-9824-6cc21735f730
[2 lines not shown]
databases/postgresql19-server: Update to 19RC1
The PostgreSQL Global Development Group announces that the first release
candidate of PostgreSQL 19 is now available for download. As a release
candidate, PostgreSQL 19 RC 1 will be mostly identical to the initial
release of PostgreSQL 19, though some more fixes may be applied prior to
the general availability of PostgreSQL 19.
To upgrade to PostgreSQL 19 RC 1 from earlier versions of PostgreSQL,
you will need to use a major version upgrade strategy, e.g. pg_upgrade
or pg_dump / pg_restore. For more information, please visit the
documentation section on upgrading:
https://www.postgresql.org/about/news/postgresql-19-rc-1-released-3409/
(cherry picked from commit 0ee810cf51b3110956e0ac1076a2ebb6f7de320f)
bhyve/riscv: fix PCIe FDT interrupt-map entry stride
In bhyve arm64, each PCIe interrupt-map entry spans 10 cells because the
ARM GIC specifies #interrupt-cells = 3. On RISC-V, the APLIC uses
#interrupt-cells = 2, so each entry spans only 9 cells.
When the PCIe FDT code was originally adapted from arm64, the property
allocation size and cell assignments were reduced to 9 cells per entry,
but the loop multiplier retained the 10-cell stride. This caused the
interrupt-map array to be packed incorrectly with gaps, breaking PCI
interrupt routing in guest operating systems and overflowing the
allocation by 16 cells.
Correct the loop stride to 9 cells so the interrupt map is properly
formed.
Reviewed by: jrtc27
Fixes: 7ab1a32cd43c ("bhyve/riscv: Initial import")
MFC after: 3 days
[3 lines not shown]
Revert "bhyve/riscv: fix PCIe FDT interrupt-map entry stride"
Thanks to past me's foolish choice not to alter the commit message such
that none of its lines start with a #, Git got very confused the
cherry-pick and included its own commented-out instructions. Reverting
to re-land with a fixed body.
This is a direct commit to stable/15.
This reverts commit 69f76efd01a72fe0d6cb68442d2c15d3174a268f.
bhyve/riscv: fix PCIe FDT interrupt-map entry stride
In bhyve arm64, each PCIe interrupt-map entry spans 10 cells because the
ARM GIC specifies #interrupt-cells = 3. On RISC-V, the APLIC uses
#interrupt-cells = 2, so each entry spans only 9 cells.
When the PCIe FDT code was originally adapted from arm64, the property
allocation size and cell assignments were reduced to 9 cells per entry,
but the loop multiplier retained the 10-cell stride. This caused the
interrupt-map array to be packed incorrectly with gaps, breaking PCI
interrupt routing in guest operating systems and overflowing the
allocation by 16 cells.
Correct the loop stride to 9 cells so the interrupt map is properly
formed.
Reviewed by: jrtc27
Fixes: 7ab1a32cd43c ("bhyve/riscv: Initial import")
MFC after: 3 days
[25 lines not shown]