sysutils/bareos24-server: Revert "Replace BROKEN to IGNORE_i386"
This reverts commit 6b84ea6ad1955a2bc13f17ddd3e0da66161f6506.
On platforms where ssize_t is 32 bits wide, the comparison will be made
unsigned (ssize_t converted to an unsigned value);
on platforms where ssize_t is wider than uint32_t, the comparison will
be made signed (uint32_t converted to the wider signed ssize_t).
That also has repercussions in that bytes_left a few lines down
will be negative if and only if the passed in size_t count argument is
greater than INT**_MAX, with ** being whatever size the "size_t count"
is.
If you don't see a compiler error on that line, that does not imply the
code is right or the bug is away, but that the compiler warning did not
trigger in that situation due to a warning bug. The upstream maintainer
did want the code break compile in that case.
[3 lines not shown]
ice(4): Handle allmulti flag in ice_if_promisc_set function
In the ice_if_promisc_set function, the driver currently disables the
IFF_ALLMULTI flag, thereby preventing the activation of multicast mode.
To address this issue, implement appropriate handling to ensure the
flag is managed correctly.
Signed-off-by: Yogesh Bhosale <yogesh.bhosale at intel.com>
Tested by: Gowthamkumar K S <gowtham.kumar.ks at intel.com>
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D54186
smartpqi: Avoid declaring extern inline functions
Each C file is compiled separately so these functions can't be inlined
except in the file where they are defined. Since these functions aren't
used outside smartpqi_request.c, just do the simple thing and make them
private to that file.
Reported by: gcc
Reviewed by: jrhall
Fixes: c558eca47970 ("smartpqi: update to version 4660.0.2002")
Differential Revision: https://reviews.freebsd.org/D54732
(cherry picked from commit 75c591b26723711d7a38f2a5df7aecc28198cd83)
Remove example tests when MK_EXAMPLES=no
This change cleans up example tests for atf, googletest, plain, and TAP
when MK_EXAMPLES=no. Not having this in results
`kyua test -k /usr/tests/share/examples/Kyuafile` being broken on a host
where the content in that directory tree is stale. I ran into that case
because at some point in time in the past I had specified
`MK_GOOGLETEST=no` one of my dev instances.
MFC after: 1 week
LinuxKPI: timer KPI *_timer -> timer_* (restore symbols)
In c84bfaa2531870a023fa9b267a765b9518ed3350 the symbols for the old
timer KPI were removed and replaced by inline functions as backup.
This breaks kernel modules (such as drm-kmod, though for that there
should be a rebuild in the package repo given a __FreeBSD_version
bump) as symbols are missing now. Restore the symbols for the stable
branch.
This is a direct commit for the fix.
Reported by: nyan
Reviewed by: nyan
Fixes: c84bfaa25318
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D55027
ports.cgi: enable to sort pkg result list by column
You can sort the pkg result table in asc or desc order
by clicking on the column header Release, Version
or Build Time.
vt.4: Sprinkle mdoc macros
Now that we have angle bracket characters for all common display sizes,
sprinkle in the correct macros for the structures in this page. While
here, fix a mdoc typo, a linter warning, and switch a parenthetical to
a much smoother appositive.
MFC after: 3 days
Fixes: 7cd6da268a8f (vt.4: Style pass)
contrib/spleen: Update to 2.2.O
This release adds several new characters critical to the manual pages
that were previously missing on high-dpi displays: em-dash, en-dash,
hyphen, angle brackets, white square, dagger, and double dagger. It
also features improved alignment for numerous characters in different
sizes.
Thanks: Fredric Cambus
MFC after: 3 days
Discussed with: emaste
sh: Fix job pointer invalidation with trapsasync
Calling dotrap() can do almost anything, including reallocating the
jobtab array. Convert the job pointer to an index before calling
dotrap() and then restore a proper job pointer afterwards.
PR: 290330
Reported by: bdrewery
Reviewed by: bdrewery
Differential Revision: https://reviews.freebsd.org/D53793
(cherry picked from commit f44ac8cc9c10d7305223a10b8dbd8e234388cc73)
sh: Fix a double free in a rare scenario with pipes
The command
sh -c 'sleep 3 | sleep 2 & sleep 3 & kill %1; wait %1'
crashes (with appropriate sanitization such as putting
MALLOC_CONF=abort:true,junk:true in the environment or compiling with
-fsanitize=address).
What happens here is that waitcmdloop() calls dowait() with a NULL job
pointer, instructing dowait() to freejob() if it's a non-interactive
shell and $! was not and cannot be referenced for it. However,
waitcmdloop() then uses fields possibly freed by freejob() and calls
freejob() again.
This only occurs if the job being waited for is identified via % syntax
($! has never been referenced for it), it is a pipeline with two or more
elements and another background job has been started before the wait
command. That seems special enough for a bug to remain. Test scripts
written by Jilles would almost always use $! and not % syntax.
[15 lines not shown]
sh: Fix job pointer invalidation with trapsasync
Calling dotrap() can do almost anything, including reallocating the
jobtab array. Convert the job pointer to an index before calling
dotrap() and then restore a proper job pointer afterwards.
PR: 290330
Reported by: bdrewery
Reviewed by: bdrewery
Differential Revision: https://reviews.freebsd.org/D53793
(cherry picked from commit f44ac8cc9c10d7305223a10b8dbd8e234388cc73)
sh: Fix a double free in a rare scenario with pipes
The command
sh -c 'sleep 3 | sleep 2 & sleep 3 & kill %1; wait %1'
crashes (with appropriate sanitization such as putting
MALLOC_CONF=abort:true,junk:true in the environment or compiling with
-fsanitize=address).
What happens here is that waitcmdloop() calls dowait() with a NULL job
pointer, instructing dowait() to freejob() if it's a non-interactive
shell and $! was not and cannot be referenced for it. However,
waitcmdloop() then uses fields possibly freed by freejob() and calls
freejob() again.
This only occurs if the job being waited for is identified via % syntax
($! has never been referenced for it), it is a pipeline with two or more
elements and another background job has been started before the wait
command. That seems special enough for a bug to remain. Test scripts
written by Jilles would almost always use $! and not % syntax.
[15 lines not shown]
