OPNSense/core e4203d8src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api NetworkinsightController.php, src/opnsense/mvc/app/views/OPNsense/Diagnostics networkinsight.volt

Reporting / Insight - cleanup frontend code and move some processing to the backend for easier handling.

Eventually we want to replace the d3 graphs, but before doing that, it's likely a good idea to cleanup the code for readability.
DeltaFile
+61-168src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+37-8src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/Api/NetworkinsightController.php
+98-1762 files

OPNSense/core bf07d89src/etc/inc interfaces.inc, src/opnsense/mvc/app/controllers/OPNsense/Core/Api FirmwareController.php

Merge branch 'master' into enhance-openvpn-config-tlscrypt
DeltaFile
+1,183-0src/opnsense/www/js/pick-a-color-1.2.3.js
+388-349src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt
+283-298src/opnsense/scripts/firmware/check.sh
+253-226src/opnsense/mvc/app/controllers/OPNsense/Core/Api/FirmwareController.php
+220-148src/www/widgets/widgets/traffic_graphs.widget.php
+116-125src/etc/inc/interfaces.inc
+2,443-1,146228 files not shown
+6,572-3,179234 files

OPNSense/core 6d310f8src/opnsense/mvc/app/views/OPNsense/Diagnostics networkinsight.volt

Fix sidebar menu collapse (#4657)

(cherry picked from commit c33af5b33f60c0c9059a539a8ecbf573b75f5843)
DeltaFile
+1-1src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+1-11 files

OPNSense/core c33af5bsrc/opnsense/mvc/app/views/OPNsense/Diagnostics networkinsight.volt

Fix sidebar menu collapse (#4657)

DeltaFile
+1-1src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+1-11 files

OPNSense/core b62dac7src/opnsense/mvc/app/views/OPNsense/Diagnostics networkinsight.volt

Network insight: store hostname into it's own field on reverse lookup so we don't loose the original address. Pass the address to the detail view on click. closes https://github.com/opnsense/core/issues/4609

(cherry picked from commit c797bfd220c40e914f3bdd1dbd07c9c4377984f8)
DeltaFile
+5-2src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+5-21 files

OPNSense/core 0606f8fsrc/opnsense/mvc/app/views/OPNsense/Diagnostics networkinsight.volt

Network insight: store hostname into it's own field on reverse lookup so we don't loose the original address. Pass the address to the detail view on click. closes https://github.com/opnsense/core/issues/4609

(cherry picked from commit c797bfd220c40e914f3bdd1dbd07c9c4377984f8)
DeltaFile
+5-2src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+5-21 files

OPNSense/core c797bfdsrc/opnsense/mvc/app/views/OPNsense/Diagnostics networkinsight.volt

Network insight: store hostname into it's own field on reverse lookup so we don't loose the original address. Pass the address to the detail view on click. closes https://github.com/opnsense/core/issues/4609
DeltaFile
+5-2src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+5-21 files

OPNSense/core 9764509src/opnsense/mvc/app/views/OPNsense/Diagnostics networkinsight.volt fw_log.volt, src/opnsense/mvc/app/views/OPNsense/IDS index.volt

Fix missing semicolons
DeltaFile
+4-4src/www/widgets/widgets/system_information.widget.php
+3-3src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+3-3src/opnsense/mvc/app/views/OPNsense/Diagnostics/fw_log.volt
+2-2src/www/widgets/widgets/ntp_status.widget.php
+2-2src/www/services_ntpd_gps.php
+2-2src/opnsense/mvc/app/views/OPNsense/IDS/index.volt
+16-1615 files not shown
+34-3421 files

OPNSense/core 69cc389src/opnsense/mvc/app/views/OPNsense/Diagnostics arp.volt networkinsight.volt, src/opnsense/mvc/app/views/OPNsense/Proxy index.volt

Fix some JS errors
DeltaFile
+18-18src/opnsense/www/js/opnsense.js
+0-9src/opnsense/mvc/app/views/OPNsense/Proxy/index.volt
+2-2src/opnsense/mvc/app/views/OPNsense/Diagnostics/arp.volt
+1-1src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+1-1src/www/firewall_schedule_edit.php
+0-1src/www/interfaces.php
+22-326 files

OPNSense/core 71774absrc/opnsense/mvc/app/views/OPNsense/Core firmware.volt, src/opnsense/mvc/app/views/OPNsense/Diagnostics networkinsight.volt systemhealth.volt

 Fix implicit Javascript global variable assignments  (#2945)

DeltaFile
+24-23src/www/firewall_schedule_edit.php
+13-13src/opnsense/www/js/opnsense_bootgrid_plugin.js
+11-13src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+11-10src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt
+7-8src/opnsense/mvc/app/views/OPNsense/Diagnostics/systemhealth.volt
+6-6src/opnsense/www/js/opnsense_ui.js
+72-7328 files not shown
+120-11434 files

OPNSense/core 2aa1b90src/opnsense/mvc/app/views/OPNsense/Diagnostics networkinsight.volt

Network insight, drop date from 2 and 8 hour view + some minor style cleanups
DeltaFile
+16-16src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+16-161 files

OPNSense/core e0692a8src/opnsense/mvc/app/views/OPNsense/CaptivePortal vouchers.volt, src/opnsense/mvc/app/views/OPNsense/Core firmware.volt

Javascript, fix multiple issues
DeltaFile
+34-32src/opnsense/mvc/app/views/OPNsense/CaptivePortal/vouchers.volt
+16-18src/opnsense/mvc/app/views/OPNsense/IDS/index.volt
+8-9src/opnsense/mvc/app/views/OPNsense/Cron/index.volt
+8-8src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt
+8-8src/opnsense/mvc/app/views/OPNsense/Monit/status.volt
+7-7src/opnsense/mvc/app/views/OPNsense/Proxy/index.volt
+81-8213 files not shown
+118-12519 files

OPNSense/core 504a51csrc/opnsense/mvc/app/views/layouts default.volt, src/www system_usermanager.php index.php

ui: cache_safe() unbreaks browser cache after updates

Discussed with: @adschellevis
DeltaFile
+29-29src/www/system_usermanager.php
+29-29src/www/widgets/widgets/system_information.widget.php
+29-29src/www/widgets/widgets/cpu_usage.widget.php
+27-27src/www/index.php
+25-26src/www/widgets/widgets/monit.widget.php
+22-22src/opnsense/mvc/app/views/layouts/default.volt
+161-16215 files not shown
+238-21021 files

OPNSense/core b0d67d7src/opnsense/mvc/app/views/OPNsense/Diagnostics networkinsight.volt

src: typo in cache_safe additions
DeltaFile
+1-1src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+1-11 files

OPNSense/core 27b3ba0src/opnsense/mvc/app/views/OPNsense/Diagnostics networkinsight.volt, src/www system_usermanager.php index.php

src: additional cache_safe() usage
DeltaFile
+29-29src/www/system_usermanager.php
+29-29src/www/widgets/widgets/cpu_usage.widget.php
+29-29src/www/widgets/widgets/system_information.widget.php
+27-27src/www/index.php
+25-26src/www/widgets/widgets/monit.widget.php
+3-3src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+142-1437 files not shown
+154-15513 files

OPNSense/core 9c74226src/opnsense/mvc/app/views/OPNsense/Diagnostics networkinsight.volt

network insight, click event issue, https://github.com/opnsense/core/issues/2405

(cherry picked from commit 08df2d02cb5537dd67146925c435f2ed892240a1)
DeltaFile
+5-1src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+5-11 files

OPNSense/core 699e1edsrc/opnsense/mvc/app/views/OPNsense/Diagnostics networkinsight.volt systemhealth.volt

Revert "network insight / systemhealth tooltips may stick during graph reload, force removal before load", see https://github.com/opnsense/core/issues/2405

This reverts commit 7d98ae11e62d96922d85995c4d494a7c94a019db.

(cherry picked from commit 3ac6a825833fd0d5e64a78ec9310d9722f2dba13)
DeltaFile
+0-2src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+0-1src/opnsense/mvc/app/views/OPNsense/Diagnostics/systemhealth.volt
+0-32 files

OPNSense/core eeb28bdsrc/opnsense/mvc/app/views/OPNsense/CaptivePortal index.volt, src/opnsense/mvc/app/views/OPNsense/Core firmware.volt

style, remove duplicate class

(cherry picked from commit b7840df5ea9b5640072597faf61904b1762405f8)
DeltaFile
+1-1src/www/diag_pf_info.php
+1-1src/opnsense/mvc/app/views/OPNsense/CaptivePortal/index.volt
+1-1src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt
+1-1src/opnsense/mvc/app/views/OPNsense/Cron/index.volt
+1-1src/opnsense/mvc/app/views/OPNsense/Diagnostics/netflow.volt
+1-1src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+6-62 files not shown
+8-88 files

OPNSense/core b7840dfsrc/opnsense/mvc/app/views/OPNsense/CaptivePortal index.volt, src/opnsense/mvc/app/views/OPNsense/Core firmware.volt

style, remove duplicate class
DeltaFile
+1-1src/opnsense/mvc/app/views/OPNsense/CaptivePortal/index.volt
+1-1src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt
+1-1src/opnsense/mvc/app/views/OPNsense/Cron/index.volt
+1-1src/opnsense/mvc/app/views/OPNsense/Diagnostics/netflow.volt
+1-1src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+1-1src/opnsense/mvc/app/views/OPNsense/IDS/index.volt
+6-63 files not shown
+9-99 files

OPNSense/core 08df2d0src/opnsense/mvc/app/views/OPNsense/Diagnostics networkinsight.volt

network insight, click event issue, https://github.com/opnsense/core/issues/2405
DeltaFile
+5-1src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+5-11 files

OPNSense/core 3ac6a82src/opnsense/mvc/app/views/OPNsense/Diagnostics networkinsight.volt systemhealth.volt

Revert "network insight / systemhealth tooltips may stick during graph reload, force removal before load", see https://github.com/opnsense/core/issues/2405

This reverts commit 7d98ae11e62d96922d85995c4d494a7c94a019db.
DeltaFile
+0-2src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+0-1src/opnsense/mvc/app/views/OPNsense/Diagnostics/systemhealth.volt
+0-32 files

OPNSense/core fc36231src/opnsense/mvc/app/views/OPNsense/Diagnostics networkinsight.volt

Insight, add dst address in detail search, closes https://github.com/opnsense/core/issues/2398
DeltaFile
+15-12src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+15-121 files

OPNSense/core fcda7cdsrc/opnsense/mvc/app/views/OPNsense/Diagnostics networkinsight.volt

Insight, add dst address in detail search, closes https://github.com/opnsense/core/issues/2398
DeltaFile
+15-12src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+15-121 files

OPNSense/core 643ee65src/opnsense/mvc/app/views/OPNsense/Diagnostics systemhealth.volt networkinsight.volt

mvc: merge icon cleanup from master
DeltaFile
+2-3src/opnsense/mvc/app/views/OPNsense/Diagnostics/systemhealth.volt
+1-1src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+3-42 files

OPNSense/core 46861aesrc/opnsense/mvc/app/views/OPNsense/Core firmware.volt, src/opnsense/mvc/app/views/OPNsense/Diagnostics networkinsight.volt systemhealth.volt

www: better layouting for fa switch on btn-xs
DeltaFile
+11-11src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt
+5-5src/www/index.php
+3-2src/opnsense/www/themes/opnsense/build/css/main.css
+3-2src/opnsense/www/themes/opnsense/assets/stylesheets/main.scss
+1-1src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+1-1src/opnsense/mvc/app/views/OPNsense/Diagnostics/systemhealth.volt
+24-226 files

OPNSense/core 4cf0f49src/opnsense/mvc/app/config services.php, src/opnsense/mvc/app/views/OPNsense/Diagnostics networkinsight.volt

theme styles, use pluggable locations for component css files in both new and legacy code

PR: https://github.com/opnsense/core/pull/2124

(cherry picked from commit 2461ca2a8504671d76946f37f7ab68d8964423a8)
(cherry picked from commit cbcb9da2ee30b8b5b4395865312934b1ca3c8ffa)
(cherry picked from commit 1fbbecec2e461677a076bd733884673039017e92)
(cherry picked from commit 15bb3ac5919d045140a4907ae1dfff41f513726a)
DeltaFile
+22-5src/opnsense/mvc/app/config/services.php
+22-0src/www/guiconfig.inc
+5-6src/opnsense/mvc/app/views/layouts/default.volt
+4-4src/www/head.inc
+1-2src/www/vpn_ipsec_settings.php
+1-1src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+55-183 files not shown
+58-199 files

OPNSense/core ae01580src/opnsense/mvc/app/views/OPNsense/Diagnostics networkinsight.volt systemhealth.volt, src/opnsense/mvc/app/views/layouts default.volt

HTML Compliance - Attribute "type" on Element <script>

Warning: The type attribute is unnecessary for JavaScript resources.

HTML5: Edition for Web Authors
http://www.w3.org/TR/2014/REC-html5-20141028/scripting-1.html
The default, which is used if the attribute is absent, is "text/javascript".

The Script element
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script
HTML5 specification urges authors to omit the attribute rather than provide a redundant MIME type.

(cherry picked from commit 6ef9a127fffa9da4150139bfaa5df5c8eb4007d3)
DeltaFile
+11-11src/opnsense/mvc/app/views/layouts/default.volt
+9-9src/www/head.inc
+8-8src/www/wizard.php
+4-4src/www/foot.inc
+3-3src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+3-3src/opnsense/mvc/app/views/OPNsense/Diagnostics/systemhealth.volt
+38-38107 files not shown
+159-159113 files

OPNSense/core 2461ca2src/opnsense/mvc/app/views/OPNsense/Diagnostics systemhealth.volt networkinsight.volt, src/opnsense/mvc/app/views/layouts default.volt

theme styles, use pluggable locations for component css files in both new and legacy code, for https://github.com/opnsense/core/pull/2124
DeltaFile
+22-0src/www/guiconfig.inc
+4-4src/opnsense/mvc/app/views/layouts/default.volt
+4-4src/www/head.inc
+1-2src/www/vpn_ipsec_settings.php
+1-1src/opnsense/mvc/app/views/OPNsense/Diagnostics/systemhealth.volt
+1-1src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+33-126 files

OPNSense/core 6ef9a12src/opnsense/mvc/app/views/layouts default.volt, src/www head.inc wizard.php

HTML Compliance - Attribute "type" on Element <script>

Warning: The type attribute is unnecessary for JavaScript resources.

HTML5: Edition for Web Authors
http://www.w3.org/TR/2014/REC-html5-20141028/scripting-1.html
The default, which is used if the attribute is absent, is "text/javascript".

The Script element
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script
HTML5 specification urges authors to omit the attribute rather than provide a redundant MIME type.
DeltaFile
+11-11src/opnsense/mvc/app/views/layouts/default.volt
+9-9src/www/head.inc
+8-8src/www/wizard.php
+4-4src/www/system_usermanager.php
+4-4src/www/foot.inc
+3-3src/www/system_usermanager_import_ldap.php
+39-39123 files not shown
+184-184129 files

OPNSense/core 97be197src/opnsense/mvc/app/models/OPNsense/Diagnostics/ACL ACL.xml, src/opnsense/mvc/app/views/OPNsense/Diagnostics networkinsight.volt

insight, add reverse lookups. https://github.com/opnsense/core/issues/1034
DeltaFile
+76-38src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt
+1-0src/opnsense/mvc/app/models/OPNsense/Diagnostics/ACL/ACL.xml
+77-382 files