Fix overlapping strcpy usages
Using overlapping src & dest witgh strcpy is undefined, so anything
like
strcpy(str + N, str + M);
is automatically invalid, regardless of the valuse of N and M.
Change offending usages here to use memmove() instead.
Note: 2 issues: First, there is no (in sntp/compat) anything to deal
with the possibility that memmove() is not available - this should not
be a problem building nbsd, but it might be if any attempt were to be
made to upstream this change (the autoconf machinery to detect memmove()
would be needed, along wth a memmove() implementation).
Second, and more serious here, I haven't been able to get a build to
actually compile this code, so while I believe it is correct, I am unable
to test it. This is intended to fix the sh3 builds on in the releng
daily builds, so we will see what happens. As best I can tell my build
[2 lines not shown]
libc/rand: remove no-longer-needed LINTED comment
The calculation happens in unsigned integer mode, which is guaranteed to
wrap around on overflow. As long as RAND_MAX fits in 'int', the cast to
'int' is not necessary, but it doesn't hurt either.
bswap16: remove no-longer-needed LINTED comment
Lint computes the integer constraints for the expression and thus knows
that it fits in uint16_t. Since the default LINTFLAGS contain only a
single -a, lint wouldn't detect an accidental overflow at this point, it
would need a second -a flag.
Import jemalloc-5.3.1 (previous was 5.3.0)
This release includes over 390 commits spanning bug fixes, new features,
performance optimizations, and portability improvements. Multiple percent
of system-level metric improvements were measured in tested production
workloads. The release has gone through large-scale production testing
at Meta.
New features:
Support pvalloc. (@Lapenkov: 5b1f2cc)
Add double free detection for the debug build. (@izaitsevfb:
36366f3, @guangli-dai: 42daa1a, @divanorama: 1897f18)
Add compile-time option --enable-pageid to enable memory mapping
annotation. (@devnexen: 4fc5c4f)
Add runtime option prof_bt_max to control the max stack depth for
profiling. (@guangli-dai: a0734fd)
Add compile-time option --enable-force-getenv to use getenv instead
of secure_getenv. (@interwq: 481bbfc)
[129 lines not shown]
pmap: move userland xtab activate/deactivate into pmap_md_asid{,de}activate
pmap_segtab_{,de}activate() no longer calls pmap_md_xtab_{,de}activate()
Instead move the calls into
- pmap_tlb_asid_acquire()
- pmap_tlb_asid_deactivate()
respectively.
Rename xtab to asid at the same time so that the functions are now named
pmap_md_asid_{,de}activate(), and are provided as static inline to improve
code size.
On arm32 and aarch64 TTBR0 is disabled for the entire time that a userland
process in not pmap_activate()ed and only ever enabled if a userland
process is pmap_activate()ed. This results in less twiddling of the disable
bit, and no speculation window there incorrect TTBR0 walks can occur.
The last part makes GENERIC64_PMAPMI stable on Fusion on an M4 laptop.
netstat: fix plural forms for large numbers
Previously, for n * 2^32 + 1, the singular form was wrongly used.
This fixes 375 lint warnings about possible loss of accuracy.
auth2-chall.c: fix merging botch that broke basic functionality
Addresses PR bin/60196 "OpenSSH keyboard-interactive/pam authentication
fails to work after the update to 10.3".
This issue would also have affected S/Key functionality from what I
see, though I have no means of testing this. Also "BSD auth", but
that's not enabled by us.
