BSD Commit Log Search

tcp: remove support for TCPPCAP

This feature could be used to store the last sent and received TCP
packets for a TCP endpoint. There was no utility to get these packets
from a live system or core.
This functionality is now provided by TCP Black Box Logging, which also
stores additional events. There are tools to get these traces from a
live system or a core.
Therefore remove TCPPCAP to avoid maintaining it, when it is not
used anymore.

Reviewed by:            rrs, rscheff, Peter Lei, glebiu
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D49589

tcp: don't send beyond receivers advertised window

When calculating length of data to be sent, we may do some congestion
calculations, but we shall never send a byte beyond (snd_una + snd_wnd).
In 7dc78150c730e we started to use tcp_compute_pipe() instead of (snd_wnd
- off).  This function makes an estimate of how much data is in flight. It
can return a value smaller and larger than (snd_nxt - snd_una).  It will
return a value larger when we have retransmitted some data from SACK
holes, and smaller once those retransmitted SACK holes are acked.

We may use tcp_compute_pipe() for length calculation, but always capped
by the send offset 'off', which (snd_nxt - snd_una).

PR:                     283649
Reviewed by:            rscheff
Differential Revision:  https://reviews.freebsd.org/D48237
Fixes:                  7dc78150c730e90fa2afdaba3aa645932b30c429

tcp: make sack_rxmit in tcp_output() a bool

Also make this variable initialization, as well as accompanying sackhole
pointer, slightly more readable. NFC.

Reviewed by:            rscheff, tuexen, rrs
Differential Revision:  https://reviews.freebsd.org/D48235

tcp_output: Clear FIN if tcp_m_copym truncates output length

Reviewed by:    rscheff, tuexen, gallatin
Sponsored by:   Chelsio Communications
Differential Revision:  https://reviews.freebsd.org/D46824

(cherry picked from commit 519981e3c09c2875b136635459c87ab24d3104e2)

tcp_output: Clear FIN if tcp_m_copym truncates output length

Reviewed by:    rscheff, tuexen, gallatin
Sponsored by:   Chelsio Communications
Differential Revision:  https://reviews.freebsd.org/D46824

(cherry picked from commit 519981e3c09c2875b136635459c87ab24d3104e2)

tcp: extend the use of the th_flags accessor function

Formally, there are 12 bits for TCP header flags.
Use the accessor functions in more (kernel) places.

No functional change.

Reviewed By: cc, #transport, cy, glebius, #iflib, kbowling
Sponsored by: NetApp, Inc.
Differential Revision: https://reviews.freebsd.org/D47063

tcp: Use segment size excluding tcp options for all cwnd calculations

Avoid sending small segments by making sure that cwnd is usually
calculated in full (data) segment sizes. Especially during loss
recovery and retransmission scenarios.

Reviewed By: tuexen, #transport
Sponsored by: NetApp, Inc.
Differential Revision: https://reviews.freebsd.org/D47474

tcp: fix cwnd recalculation during limited transmit

Properly calculate the expected flight size (cwnd) during
limited transmit. Exclude the SACK scoreboard from
consideration when still in limited transmit.

PR: 282605
Reviewed By: tuexen, #transport
Sponsored by: NetApp, Inc.
Differential Revision: https://reviews.freebsd.org/D47541

tcp: allow TSO even while RX path is unordered

Over IP networks, forward and return path largely
act independently from each other. Do not disable LRO
on the TX side, when reordering/loss is happening
on the RX half-connection.

Reviewed By: rrs, #transport, peter.lei_ieee.org
Sponsored by: NetApp, Inc.
Differential Revision: https://reviews.freebsd.org/D47056

tcp: change SOCKBUF_* macros to SOCK_[RECV|SEND]BUF_* macros

Change the older LOCK related macros over to the
dedicated send/recv buffer macros in the base tcp stack.

No functional change intended.

Reviewed By: tuexen, #transport
Sponsored by: NetApp, Inc.
Differential Revision: https://reviews.freebsd.org/D47567

tcp: refactor cwnd during SACK transmissions to allow TSO

Refactoring of cwnd and moving the adjustment for SACKed data into
tcp_output() - cwnd tracking the maximum extent starting at snd_una -
allows both SACK loss recovery as well as SACK transmissions after
RTO during slow start and if allowed, the use of TSO while in loss
recovery.

Reviewed By:            tuexen, cc, #transport
Sponsored by:           NetApp, Inc.
Differential Revision:  https://reviews.freebsd.org/D43470

tcp: fix duplicate retransmissions when RTO happens during SACK loss recovery

When snd_nxt doesn't track snd_max, partial SACK ACKs may elicit
unexpected duplicate retransmissions. This is usually masked by
LRO not necessarily ACKing every individual segment, and prior
to RFC6675 SACK loss recovery, harder to trigger even when an
RTO happens while SACK loss recovery is ongoing.

Address this by improving the logic when to start a SACK loss recovery
and how to deal with a RTO, as well as improvements to the adjusted
congestion window during transmission selection.

Reviewed By:    tuexen, cc, #transport
Sponsored by:   NetApp, Inc.
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D43355

(cherry picked from commit 440f4ba18e3ab7be912858bbcb96a419fcf14809)

tcp: fix duplicate retransmissions when RTO happens during SACK loss recovery

When snd_nxt doesn't track snd_max, partial SACK ACKs may elicit
unexpected duplicate retransmissions. This is usually masked by
LRO not necessarily ACKing every individual segment, and prior
to RFC6675 SACK loss recovery, harder to trigger even when an
RTO happens while SACK loss recovery is ongoing.

Address this by improving the logic when to start a SACK loss recovery
and how to deal with a RTO, as well as improvements to the adjusted
congestion window during transmission selection.

Reviewed By:    tuexen, cc, #transport
Sponsored by:   NetApp, Inc.
MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D43355

tcp_output: Clear FIN if tcp_m_copym truncates output length

Reviewed by:    rscheff, tuexen, gallatin
Sponsored by:   Chelsio Communications
Differential Revision:  https://reviews.freebsd.org/D46824

tcp: remove remnants of 20+ year old disabled code from d912c694ee00

Fixes:  90ad2dc28747a3a5036d68ccc87d2352459f5cb1

tcp: no data on SYN segments unless doing TFO

Ensure that there is no data on SYN segments unless doing TFO.
This check is already in RACK and BBR.

Reported by:            glebius
Reviewed by:            rscheff
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D44384

(cherry picked from commit af700f430fd86ba3eae63e587985a12436db8f69)

ipsec_offload: handle TSO if supported

Allow for TSO to operate if network interface supports ipsec inline
offload and supports TSO over it.

Reviewed by:    tuexen
Sponsored by:   NVIDIA networking
Differential revision:  https://reviews.freebsd.org/D44222

tcp: add counter to track when SACK loss recovery uses TSO

Add a counter to track how frequently SACK has transmitted
more than one MSS using TSO. Instances when this will be
beneficial is the use of PRR, or when ACK thinning due to
GRO/LRO or ACK discards by the network are present.

Reviewed By:            tuexen, #transport
Sponsored by:           NetApp, Inc.
Differential Revision:  https://reviews.freebsd.org/D45070

tcp: add sysctl to allow/disallow TSO during SACK loss recovery

Introduce net.inet.tcp.sack.tso for future use when TSO is ready
to be used during loss recovery.

Reviewed By:            tuexen, #transport
Sponsored by:           NetApp, Inc.
Differential Revision:  https://reviews.freebsd.org/D45068

tcp: no data on SYN segments unless doing TFO

Ensure that there is no data on SYN segments unless doing TFO.
This check is already in RACK and BBR.

Reported by:            glebius
Reviewed by:            rscheff
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D44384

(cherry picked from commit af700f430fd86ba3eae63e587985a12436db8f69)

tcp: no data on SYN segments unless doing TFO

Ensure that there is no data on SYN segments unless doing TFO.
This check is already in RACK and BBR.

Reported by:            glebius
Reviewed by:            rscheff
MFC after:              1 week
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D44384

tcp: remove IS_FASTOPEN() macro

The macro is more obfuscating than helping as it just checks a single flag
of t_flags.  All other t_flags bits are checked without a macro.

A bigger problem was that declaration of the macro in tcp_var.h depended
on a kernel option.  It is a bad practice to create such definitions in
installable headers.

Reviewed by:            rscheff, tuexen, kib
Differential Revision:  https://reviews.freebsd.org/D44362

tcp: stop doing superfluous work after sending RST

When sending a RST control segment in tcp_output() it
means we are in TCPS_CLOSED state, called from tcp_drop().
Once the RST is sent, don't call tcp_timer_activate() or
update anything in tcpcb, since that will go away shortly.

PR:                     276761
Provided by:            glebius
Reviewed By:            glebius, tuexen, #transport
Sponsored by:           NetApp, Inc.
Differential Revision:  https://reviews.freebsd.org/D43808

tcp: commonize check for more data to send, style changes

Use SEQ_SUB instead of a plain subtraction, for an implict
type conversion and prevention of a possible overflow.
Use curly brackets in stacked if statements throughout.
Use of the ? operator to enhance readability when clearing
the FIN flag in tcp_output().

None of the above change the function.

Reviewed By:           tuexen, cc, #transport
Sponsored by:          NetApp, Inc.
Differential Revision: https://reviews.freebsd.org/D43539

tcp: fix TCPSTAT accounting for SACK

Account for SACK retransmitted bytes once the actual length
is known. This prevents a call to tcp_maxseg() and prepares
for TSO support when transmitting from the SACK scoreboard.

Reviewed By:           tuexen, #transport
Sponsored by:          NetApp, Inc.
Differential Revision: https://reviews.freebsd.org/D43447

tcp: remove 20+ year old disabled code from d912c694ee00

tcp: clear outdated comment mentioning T/TCP

sys: Style fix for M_EXT | M_EXTPG

Add a space around the | operator in places testing for either M_EXT
or M_EXTPG.

Reviewed by:    imp, glebius
Sponsored by:   Chelsio Communications
Differential Revision:  https://reviews.freebsd.org/D43216

(cherry picked from commit f7d5900aa063c6e9d19e6372ba981fc76aa326a2)

sys: Style fix for M_EXT | M_EXTPG

Add a space around the | operator in places testing for either M_EXT
or M_EXTPG.

Reviewed by:    imp, glebius
Sponsored by:   Chelsio Communications
Differential Revision:  https://reviews.freebsd.org/D43216

(cherry picked from commit f7d5900aa063c6e9d19e6372ba981fc76aa326a2)

tcp: clean PRR state after ECN congestion recovery.

PRR state was not properly reset on subsequent ECN CE
events. Clean up after local transmission failures too.

Reviewed by:           tuexen, cc, #transport
MFC after:             3 days
Sponsored by:          NetApp, Inc.
Differential Revision: https://reviews.freebsd.org/D43170

(cherry picked from commit 429f14f83ae1f6357a9455d4f075522420b01b03)