BSD Commit Log Search

hash_isset_var: mapfile can break since specializing /dev/stdin

Add stack_isset()

eargs: Support showing passed in vars

Requires adding to the end of the eargs line:
        EARGS: "$@"
This passes in the positional parameters which allows seeing them
properly grouped.

        # ./poudriere api 'hash_get'
        Error: hash_get: 3 arguments expected, got 0:
                Expected: hash_get var key var_return
                Missing:  var key var_return
        # ./poudriere api 'hash_get 1'
        Error: hash_get: 3 arguments expected, got 1:
                Expected: hash_get var key var_return
                Received: hash_get "1"
                Missing:  key var_return
        # ./poudriere api 'hash_get 1 2'
        Error: hash_get: 3 arguments expected, got 2:
                Expected: hash_get var key var_return

    [6 lines not shown]

issetvar(): Rename to more consistent 'isset'

setvar can fail, return error if so

Avoid || return on last line.

This may change behavior since || disables set -e. The
caller can control this if it cares about the error.

Fix some getvar/setvar functions to avoid shadowing setvar

gsub sh: Fix special case of replacing '*'

This fixes an infinite loop in _msg_fmt_n() when aligning build summary.

hash: Cleanup shellcheck warnings

hash_set: Support noclobber

hash_remove: Support no return var

hash_remove: Avoid colliding with parent vars

Add a hash_vars() mostly for test assertions

gsub_badchars: Fix with /bin/sh for '-' replacements

Merge branch 'tests-and-framework-and-misc'

* tests-and-framework-and-misc: (208 commits)
  Update ports from freebsd/freebsd-ports/main at 9d8ea2600730961c87b13ff051f26c4e88fa136d
  Support gmake jobserver for 'make check'
  New test assert framework
  Tests now support running the same test with different data.
  More SH builtins
  SH error/debug improvements
  77 new tests, 36 being package build tests
  Tests for pkgclean and incremental build
  Processes are now tracked as jobs rather than pids
  if [] conditions changed to use case where possible
  Some shellcheck finding fixes

stack: Add stack_size()

array/readarray() stuff

stack: Add stack_expand() and stack_set()

stack: Support spaced values

SC2295: Avoid expansion becoming a pattern

SC2145: Pass $@ properly as its own argument

SC2254: Fix and document where case globbing is intended

case is significantly faster than test(1) for simple string checks.

stack: Add basic push/pop functions stack_*() and for hash_*()

Pipefail fixes

Merge branch 'display_encode_args'

hash: Reduce code duplication

hash: Avoid name collisions with callers

hash: Add hash_isset_var() and hash_unset_var()

hash/list: Hide unhelpful set -x debugging