Add named constants and improve protocol validation
- Add CONSOLE_HANDSHAKE_TIMEOUT (5000ms) and CONSOLE_LOG_TRUNCATE_LEN (100)
named constants to replace magic numbers
- Use stricter protocol validation: data.toString().trim() === 'OK'
instead of indexOf('OK') === 0 for more robust handshake checking
The stricter validation prevents false positives if the response contains
"OK" as a substring of a different message.
Addresses PR review feedback from https://github.com/TritonDataCenter/smartos-live/pull/1159
Co-Authored-By: Claude Opus 4.5 <noreply at anthropic.com>
TRITON-2520: Servers should not change UUID on reboot
Portions generated by: Claude <noreply at anthropic.com>
Reviewed by: Dan McDonald <danmcd at edgecast.io>
Reviewed by: Toomas Soome <tsoome at edgecast.io>
Approved by: Toomas Soome <tsoome at edgecast.io>
TRITON-2520: Fix syntax error and indentation in get_or_store_uuid
- Add missing space before ]] in conditional test
- Fix indentation to use spaces consistently
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply at anthropic.com>
OS-8701 (missing cleanup)
Reviewed by: Travis Paul <tpaul at edgecast.io>
Reviewed by: Toomas Soome <tsoome at edgecast.io>
Approved by: Toomas Soome <tsoome at edgecast.io>
OS-8701 smartos-live (and node-0.10 of node-fs-ext) need to freeze "nan" version
Reviewed by: Carlos Neira <cneira at edgecast.io>
Reviewed by: Travis Paul <tpaul at edgecast.io>
Reviewed by: Toomas Soome <tsoome at edgecast.io>
Approved by: Carlos Neira <cneira at edgecast.io>
OS-8698 smartos-live ucodecheck needs to address AMD fallback ucode
Reviewed by: Carlos Neira <carlos.neira at edgecast.io>
Reviewed by: Travis Paul <tpaul at edgecast.io>
Approved by: Travis Paul <tpaul at edgecast.io>
OS-8697 piadm's fatal() helper should echo all args (#1160)
Reviewed by: Carlos Neira <carlos.neira at edgecast.io>
Reviewed by: Dan McDonald <danmcd at edgecast.io>
Approved by: Dan McDonald <danmcd at edgecast.io>