Illumos/gate eee92abusr/src/uts/common/io/mxfe mxfe.c

17161 mxfe: variable dereferenced before check
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Approved by: Patrick Mooney <pmooney at pfmooney.com>
DeltaFile
+14-14usr/src/uts/common/io/mxfe/mxfe.c
+14-141 files

Illumos/gate 7887f1cusr/src/uts/common/io/dld dld_proto.c, usr/src/uts/intel/dld Makefile

17167 dld: unsigned is never less than zero
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Approved by: Patrick Mooney <pmooney at pfmooney.com>
DeltaFile
+1-1usr/src/uts/common/io/dld/dld_proto.c
+0-2usr/src/uts/intel/dld/Makefile
+1-32 files

Illumos/gate ef109a5usr/src/uts/common/io/ena ena_tx.c, usr/src/uts/common/io/i40e i40e_transceiver.c i40e_stats.c

17210 meoi expectations broken by 17136
Reviewed by: Dan McDonald <danmcd at mnx.io>
Reviewed by: Kyle Simpson <kyle at oxide.computer>
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Approved by: Robert Mustacchi <rm at fingolfin.org>
DeltaFile
+42-5usr/src/uts/common/io/igc/igc_ring.c
+25-0usr/src/uts/common/io/mac/mac_provider.c
+9-6usr/src/uts/common/io/i40e/i40e_transceiver.c
+6-1usr/src/uts/common/io/ena/ena_tx.c
+1-4usr/src/uts/common/io/vioif/vioif.c
+0-3usr/src/uts/common/io/i40e/i40e_stats.c
+83-191 files not shown
+83-207 files

Illumos/gate f5512ffusr/src/uts/common/io/ena ena_tx.c, usr/src/uts/common/io/i40e i40e_transceiver.c i40e_stats.c

17210 meoi expectations broken by 17136

Change-Id: I6a6a636c2e66f8905bef4847c3d12d24cff20330
DeltaFile
+42-5usr/src/uts/common/io/igc/igc_ring.c
+25-0usr/src/uts/common/io/mac/mac_provider.c
+9-6usr/src/uts/common/io/i40e/i40e_transceiver.c
+6-1usr/src/uts/common/io/ena/ena_tx.c
+1-4usr/src/uts/common/io/vioif/vioif.c
+0-3usr/src/uts/common/io/i40e/i40e_stats.c
+83-191 files not shown
+83-207 files

Illumos/gate 39222beusr/src/uts/common/io/ib/ibtl ibtl_util.c

17168 ibtl: unsigned 'ibtf_errlevel' is never less than zero.
Reviewed by: Andrew Stormont <andyjstormont at gmail.com>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+2-6usr/src/uts/common/io/ib/ibtl/ibtl_util.c
+2-61 files

Illumos/gate 95682cdusr/src/uts/common/io/afe afe.c

17160 afe: variable dereferenced before check
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+8-8usr/src/uts/common/io/afe/afe.c
+8-81 files

Illumos/gate 8b184c1usr/src/cmd/dtrace/test/tst/common/print tst.anon.ksh.out tst.anon.c, usr/src/common/ctf ctf_types.c

17190 mdb should do better with anonymous structs and unions
17191 ctfdump should do better with anonymous structs and unions
13696 ctf_member_info() should support C11 anonymous SOUs
17189 make it easier to override ctftest debug flags
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+114-30usr/src/common/ctf/ctf_types.c
+106-0usr/src/test/util-tests/tests/mdb/progs/anon.c
+105-0usr/src/cmd/dtrace/test/tst/common/print/tst.anon.ksh.out
+97-0usr/src/test/util-tests/tests/mdb/sou/tst.anon.ksh
+89-0usr/src/cmd/dtrace/test/tst/common/print/tst.anon.c
+87-0usr/src/test/util-tests/tests/mdb/sou/tst.anon.ksh.out
+598-3023 files not shown
+1,172-10329 files

Illumos/gate e911ecbusr/src/cmd/dlstat dlstat.c, usr/src/lib/libdladm/common libdlstat.c libdlstat.h

16992 Memory leaks in dlstat
Reviewed by: Joshua M. Clulow <josh at sysmgr.org>
Reviewed by: Patrick Mooney <pmooney at pfmooney.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Vitaliy Gusev <gusev.vitaliy at gmail.com>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+12-10usr/src/lib/libdladm/common/libdlstat.c
+2-1usr/src/cmd/dlstat/dlstat.c
+1-0usr/src/lib/libdladm/common/libdlstat.h
+15-113 files

Illumos/gate ef292f3usr/src/cmd/fm/fmstat/common fmstat.c

17112 fmstat: impossible condition (use strtonumx)
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+1-1usr/src/cmd/fm/fmstat/common/fmstat.c
+1-11 files

Illumos/gate 85f582busr/src/uts/common/krtld kobj.c

17197 kobj_getsymname() should detect the standalone kernel
Reviewed by: Dan McDonald <danmcd at mnx.io>
Approved by: Patrick Mooney <pmooney at pfmooney.com>
DeltaFile
+6-0usr/src/uts/common/krtld/kobj.c
+6-01 files

Illumos/gate 02ed740usr/src/cmd/dtrace/test/tst/common Makefile, usr/src/cmd/dtrace/test/tst/common/ip msnc.c tst.localtcpstate.ksh

17188 dtest tst.localtcpstate.ksh regularly fails
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>~
Approved by: Patrick Mooney <pmooney at pfmooney.com>
DeltaFile
+133-0usr/src/cmd/dtrace/test/tst/common/ip/msnc.c
+5-20usr/src/cmd/dtrace/test/tst/common/ip/tst.localtcpstate.ksh
+3-20usr/src/cmd/dtrace/test/tst/common/ip/tst.ipv4remotetcp.ksh
+2-1usr/src/pkg/manifests/system-dtrace-tests.p5m
+2-0usr/src/cmd/dtrace/test/tst/common/Makefile
+145-415 files

Illumos/gate 680473dusr/src/lib/libdtrace/common dt_module.c

7093 libdtrace mangles userland struct keywords
Reviewed by: C Fraire <cfraire at me.com>
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Approved by: Patrick Mooney <pmooney at pfmooney.com>
DeltaFile
+112-22usr/src/lib/libdtrace/common/dt_module.c
+112-221 files

Illumos/gate c847df6usr/src/common/ctf ctf_create.c

17187 CTF creation should only have a single empty string
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Approved by: Patrick Mooney <pmooney at pfmooney.com>
DeltaFile
+10-3usr/src/common/ctf/ctf_create.c
+10-31 files

Illumos/gate f3410f4usr/src/uts/common/krtld kobj.c

17196 kobj: we should check the return code from kobj_boot_mountroot()
Reviewed by: Jason King <jason.brian.king+illumos at gmail.com>
Approved by: Patrick Mooney <pmooney at pfmooney.com>
DeltaFile
+10-9usr/src/uts/common/krtld/kobj.c
+10-91 files

Illumos/gate 8da72dbusr/src/pkg/manifests system-test-ostest.p5m, usr/src/test/os-tests/tests/mac_test mac_test.c Makefile

17136 want partial parsing in mac_ether_offload_info
17142 mac_ether_offload_info should detect fragments
17135 want ktest for mac_ether_offload_info
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Reviewed by: Kyle Simpson <kyle at oxide.computer>
Reviewed by: Dan McDonald <danmcd at mnx.io>
Approved by: Hans Rosenfeld <rosenfeld at grumpf.hope-2000.org>
DeltaFile
+525-156usr/src/uts/common/io/mac/mac_provider.c
+645-0usr/src/test/os-tests/tests/mac_test/mac_test.c
+315-1usr/src/uts/common/io/mac/mac_test.c
+50-0usr/src/test/os-tests/tests/mac_test/Makefile
+22-6usr/src/uts/common/sys/mac_provider.h
+2-0usr/src/pkg/manifests/system-test-ostest.p5m
+1,559-1631 files not shown
+1,560-1637 files

Illumos/gate 97088f6usr/src/cmd/modload modunload.c Makefile.com, usr/src/man/man8 modunload.8

17193 want modunload by name
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+125-66usr/src/man/man8/modunload.8
+114-62usr/src/cmd/modload/modunload.c
+53-14usr/src/uts/common/os/modctl.c
+9-7usr/src/cmd/modload/Makefile.com
+9-5usr/src/uts/common/sys/modctl.h
+310-1545 files

Illumos/gate 7633a05usr/src/cmd/cmd-inet/usr.bin/nc netcat.c, usr/src/man/man1 nc.1

16604 Add IPsec policy bypass for netcat
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Approved by: Patrick Mooney <pmooney at pfmooney.com>
DeltaFile
+32-2usr/src/cmd/cmd-inet/usr.bin/nc/netcat.c
+16-2usr/src/man/man1/nc.1
+48-42 files

Illumos/gate fed2821usr/src/lib/iconv_modules/utf-8 alias

17152 Import common IANA iconv aliases
1182 iconv should know about latinN aliases
17104 iconv should support IBM865
Reviewed by: C Fraire <cfraire at me.com>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+225-4usr/src/lib/iconv_modules/utf-8/alias
+225-41 files

Illumos/gate 915b015usr/src/lib/libnvme/common libnvme_phison.c

17155 want support for Phison X200 NVMe logs (missing file)
Reviewed by: Hans Rosenfeld <rosenfeld at grumpf.hope-2000.org>
Approved by: Patrick Mooney <pmooney at pfmooney.com>
DeltaFile
+44-0usr/src/lib/libnvme/common/libnvme_phison.c
+44-01 files

Illumos/gate fbd5b86usr/src/lib/libnvme/common libnvme_log.c libnvme_ocp.c, usr/src/uts/common/sys/nvme ocp.h phison.h

17153 NVMe log page discovery could check supported logs
17154 want support for Micron 9550 NVMe logs
17155 want support for Phison X200 NVMe logs
17156 want support for WDC SN861 NVMe logs
Reviewed by: C Fraire <cfraire at me.com>
Reviewed by: Hans Rosenfeld <rosenfeld at grumpf.hope-2000.org>
Approved by: Patrick Mooney <pmooney at pfmooney.com>
DeltaFile
+106-3usr/src/uts/common/sys/nvme/ocp.h
+101-6usr/src/lib/libnvme/common/libnvme_log.c
+50-0usr/src/uts/common/sys/nvme/phison.h
+49-0usr/src/uts/common/sys/nvme/wdc_sn861.h
+47-0usr/src/uts/common/sys/nvme/micron_9550.h
+32-1usr/src/lib/libnvme/common/libnvme_ocp.c
+385-1011 files not shown
+494-2517 files

Illumos/gate 1bebe61usr/src/cmd/svc/startd method.c

17165 svc/startd: variable dereferenced before check
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Approved by: Patrick Mooney <pmooney at pfmooney.com>
DeltaFile
+1-1usr/src/cmd/svc/startd/method.c
+1-11 files

Illumos/gate 1771e81usr/src/test/util-tests/tests/find findroot.ksh

17183 SID "findroot" test can temporarily enable idmap
Reviewed by: Toomas Soome <tsoome at me.com>
Reviewed by: Hans Rosenfeld <rosenfeld at grumpf.hope-2000.org>
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Approved by: Robert Mustacchi <rm at fingolfin.org>
DeltaFile
+18-0usr/src/test/util-tests/tests/find/findroot.ksh
+18-01 files

Illumos/gate adf881dusr/src/cmd/bhyve/common pci_virtio_viona.c

17148 viona wrongly rejects jumbo frames
Reviewed by: Kyle Simpson <kyle at oxide.computer>
Reviewed by: Dan McDonald <danmcd at mnx.io>
Approved by: Robert Mustacchi <rm at fingolfin.org>
DeltaFile
+36-1usr/src/cmd/bhyve/common/pci_virtio_viona.c
+36-11 files

Illumos/gate da16d43usr/src/uts/common/io/dld dld_drv.c

13992 VNIC in Zone loses access to properties
Reviewed by: Patrick Mooney <pmooney at pfmooney.com>
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Approved by: Robert Mustacchi <rm at fingolfin.org>
DeltaFile
+38-3usr/src/uts/common/io/dld/dld_drv.c
+38-31 files

Illumos/gate aaf7a49usr/src/cmd/svc/startd method.c

17175 SMF service log could be more helpful on exec failure
Reviewed by: Marco van Wieringen <marco.van.wieringen at planets.elm.net>
Reviewed by: Andrew Stormont <andyjstormont at gmail.com>
Reviewed by: Peter Tribble <peter.tribble at gmail.com>
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+4-0usr/src/cmd/svc/startd/method.c
+4-01 files

Illumos/gate fdc5332usr/src/cmd/fs.d fslib.c

17166 fs.d: variable dereferenced before check
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Reviewed by: Robert Mustacchi <rm at fingolfin.org>
Approved by: Dan McDonald <danmcd at mnx.io>
DeltaFile
+7-3usr/src/cmd/fs.d/fslib.c
+7-31 files

Illumos/gate 367731fusr/src/cmd/devmgmt/cmds devreserv.c devfree.c

17116 devmgmt: impossible condition
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Approved by: Robert Mustacchi <rm at fingolfin.org>
DeltaFile
+195-175usr/src/cmd/devmgmt/cmds/devreserv.c
+121-110usr/src/cmd/devmgmt/cmds/devfree.c
+316-2852 files

Illumos/gate 05e3992usr/src/cmd/power handlers.c

17113 power: impossible condition
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Approved by: Robert Mustacchi <rm at fingolfin.org>
DeltaFile
+6-5usr/src/cmd/power/handlers.c
+6-51 files

Illumos/gate ec7ed31usr/src/uts/common/fs/zfs dnode.c

17050 dnode_hold_impl() lockup
Portions contributed by: Andy Fiddaman <illumos at fiddaman.net>
Reviewed by: Joshua M. Clulow <josh at sysmgr.org>
Reviewed by: Dan McDonald <danmcd at mnx.io>
Reviewed by: Toomas Soome <tsoome at me.com>
Approved by: Robert Mustacchi <rm at fingolfin.org>
DeltaFile
+57-64usr/src/uts/common/fs/zfs/dnode.c
+57-641 files

Illumos/gate b645077usr/src/lib/smbclnt/libfksmbfs/common fake_fssub.c, usr/src/uts/common/fs/smbclnt/netsmb smb_rq.c

17121 smbclnt: impossible condition
Reviewed by: Andy Fiddaman <illumos at fiddaman.net>
Reviewed by: Bill Sommerfeld <sommerfeld at hamachi.org>
Approved by: Robert Mustacchi <rm at fingolfin.org>
DeltaFile
+2-2usr/src/uts/common/fs/smbclnt/netsmb/smb_rq.c
+1-1usr/src/lib/smbclnt/libfksmbfs/common/fake_fssub.c
+1-1usr/src/uts/common/fs/smbclnt/smbfs/smbfs_vnops.c
+4-43 files