BSD Commit Log Search

Fix stig unit test.  Update the compare.

(cherry picked from commit bb0a93263e07544a8a10e0671b4d8717e8da4596)

NAS-134795 / 25.10 / Fix stig unit test. (#16000)

The STIG unit test is failing because the recently added test used an
incorrect string. The test used the _source_ rule, but the `augenrules`
utility reformats the rule.

Updated the test to use the rule as formatted by `augenrules`.

The auditd rule is included in 25.04.0 and this test fix should be
backported accordingly.

NAS-134764 / 25.04.0 / Fix discrepancy between 2510 and 2504 virt pydantic models (by Qubad786) (#16001)

## Context

A small diff between 2504 and 2510 had leaked in backporting changes and
is being fixed.

Original PR: https://github.com/truenas/middleware/pull/15989
Jira URL: https://ixsystems.atlassian.net/browse/NAS-134764

Co-authored-by: M. Rehan <mrehanlm93 at gmail.com>

alphabetize the classes

NAS-134764 / 25.10 / Fix discrepancy between 2510 and 2504 virt pydantic models (#15989)

## Context

A small diff between 2504 and 2510 had leaked in backporting changes and
is being fixed.

grammar are hard

move filesystem.can_access_as_user to a private endpoint

NAS-134784 / 25.10 / convert system.general.timezone_choices to new API (#15996)

NAS-134783 / 25.10 / convert system.general.kbdmap_choices to new API (#15995)

This converts `system.general.kbdmap_choices` to new API and also
switches to parsing the `xml` provided file which is a better approach
for programmatically building this list.

typo

move filesystem_/perm_check.py to new API

convert system_general/ui.py to new API

remove language from system.general

Merge branch 'master' of https://github.com/truenas/middleware into NAS-133993

set defaults in zfs.snapshot methods

replace all occurences of zfs.snapshot with pool.snapshot in tests

conver system.general.timezone_choices to new API

fix typo

convert system.general.kbdmap_choices to new API

NAS-134781 / 25.04.0 / Standardize prefix for incus storage pool property (by anodos325) (#15994)

This commit fixes an issue with the incus storage pool ZFS user property
prefix and puts it in the enum of truenas-manaaged user properties.

Original PR: https://github.com/truenas/middleware/pull/15993
Jira URL: https://ixsystems.atlassian.net/browse/NAS-134781

Co-authored-by: Andrew Walker <awalker at ixsystems.com>

NAS-134777 / 25.04.0 / Fix copytree unit test failures (by anodos325) (#15992)

This commit changes to using a set comparison insted of list comparison
for directory contents.

Original PR: https://github.com/truenas/middleware/pull/15991
Jira URL: https://ixsystems.atlassian.net/browse/NAS-134777

Co-authored-by: Andrew Walker <awalker at ixsystems.com>

Standardize prefix for incus storage pool property

This commit fixes an issue with the incus storage pool ZFS
user property prefix and puts it in the enum of truenas-manaaged
user properties.

(cherry picked from commit 67f5f415a52d60d282c7844323071954a204b2b5)

NAS-134781 / 25.10 / Standardize prefix for incus storage pool property (#15993)

This commit fixes an issue with the incus storage pool ZFS user property
prefix and puts it in the enum of truenas-manaaged user properties.

Fix copytree unit test failures

This commit changes to using a set comparison insted of list
comparison for directory contents.

(cherry picked from commit ee0b9398c7005c13e7955904709152ea86cce93b)

NAS-134777 / 25.10 / Fix copytree unit test failures (#15991)

This commit changes to using a set comparison insted of list comparison
for directory contents.

Fix copytree unit test failures

This commit changes to using a set comparison insted of list
comparison for directory contents.

NAS-134443 / 25.04.0 / Make sure virt instance is stopped before attempting to delete it (by Qubad786) (#15990)

Make sure virt instance is stopped before attempting to delete it

(cherry picked from commit ff762ef7e18229a156c77f3b828dedd4c67b3d93)

NAS-134443 / 25.10 / Make sure virt instance is stopped before attempting to delete it (#15988)

## Problem

There has been a case where an incus instance was not able to delete
because incus complained that it can't delete a running instance. I have
not been able to reproduce it specifically but there was a case which
was being missed which was that if the instance is in `UNKNOWN` state
which it can be but very briefly - that can result in this issue.


## Solution

Make sure if instance is not stopped, we attempt to force stop it before
attempting deletion and if it fails (which it can if the instance is
already stopped, we just silently log it) and let deletion go through.

Fix discrepancy between 2510 and 2504 virt pydantic models