FreeBSD/src 00db5c7release Makefile, release/tools vmimage.subr

vmimage.subr: Redirect etcupdate log to stdout

While we're here, send the etcupdate log from generating base.txz
to stdout instead of /dev/null (see e972e408d19a) as well.

Reviewed by:    emaste, gordon, jrtc27
MFC after:      1 week
Sponsored by:   Amazon
Differential Revision:  https://reviews.freebsd.org/D48719

(cherry picked from commit ace4637ee0c666c6f5a1c664f8956f7302234edd)
DeltaFile
+2-1release/tools/vmimage.subr
+1-1release/Makefile
+3-22 files

FreeBSD/src 1dbcd9arelease Makefile, release/tools vmimage.subr

vmimage.subr: Redirect etcupdate log to stdout

While we're here, send the etcupdate log from generating base.txz
to stdout instead of /dev/null (see e972e408d19a) as well.

Reviewed by:    emaste, gordon, jrtc27
MFC after:      1 week
Sponsored by:   Amazon
Differential Revision:  https://reviews.freebsd.org/D48719

(cherry picked from commit ace4637ee0c666c6f5a1c664f8956f7302234edd)
DeltaFile
+2-1release/tools/vmimage.subr
+1-1release/Makefile
+3-22 files

FreeBSD/src 9ef38a0sys/kern uipc_usrreq.c

unix: remove always true check from uipc_attach

This is pr_attach method, it is always called on a newborn socket.  The
condition was always true at least since 6d32873c2930.
DeltaFile
+25-27sys/kern/uipc_usrreq.c
+25-271 files

FreeBSD/src 96dcff1sys/security/audit audit.c

audit/audit.c: fix typo KERNEL_PANICED->KERNEL_PANICKED

Noted by:       cy
Fixes:  53ece2bea9ffa654aaa50e (audit(9): do not touch VFS if  panicing)
MFC after:      3 days
DeltaFile
+1-1sys/security/audit/audit.c
+1-11 files

FreeBSD/src 8d4a464share/man/man4 tty.4

tty.4: correct description of header file

PR:     284596
MFC after:      3 days
DeltaFile
+1-1share/man/man4/tty.4
+1-11 files

FreeBSD/src 53ece2bsys/security/audit audit.c

audit(9): do not touch VFS if panicing

Reported by:    bz
DeltaFile
+2-1sys/security/audit/audit.c
+2-11 files

FreeBSD/src dc66be9sys/netinet/tcp_stacks bbr.c

TCP BBR: remove dead code

No functional change intended.

Reviewed by:            Peter Lei, rrs (earlier version)
CID:                    1523802
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D48341

(cherry picked from commit e7fbf52a3e38c4bc4249e6541fe7e42ecc119656)
DeltaFile
+0-4sys/netinet/tcp_stacks/bbr.c
+0-41 files

FreeBSD/src 3cf7769sys/netinet/tcp_stacks rack.c

TCP RACK: don't log an uninitialized value

reduce is uninitialized, if the code path for logging is reached via
goto old_method;.

Reviewed by:            rrs, Peter Lei
CID:                    1557359
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D48346

(cherry picked from commit 4c89d59e0cdac4d83fb5841aefae9214545b2273)
DeltaFile
+3-2sys/netinet/tcp_stacks/rack.c
+3-21 files

FreeBSD/src 8884446sys/netinet/tcp_stacks bbr.c

TCP BBR: remove dead code

No functional change intended.

Reviewed by:            rrs
CID:                    1523808
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D48338

(cherry picked from commit 061727efe1e355fb2fde1b05e92718543d05bfe7)
DeltaFile
+0-8sys/netinet/tcp_stacks/bbr.c
+0-81 files

FreeBSD/src 7edc7c8sys/netinet/tcp_stacks bbr.c

TCP BBR: remove dead code

bw is unsigned and not zero. So it cannot be smaller than 1.
No functional change intended.

Reviewed by:            rrs, cc
CID:                    1523791
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D48323

(cherry picked from commit c28fefe1dc44b69743dd18d038440da38a2867a7)
DeltaFile
+0-3sys/netinet/tcp_stacks/bbr.c
+0-31 files

FreeBSD/src 9698788sys/netinet/tcp_stacks rack.c

TCP RACK: fix TCP fast open

Do not jump to a place in the code, which requires several variables
to be set (segsize, minseg, idle, len, sb_offset), which is not true.
To avoid using these variables, start the HPTS timer explicitly.
This fix only applies to the client side using TCP fast open.

Approved by:            rrs
CID:                    1523766
CID:                    1523770
CID:                    1523786
CID:                    1523801
CID:                    1523809
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D48322

(cherry picked from commit bb9525f30214e8b6c53c6cccd9e8f02e8f8e8c42)
DeltaFile
+5-4sys/netinet/tcp_stacks/rack.c
+5-41 files

FreeBSD/src 264b7ddsys/netinet/tcp_stacks bbr.c

TCP BBR: remove code which is not needed

rc_bbr_substate is a 3-bit unsigned int, so it can't be larger than
or equal to 8. The wrap around already happens.
No functional change intended.

Reviewed by:            rrs
CID:                    1523795
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D48320

(cherry picked from commit 4bce1a19fcfac0c9f22c11278daa510546ccd3f2)
DeltaFile
+0-4sys/netinet/tcp_stacks/bbr.c
+0-41 files

FreeBSD/src dd78d98contrib/one-true-awk run.c FIXES, contrib/one-true-awk/testdir T.misc T.errmsg

ota:  Merge One True Awk 20250116 bsd-feature 2dce54b053d4

Jan 14, 2025
        Fix incorrect error line number issues. unput has
        no business managing lineno. Thanks to Ozan Yigit.

Jan 05, 2025
        Fix hex detection in is_valid_number.
        Fix indirect field specification with non-numeric string
        eg. $("foo") in indirect. This is not illegal.
        Thanks to Arnold Robbins.

Jan 01, 2025
        Fixed openfile to not try to read from a directory.
        Thanks to Arnold Robbins.

Sponsored by:           Netflix
DeltaFile
+10-5contrib/one-true-awk/run.c
+14-0contrib/one-true-awk/FIXES
+7-1contrib/one-true-awk/testdir/T.misc
+0-7contrib/one-true-awk/lex.c
+0-3contrib/one-true-awk/testdir/T.errmsg
+1-1contrib/one-true-awk/main.c
+32-171 files not shown
+33-187 files

FreeBSD/src 4f5788dsys/netinet/tcp_stacks bbr.c

TCP BBR: simplify expression

There is no need to check partially for bbr->r_ctl.crte being NULL,
since this can't be true in this path.
No functional change intended.

Reviewed by:            rrs
CID:                    1523810
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D48312

(cherry picked from commit 305c40dc552f9c150eacce95c181798031368cd9)
DeltaFile
+1-1sys/netinet/tcp_stacks/bbr.c
+1-11 files

FreeBSD/src ed530aasys/netinet/tcp_stacks bbr.c

TCP BBR: fix integer overflow

Use 64-bit arithmetic.

Reviewed by:            rrs
CID:                    1523806
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D48302

(cherry picked from commit 88766e7af52bbde32b14ad48fb76798a3ba4650c)
DeltaFile
+1-1sys/netinet/tcp_stacks/bbr.c
+1-11 files

FreeBSD/src 0d93b08sys/netinet/tcp_stacks bbr.c

TCP BBR: simplify expression

rsm cannot be NULL, when calling bbr_update_bbr_info().
So no need to check partially for it. No functional change intended.

Reviewed by:            rrs
CID:                    1523803
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D48293

(cherry picked from commit 4173a3a009a42c47f1ec2d1cbfb99347aaf195da)
DeltaFile
+1-1sys/netinet/tcp_stacks/bbr.c
+1-11 files

FreeBSD/src 0450ed7sys/netinet/tcp_stacks rack.c

TCP RACK: remove un-needed assignment

No functional change intended.

Reviewed by:            rrs
CID:                    1523768
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D48292

(cherry picked from commit deb4252e9e7c8d2eca9be6333caa434061f3f594)
DeltaFile
+0-1sys/netinet/tcp_stacks/rack.c
+0-11 files

FreeBSD/src f520318sys/netinet/tcp_stacks bbr.c

TCP BBR: do not log an uninitialized value

Reviewed by:            rrs
CID:                    1523789
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D48281

(cherry picked from commit c7e81cc04369dd7bdd00519109efe9d75f53375c)
DeltaFile
+1-1sys/netinet/tcp_stacks/bbr.c
+1-11 files

FreeBSD/src c8828fesys/netinet/tcp_stacks bbr.c

TCP BBR: remove code which is never executed

USEC_2_TICKS() returns at least 1.

Reviewed by:            rrs
CID:                    1523775
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D4827

(cherry picked from commit 1781324db2bc22a971a33c5a063036b2775055c6)
DeltaFile
+0-2sys/netinet/tcp_stacks/bbr.c
+0-21 files

FreeBSD/src 699d563sys/netinet/tcp_stacks bbr.c

TCP BBR: fix condition when sending a tail loss probe

Reviewed by:            rrs
CID:                    1523793
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D48274

(cherry picked from commit 5ec914e06c96ff40bf0e6567359c0de039b59ed2)
DeltaFile
+1-1sys/netinet/tcp_stacks/bbr.c
+1-11 files

FreeBSD/src 7db5c08sys/netinet/tcp_stacks rack.c

TCP RACK: add comment

Indicate that the missing of the break is intentionally.

Reviewed by:            rrs
CID:                    1523782
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D48273

(cherry picked from commit 0ce13b1d580f05f96e3d85afb0824f672cb0c7a2)
DeltaFile
+1-0sys/netinet/tcp_stacks/rack.c
+1-01 files

FreeBSD/src 1d39f58sys/netinet/tcp_stacks bbr.c

TCP BBR: fix getsockopt() for TCP_BBR_USEDEL_RATE

Actually implement the IPPROTO_TCP-level socket option
TCP_BBR_USEDEL_RATE.

Reviewed by:            rrs
CID:                    1523813
CID:                    1523814
Sponsored by:           Netflix, Inc.
Differential Revision:  https://reviews.freebsd.org/D48261

(cherry picked from commit b47dcb4b1ff16e6af2e07798f6fe06580b4eddf0)
DeltaFile
+6-2sys/netinet/tcp_stacks/bbr.c
+6-21 files

FreeBSD/src 986dc91sys/netpfil/pf pf_norm.c

pf: remove unused function

No functional change.

Sponsored by:   Rubicon Communications, LLC ("Netgate")
DeltaFile
+0-13sys/netpfil/pf/pf_norm.c
+0-131 files

FreeBSD/src 0cd9535tests/sys/netpfil/pf set_tos.sh

pf tests: extend set-tos test

Verify that we can set-tos on pass rules, and that this still works even if a
'scrub' option is present on the pass rule.

Sponsored by:   Rubicon Communications, LLC ("Netgate")
DeltaFile
+16-0tests/sys/netpfil/pf/set_tos.sh
+16-01 files

FreeBSD/src 0ae2ba5sbin/pfctl pfctl_parser.c

pfctl: remove unused variables

Sponsored by:   Rubicon Communications, LLC ("Netgate")
DeltaFile
+0-5sbin/pfctl/pfctl_parser.c
+0-51 files

FreeBSD/src 9e425a8usr.sbin/ctld login.c kernel.c

ctld: Move kernel_limits into login.c where it is used

Reviewed by:    asomers
Sponsored by:   Chelsio Communications
Differential Revision:  https://reviews.freebsd.org/D48771
DeltaFile
+61-1usr.sbin/ctld/login.c
+1-55usr.sbin/ctld/kernel.c
+2-6usr.sbin/ctld/ctld.h
+64-623 files

FreeBSD/src aa06023usr.sbin/ctld uclparse.c

ctld: Factor out functions to parse dscp and pcp properties

Reviewed by:    asomers
Sponsored by:   Chelsio Communications
Differential Revision:  https://reviews.freebsd.org/D48769
DeltaFile
+89-68usr.sbin/ctld/uclparse.c
+89-681 files

FreeBSD/src 4dfc255usr.sbin/ctladm ctladm.c

ctladm: Use nvlist instead of home-rolled name-value lists

Reviewed by:    asomers
Sponsored by:   Chelsio Communications
Differential Revision:  https://reviews.freebsd.org/D48774
DeltaFile
+55-72usr.sbin/ctladm/ctladm.c
+55-721 files

FreeBSD/src 7bad3c3usr.sbin/ctld ctld.c

ctld: Write the pidfile once after forking

Don't rewrite the pidfile each time main_loop is called.

PR:             284282
Reported by:    asomers
Reviewed by:    asomers
Sponsored by:   Chelsio Communications
Differential Revision:  https://reviews.freebsd.org/D48768
DeltaFile
+4-4usr.sbin/ctld/ctld.c
+4-41 files

FreeBSD/src 0a3e74fusr.sbin/ctld ctld.c

ctld: Don't specify the TCP port for default iSCSI portal group sockets

portal_group_add_listen already uses the default TCP port if no port
is specified so this was redundant.

Reviewed by:    asomers
Sponsored by:   Chelsio Communications
Differential Revision:  https://reviews.freebsd.org/D48770
DeltaFile
+2-2usr.sbin/ctld/ctld.c
+2-21 files