OPNSense/core 6d98acdsrc/etc/inc interfaces.inc, src/opnsense/mvc/app/controllers/OPNsense/Interfaces/forms dialogWireless.xml

Interfaces: Wireless: Devices - Migrate to MVC code, second phase, move settings from Interfaces into Wireless. closes https://github.com/opnsense/core/issues/10751 (#10796)

Move all settings from interface.XXX.wireless to wireless.clone and cleanup code referencing the old spot.

The console menu contained some, likely incomplete, code, which we will remove here as well, it doesn't feel very usefull trying to offer console configuration for wireless anyway.
Not all validations are being migrated, only the most relevant ones, which should be good enough.
DeltaFile
+0-999src/www/interfaces.php
+365-3src/opnsense/mvc/app/controllers/OPNsense/Interfaces/forms/dialogWireless.xml
+206-0src/opnsense/mvc/app/models/OPNsense/Interfaces/Wlan.xml
+35-136src/etc/inc/interfaces.inc
+101-0src/opnsense/mvc/app/models/OPNsense/Interfaces/Migrations/WLAN1_0_0.php
+100-0src/opnsense/mvc/app/models/OPNsense/Interfaces/Wlan.php
+807-1,1389 files not shown
+931-1,29915 files

OPNSense/core a009347src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogOneToOneRule.xml dialogNptRule.xml, src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes JsonAuditField.php

Merge branch 'master' into FR10751_WiFi
DeltaFile
+161-22src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/AliasNameField.php
+147-0src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/JsonAuditField.php
+75-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogSNatRule.xml
+74-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogOneToOneRule.xml
+74-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogNptRule.xml
+74-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
+605-2328 files not shown
+873-10734 files

OPNSense/core ef61fffsrc/opnsense/mvc/app/models/OPNsense/Firewall Filter.php

Syntactically received-on is valid for all directions, but it makes sense for out rules primarily. Validate to prevent weird user decisions here.
DeltaFile
+6-0src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.php
+6-01 files

OPNSense/core 9ac6e6esrc/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterController.php

Make sure the interface selectpicker also states it is only concerned about inbound
DeltaFile
+4-4src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+4-41 files

OPNSense/core b9fb460src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogFilterRule.xml, src/opnsense/mvc/app/models/OPNsense/Firewall Filter.xml

for single selections its BlankDesc and not hint for some reason
DeltaFile
+0-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
+1-0src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
+1-12 files

OPNSense/core 0415eedsrc/opnsense/mvc/app/controllers/OPNsense/Firewall FilterController.php, src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogFilterRule.xml

demote both interfacenot and received-on-not to advanced options
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
+1-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/FilterController.php
+2-22 files

OPNSense/core 7a6a6b8src/etc/inc interfaces.inc, src/opnsense/mvc/app/controllers/OPNsense/Interfaces/forms dialogWireless.xml

Interfaces: Wireless: Devices - Migrate to MVC code, second phase, move settings from Interfaces into Wireless. closes https://github.com/opnsense/core/issues/10751

Move all settings from interface.XXX.wireless to wireless.clone and cleanup code referencing the old spot.

The console menu contained some, likely incomplete, code, which we will remove here as well, it doesn't feel very usefull trying to offer console configuration for wireless anyway.
Not all validations are being migrated, only the most relevant ones, which should be good enough.
DeltaFile
+0-999src/www/interfaces.php
+365-3src/opnsense/mvc/app/controllers/OPNsense/Interfaces/forms/dialogWireless.xml
+206-0src/opnsense/mvc/app/models/OPNsense/Interfaces/Wlan.xml
+35-136src/etc/inc/interfaces.inc
+101-0src/opnsense/mvc/app/models/OPNsense/Interfaces/Migrations/WLAN1_0_0.php
+100-0src/opnsense/mvc/app/models/OPNsense/Interfaces/Wlan.php
+807-1,1389 files not shown
+931-1,29915 files

OPNSense/core d75cd17src/opnsense/mvc/app/views/layout_partials base_form.volt form_input_tr.volt

same for dialog, remove tooltips
DeltaFile
+7-3src/opnsense/mvc/app/views/layout_partials/base_dialog.volt
+2-2src/opnsense/mvc/app/views/layout_partials/form_input_tr.volt
+1-1src/opnsense/mvc/app/views/layout_partials/base_form.volt
+10-63 files

OPNSense/core f14ffb0src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogFilterRule.xml

invert should be ignored in grid
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
+1-11 files

OPNSense/core 209fa1dsrc/etc/inc interfaces.inc, src/opnsense/mvc/app/controllers/OPNsense/Interfaces/forms dialogWireless.xml

Interfaces: Wireless: Devices - Migrate to MVC code, second phase, move settings from Interfaces into Wireless. closes https://github.com/opnsense/core/issues/10751

Move all settings from interface.XXX.wireless to wireless.clone and cleanup code referencing the old spot.

The console menu contained some, likely incomplete, code, which we will remove here as well, it doesn't feel very usefull trying to offer console configuration for wireless anyway.
Not all validations are being migrated, only the most relevant ones, which should be good enough.
DeltaFile
+0-999src/www/interfaces.php
+365-3src/opnsense/mvc/app/controllers/OPNsense/Interfaces/forms/dialogWireless.xml
+206-0src/opnsense/mvc/app/models/OPNsense/Interfaces/Wlan.xml
+35-136src/etc/inc/interfaces.inc
+101-0src/opnsense/mvc/app/models/OPNsense/Interfaces/Migrations/WLAN1_0_0.php
+100-0src/opnsense/mvc/app/models/OPNsense/Interfaces/Wlan.php
+807-1,1389 files not shown
+930-1,29815 files

OPNSense/core 3f49343src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

Fix the header formatters for both interface types
DeltaFile
+4-1src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+4-11 files

OPNSense/core 32dc2a3src/opnsense/mvc/app/controllers/OPNsense/CaptivePortal/forms dialogZone.xml, src/opnsense/scripts/captiveportal cp-background-process.py

captive portal: exclude IPv4 from roaming logic

PR: GHSA-864r-q4j5-5mjq

(cherry picked from commit f46836d0c3d14e26d79214009bfbfa9a1eecab55)
(cherry picked from commit b7608362d7f2638bf1abcc47ad4817a6f9232d64)
DeltaFile
+27-2src/opnsense/scripts/captiveportal/cp-background-process.py
+1-1src/opnsense/mvc/app/controllers/OPNsense/CaptivePortal/forms/dialogZone.xml
+28-32 files

OPNSense/core f46836dsrc/opnsense/scripts/captiveportal cp-background-process.py

captive portal: exclude IPv4 from roaming logic

PR: GHSA-864r-q4j5-5mjq
DeltaFile
+27-2src/opnsense/scripts/captiveportal/cp-background-process.py
+27-21 files

OPNSense/core fbff1e7src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogFilterRule.xml

another name tweak (its complicated)
DeltaFile
+4-4src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
+4-41 files

OPNSense/core b760836src/opnsense/mvc/app/controllers/OPNsense/CaptivePortal/forms dialogZone.xml

captive portal: mark roaming option as IPv6-only

PR: GHSA-864r-q4j5-5mjq
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/CaptivePortal/forms/dialogZone.xml
+1-11 files

OPNSense/core 434d151src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogFilterRule.xml

Change interface to inbound interface
DeltaFile
+2-2src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
+2-21 files

OPNSense/core 24b8069src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogFilterRule.xml, src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

Some more name tweaking and add interface formatter
DeltaFile
+5-4src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
+4-1src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+9-52 files

OPNSense/core 1bf30c9src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogFilterRule.xml, src/opnsense/mvc/app/models/OPNsense/Firewall Filter.xml

Move received-on to interface settings
DeltaFile
+24-22src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
+9-9src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
+33-312 files

OPNSense/core 570b96dsrc/etc/inc interfaces.inc, src/opnsense/mvc/app/controllers/OPNsense/Interfaces/forms dialogWireless.xml

Interfaces: Wireless: Devices - Migrate to MVC code, second phase, move settings from Interfaces into Wireless. closes https://github.com/opnsense/core/issues/10751

Move all settings from interface.XXX.wireless to wireless.clone and cleanup code referencing the old spot.

The console menu contained some, likely incomplete, code, which we will remove here as well, it doesn't feel very usefull trying to offer console configuration for wireless anyway.
Not all validations are being migrated, only the most relevant ones, which should be good enough.
DeltaFile
+0-999src/www/interfaces.php
+365-3src/opnsense/mvc/app/controllers/OPNsense/Interfaces/forms/dialogWireless.xml
+182-1src/opnsense/mvc/app/models/OPNsense/Interfaces/Wireless.xml
+32-133src/etc/inc/interfaces.inc
+101-0src/opnsense/mvc/app/models/OPNsense/Interfaces/Migrations/WIFI1_0_0.php
+61-0src/opnsense/scripts/interfaces/list_regdomain.py
+741-1,1365 files not shown
+798-1,16611 files

OPNSense/core b1bd9a4src/etc/inc interfaces.inc, src/opnsense/mvc/app/controllers/OPNsense/Interfaces/forms dialogWireless.xml

Interfaces: Wireless: Devices - Migrate to MVC code, second phase, move settings from Interfaces into Wireless. for https://github.com/opnsense/core/issues/10751

Move all settings from interface.XXX.wireless to wireless.clone and cleanup code referencing the old spot.

console : seemed to show the parent interfaces, but without a useful implementation, removed it
DeltaFile
+0-999src/www/interfaces.php
+365-3src/opnsense/mvc/app/controllers/OPNsense/Interfaces/forms/dialogWireless.xml
+182-1src/opnsense/mvc/app/models/OPNsense/Interfaces/Wireless.xml
+32-133src/etc/inc/interfaces.inc
+101-0src/opnsense/mvc/app/models/OPNsense/Interfaces/Migrations/WIFI1_0_0.php
+61-0src/opnsense/scripts/interfaces/list_regdomain.py
+741-1,1365 files not shown
+798-1,16611 files

OPNSense/core 445533asrc/etc/inc interfaces.inc, src/opnsense/mvc/app/controllers/OPNsense/Interfaces/forms dialogWireless.xml

Interfaces: Wireless: Devices - Migrate to MVC code, second phase, move settings from Interfaces into Wireless. for https://github.com/opnsense/core/issues/10751

Move all settings from interface.XXX.wireless to wireless.clone and cleanup code referencing the old spot.

console : seemed to show the parent interfaces, but without a useful implementation, removed it
DeltaFile
+0-999src/www/interfaces.php
+365-3src/opnsense/mvc/app/controllers/OPNsense/Interfaces/forms/dialogWireless.xml
+182-1src/opnsense/mvc/app/models/OPNsense/Interfaces/Wireless.xml
+32-133src/etc/inc/interfaces.inc
+101-0src/opnsense/mvc/app/models/OPNsense/Interfaces/Migrations/WIFI1_0_0.php
+61-0src/opnsense/scripts/interfaces/list_regdomain.py
+741-1,1365 files not shown
+798-1,16611 files

OPNSense/core c4c48b0src/opnsense/mvc/app/views/layout_partials form_input_tr.volt base_form.volt

incomplete test
DeltaFile
+7-3src/opnsense/mvc/app/views/layout_partials/base_form.volt
+1-1src/opnsense/mvc/app/views/layout_partials/form_input_tr.volt
+8-42 files

OPNSense/core 79045e2src/etc/inc interfaces.inc, src/opnsense/mvc/app/controllers/OPNsense/Interfaces/forms dialogWireless.xml

Interfaces: Wireless: Devices - Migrate to MVC code, second phase, move settings from Interfaces into Wireless. for https://github.com/opnsense/core/issues/10751

Move all settings from interface.XXX.wireless to wireless.clone and cleanup code referencing the old spot.

console : seemed to show the parent interfaces, but without a useful implementation, removed it
DeltaFile
+0-999src/www/interfaces.php
+356-3src/opnsense/mvc/app/controllers/OPNsense/Interfaces/forms/dialogWireless.xml
+182-1src/opnsense/mvc/app/models/OPNsense/Interfaces/Wireless.xml
+32-133src/etc/inc/interfaces.inc
+101-0src/opnsense/mvc/app/models/OPNsense/Interfaces/Migrations/WIFI1_0_0.php
+61-0src/opnsense/scripts/interfaces/list_regdomain.py
+732-1,1364 files not shown
+788-1,16510 files

OPNSense/core 89fe70dsrc/etc/inc interfaces.inc, src/opnsense/mvc/app/controllers/OPNsense/Interfaces/forms dialogWireless.xml

Interfaces: Wireless: Devices - Migrate to MVC code, second phase, move settings from Interfaces into Wireless. for https://github.com/opnsense/core/issues/10751

Move all settings from interface.XXX.wireless to wireless.clone and cleanup code referencing the old spot.

console : seemed to show the parent interfaces, but without a useful implementation, removed it
DeltaFile
+0-999src/www/interfaces.php
+356-3src/opnsense/mvc/app/controllers/OPNsense/Interfaces/forms/dialogWireless.xml
+182-1src/opnsense/mvc/app/models/OPNsense/Interfaces/Wireless.xml
+32-133src/etc/inc/interfaces.inc
+101-0src/opnsense/mvc/app/models/OPNsense/Interfaces/Migrations/WIFI1_0_0.php
+61-0src/opnsense/scripts/interfaces/list_regdomain.py
+732-1,1364 files not shown
+788-1,16510 files

OPNSense/core b3047e4src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogNptRule.xml dialogFilterRule.xml, src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes JsonAuditField.php

Merge remote-tracking branch 'origin/master' into firewall-received-on
DeltaFile
+161-22src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/AliasNameField.php
+147-0src/opnsense/mvc/app/models/OPNsense/Base/FieldTypes/JsonAuditField.php
+75-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogSNatRule.xml
+74-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogNptRule.xml
+74-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
+74-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogDNatRule.xml
+605-2326 files not shown
+845-10432 files

OPNSense/core 1b601a1src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogSNatRule.xml, src/opnsense/mvc/app/library/OPNsense/Firewall SNatRule.php

Firewall: NAT: Source NAT: fix port alias and well known port usage in target_port (#10793)

* Firewall: NAT: Source NAT: fix port alias usage in target_port

* Add use statements for BooleanField and ProtocolField
DeltaFile
+22-6src/opnsense/mvc/app/library/OPNsense/Firewall/SNatRule.php
+12-1src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.php
+7-2src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/SourceNatRuleField.php
+1-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogSNatRule.xml
+2-0src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
+44-105 files

OPNSense/core 3114792src/opnsense/mvc/app/views/layout_partials form_input_tr.volt

revisit
DeltaFile
+5-5src/opnsense/mvc/app/views/layout_partials/form_input_tr.volt
+5-51 files

OPNSense/core 4489e19src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes SourceNatRuleField.php

Add use statements for BooleanField and ProtocolField
DeltaFile
+4-2src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/SourceNatRuleField.php
+4-21 files

OPNSense/core 48e1c7asrc/opnsense/mvc/app/views/layout_partials form_input_tr.volt

mvc: advanced marker for fields POC

Also adds tooltip for it and help button.
DeltaFile
+4-1src/opnsense/mvc/app/views/layout_partials/form_input_tr.volt
+4-11 files

OPNSense/core dc9ac31src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes AliasNameField.php

Firewall: Alias: Update internally reserved pf keywords (#10794)

* Firewall: Alias: Update internally reserved pf keywords

* Also add missing sprintf() in validation
DeltaFile
+161-22src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/AliasNameField.php
+161-221 files