OPNSense/core 0ac0583 — src/etc/inc filter.inc

set timeout should never print empty
DeltaFile
+5-3src/etc/inc/filter.inc
+5-31 files

OPNSense/core 0b54f3e — src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations MFP1_1_0.php MFP1_1_3.php

Guard if migrations fail and users already set new values, they should precede values the migration might set on a rerun
DeltaFile
+48-22src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_1_7.php
+23-7src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_0_9.php
+18-8src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_1_6.php
+15-7src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_1_5.php
+12-6src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_1_3.php
+9-5src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_1_0.php
+125-553 files not shown
+134-649 files

OPNSense/core d4db7f0 — src/etc/inc filter.lib.inc filter.inc, src/etc/inc/plugins.inc.d captiveportal.inc ipsec.inc

Fall back to safe defaults in case the settings array keys cannot be accessed if the migration did not run
DeltaFile
+37-35src/etc/inc/filter.inc
+14-13src/etc/inc/filter.lib.inc
+9-8src/opnsense/mvc/app/library/OPNsense/Firewall/Plugin.php
+6-5src/etc/inc/plugins.inc.d/pf.inc
+5-4src/etc/inc/plugins.inc.d/ipsec.inc
+4-4src/etc/inc/plugins.inc.d/captiveportal.inc
+75-693 files not shown
+84-789 files

OPNSense/core 8837a24 — src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api TunnelController.php, src/opnsense/mvc/app/controllers/OPNsense/IPsec/forms settings.xml

VPN: IPsec: Deprecate IKEv1 (#10925)
DeltaFile
+89-0src/opnsense/mvc/app/library/OPNsense/System/Status/IPsecIkev1Status.php
+20-1src/opnsense/mvc/app/views/OPNsense/IPsec/connections.volt
+16-1src/opnsense/mvc/app/views/OPNsense/IPsec/sessions.volt
+10-6src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/TunnelController.php
+6-6src/opnsense/mvc/app/controllers/OPNsense/IPsec/forms/settings.xml
+5-5src/opnsense/mvc/app/models/OPNsense/IPsec/Swanctl.xml
+146-194 files not shown
+154-2610 files

OPNSense/core 86cae77 — src/opnsense/mvc/app/library/OPNsense/Firewall ForwardRule.php

Firewall: NAT: Destination NAT - fix "Warning: Undefined variable $port in .."
DeltaFile
+1-1src/opnsense/mvc/app/library/OPNsense/Firewall/ForwardRule.php
+1-11 files

OPNSense/core 2cf8272 — src/etc/inc interfaces.inc, src/www interfaces.php

interfaces: remove direct $config access and improve device handover in legacy apply
DeltaFile
+9-13src/etc/inc/interfaces.inc
+3-1src/www/interfaces.php
+12-142 files

OPNSense/core b89172f — src/etc/inc filter.lib.inc interfaces.inc, src/opnsense/mvc/app/models/OPNsense/Interfaces NetworkInterface.xml

interfaces: remove PPTP support; closes #10973

To ease future migrations from PPP to MVC/API and reduce the
config field "localip" misuse we want to phase out PPTP and
reduce complexity of the implementation.

While L2TP may be still around the PPTP tunneling is very likely
not used anymore.  A bit of a message to everyone still using this.
Only one way to find out.
DeltaFile
+9-12src/etc/inc/interfaces.inc
+0-16src/etc/inc/filter.lib.inc
+1-6src/www/interfaces.php
+1-3src/www/interfaces_ppps_edit.php
+2-2src/opnsense/scripts/shell/banner.php
+1-2src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.xml
+14-416 files not shown
+19-4712 files

OPNSense/core 403435e — src/etc/inc interfaces.inc

Revert "interfaces: fallback here to prevent php warnings"

This reverts commit cda3b2f717fce26add61c147d1da0b0a0812c3eb.

these are stored by default now after save
DeltaFile
+2-2src/etc/inc/interfaces.inc
+2-21 files

OPNSense/core cda3b2f — src/etc/inc interfaces.inc

interfaces: fallback here to prevent php warnings

PHP Warning:  Undefined array key "localip" in /usr/local/etc/inc/interfaces.inc on line 1192
PHP Warning:  Undefined array key "gateway" in /usr/local/etc/inc/interfaces.inc on line 1196
DeltaFile
+2-2src/etc/inc/interfaces.inc
+2-21 files

OPNSense/core 3e73897 — src/opnsense/mvc/app/views/OPNsense/Unbound overview.volt

reporting: unbound: add dnssec status column in details grid (#10940)

PR: https://github.com/opnsense/core/issues/10704

(cherry picked from commit c6318dfbbdfcc79e7edbfc46f10ae6f878c32e1c)
(cherry picked from commit 384bd74f60cd5020ef06cdaaa0b79378c7c57c33)
DeltaFile
+18-11src/opnsense/mvc/app/views/OPNsense/Unbound/overview.volt
+18-111 files

OPNSense/core 466c9c5 — src/etc/inc/plugins.inc.d core.inc

system: $config is unused in core.inc

(cherry picked from commit f76beb8ff0aba6ca94fd7cdb612647359d594138)
DeltaFile
+0-5src/etc/inc/plugins.inc.d/core.inc
+0-51 files

OPNSense/core 649bcb2 — src/opnsense/mvc/app/models/OPNsense/Auth/FieldTypes UidField.php

mvc: UidField: allow reuse of UID 0 for system scope users
DeltaFile
+11-6src/opnsense/mvc/app/models/OPNsense/Auth/FieldTypes/UidField.php
+11-61 files

OPNSense/core cc0b292 — src/opnsense/mvc/app/models/OPNsense/Auth User.php

system: do not allow system scope users to be renamed

The previous check was about UID 0 and "root", but if we factor
in the "installer" user this construct falls apart.  Instead,
check for system scope and deny all field changes.
DeltaFile
+2-2src/opnsense/mvc/app/models/OPNsense/Auth/User.php
+2-21 files

OPNSense/core 786c2e0 — src/opnsense/mvc/app/controllers/OPNsense/Interfaces/forms dialogAssignment.xml, src/opnsense/mvc/app/models/OPNsense/Interfaces NetworkInterface.php NetworkInterface.xml

Interfaces: Assignments - add interface configuration settings in new assignments page

PR: https://github.com/opnsense/core/issues/10568 (#10740)

(cherry picked from commit 92cb28a6696d7ab3ffebb929560da1361b501192)
(cherry picked from commit 09c8df5c7ca51dbd24df80934b089bb634233db8)
(cherry picked from commit 6e4dab10429bcb4d05bac9321d1377cbbe63f5ed)
(cherry picked from commit 05a5ab8f83a697cca893554e8ebd2c65764271e8)
(cherry picked from commit d6a1f0118c94fa5c133d54e8cd5dafa6aaca98bb)
(cherry picked from commit 2f2d9892a0d64fb4c9839fe0ee14ce573f72959e)
(cherry picked from commit 3fad5a050483008c8e4e162175efa0991552c970)
(cherry picked from commit 857b29009bdcf7e0ed8b8966bc831e12430c7698)
(cherry picked from commit dfb019d9ab92145b1668ca125ce3eabbf66ec288)
(cherry picked from commit 17bc9256510dfafc0e5df5e14128b0d838431f4d)
(cherry picked from commit 8efb2fa645f2e35c85f3d87701562ab9c01997a1)
(cherry picked from commit 8de365a559f1fdb819bad6f96281c9f944f283f4)
(cherry picked from commit 70c5c92263fc4b9122cb284f4862810dd10751e6)
(cherry picked from commit c3100684f8a2a349e7183a2c86ea8f5f4dd1c084)
(cherry picked from commit 6b2026c70a3667351c194baa3f2de656165f040b)

    [12 lines not shown]
DeltaFile
+559-0src/opnsense/mvc/app/controllers/OPNsense/Interfaces/forms/dialogAssignment.xml
+330-0src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/Dhcp4SendOptionsField.php
+318-0src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/Dhcp4RequestOptionsField.php
+216-1src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.xml
+194-0src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/NetworkInterfaceField.php
+151-17src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.php
+1,768-1811 files not shown
+2,225-2817 files

OPNSense/core 384bd74 — src/opnsense/mvc/app/views/OPNsense/Unbound overview.volt

reporting: unbound: capitalize DNSSEC status column header
DeltaFile
+1-1src/opnsense/mvc/app/views/OPNsense/Unbound/overview.volt
+1-11 files

OPNSense/core 17ebc4e — src/opnsense/mvc/app/library/OPNsense/Core Config.php

Config: missing chown in backup call to prevent backend processes leaving unaccessible files for the frontend. closes https://github.com/opnsense/core/pull/10963

(cherry picked from commit 196cb9ab846fccb8446bb25e75fd1dd43a3e94bd)
DeltaFile
+7-1src/opnsense/mvc/app/library/OPNsense/Core/Config.php
+7-11 files

OPNSense/core 2bb36ab — src/opnsense/mvc/app/controllers/OPNsense/Routing/Api SettingsController.php

gateways: null is not going to be a UUID either

ErrorException: Using null as an array offset is deprecated, use an empty string instead in /usr/local/opnsense/mvc/app/controllers/OPNsense/Routing/Api/SettingsController.php:162
Stack trace:

(cherry picked from commit d7cc8e1c0f10f26d0696e74f6127eecea42b672e)
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/Routing/Api/SettingsController.php
+1-11 files

OPNSense/core 1177021 — . plist, src/etc/inc interfaces.inc

interfaces: backend call for interfaces_ppps_configure(); closes #9352
DeltaFile
+40-0src/opnsense/scripts/interfaces/reconfigure_ppp.php
+6-0src/opnsense/service/conf/actions.d/actions_interface.conf
+2-2src/etc/inc/interfaces.inc
+2-1src/www/interfaces_ppps_edit.php
+1-1src/www/interfaces_ppps.php
+1-0plist
+52-46 files

OPNSense/core d7cc8e1 — src/opnsense/mvc/app/controllers/OPNsense/Routing/Api SettingsController.php

gateways: null is not going to be a UUID either

ErrorException: Using null as an array offset is deprecated, use an empty string instead in /usr/local/opnsense/mvc/app/controllers/OPNsense/Routing/Api/SettingsController.php:162
Stack trace:
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/Routing/Api/SettingsController.php
+1-11 files

OPNSense/core dfc0759 — . plist, src/opnsense/scripts/interfaces apply_legacy_if_changes.php

interfaces: priv-sep script for interface apply the legacy way #9352
DeltaFile
+54-0src/opnsense/scripts/interfaces/apply_legacy_if_changes.php
+1-13src/www/interfaces.php
+6-0src/opnsense/service/conf/actions.d/actions_interface.conf
+1-0plist
+62-134 files

OPNSense/core cb005ef — src/etc/inc filter.lib.inc, src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms settings.xml

Firewall: Migrate Miscellaneous advanced settings (automatic rules)


DeltaFile
+0-105src/www/system_advanced_firewall.php
+70-0src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_1_6.php
+40-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/settings.xml
+16-15src/etc/inc/filter.lib.inc
+25-1src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
+3-3src/opnsense/mvc/app/models/OPNsense/Core/InitialSetup.php
+154-1247 files not shown
+165-13313 files

OPNSense/core 1236d85 — src/etc/inc filter.inc, src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms settings.xml

Firewall: Migrate remaining Miscellaneous advanced settings

Remove the legacy advanced firewall settings page.


DeltaFile
+0-472src/www/system_advanced_firewall.php
+106-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/settings.xml
+99-1src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
+98-0src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_1_7.php
+31-22src/etc/inc/filter.inc
+20-0src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.php
+354-4958 files not shown
+381-51714 files

OPNSense/core 6d82439 — . plist, src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms settings.xml

Firewall: Migrate NAT advanced settings to new settings page





DeltaFile
+64-0src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_1_0.php
+0-59src/www/system_advanced_firewall.php
+34-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/settings.xml
+13-1src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
+4-3src/opnsense/mvc/app/library/OPNsense/Firewall/Plugin.php
+1-0plist
+116-636 files

OPNSense/core 6e3269a — src/etc/inc system.inc, src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms settings.xml

Firewall: Migrate Multi-WAN advanced settings to new settings page





DeltaFile
+0-88src/www/system_advanced_firewall.php
+66-0src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_1_3.php
+28-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/settings.xml
+17-1src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
+8-6src/opnsense/mvc/app/models/OPNsense/Core/InitialSetup.php
+4-2src/etc/inc/system.inc
+123-976 files not shown
+135-10312 files

OPNSense/core de6d906 — . plist, src/etc/inc filter.inc

Firewall: Migrate Schedules advanced settings to new settings page





DeltaFile
+60-0src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_1_4.php
+0-25src/www/system_advanced_firewall.php
+10-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/settings.xml
+5-1src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
+1-1src/etc/inc/filter.inc
+1-0plist
+77-276 files

OPNSense/core 7c4953c — src/etc/inc/plugins.inc.d pf.inc, src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api SettingsController.php

Firewall: Migrate Bogon advanced settings to new settings page





DeltaFile
+60-0src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_1_1.php
+0-32src/www/system_advanced_firewall.php
+12-1src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
+3-5src/etc/inc/plugins.inc.d/pf.inc
+8-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/settings.xml
+3-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/SettingsController.php
+86-391 files not shown
+87-397 files

OPNSense/core 8ff71c1 — src/etc/inc filter.lib.inc, src/etc/inc/plugins.inc.d kea.inc

Firewall: Migrate Logging advanced settings to new settings page





DeltaFile
+68-0src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_1_5.php
+0-67src/www/system_advanced_firewall.php
+36-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/settings.xml
+23-1src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
+5-5src/etc/inc/filter.lib.inc
+4-5src/etc/inc/plugins.inc.d/kea.inc
+136-786 files not shown
+150-9012 files

OPNSense/core d0e8b32 — . plist, src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms settings.xml

Firewall: Migrate Gateway Monitoring advanced settings to new settings page





DeltaFile
+60-0src/opnsense/mvc/app/models/OPNsense/Firewall/Migrations/MFP1_1_2.php
+0-27src/www/system_advanced_firewall.php
+10-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/settings.xml
+5-1src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
+1-1src/opnsense/mvc/app/library/OPNsense/Firewall/Plugin.php
+1-0plist
+77-296 files

OPNSense/core 530ee0c — src/www interfaces.php

interfaces: remove system_routing_configure() #9352

The function is called via $reload hook so adding another
hook makes no sense.  This may have changed since the original
commit below and since we need to priv-sep these calls the
easiest way is to remove it.  ;)

See also: https://github.com/pfsense/pfsense/commit/8e11b23f541d
DeltaFile
+0-1src/www/interfaces.php
+0-11 files

OPNSense/core f76beb8 — src/etc/inc/plugins.inc.d core.inc

system: $config is unused in core.inc
DeltaFile
+0-5src/etc/inc/plugins.inc.d/core.inc
+0-51 files