System: Routes: Configuration - concurrency fix and small cleanups for https://github.com/opnsense/core/issues/10569
If we want to allow a single network being routed through multiple next hops, we should alter our cleanup to use the actual gateway instead of always dropping the destination network.
This change only uniforms how we collect that information from the ui and implements proper locking, the logic itself (drop network when altered or removed) isn't changed yet.
ui: sync expanded state for selected submenus
Noticed while reviewing https://github.com/opnsense/core/pull/10942
This will prevent two submenus being open at the same time regardless
of depth, which seemed to happen particularly on second-level submenus.
This will cause more shifting around, but this consistency is already
applied on the first-level submenu.
The alternative is to allow multiple second-level submenus open
at the same time and only close when switching top-level sections.
ui: sync expanded state for selected submenus
Noticed while reviewing https://github.com/opnsense/core/pull/10942
This will prevent two submenus being open at the same time regardless
of depth, which seemed to happen particularly on second-level submenus.
This will cause more shifting around, but this consistency is already
applied on the first-level submenu.
The alternative is to allow multiple second-level submenus open
at the same time and only close when switching top-level sections.
interfaces: remove the PPP uptime option
Was modified in 4d495ea6cc3d3c99366, f129c4682b2a et al. to a state where
the option could still be enabled but never read. The /conf bound historic
log is still filled but nothing reads it. Let's retire it for 27.1.
One other goal here is to reduce the incoming impact of a MVC/API rewrite.
Discussed with: @swhite2
interafces: PPPoE supports all IPv6 types
Only IPv4 prohibits use of 'staticv4' and 'dhcp'. In theory
even these could work but we don't want to push our luck.
interfaces: defer PPP to after bootup #10936
This is intended to fix bootup related issues with PPPoE, e.g. where it
retriggers DHCPv6 too many times. Essentially it's the same as deferring
the newwanip scripts, but one level below since mpd5 is much more allergic
to link state changes.
This also disables the CARP handling on bootup, but does not address
the backup starting up as well as the master. Essentially this is what
reconfigure_ppp.php is meant for.