OPNSense/core e1a0b4a — src/etc/inc interfaces.inc, src/sbin pluginctl

interfaces: split out interfaces_dependencies() and make it digestible via pluginctl -Q

This is a cherry-pick from master that retains the stable branch queue
ordering for now.  The parents are picked up via the shared functionality,
but the end result should still be the same as before.

(cherry picked from commit f9b24b852ba74d21c26b6c991548fe21d7131859)
DeltaFile
+62-56src/etc/inc/interfaces.inc
+6-3src/sbin/pluginctl
+68-592 files

OPNSense/core 1c7f05c — src/opnsense/mvc/app/views/OPNsense/Firewall nat_rule.volt filter_rule.volt, src/opnsense/mvc/app/views/OPNsense/Unbound overrides.volt

firewall: use fa elements for data tree controls to align with themes. Closes https://github.com/opnsense/core/issues/10892

(cherry picked from commit 506abed86ec7080b3b2a93a0d09b0c04af67fbaf)
(cherry picked from commit cf4a74309fff95a968774149d01ce293ffe78d83)
DeltaFile
+8-5src/opnsense/mvc/app/views/OPNsense/Firewall/nat_rule.volt
+8-5src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+2-2src/opnsense/mvc/app/views/OPNsense/Unbound/overrides.volt
+18-123 files

OPNSense/core 59b7aec — src/opnsense/service/templates/OPNsense/Monit monitrc

Services: Monit - merge most pressing part of https://github.com/opnsense/core/pull/10929 to avoid Monit complaining about an invalid config. for https://github.com/opnsense/core/issues/10928

We should rename logfile to log to prvent the deprecation messages, the rest of the PR needs some more work to align with the rest of the codebase.

(cherry picked from commit d05d8e19989d5dd30ae33ff216b3fdf6ade3eed7)
DeltaFile
+2-2src/opnsense/service/templates/OPNsense/Monit/monitrc
+2-21 files

OPNSense/core 045e62d — src/opnsense/scripts/interfaces capture.py

Interfaces: Diagnostics: Packet Capture - stricten archive command a bit further

(cherry picked from commit 3fde92805c03d0be4737fcc1d15dbb97ce35ceac)
DeltaFile
+1-1src/opnsense/scripts/interfaces/capture.py
+1-11 files

OPNSense/core 7441cc3 — src/etc/inc interfaces.inc

interfaces: make a note for some post-merge work still not done
DeltaFile
+1-0src/etc/inc/interfaces.inc
+1-01 files

OPNSense/core eff00b6 — src/etc/inc interfaces.lib.inc interfaces.inc

interfaces: skip pfsync interface reconfiguration if peer unchanged (#10924)

also check if mtu actually changes before applying it on pfsync0

(cherry picked from commit 95f552b3d6b765b47b271441cb616ed1d6d61bc6)
DeltaFile
+16-2src/etc/inc/interfaces.inc
+14-0src/etc/inc/interfaces.lib.inc
+30-22 files

OPNSense/core cf4a743 — src/opnsense/mvc/app/views/OPNsense/Firewall nat_rule.volt filter_rule.volt, src/opnsense/mvc/app/views/OPNsense/Unbound overrides.volt

ui: ditch font awesome 5 usage here

This also allows us to align the style better to what it was
DeltaFile
+2-2src/opnsense/mvc/app/views/OPNsense/Unbound/overrides.volt
+2-2src/opnsense/mvc/app/views/OPNsense/Firewall/nat_rule.volt
+2-2src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+6-63 files

OPNSense/core d05d8e1 — src/opnsense/service/templates/OPNsense/Monit monitrc

Services: Monit - merge most pressing part of https://github.com/opnsense/core/pull/10929 to avoid Monit complaining about an invalid config. for https://github.com/opnsense/core/issues/10928

We should rename logfile to log to prvent the deprecation messages, the rest of the PR needs some more work to align with the rest of the codebase.
DeltaFile
+2-2src/opnsense/service/templates/OPNsense/Monit/monitrc
+2-21 files

OPNSense/core 3fde928 — src/opnsense/scripts/interfaces capture.py

Interfaces: Diagnostics: Packet Capture - stricten archive command a bit further
DeltaFile
+1-1src/opnsense/scripts/interfaces/capture.py
+1-11 files

OPNSense/core 9862a88 — src/opnsense/www/js opnsense_ui.js

ui: make settings-changed overridable

(cherry picked from commit 1d92dcda25bb41644ccb809177cde6e4e326090e)
DeltaFile
+4-0src/opnsense/www/js/opnsense_ui.js
+4-01 files

OPNSense/core c4d8166 — src/opnsense/www/js opnsense_bootgrid.js

bootgrid: exclude header cells from status color rendering

(cherry picked from commit db0e230f0e999d89c659e8cddd6d68af646c8915)
DeltaFile
+1-1src/opnsense/www/js/opnsense_bootgrid.js
+1-11 files

OPNSense/core 3891a81 — src/opnsense/www/themes/opnsense-dark/assets/stylesheets main.scss, src/opnsense/www/themes/opnsense-dark/build/css main.css

ui: fix blank bottom UI space (#10375)

(cherry picked from commit 31633a4a8cdedc5a95c84a443b3872509667c964)
DeltaFile
+2-2src/opnsense/www/themes/opnsense/build/css/main.css
+2-2src/opnsense/www/themes/opnsense/assets/stylesheets/main.scss
+2-2src/opnsense/www/themes/opnsense-dark/build/css/main.css
+2-2src/opnsense/www/themes/opnsense-dark/assets/stylesheets/main.scss
+8-84 files

OPNSense/core cdde38b — src/opnsense/www/js tabulator.min.js.map tabulator.min.js

bootgrid: upgrade Tabulator to version 6.5.3
DeltaFile
+2-2src/opnsense/www/js/tabulator.min.js
+1-1src/opnsense/www/js/tabulator.min.js.map
+3-32 files

OPNSense/core 506abed — src/opnsense/mvc/app/views/OPNsense/Firewall nat_rule.volt filter_rule.volt

firewall: use fa elements for data tree controls to align with themes. Closes https://github.com/opnsense/core/issues/10892
DeltaFile
+8-5src/opnsense/mvc/app/views/OPNsense/Firewall/nat_rule.volt
+8-5src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+16-102 files

OPNSense/core 70c5c92 — src/etc/inc interfaces.inc, src/opnsense/scripts/interfaces apply_pending_if_changes.php

interfaces: use batch reload in apply_pending_if_changes.php

This approach may be useful for rc.linkup as well.  We basically
have all the code we need except for proper locking.
DeltaFile
+14-2src/opnsense/scripts/interfaces/apply_pending_if_changes.php
+1-1src/etc/inc/interfaces.inc
+15-32 files

OPNSense/core d35bdb0 — src/opnsense/mvc/app/views/OPNsense/Interface assignment.volt

interfaces: use 1d92dcda2 to customize the settings-changed trigger

This is not the final form, but it keeps the special page logic
contained herein while still being able to use the generic trigger.
DeltaFile
+8-4src/opnsense/mvc/app/views/OPNsense/Interface/assignment.volt
+8-41 files

OPNSense/core 1d92dcd — src/opnsense/www/js opnsense_ui.js

ui: make settings-changed overridable
DeltaFile
+4-0src/opnsense/www/js/opnsense_ui.js
+4-01 files

OPNSense/core db0e230 — src/opnsense/www/js opnsense_bootgrid.js

bootgrid: exclude header cells from status color rendering
DeltaFile
+1-1src/opnsense/www/js/opnsense_bootgrid.js
+1-11 files

OPNSense/core e7c800f — src/opnsense/mvc/app/controllers/OPNsense/Kea/forms dialogSubnet4.xml, src/opnsense/mvc/app/models/OPNsense/Kea KeaDhcpv4.xml KeaDhcpv6.php

Services: Kea DHCPv4: add ping check settings (libdhcp_ping_check.so) for subnet configuration (#10903)

(cherry picked from commit 88c0d87e2a30a5540e8ddb1984a436678db530ae)
(cherry picked from commit e007fd114432ca5d54af1b602cedb70544aae703)
(cherry picked from commit 160417ddb7bbcdfa5eb2d4ed191ca0f06f2f1b45)
(cherry picked from commit 0eb4edd8fe84ed3c05172746540d38e04a8c3d30)
DeltaFile
+22-6src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.php
+13-13src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php
+11-0src/opnsense/mvc/app/controllers/OPNsense/Kea/forms/dialogSubnet4.xml
+5-1src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv4.xml
+2-1src/opnsense/scripts/kea/kea_prefix_renew.py
+53-215 files

OPNSense/core 45f366e — src/www interfaces.php

interfaces: retire these problematic validations

ISC DHCP is no longer installed by default and mostly not installed
on newer installations.  However, people tend to use older backups
and the server may be enabled still.  The alternative would be to
add a plugin check, but I don't really see the point in dragging this
on.

PR: https://forum.opnsense.org/index.php?topic=48181.0
(cherry picked from commit 67a0184458b3d2a5a7a7a805f87e07be59e0208c)
DeltaFile
+0-7src/www/interfaces.php
+0-71 files

OPNSense/core 2192399 — src/opnsense/mvc/app/models/OPNsense/Interfaces NetworkInterface.php

interfaces: save fields that don't matter to operation directly

This ignores the fields from the compare.  There's still an issue
with the banner showing the apply message when no apply is needed
(and no todo file is added).  This needs to be fixed in the UI,
but needs more glue first.
DeltaFile
+4-2src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.php
+4-21 files

OPNSense/core 7e5c288 — src/opnsense/mvc/app/models/OPNsense/Interfaces NetworkInterface.php

interfaces: compare first, then call the real toLegacy() when needed

Saves a few cycles after we have to pull the data twice.
DeltaFile
+33-28src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.php
+33-281 files

OPNSense/core 8de365a — src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api AssignmentController.php, src/opnsense/mvc/app/models/OPNsense/Interfaces NetworkInterface.php

interfaces: make toLegacy() return the real legacy config

Addresses the workaround of 17bc9256510 which makes the resulting
code a bit more condensed and failsafe.
DeltaFile
+20-30src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/AssignmentController.php
+37-1src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/NetworkInterfaceField.php
+2-27src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.php
+5-24src/opnsense/scripts/interfaces/apply_pending_if_changes.php
+64-824 files

OPNSense/core 4abce6a — src/opnsense/mvc/app/models/OPNsense/Interfaces NetworkInterface.php

interfaces: save fields that don't matter to operation directly

This ignores the fields from the compare.  There's still an issue
with the banner showing the apply message when no apply is needed
(and no todo file is added).  This needs to be fixed in the UI,
but needs more glue first.
DeltaFile
+4-2src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.php
+4-21 files

OPNSense/core 6da4e53 — src/opnsense/mvc/app/views/OPNsense/Core backup_history.volt

core/backup: Backup History add data-live-search to providers selectpicker, Fixes: #10742

(cherry picked from commit b7f6e900cc2860cafe05aa4d3f51dafb0639f8e3)
DeltaFile
+1-1src/opnsense/mvc/app/views/OPNsense/Core/backup_history.volt
+1-11 files

OPNSense/core 9aae50e — src/etc/inc/plugins.inc.d core.inc

filter:aliases - wrong expiry default when set to < 3600 seconds. closes https://github.com/opnsense/core/issues/10917

(cherry picked from commit b73655551b82aac5634bf23cb5d093f641e7f32b)
DeltaFile
+2-0src/etc/inc/plugins.inc.d/core.inc
+2-01 files

OPNSense/core 56af126 — src/opnsense/mvc/app/models/OPNsense/Interfaces NetworkInterface.php

interfaces: compare first, then call the real toLegacy() when needed

Saves a few cycles after we have to pull the data twice.
DeltaFile
+33-28src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.php
+33-281 files

OPNSense/core 4d24aa5 — src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api AssignmentController.php, src/opnsense/mvc/app/models/OPNsense/Interfaces NetworkInterface.php

interfaces: make toLegacy() return the real legacy config

Addresses the workaround of 17bc9256510 which makes the resulting
code a bit more condensed and failsafe.
DeltaFile
+20-30src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/AssignmentController.php
+37-1src/opnsense/mvc/app/models/OPNsense/Interfaces/FieldTypes/NetworkInterfaceField.php
+2-27src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.php
+5-22src/opnsense/scripts/interfaces/apply_pending_if_changes.php
+64-804 files

OPNSense/core 31633a4 — src/opnsense/www/themes/opnsense-dark/assets/stylesheets main.scss, src/opnsense/www/themes/opnsense-dark/build/css main.css

ui: fix blank bottom UI space (#10375)
DeltaFile
+2-2src/opnsense/www/themes/opnsense/build/css/main.css
+2-2src/opnsense/www/themes/opnsense/assets/stylesheets/main.scss
+2-2src/opnsense/www/themes/opnsense-dark/build/css/main.css
+2-2src/opnsense/www/themes/opnsense-dark/assets/stylesheets/main.scss
+8-84 files

OPNSense/core 95f552b — src/etc/inc interfaces.lib.inc interfaces.inc

interfaces: skip pfsync interface reconfiguration if peer unchanged (#10924)

also check if mtu actually changes before applying it on pfsync0
DeltaFile
+16-2src/etc/inc/interfaces.inc
+14-0src/etc/inc/interfaces.lib.inc
+30-22 files