interfaces: use batch reload in apply_pending_if_changes.php
This approach may be useful for rc.linkup as well. We basically
have all the code we need except for proper locking.
interfaces: use 1d92dcda2 to customize the settings-changed trigger
This is not the final form, but it keeps the special page logic
contained herein while still being able to use the generic trigger.
interfaces: retire these problematic validations
ISC DHCP is no longer installed by default and mostly not installed
on newer installations. However, people tend to use older backups
and the server may be enabled still. The alternative would be to
add a plugin check, but I don't really see the point in dragging this
on.
PR: https://forum.opnsense.org/index.php?topic=48181.0
(cherry picked from commit 67a0184458b3d2a5a7a7a805f87e07be59e0208c)
interfaces: save fields that don't matter to operation directly
This ignores the fields from the compare. There's still an issue
with the banner showing the apply message when no apply is needed
(and no todo file is added). This needs to be fixed in the UI,
but needs more glue first.
interfaces: make toLegacy() return the real legacy config
Addresses the workaround of 17bc9256510 which makes the resulting
code a bit more condensed and failsafe.
interfaces: save fields that don't matter to operation directly
This ignores the fields from the compare. There's still an issue
with the banner showing the apply message when no apply is needed
(and no todo file is added). This needs to be fixed in the UI,
but needs more glue first.
interfaces: make toLegacy() return the real legacy config
Addresses the workaround of 17bc9256510 which makes the resulting
code a bit more condensed and failsafe.
interfaces: make toLegacy() return the real legacy config
Addresses the workaround of 17bc9256510 which makes the resulting
code a bit more condensed and failsafe.
interfaces: sync all configration before running configure loop
dhcpv6 depends on WAN<->LAN relationships which need a sync of
the whole interface config first.
While here enable output for diagnostic purposes when running
the script from the shell.
interfaces: offload $legacybools and $legacyempties to NetworkInterface model; closes #10918
So we can fix the mocked $config apply in apply_pending_if_changes.php.
Ideally, toLegacy() should already do this and we just replace the whole
interface section in the script.
