Revert "firewall: fix loopback address in private defintions; closes #10694"
This reverts commit 9bac2b8a75f3f218e252a1ca2092c2566291790f.
Since we want to get rid of treating loopback as private and push it to
bogons and this was already broken do not try to repair it.
firewall: remove handling looback addresses as "private"
Loopbacks are not "private" in the traditional sense and will be handled
by bogons in the near future to more closely align with the upstream bogon
source.
Interfaces: split media and mediaopt with tabs instead of spaces as spaces may exist in the actual output.
(cherry picked from commit d740eecdbfe0e39beccd771e704f28f9493e84f1)
interfaces: bring WLAN and MPD5 loading/reset points closer together
Largely these fill the same need: we run a daemon on that interface
(or a daemon that will create the software interface). Since WLAN
clones are created and reloaded earlier we are not bound to a random
place in the configure function and can eventually add a plugin hook
for this if it makes sense.
While here push the $linkup workaround down and add a comment on
why it is still needed. It would be nicer not having it but the
situation is pretty tough if the historic situation did not change.
interfaces: interfaces_wlan_clone() is already plugged
This means we call it during device creation and reloading, which
means we can remove it from interafaces_wlan_configure() so it loses
another side effect. Just needs the reconfigure script to run the
full configuration loop then.
While here unify the function syntax to interfaces_wlan_*().
interfaces: return an empty string which cannot be an interface in convert_real_interface_to_friendly_interface_name()
(cherry picked from commit 9892d2852e863b2430841468467581c7d9baf333)
openvpn: legacy CARP hook abort on empty interface
This can be moved to the plugin. Before we do that, however,
rename the file to make this more obvious since it was missed
up until now.
interfaces: return an empty string which cannot be an interface in convert_real_interface_to_friendly_interface_name()
Recent PHP warns on using a null index to an array anyway. This
folds nicely into config_read_array() use.
