OPNSense/core 551c4bcsrc/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

Firewall: Rules [new]: Theory for race condition during selectpicker population
DeltaFile
+22-0src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+22-01 files

OPNSense/core 40cb821src/opnsense/mvc/app/models/OPNsense/Base BaseModel.php

mvc: BaseModel - improve legacy mapper support when parent item doesn't exist.

Fixes:

ErrorException: Undefined array key 0 in /usr/local/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php:755
Stack trace:

If we can't find the specified root node, we should create one, which is similar to non legacy mapper nodes.
DeltaFile
+9-1src/opnsense/mvc/app/models/OPNsense/Base/BaseModel.php
+9-11 files

OPNSense/core 2a750e1src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

Firewall: Rules [new]: Theory for race condition during selectpicker population
DeltaFile
+15-6src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+15-61 files

OPNSense/core 5276f51src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/Api LeasesController.php

dnsmasq: Compare lower case strings only in leases to fix edge cases in is_reserved detection (#9714)

DeltaFile
+6-8src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/Api/LeasesController.php
+6-81 files

OPNSense/core 0329175src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/Api LeasesController.php

dnsmasq: Compare lower case strings only in leases to fix edge cases in is_reserved detection
DeltaFile
+6-8src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/Api/LeasesController.php
+6-81 files

OPNSense/core 7ae42d9src/opnsense/scripts/firmware upgrade.sh

firmware: do not fail upgrade if new kernel is already booted

PR: https://forum.opnsense.org/index.php?topic=50654.0
DeltaFile
+2-0src/opnsense/scripts/firmware/upgrade.sh
+2-01 files

OPNSense/core 94d8a11src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterController.php

Shuffle is_if condition around for clarity
DeltaFile
+2-2src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+2-21 files

OPNSense/core d048419src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterController.php, src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

Turn __* into __any
DeltaFile
+3-3src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+1-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+4-42 files

OPNSense/core 0935abbsrc/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

Remove some unneeded newlines
DeltaFile
+0-3src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+0-31 files

OPNSense/core 0ba302dsrc/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

That comment went missing
DeltaFile
+1-1src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+1-11 files

OPNSense/core 1b42262src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterController.php, src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

Some more style
DeltaFile
+9-9src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+0-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+9-102 files

OPNSense/core defe87fsrc/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

Style
DeltaFile
+0-1src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+0-11 files

OPNSense/core c3bb8b5src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterController.php

Lower diff in controller by folding null case into is_if
DeltaFile
+5-9src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+5-91 files

OPNSense/core b8bf4afsrc/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterController.php

Change label from any to floating (for floating)
DeltaFile
+1-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+1-11 files

OPNSense/core 15ef4besrc/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterController.php, src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

To fix URL hash weirdness, it's best to special case __floating and __* in the frontend
DeltaFile
+17-16src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+2-2src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+19-182 files

OPNSense/core 3dd547csrc/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

Interface select default only on null or no match, not on empty string
DeltaFile
+1-1src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+1-11 files

OPNSense/core e6e59fasrc/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterController.php, src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

Firewall - Rules [new]: Add all rules option to interface selectpicker and select it by default
DeltaFile
+33-10src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+14-3src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+47-132 files

OPNSense/core 9b67006src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

Select all rules as default
DeltaFile
+4-0src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+4-01 files

OPNSense/core 2fc37d5src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterController.php, src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt

Firewall - Rules [new]: Add all rules option to interface selectpicker
DeltaFile
+29-6src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+10-3src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+39-92 files

OPNSense/core 8a1614csrc/etc/inc/plugins.inc.d openssh.inc

openssh: style update for config generation

(cherry picked from commit 47be95b7ffe31b34e99b45c1464819e8848edf73)
(cherry picked from commit d11320bb42d280586e8647c1f1a13e7e1b94a0d3)
(cherry picked from commit c3dd6d56f1d2b64eab3ed761014c1cb836f6dcf2)
DeltaFile
+9-16src/etc/inc/plugins.inc.d/openssh.inc
+9-161 files

OPNSense/core c3dd6d5src/etc/inc/plugins.inc.d openssh.inc

openssh: minor style tweak
DeltaFile
+1-1src/etc/inc/plugins.inc.d/openssh.inc
+1-11 files

OPNSense/core d01c4d7Mk lint.mk, Scripts class-filename.sh

make: add a linter for PHP class name consistency #9638

(cherry picked from commit cff4c085d3e5d6236915c60d1dfb21e1796b3af8)
DeltaFile
+52-0Scripts/class-filename.sh
+4-1Mk/lint.mk
+56-12 files

OPNSense/core dbc0af5src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api ManualSpdController.php, src/opnsense/mvc/app/controllers/OPNsense/Interfaces VxlanController.php

mvc: use linter to find two wrong class names; closes #9638

(cherry picked from commit 9e70ee7508f70591bd84a0aee81293c435e949e2)
(cherry picked from commit b95c81d08d9e6d48ba9b01f0ca8cebafafc6ddd3)
(cherry picked from commit e771a800d5cd701d8d4cb6786f52b3989e0f1858)
DeltaFile
+2-2src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/ManualSpdController.php
+1-1src/opnsense/mvc/app/controllers/OPNsense/Interfaces/VxlanController.php
+3-32 files

OPNSense/core e771a80. plist, src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api ManualSpdController.php ManualSPDController.php

ipsec: same same, switch class name not file name
DeltaFile
+71-0src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/ManualSpdController.php
+0-71src/opnsense/mvc/app/controllers/OPNsense/IPsec/Api/ManualSPDController.php
+1-1plist
+72-723 files

OPNSense/core b95c81d. plist, src/opnsense/mvc/app/controllers/OPNsense/Interfaces VxlanController.php VxLanController.php

interfaces: class name was wrong, fix UI page link
DeltaFile
+39-0src/opnsense/mvc/app/controllers/OPNsense/Interfaces/VxlanController.php
+0-39src/opnsense/mvc/app/controllers/OPNsense/Interfaces/VxLanController.php
+1-1plist
+40-403 files

OPNSense/core 45846bfsrc/opnsense/scripts/kea kea_prefix_watcher.py

dhcp/kea: Use hostdiscovery service as ndp source in kea_prefix_watcher script (#9648)

* Use hostdiscovery service as ndp source in kea_prefix_watcher script via list_hosts.py, only request IPv6 addresses, fall back to ndp when hostdiscovery is not running

(cherry picked from commit c827a02ef6ce0aa12ee54c24e6f538e118dda54d)
DeltaFile
+18-14src/opnsense/scripts/kea/kea_prefix_watcher.py
+18-141 files

OPNSense/core 338ddeesrc/www firewall_scrub_edit.php firewall_rules_edit.php

firewall: ancient copy+paste error in scrub rules

(cherry picked from commit 4c559a63d42cfcda83440a60f6e6321ed595976e)
(cherry picked from commit e2d95ad6728e654bf195455edf45852c025ddbd5)
DeltaFile
+1-1src/www/firewall_scrub_edit.php
+1-1src/www/firewall_rules_edit.php
+2-22 files

OPNSense/core ae1e703src/etc/inc system.inc

system: Persian into production mode

(cherry picked from commit fce3f7973a5dc24a3577f660b9e58b95f49adf96)
DeltaFile
+0-1src/etc/inc/system.inc
+0-11 files

OPNSense/core 69e7e57src/opnsense/mvc/app/models/OPNsense/Kea KeaDhcpv6.php

kea: add several missing validation

PR: https://github.com/opnsense/core/issues/9343

(cherry picked from commit b6a59bb7e55793ed5ddc75d440ecfe67ae10663f)
(cherry picked from commit fcab636a4cb8238977335ceb684b2f6714e7a489)
(cherry picked from commit 83f9492087df23f591072e595eefb0b29b33d7db)
DeltaFile
+25-0src/opnsense/mvc/app/models/OPNsense/Kea/KeaDhcpv6.php
+25-01 files

OPNSense/core 7f1abcdsrc/opnsense/mvc/app/controllers/OPNsense/Diagnostics/forms ping.xml, src/opnsense/mvc/app/models/OPNsense/Diagnostics Ping.xml

Interfaces: Diagnostics: Ping - add optional interval (seconds), closes https://github.com/opnsense/core/issues/9695

(cherry picked from commit c6540bf6fa5c2d6c3a4eddaf0bb6be8fb5a531af)
DeltaFile
+7-0src/opnsense/mvc/app/controllers/OPNsense/Diagnostics/forms/ping.xml
+4-0src/opnsense/mvc/app/models/OPNsense/Diagnostics/Ping.xml
+3-0src/opnsense/scripts/interfaces/ping.py
+14-03 files