OPNSense/core 2c1d5cbsrc/opnsense/mvc/app/library/OPNsense/Firewall FilterRule.php

Firewall: Rules [new] - missing reply-to when not specifically set, closes https://github.com/opnsense/core/issues/9761

(cherry picked from commit e98e55ede5dffb109a11a979a49b9c2b37f931d4)
DeltaFile
+1-1src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php
+1-11 files

OPNSense/core e98e55esrc/opnsense/mvc/app/library/OPNsense/Firewall FilterRule.php

Firewall: Rules [new] - missing reply-to when not specifically set, closes https://github.com/opnsense/core/issues/9761
DeltaFile
+1-1src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php
+1-11 files

OPNSense/core b2aae25src/opnsense/www/js opnsense_ui.js

mvc:javascript:SimpleFileUploadDlg() - add download button for validation errors, closes https://github.com/opnsense/core/issues/9760

When uploading a file results in validation messages, add a download button to dump the results into a csv file as well.
Since our javascript code doesn't translate very well, only add an icon and skip the title text for simplicity.
DeltaFile
+22-1src/opnsense/www/js/opnsense_ui.js
+22-11 files

OPNSense/core 766c6cesrc/etc/inc/plugins.inc.d unbound.inc, src/opnsense/mvc/app/controllers/OPNsense/Unbound/forms dialogHostOverride.xml

Services: Unbound DNS: Overrides - persist PTR configuration and allow the user to deselect it, closes https://github.com/opnsense/core/pull/9753
DeltaFile
+5-5src/etc/inc/plugins.inc.d/unbound.inc
+9-0src/opnsense/mvc/app/controllers/OPNsense/Unbound/forms/dialogHostOverride.xml
+5-1src/opnsense/mvc/app/models/OPNsense/Unbound/Unbound.xml
+3-0src/opnsense/mvc/app/views/OPNsense/Unbound/overrides.volt
+22-64 files

OPNSense/core ccffd88src/opnsense/mvc/app/controllers/OPNsense/Kea DhcpController.php

Services: Kea DHCP: Kea DHCPv4/6 / Subnets - missing root node, closes https://github.com/opnsense/core/issues/9762
DeltaFile
+2-2src/opnsense/mvc/app/controllers/OPNsense/Kea/DhcpController.php
+2-21 files

OPNSense/core 68ff0dcsrc/opnsense/mvc/app/controllers/OPNsense/Routing/forms dialogEditGateway.xml

System: Gateways: Configuration - remove "upstream" from grid as priority already reflects the proper data, closes https://github.com/opnsense/core/issues/9751

The grid was added in https://github.com/opnsense/core/commit/7f9d1046639d5bea43f24ef80dadef913b54b739, but shouldn't have been due to type issues of the raw field, see also https://github.com/opnsense/core/commit/8069d72bacc651b0506a1a093d5206008f92731e
DeltaFile
+1-3src/opnsense/mvc/app/controllers/OPNsense/Routing/forms/dialogEditGateway.xml
+1-31 files

OPNSense/core c7d85desrc/opnsense/mvc/app/models/OPNsense/Base/Menu MenuSystem.php

Revert "Services: ISC DHCPv4: hide menu items when dnsmasq is enabled to improve "out of the box" experience. closes https://github.com/opnsense/core/issues/8329"

We are not hiding v6 now and since ISC-DHCP is not in the core system
we can go back to the normal way.

This reverts commit 0d6aa56527c60be14e6e626e5d0728108110cf2f.

PR: https://www.reddit.com/r/opnsense/comments/1qxqru9/comment/o42nx7v/
DeltaFile
+1-25src/opnsense/mvc/app/models/OPNsense/Base/Menu/MenuSystem.php
+1-251 files

OPNSense/core 573dd33src/etc/inc filter.lib.inc

Firewall: NAT: Destination NAT - use "local-port" as target when specified, closes https://github.com/opnsense/core/issues/9750

(cherry picked from commit c56f89b756b186f4bf590ff3915145df74b37c48)
DeltaFile
+3-0src/etc/inc/filter.lib.inc
+3-01 files

OPNSense/core c56f89bsrc/etc/inc filter.lib.inc

Firewall: NAT: Destination NAT - use "local-port" as target when specified, closes https://github.com/opnsense/core/issues/9750
DeltaFile
+3-0src/etc/inc/filter.lib.inc
+3-01 files

OPNSense/core cd409c5src/opnsense/mvc/app/library/OPNsense/Firewall FilterRule.php Rule.php

firewall: fix the faulty "any" replacement of a09fab2c8

While here fix another warning lighting up in the test run.
DeltaFile
+1-1src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php
+1-1src/opnsense/mvc/app/library/OPNsense/Firewall/Rule.php
+2-22 files

OPNSense/core b50350a. plist, src/opnsense/mvc/tests/app/library/OPNsense/Firewall FilterRuleTest.php

tests: add FilterRule testing for #9744

The test already revealed an issue with the refactor:

replacing "any" with "" and then "" with "in" is not in
the interest of the inventor.  Fix follows.
DeltaFile
+79-0src/opnsense/mvc/tests/app/library/OPNsense/Firewall/FilterRuleTest.php
+6-0src/opnsense/mvc/tests/app/library/OPNsense/Firewall/FilterRuleTest/testDirection.conf
+4-0src/opnsense/mvc/tests/app/library/OPNsense/Firewall/FilterRuleTest/testIcmp.conf
+3-0plist
+92-04 files

OPNSense/core 9f70bc6src/etc/inc interfaces.inc, src/opnsense/scripts/interfaces rtsold_script.sh

interfaces: multi-dhcp6c support and custom PD association #7647

This splits off rtsold and dhcp6c into separate processes
which frees us from the restrictions of faked iterative IDs
for PD associations.  For NA we simply default to 0 now.

I'm not entirely sure why we settled for a single deamon of
dhcp6c back in the day, but there are certianly downsides to
it and I don't see something that wasn't fixed in the meantime
that makes this not work.
DeltaFile
+22-58src/etc/inc/interfaces.inc
+58-4src/www/interfaces.php
+6-6src/opnsense/scripts/interfaces/rtsold_script.sh
+86-683 files

OPNSense/core 219e076src/opnsense/mvc/app/controllers/OPNsense/CaptivePortal/forms dialogZone.xml, src/opnsense/mvc/app/models/OPNsense/CaptivePortal CaptivePortal.xml

captive portal: rename virtual IPs to 'roaming'
DeltaFile
+10-10src/opnsense/scripts/captiveportal/lib/db.py
+4-4src/opnsense/scripts/captiveportal/cp-background-process.py
+3-3src/opnsense/mvc/app/controllers/OPNsense/CaptivePortal/forms/dialogZone.xml
+2-2src/opnsense/mvc/app/models/OPNsense/CaptivePortal/CaptivePortal.xml
+1-1src/opnsense/scripts/captiveportal/allow.py
+1-1src/opnsense/service/templates/OPNsense/Captiveportal/captiveportal.conf
+21-216 files

OPNSense/core 72cea55src/opnsense/mvc/app/views/OPNsense/Diagnostics fw_log.volt

firewall: live view: combined filters stored as converted strings, adjust parsing (fixes https://github.com/opnsense/core/issues/9741)
DeltaFile
+6-3src/opnsense/mvc/app/views/OPNsense/Diagnostics/fw_log.volt
+6-31 files

OPNSense/core 9b545e2src/opnsense/scripts/captiveportal allow.py

shorten this
DeltaFile
+1-2src/opnsense/scripts/captiveportal/allow.py
+1-21 files

OPNSense/core f788e18src/opnsense/scripts/captiveportal/sql init.sql

comment not relevant anymore
DeltaFile
+1-1src/opnsense/scripts/captiveportal/sql/init.sql
+1-11 files

OPNSense/core e90249csrc/opnsense/mvc/app/controllers/OPNsense/CaptivePortal/Api AccessController.php

clean up ipv6 localhost usage
DeltaFile
+1-8src/opnsense/mvc/app/controllers/OPNsense/CaptivePortal/Api/AccessController.php
+1-81 files

OPNSense/core ac2dc26src/etc/inc/plugins.inc.d captiveportal.inc, src/opnsense/mvc/app/controllers/OPNsense/CaptivePortal/forms dialogZone.xml

captive portal: limit hostwatch output and other small changes
DeltaFile
+47-17src/opnsense/scripts/captiveportal/lib/db.py
+1-16src/opnsense/mvc/app/views/OPNsense/CaptivePortal/clients.volt
+7-1src/opnsense/scripts/interfaces/list_hosts.py
+2-4src/etc/inc/plugins.inc.d/captiveportal.inc
+2-2src/opnsense/mvc/app/models/OPNsense/CaptivePortal/CaptivePortal.xml
+2-2src/opnsense/mvc/app/controllers/OPNsense/CaptivePortal/forms/dialogZone.xml
+61-422 files not shown
+63-438 files

OPNSense/core 17310aesrc/etc/inc filter.inc

firewall: another ether rule leftover
DeltaFile
+0-1src/etc/inc/filter.inc
+0-11 files

OPNSense/core 1e90897src/opnsense/mvc/app/library/OPNsense/Firewall ForwardRule.php

Firewall: NAT: Destination NAT - fix target mapping inconsistency leading to ip and network references not being processed (e.g. "lan ip", "wan network")

(cherry picked from commit 96ceae0debc240789ebc962bc787443fb47c921b)
DeltaFile
+2-2src/opnsense/mvc/app/library/OPNsense/Firewall/ForwardRule.php
+2-21 files

OPNSense/core a09fab2src/opnsense/mvc/app/library/OPNsense/Firewall Rule.php FilterRule.php

firewall: adjust for parseReplace() for icmp-type "skip"; closes #9738

Direction was a little tricky.  Would be nice to have tests for this.  ;)
DeltaFile
+12-11src/opnsense/mvc/app/library/OPNsense/Firewall/Rule.php
+1-1src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php
+13-122 files

OPNSense/core 3fe3500Scripts class-filename.sh, src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterController.php

Merge remote-tracking branch 'origin/master' into captive-portal-ipv6
DeltaFile
+85-0src/opnsense/mvc/tests/app/library/OPNsense/Core/ShellTest.php
+69-4src/opnsense/www/js/opnsense_bootgrid.js
+47-24src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+48-22src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+52-0Scripts/class-filename.sh
+30-16src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
+331-6655 files not shown
+704-22761 files

OPNSense/core 9937de0src/etc/inc/plugins.inc.d captiveportal.inc, src/opnsense/mvc/app/controllers/OPNsense/CaptivePortal/Api AccessController.php

captive portal: WIP for IPv6 support
DeltaFile
+406-249src/opnsense/scripts/captiveportal/lib/db.py
+64-215src/opnsense/scripts/captiveportal/lib/arp.py
+52-74src/opnsense/scripts/captiveportal/cp-background-process.py
+13-66src/opnsense/scripts/captiveportal/lib/pf.py
+8-59src/etc/inc/plugins.inc.d/captiveportal.inc
+5-25src/opnsense/mvc/app/controllers/OPNsense/CaptivePortal/Api/AccessController.php
+548-68810 files not shown
+609-72016 files

OPNSense/core b84bd68src/opnsense/scripts/unbound-dnsbl dnsbl_match.py, src/opnsense/scripts/unbound-dnsbl/lib dnsbl.py

Services: Unbound DNS: Blocklists / Tester - safeguard config use, when there's none specified, don't crash out.
DeltaFile
+3-0src/opnsense/scripts/unbound-dnsbl/lib/dnsbl.py
+1-1src/opnsense/scripts/unbound-dnsbl/dnsbl_match.py
+4-12 files

OPNSense/core 48d3a73src/opnsense/mvc/app/library/OPNsense/Firewall Rule.php FilterRule.php

firewall: adjust for parseReplace() for icmp-type "skip"; closes #9738

Direction was a little tricky.  Would be nice to have tests for this.  ;)
DeltaFile
+12-11src/opnsense/mvc/app/library/OPNsense/Firewall/Rule.php
+1-1src/opnsense/mvc/app/library/OPNsense/Firewall/FilterRule.php
+13-122 files

OPNSense/core 17bb00fsrc/opnsense/scripts/unbound-dnsbl dnsbl_match.py, src/opnsense/scripts/unbound-dnsbl/lib dnsbl.py

Services: Unbound DNS: Blocklists / Tester - safeguard config use, when there's none specified, don't crash out.
DeltaFile
+3-0src/opnsense/scripts/unbound-dnsbl/lib/dnsbl.py
+1-1src/opnsense/scripts/unbound-dnsbl/dnsbl_match.py
+4-12 files

OPNSense/core c7650c6src/opnsense/mvc/app/library/OPNsense/Auth LDAP.php, src/www system_authservers.php

System: Access: Servers - add configurable "memberOf" attribute, simplified version of https://github.com/opnsense/core/pull/9675

closes https://github.com/opnsense/core/issues/9650
DeltaFile
+20-8src/www/system_authservers.php
+15-6src/opnsense/mvc/app/library/OPNsense/Auth/LDAP.php
+35-142 files

OPNSense/core 96ceae0src/opnsense/mvc/app/library/OPNsense/Firewall ForwardRule.php

Firewall: NAT: Destination NAT - fix target mapping inconsistency leading to ip and network references not being processed (e.g. "lan ip", "wan network")
DeltaFile
+2-2src/opnsense/mvc/app/library/OPNsense/Firewall/ForwardRule.php
+2-21 files

OPNSense/core e0eceb5src/etc/inc interfaces.inc

interfaces: fix wlanmode usage part 2 #9727

(cherry picked from commit 4912a671be1ee8dd261d3dd9ed5720b9ed2f805e)
DeltaFile
+3-15src/etc/inc/interfaces.inc
+3-151 files

OPNSense/core 2547703src/opnsense/mvc/tests/app/library/OPNsense/Core ShellTest.php

mvc: style
DeltaFile
+1-2src/opnsense/mvc/tests/app/library/OPNsense/Core/ShellTest.php
+1-21 files