OPNSense/core 9e9e20b — src/etc/inc interfaces.lib.inc, src/etc/inc/plugins.inc.d radvd.inc

interfaces: do not throw an error on getting stats for interfaces

PR: https://forum.opnsense.org/index.php?topic=53344.0

(cherry picked from commit 24e028dc10c7a4c601dfd40872a229f44e3f6dd6)
(cherry picked from commit 3dbfca64689d9258c1ef38288650fa0c7dc3d17f)
DeltaFile
+5-8src/etc/inc/interfaces.lib.inc
+4-4src/etc/inc/plugins.inc.d/radvd.inc
+9-122 files

OPNSense/core 3dbfca6 — src/etc/inc/plugins.inc.d radvd.inc

radvd: ditch the use of legacy_interface_stats() to probe for MTU

This should increase performance quite a bit.  We already have the full
ifconfig data cached above.  Iteration of 24e028dc10.
DeltaFile
+4-4src/etc/inc/plugins.inc.d/radvd.inc
+4-41 files

OPNSense/core 4237676 — src/etc/inc interfaces.inc, src/etc/rc.syshook.d/carp 20-ppp

interfaces: defer PPP to after rc.bootup completes

This may have several benefits like drivers only slowly becoming
ready during interface configuration and dhcp6c coming up more
gracefully.

PR: https://forum.opnsense.org/index.php?topic=52824.0
PR: https://forum.opnsense.org/index.php?topic=53344.0
DeltaFile
+10-2src/etc/inc/interfaces.inc
+12-0src/etc/rc.syshook.d/start/10-newwanip
+2-0src/etc/rc.syshook.d/carp/20-ppp
+24-23 files

OPNSense/core dba1fac — src/opnsense/service/conf actions_service.conf, src/opnsense/service/conf/actions.d actions_system.conf actions_openvpn.conf

configd: restrict service stop and similar actions to wheel,wwwonly (#11233)

Addition to https://github.com/opnsense/core/commit/676d307294fe22d84b73f9639559702872b554bf
which restricted each service's own stop, the state kill actions,
clearing logs and disconnecting IPsec sessions. Still open:

- service stop
- filter flush states, filter flush sources
- system flush config_history
- ids drop alertlog
- openvpn kill
- captiveportal disconnect

None has a description, so none can be scheduled, and their only
callers in core are the web GUI and the API.
DeltaFile
+2-0src/opnsense/service/conf/actions.d/actions_filter.conf
+1-0src/opnsense/service/conf/actions_service.conf
+1-0src/opnsense/service/conf/actions.d/actions_system.conf
+1-0src/opnsense/service/conf/actions.d/actions_openvpn.conf
+1-0src/opnsense/service/conf/actions.d/actions_ids.conf
+1-0src/opnsense/service/conf/actions.d/actions_captiveportal.conf
+7-06 files

OPNSense/core 84c6837 — src/sbin pluginctl

pluginctl: enforce primary mode as selected by caller

While here sort the mode cases and add a print_help() wrapper.

Reported by: @dmuensterer
DeltaFile
+198-164src/sbin/pluginctl
+198-1641 files

OPNSense/core 5118936 — src/opnsense/scripts/interfaces dhclient-script

interfaces: small simplification on dhclient-script

Reorder the add_new_routes / add_new_alias in the TIMEOUT case
to be in the order that the average case above also uses.
DeltaFile
+3-3src/opnsense/scripts/interfaces/dhclient-script
+3-31 files

OPNSense/core eda010d — src/opnsense/scripts/interfaces dhclient-script

interfaces: flatten the successful TIMEOUT branch #11231

The ping may not always go through.  The lease life cycle
changes by assuming it is valid, but connectivity should
only be positively impacted by this.

While here remove the sleep and suprious inline exit.  The newwanip
should keep the force this we could enter this condition after a cold
boot as long as the lease is still valid on paper.

Suggested by: @firestrife23
DeltaFile
+5-17src/opnsense/scripts/interfaces/dhclient-script
+5-171 files

OPNSense/core 0614a21 — src/etc/inc/plugins.inc.d vxlan.inc

interfaces: do not skip VXLAN setup looking for local address

While here modernize the mwexecf() bits.
DeltaFile
+12-27src/etc/inc/plugins.inc.d/vxlan.inc
+12-271 files

OPNSense/core baf1b81 — src/etc rc.newwanipv6 rc.newwanip, src/etc/inc interfaces.inc

Interfaces: Assignments - during reconfiguration, an event could be triggered which will then use the current configuration data instead of the state if should have when finished. (ref: https://github.com/opnsense/core/pull/11178)

(cherry picked from commit df1ef26b5c6c3f51ded5f316a94193a4c3d51ba6)
(cherry picked from commit 46d877d03a52476468f188f5c2b005513f7f6367)
(cherry picked from commit 6fe1a0d9e716f3410246f1e1d59cfe813883bebb)
(cherry picked from commit 5da371352684b2c83ebd9f139b5effe60119ae1d)
(cherry picked from commit 4225a86402e96afff364415fd99ff205274eabd5)
DeltaFile
+41-41src/opnsense/scripts/interfaces/apply_pending_if_changes.php
+28-0src/etc/inc/interfaces.inc
+5-1src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/AssignmentController.php
+3-0src/etc/rc.newwanipv6
+3-0src/etc/rc.newwanip
+1-1src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.php
+81-436 files

OPNSense/core c5b5f72 — . plist, src/etc/inc interfaces.inc

interfaces: remove the PPP uptime option

Was modified in 4d495ea6cc3d3c99366, f129c4682b2a et al. to a state where
the option could still be enabled but never read.  The /conf bound historic
log is still filled but nothing reads it.  Let's retire it for 27.1.

One other goal here is to reduce the incoming impact of a MVC/API rewrite.

Discussed with: @swhite2

(cherry picked from commit 3e63c1cbf8819ffd7cc3de8dea16fa2a13eccffc)
DeltaFile
+1-12src/www/interfaces_ppps_edit.php
+0-7src/opnsense/scripts/interfaces/ppp-linkdown.sh
+0-7src/etc/inc/interfaces.inc
+0-5src/opnsense/scripts/interfaces/ppp-uptime.sh
+0-2src/opnsense/scripts/interfaces/ppp-linkup.sh
+0-1plist
+1-346 files

OPNSense/core c855d7e — src/opnsense/scripts/captiveportal cp-background-process.py

Services: Captive Portal - partially revert https://github.com/opnsense/core/commit/2bb88a77bdc6643174e10ab1f3ae59cdf0b30b8f for https://github.com/opnsense/core/issues/11214

Although roaming is only relevevant for IPv6 addresses, the signed in client could still have a dual stack ipv4 address.
Looking at the original issue https://github.com/opnsense/core/issues/11092, that would already have been solved by not trying to roam when a static address is requested, this seemed to have solved in the same commit.

(cherry picked from commit f016b8df486ad5366a11d96b76958525831ce9f0)
DeltaFile
+15-2src/opnsense/scripts/captiveportal/cp-background-process.py
+15-21 files

OPNSense/core 7dbcf7c — src/opnsense/mvc/app/controllers/OPNsense/Auth/Api UserApiKeyController.php, src/opnsense/mvc/app/controllers/OPNsense/Auth/forms dialogApiKey.xml

users: api: add descriptions (#11167)

(cherry picked from commit 4164ea6595750219df2070b793cc4a4a41ba4eb9)
DeltaFile
+79-35src/opnsense/mvc/app/models/OPNsense/Auth/FieldTypes/ApiKeyField.php
+81-0src/opnsense/mvc/app/models/OPNsense/Auth/ApiKey.php
+61-0src/opnsense/mvc/app/controllers/OPNsense/Auth/Api/UserApiKeyController.php
+14-4src/opnsense/mvc/app/views/OPNsense/Auth/user.volt
+18-0src/opnsense/mvc/app/controllers/OPNsense/Auth/forms/dialogApiKey.xml
+16-0src/opnsense/mvc/app/models/OPNsense/Auth/ApiKey.xml
+269-393 files not shown
+281-409 files

OPNSense/core bc9fad6 — src/opnsense/mvc/app/views/OPNsense/Diagnostics log.volt

system: show the stored history range in the log viewer (#11230)

(cherry picked from commit bf990dd7ad9c30360eda55a3de743fcaf9793add)
DeltaFile
+1-1src/opnsense/mvc/app/views/OPNsense/Diagnostics/log.volt
+1-11 files

OPNSense/core bf990dd — src/opnsense/mvc/app/views/OPNsense/Diagnostics log.volt

system: show the stored history range in the log viewer (#11230)
DeltaFile
+1-1src/opnsense/mvc/app/views/OPNsense/Diagnostics/log.volt
+1-11 files

OPNSense/core f688071 — src/etc/rc.syshook.d/start 10-newwanip

interfaces: simplify the deferred PPP hook

Keep it synchonous but mention that it works so we do not
need the other comments anymore.

PR: https://forum.opnsense.org/index.php?topic=53344.0
DeltaFile
+4-3src/etc/rc.syshook.d/start/10-newwanip
+4-31 files

OPNSense/core 4225a86 — src/etc/inc interfaces.inc, src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api AssignmentController.php

interfaces: move assignments TODO file to /var/lib/php/tmp

It belongs to the GUI since the controller handles its life cycle.
While here also avoid hardcoding the path since we have a getter.
DeltaFile
+1-1src/opnsense/scripts/interfaces/apply_pending_if_changes.php
+1-1src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.php
+1-1src/opnsense/mvc/app/controllers/OPNsense/Interfaces/Api/AssignmentController.php
+1-1src/etc/inc/interfaces.inc
+4-44 files

OPNSense/core 0ff1e32 — src/opnsense/mvc/app/library/OPNsense/System StaticRoute.php

system: move static routes TODO file to /var/lib/php/tmp

It is written by the controller which means it belongs to the GUI.
DeltaFile
+1-1src/opnsense/mvc/app/library/OPNsense/System/StaticRoute.php
+1-11 files

OPNSense/core 77e8192 — src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api ScheduleController.php, src/opnsense/mvc/app/models/OPNsense/Firewall Schedule.php

Move isActive to the controller as its not a model concern since we didn't use volatile field for it for perf reasons
DeltaFile
+21-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/ScheduleController.php
+0-20src/opnsense/mvc/app/models/OPNsense/Firewall/Schedule.php
+21-212 files

OPNSense/core 9ef502d — src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api ScheduleController.php, src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms dialogSchedule.xml

Legacy page displayed if a schedule is currently active or not, replicate this behavior in the new implementation
DeltaFile
+20-0src/opnsense/mvc/app/models/OPNsense/Firewall/Schedule.php
+8-0src/opnsense/mvc/app/views/OPNsense/Firewall/schedule.volt
+6-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/ScheduleController.php
+3-0src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogSchedule.xml
+37-14 files

OPNSense/core d409990 — src/etc rc.newwanipv6, src/etc/inc util.inc interfaces.inc

interfaces: introduce DAD sleep for 6to4/6rd trackers; closes #11179

Add the sleep in the fringe cases only and consolidate the wait
as + 2 to simplify and make it more reliable.

(cherry picked from commit 97be9723322c8a1f3570e5ebfbe4c73e41620028)
DeltaFile
+5-3src/etc/inc/interfaces.inc
+1-1src/etc/rc.newwanipv6
+1-1src/etc/inc/util.inc
+7-53 files

OPNSense/core b1866e5 — src/opnsense/mvc/app/controllers/OPNsense/Wireguard/Api ServerController.php ClientController.php

VPN: WireGuard - add optional $enabled flag for consistency, closes https://github.com/opnsense/core/issues/11219

(cherry picked from commit a5e05ff1fd10eed3e20c763c1c04cce776788399)
DeltaFile
+2-2src/opnsense/mvc/app/controllers/OPNsense/Wireguard/Api/ServerController.php
+2-2src/opnsense/mvc/app/controllers/OPNsense/Wireguard/Api/ClientController.php
+4-42 files

OPNSense/core ed738b9 — src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api AliasController.php, src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes AliasContentField.php

Firewall: Aliases - remove unused "EU" workaround (Maxmind seems to have removed these entries) and add Kosovo which isn't in IANA's list. closes https://github.com/opnsense/core/issues/11210

(cherry picked from commit a2288d253297db1d2e5092d4f6b552975609b75b)
DeltaFile
+3-2src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/AliasController.php
+1-2src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/AliasContentField.php
+4-42 files

OPNSense/core e2fc642 — src/opnsense/mvc/app/models/OPNsense/IPsec IPsec.xml

IPsec: Pre-Shared Keys - check uniqueness when only the remote identifier changes (#11224)

The reference to ident.check001 sat straight under <Constraints>, where
getConstraintValidators() skips it, so the identifier pair was only
checked when the local identifier changed.

(cherry picked from commit 3ad974d007a26bc33f3c61260a64ddefd7a53863)
DeltaFile
+3-1src/opnsense/mvc/app/models/OPNsense/IPsec/IPsec.xml
+3-11 files

OPNSense/core 7a2d422 — src/opnsense/mvc/app/models/OPNsense/Routing Gateways.xml

Routing: Gateways - drop threshold constraints that never ran (#11225)

The four ComparedToFieldConstraint options sat straight under
<Constraints> without a name, so getConstraintValidators() skipped
them. Gateways::performValidation() already checks both threshold
pairs.

(cherry picked from commit a0e64dbe2c354e91d977e0b39ccc683c9afaeba7)
DeltaFile
+0-24src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.xml
+0-241 files

OPNSense/core 90505ef — src/opnsense/mvc/app/models/OPNsense/Monit Monit.xml

Update polltime mask to include slash character (#11059)

Monit 6.0.0 deprecates the "every N cycles" statement in favour of cron-style
schedules such as every "*/3 * * * *". The polltime field of the Monit
service dialog rejects "/", so the recommended cron step syntax cannot be
entered from the GUI.

This extends the polltime mask in Monit.xml to allow "/" and updates the
validation message accordingly. No backend change is required: cron-style
values are already passed through and quoted correctly by the monitrc template.

Tested operationally on OPNsense 26.7.7 with Monit 6.0.0:

entered */3 * * * * for services previously set to every 3 cycles
generated monitrc contains every "*/3 * * * *"
monit -t passes, the "every N cycles" deprecation warnings are gone
alerting behaviour unchanged
Fixes: #11058

(cherry picked from commit 99a905407856fb0acc84bb788e6fd7f7f9ddbd06)
DeltaFile
+2-2src/opnsense/mvc/app/models/OPNsense/Monit/Monit.xml
+2-21 files

OPNSense/core 200575e — src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes ScheduleListField.php

Empty dates remain allowed when weekdays are selected
DeltaFile
+0-3src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/ScheduleListField.php
+0-31 files

OPNSense/core e048c69 — src/opnsense/mvc/tests/app/models/OPNsense/Base BaseModelTest.php, src/opnsense/mvc/tests/app/models/OPNsense/Base/BaseModel TestModel.xml

tests: add a test case for getNodeCotent()

(cherry picked from commit b20909a2e37ff683116d729596a023a6d88b1eba)
DeltaFile
+26-0src/opnsense/mvc/tests/app/models/OPNsense/Base/BaseModelTest.php
+12-0src/opnsense/mvc/tests/app/models/OPNsense/Base/BaseModel/TestModel.xml
+38-02 files

OPNSense/core d72b616 — src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api ScheduleController.php

Move findRange down closer to where its needed
DeltaFile
+12-12src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/ScheduleController.php
+12-121 files

OPNSense/core 24e028d — src/etc/inc interfaces.lib.inc, src/etc/inc/plugins.inc.d radvd.inc

interfaces: do not throw an error on getting stats for interfaces

The output is well defined and mostly braced well.  Radvd code is
doing a few dirty reads here but in the grand scheme of things it
is irrelevant to log the failures.

PR: https://forum.opnsense.org/index.php?topic=53344.0
DeltaFile
+5-8src/etc/inc/interfaces.lib.inc
+4-4src/etc/inc/plugins.inc.d/radvd.inc
+9-122 files

OPNSense/core eaf8dc1 — src/opnsense/mvc/app/models/OPNsense/Firewall Schedule.php

Legacy editor prevents WAN and LAN as schedule names, add validation
DeltaFile
+7-0src/opnsense/mvc/app/models/OPNsense/Firewall/Schedule.php
+7-01 files