radvd: ditch the use of legacy_interface_stats() to probe for MTU
This should increase performance quite a bit. We already have the full
ifconfig data cached above. Iteration of 24e028dc10.
configd: restrict service stop and similar actions to wheel,wwwonly (#11233)
Addition to https://github.com/opnsense/core/commit/676d307294fe22d84b73f9639559702872b554bf
which restricted each service's own stop, the state kill actions,
clearing logs and disconnecting IPsec sessions. Still open:
- service stop
- filter flush states, filter flush sources
- system flush config_history
- ids drop alertlog
- openvpn kill
- captiveportal disconnect
None has a description, so none can be scheduled, and their only
callers in core are the web GUI and the API.
interfaces: small simplification on dhclient-script
Reorder the add_new_routes / add_new_alias in the TIMEOUT case
to be in the order that the average case above also uses.
interfaces: flatten the successful TIMEOUT branch #11231
The ping may not always go through. The lease life cycle
changes by assuming it is valid, but connectivity should
only be positively impacted by this.
While here remove the sleep and suprious inline exit. The newwanip
should keep the force this we could enter this condition after a cold
boot as long as the lease is still valid on paper.
Suggested by: @firestrife23
interfaces: remove the PPP uptime option
Was modified in 4d495ea6cc3d3c99366, f129c4682b2a et al. to a state where
the option could still be enabled but never read. The /conf bound historic
log is still filled but nothing reads it. Let's retire it for 27.1.
One other goal here is to reduce the incoming impact of a MVC/API rewrite.
Discussed with: @swhite2
(cherry picked from commit 3e63c1cbf8819ffd7cc3de8dea16fa2a13eccffc)
interfaces: move assignments TODO file to /var/lib/php/tmp
It belongs to the GUI since the controller handles its life cycle.
While here also avoid hardcoding the path since we have a getter.
interfaces: introduce DAD sleep for 6to4/6rd trackers; closes #11179
Add the sleep in the fringe cases only and consolidate the wait
as + 2 to simplify and make it more reliable.
(cherry picked from commit 97be9723322c8a1f3570e5ebfbe4c73e41620028)
IPsec: Pre-Shared Keys - check uniqueness when only the remote identifier changes (#11224)
The reference to ident.check001 sat straight under <Constraints>, where
getConstraintValidators() skips it, so the identifier pair was only
checked when the local identifier changed.
(cherry picked from commit 3ad974d007a26bc33f3c61260a64ddefd7a53863)
Routing: Gateways - drop threshold constraints that never ran (#11225)
The four ComparedToFieldConstraint options sat straight under
<Constraints> without a name, so getConstraintValidators() skipped
them. Gateways::performValidation() already checks both threshold
pairs.
(cherry picked from commit a0e64dbe2c354e91d977e0b39ccc683c9afaeba7)
Update polltime mask to include slash character (#11059)
Monit 6.0.0 deprecates the "every N cycles" statement in favour of cron-style
schedules such as every "*/3 * * * *". The polltime field of the Monit
service dialog rejects "/", so the recommended cron step syntax cannot be
entered from the GUI.
This extends the polltime mask in Monit.xml to allow "/" and updates the
validation message accordingly. No backend change is required: cron-style
values are already passed through and quoted correctly by the monitrc template.
Tested operationally on OPNsense 26.7.7 with Monit 6.0.0:
entered */3 * * * * for services previously set to every 3 cycles
generated monitrc contains every "*/3 * * * *"
monit -t passes, the "every N cycles" deprecation warnings are gone
alerting behaviour unchanged
Fixes: #11058
(cherry picked from commit 99a905407856fb0acc84bb788e6fd7f7f9ddbd06)
interfaces: do not throw an error on getting stats for interfaces
The output is well defined and mostly braced well. Radvd code is
doing a few dirty reads here but in the grand scheme of things it
is irrelevant to log the failures.
PR: https://forum.opnsense.org/index.php?topic=53344.0