interfaces: remove PPTP support; closes #10973
To ease future migrations from PPP to MVC/API and reduce the
config field "localip" misuse we want to phase out PPTP and
reduce complexity of the implementation.
While L2TP may be still around the PPTP tunneling is very likely
not used anymore. A bit of a message to everyone still using this.
Only one way to find out.
Revert "interfaces: fallback here to prevent php warnings"
This reverts commit cda3b2f717fce26add61c147d1da0b0a0812c3eb.
these are stored by default now after save
interfaces: fallback here to prevent php warnings
PHP Warning: Undefined array key "localip" in /usr/local/etc/inc/interfaces.inc on line 1192
PHP Warning: Undefined array key "gateway" in /usr/local/etc/inc/interfaces.inc on line 1196
system: do not allow system scope users to be renamed
The previous check was about UID 0 and "root", but if we factor
in the "installer" user this construct falls apart. Instead,
check for system scope and deny all field changes.
gateways: null is not going to be a UUID either
ErrorException: Using null as an array offset is deprecated, use an empty string instead in /usr/local/opnsense/mvc/app/controllers/OPNsense/Routing/Api/SettingsController.php:162
Stack trace:
(cherry picked from commit d7cc8e1c0f10f26d0696e74f6127eecea42b672e)
gateways: null is not going to be a UUID either
ErrorException: Using null as an array offset is deprecated, use an empty string instead in /usr/local/opnsense/mvc/app/controllers/OPNsense/Routing/Api/SettingsController.php:162
Stack trace:
interfaces: remove system_routing_configure() #9352
The function is called via $reload hook so adding another
hook makes no sense. This may have changed since the original
commit below and since we need to priv-sep these calls the
easiest way is to remove it. ;)
See also: https://github.com/pfsense/pfsense/commit/8e11b23f541d