OPNSense/tools a27c06cconfig/26.1 make.conf

config: fix zabbix builds after option change

  ===> License GPLv2+ accepted by the user
  ====> You must select one and only one option from the DB single
  =====> Only one of these must be defined: MYSQLDV SQLITE
  *** Error code 1
DeltaFile
+3-3config/26.1/make.conf
+3-31 files

OPNSense/tools a335ce4config/26.1 extras.conf

config: add xml injection safeguard helper for extras

This can lead to strange results when the config.xml is not pristine.
DeltaFile
+25-1config/26.1/extras.conf
+25-11 files

OPNSense/core 28c36dasrc/opnsense/www/js/widgets Services.js BaseWidget.js, src/opnsense/www/js/widgets/Metadata Core.xml

system: distill service widget essence based on #9608
DeltaFile
+10-36src/opnsense/www/js/widgets/Services.js
+2-2src/opnsense/www/js/widgets/BaseWidget.js
+2-2src/opnsense/www/js/widgets/Metadata/Core.xml
+14-403 files

OPNSense/core 8942e1csrc/etc/inc/xmlrpc legacy.inc

xmlrpc: our xmlrpc sync still has a rather spcial handling for virtual ip's, which sometimes collisions with our standard handling when it comes to "nonsync" behavior.

In https://github.com/opnsense/core/commit/f469cf85296e3da8fe0bb49f4aaee58617d5e065 we fixed virtual ips with a vhid set, but missed the point that the backup may also set nosync on an item not in the list at all, in which case these items that are not in the list will still be duplicated.

This commit removes the vhid constraint and ignore all "nosync" records, which should close the gap here.
DeltaFile
+1-1src/etc/inc/xmlrpc/legacy.inc
+1-11 files

OPNSense/core 8881f01src/opnsense/mvc/app/views/OPNsense/Unbound stats.volt dot.volt

unbound: adjust for better layout, apply bar use and especially stats page
DeltaFile
+46-35src/opnsense/mvc/app/views/OPNsense/Unbound/stats.volt
+5-3src/opnsense/mvc/app/views/OPNsense/Unbound/dot.volt
+3-1src/opnsense/mvc/app/views/OPNsense/Unbound/dnsbl.volt
+2-2src/opnsense/mvc/app/views/OPNsense/Unbound/acl.volt
+2-1src/opnsense/mvc/app/views/OPNsense/Unbound/advanced.volt
+2-1src/opnsense/mvc/app/views/OPNsense/Unbound/general.volt
+60-431 files not shown
+62-447 files

OPNSense/core eeee812src/opnsense/mvc/app/controllers/OPNsense/Routing/Api GroupSettingsController.php

move this
DeltaFile
+8-9src/opnsense/mvc/app/controllers/OPNsense/Routing/Api/GroupSettingsController.php
+8-91 files

OPNSense/core 386f58esrc/opnsense/mvc/app/controllers/OPNsense/Routing/Api GroupSettingsController.php, src/opnsense/mvc/app/controllers/OPNsense/Routing/forms dialogEditGatewayGroup.xml

gateway groups: prepare controller logic, add missing lock on delete
DeltaFile
+23-0src/opnsense/mvc/app/controllers/OPNsense/Routing/forms/dialogEditGatewayGroup.xml
+18-1src/opnsense/mvc/app/controllers/OPNsense/Routing/Api/GroupSettingsController.php
+41-12 files

OPNSense/core f5d0b89src/opnsense/mvc/app/controllers/OPNsense/Routing/Api GroupSettingsController.php, src/opnsense/mvc/app/models/OPNsense/Routing GatewayGroups.php

Gateway Groups: MVC: protect group deletion and fix getGroupsConfig()
DeltaFile
+25-0src/opnsense/mvc/app/controllers/OPNsense/Routing/Api/GroupSettingsController.php
+2-4src/opnsense/mvc/app/models/OPNsense/Routing/GatewayGroups.php
+3-0src/opnsense/mvc/app/views/OPNsense/Routing/groups.volt
+30-43 files

OPNSense/core e44c259src/opnsense/mvc/app/controllers/OPNsense/Routing/Api SettingsController.php, src/opnsense/mvc/app/models/OPNsense/Routing GatewayGroups.php Gateways.php

Gateway Groups: convert to MVC
DeltaFile
+305-0src/opnsense/mvc/app/models/OPNsense/Routing/GatewayGroups.php
+0-120src/opnsense/mvc/app/models/OPNsense/Routing/Gateways.php
+60-0src/opnsense/mvc/app/models/OPNsense/Routing/FieldTypes/GatewayGroupItemField.php
+42-0src/opnsense/mvc/app/models/OPNsense/Routing/GatewayGroups.xml
+14-12src/opnsense/scripts/monit/gateway_alert.php
+5-13src/opnsense/mvc/app/controllers/OPNsense/Routing/Api/SettingsController.php
+426-1455 files not shown
+441-16311 files

OPNSense/core 5656077src/opnsense/mvc/app/controllers/OPNsense/Routing/Api GroupSettingsController.php

use xpath to determine uses
DeltaFile
+22-3src/opnsense/mvc/app/controllers/OPNsense/Routing/Api/GroupSettingsController.php
+22-31 files

OPNSense/core cf78fddsrc/opnsense/mvc/app/controllers/OPNsense/Routes/Api GatewayController.php, src/opnsense/mvc/app/controllers/OPNsense/Routing/Api GroupSettingsController.php

review feedback
DeltaFile
+13-8src/opnsense/mvc/app/controllers/OPNsense/Routing/Api/GroupSettingsController.php
+4-4src/opnsense/mvc/app/models/OPNsense/Routing/GatewayGroups.xml
+1-2src/opnsense/mvc/app/controllers/OPNsense/Routes/Api/GatewayController.php
+18-143 files

OPNSense/core 34cad56src/opnsense/mvc/app/controllers/OPNsense/Routes/Api GatewayController.php, src/opnsense/mvc/app/controllers/OPNsense/Routing/Api SettingsController.php

gateways: do a bit of refactoring in the regular gateway controller and backend call to ease parsing for the group settings
DeltaFile
+7-7src/opnsense/mvc/app/controllers/OPNsense/Routing/Api/SettingsController.php
+1-1src/opnsense/scripts/routes/gateway_status.php
+1-0src/opnsense/mvc/app/controllers/OPNsense/Routes/Api/GatewayController.php
+9-83 files

OPNSense/core 12d7ab9src/opnsense/mvc/app/models/OPNsense/Routing GatewayGroups.xml, src/opnsense/mvc/app/models/OPNsense/Routing/FieldTypes GatewayGroupItemField.php

set this in the model just to be explicit
DeltaFile
+5-0src/opnsense/mvc/app/models/OPNsense/Routing/GatewayGroups.xml
+0-1src/opnsense/mvc/app/models/OPNsense/Routing/FieldTypes/GatewayGroupItemField.php
+5-12 files

OPNSense/core b58606csrc/opnsense/mvc/app/models/OPNsense/Routing GatewayGroups.php, src/opnsense/scripts/routes gateway_watcher.php

Gateway Groups: typo and lazy-load model in gateway watcher
DeltaFile
+4-2src/opnsense/scripts/routes/gateway_watcher.php
+1-1src/opnsense/mvc/app/models/OPNsense/Routing/GatewayGroups.php
+5-32 files

OPNSense/core a9be0e7. plist, src/www system_gateway_groups_edit.php system_gateway_groups.php

remove legacy pages
DeltaFile
+0-288src/www/system_gateway_groups_edit.php
+0-221src/www/system_gateway_groups.php
+0-2plist
+0-5113 files

OPNSense/core 99c2a7bsrc/opnsense/scripts/routes gateways.php

remove line
DeltaFile
+0-1src/opnsense/scripts/routes/gateways.php
+0-11 files

OPNSense/core 795e28fsrc/opnsense/mvc/app/views/OPNsense/Routing groups.volt

Gateway Groups: MVC: fix endpoint
DeltaFile
+1-1src/opnsense/mvc/app/views/OPNsense/Routing/groups.volt
+1-11 files

OPNSense/core 4d051c1src/opnsense/mvc/app/controllers/OPNsense/Routing GatewayGroupsController.php, src/opnsense/mvc/app/controllers/OPNsense/Routing/forms dialogEditGatewayGroup.xml

Gateway Groups: MVC conversion: review feedback and add UI
DeltaFile
+55-0src/opnsense/mvc/app/controllers/OPNsense/Routing/forms/dialogEditGatewayGroup.xml
+46-0src/opnsense/mvc/app/views/OPNsense/Routing/groups.volt
+28-13src/opnsense/mvc/app/models/OPNsense/Routing/GatewayGroups.php
+41-0src/opnsense/mvc/app/controllers/OPNsense/Routing/GatewayGroupsController.php
+2-7src/opnsense/mvc/app/models/OPNsense/Core/ACL/ACL.xml
+1-4src/opnsense/mvc/app/models/OPNsense/Core/Menu/Menu.xml
+173-242 files not shown
+179-248 files

OPNSense/core 0014344src/opnsense/mvc/app/controllers/OPNsense/Routing/Api GroupSettingsController.php, src/opnsense/mvc/app/models/OPNsense/Routing GatewayGroups.php GatewayGroups.xml

tmp
DeltaFile
+62-0src/opnsense/mvc/app/controllers/OPNsense/Routing/Api/GroupSettingsController.php
+11-30src/opnsense/mvc/app/models/OPNsense/Routing/GatewayGroups.php
+14-7src/opnsense/mvc/app/models/OPNsense/Routing/FieldTypes/GatewayGroupItemField.php
+15-5src/opnsense/mvc/app/models/OPNsense/Routing/GatewayGroups.xml
+2-2src/opnsense/scripts/monit/gateway_alert.php
+1-2src/opnsense/scripts/routes/gateways.php
+105-461 files not shown
+106-477 files

OPNSense/core 0830f2fsrc/opnsense/mvc/app/models/OPNsense/Routing GatewayGroups.php

update function docs here
DeltaFile
+1-1src/opnsense/mvc/app/models/OPNsense/Routing/GatewayGroups.php
+1-11 files

OPNSense/core 7d9e349src/opnsense/mvc/app/models/OPNsense/Routing GatewayGroups.php GatewayGroups.xml, src/opnsense/scripts/routes gateways.php

Gateway Groups: MVC: missing gateway name validation, modify backend call to optionally exclude localhost,inactive,disabled
DeltaFile
+14-13src/opnsense/scripts/routes/gateways.php
+13-3src/opnsense/mvc/app/models/OPNsense/Routing/GatewayGroups.php
+5-5src/opnsense/mvc/app/models/OPNsense/Routing/GatewayGroups.xml
+32-213 files

OPNSense/core 5ca0ecesrc/opnsense/mvc/app/controllers/OPNsense/IPsec/forms dialogConnection.xml, src/opnsense/mvc/app/views/OPNsense/IPsec connections.volt

ipsec: fancy up the connections dialog

It's a bit special but save is for the form in particular
and this way we can have native striping. The grids save
on their own and hopefully UI will be clearer now.

Add a static header option for it and fix true/false checks.

Close the extra dialog-form on apply.

Discussed with: @Monviech
DeltaFile
+98-111src/opnsense/mvc/app/views/OPNsense/IPsec/connections.volt
+21-5src/opnsense/mvc/app/views/layout_partials/base_dialog.volt
+5-0src/opnsense/mvc/app/controllers/OPNsense/IPsec/forms/dialogConnection.xml
+124-1163 files

OPNSense/core 36fda5fsrc/opnsense/mvc/app/controllers/OPNsense/IPsec/forms dialogConnection.xml, src/opnsense/mvc/app/views/OPNsense/IPsec connections.volt

ipsec: allow save_cancel render as field and restyle for gap layout incl. content box and vertical border
DeltaFile
+51-34src/opnsense/mvc/app/views/OPNsense/IPsec/connections.volt
+17-0src/opnsense/mvc/app/views/layout_partials/form_input_tr.volt
+0-14src/opnsense/mvc/app/views/layout_partials/base_dialog.volt
+4-0src/opnsense/mvc/app/controllers/OPNsense/IPsec/forms/dialogConnection.xml
+72-484 files

OPNSense/core c2c476fsrc/opnsense/mvc/app/controllers/OPNsense/Base ControllerBase.php, src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt nat_rule.volt

ui: use single generic event
DeltaFile
+17-11src/opnsense/www/js/opnsense_bootgrid.js
+3-3src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+3-3src/opnsense/www/js/opnsense_ui.js
+3-1src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php
+2-2src/opnsense/mvc/app/views/OPNsense/Firewall/nat_rule.volt
+1-2src/opnsense/mvc/app/views/layout_partials/base_apply_button.volt
+29-223 files not shown
+32-259 files

OPNSense/core 7d38377src/opnsense/mvc/app/views/OPNsense/IPsec connections.volt

ipsec: reduce visual jumping on page by reusing grids

only hide if we're coming from a different tab. Any change
triggered on the tab itself will now clear the grids and reload
them so the content doesn't pop out and in of existence when
pressing save.

As a fallback, always hide if the connection doesn't exist
DeltaFile
+13-2src/opnsense/mvc/app/views/OPNsense/IPsec/connections.volt
+13-21 files

OPNSense/core a610490src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt nat_rule.volt, src/opnsense/mvc/app/views/OPNsense/IPsec connections.volt

ui: apply message unification progress #10230
DeltaFile
+8-32src/opnsense/mvc/app/views/OPNsense/IPsec/connections.volt
+1-5src/opnsense/mvc/app/views/OPNsense/Unbound/acl.volt
+3-2src/opnsense/www/js/opnsense_bootgrid.js
+3-2src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+4-0src/opnsense/www/js/opnsense_ui.js
+2-2src/opnsense/mvc/app/views/OPNsense/Firewall/nat_rule.volt
+21-431 files not shown
+22-447 files

OPNSense/core da8fb9dsrc/opnsense/mvc/app/controllers/OPNsense/OpenVPN/Api ExportController.php, src/opnsense/mvc/app/models/OPNsense/Unbound/FieldTypes UnboundInterfaceField.php

openvpn: fix legacy access following a0863680e2ca9
DeltaFile
+12-12src/opnsense/mvc/app/controllers/OPNsense/OpenVPN/Api/ExportController.php
+1-1src/opnsense/mvc/app/models/OPNsense/Unbound/FieldTypes/UnboundInterfaceField.php
+13-132 files

OPNSense/core 983ece5src/opnsense/mvc/app/controllers/OPNsense/IPsec/forms dialogConnection.xml, src/opnsense/mvc/app/views/OPNsense/IPsec connections.volt

ipsec: allow save_cancel render as field and restyle for gap layout incl. content box and vertical border
DeltaFile
+51-34src/opnsense/mvc/app/views/OPNsense/IPsec/connections.volt
+17-0src/opnsense/mvc/app/views/layout_partials/form_input_tr.volt
+0-14src/opnsense/mvc/app/views/layout_partials/base_dialog.volt
+4-0src/opnsense/mvc/app/controllers/OPNsense/IPsec/forms/dialogConnection.xml
+72-484 files

OPNSense/core 9bdc3f6src/opnsense/mvc/app/views/OPNsense/IPsec connections.volt

ipsec: reduce visual jumping on page by reusing grids

only hide if we're coming from a different tab. Any change
triggered on the tab itself will now clear the grids and reload
them so the content doesn't pop out and in of existence when
pressing save.

As a fallback, always hide if the connection doesn't exist
DeltaFile
+13-2src/opnsense/mvc/app/views/OPNsense/IPsec/connections.volt
+13-21 files

OPNSense/core 99a0055src/opnsense/mvc/app/controllers/OPNsense/Base ControllerBase.php, src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt nat_rule.volt

ui: use single generic event
DeltaFile
+17-11src/opnsense/www/js/opnsense_bootgrid.js
+3-3src/opnsense/www/js/opnsense_ui.js
+3-3src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+2-2src/opnsense/mvc/app/views/OPNsense/Firewall/nat_rule.volt
+3-1src/opnsense/mvc/app/controllers/OPNsense/Base/ControllerBase.php
+1-2src/opnsense/mvc/app/views/layout_partials/base_apply_button.volt
+29-223 files not shown
+32-259 files