Interfaces: Wireless: Devices - Migrate to MVC code, second phase, move settings from Interfaces into Wireless. closes https://github.com/opnsense/core/issues/10751
Move all settings from interface.XXX.wireless to wireless.clone and cleanup code referencing the old spot.
The console menu contained some, likely incomplete, code, which we will remove here as well, it doesn't feel very usefull trying to offer console configuration for wireless anyway.
Not all validations are being migrated, only the most relevant ones, which should be good enough.
Interfaces: Wireless: Devices - Migrate to MVC code, second phase, move settings from Interfaces into Wireless. for https://github.com/opnsense/core/issues/10751
Move all settings from interface.XXX.wireless to wireless.clone and cleanup code referencing the old spot.
console : seemed to show the parent interfaces, but without a useful implementation, removed it
Interfaces: Wireless: Devices - Migrate to MVC code, second phase, move settings from Interfaces into Wireless. for https://github.com/opnsense/core/issues/10751
Move all settings from interface.XXX.wireless to wireless.clone and cleanup code referencing the old spot.
console : seemed to show the parent interfaces, but without a useful implementation, removed it
Interfaces: Wireless: Devices - Migrate to MVC code, second phase, move settings from Interfaces into Wireless. for https://github.com/opnsense/core/issues/10751
Move all settings from interface.XXX.wireless to wireless.clone and cleanup code referencing the old spot.
console : seemed to show the parent interfaces, but without a useful implementation, removed it
Interfaces: Wireless: Devices - Migrate to MVC code, second phase, move settings from Interfaces into Wireless. for https://github.com/opnsense/core/issues/10751
Move all settings from interface.XXX.wireless to wireless.clone and cleanup code referencing the old spot.
console : seemed to show the parent interfaces, but without a useful implementation, removed it
Firewall: NAT: Source NAT: fix port alias and well known port usage in target_port (#10793)
* Firewall: NAT: Source NAT: fix port alias usage in target_port
* Add use statements for BooleanField and ProtocolField
ui: apply second half of previous for advanced
The local storage doesn't follow this UI flow now, but
the UI flow is rather consistent. Might be worth disabling
local storage on key strokes, but that's for later.
mvc: add JsonAuditField and implement in firewall (#10726)
Adds a reusable audit field type for model records. Models can opt in with a single JsonAuditField, while ApiMutableModelControllerBase manages some of the created and updated information.
The audit data is stored as JSON so it can be extended later without adding more model fields.
An additionally user supplied note field can store why an item has been changed.
A migration moves legacy created/updated into the new JSON fieldtype.
---------
Co-authored-by: Ad Schellevis <ad at opnsense.org>
e1000: Avoid signed shifts while assembling PHY IDs
PHY identifier words are promoted to signed int when the cast is applied
after the shift. Cast each 16-bit register value first so identifiers
with their high bit set are assembled as unsigned data.
(cherry picked from commit 13a7470096567480676e24545b3c1d6404f3f2ec)
e1000: Avoid a signed manageability VLAN bitmap shift
A manageability VLAN can select bit 31 of its VFTA register. Use an
unsigned value when constructing the register mask.
(cherry picked from commit 392fbdcf2232f12cb973d00ae931740c72d970c6)
e1000: Verify i210 and i211 multicast table writes
The i210 and i211 can occasionally fail to accept multicast table
writes, particularly while addresses are added and removed rapidly.
Read the table back and rewrite mismatches for up to three passes.
This prevents multicast reception from retaining stale filter state
while keeping the workaround limited to the affected controllers.
(cherry picked from commit bb8d0944b5d53863f00492b69b7bf13d2618fc95)
e1000: Avoid a signed multicast bitmap shift
The multicast hash bit can be 31. Use an unsigned value so setting the
bit cannot shift a signed integer into its sign bit.
(cherry picked from commit a86d65b2c99bab3fe46389b3b51ad27956dccfe9)
