mvc: remove grouped ModelRelationField option handling (#10339)
The group option collapsed multiple related model rows into a single
display entry while still storing the UUID of one concrete source row.
This makes the selected relation dependent on iteration order and is not
a stable representation of the grouped object.
References:
https://github.com/opnsense/core/commit/fe571ac442efe76c3a1efd3e6f90b8ec4cb6e7bd
Frr was the only consumer (I could grep in core and plugins, don't know if external ones exist), I reworked how the relationship is displayed there to make it more obvious to the user how items relate to each other, and also prevent that the wrong items get deleted. Configs should be more coherent now.
It's also not perfect, but more "obvious" lets say.
It also helps with the addition of internalModelUseSafeDelete in FRR.
opnsense/plugins at 0798cde
opnsense/plugins at d3c3e79
opnsense/plugins at cb9a5d6
mvc: remove grouped ModelRelationField option handling
The group option collapsed multiple related model rows into a single
display entry while still storing the UUID of one concrete source row.
This makes the selected relation dependent on iteration order and is not
a stable representation of the grouped object.
References:
https://github.com/opnsense/core/commit/fe571ac442efe76c3a1efd3e6f90b8ec4cb6e7bd
ipsec: move swanctl.conf download button to the tab
This aligns with the aliases actions tab.
(cherry picked from commit e44a05a0de9c3d984cea938bc134824be90a5bdb)
unbound: blocklist improvements (#10149)
* Organizes DNSBLs by provider/category.
* Adds the Social Network blocklist by hegizi.
* The tester now gives you the DNSBL name and category instead of its shortcode.
(cherry picked from commit d7f455bdfb3586eb943d533edded011bd9972014)
Firewall: Rules [new]: Fix action, ipprotocol and protocol translations (legacy rules) (#10299)
* Firewall: Rules [new]: Fix action, ipprotocol and protocol translations. Fix Automatically generated rules category.
* Ensure translations are passed through all the way to icon formatter in view
* Ensure inet46 always shows as Any or *
* Update src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.xml
Co-authored-by: Franco Fichtner <franco at opnsense.org>
* Update src/opnsense/scripts/filter/list_non_mvc_rules.php
Co-authored-by: Franco Fichtner <franco at opnsense.org>
---------
Co-authored-by: Franco Fichtner <franco at opnsense.org>
(cherry picked from commit b73465c9b17d0afa2cac1655592355b9cc96de5c)
net/frr: BGP Improve visibility in ModelRelationFields and enable internalModelUseSafeDelete (#5461)
* net/frr: Improve visibility in ModelRelationFields and enable internalModelUseSafeDelete
* Adjust BGP template to only emit a single set for multiple selected items with the same name
Revert "ui: lazily hook settings-changed trigger in saveFormToEndpoint()"
This reverts commit e4dc9ad212f18d28590c46392793f4ca28fc069f.
This reverts commit 45ef8ddd1a553e44c5f7e95f2e228fc66ec58abc.
The current approach is fine since it is not the default behaviour to
use change() to save the form.
Discussed with: @swhite2
ui: add a class marker for forms to use settings-changed trigger
Most flat forms make save+apply which glitches with a general
settings-changed show in saveFormToEndpoint().
ui: improve form validation error append (#10333)
Since this iterates over a lot of irrelevant IDs and then mismatches
with the target change this by safeguarding against fields that are
likely not going to work without help_block_<id> and switch target
to a suffix match.
One spot where this matters: under kea v6 subnet add "DNS servers"
entry e.g. "::", click auto collect for check mark, click save. Interface
and subnet validation is red, the DNS server one shown is not.
(cherry picked from commit 546de351d7eed21ae1f0464938ca1743c1d1b865)
