OpenBSD/src fF1kZeR — usr.sbin/rpki-client parser.c

   Stop initalizing the return pointer in the various proc_parser_mft functions.
   Instead add the missing crlfile initalization at the top of proc_parser_mft.
   There is a maze of pointers that are passed around here and those extra
   assignments don't make the code easier to read.

   OK tb@
VersionDeltaFile
1.208+2-7usr.sbin/rpki-client/parser.c
+2-71 files

OpenBSD/src rWkqCLy — sys/kern kern_event.c

   Implement a different fix for the use-after-free in filt_procattach
   from rev 1.207.

   Instead of shuffling locks around take a process reference in this
   code to prevent the process from exiting under us while sleeping
   for the kqueue_ps_list_lock rwlock. This is the same solution that
   was used for a similar issue in fork1.

   Reported by Acts1631 and OpenAI
   Patch provided by OpenAI
   from claudio@; OK mvs@

   this is errata/8.0/022_kqueue.patch.sig
VersionDeltaFile
1.206.2.1+4-1sys/kern/kern_event.c
+4-11 files

OpenBSD/src kBi1TUs — sys/kern kern_event.c

   Implement a different fix for the use-after-free in filt_procattach
   from rev 1.207.

   Instead of shuffling locks around take a process reference in this
   code to prevent the process from exiting under us while sleeping
   for the kqueue_ps_list_lock rwlock. This is the same solution that
   was used for a similar issue in fork1.

   Reported by Acts1631 and OpenAI
   Patch provided by OpenAI
   from claudio@; OK mvs@

   this is errata/7.9/057_kqueue.patch.sig
VersionDeltaFile
1.205.4.1+4-1sys/kern/kern_event.c
+4-11 files

OpenBSD/src HCgnspH — sys/kern tty_pty.c

   Do not allow TIOCSCTTY, TIOCNOTTY, or TIOCSPGRP on the pty master.  Return
   ENOTTY for all 3 of these.  They could create incoherent session states,
   leading to dangerous UAF reported by openai (unfortunately their proposed
   patch was batshit crazy and made the situation worse, due to not identifying
   this as root cause, and writing code to support the condition).
   from deraadt@ with claudio@ various versions; OK kettenis@ kirill@ and others

   this is errata/8.0/021_pty.patch.sig
VersionDeltaFile
1.116.6.1+6-1sys/kern/tty_pty.c
+6-11 files

OpenBSD/src S9s1uf5 — sys/kern tty_pty.c

   Do not allow TIOCSCTTY, TIOCNOTTY, or TIOCSPGRP on the pty master.  Return
   ENOTTY for all 3 of these.  They could create incoherent session states,
   leading to dangerous UAF reported by openai (unfortunately their proposed
   patch was batshit crazy and made the situation worse, due to not identifying
   this as root cause, and writing code to support the condition).
   from deraadt@ with claudio@ various versions; OK kettenis@ kirill@ and others

   this is errata/7.9/056_pty.patch.sig
VersionDeltaFile
1.116.4.1+6-1sys/kern/tty_pty.c
+6-11 files

OpenBSD/src 0n6XbNo — usr.bin/tmux utf8-combined.c input-keys.c

   Swap wchar_t to int except when necessary since on some platforms it is 16 bits,
   GitHub issue 5803 from hrajyw4 at gmail dot com.
VersionDeltaFile
1.78+24-18usr.bin/tmux/utf8.c
1.81+4-17usr.bin/tmux/key-string.c
1.1482+3-3usr.bin/tmux/tmux.h
1.12+2-2usr.bin/tmux/utf8-combined.c
1.116+2-2usr.bin/tmux/input-keys.c
+35-425 files

OpenBSD/src RPPhnTM — usr.bin/tmux cmd-resize-pane.c

   Account for status line in size calculation.
VersionDeltaFile
1.74+4-5usr.bin/tmux/cmd-resize-pane.c
+4-51 files

OpenBSD/src JSs0ArF — sbin/scan_ffs scan_ffs.c

   Make sure the static buffer in ufsscan() is 64-bit aligned. Clang on sparc64
   does not guarantee anything, and SIGBUS occur later.

   ok tb@
VersionDeltaFile
1.25+2-2sbin/scan_ffs/scan_ffs.c
+2-21 files

OpenBSD/src tptVH1D — sys/dev/usb usbdi.c

   Avoid assigning output parameter on error in usbd_open_pipe_intr

   In case of an error ipipe is closed after yet the caller already got
   it.

   OK kirill@
VersionDeltaFile
1.113+2-2sys/dev/usb/usbdi.c
+2-21 files

OpenBSD/src OUD71YA — sbin/iked iked.c

   fix indentation
VersionDeltaFile
1.76+2-2sbin/iked/iked.c
+2-21 files

OpenBSD/src Ijx0cTd — lib/libcrypto/evp e_aes.c

   libcrypto: fix a long-standing quirk in CCM mode

   For some reason it was decided that in CCM mode the caller should not be
   allowed to set the tag length before setting the tag, which is the natural
   order. This required various contortions in downstream, at least in Ruby
   and rust-openssl.

   This pulls in 9cca7be1 (before license change) and makes a trivial change
   functionally equivalent to (but different from) 67c81ec3 from OpenSSL.

   From William T. Nelson
VersionDeltaFile
1.86+6-4lib/libcrypto/evp/e_aes.c
+6-41 files

OpenBSD/src nY0RvK4 — lib/libcrypto/evp e_aes.c

   libcrypto: add missing AEAD flag to AES-CCM

   The AES-CCM ciphers aren't marked as AEAD ciphers, so openssl enc allows
   them even though it shouldn't. OpenSSL has set the flag since adding CCM
   support to libssl in e75c5a79.

   From William T. Nelson
VersionDeltaFile
1.85+4-4lib/libcrypto/evp/e_aes.c
+4-41 files

OpenBSD/src 4qF1nUt — lib/libcrypto/evp e_aes.c

   libcrypto: use consistent spacing around | in e_aes.c
VersionDeltaFile
1.84+4-4lib/libcrypto/evp/e_aes.c
+4-41 files

OpenBSD/src PrPSUOW — usr.bin/tmux key-bindings.c

   Do not include edit on menu.
VersionDeltaFile
1.199+1-2usr.bin/tmux/key-bindings.c
+1-21 files

OpenBSD/src 65geWXh — usr.bin/tmux window.c

   Couple of bits not merged correctly from previous.
VersionDeltaFile
1.392+2-5usr.bin/tmux/window.c
+2-51 files

OpenBSD/src dd8xSgS — lib/libcrypto/x509 x509_asid.c x509_addr.c

   libcrypto: link to eid9314 in the RFC 3779 inherit workarounds
VersionDeltaFile
1.48+2-1lib/libcrypto/x509/x509_asid.c
1.98+2-1lib/libcrypto/x509/x509_addr.c
+4-22 files

OpenBSD/src yXdA0vc — usr.sbin/rpki-client validate.c

   rpki-client: the inherit workaround is now an erratum (hfdu) for RFC 3779

   Link to https://errata.rfc-editor.org/eid9314/

   ok job
VersionDeltaFile
1.95+3-1usr.sbin/rpki-client/validate.c
+3-11 files

OpenBSD/src bwGtvcS — usr.sbin/rpki-client aspa.c

   rpki-client: handle {0} ASPAs up front

   The semantics of merging mean that merging {0} into an already existing
   CAS does nothing, so if aspa->providers[] is the set {0}, we can return
   early. If v->providers[] is the set {0}, drop the 0 and adjust counters
   then copy aspa->providers[] into it.

   This approach would have worked before, but it's now a bit easier to see
   why it works.

   ok claudio
VersionDeltaFile
1.58+15-9usr.sbin/rpki-client/aspa.c
+15-91 files

OpenBSD/src 6K1yXl2 — sys/dev/ic decmonitors.c, sys/dev/pci tga.c

   Make the video modes table used by tga(4) const.
VersionDeltaFile
1.47+4-4sys/dev/pci/tga.c
1.4+2-2sys/dev/ic/decmonitors.c
+6-62 files

OpenBSD/src PrFi9CU — sys/dev/pci if_txp.c

   Do not compile txp_show_descriptor() unless option DDB.
VersionDeltaFile
1.132+5-1sys/dev/pci/if_txp.c
+5-11 files

OpenBSD/src Gi1TPkl — sys/dev/usb usb_quirks.c

   Comment-out the class-specific quirks table and related code, until the need
   for a class-specific quirk arises again (hopefully never again).
VersionDeltaFile
1.82+7-1sys/dev/usb/usb_quirks.c
+7-11 files

OpenBSD/src S04YoaX — sys/nfs nfs_socket.c

   Remove unused function call counters.
VersionDeltaFile
1.159+1-6sys/nfs/nfs_socket.c
+1-61 files

OpenBSD/src Ur9tz4K — usr.sbin/rpki-client aspa.c

   rpki-client: I did some work in aspa.c
VersionDeltaFile
1.57+2-2usr.sbin/rpki-client/aspa.c
+2-21 files

OpenBSD/src U6T80zT — usr.sbin/rpki-client ccr.c

   rpki-client: disallow AS 0 alongside others in CCR ASPA payloads

   Reported by Ties de Kock

   ok job
VersionDeltaFile
1.49+6-1usr.sbin/rpki-client/ccr.c
+6-11 files

OpenBSD/src KJWMJNK — usr.sbin/rpki-client aspa.c

   rpki-client: rework aspa_insert_vaps()

   The merge loop in aspa_insert_vaps() is too smart and has tripped us all up
   repeatedly. While it won't matter much due to size constraints, its worst
   case is O(n*m), which isn't great.

   Let's make this easier to follow and reason about. A linear sweep merges
   and deduplicates the two arrays question until one of them is consumed,
   then fill in the tail of the one that remains non-empty. Both arrays are
   strictly monotonic, and this property is clearly preserved by the new
   approach.

   The other bit that is obvious is that the merge loop is O(n + m). The price
   we pay is a bit more code and an extra allocation.

   ok claudio job
VersionDeltaFile
1.56+46-32usr.sbin/rpki-client/aspa.c
+46-321 files

OpenBSD/src neGToic — usr.sbin/ldpd labelmapping.c

   In tlv_decode_fec_elm add missing initial len and prefixlen check

   Ensure that fec_elm have at least the one byte needed for the type
   and also check that the encoded prefixlen actually matches with the
   address family.

   Reported by Yang Hailong
   OK deraadt@ tb@
VersionDeltaFile
1.71+14-2usr.sbin/ldpd/labelmapping.c
+14-21 files

OpenBSD/src ILr2V9b — usr.bin/tmux options.c layout-set.c

   Add support for separate pane borders via a new option pane-border-type.
   GitHub issue 5433 from David Marte.
VersionDeltaFile
1.109+341-31usr.bin/tmux/layout.c
1.391+66-22usr.bin/tmux/window.c
1.8+76-8usr.bin/tmux/window-panes.c
1.437+45-12usr.bin/tmux/format.c
1.42+49-5usr.bin/tmux/layout-set.c
1.95+27-8usr.bin/tmux/options.c
+604-868 files not shown
+692-11314 files

OpenBSD/src VI5llV6 — usr.bin/tmux window-switch.c

   Do not dim selected rows or the dimmed text is not readable with some
   themes, GitHub issue 5885 from Michael Grant.
VersionDeltaFile
1.9+54-20usr.bin/tmux/window-switch.c
+54-201 files

OpenBSD/src OuNV9GL — usr.sbin/rpki-client extern.h repo.c

   rpki-client: fix merging of ASPA objects

   Prompted by a question by Yangyang WANG, draft-ietf-sidrops-aspa-profile-29
   added new wording regarding 0 handling when merging two ASPAs with the same
   customer ASID and clarified that 0 should be discarded:

   https://mailarchive.ietf.org/arch/msg/sidrops/TToTScyLiVXdyJzf-kgzv5XMy3U/

   Implement this and adjust the accounting when dropping the 0.

   Found by job because this case now appears in the wild.

   ok claudio
VersionDeltaFile
1.55+8-1usr.sbin/rpki-client/aspa.c
1.102+4-1usr.sbin/rpki-client/repo.c
1.329+2-1usr.sbin/rpki-client/extern.h
+14-33 files

OpenBSD/src jRrh2iB — usr.bin/tmux window-copy.c

   Fix remembered copy mode column with vi keys and after end-of-line,
   GitHub issue 5887 from Dmitrii Novikov.
VersionDeltaFile
1.446+19-12usr.bin/tmux/window-copy.c
+19-121 files