Do not try to configure 0.0.0.0 (INADDR_ANY) on an interface.
If we indicate a preference for IPv6-only (DHCP option 108), the
server does not offer an IP address (indicated by INADDR_ANY), so we
must first check if the server supported option 108 before checking if
we received an IPv4 offer.
Logic error pointed out and diff provided by acts1631 at proton.me,
thanks!
Don't drop X509_V_ERR_HOSTNAME_MISMATCH when verify callback returns 1
While not the advised way of using the verify callback (either by OpenSSL
or by us) in production, sometimes folks like to return 1 from everything
in the callback and then check the error return and make decicions about
things.
This fix ensures that such callbacks will see the hostname mismatch and
be able to act upon them.
Reported by Alexander Aleksandrovic Klimov
ok tb@
Do not hardcode /usr/src/ in one of the files containing desired output.
This is expected to fix a test failure that anton@ reported with BSDSRCDIR set.
Fix control message handling in recvit to avoid out of bounds write
to userland
Because of the use of a unsigned variable to track the length of the
control buffer recvit can underflow that variable because of an unchecked
ALIGN(). This can be triggered by passing a too short buffer that is not a
multiple of _ALIGNBYTES + 1. In such a case the kernel copies out data past
the provided buffer.
On top of addding the missing overflow check this also uses the proper
socklen_t type for the msg_controllen and uses an unsigned int for the
still overloaded variable i.
The security implications of this are mainly theoretical. The correct use
of control message handling requires the use of CMSG_SPACE which ensures
the buffer size is properly rounded. In base only dig uses a buffer that
is not correctly rounded at the same time it is oversized enough to not
matter.
[2 lines not shown]
find: check localtime() return before calling strftime on it
landry saw "find dir -ls" crash with fs corruption. dgl reproduced with
touch foo && perl -e'utime 2**63, 2**63, "foo"' && find foo -ls
which could have been added to regress if there was any...
ok deraadt
rpki-client: reject some signed objects with BER encoding
ARIN finally fixed their shit and no longer distributes malformed ROAs.
Detect one symptom of their malformedness. This is a very unsatisfactory
kludge since it only detects indefinite length encoding at the outermost
layer, but this will hopefully help avoid regressions. libcrypto's ASN.1
parser is not going to help making the world a cleaner place.
fine with claudio, ok job
rpki-client: unconditionally warn about incorrect RSA parameters
Now that ARIN have fixed their old ROAs, this encoding no longer occurs
in the wild, so enabling this warning does no harm. Ideally we'd error,
but a Postel-inspired MUST that has been sprinkled across numerous RFCs
ensured that this had to be tolerated for more than a quarter of a century
and will continue to be for at least another one.
discussed with claudio job
Most dictionaries list the noun "firmware" as uncountable,
so avoid the plural form.
OK jsg@ ian@ and also agrees with jmc@'s past practice.
Minor issue found by jsg@.
Provide assembly implementation of SHA-1 for aarch64 in libc
Provide a CE assembly implementation that can be used on hardware that
has the CE SHA-1 instructions. This is considerably faster than the
generic C implementation.
Largely borrowed from libcrypto.
With input from naddy@
ok naddy@ tb@
Validate the IP address the dhcp server acks.
acts1631 at proton.me points out that a rogue dhcp server can trick
dhcpleased into holding on to a lease indefinitely since it looses
track which IP is actually configured.
Diff provided by acts1631 as well, thanks!
While here, remove checking for yiaddr being absent (i.e. INADDR_ANY)
because that check is now redundant.
Add a clear-on-attach option which when turned off scrolls away the
existing terminal state instead of entering the alternate screen. This
is useful in environments where tmux is started as a login shell but it
is important that any pre-tmux messages are still visible. GitHub issue
5508 from Josef Řídký.
