isakmpd: avoid direct ASN1_STRING accesses
Since this transforms notBefore and notAfter into a string to be used in
a keynote assertion, existing libcrypto interfaces aren't directly suitable,
so I kept this mechanical by assigning the data and length fields to local
variables via accessors and replacing tm->data by data and tm->length by
len, only occasionally fixing up whitespace and omitting parentheses.
probably ok beck claudio
Fix vmd reboots broken by my pause barrier changes.
Reported by bluhm@.
Long story is vmd has some complexity in how the decision to "reboot"
a vm process is made. The pause barrier diff clobbered a return
value that bubbled up to a value passed to exit(3) and picked up
by the parent vmd process (the "vmm" process) that determines if a
process exit should result in relaunching the vm process or not.
For now, just stop clobbering the value and don't report the error
returned by pthread_barrier_destroy(3).
Replace trivial uses of ASN1_STRING_data()
Almost entirely mechanical diff that ensures that for read-only accesses
we use the const correct ASN1_STRING_get0_data(). Arguably, in most
places the better fix would be to reach into ASN1_STRING but then we
have to think and bikeshed...
ok beck kenjiro
libcrypto: make most of the BN_* macro pollution internal
This is a first sweep of reducing the number of terribly named macros
in bn.h More can go away. Those we need internally go to bn_local.h.
Annoyingly bn_internal.h uses some of them, so it includes bn_local.h
now. This can be cleaned up later.
ok jsing kenjiro
qt5/qtbase: convert to opaque ASN1_STRING
Similar to what was done to the bundled qt4 in wkhtmltopdf: const correct
q_ASN1_STRING_length(), add _type() and use them where needed.
Prompted by https://github.com/openssl/openssl/issues/29117
