Displaying 1 50 of 184,603 commits (0.030s)

OpenBSD — usr.bin/ssh sshd.c

might as well set the listener socket CLOEXEC
Delta File
+6 -1 usr.bin/ssh/sshd.c
+6 -1 1 file

OpenBSD — lib/libc/arch/aarch64/sys sigpending.S

The assembly for sigpending(2) wasn't correctly implemented either.  I
suppose this still stems from the first steps where we tried to get at
least some userland stuff to compile.  This change properly saves the
pointer before doing the syscall and stores the return value in the
pointer on return.  This makes sigpending regress pass.

OpenBSD — bin/md5 md5.1, lib/libc/hash sha1.3

SHA-1 collisions have now been found so update some man pages. As noted by
minek van on misc@. Thanks.

ok tb@, tj@

(and jmc@ is ok with the diff but can't ok the technical content).
Delta File
+9 -5 lib/libc/hash/sha1.3
+4 -9 bin/md5/md5.1
+13 -14 2 files

OpenBSD — lib/libc/hash md5.3

Replace use of mathematical minus with an em-dash (from tb@) and break up
a long sentence (from tj@).
Delta File
+5 -5 lib/libc/hash/md5.3
+5 -5 1 file

OpenBSD — gnu/usr.bin/binutils-2.17/bfd elf64-aarch64.c

Set ELF_MAXPAGESIZE to 64k, to match lld(1).  Also define ELF_MINPAGESIZE.

ok patrick@, jsg@

OpenBSD — lib/libc/asr asr.c getnetnamadr_async.c

Put a common subq pointer in the query struct, rather than one in each
element of the union.

ok gilles@ millert@ krw@

OpenBSD — regress/lib/libcrypto/bn/general bntest.c

Check return value of every BN_* functions in bntest
- add macro CHECK_GOTO
- unify function return code to rc
- add err: label for error goto
ok bcook@
Delta File
+426 -393 regress/lib/libcrypto/bn/general/bntest.c
+426 -393 1 file

OpenBSD — etc/examples pkg.conf

Delta File
+2 -2 etc/examples/pkg.conf
+2 -2 1 file

OpenBSD — etc/examples pkg.conf

Delta File
+2 -2 etc/examples/pkg.conf
+2 -2 1 file

OpenBSD — sys/dev/pv hypervic.c

Add missing mtx_leave() calls in two hypervic error paths

ok mikeb@
Delta File
+6 -2 sys/dev/pv/hypervic.c
+6 -2 1 file

OpenBSD — usr.bin/bc bc.y

- write parse errors to stderr, prompted by Martijn Dekker
- we're only interactive if stdout en stderr are a tty as well as stdin
Delta File
+4 -3 usr.bin/bc/bc.y
+4 -3 1 file

OpenBSD — usr.bin/dc bcode.c dc.1

Introduce e command, equivalent to p, but writes to stderr
Delta File
+15 -1 usr.bin/dc/bcode.c
+6 -2 usr.bin/dc/dc.1
+21 -3 2 files

OpenBSD — sys/sys percpu.h

be nicer to 32bit strict alignment archs that can do 64bit loads/stores.

ie, align boot memory to the size of uint64_ts.

there's an argument to be made that we should align this to 16 bytes
to be consistent with malloc and pools.
Delta File
+2 -2 sys/sys/percpu.h
+2 -2 1 file

OpenBSD — sys/arch/arm64/conf GENERIC RAMDISK

Enable ahci(4).

ok kettenis@

OpenBSD — sys/dev/fdt ahci_fdt.c files.fdt

Add a generic ahci(4) frontend for FDT.

ok kettenis@
Delta File
+113 -0 sys/dev/fdt/ahci_fdt.c
+5 -1 sys/dev/fdt/files.fdt
+118 -1 2 files

OpenBSD — sys/arch/arm64/arm64 bus_dma.c, sys/arch/arm64/dev simplebus.c mainbus.c

The AMD Seattle SoC incorporates DMA coherent controllers, especially
AHCI, PCIe and Ethernet.  Since these systems rely on cache snooping,
we must not map pages that are supposed to be coherent as uncacheable.
Instead if we have a cache coherent device, create a bus tag and mark
that tag as coherent.  For users of that tag we can simply use normal,
cached memory.

ok kettenis@

OpenBSD — lib/libc/arch/aarch64/sys sigprocmask.S

The assembly for sigprocmask(2) had a tiny typo which made it jump to
the wrong location, thus not making it set SIG_BLOCK with a zero mask
when attempting to read the signal mask (if set ptr is NULL).  Instead
an attempt to read the mask actually told the syscall to set the mask
to zero.

OpenBSD — sys/dev/acpi acpisbs.c

fix timeout loop

from Anton Lindqvist
Delta File
+2 -8 sys/dev/acpi/acpisbs.c
+2 -8 1 file

OpenBSD — distrib/sets/lists/comp mi

Delta File
+1 -0 distrib/sets/lists/comp/mi
+1 -0 1 file

OpenBSD — sys/kern uipc_proto.c, sys/net pfkey.c rtsock.c

Use c99 struct initialization with protosw.

This makes it easier to grep for a member, such as .pr_usrreq, and know
which functions to review.

ok mpi@ bluhm@ jca@

OpenBSD — sys/arch/amd64/conf GENERIC, sys/dev/acpi acpisbs.c smbus.h

add acpisbs, an acpi smart battery subsystem driver reading data
over smbus

currently disabled because it conflicts with acpibat

ok deraadt, kettenis

OpenBSD — usr.bin/mandoc cgi.c

Pledge man.cgi(8).
Based on a more complicated patch from semarie@.
Sebastien and tb@ both agree with the simplification.
Delta File
+15 -1 usr.bin/mandoc/cgi.c
+15 -1 1 file

OpenBSD — sys/net pfvar.h

Amend a misleading comment mentioning ``ipintrq''.
Delta File
+2 -2 sys/net/pfvar.h
+2 -2 1 file

OpenBSD — usr.bin/mandoc main.c

Since SQLite is gone, we no longer need the "flock" pledge.
Patch from semarie@, OK tb@.
Delta File
+3 -3 usr.bin/mandoc/main.c
+3 -3 1 file

OpenBSD — usr.sbin/ldapd btest.c

print a formatted errx() string instead of segfault,
by checking argc correctly.

ok guenther@
Delta File
+2 -2 usr.sbin/ldapd/btest.c
+2 -2 1 file

OpenBSD — regress/usr.sbin/ldapd Makefile

ldapd regress tests depends on openldap-client, check
if that package is installed, otherwise print
a warning and skip them but not fail.

requested by/ok mpi@
Delta File
+10 -1 regress/usr.sbin/ldapd/Makefile
+10 -1 1 file

OpenBSD — usr.sbin/eigrpd interface.c parse.y

No need to use SIOCGIFRDOMAIN anymore.

OpenBSD — usr.sbin/eigrpctl eigrpctl.c eigrpctl.8

Allow specifying an alternate socket path.

OpenBSD — usr.bin/sed process.c

Remove unused-with-dead-store variable oldpsanl.

From Daniel Cegielka - thanks

ok jca@
Delta File
+1 -3 usr.bin/sed/process.c
+1 -3 1 file

OpenBSD — usr.sbin/bgpd parse.y pfkey.c

Add missing htonl for IPsec SPI.

Also, do not allow to configure SPI values in the 0..255 range. RFC 4302
and RFC 4303 say the following:
"The set of SPI values in the range 1 through 255 are reserved by the
Internet Assigned Numbers Authority (IANA) for future use; a reserved
SPI value will not normally be assigned by IANA unless the use of the
assigned SPI value is specified in an RFC.  The SPI value of zero (0)
is reserved for local, implementation-specific use and MUST NOT be
sent on the wire".

ok and tweak benno@
Delta File
+3 -2 usr.sbin/bgpd/parse.y
+2 -2 usr.sbin/bgpd/pfkey.c
+5 -4 2 files

OpenBSD — sys/netinet6 in6.h

Fix comments about a few ipv6 sockoptions

OK millert@ florian@
Delta File
+4 -4 sys/netinet6/in6.h
+4 -4 1 file

OpenBSD — sbin/ping ping.c

Unbreak "ping6 -L"

$ ping6 -L ff02::1%em1
ping6: setsockopt IP6_MULTICAST_LOOP: Invalid argument

Unfortunately we have this inconsistency in the sockets API where we need
to pass an unsigned char for IP_MULTICAST_LOOP but we need an unsigned

While here, fix a typo in the error message.

OK millert@ florian@
Delta File
+9 -4 sbin/ping/ping.c
+9 -4 1 file

OpenBSD — sys/nfs nfs_var.h nfs_vnops.c

Keep local definitions local.

"good work" deraadt@, ok visa@
Delta File
+1 -70 sys/nfs/nfs_var.h
+55 -1 sys/nfs/nfs_vnops.c
+15 -1 sys/nfs/nfs_vfsops.c
+1 -15 sys/nfs/nfsmount.h
+10 -2 sys/nfs/nfs_syscalls.c
+11 -1 sys/nfs/nfs_socket.c
+9 -9 4 files not shown
+102 -99 10 files

OpenBSD — regress/sys/kern/pledge Makefile

Enable semarie's sendrecvfd tests
Delta File
+2 -1 regress/sys/kern/pledge/Makefile
+2 -1 1 file

OpenBSD — regress/sys/kern/pledge/sendrecvfd sendrecvfd.c Makefile

Add regress tests for fd passing and pledge. Check sending and receiving
all 7 types of vnodes as follows:
  - nopledge:         no pledge - verify that send/recv work as expected
  - sendfd:         pledge the sender with "stdio sendfd"
  - recvfd:         pledge the receiver with "stdio recvfd"
  - nosendfd:         pledge the sender with "stdio" (it is expected to fail)
  - norecvfd:         pledge the receiver with "stdio" (it is expected to fail)
This results in 35 possible combinations with different semantics depending
on the vnode type.

From semarie, many thanks!

OpenBSD — sys/kern sys_socket.c

Do not grab the NET_LOCK() when poll(2)ing on unix domain sockets.

Fix the 'X freeze' while scanning with wireless interfaces.  Problem
reported by pirofti@.

ok tb@, bluhm@
Delta File
+3 -3 sys/kern/sys_socket.c
+3 -3 1 file

OpenBSD — usr.sbin/npppd/npppd npppd.conf.5

The default for the strip-nt-domain attribute is "yes", so fix up
the manpage to not tell lies.

ok yasuoka@
Delta File
+3 -3 usr.sbin/npppd/npppd/npppd.conf.5
+3 -3 1 file

OpenBSD — sys/net bpf.h

The pcap people gave us ID 267 for DLT_OPENFLOW

Via https://github.com/the-tcpdump-group/libpcap/issues/542

OK sthen@ jsg@
Delta File
+2 -2 sys/net/bpf.h
+2 -2 1 file

OpenBSD — usr.bin/tmux grid.c key-string.c

Minor bits: fix an array size, add comment, make grid_cell_entry static.

OpenBSD — usr.bin/mandoc mdoc_html.c

Handle an odd edge case where .It is preceded by .Sm.
NULL dereference in man.cgi reported by Gabriel Guzman <gabe at
guzman dash nunez dot com> on misc@.
Delta File
+2 -1 usr.bin/mandoc/mdoc_html.c
+2 -1 1 file

OpenBSD — usr.sbin/npppd/npppd npppd_auth.c

Delete lines which are misleading and unneeded.
spotted patrick
Delta File
+2 -5 usr.sbin/npppd/npppd/npppd_auth.c
+2 -5 1 file

OpenBSD — sys/arch/arm64/dev bcm2835_dwctwo.c, sys/arch/armv7/broadcom bcm2835_dwctwo.c

Set sc_vendor in bcm2835_dwctwo before calling dwc2_init().

This changes the root hub dmesg output from
"vendor 0x0000 DWC2 root hub" to "Broadcom DWC2 root hub".

ok kettenis@

OpenBSD — share/man/man7 roff.7

fix spelling error;
found by Michael <Stapelberg at debian dot org> with Lintian
Delta File
+3 -3 share/man/man7/roff.7
+3 -3 1 file

OpenBSD — lib/libc/asr getaddrinfo_async.c getnetnamadr_async.c

missing breaks

ok jca@ krw@ gilles@

OpenBSD — regress/sys/kern/pledge/ioctl Makefile

Remove SUDO=doas in regress Makefile.  The test developer must not
set the SUDO variable.  The tester may decide wether he runs doas,
sudo or the whole test as root.
discussed with tb@ semarie@ benno@

OpenBSD — usr.bin/tmux tty.c

Change pane redraw to collect cells up as well, and simplify it a bit.
Delta File
+44 -24 usr.bin/tmux/tty.c
+44 -24 1 file

OpenBSD — sys/conf GENERIC

temporarily disable BFD, to not block work on unlocking the socket layer.

requested by deraadt@
Delta File
+2 -2 sys/conf/GENERIC
+2 -2 1 file

OpenBSD — regress/sys/kern/pledge/generic test_tty.c Makefile

Make test_request_tty() also pass in environments without tty by opening a
pseudo-tty and testing on the slave instead of stderr.

nicm confirms that this approach is fine
bluhm tested in his environment and the tests now pass

from semarie

OpenBSD — sys/netinet6 ip6_output.c

In ip6_ctloutput, check for an invalid level early like the other
*ctloutput functions.  This also reduces a level of indentation.

ok mpi@
Delta File
+432 -432 sys/netinet6/ip6_output.c
+432 -432 1 file

OpenBSD — lib/libssl ssl_ciph.c ssl_locl.h

Remove STREEBOG 512 as a TLS MAC since there are currently no cipher suites
that make use of it.

ok bcook@ inoguchi@
Delta File
+4 -22 lib/libssl/ssl_ciph.c
+2 -4 lib/libssl/ssl_locl.h
+6 -26 2 files