FreeBSD/src 55b89b7 — sys/dev/sound/pcm dsp.c

sound: Unlock the channel when chn_reset() fails in dsp_chn_alloc()

If chn_reset() fails, dsp_chn_alloc() returns with the channel lock
held, dsp_open() calls dsp_close() as part of its cdevpriv error path,
and this causes both a mutex recursion on the channel lock in
dsp_close(), as well a lock order reversal.

Fixes:          02d4eeabfd73 ("sound: Allocate vchans on-demand")
Reported by:    llm-postcr
MFC after:      Immediately
Sponsored by:   The FreeBSD Foundation
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D61793

(cherry picked from commit 01a8cd5ebe9368fd115fb5060bcb1e60d1bbdf1f)
DeltaFile
+3-1sys/dev/sound/pcm/dsp.c
+3-11 files

FreeBSD/src 01a8cd5 — sys/dev/sound/pcm dsp.c

sound: Unlock the channel when chn_reset() fails in dsp_chn_alloc()

If chn_reset() fails, dsp_chn_alloc() returns with the channel lock
held, dsp_open() calls dsp_close() as part of its cdevpriv error path,
and this causes both a mutex recursion on the channel lock in
dsp_close(), as well a lock order reversal.

Fixes:          02d4eeabfd73 ("sound: Allocate vchans on-demand")
Reported by:    llm-postcr
MFC after:      Immediately
Sponsored by:   The FreeBSD Foundation
Reviewed by:    markj
Differential Revision:  https://reviews.freebsd.org/D61793
DeltaFile
+3-1sys/dev/sound/pcm/dsp.c
+3-11 files

FreeBSD/src 2cb4abf — sys/compat/linux linux_if.c

linux: Destroy the per-VNET unit allocator after the cloners

linux_ifnet_vnet_uninit() deletes the unit number allocator that
linux_ifnet_departure() frees into.  It ran at SI_SUB_INIT_IF,
SI_ORDER_ANY, the same slot in which lagg, vlan, edsc and ng_eiface
destroy the interfaces left in a dying vnet.  Destructors of equal order
run in the reverse of the order their modules were loaded, so with
linux_common loaded after if_lagg the allocator was gone by the time
vnet_lagg_uninit() detached its interfaces, and removing a vnet jail that
still held a lagg interface panicked in free_unr().

Commit a23901a37be9 moved the destructor from SI_SUB_PROTO_IF to
SI_SUB_INIT_IF for the cloners that tear down earlier, which left this
tie.

Run the destructor at SI_ORDER_FIRST, which is after every destructor of
a later order in the same subsystem, whatever the load order.  Move the
constructor with it.


    [6 lines not shown]
DeltaFile
+6-2sys/compat/linux/linux_if.c
+6-21 files

FreeBSD/src af641e9 — sys/compat/linuxkpi/common/include/linux mm.h io.h, sys/dev/qat/include/common qat_freebsd.h

LinuxKPI: Include <linux/fs.h> from <linux/mm.h>

and <linux/kernel.h> from <linux/io.h>.
This reproduces the same namespace pollution as Linux and will help us
to fix historical bug when these files were included from <linux/fb.h>.
Fix conflicting Linux name leakage appeared in qat(4) as result.

Differential Revision:  https://reviews.freebsd.org/D60798
DeltaFile
+9-0sys/dev/qat/include/common/qat_freebsd.h
+1-0sys/compat/linuxkpi/common/include/linux/mm.h
+1-0sys/compat/linuxkpi/common/include/linux/io.h
+11-03 files

FreeBSD/src 40e7264 — sys/compat/linuxkpi/common/include/linux page-flags.h pagemap.h

LinuxKPI: Add mapping_gfp_mask() and four more folio/pagemap helpers

Adds mapping_gfp_mask(), mapping_gfp_constraint(), mapping_set_unevictable(),
folio_page() and folio_file_page(), which Linux's drm_gem_get_pages() uses.
drm-kmod carries them in an overlay for virtio-gpu (freebsd/drm-kmod#517) today.

The mask is GFP_KERNEL, as shmem page allocation may sleep and ignores
the other flags. folio_page() and folio_file_page() are exact copies
from D58763, to not clash with it.

Signed-off-by:  Denis Borovikov <denis.borovikov at gmail.com>
Reviewed by:    wulf
Differential Revision:  https://reviews.freebsd.org/D61217
DeltaFile
+24-0sys/compat/linuxkpi/common/include/linux/pagemap.h
+8-0sys/compat/linuxkpi/common/include/linux/page-flags.h
+32-02 files

FreeBSD/src 9e4dfe6 — sys/compat/linuxkpi/common/src linux_pci.c, sys/modules/linuxkpi Makefile

LinuxKPI: Add PCI method for transferring framebuffer parameters

from LKPI video driver to FreeBSD native framebuffer driver.
This makes possible to attach framebuffer driver in traditional way
using newbus interface rather than direct calls into vt internals.
It is required to make LKPI framebuffer driver compatible with
fbd/vt_fb. As a consequence that allows us to switch back to vt_fb on
radeon driver where vt_drmfb regressions have been reported [1].

The method expects fbd device ivars pointed to FreeBSD fb_info
structure embedded in to Linux fb_info structure. See linux/fb.h.
Note that some out-of-tree non-PCI drm drivers may require similar
changes in parent bus drivers.

[1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=285088

PR:             285088
Differential Revision:  https://reviews.freebsd.org/D60038
DeltaFile
+23-0sys/compat/linuxkpi/common/src/linux_pci.c
+1-1sys/modules/linuxkpi/Makefile
+24-12 files

FreeBSD/src 2f1acc5 — sys/conf kern.post.mk

kern: Have .m rules depend sys/tools/makeobjops.awk

Generated _if.[ch] files have to be rebuilt after commit bf362c1b41c8
("kobj: convert KOBJOPLOOKUP() to returning pointer to function").  Add
a dependency on the build tool, similar to kmod.mk.

Build rules using NORMAL_M (defined in kern.pre.mk) presumably need a
similar treatment, but this restores (most of) the incremental build
now.

Reviewed by:    jrtc27
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D61821
DeltaFile
+2-2sys/conf/kern.post.mk
+2-21 files

FreeBSD/src e61c4b8 — lib/libexecinfo/tests sigtramp_test.c

tests/sigtramp_test: re-enable test on aarch64

This now passes on both aarch64 (since 6a936d939b88)
and amd64. It still fails on other architectures, so
keep the xfail.

PR:             289096
Sponsored by:   The FreeBSD Foundation
DeltaFile
+2-6lib/libexecinfo/tests/sigtramp_test.c
+2-61 files

FreeBSD/src 138bce7 — usr.sbin/chroot chroot.8 chroot.c

chroot(8): add altroot mode

Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D60035
DeltaFile
+36-14usr.sbin/chroot/chroot.c
+25-0usr.sbin/chroot/chroot.8
+61-142 files

FreeBSD/src 25f21bb — sys/sys user.h

sys/user.h: make KF_FD_TYPE macros safer

Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D60035
DeltaFile
+6-6sys/sys/user.h
+6-61 files

FreeBSD/src c97671a — usr.bin/procstat procstat.1 procstat_files.c

procstat(1): teach about altroot

Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D60035
DeltaFile
+1-1usr.bin/procstat/procstat.1
+2-0usr.bin/procstat/procstat_files.c
+3-12 files

FreeBSD/src face51f — usr.bin/fstat fuser.c fstat.c

fstat(1), fuser(1): teach about altroot

Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D60035
DeltaFile
+4-1usr.bin/fstat/fuser.1
+4-1usr.bin/fstat/fstat.1
+2-0usr.bin/fstat/fstat.c
+1-0usr.bin/fstat/fuser.c
+11-24 files

FreeBSD/src f92ba77 — lib/libprocstat libprocstat.h libprocstat.c

libprocstat(3): teach about altroot

Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D60035
DeltaFile
+9-0lib/libprocstat/libprocstat.c
+1-0lib/libprocstat/libprocstat.h
+10-02 files

FreeBSD/src 8cfae68 — sys/kern kern_descrip.c, sys/sys user.h

kinfo: export altroot

Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D60035
DeltaFile
+7-0sys/kern/kern_descrip.c
+1-0sys/sys/user.h
+8-02 files

FreeBSD/src 29691ec — lib/libsys cap_enter.2

cap_enter.2: document clearing altroot

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D60035
DeltaFile
+2-0lib/libsys/cap_enter.2
+2-01 files

FreeBSD/src dae40d1 — lib/libsys chroot.2

fchroot.2: document ENOTCAPABLE for O_RESOLVE_BENEATH

Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D60035
DeltaFile
+9-0lib/libsys/chroot.2
+9-01 files

FreeBSD/src 14016b7 — sys/compat/freebsd32 freebsd32_syscall.h freebsd32_systrace_args.c, sys/kern systrace_args.c

Regen
DeltaFile
+44-0sys/kern/systrace_args.c
+44-0sys/compat/freebsd32/freebsd32_systrace_args.c
+10-0sys/sys/sysproto.h
+3-1sys/sys/syscall.mk
+3-1sys/sys/syscall.h
+3-1sys/compat/freebsd32/freebsd32_syscall.h
+107-36 files not shown
+123-312 files

FreeBSD/src 9757c0c — sys/kern syscalls.master vfs_syscalls.c, sys/sys unistd.h

chaltroot(2) and fchaltroot(2): new syscalls

to change the altroot AKA ABI root for native processes

Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D60035
DeltaFile
+85-0sys/kern/vfs_syscalls.c
+10-0sys/kern/syscalls.master
+2-0sys/sys/unistd.h
+97-03 files

FreeBSD/src 06ec614 — sys/kern kern_descrip.c

pwd_altroot(9): expand herald comment

Requested and reviewed by:      markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D60035
DeltaFile
+5-1sys/kern/kern_descrip.c
+5-11 files

FreeBSD/src 4333964 — sys/kern kern_descrip.c

pwd_altroot(): avoid creating new pwd structure if altroot does not change

Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D60035
DeltaFile
+13-16sys/kern/kern_descrip.c
+13-161 files

FreeBSD/src 06c455d — sys/compat/linux linux_util.c, sys/kern kern_descrip.c

vfs: guard against altroot pointing to not a directory

Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D60035
DeltaFile
+7-2sys/compat/linux/linux_util.c
+4-1sys/kern/kern_descrip.c
+1-1sys/sys/filedesc.h
+12-43 files

FreeBSD/src f2ee207 — include unistd.h, lib/libsys Symbol.sys.map

chaltroot(2)/fchaltroot(2): make accessible to userspace

Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D60035
DeltaFile
+2-0lib/libsys/Symbol.sys.map
+2-0include/unistd.h
+4-02 files

FreeBSD/src e880b7a — sys/security/mac mac_framework.h mac_policy.h, sys/security/mac_stub mac_stub.c

mac(4): add vnode_check_chaltroot

Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D60035
DeltaFile
+18-0sys/security/mac/mac_vfs.c
+15-0sys/security/mac_test/mac_test.c
+9-0sys/security/mac_stub/mac_stub.c
+3-0sys/security/mac/mac_policy.h
+1-0sys/security/mac/mac_framework.h
+46-05 files

FreeBSD/src 3dac774 — sys/bsm audit_kevents.h, sys/security/audit audit_bsm.c

sys: add AUE_CHALTROOT and AUE_FCHALTROOT

Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D60035
DeltaFile
+2-0sys/security/audit/audit_bsm.c
+2-0sys/bsm/audit_kevents.h
+4-02 files

FreeBSD/src db5ea29 — sys/kern sys_capability.c

cap_enter(2): clear altroot when entering cap mode.

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D60035
DeltaFile
+5-0sys/kern/sys_capability.c
+5-01 files

FreeBSD/src 763f6cc — lib/libsys Makefile.sys chroot.2

chroot.2: document chaltroot(2)

Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D60035
DeltaFile
+111-17lib/libsys/chroot.2
+3-1lib/libsys/Makefile.sys
+114-182 files

FreeBSD/src 151a23f — sys/kern vfs_lookup.c

namei: disallow altroot for beneath lookups

Once namei_setup() has determined that the lookup is strictly relative,
set ni_rootdir to pwd_rdir and mark the lookup as already restarted,
which effectively disables restart on ENOENT.

This is done in namei_setup() and not in NDINIT(), because RBENEATH
might be set after NDINIT() by vn_open_cred() or inherited from
the dirfd in fgetvp_lookup(), and ISRESTARTED is cleared by
NDREINIT()/NDRESET().

Noted by:       markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D60035
DeltaFile
+7-0sys/kern/vfs_lookup.c
+7-01 files

FreeBSD/src 2137bad — sys/kern kern_exec.c

exec_new_vmspace(): drop altroot for native processes if setuid

Noted and reviewed by:  markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D60035
DeltaFile
+14-0sys/kern/kern_exec.c
+14-01 files

FreeBSD/src b5a5feb — lib/libsysdecode mktables

libsysdecode: Avoid non-portable \> word end boundary in mktables

Whilst we bootstrap our own sed when building on non-FreeBSD, it uses
the system regex(3) implementation, and so inherits its extensions, not
our own. Our implementation and glibc's both include this extension to
POSIX, but macOS's does not, and so even with our bootstrap sed we
cannot use the \> extension when built and run on macOS.

Unfortunately, there is no alternative form we can use; whilst macOS
implements [[:>:]] as an extension that provides this same feature, and
so do we, the regex(3) implementation in glibc does not, and the only
alternative glibc offers is \b, which neither us nor macOS implement.

We could make the form used conditional on the OS, but that starts to
get messy once other Linux libcs enter the picture, which in theory we
somewhat support.

Rewrite both uses to avoid the need for \>. For gen_table, use a pattern
to match the identifier that is precisely the (non-extended) C99

    [23 lines not shown]
DeltaFile
+2-2lib/libsysdecode/mktables
+2-21 files

FreeBSD/src 76212e6 — libexec/nuageinit/tests adduser.lua

nuageinit: Fix typo, whitespace, and lua style in new test

Fixes: e82b8378de19 ("nuageinit: Also add -n to pw usermod and pw groupshow")
Sponsored by:   The FreeBSD Foundation
DeltaFile
+3-3libexec/nuageinit/tests/adduser.lua
+3-31 files