FreeBSD/src dcc684dlib/libc/stdlib system.3

system(3): Use plural form of 'command'

Pick the plural form in the sentence about running arbitrary commands in
the security consideration section.

PR:         294497
Event:      Halifax Hackathon 202606
Location:   Couch
DeltaFile
+1-1lib/libc/stdlib/system.3
+1-11 files

FreeBSD/src 0cedb62sys/dev/iicbus iichid.c

iichid(4): Always release interrupt resource

Reviewed by:    aokblast
Event:          Halifax Hackathon 202606
Location:       Chair
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D57886
DeltaFile
+4-4sys/dev/iicbus/iichid.c
+4-41 files

FreeBSD/src 7fff1f1share/man/man4 netlink.4

netlink.4: Document missing socket options

Add descriptions for NETLINK_GET_STRICT_CHK, NETLINK_MSG_INFO.

Reviewed by:    ziaee, obiwac
Differential Revision:  https://reviews.freebsd.org/D57520
DeltaFile
+6-0share/man/man4/netlink.4
+6-01 files

FreeBSD/src b207b15sys/sys systm.h

sys/systm.h: use __nodiscard consistently and correctly

__nodiscard is closer to (and sometimes expands to) [[nodiscard]] from
C23 and C++17 so prefer it to the homegrown __result_use_check and put
it in the right place so it is correct when expanded to [[nodiscard]].

Reviewed by:    markj, emaste
Sponsored by:   DARPA, AFRL
Differential Revision:  https://reviews.freebsd.org/D57882
DeltaFile
+6-6sys/sys/systm.h
+6-61 files

FreeBSD/src 2515e3fshare/man/man9 cdefs.9

cdefs(9): encourage __nodiscard over __result_use_check

__nodiscard is closer to (and sometimes expands to) [[nodiscard]] from
C23 and C++17 so prefer it to the homegrown __result_use_check.

When __nodiscard does expand to [[nodiscard]] it must appear entierly
before the function declaration (or between the function name
and argument list) so relocate as appropriate.  This differs from
__attribute__((__warn_unused_result__)) used by __result_use_check which
is more flexible.

Reviewed by:    imp, markj, emaste
Sponsored by:   DARPA, AFRL
Differential Revision:  https://reviews.freebsd.org/D57881
DeltaFile
+7-1share/man/man9/cdefs.9
+7-11 files

FreeBSD/src 62bb16clib/msun/tests nan_test.c

lib/msun/tests: re-enable nan_test on riscv

Commit 1e25cda7f06923d05e28dac8eb1c1c428a5c92dc fixed it.

MFC after:      3 days
Sponsored by:   The FreeBSD Foundation

(cherry picked from commit 52ad4f883489f73e7a876f5cf296bb5a7dc696a2)
DeltaFile
+0-3lib/msun/tests/nan_test.c
+0-31 files

FreeBSD/src 487e1d0lib/msun/tests logarithm_test.c

msun/logarithm_test: expect_fail log1p_accuracy_tests in the correct spot

While here, remove the conditional on the "ci" config var to ensure that
this is reproducible locally as well.

This fixes a case where we are expecting a fail before the failing ATF_CHECK_*
assertion happens. Found in a CI failure here:
https://ci.freebsd.org/job/FreeBSD-main-riscv64-test/16608/testReport/lib.msun/logarithm_test/log1p_accuracy_tests/

PR:             253984
Fixes:          405188aeac540f7666dfde37c2f32d222119f56e
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D57351

(cherry picked from commit 19af9c77acc912e4bf90a667924f5f4ff78a7759)
DeltaFile
+3-4lib/msun/tests/logarithm_test.c
+3-41 files

FreeBSD/src f08d536lib/msun/tests invctrig_test.c logarithm_test.c

lib/msun/tests: xfail remaining failing tests on non-x86 archs

These are the remaining trivial xfail cases where no other
test logic changes are necessary.

Signed-off-by: Siva Mahadevan <me at svmhdvn.name>
PR:             290099
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1871
(cherry picked from commit 405188aeac540f7666dfde37c2f32d222119f56e)
DeltaFile
+15-0lib/msun/tests/invctrig_test.c
+9-2lib/msun/tests/logarithm_test.c
+9-0lib/msun/tests/ctrig_test.c
+9-0lib/msun/tests/next_test.c
+9-0lib/msun/tests/fma_test.c
+3-1lib/msun/tests/trig_test.c
+54-35 files not shown
+69-311 files

FreeBSD/src a55f946lib/msun/tests lrint_test.c

lib/msun/tests: xfail failing lrint_test cases on non-x86 archs

Replace ATF_CHECK_* with ATF_REQUIRE_* to fail fast and avoid
unexpected aborts.

Signed-off-by: Siva Mahadevan <me at svmhdvn.name>
PR:             290099
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1871
(cherry picked from commit de601d5bf5c6d2409134abc4638c7a0818cc896e)
DeltaFile
+5-2lib/msun/tests/lrint_test.c
+5-21 files

FreeBSD/src 20806e7lib/msun/tests invtrig_test.c

lib/msun/tests: xfail failing invtrig_test cases on non-x86

Replace ATF_CHECK_* with ATF_REQUIRE_* to fail fast and avoid
unexpected abort.

PR:             290099
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1871

(cherry picked from commit 5a0617454e37c6a3df4106c24bd5ad20b338fe3a)
DeltaFile
+19-7lib/msun/tests/invtrig_test.c
+19-71 files

FreeBSD/src 4a07cffcontrib/netbsd-tests/lib/libm t_fe_round.c

lib/msun/tests: xfail fe_round on riscv64

Replace ATF_CHECK_* with ATF_REQUIRE_* to fail fast and
avoid unexpected aborts.

Signed-off-by: Siva Mahadevan <me at svmhdvn.name>
PR:             290099
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1871
(cherry picked from commit 6c18c40b29fd5ac66230af34726260ce2d47aecd)
DeltaFile
+5-2contrib/netbsd-tests/lib/libm/t_fe_round.c
+5-21 files

FreeBSD/src d87110blib/msun/tests test-utils.h

lib/msun/tests: Add REQUIRE_ variants of test-utils macros

Signed-off-by: Siva Mahadevan <me at svmhdvn.name>
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1871
(cherry picked from commit a9b1650f90f4dbc62baa52b395082b1714b6cbf3)
DeltaFile
+30-15lib/msun/tests/test-utils.h
+30-151 files

FreeBSD/src a90616ccontrib/netbsd-tests/lib/libm t_fe_round.c, lib/msun/tests fmaxmin_test.c

lib/msun/tests: Remove newlines in ATF msgs

This fixes broken test reports with the following message:

lib/msun/fe_round_test:fe_round  ->  broken: Test result contains
multiple lines: expected_failure:
/usr/src/contrib/netbsd-tests/lib/libm/t_fe_round.c:95: Didn't get the
same rounding mode out!<<NEWLINE>>(index 0) fed in 64 rounding mode, got
0 out<<NEWLINE>>  [0.079s]

Signed-off-by: Siva Mahadevan <me at svmhdvn.name>
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1871
(cherry picked from commit ec640742e30270098f8d982c1c0838f2dfde9ad5)
DeltaFile
+12-12contrib/netbsd-tests/lib/libm/t_fe_round.c
+1-1lib/msun/tests/fmaxmin_test.c
+13-132 files

FreeBSD/src 548a058lib/msun/tests fma_test.c ctrig_test.c

lib/msun/tests: Replace remaining printf() with debug()

Signed-off-by: Siva Mahadevan <me at svmhdvn.name>
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1871
(cherry picked from commit d03c9b8f662466537753056608d6a64d8c5513c3)
DeltaFile
+4-4lib/msun/tests/fma_test.c
+3-3lib/msun/tests/ctrig_test.c
+7-72 files

FreeBSD/src 35f572eusr.bin/lorder/tests lorder_test.sh Makefile

tests/lorder_test: Add require.progs for nm and cc

Signed-off-by: Siva Mahadevan <me at svmhdvn.name>
Sponsored by:   The FreeBSD Foundation
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1858
(cherry picked from commit 66d2816407c32a0da0f039c4edb4f19b280f9bb5)
DeltaFile
+4-0usr.bin/lorder/tests/lorder_test.sh
+2-0usr.bin/lorder/tests/Makefile
+6-02 files

FreeBSD/src d4459e2tests/sys/netinet6/frag6 frag6_07.sh

Unskip test sys.netinet6.frag6.frag6_07.frag6_07

This is now consistently passing with 100+ consecutive runs.

Signed-off-by: Siva Mahadevan <me at svmhdvn.name>
PR:             244170
MFC after:      3 days
Sponsored by: The FreeBSD Foundation
(cherry picked from commit 681e9d3e391f30a512c523514f69a63c9782a901)
DeltaFile
+0-3tests/sys/netinet6/frag6/frag6_07.sh
+0-31 files

FreeBSD/src 73ff854tests/sys/net if_lagg_test.sh

tests/if_lagg_test: unskip 'witness' testcase

This testcase passes consistently (in 100+ runs) now.

Signed-off-by:  Siva Mahadevan <me at svmhdvn.name>
PR:             244163, 251726
MFC after:      3 days
Sponsored by:   The FreeBSD Foundation

(cherry picked from commit 7a83fedc116d827cc9c6d8e049b785f1d7b68dcd)
DeltaFile
+0-3tests/sys/net/if_lagg_test.sh
+0-31 files

FreeBSD/src 7720083tests/sys/netinet fibs_test.sh

tests/fibs_test: unskip udp_dontroute6 testcase

This test now consistently passes (300+ consecutive runs).

Signed-off-by:  Siva Mahadevan <me at svmhdvn.name>
PR:             244172
Sponsored by:   The FreeBSD Foundation

(cherry picked from commit e93e57d3da2ea54598b5db01cc12a3acd656faba)
DeltaFile
+0-3tests/sys/netinet/fibs_test.sh
+0-31 files

FreeBSD/src 0bc4bedtests/sys/mac/portacl Makefile

tests/mac_portacl: enable is_exclusive for now

Both tests rely on ports 77 and 7777 to be available
and thus cannot be run concurrently. This is a temporary
measure to ensure that they don't conflict with each other.

In the future, these should be rewritten to wait until the
necessary ports are available, or deterministically select a
free port instead.

Signed-off-by: Siva Mahadevan <me at svmhdvn.name>
Sponsored by:   The FreeBSD Foundation
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1790
(cherry picked from commit 5dadfac51c3876b0ba6fde831cb4417594167fed)
DeltaFile
+1-0tests/sys/mac/portacl/Makefile
+1-01 files

FreeBSD/src 2fb507flib/libcasper/services/cap_net/tests net_test.c

cap_net/net_test: require 'allow_network_access'

Signed-off-by: Siva Mahadevan <me at svmhdvn.name>

Sponsored by:   The FreeBSD Foundation
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1779

(cherry picked from commit df88c711a26c04192761e96dc08a6f3f9e42afed)
DeltaFile
+140-28lib/libcasper/services/cap_net/tests/net_test.c
+140-281 files

FreeBSD/src 675eccctests/sys/netpfil/common dummynet.sh, tests/sys/netpfil/pf forward.sh killstate.sh

tests/sys/netpfil: unskip tests that no longer need to be skipped

All of these are passing consistently in the latest CI environment
in 15 back-to-back test runs.

Signed-off-by:  Siva Mahadevan <me at svmhdvn.name>

PR:             260458, 260459, 260460, 264805
Sponsored by:   The FreeBSD Foundation
Pull Request:   https://github.com/freebsd/freebsd-src/pull/1788

(cherry picked from commit 6ff78a63d8cd0dd64ae79cbda5cb03572c1e17f5)
DeltaFile
+0-4tests/sys/netpfil/common/dummynet.sh
+0-4tests/sys/netpfil/pf/forward.sh
+0-4tests/sys/netpfil/pf/killstate.sh
+0-4tests/sys/netpfil/pf/set_tos.sh
+0-164 files

FreeBSD/src 0b6f420lib/libexecinfo/tests sigtramp_test.c

tests/sigtramp_test: xfail on non-amd64

This test fail until at least https://reviews.llvm.org/D155066 is
rebased and picked up for aarch64 and more work is done for the other
archs.

PR:             289096
Reviewed by:    jlduran
Fixes:          fef84fd8ae845e19cec0f6b9aac0e6451cca3d7a
MFC after:      3 days

(cherry picked from commit 0010c4b8a020dbeb81e61b71117d1caae9b044cc)
DeltaFile
+2-2lib/libexecinfo/tests/sigtramp_test.c
+2-21 files

FreeBSD/src 97ecf34tests/sys/posixshm memfd_test.c

memfd_test: skip hugetlb testcase when large page requests are not supported

Fixes this CI test failure: https://ci.freebsd.org/view/Test/job/FreeBSD-main-riscv64-test/16606/testReport/junit/sys.posixshm/memfd_test/hugetlb/

Reviewed by:    kevans
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D57289

(cherry picked from commit 64b053f879a8b3c4aa31e1ab99340dfe0ddfea0c)
DeltaFile
+5-2tests/sys/posixshm/memfd_test.c
+5-21 files

FreeBSD/src 83344feshare/man/man5 src.conf.5, share/mk src.opts.mk

src.opts.mk: enable OPENSSL_KTLS by default on riscv64

1e649491b8567151270095fda3bce8faea394952 enabled KERN_TLS in
riscv/conf/GENERIC, but didn't enable OPENSSL_KTLS.

This passes all testcases in the sys/kern/ssl_sendfile suite and
fixes CI failures seen here:
https://ci.freebsd.org/job/FreeBSD-main-riscv64-test/16606/testReport/sys.kern/ssl_sendfile/

PR:     293810
Fixes:  1e649491b8567151270095fda3bce8faea394952
MFC after:      3 days
Reviewed by:    gallatin, ngie
Differential Revision:  https://reviews.freebsd.org/D57316

(cherry picked from commit b61ab2d693c04d4be5468e7db4b03d5777228f95)
DeltaFile
+3-3share/man/man5/src.conf.5
+2-2share/mk/src.opts.mk
+5-52 files

FreeBSD/src 1ae396elib/libc/riscv gd_qnan.h

libc: fix strtold NaN representation on riscv

Regenerate gd_qnan.h on riscv using the qnan.c
config tool found in contrib/gdtoa.

This fixes the following tests in CI:
lib/libc/stdio/scanfloat_test:infinities_and_nans
lib/libc/stdlib/strtod_test:strtold_nan

Reviewed by:    jrtc27
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D57405

(cherry picked from commit 1e25cda7f06923d05e28dac8eb1c1c428a5c92dc)
DeltaFile
+3-3lib/libc/riscv/gd_qnan.h
+3-31 files

FreeBSD/src 0c4bafdtests/sys/kern ptrace_test.c

ptrace_test: expect PT_STEP tests to fail on riscv

ptrace_single_step currently returns EOPNOTSUPP on riscv.

This temporarily fixes the following CI failures:
https://ci.freebsd.org/job/FreeBSD-main-riscv64-test/16606/testReport/sys.kern/ptrace_test/ptrace__PT_STEP_with_signal/
https://ci.freebsd.org/job/FreeBSD-main-riscv64-test/16606/testReport/sys.kern/ptrace_test/ptrace__step_siginfo/

Reviewed by:    kib
Approved by:    emaste (mentor)
Differential Revision:  https://reviews.freebsd.org/D57288

(cherry picked from commit a7df326619ef9caa2ed00bf2d103dd278e7b32ec)
DeltaFile
+8-0tests/sys/kern/ptrace_test.c
+8-01 files

FreeBSD/src c8dfb30. Makefile

universe: emit warning instead of error for bad/missing KERNCONF

When doing a large `make universe` build with multiple KERNCONFS,
it should not be an error when a particular target has a missing
KERNCONF.

In this example,

```
$ make universe TARGETS='arm64 riscv' KERNCONFS='QEMU VIRT'
```

Currently, arm64 does not have a QEMU conf, and riscv
does not have a VIRT conf. However, this command should still
succeed instead of failing with the following message:

```
make[2]: /usr/src/Makefile:767: Target architecture for riscv/conf/VIRT unknown.  config(8) likely too old.
        in .for loop from /usr/src/Makefile:761 with kernel = VIRT

    [15 lines not shown]
DeltaFile
+5-1Makefile
+5-11 files

FreeBSD/src e6b52ce. Makefile, share/man/man7 build.7

universe: allow moving build logs to UNIVERSE_LOGDIR

This allows `make universe` or `make tinderbox`
to build from a read-only src tree.

Reviewed by:    ziaee, imp, delphij
Approved by:    lwhsu (mentor), emaste (mentor)
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D55566

(cherry picked from commit 02ef0b6d76e9717b8e3182dd706e23fd2702701d)
DeltaFile
+8-9Makefile
+6-1share/man/man7/build.7
+14-102 files

FreeBSD/src ef77247usr.sbin/mixer/tests mixer_test.sh Makefile

mixer/tests: use require.kmods property instead of ad-hoc checks

Reviewed by:    christos
Approved by:    lwhsu (mentor)
Sponsored by:   The FreeBSD Foundation
MFC after:      3 days
Differential Revision:  https://reviews.freebsd.org/D55221

(cherry picked from commit 5fa297f4bcd277dca7eef03e68363fb1e721799e)
DeltaFile
+0-12usr.sbin/mixer/tests/mixer_test.sh
+2-1usr.sbin/mixer/tests/Makefile
+2-132 files

FreeBSD/src 2d7f1cfsys/kern syscalls.master

syscalls.master: Allow clock_nanosleep in capability mode

It is akin to nanosleep(2) and does not access global namespaces.
It should be permitted in capability mode.

Reviewed by: vangyzen
Fixes: 3f8455b0905a ("Add clock_nanosleep()")
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D57343

(cherry picked from commit 692b0ef1506ba51b72d0a2707cbf8879a6e01d78)
DeltaFile
+1-1sys/kern/syscalls.master
+1-11 files