Displaying 1 50 of 314,062 commits (0.031s)

FreeBSD — stable/10/sys/fs/nfsclient nfs_clstate.c

MFC: r316669
Avoid starvation of the server crash recovery thread for the NFSv4 client.

This patch gives a requestor of the exclusive lock on the client state
in the NFSv4 client priority over shared lock requestors. This avoids
the server crash recovery thread being starved out by other threads doing
RPCs.

FreeBSD — stable/11/sys/fs/nfsclient nfs_clstate.c

MFC: r316669
Avoid starvation of the server crash recovery thread for the NFSv4 client.

This patch gives a requestor of the exclusive lock on the client state
in the NFSv4 client priority over shared lock requestors. This avoids
the server crash recovery thread being starved out by other threads doing
RPCs.

FreeBSD — head/sys/kern uipc_socket.c

Remove unnecessary check for NULL mbuf in soreceive_generic().

This check has been redundant since it was introduced in r162554.

Reviewed by:        emaste, glebius
MFC after:        1 week
Differential Revision:        https://reviews.freebsd.org/D10322
Delta File
+1 -1 head/sys/kern/uipc_socket.c
+1 -1 1 file

FreeBSD — stable/10/sys/fs/nfsclient nfs_clport.c

MFC: r316667
Fix the NFSv4 client hndling of a stale write verifier in the Commit operation.

When the NFSv4 client Commit operation encountered a stale write verifier,
it erroneously mapped that to EIO. This could have caused recently written
data to be lost when a server crashes/reboots between an UNSTABLE write
and the subsequent commit. This patch fixes this.
The bug was only for the NFSv4 client and did not affect NFSv3.

FreeBSD — stable/10/sys/fs/nfs nfs_commonsubs.c

MFC: r316666
Fix the NFSv4.1 client for NFSERR_BADSESSION recovery via ReclaimComplete.

For the ReclaimComplete operation, the RPC layer should not loop on
NFSERR_BADSESSION. If it does, the recovery thread (nfscl) can get stuck
looping and will not do a recovery.
This patch fixes it so it does not loop. This bug only affects NFSv4.1 and
only when a server reboots.

FreeBSD — stable/11/sys/fs/nfsclient nfs_clport.c

MFC: r316667
Fix the NFSv4 client hndling of a stale write verifier in the Commit operation.

When the NFSv4 client Commit operation encountered a stale write verifier,
it erroneously mapped that to EIO. This could have caused recently written
data to be lost when a server crashes/reboots between an UNSTABLE write
and the subsequent commit. This patch fixes this.
The bug was only for the NFSv4 client and did not affect NFSv3.

FreeBSD — stable/11/sys/fs/nfs nfs_commonsubs.c

MFC: r316666
Fix the NFSv4.1 client for NFSERR_BADSESSION recovery via ReclaimComplete.

For the ReclaimComplete operation, the RPC layer should not loop on
NFSERR_BADSESSION. If it does, the recovery thread (nfscl) can get stuck
looping and will not do a recovery.
This patch fixes it so it does not loop. This bug only affects NFSv4.1 and
only when a server reboots.

FreeBSD — head/gnu/usr.bin/gdb Makefile Makefile.inc, head/share/mk src.opts.mk

Add a new GDB_LIBEXEC option to install gdb and kgdb to /usr/libexec.

When this option is enabled, only gdb and kgdb are installed to
/usr/libexec for use by crashinfo(8). Other bits of GDB such as
gdbserver and gdbtui are not installed. For this option to be
effective, GDB must be enabled.

Rework r317094 to re-enable GDB on all platforms but enable
GDB_LIBEXEC on platforms for which the GDB in ports is a superset of
functionality.

Reviewed by:        emaste, kib
Suggested by:        kib
Relnotes:        yes
Differential Revision:        https://reviews.freebsd.org/D10449

FreeBSD — head/lib/libbsnmp/libbsnmp Makefile, head/tools/build/mk OptionalObsoleteFiles.inc

Remove an incorrect MLINK for tree(3) introduced in r310728.

Reported by:        many
PR:                216476
MFC after:        3 days
Sponsored by:        The FreeBSD Foundation

FreeBSD — head/cddl/contrib/opensolaris/cmd/zfs zfs.8 zfs_main.c, head/cddl/contrib/opensolaris/cmd/zstreamdump zstreamdump.c

MFV 316894

7252 7628 compressed zfs send / receive

illumos/illumos-gate at 5602294fda888d923d57a78bafdaf48ae6223dea
https://github.com/illumos/illumos-gate/commit/5602294fda888d923d57a78bafdaf48ae6223dea

https://www.illumos.org/issues/7252
  This feature includes code to allow a system with compressed ARC enabled to
  send data in its compressed form straight out of the ARC, and receive data in
  its compressed form directly into the ARC.

https://www.illumos.org/issues/7628
  We should have longer, more readable versions of the ZFS send / recv options.

7628 create long versions of ZFS send / receive options

Reviewed by: George Wilson <george.wilson at delphix.com>
Reviewed by: John Kennedy <john.kennedy at delphix.com>
Reviewed by: Matthew Ahrens <mahrens at delphix.com>
Reviewed by: Paul Dagnelie <pcd at delphix.com>
Reviewed by: Pavel Zakharov <pavel.zakharov at delphix.com>
Reviewed by: Sebastien Roy <sebastien.roy at delphix.com>
Reviewed by: David Quigley <dpquigl at davequigley.com>
Reviewed by: Thomas Caputi <tcaputi at datto.com>

    [2 lines not shown]

FreeBSD — head/tools/build/mk OptionalObsoleteFiles.inc

Remove info files from optional old files.

Info files are now all removed unconditionally after the removal of
texinfo.

MFC after:        1 week

FreeBSD — head ObsoleteFiles.inc

Add info files for GCC 4.2 to the list of info files to remove.

This would only affect upgrades from older versions of non-clang
platforms.

MFC after:        1 week
Delta File
+4 -0 head/ObsoleteFiles.inc
+4 -0 1 file

FreeBSD — head/sbin atm, head/sys netnatm

Remove directories made empty by NATM, EISA, and IEEE488 removals.

Reported by:        ak
Delta File
+0 -0 head/usr.sbin/bsnmpd/modules/snmp_atm/
+0 -0 head/sys/dev/ahb/
+0 -0 head/sys/dev/eisa/
+0 -0 head/sys/dev/en/
+0 -0 head/sys/dev/fatm/
+0 -0 head/sys/dev/hatm/
+0 -0 13 files not shown
+0 -0 19 files

FreeBSD — head/sys/dev/cxgbe/iw_cxgbe iw_cxgbe.h

cxgbe/iw_cxgbe: Pull in some updates to c4iw_wait_for_reply from the
iw_cxgb4 Linux driver.

Obtained from:        Chelsio Communications
MFC after:        3 days
Sponsored by:        Chelsio Communications
Delta File
+42 -21 head/sys/dev/cxgbe/iw_cxgbe/iw_cxgbe.h
+42 -21 1 file

FreeBSD — head/contrib/tcpdump tcpdump.c

Cherry-pick 5d3c5151c2b885aab36627bafb8539238da27b2d, it fixes use after free
if tcpdump(1) is run on non-existent interface.

Suggested by:        zeising
Delta File
+1 -1 head/contrib/tcpdump/tcpdump.c
+1 -1 1 file

FreeBSD — stable/10/sys/fs/nfsclient nfs_clvnops.c

MFC r316698:
Remove debugging printf.

FreeBSD — stable/11/sys/fs/nfsclient nfs_clvnops.c

MFC r316698:
Remove debugging printf.

FreeBSD — stable/10/sys/fs/nfsclient nfs_clrpcops.c

MFC: r316655
Fix parsing failure for NFSv4 Setattr operation for failed case.

If an operation that preceeds a Setattr in an NFSv4 compound fails,
there is no bitmap of attributes to parse. Without this patch, the
parsing would fail and return EBADRPC instead of the correct failure
error. This could break recovery from a server crash/reboot.

FreeBSD — stable/11/sys/fs/nfsclient nfs_clrpcops.c

MFC: r316655
Fix parsing failure for NFSv4 Setattr operation for failed case.

If an operation that preceeds a Setattr in an NFSv4 compound fails,
there is no bitmap of attributes to parse. Without this patch, the
parsing would fail and return EBADRPC instead of the correct failure
error. This could break recovery from a server crash/reboot.

FreeBSD — stable/10/sys/fs/nfs nfs_commonsubs.c nfs_commonkrpc.c, stable/10/sys/fs/nfsclient nfs_clrpcops.c nfs_clstate.c

MFC: r310491
Fix NFSv4.1 client recovery from NFS4ERR_BAD_SESSION errors.

For most NFSv4.1 servers, a NFS4ERR_BAD_SESSION error is a rare failure
that indicates that the server has lost session/open/lock state.
However, recent testing by cperciva@ against the AmazonEFS server found
several problems with client recovery from this due to it generating this
failure frequently.
Briefly, the problems fixed are:
- If all session slots were in use at the time of the failure, some processes
  would continue to loop waiting for a slot on the old session forever.
- If an RPC that doesn't use open/lock state failed with NFS4ERR_BAD_SESSION,
  it would fail the RPC/syscall instead of initiating recovery and then
  looping to retry the RPC.
- If a successful reply to an RPC for an old session wasn't processed
  until after a new session was created for a NFS4ERR_BAD_SESSION error,
  it would erroneously update the new session and corrupt it.
- The use of the first element of the session list in the nfs mount
  structure (which is always the current metadata session) was slightly
  racey. With changes for the above problems it became more racey, so all
  uses of this head pointer was wrapped with a NFSLOCKMNT()/NFSUNLOCKMNT().
- Although the kernel malloc() usually allocates more bytes than requested
  and, as such, this wouldn't have caused problems, the allocation of a
  session structure was 1 byte smaller than it should have been.
  (Null termination byte for the string not included in byte count.)

    [9 lines not shown]

FreeBSD — stable/11/sys/net if_gre.c if_me.c

MFC r316699:
  Do not adjust interface MTU automatically. Leave this task to the system
  administrator.

  Before r274246 interface MTU was adjusted only when GRE key is configured.
  The r274246 has changed this behavior to automatically adjust MTU when any
  option, that changes the size of GRE header is configured.
  This patch removes automatic MTU adjustment from if_gre(4) and if_me(4),
  and restores the behavior that was prior to r274246.

  Differential Revision:        https://reviews.freebsd.org/D10215

FreeBSD — head/lib/librpcsec_gss svc_rpcsec_gss.c

Fix a potential problem where we might try to shift by more than 31 bits

CID:    1198859
Delta File
+14 -11 head/lib/librpcsec_gss/svc_rpcsec_gss.c
+14 -11 1 file

FreeBSD — user/pho/stress2/misc quota8.sh quota9.sh

Added check for QUOTA configured.
Style fix while here.

Sponsored by:        Dell EMC Isilon

FreeBSD — head/sys/netpfil/pf pf_table.c

Fix VNET leakages in PF by V_irtualizing pfr_ktables and friends.
Apparently this resolves a PF-triggered panic when destroying VNET jails.

Submitted by:        Peter Blok <peter.blok at bsd4all.org>
Reviewed by:        kp
Delta File
+29 -24 head/sys/netpfil/pf/pf_table.c
+29 -24 1 file

FreeBSD — head/sys/netpfil/pf pf_if.c

Since curvnet is already properly set on entry to event handlers,
there's no need to override it, particularly not unconditionally with
vnet0.

Submitted by:        Peter Blok <peter.blok at bsd4all.org>
Reviewed by:        kp
Delta File
+9 -27 head/sys/netpfil/pf/pf_if.c
+9 -27 1 file

FreeBSD — vendor/less v487

Tag less v487.
Delta File
+0 -0 vendor/less/v487/
+0 -0 1 file

FreeBSD — vendor/less/dist funcs.h less.man

Vendor import of less 487.
Delta File
+299 -302 vendor/less/dist/funcs.h
+184 -176 vendor/less/dist/less.man
+124 -109 vendor/less/dist/cmdbuf.c
+128 -61 vendor/less/dist/output.c
+107 -80 vendor/less/dist/wide.uni
+120 -66 vendor/less/dist/search.c
+1,449 -788 64 files not shown
+2,411 -1,582 70 files

FreeBSD — vendor/less/dist funcs.h regexp.c

Apply r316339 to vendor area.
Delta File
+302 -298 vendor/less/dist/funcs.h
+74 -102 vendor/less/dist/regexp.c
+56 -97 vendor/less/dist/cmdbuf.c
+55 -86 vendor/less/dist/screen.c
+41 -92 vendor/less/dist/search.c
+41 -76 vendor/less/dist/line.c
+514 -932 32 files not shown
+1,083 -1,683 38 files

FreeBSD — stable/11/sys/fs/fuse fuse_node.c

MFC r317273 (by cem):
fuse: Implement FOPEN_KEEP_CACHE flag
Delta File
+2 -2 stable/11/sys/fs/fuse/fuse_node.c
+2 -2 1 file

FreeBSD — stable/11/lib/libc/gen ttyname.c

MFC r316768:

Fix an out-of-bounds write when a zero-length buffer is passed.

Found with ttyname_test and CHERI bounds checking.

Reviewed by:        emaste
Obtained from:        CheriBSD
Sponsored by:        DARPA, AFRL
Delta File
+4 -0 stable/11/lib/libc/gen/ttyname.c
+4 -0 1 file

FreeBSD — head/sys/netinet tcp_lro.c

Flush the LRO ctrl as soon as lro_mbufs fills up.  There is no need to
wait for the next enqueue from the driver.

Reviewed by:        gnn@, hselasky@, gallatin@
MFC after:        1 week
Sponsored by:        Chelsio Communications
Differential Revision:        https://reviews.freebsd.org/D10432
Delta File
+5 -5 head/sys/netinet/tcp_lro.c
+5 -5 1 file

FreeBSD — head/sys/netinet tcp_lro.c

Frames that are not considered for LRO should not be counted in LRO statistics.

Reviewed by:        gnn@, hselasky@, gallatin@
MFC after:        1 week
Sponsored by:        Chelsio Communications
Differential Revision:        https://reviews.freebsd.org/D10430
Delta File
+0 -2 head/sys/netinet/tcp_lro.c
+0 -2 1 file

FreeBSD — head/usr.sbin/ntp/sntp Makefile

Use the approved syntax to build no man pages.

MFC after:        1 week
Sponsored by:        DARPA, AFRL
Delta File
+1 -1 head/usr.sbin/ntp/sntp/Makefile
+1 -1 1 file

FreeBSD — stable/10/lib/libutil humanize_number.c

MFC r316766:

Correct an out of bounds read with HN_AUTOSCALE and very large numbers.

The maximum scale is 6 (K, M, G, T, P, E) (B is 0).

Overly large explict scales were checked correctly, but for sufficently
large numbers HN_AUTOSCALE would get to 7 resulting in an out of bounds
read.

Found with humanize_number_test and CHERI bounds checking.

Reviewed by:        emaste
Obtained from:        CheriBSD
Sponsored by:        DARPA, AFRL

FreeBSD — stable/11/lib/libutil humanize_number.c

MFC r316766:

Correct an out of bounds read with HN_AUTOSCALE and very large numbers.

The maximum scale is 6 (K, M, G, T, P, E) (B is 0).

Overly large explict scales were checked correctly, but for sufficently
large numbers HN_AUTOSCALE would get to 7 resulting in an out of bounds
read.

Found with humanize_number_test and CHERI bounds checking.

Reviewed by:        emaste
Obtained from:        CheriBSD
Sponsored by:        DARPA, AFRL

FreeBSD — head/usr.bin/getaddrinfo Makefile

Clean up Makefile.

Prefer SRCTOP vs .CURDIR relative paths.

Find libnetbsd using LIBADD infrastructure rather than manual hackery.

Reviewed by:        ngie, bapt
Obtained from:        CheriBSD
MFC after:        1 week
Sponsored by:        DARPA, AFRL
Differential Revision:        https://reviews.freebsd.org/D10461
Delta File
+5 -9 head/usr.bin/getaddrinfo/Makefile
+5 -9 1 file

FreeBSD — head UPDATING

Document the removal of NATM.

Relnotes:        yes
Delta File
+5 -0 head/UPDATING
+5 -0 1 file

FreeBSD — head ObsoleteFiles.inc, head/etc/mtree BSD.usr.dist

Remove the NATM framework including the en(4), fatm(4), hatm(4), and
patm(4) devices.

Maintaining an address family and framework has real costs when we make
infrastructure improvements.  In the case of NATM we support no devices
manufactured in the last 20 years and some will not even work in modern
motherboards (some newer devices that patm(4) could be updated to
support apparently exist, but we do not currently have support).

With this change, support remains for some netgraph modules that don't
require NATM support code. It is unclear if all these should remain,
though ng_atmllc certainly stands alone.

Note well: FreeBSD 11 supports NATM and will continue to do so until at
least September 30, 2021.  Improvements to the code in FreeBSD 11 are
certainly welcome.

Reviewed by:        philip
Approved by:        harti
Delta File
+0 -9,079 head/sys/dev/patm/if_patm_rtables.c
+0 -3,367 head/sys/dev/en/midway.c
+0 -3,091 head/sys/dev/fatm/if_fatm.c
+0 -2,419 head/sys/dev/hatm/if_hatm.c
+0 -2,393 head/sys/dev/fatm/firmware.h
+0 -1,515 head/sys/dev/utopia/suni.h
+56 -25,012 96 files not shown
+56 -46,876 102 files

FreeBSD — head/sys/fs/nfsserver nfs_nfsdstate.c

Allow use of a write open stateid for reading in the NFSv4 server.

The NFSv4 RFCs give a server the option of allowing the use of an open
stateid for write access to be used for a Read operation.
This patch enables this by default and adds a sysctl to disable it,
for anyone who does not want this capability.
Allowing this is particularily useful for a pNFS Data Server (DS), since
they are not permitted to allow the use of special stateids.
Discovered during recent testing of the pNFS server under development.

MFC after:        2 weeks

FreeBSD — head/usr.bin/diff diffreg.c

Fix the following warning from gcc 4.2 in usr.bin/diff:

usr.bin/diff/diffreg.c: In function 'change':
usr.bin/diff/diffreg.c:1085: warning: 'i' may be used uninitialized in this function

This version of gcc is not smart enough to see that 'i' cannot actually
be used unitialized.  However, the variable is confusingly re-used, so
it is better to give it another name, and clearly initialize it before
attempting to use it.

Reviewed by:        bapt
Differential Revision: https://reviews.freebsd.org/D10484
Delta File
+7 -6 head/usr.bin/diff/diffreg.c
+7 -6 1 file

FreeBSD — head/sys/dev/bhnd bhnd_erom.h bhnd_erom_if.m, head/sys/dev/bhnd/bcma bcma_erom.c

Add support for dumping bcma/siba EROM tables to the console via a new
BHND_EROM_DUMP() method.

Dump the EROM tables to the coneole on mips/broadcom devices if bootverbose
is enabled; this functionality is primarily useful when debugging SoC EROM
parsing and device matching issues during early boot.

Reviewed by:        mizhka
Approved by:        adrian (mentor)
Sponsored by:        Plausible Labs
Differential Revision:        https://reviews.freebsd.org/D10122

FreeBSD — head/sys/dev/bhnd/nvram bhnd_nvram_data_sprom.c

Drop unused/unnecessary return statement.

Reported by:        Coverity
CID:                1373118
Approved by:        adrian (mentor, implicit)

FreeBSD — head/usr.bin/sed sed.1

Fix the last example to really replace all occurrences of the search string
in the file by adding the global (g) option at the end.  Without it, only the
first match is replaced, subsequent ones are ignored.  The intention of the
example is to demonstrate something else, but adding the g matches the example
to what the description says.

Discussed with:            brd (on IRC)
MFC after:            1 week
Delta File
+1 -1 head/usr.bin/sed/sed.1
+1 -1 1 file

FreeBSD — stable/11/usr.sbin/acpi/acpidump acpi.c acpidump.c

MFC r302788, r303026, r305471

r302788:
Fix the type used to hold the value returned from getopt. On arm64 char is
unsigned so will never be -1.

r303026:
Add missing flags from acpidump. These are defined in the header, but not
printed. The HW_REDUCED flag is useful as it should be set on arm64 to
comply with the ARM Server Base Boot Requirements.

r305471:
Teach acpidump how to parse ACPI 5.1 tables found on the development
ThunderX units in the netperf cluster.

FreeBSD — head/release/scripts pkg-stage.sh

Add sysutils/tmux to the DVD package set

The zsh + tmux combination is commonly wanted.

Approved by:        gjb
MFC after:        2 weeks
Sponsored by:        The FreeBSD Foundation
Delta File
+1 -0 head/release/scripts/pkg-stage.sh
+1 -0 1 file

FreeBSD — stable/10/cddl/lib/libdtrace ip.d, stable/10/sys/netinet tcp_input.c in_kdtrace.c

Partial MFC r316676 and the required r313045

MFC r316676:

Use estimated RTT for receive buffer auto resizing instead of timestamps.
This is a partial MFC as stable/10 doesn't include the TCP stack
modularisation.

MFC r313045:

Add an mbuf to ipinfo_t translator to finish cleanup of mbuf passing to TCP
probes. This is a partial MFC (missing debug__output & debug__drop changes)
due to the massive amount of additional dtrace changes that would be
required for a full MFC.

Relnotes:        Yes
Sponsored by:        Multiplay

FreeBSD — stable/11/sbin/camcontrol camcontrol.8 persist.c

MFC r312558:

Misc Coverity fixes in camcontrol(8)

CID 1229913        Fix output of "camcontrol persist -i report_capabilities".
                The reported Persistent Reservation Types were wrong in all
                cases.
CID 1356029        Annotate the code so Coverity will know that this is a false
                positive.
CID 1366830        Fix a memory leak in "camcontrol timestamp -s"
CID 1366832        Fix a segfault that could be caused by bad drive firmware

Also, fix the man page entry for the "camcontrol epc state" command to match
what the code does.

Reviewed by:        ken, wblock
MFC after:        4 weeks
Sponsored by:        Spectra Logic Corp
Differential Revision:        https://reviews.freebsd.org/D9239

FreeBSD — stable/11/etc/defaults periodic.conf, stable/11/etc/periodic/daily 480.leapfile-ntpd

MFC r316342, r316358

r316342:
Consolidate random sleeps in periodic scripts

Multiple periodic scripts sleep for a random amount of time in order to
mitigate the thundering herd problem. This is bad, because the sum of
multiple uniformly distributed random variables approaches a normal
distribution, so the problem isn't mitigated as effectively as it would be
with a single sleep.

This change creates a single configurable anticongestion sleep. periodic
will only sleep if at least one script requires it, and it will never sleep
more than once per invocation. It also won't sleep if periodic was run
interactively, fixing an unrelated longstanding bug.

PR:                217055
PR:                210188
Reviewed by:        cy
MFC after:        3 weeks
Differential Revision:        https://reviews.freebsd.org/D10211

r316358:
Fix man page typo from r316342


    [3 lines not shown]

FreeBSD — head/lib/libc/gen scandir.c

scandir(3): promote arraysz to size_t to match numitems.

The internal array size goes through a loop and is compared with numitems
which at its limits makes can be unreachably higher than arraysz.
Prevent an hypothetical overflow by matching the types.

MFC after:        1 week
Delta File
+1 -2 head/lib/libc/gen/scandir.c
+1 -2 1 file

FreeBSD — head/contrib/elftoolchain/elfcopy main.c

elfcopy: allow empty symbol list files

Reported by:        bz
MFC after:        2 weeks
Sponsored by:        The FreeBSD Foundation
Differential Revision:        https://reviews.freebsd.org/D10441