bxe(4): don't feed a zero page size to ilog2 during ILT init
FreeBSD's bxe hardwires CNIC_SUPPORT() to 0, so bxe_ilt_set_info()
never enters the block that initializes the SRC and TM ILT clients.
Those two clients are left zeroed (page_size 0, flags 0), yet
ecore_ilt_init_page_size() calls ecore_ilt_init_client_psz() for all
four clients unconditionally. For SRC and TM that evaluates
ILOG2(page_size >> 12), i.e. ilog2(0). On an INVARIANTS kernel ilog2()
asserts "ilog argument must be nonzero" and panics the machine the
first time the interface is brought up (bxe_init -> bxe_nic_load ->
bxe_init_hw -> ecore_ilt_init_page_size). On a non-INVARIANTS kernel
it silently programs a bogus page-size register instead.
Restore the else branch that upstream Linux bnx2x carries: when CNIC
is not supported, mark the SRC and TM clients with ILT_CLIENT_SKIP_INIT
and ILT_CLIENT_SKIP_MEM so ecore_ilt_init_client_psz() skips them.
Root-caused from a crash dump on a BCM57810 (device 0x168e): the ILT
clients showed CDU and QM populated and SRC and TM zeroed with no skip
[6 lines not shown]
nanobsd: Remove pandaboard.cfg
Pandaboard (sys/arm/ti/omap4) is removed due to lack of HW.
Remove the pandaboard config file for nanobsd aswell.
Approved by: imp, jlduran, manu(mentor)
Diffrential revision: https://reviews.freebsd.org/D54319
x11/colormeter: Add new port
X11 pixel magnifier with live RGB readout from FrauBSD. Ctrl+L locks
the sample; Button1 drag moves the window. Installs colormeter(1).
Reviewed by: jrm
Differential Revision: https://reviews.freebsd.org/D58429
LinuxKPI: 802.11: implement cfg80211_calculate_bitrate()
lkpi_cfg80211_calculate_bitrate_vht() was constantly showing up
in my debug traces as a TODO with rtw89 so I went ahead and implemented
the HT and VHT versions. Realtek seems to limit amsdu sizes based
on the value and ask for it whether needed or not.
Sponsored by: The FreeBSD Foundation
MFC after: 3 days
iflib: don't update the admin status in if_media_status()
When _task_fn_admin() is active, it will regularly call
IFDI_UPDATE_ADMIN_STATUS(). So there is no need to do it in
iflib_media_status. This can be fairly expensive on some drivers (long
DELAY busywait loops waiting for a NIC command), and there is no need
to pause a userspace app in this DELAY() if it is happening
asynchronously anyway.
Note the logic to detect if _task_fn_admin() is regularly calling
IFDI_UPDATE_ADMIN_STATUS() was copied from that function.
Reviewed by: erj, kbowling
Sponsored by: Netflix
Differential Revision: https://reviews.freebsd.org/D54096
sysutils/exa: Mark deprecated
The project is abandoned upstream. It's been forked as eza,
and the fork already has a port, so recommend that instead.
PR: 298083
Reported by: asomers
Sponsored by: ConnectWise
Approved by: osa, vvd (Mentors, implicit)
(cherry picked from commit 20e6ca4c67147e14628de8bc47656bd7ee75f7c7)
sysutils/exa: Mark deprecated
The project is abandoned upstream. It's been forked as eza,
and the fork already has a port, so recommend that instead.
PR: 298083
Reported by: asomers
Sponsored by: ConnectWise
Approved by: osa, vvd (Mentors, implicit)
mail/mutt: update the mirror list
Remove bitbucket, which doesn't have any mutt downloads right now. And
add http to the primary server, for ftp-challenged environments. Http
is listed as the preferred download protocol:
http://www.mutt.org/download.html
PR: 298080
Reported by: asomers
Sponsored by: ConnectWise
Approved by: osa, vvd (Mentors, implicit)
games/luanti-mineclonia: add port
Survival sandbox game inspired by Minecraft
You start in a randomly-generated world made entirely of cubes. You
can explore the world and dig and build almost every block in the
world to create new structures. You can choose to play in a “survival
mode” in which you have to fight monsters and hunger for survival
and slowly progress through the various other aspects of the game,
such as mining, farming, building machines, and so on Or you can
play in “creative mode” in which you can build almost anything
instantly.
gstat: Set errno = 0 before strtoul
The strtoul function sets errno on error, but does not clear it on
success; when using strtoul and checking errno (as one should) for
ERANGE / EINVAL afterwards, it's important to zero errno first.
While here, remove a dead store.
Reviewed by: phk
Fixes: 4fe8c1b67be0 ("Add error and range checking ... ")
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D59270
audio/squash: polish port and fix few minor bugs
...exposed through clang or gcc compiler warnings.
Add a deprecation warning that upstream has been dead since 22 years.
PR: 297721
Pull Request: https://github.com/freebsd/freebsd-ports/pull/605
inetd: only declare and use the mapped-address netconfig under INET6
In a WITHOUT_INET6 build the only assignment to netid2 is compiled out and
the non-INET6 arm returns early, so netid2 is unconditionally NULL and the
rpcb_set() call guarded by it is dead code. clang does not prove it dead
and reports nbuf2 as uninitialized where it is passed as a const pointer,
No functional change.
MFC after: 1 week
Reported by: clang (-Wuninitialized-const-pointer)
Suggested by: dim
Approved by: ngie (co-mentor)
Reviewed by: ngie
Differential Revision: https://reviews.freebsd.org/D59277
