FreeBSD/src 0a85254usr.bin/top top.1 commands.c

top: Polish key bindings in usage and manual

Organize key bindings by ascii(7) for consistency and maintainability,
mark them as Interactive Commands, wordsmith them, and sync their
organization between the manual and help screen.

MFC after:              3 days
PR:                     282734
Fixes:                  c8aa5e526 (move command mapping to commands.c)
Reviewed by:            imp, mhorne, Jim Brown <jpb at jimby.name>
Approved by:            mhorne (mentor)
Differential Revision:  https://reviews.freebsd.org/D49462
DeltaFile
+92-91usr.bin/top/top.1
+13-13usr.bin/top/commands.c
+105-1042 files

FreeBSD/src f03c886usr.sbin/nfsd nfsd.8

nfsd.8: Note that the -n option is deprecated

PR#284616 reported that --maxthreads did not
obey the 256 thread limit defined as MAXNFSDCNT in nfsd.c.

This is actually a feature and not a bug, since many NFS
servers will now want to run more than 256 threads and
--maxthreads can be used to set the upper bound on the
number of threads. (MAXNFSDCNT was used long ago to
define how many daemons would be forked, before daemons
were replaced by kernel threads.)

However, the nfsd.8 man page was misleading, since it
indicated that "-n" was the equivalent to setting both
--minthreads and --maxthreads to the same value.
This patch fixes the man page.

This is a content change.


    [3 lines not shown]
DeltaFile
+20-10usr.sbin/nfsd/nfsd.8
+20-101 files

FreeBSD/src cb29db2crypto/openssl/apps speed.c, crypto/openssl/doc/man1 openssl-verification-options.pod openssl.pod

openssl: Import OpenSSL 3.0.16

This release incorporates the following bug fixes and mitigations:
- [CVE-2024-13176](https://www.openssl.org/news/vulnerabilities.html#CVE-2024-13176
- [CVE-2024-9143](https://www.openssl.org/news/vulnerabilities.html#CVE-2024-9143)

Release notes can be found at:
https://openssl-library.org/news/openssl-3.0-notes/index.html

MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D49296

(cherry picked from commit 0d0c8621fd181e507f0fb50ffcca606faf66a8c2)
DeltaFile
+292-79crypto/openssl/apps/speed.c
+127-127crypto/openssl/providers/fips-sources.checksums
+114-78crypto/openssl/doc/man1/openssl-verification-options.pod
+94-95crypto/openssl/util/check-format-commit.sh
+72-54crypto/openssl/test/evp_libctx_test.c
+9-98crypto/openssl/doc/man1/openssl.pod
+708-531160 files not shown
+2,039-1,079166 files

FreeBSD/src 0d61082crypto/openssl/include/openssl opensslv.h, secure/lib/libcrypto Makefile.inc

openssl: update ASM and version info for 3.0.16 import

MFC after:      1 week
MFC with:       0d0c8621fd181e507f0fb50ffcca606faf66a8c2
Differential Revision:  https://reviews.freebsd.org/D49297

(cherry picked from commit d2a55e6a9348bb55038dbc6b727ab041085f22db)
DeltaFile
+5-5crypto/openssl/include/openssl/opensslv.h
+2-2secure/lib/libcrypto/Makefile.inc
+2-0sys/crypto/openssl/aarch64/armv8-mont.S
+9-73 files

FreeBSD/src 7286b72tests/sys/fs/fusefs io.cc

tests/sys/fs/fusefs: include iomanip header

io.cc relies on `std::setw(..)`, which is exported by the iomanip C++
header. Newer versions of GoogleTest don't export this header, so add
the explicit include.

This unbreaks the build with GoogleTest 1.15.2.

MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D47194

(cherry picked from commit 0077477f215c851fe15c9ea12cfb005125c4238a)
DeltaFile
+2-0tests/sys/fs/fusefs/io.cc
+2-01 files

FreeBSD/src 1d67ceccontrib/googletest/googlemock/include/gmock gmock-matchers.h, contrib/googletest/googletest/include/gtest gtest-typed-test.h

contrib/googletest: update from 1.14.0 to 1.15.2

The changes between the two versions can be found in this diff of the
two release tags:
https://github.com/google/googletest/compare/v1.14.0...v1.15.2

One notable change is that GoogleTest 1.15.x now officially requires
C++-14 (1.14.x required C++-11).

MFC after:      1 week
Differential Revision:  https://reviews.freebsd.org/D47197

Merge commit '14f7077fed7d82046bdcbe347004132f08aba886'

(cherry picked from commit 5ca8c28cd8c725b81781201cfdb5f9969396f934)
DeltaFile
+174-120contrib/googletest/googletest/src/gtest.cc
+90-89contrib/googletest/googlemock/include/gmock/gmock-matchers.h
+81-73contrib/googletest/googletest/test/gtest_environment_test.cc
+78-74contrib/googletest/googletest/include/gtest/internal/gtest-param-util.h
+98-43contrib/googletest/googletest/include/gtest/internal/gtest-port.h
+65-61contrib/googletest/googletest/include/gtest/gtest-typed-test.h
+586-46068 files not shown
+1,595-1,05374 files

FreeBSD/src 2f1f523sys/dev/sound/pci/hda hdaa_patches.c hdac.h

snd_hda: Patch Framework 16 AMD

Reported by:    jrm
Tested by:      jrm
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Reviewed by:    jrm
Differential Revision:  https://reviews.freebsd.org/D49416
DeltaFile
+14-0sys/dev/sound/pci/hda/hdaa_patches.c
+1-0sys/dev/sound/pci/hda/hdac.h
+15-02 files

FreeBSD/src 693fa33sys/conf options.arm

arm: Garbage collect CPU_ARM1176

Remove the option CPU_ARM1176, as it has been useless since armv6 support
was removed.
DeltaFile
+0-1sys/conf/options.arm
+0-11 files

FreeBSD/src 5fca5c7sys/conf files.arm

arm: Remove any reference to cpufunc_asm_arm11x6.S

I was wrong and there were still one reference to that file, in files.arm,
so remove it.
DeltaFile
+0-1sys/conf/files.arm
+0-11 files

FreeBSD/src 65f2a88sys/arm/arm cpufunc_asm_arm11x6.S

arm: Garbage collect cpufunc_asm_arm11x6.S

Armv6 support has been removed a while ago, we can safely remove
cpufunc_asm_arm11x6.S, as it is now unused.
DeltaFile
+0-86sys/arm/arm/cpufunc_asm_arm11x6.S
+0-861 files

FreeBSD/src d45d070tools/tools/sysdoc tunables.mdoc

tools/sysdoc: Chase sysctl rename

PR:             285591
Reviewed by:    glebius
Fixes: 94df3271d6b2 ("Rename net.inet.ip.check_interface to rfc1122_strong_es and document it.")
Sponsored by:   The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D49486
DeltaFile
+2-2tools/tools/sysdoc/tunables.mdoc
+2-21 files

FreeBSD/src 718d192sys/compat/linuxkpi/common/include/linux gfp.h, sys/compat/linuxkpi/common/src linux_page.c

LinuxKPI: make linux_alloc_pages() honor __GFP_NORETRY

This is to fix slowdowns with drm-kmod that get worse over time as
physical memory become more fragmented (and probably also depending on
other factors).

Based on information posted in this bug report:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277476

By default, linux_alloc_pages() retries failed allocations by calling
vm_page_reclaim_contig() to attempt to free contiguous physical memory
pages. vm_page_reclaim_contig() does not always succeed and calling it
can be very slow even when it fails. When physical memory is very
fragmented, vm_page_reclaim_contig() can end up being called (and
failing) after every allocation attempt. This could cause very
noticeable graphical desktop hangs (which could last seconds).

The drm-kmod code in question attempts to allocate multiple contiguous
pages at once but does not actually require them to be contiguous. It

    [36 lines not shown]
DeltaFile
+2-2sys/compat/linuxkpi/common/include/linux/gfp.h
+2-1sys/compat/linuxkpi/common/src/linux_page.c
+4-32 files

FreeBSD/src b670804tests/sys/netipsec/tunnel empty.sh

tests: fix test for NULL encription

After 04207850a9b9 it is required that key length is not zero.
Add some key to avoid error.

Reported by:    markj
MFC after:      1 week
DeltaFile
+2-2tests/sys/netipsec/tunnel/empty.sh
+2-21 files

FreeBSD/src d3a659asys/dev/usb usb_msctest.c

usb-msctest: Be more conservative setting GETMAXLUN quirk

Only set the GETMAXLUN quirk when it causes an error, but don't set it
when it returns 0. Since we reset the device when we set any quirk, only
set this quirk when it generates an error so umass will avoid it. When
the command works, there's no reason for umass to avoid it at all.

MFC After: 1 week
Sponsored by: Netflix

(cherry picked from commit b0375f78e32acd7947d28126a5e165f8139a5a23)
DeltaFile
+4-9sys/dev/usb/usb_msctest.c
+4-91 files

FreeBSD/src 2452bcdsys/compat/freebsd32 freebsd32.h, sys/sys event.h

kevent32/kinfo_knote32: remove __LP64__ predicate in definitions

Requested by:   jrtc27
Reviewed by:    kevans, markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D49483
DeltaFile
+1-1sys/compat/freebsd32/freebsd32.h
+1-1sys/sys/event.h
+2-22 files

FreeBSD/src a27328eusr.sbin/bhyve bhyve_config.5, usr.sbin/bhyve/amd64 vmexit.c bhyverun_machdep.c

bhyve: Suppress unimplemented MSR related warnings

When using bhyve on x86, rdmsr and wrmsr can emit many warnings when
dealing with unimplemented MSRs. An option x86.verbosemsr is created to
control these warnings. By default, the MSR related warnings are
suppressed to avoid spamming the console.

Sponsored by: Netflix
Reviewed by: imp, jhb
Pull Request: https://github.com/freebsd/freebsd-src/pull/1611
DeltaFile
+10-4usr.sbin/bhyve/amd64/vmexit.c
+5-0usr.sbin/bhyve/bhyve_config.5
+1-0usr.sbin/bhyve/amd64/bhyverun_machdep.c
+16-43 files

FreeBSD/src 3209f63usr.sbin/trim Makefile

trim: Remove unnecessary include of src.opts.mk

Reviewed by:    chs
Fixes: db466e475446 ("trim: add missing include of src.opts.mk, remove unneeded LDFLAGS")
Differential Revision: https://reviews.freebsd.org/D49485
DeltaFile
+0-2usr.sbin/trim/Makefile
+0-21 files

FreeBSD/src c40b323usr.bin/beep Makefile

beep: Remove unnecessary include of src.opts.mk

Reviewed by:    chs
Fixes: 623be660fcc9 ("beep: add missing include of src.opts.mk, use LIBADD instead of LDFLAGS")
Differential Revision:  https://reviews.freebsd.org/D49485
DeltaFile
+0-2usr.bin/beep/Makefile
+0-21 files

FreeBSD/src 67c1c4dsys/kern uipc_sockbuf.c

sockbuf: provide sbunreserve_locked() which is a complement to sbreserve()

The sbreserve() works only on protocol-independent parts of the sockbuf,
but sbrelease() also clears the generic sockbuf mbuf chain.  Calling the
latter to undo changes done by the former is not correct.  The new
function is the right thing.

Reviewed by:            markj
Differential Revision:  https://reviews.freebsd.org/D49364
DeltaFile
+15-4sys/kern/uipc_sockbuf.c
+15-41 files

FreeBSD/src 371392bsys/kern uipc_sockbuf.c uipc_socket.c

sockbuf: remove sbflush_internal() and sbrelease_internal() shims

This functions serve just one purpose - allow to call sbdestroy() from
sofree() without triggering unlocked mutex assertions.  Let's just don't
save on locking with INVARIANTS kernel and this will allow to clean up all
these shims.  Should be no functional changes.

Reviewed by:            markj
Differential Revision:  https://reviews.freebsd.org/D49363
DeltaFile
+10-24sys/kern/uipc_sockbuf.c
+13-5sys/kern/uipc_socket.c
+23-292 files

FreeBSD/src 4a328b8sys/netinet tcp_input.c

tcp: fix reverting of spurious timeouts (RTO)

One variable that became critical to correctly calculate
the cwnd during limited transmit was not properly reverted
on detection of spurious timeouts.

PR:                     282605
Reviewed By:            cc, tuexen, #transport
MFC after:              3 days
Sponsored by:           NetApp, Inc.
Differential Revision:  https://reviews.freebsd.org/D48652

(cherry picked from commit 6f6c07813b38ab04d8b1b2bb87c0291dbae25a25)
DeltaFile
+1-0sys/netinet/tcp_input.c
+1-01 files

FreeBSD/src c18a16esys/kern kern_event.c

kern_proc_kqueues_out(): maxlen == -1 means there is no maxlen

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
DeltaFile
+11-3sys/kern/kern_event.c
+11-31 files

FreeBSD/src a6ea60asys/compat/freebsd32 freebsd32.h

freebsd32/freebsd32.h: only define kinfo_knote32 when kevent32 is defined

Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
DeltaFile
+2-0sys/compat/freebsd32/freebsd32.h
+2-01 files

FreeBSD/src 626ec04sys/vm vm_reserv.c

vm_reserv: clarify reserv_from_object

vm_reserv_from_page returns an existing reservation, or initializes a
successor pointer, or both.  If it returns an existing reservation,
callers will ignore the successor pointer, initialized or not, so
initializing it serves no purpose. So, don't initialize it in that
case, and make less ambiguous the comment that describes the
function's behavior.

Reviewed by:    markj, kib, alc
Differential Revision:  https://reviews.freebsd.org/D49415
DeltaFile
+5-9sys/vm/vm_reserv.c
+5-91 files

FreeBSD/src 1c3d653lib/libprocstat libprocstat.c core.c

libprocstat: add knowledge about NT_PROCSTAT_KQUEUES core file section

Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D49372
DeltaFile
+31-2lib/libprocstat/libprocstat.c
+4-0lib/libprocstat/core.c
+1-0lib/libprocstat/core.h
+36-23 files

FreeBSD/src fa8fdd8sys/compat/freebsd32 freebsd32_misc.c freebsd32.h, sys/kern kern_event.c

sysctl KERN_PROC_KQUEUE: implement compat32

Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D49372
DeltaFile
+50-0sys/compat/freebsd32/freebsd32_misc.c
+25-13sys/kern/kern_event.c
+18-0sys/compat/freebsd32/freebsd32.h
+5-0sys/compat/freebsd32/freebsd32_util.h
+98-134 files

FreeBSD/src debcd4clib/libprocstat core.c

libprocstat: constify psc_type_info[]

Suggested by:   markj
Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D49372
DeltaFile
+1-1lib/libprocstat/core.c
+1-11 files

FreeBSD/src ab9b296sys/kern kern_event.c

sysctl KERN_PROC_KQUEUE: treat omitted kqfd as request to dump all kqueues

Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D49372
DeltaFile
+40-26sys/kern/kern_event.c
+40-261 files

FreeBSD/src fe8ece3sys/compat/freebsd32 freebsd32.h, sys/sys user.h

struct kinfo_knote: add spare fields

This is yet another ABI breakage, hopefully the last.

Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Diffferential revision:  https://reviews.freebsd.org/D49372
DeltaFile
+1-0sys/compat/freebsd32/freebsd32.h
+1-0sys/sys/user.h
+2-02 files

FreeBSD/src 5e7c43fsys/kern imgact_elf.c kern_event.c, sys/sys user.h elf_common.h

Add NT_PROCSTAT_KQUEUES core note

Suggested by:   jhb
Reviewed by:    markj
Sponsored by:   The FreeBSD Foundation
MFC after:      1 week
Differential revision:  https://reviews.freebsd.org/D49372
DeltaFile
+51-0sys/kern/imgact_elf.c
+47-0sys/kern/kern_event.c
+2-0sys/sys/user.h
+1-0sys/sys/elf_common.h
+101-04 files