top: Polish key bindings in usage and manual
Organize key bindings by ascii(7) for consistency and maintainability,
mark them as Interactive Commands, wordsmith them, and sync their
organization between the manual and help screen.
MFC after: 3 days
PR: 282734
Fixes: c8aa5e526 (move command mapping to commands.c)
Reviewed by: imp, mhorne, Jim Brown <jpb at jimby.name>
Approved by: mhorne (mentor)
Differential Revision: https://reviews.freebsd.org/D49462
nfsd.8: Note that the -n option is deprecated
PR#284616 reported that --maxthreads did not
obey the 256 thread limit defined as MAXNFSDCNT in nfsd.c.
This is actually a feature and not a bug, since many NFS
servers will now want to run more than 256 threads and
--maxthreads can be used to set the upper bound on the
number of threads. (MAXNFSDCNT was used long ago to
define how many daemons would be forked, before daemons
were replaced by kernel threads.)
However, the nfsd.8 man page was misleading, since it
indicated that "-n" was the equivalent to setting both
--minthreads and --maxthreads to the same value.
This patch fixes the man page.
This is a content change.
[3 lines not shown]
tests/sys/fs/fusefs: include iomanip header
io.cc relies on `std::setw(..)`, which is exported by the iomanip C++
header. Newer versions of GoogleTest don't export this header, so add
the explicit include.
This unbreaks the build with GoogleTest 1.15.2.
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D47194
(cherry picked from commit 0077477f215c851fe15c9ea12cfb005125c4238a)
arm: Garbage collect cpufunc_asm_arm11x6.S
Armv6 support has been removed a while ago, we can safely remove
cpufunc_asm_arm11x6.S, as it is now unused.
LinuxKPI: make linux_alloc_pages() honor __GFP_NORETRY
This is to fix slowdowns with drm-kmod that get worse over time as
physical memory become more fragmented (and probably also depending on
other factors).
Based on information posted in this bug report:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277476
By default, linux_alloc_pages() retries failed allocations by calling
vm_page_reclaim_contig() to attempt to free contiguous physical memory
pages. vm_page_reclaim_contig() does not always succeed and calling it
can be very slow even when it fails. When physical memory is very
fragmented, vm_page_reclaim_contig() can end up being called (and
failing) after every allocation attempt. This could cause very
noticeable graphical desktop hangs (which could last seconds).
The drm-kmod code in question attempts to allocate multiple contiguous
pages at once but does not actually require them to be contiguous. It
[36 lines not shown]
tests: fix test for NULL encription
After 04207850a9b9 it is required that key length is not zero.
Add some key to avoid error.
Reported by: markj
MFC after: 1 week
usb-msctest: Be more conservative setting GETMAXLUN quirk
Only set the GETMAXLUN quirk when it causes an error, but don't set it
when it returns 0. Since we reset the device when we set any quirk, only
set this quirk when it generates an error so umass will avoid it. When
the command works, there's no reason for umass to avoid it at all.
MFC After: 1 week
Sponsored by: Netflix
(cherry picked from commit b0375f78e32acd7947d28126a5e165f8139a5a23)
bhyve: Suppress unimplemented MSR related warnings
When using bhyve on x86, rdmsr and wrmsr can emit many warnings when
dealing with unimplemented MSRs. An option x86.verbosemsr is created to
control these warnings. By default, the MSR related warnings are
suppressed to avoid spamming the console.
Sponsored by: Netflix
Reviewed by: imp, jhb
Pull Request: https://github.com/freebsd/freebsd-src/pull/1611
beep: Remove unnecessary include of src.opts.mk
Reviewed by: chs
Fixes: 623be660fcc9 ("beep: add missing include of src.opts.mk, use LIBADD instead of LDFLAGS")
Differential Revision: https://reviews.freebsd.org/D49485
sockbuf: provide sbunreserve_locked() which is a complement to sbreserve()
The sbreserve() works only on protocol-independent parts of the sockbuf,
but sbrelease() also clears the generic sockbuf mbuf chain. Calling the
latter to undo changes done by the former is not correct. The new
function is the right thing.
Reviewed by: markj
Differential Revision: https://reviews.freebsd.org/D49364
sockbuf: remove sbflush_internal() and sbrelease_internal() shims
This functions serve just one purpose - allow to call sbdestroy() from
sofree() without triggering unlocked mutex assertions. Let's just don't
save on locking with INVARIANTS kernel and this will allow to clean up all
these shims. Should be no functional changes.
Reviewed by: markj
Differential Revision: https://reviews.freebsd.org/D49363
tcp: fix reverting of spurious timeouts (RTO)
One variable that became critical to correctly calculate
the cwnd during limited transmit was not properly reverted
on detection of spurious timeouts.
PR: 282605
Reviewed By: cc, tuexen, #transport
MFC after: 3 days
Sponsored by: NetApp, Inc.
Differential Revision: https://reviews.freebsd.org/D48652
(cherry picked from commit 6f6c07813b38ab04d8b1b2bb87c0291dbae25a25)
vm_reserv: clarify reserv_from_object
vm_reserv_from_page returns an existing reservation, or initializes a
successor pointer, or both. If it returns an existing reservation,
callers will ignore the successor pointer, initialized or not, so
initializing it serves no purpose. So, don't initialize it in that
case, and make less ambiguous the comment that describes the
function's behavior.
Reviewed by: markj, kib, alc
Differential Revision: https://reviews.freebsd.org/D49415
struct kinfo_knote: add spare fields
This is yet another ABI breakage, hopefully the last.
Reviewed by: markj
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Diffferential revision: https://reviews.freebsd.org/D49372