Linux/linux e8e9c98drivers/net/phy dp83640.c

dp83640: reject unsupported external timestamp flags

Fix the dp83640 PTP support to explicitly reject any future flags that
get added to the external timestamp request ioctl.

In order to maintain currently functioning code, this patch accepts all
three current flags. This is because the PTP_RISING_EDGE and
PTP_FALLING_EDGE flags have unclear semantics and each driver seems to
have interpreted them slightly differently.

For the record, the semantics of this driver are:

  flags                                                 Meaning
  ----------------------------------------------------  --------------------------
  PTP_ENABLE_FEATURE                                    Time stamp rising edge
  PTP_ENABLE_FEATURE|PTP_RISING_EDGE                    Time stamp rising edge
  PTP_ENABLE_FEATURE|PTP_FALLING_EDGE                   Time stamp falling edge
  PTP_ENABLE_FEATURE|PTP_RISING_EDGE|PTP_FALLING_EDGE   Time stamp falling edge

Cc: Stefan Sørensen <stefan.sorensen at spectralink.com>
Cc: Richard Cochran <richardcochran at gmail.com>
Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
Reviewed-by: Richard Cochran <richardcochran at gmail.com>
Signed-off-by: David S. Miller <davem at davemloft.net>
DeltaFile
+5-0drivers/net/phy/dp83640.c
+5-01 files

UnifiedSplitRaw