Displaying 1 50 of 296,121 commits (0.023s)

FreeBSD — head/sys/dev/usb usb_device.c

Extend the UQ_NO_STRINGS quirk to also cover the USB language string
descriptor. This fixes enumeration of some older Samsung Galaxy S3
phones.

MFC after:        1 week
Delta File
+3 -1 head/sys/dev/usb/usb_device.c
+3 -1 1 file

FreeBSD — stable/10/contrib/netbsd-tests/lib/libc/sys t_connect.c

MFC r298366:

Fix coverity issues with contrib/netbsd-tests/lib/libc/sys/t_connect.c

- Ensure socket(2) calls succeed
- Don't leak slist allocated by earlier socket(2) call

CID: 976773, 1251405

FreeBSD — stable/10/tests/sys/posixshm posixshm_test.c

MFC r298304:

Fix issues identified by Coverity

- Always munmap memory regions after mmap'ing them.
- Make sure getpagesize() returns a value greater than 0 and use a
  cached value instead of always calling getpagesize(3).
- Remove intermediate variable for assigning from $TMPDIR if set in the
  environment to eliminate warnings about pointer conversions with "/tmp",
  and to mute an invalid buffer overflow concern from Coverity
  (snprintf and tacking on a NUL terminator was alleviating that concern
  before).
- Remove useless self-test of psize before it's initialized.
- Check the return values of getrlimit/setrlimit.

Cosmetic changes:
- Replace a `(void*)0` with NULL.
- Do some minor whitespace clean up.
- Remove an unnecessary cast to mmap.
- Make all munmap calls use ATF_REQUIRE_MSG instead of using the:

  > if (munmap(..) == -1)
  >    atf_tc_fail(..)

  idiom. Employ the new idiom consistently when calling munmap.

    [2 lines not shown]

FreeBSD — stable/10/tests/sys/vm mmap_test.c

MFC r298301:

Fix leaks and test for getpagesize() returning == -1

- close file descriptors after use.
- Always munmap memory regions after mmap'ing them.
- Make sure getpagesize() returns a value greater than 0 and use a
  cached value instead of always calling getpagesize(3).

CID: 1331374-1331377, 1331653-1331662
Delta File
+35 -21 stable/10/tests/sys/vm/mmap_test.c
+35 -21 1 file

FreeBSD — stable/10/sbin/camcontrol camcontrol.c

MFC r298758:

Remove logically impossible test in scsidoinquiry(..)

It was already done 4 lines prior and the value of error didn't change

CID: 1011236

FreeBSD — user/ngie/release-pkg-fix-tests/share/examples/tests/tests/atf Makefile cp_test.sh, user/ngie/release-pkg-fix-tests/share/examples/tests/tests/plain Makefile cp_test.sh

Provide working examples which use PACKAGE/${PACKAGE}FILES

file1 was previously created on the fly and deleted after the test was
over. Switch things up a bit by installing it via the build, so helpful
comments and reasoning can be added for the ${PACKAGE}FILES idiom I've
sprinkled around the tree on the branch

Also, in plain/cp_test.sh, use file3 in the second test instead of file2.
Using file2 worked previously because the files' permissions were reset
when the files were truncated, but since the environment for both the
`force` and `simple` testcases are the same, it would fail when `force`
followed `simple`, as file2 existed when `force` was run, but had
incorrect permissions, thus resulting in a permission died error from
cp(1).

FreeBSD — stable/9/crypto/openssl/crypto/asn1 a_type.c tasn_dec.c, stable/9/crypto/openssl/crypto/evp encode.c evp_enc.c

Fix several OpenSSL vulnerabilities.

Security:        CVE-2016-2105, CVE-2016-2106, CVE-2016-2109
Security:        CVE-2016-2176 (does not affect FreeBSD)
Security:        FreeBSD-SA-16:17.openssl

FreeBSD — head/sys/dev/acpi_support atk0110.c

s/struct device */device_t/g

Submitted by:        kmacy

FreeBSD — head/sys/dev/fdc fdcvar.h

s/struct device */device_t/g

Submitted by:        kmacy
Delta File
+1 -1 head/sys/dev/fdc/fdcvar.h
+1 -1 1 file

FreeBSD — head/sys/dev/esp esp_pci.c

s/struct device */device_t/g

Submitted by:        kmacy
Delta File
+1 -1 head/sys/dev/esp/esp_pci.c
+1 -1 1 file

FreeBSD — head/sys/dev/buslogic btreg.h

s/struct device */device_t/g

Submitted by:        kmacy
Delta File
+1 -1 head/sys/dev/buslogic/btreg.h
+1 -1 1 file

FreeBSD — head/sys/dev/lmc if_lmc.h

s/struct device */device_t/g

Submitted by:        kmacy
Delta File
+1 -1 head/sys/dev/lmc/if_lmc.h
+1 -1 1 file

FreeBSD — head/sys/dev/pci pci.c

Fix build without "options PCI_IOV".
Delta File
+4 -1 head/sys/dev/pci/pci.c
+4 -1 1 file

FreeBSD — user/ngie/release-pkg-fix-tests/cddl/usr.sbin/dtrace/tests Makefile

Be less emphatic with KYUAFILE, i.e. use yes, not YES

Although not illegal, it's inconsistent with other uses

FreeBSD — user/ngie/release-pkg-fix-tests/lib/atf/tests/test-programs Makefile

Add a newline between TESTSDIR and KYUAFILE for consistency

FreeBSD — user/ngie/release-pkg-fix-tests/tests Makefile

Only account for Kyuafile once with KYUAFILE=yes

Let suite.test.mk handle the rest

Sort the make variables while here

FreeBSD — user/ngie/release-pkg-fix-tests/libexec/atf/atf-sh/tests Makefile, user/ngie/release-pkg-fix-tests/share/examples/tests/tests/atf Makefile

Reap TESTSPACKAGE definitions and associated Kyuafile definitions

The former is covered in bsd.test.mk, the latter is covered in suite.test.mk

FreeBSD — head/usr.bin/mkuzip Makefile.depend

DIRDEPS_BUILD: Update dependencies.

Sponsored by:        EMC / Isilon Storage Division

FreeBSD — head/share/mk local.dirdeps.mk

DIRDEPS_BUILD: Exclude secure/lib* libraries for host builds.

Sponsored by:        EMC / Isilon Storage Division
Delta File
+1 -0 head/share/mk/local.dirdeps.mk
+1 -0 1 file

FreeBSD — head/sys/kern subr_hash.c

kern: Factor out function to convert hash flags to malloc(9) flags

Suggested by:        jhb
Reviewed by:        jhb, kib
Sponsored by:        Microsoft OSTC
Differential Revision:        https://reviews.freebsd.org/D6184
Delta File
+12 -10 head/sys/kern/subr_hash.c
+12 -10 1 file

FreeBSD — user/ngie/release-pkg-fix-tests/cddl/usr.sbin/dtrace/tests dtrace.test.mk

Add PACKAGE info to ${TESTGROUP}EXE

FreeBSD — user/ngie/release-pkg-fix-tests/cddl/usr.sbin/dtrace/tests dtrace.test.mk, user/ngie/release-pkg-fix-tests/cddl/usr.sbin/dtrace/tests/tools genmakefiles.sh

Use ${PACKAGE}FILES instead of TESTFILES

For some odd reason make was getting "lost" with the former idiom and wasn't
installing .d and .ksh scripts..

FreeBSD — head/sys/dev/bwn if_bwn.c

[bwn] fix rate control feedback.

* Add a debug print for the xmit completion status fields.
  Yes, I like staring at a stream of DWORDS.

* Set the retrycnt to the number of full frame retries for now;
  I'll figure out how to factor rts/cts failures into it when
  I figure out what the difference is.

  It's -1 because it's not "retries", it's "tries".

It now passes the youtube test.

Tested:

* BCM4312, STA mode
Delta File
+10 -10 head/sys/dev/bwn/if_bwn.c
+10 -10 1 file

FreeBSD — head/bin/sh parser.c

sh: Handle empty hostname and $PWD when building prompt

If the hostname is empty and \h is used in $PS1,
the remainder of the prompt following \h will be empty.
Likewise for $PWD and \w.  Fix it.

Reviewed by:        jilles
MFC after:        1 week
Sponsored by:        Dell Inc.
Differential Revision:        https://reviews.freebsd.org/D6188
Delta File
+3 -2 head/bin/sh/parser.c
+3 -2 1 file

FreeBSD — head/sys/dev/nvram2env nvram2env.c

Fix nvram2env after bus_space_fdt removal.

The generic bus space does the mapping now, no need to pre-translate
phys addresses to KSEG1 anymore.

Submitted by: Hiroki Mori

FreeBSD — head/sys/dev/hptiop hptiop.c

Use imin() macro from sys/libkern.h.

MFC after:        2 weeks.
Delta File
+2 -2 head/sys/dev/hptiop/hptiop.c
+2 -2 1 file

FreeBSD — head/sys/dev/bwn if_bwn.c

[bwn] accurately(ish) account transmit/recieve failures for rate control.

I noticed that it'd associate fine, but it'd quickly stop exchanging traffic.
Receive was okay, but transmit just failed.

Then I went "wlandebug +rate".  I discovered it started at 36M OFDM, and then
quickly rose to 54M, which then showed 0% transmit success.

Then, I dug into how the completion path works.  We are reading 'ack=0'
in the TX status side, so .. then I discovered we were only processing the
TX completion status /if/ ack=1.  So, we'd only ever count successes;
we'd never count failures, and thus the rate control code thought
everything was a-ok.

We also have to set retrycnt to something non-zero so it indeed does
bring the rate down upon failure.

So:

* Delete the rate control completion code from the tx completion
  routine, it's just duplicate and never worked.  Putting it behind
  'if (status->ack) was pointless.

* Move it to the PIO and DMA completion routines which actually
  do free the node reference and mbuf.  We know at that point

    [27 lines not shown]
Delta File
+31 -46 head/sys/dev/bwn/if_bwn.c
+31 -46 1 file

FreeBSD — user/ngie/release-pkg-fix-tests/usr.bin/mkimg/tests Makefile

Fix up some items missed in the TESTS -> ${PACKAGE}FILES conversion

This reared its ugly head because the files weren't being generated/cleaned

FreeBSD — user/ngie/release-pkg-fix-tests/lib/libc/tests/nss Makefile

Convert TESTS to ${PACKAGE}FILES

FreeBSD — user/ngie/release-pkg-fix-tests/lib/libc/tests/regex Makefile

Fix up slightly botched TESTS -> ${PACKAGE}FILES conversion

FreeBSD — head/sys/dev/bwn if_bwn.c

[bwn] ensure the fallback rate stays in the same PHY mode.

Falling back from 6MB OFDM to 5MB CCK (a) may not work well in the
11bg PHYs, (b) won't work at all if you're 11g only, and (c) plainly
won't work for the 11a PHY.

So, don't do that!

Tested:

* BCM4312 802.11b/g Wireless, STA mode
  WLAN (chipid 0x4312 rev 15) PHY (analog 6 type 5 rev 1) RADIO (manuf 0x17f ver 0x2062 
rev 2)
Delta File
+9 -1 head/sys/dev/bwn/if_bwn.c
+9 -1 1 file

FreeBSD — user/ngie/release-pkg-fix-tests/lib/atf/libatf-c/tests/detail Makefile

Replace missed instances of FILES/TESTS with ${PACKAGE}FILES and
reap TESTSPACKAGE definition

FreeBSD — user/ngie/release-pkg-fix-tests/lib/atf/tests Makefile

Remove unnecessary TESTSDIR definition and .include of bsd.own.mk

FreeBSD — user/ngie/release-pkg-fix-tests/usr.bin/bmake/tests Makefile

Fix missed TESTS -> ${PACKAGE}FILES conversion

FreeBSD — stable/10/lib/libcam scsi_cmdparse.c

MFC r298753:

Fix va_list handling

- Add missing va_end's after corresponding va_start's to cleanup state
- Eliminate questionable bzero'ing of va_list passed in to
  do_buff_decode(..) and do_encode(..) from buff_{de,en}code_visit(..)
  and csio_{de,en}code_visit(..). Make va_list a pointer instead and
  pass NULL into the underlying functions to handler this in a portable
  way.
- Do some minor style(9) clean up in affected functions.

CID: 1018500-1018503
Delta File
+41 -38 stable/10/lib/libcam/scsi_cmdparse.c
+41 -38 1 file

FreeBSD — stable/9/contrib/bsnmp/gensnmptree gensnmptree.c

MFstable/10 r299022:

MFC r298450:

Simplify always evaluated branch (`e != NULL`)

- xalloc(..) ensures that e will be non-null via malloc + err.
- `e` is already dereferenced above, so logically it's impossible
  to hit the lower test without crashing if it was indeed NULL.

CID: 1007408

FreeBSD — stable/10/contrib/bsnmp/gensnmptree gensnmptree.c

MFC r298450:

Simplify always evaluated branch (`e != NULL`)

- xalloc(..) ensures that e will be non-null via malloc + err.
- `e` is already dereferenced above, so logically it's impossible
  to hit the lower test without crashing if it was indeed NULL.

CID: 1007408

FreeBSD — stable/10/lib/libc/tests/stdio fmemopen2_test.c freopen_test.c

MFC r298311,r298312:

r298311:

Make sure fmemopen succeeds in :test_append_binary_pos before calling ftell
on the FILE object

This fixes potential null pointer dereferences on failure

CID: 1254952

r298312:

Fix double fclose of `fp1` when freopen fails

freopen handles closing file descriptors on error, with the exception of
fdopen'ed descriptors, so closing an already fclose'd file descriptor is
incorrect

CID: 1338525

FreeBSD — stable/10/contrib/netbsd-tests/lib/libc/ssp h_read.c

MFC r298368,r298660:

r298368:

Fix coverity issue with contrib/netbsd-tests/lib/libc/ssp/h_read.c

Ensure opening /dev/zero succeeds. Abort the test if it doesn't.

Also, use _PATH_DEVZERO instead of hardcoding "/dev/zero"

CID: 1251410

r298660:

Fix up r298368

Remove the semicolon accidentally added after the new conditional that tests
that /dev/zero is opened successfully.

CID: 1354980

FreeBSD — stable/9/contrib/bsnmp/snmpd config.c main.c

MFstable/10 r299018:

MFC r298448,r298464:

r298448:

Don't leak `string` in parse_define(..) when a macro has been found
and the parser token != TOK_ASSIGN

CID: 1007187, 1007188
Obtained from: Isilon OneFS (part of r445479)

r298464:

Use `sizeof(*uuser)` instead of `sizeof(struct usm_user)` for consistency with
the rest of the users in the file

No functional change

FreeBSD — stable/10/contrib/bsnmp/snmpd config.c main.c

MFC r298448,r298464:

r298448:

Don't leak `string` in parse_define(..) when a macro has been found
and the parser token != TOK_ASSIGN

CID: 1007187, 1007188
Obtained from: Isilon OneFS (part of r445479)

r298464:

Use `sizeof(*uuser)` instead of `sizeof(struct usm_user)` for consistency with
the rest of the users in the file

No functional change

FreeBSD — stable/9/usr.sbin/bsnmpd/tools/libbsnmptools bsnmptc.c bsnmptools.c

MFstable/10 r299016:

MFC r298451,r298452,r298507,r298750:

r298451:

Don't use `entry` after free in the "already in lists" case

Return with 0 as it isn't an error.

CID: 1006085
Obtained from: Isilon OneFS (part of r493633)

r298452:

Don't try to free `string` (stack allocated char[])

Fix minor style with warnx call while in the neighborhood

CID: 1009683

r298507:

Fix looking for "UTC" at start of ptr by using strnmp instead of improperly
unrolled equivalent

    [9 lines not shown]

FreeBSD — stable/10/usr.sbin/bsnmpd/tools/libbsnmptools bsnmptc.c bsnmptools.c

MFC r298451,r298452,r298507,r298750:

r298451:

Don't use `entry` after free in the "already in lists" case

Return with 0 as it isn't an error.

CID: 1006085
Obtained from: Isilon OneFS (part of r493633)

r298452:

Don't try to free `string` (stack allocated char[])

Fix minor style with warnx call while in the neighborhood

CID: 1009683

r298507:

Fix looking for "UTC" at start of ptr by using strnmp instead of improperly
unrolled equivalent

CID: 1347118

    [7 lines not shown]

FreeBSD — head/sys/dev/ioat ioat.c

Use DEVMETHOD_END ({ NULL, NULL }) instead of hardcoding { 0, 0 }

Sponsored by: EMC / Isilon Storage Division
Delta File
+1 -1 head/sys/dev/ioat/ioat.c
+1 -1 1 file

FreeBSD — stable/10/sys/netinet6 nd6_rtr.c nd6.c

MFC r295575, r295576, r295578, r295579, r295580:
Various NDP cleanups. No functional change intended.

FreeBSD — user/ngie/release-pkg-fix-tests ObsoleteFiles.inc Makefile.inc1, user/ngie/release-pkg-fix-tests/contrib/subversion/subversion/svn util.c

MFhead @ r299012

FreeBSD — user/ngie/release-pkg-fix-tests/bin/cat/tests Makefile, user/ngie/release-pkg-fix-tests/bin/date/tests Makefile

Checkpoint next iteration for fixing tests after the release packaging merge

On reflection, using TESTS was a bit too opportunistic; I'd rather not break
things unexpectedly in downstream consumers.

In particular:
- Replace all instances of FILES/TESTS with ${PACKAGE}FILES. This ensures that
  namespacing is kept with FILES appropriately, and that this shouldn't need
  to be repeated if the namespace changes -- only the definition of PACKAGE
  needs to be changed
- Remove PACKAGE definitions where possible, i.e. where FILES wasn't used
  previously.
- Remove unnecessary TESTSPACKAGE definitions; this has been elided into
  bsd.tests.mk
- Remove unnecessary BINDIRs used previously with ${PACKAGE}FILES;
  ${PACKAGE}FILESDIR is now defined in bsd.test.mk.
- Remove unnecessary .include <bsd.own.mk>'s
- Fix installation of files under data/ subdirectories in lib/libc/tests/hash
  and lib/libc/tests/net/getaddrinfo
- Allow PACKAGE to be overridden by callers instead of forcing it to always be
  `tests`. In the event we get to the point where things can be split up
  enough in the base system, it would make more sense to group the tests
  with the blocks they're a part of, e.g. byacc with byacc-tests, etc

FreeBSD — head/usr.sbin/pmcstudy pmcstudy.8

pmcstudy.8: minor "efficiency" fix.

No functional change.
Delta File
+1 -1 head/usr.sbin/pmcstudy/pmcstudy.8
+1 -1 1 file