Displaying 1 50 of 6,457 commits (0.009s)

OpenBSD — usr.sbin/smtpd smtpctl.c queue.c

fix "smtpctl show queue" reporting "invalid" envelope state.
runtime state is not serialized with the envelope, so add it to the imsg.

ok gilles@
Delta File
+55 -10 usr.sbin/smtpd/smtpctl.c
+8 -12 usr.sbin/smtpd/queue.c
+63 -22 2 files

OpenBSD — usr.sbin/smtpd ssl.c smtpd.conf.5

Use automatic DH parameters, instead of fixed ones. Also disable DHE by
default since it is computationally expensive and a potential DoS vector.

ok gilles@

OpenBSD — usr.sbin/smtpd smtpd.8

add -T to SYNOPSIS;
Delta File
+2 -1 usr.sbin/smtpd/smtpd.8
+2 -1 1 file

OpenBSD — usr.sbin/smtpd smtpd.8

document the -T flag

original diff from Bernard Spil

ok millert
Delta File
+37 -2 usr.sbin/smtpd/smtpd.8
+37 -2 1 file

OpenBSD — usr.sbin/smtpd smtpctl.8

fix typo, it is supposed to be smtpctl trace "filters" not "filter"

from Boudewijn Dijkstra
Delta File
+3 -3 usr.sbin/smtpd/smtpctl.8
+3 -3 1 file

OpenBSD — usr.sbin/smtpd smtpd.conf.5

arguments to "chain" are space separated, not comma; verified by jung
diff from david+bsd

i also removed Op, since ... is enough/
Delta File
+3 -3 usr.sbin/smtpd/smtpd.conf.5
+3 -3 1 file

OpenBSD — bin/ksh Makefile, bin/md5 Makefile

for some time now mandoc has not required MLINKS to function
correctly - logically complete that now by removing MLINKS from base;

authors need only to ensure there is an entry in NAME for any function/
util being added. MLINKS will still work, and remain for perl to ease
upgrades;

ok nicm (curses) bcook (ssl)
ok schwarze, who provided a lot of feedback and assistance
ok tb natano jung
Delta File
+1 -903 lib/libcrypto/man/Makefile
+1 -436 share/man/man9/Makefile
+1 -202 lib/libm/Makefile
+1 -175 lib/libcurses/Makefile
+1 -166 lib/libssl/man/Makefile
+1 -111 lib/libc/rpc/Makefile.inc
+114 -1,141 115 files not shown
+120 -3,134 121 files

OpenBSD — usr.sbin/ntpd control.c ntpd.h

Rename session_socket_blockmode() to session_socket_nonblockmode(),
removing its second parameter and the enum() that provided the
values for said parameter.

The function was only called with the second parameter set to one
value (BM_NONBLOCKING) from the enum(). So just do the right thing.
Similar to changes made in smtpd.

While here remove the pointless third parameter from the fcntl(F_GETFL)
call.

No functional change.

ok guenther@ bcook@ deraadt@
Delta File
+6 -9 usr.sbin/ntpd/control.c
+2 -7 usr.sbin/ntpd/ntpd.h
+8 -16 2 files

OpenBSD — usr.sbin/smtpd util.c ioev.c

Nuke session_socket_blockmode() and session_socket_linger(). Use
the identical io_set_blocking() and io_set_linger().

Since both are always called to turn off blocking or lingering,
nuke the parameter and associated enum in favour of "just doing the
right thing".

While passing remove the unneeded last parameter to the remaining
fcntl(F_GETFL).

Finally, rename the functions to io_set_nonblocking() and
io_set_nolinger() for clarity.

No functional change.

Started with a sweep of fcntl() usage inspired by guenther@.

ok gilles@

OpenBSD — regress/lib/libpthread/signals/ignore_sigchild ignore_sigchild.c, regress/sys/kern/exec_self exec_self.c

Last parameter to execl[e]() functions *must* be cast to a pointer.
Just NULL is not good practise as NULL is theoretically allowed to
be an integer rather than a pointer.

Use (char *)NULL consistently instead of scattering a few (char *)0
and (void *)NULL into the mix.

Prompted by and probably ok deraadt@ millert@ kettenis@

Definitely ok mestre@ ratchov@

FreeBSD Ports — head/mail/postfix-current Makefile distinfo

- update to 3.2-20160314
- change comment to reflect this is a  Experimental version
- fix CONFLICTS

Changes:
20160227
        Cleanup: remember multiple BCC actions in access maps.
        Files: smtpd/smtpd.h, smtpd/smtpd.c, smtpd/smtpd_check.c,
        smtpd/smtpd_state.c, proto/access.

20160228
        Documentation: STRESS_README. File: proto/STRESS_README.html.

20160229
        Documentation: postmulti manpage. File: postmulti/postmulti.c.

20160305
        Future-proofing: detect integer overflow before it happens.
        After-the-fact detection relies on assumptions about
        undefined behavior that are invalidated by compilers.  Files:
        util/mymalloc.c, util/vstring.c.

20160310
        Bugfix (introduced: Postfix 2.6): the Milter SMFIR_CHGFROM
        (replace sender) request lost the sender_bcc_maps address.

    [15 lines not shown]

OpenBSD — usr.sbin/smtpd smtpd.conf.5

fix error in documentation of `ca' keyword

From: Sevan Janiyan <venture37 at geeklan.co.uk>
Delta File
+3 -3 usr.sbin/smtpd/smtpd.conf.5
+3 -3 1 file

Bitrig — usr.sbin/smtpd smtpd.conf.5

fix error in documentation of `ca' keyword

From: Sevan Janiyan <venture37 at geeklan.co.uk>
Delta File
+3 -3 usr.sbin/smtpd/smtpd.conf.5
+3 -3 1 file

OpenBSD — usr.sbin/smtpd parse.y

the default address family for a listener was set too late and would
override the value provided by the user if any. this commit moves the
initialization earlier to avoid this.

issue reported by and fix ok jturner@
Delta File
+6 -7 usr.sbin/smtpd/parse.y
+6 -7 1 file

Bitrig — usr.sbin/smtpd parse.y

the default address family for a listener was set too late and would
override the value provided by the user if any. this commit moves the
initialization earlier to avoid this.

issue reported by and fix ok jturner@
Delta File
+6 -7 usr.sbin/smtpd/parse.y
+6 -7 1 file

Bitrig — usr.sbin/smtpd smtpd.h

bump version
Delta File
+2 -2 usr.sbin/smtpd/smtpd.h
+2 -2 1 file

OpenBSD — usr.sbin/smtpd to.c

Revert previous, semarie@ found a regression.
Delta File
+34 -15 usr.sbin/smtpd/to.c
+34 -15 1 file

Bitrig — usr.sbin/smtpd to.c

Revert previous, semarie@ found a regression.
Delta File
+34 -15 usr.sbin/smtpd/to.c
+34 -15 1 file

OpenBSD — usr.sbin/smtpd to.c

Simplify address parsing code by only using inet_net_pton(3).

There's no need to have a separate case for non-CIDR addresses using
inet_pton(3) as inet_net_pton(3) handles them as well.

This simplification is valid for all our daemons parsing addresses,
it is a common patern.

ok gilles@, millert@, jung@
Delta File
+15 -34 usr.sbin/smtpd/to.c
+15 -34 1 file

Bitrig — usr.sbin/smtpd to.c

Simplify address parsing code by only using inet_net_pton(3).

There's no need to have a separate case for non-CIDR addresses using
inet_pton(3) as inet_net_pton(3) handles them as well.

This simplification is valid for all our daemons parsing addresses,
it is a common patern.

ok gilles@, millert@, jung@
Delta File
+15 -34 usr.sbin/smtpd/to.c
+15 -34 1 file

OpenBSD — usr.sbin/smtpd smtpd.conf.5

tweak previous;
Delta File
+3 -5 usr.sbin/smtpd/smtpd.conf.5
+3 -5 1 file

Bitrig — usr.sbin/smtpd smtpd.conf.5

tweak previous;
Delta File
+3 -5 usr.sbin/smtpd/smtpd.conf.5
+3 -5 1 file

OpenBSD — usr.sbin/smtpd smtpd.conf.5

describe how 'listen on socket' works

original diff from Peter Bisroev <peter at int19h.net>
rewording from me, linebreaks from jung@
Delta File
+32 -6 usr.sbin/smtpd/smtpd.conf.5
+32 -6 1 file

Bitrig — usr.sbin/smtpd smtpd.conf.5

describe how 'listen on socket' works

original diff from Peter Bisroev <peter at int19h.net>
rewording from me, linebreaks from jung@
Delta File
+32 -6 usr.sbin/smtpd/smtpd.conf.5
+32 -6 1 file

OpenBSD — usr.sbin/smtpd parse.y smtp.c

handle enqueuer socket as a regular listener that can be configured with
"listen on socket". this simplifies a bit of code, removes some special
cases and will allow attaching filters & masking source just as on lo0.

diff from Peter Bisroev <peter at int19h.net>
ok gilles@, jung@
Delta File
+98 -39 usr.sbin/smtpd/parse.y
+3 -14 usr.sbin/smtpd/smtp.c
+101 -53 2 files

Bitrig — usr.sbin/smtpd parse.y smtp.c

handle enqueuer socket as a regular listener that can be configured with
"listen on socket". this simplifies a bit of code, removes some special
cases and will allow attaching filters & masking source just as on lo0.

diff from Peter Bisroev <peter at int19h.net>
ok gilles@, jung@

OpenBSD — usr.sbin/smtpd smtp.c

remove some noop leftover code from an earlier cleanup

diff from Peter Bisroev <peter at int19h.net>
Delta File
+6 -13 usr.sbin/smtpd/smtp.c
+6 -13 1 file

Bitrig — usr.sbin/smtpd smtp.c

remove some noop leftover code from an earlier cleanup

diff from Peter Bisroev <peter at int19h.net>
Delta File
+6 -13 usr.sbin/smtpd/smtp.c
+6 -13 1 file

OpenBSD — usr.sbin/smtpd makemap.8 makemap.c

remove support for 'dbm' which is really 'recno' from our makemap, it can't
work because it requires dbopen() to be the call that creates the db, while
we want mkstemp() to create an empty db ourselves.

it has never worked, no one could ever create a recno db with our makemap &
no one actually noticed so drop it.

ok millert@, sunil@, jung@

Bitrig — usr.sbin/smtpd makemap.8 makemap.c

remove support for 'dbm' which is really 'recno' from our makemap, it can't
work because it requires dbopen() to be the call that creates the db, while
we want mkstemp() to create an empty db ourselves.

it has never worked, no one could ever create a recno db with our makemap &
no one actually noticed so drop it.

ok millert@, sunil@, jung@

OpenBSD — usr.sbin/smtpd smtpctl.c makemap.c

Cleanup getopt(3) mis-use in sendmail compat code.

Avoid multiple getopt(3) evaluations without optreset set and
unspecified behavior of optind = 0 as per POSIX. Instead, iterate
over argv the first time for classification. Fixes -portable without
any divergence from -current, and all newaliases opts are handled
in one place.

Looks good to me millert@
Ok gilles@ jung@ eric@
Delta File
+41 -66 usr.sbin/smtpd/smtpctl.c
+19 -5 usr.sbin/smtpd/makemap.c
+60 -71 2 files

Bitrig — usr.sbin/smtpd smtpctl.c makemap.c

Cleanup getopt(3) mis-use in sendmail compat code.

Avoid multiple getopt(3) evaluations without optreset set and
unspecified behavior of optind = 0 as per POSIX. Instead, iterate
over argv the first time for classification. Fixes -portable without
any divergence from -current, and all newaliases opts are handled
in one place.

Looks good to me millert@
Ok gilles@ jung@ eric@
Delta File
+41 -66 usr.sbin/smtpd/smtpctl.c
+19 -5 usr.sbin/smtpd/makemap.c
+60 -71 2 files

Bitrig — usr.sbin/smtpd mproc.c

Change imsg_read() return value checking from an if..else block to
a switch statement for improved readability.  OK jung@ sunil@ gilles@
Delta File
+10 -6 usr.sbin/smtpd/mproc.c
+10 -6 1 file

OpenBSD — usr.sbin/smtpd makemap.c

when creating a db map, we use a temporary file to work on and atomically
move to destination when done. this causes dbopen() to be called with an
empty file which happens to... not work with other db libraries.

adding O_TRUNC is noop for us, fixes the issue for other libraries and
lets us reduce delta between us and portable.

ok sunil@, ok eric@
Delta File
+2 -2 usr.sbin/smtpd/makemap.c
+2 -2 1 file

Bitrig — usr.sbin/smtpd makemap.c

when creating a db map, we use a temporary file to work on and atomically
move to destination when done. this causes dbopen() to be called with an
empty file which happens to... not work with other db libraries.

adding O_TRUNC is noop for us, fixes the issue for other libraries and
lets us reduce delta between us and portable.

ok sunil@, ok eric@
Delta File
+2 -2 usr.sbin/smtpd/makemap.c
+2 -2 1 file

OpenBSD — usr.sbin/smtpd smtpd-api.h

add PROC_QUEUE_MESSAGE_UNCORRUPT to smtpd-api.h, needed by privsep queues
Delta File
+2 -1 usr.sbin/smtpd/smtpd-api.h
+2 -1 1 file

Bitrig — usr.sbin/smtpd smtpd-api.h

add PROC_QUEUE_MESSAGE_UNCORRUPT to smtpd-api.h, needed by privsep queues
Delta File
+2 -1 usr.sbin/smtpd/smtpd-api.h
+2 -1 1 file

Bitrig — usr.sbin/smtpd mproc.c

r1.16 accidentally masked retries on EAGAIN introduced in r1.15.
Fix and simplify imsg_read() return value checking into a single
if..else block.

Ok gilles@ jung@
Delta File
+6 -7 usr.sbin/smtpd/mproc.c
+6 -7 1 file

OpenBSD — usr.sbin/smtpd smtpctl.c

rename variable sun to s_un to ease portability

diff from Freddy DISSAUX, ok gilles@, jung@, sunil@, millert@
Delta File
+6 -6 usr.sbin/smtpd/smtpctl.c
+6 -6 1 file

Bitrig — usr.sbin/smtpd control.c smtpctl.c

rename variable sun to s_un to ease portability

diff from Freddy DISSAUX, ok gilles@, jung@, sunil@, millert@
Delta File
+11 -11 usr.sbin/smtpd/control.c
+6 -6 usr.sbin/smtpd/smtpctl.c
+17 -17 2 files

Bitrig — usr.sbin/smtpd smtpd.h

remove no longer relevant ifndef

suggested by gilles
Delta File
+1 -3 usr.sbin/smtpd/smtpd.h
+1 -3 1 file

OpenBSD — usr.sbin/smtpd smtpd.c

use SMTPD_NAME define

ok gilles
Delta File
+2 -2 usr.sbin/smtpd/smtpd.c
+2 -2 1 file

Bitrig — usr.sbin/smtpd smtp_session.c smtpd.c

use SMTPD_NAME define

ok gilles

Bitrig — usr.sbin/smtpd rfc2822.c

fix memory leak

ok gilles@ jung@
Delta File
+2 -1 usr.sbin/smtpd/rfc2822.c
+2 -1 1 file

Bitrig — usr.sbin/smtpd smtp_session.c

Make code more readable by putting the message parsing logic in a single place.

ok gilles@ sunil@ jung@
Delta File
+22 -23 usr.sbin/smtpd/smtp_session.c
+22 -23 1 file

OpenBSD — usr.sbin/smtpd queue_backend.c

When deleting a message, remove associated envelopes from the cache,
if any (it happens when a message transaction is cancelled).

ok gilles@ sunil@
Delta File
+14 -1 usr.sbin/smtpd/queue_backend.c
+14 -1 1 file

Bitrig — usr.sbin/smtpd queue_backend.c

When deleting a message, remove associated envelopes from the cache,
if any (it happens when a message transaction is cancelled).

ok gilles@ sunil@
Delta File
+14 -1 usr.sbin/smtpd/queue_backend.c
+14 -1 1 file

Bitrig — usr.sbin/smtpd smtp_session.c

Add helpers function to talk to the queue. Make the code simpler.

ok gilles@ sunil@
Delta File
+53 -35 usr.sbin/smtpd/smtp_session.c
+53 -35 1 file

Bitrig — usr.sbin/smtpd smtp_session.c

tell filters to rollback the current transaction if MAIL or EOM fails

ok gilles@ jung@
Delta File
+3 -1 usr.sbin/smtpd/smtp_session.c
+3 -1 1 file

OpenBSD — usr.sbin/smtpd filter.c

When a filter rejects a message content, report immediatly to the
smtp session. Simplify code while here.

ok gilles@ jung@
Delta File
+14 -25 usr.sbin/smtpd/filter.c
+14 -25 1 file