Displaying 1 50 of 6,672 commits (0.010s)

OpenBSD — usr.sbin/smtpd smtp_session.c

move transaction-specific states from struct smtp_session to struct smtp_tx

ok gilles@
Delta File
+191 -150 usr.sbin/smtpd/smtp_session.c
+191 -150 1 file

OpenBSD — sbin/iked parse.y, sbin/ipsecctl parse.y

do not allow whitespace in macro names, i.e. "this is" = "a variable".
change this in all config parsers in our tree that support macros.
problem reported by sven falempin.

feedback from henning@, stsp@, deraadt@
ok florian@ mikeb@
Delta File
+9 -1 usr.sbin/ypldap/parse.y
+9 -1 sbin/ipsecctl/parse.y
+9 -1 sbin/pfctl/parse.y
+9 -1 usr.sbin/bgpd/parse.y
+9 -1 usr.sbin/dvmrpd/parse.y
+9 -1 usr.sbin/eigrpd/parse.y
+126 -14 14 files not shown
+180 -20 20 files

OpenBSD — usr.sbin/smtpd smtpd.c

with new fork+reexec, in case of failure in init of any child process
causing it to exit, we could end up with a NULL deref in parent.

free commit offered by eric@, ok gilles@
Delta File
+4 -1 usr.sbin/smtpd/smtpd.c
+4 -1 1 file

OpenBSD — usr.sbin/smtpd smtp_session.c

Also add missing date or message-id when listening on the submit port
ok gilles@
Delta File
+2 -2 usr.sbin/smtpd/smtp_session.c
+2 -2 1 file

OpenBSD — usr.sbin/smtpd smtp_session.c

properly reset the transaction when a filter rejects a message.

ok gilles@
Delta File
+4 -1 usr.sbin/smtpd/smtp_session.c
+4 -1 1 file

OpenBSD — usr.sbin/smtpd limit.c

increase number of connections a local address is allowed to establish
decrease the delay between transactions in the same session

ok eric@
Delta File
+3 -3 usr.sbin/smtpd/limit.c
+3 -3 1 file

OpenBSD — usr.sbin/smtpd smtp_session.c

'Received' header violates RFC when receiving a TLS session, rework format

reported by vstakhov
Delta File
+2 -2 usr.sbin/smtpd/smtp_session.c
+2 -2 1 file

OpenBSD — usr.sbin/smtpd smtpctl.8

Fix typo; OK jung@
Delta File
+3 -3 usr.sbin/smtpd/smtpctl.8
+3 -3 1 file

FreeBSD Ports — head/mail/postfix-current distinfo Makefile, head/mail/postfix-current/files patch-src_tls_tls.h patch-src__util__sys_defs.h

- update to 3.2-20160612
- fix build with LibreSSL [1]

20160601
        Cleanup: moved parsing of '!' operators from cidr_match.c
        to dict_cidr.c. Files: util/cidr_match.[hc], util/dict_cidr.c,
        util/match_ops.c.

20160604
        Cleanup: made parsing of '!' operators in regexp and pcre
        tables consistent with cidr tables. Files: util/dict_regexp.c,
        util/dict_pcre.c.

20160605
        Cleanup: integer wrap-around detection in the MySQL and
        PostgreSQL clients. This is totally non-critical because
        Postfix strings are size-limited by design. Files:
        global/dict_mysqql.c, global/dict_pgsql.c.

20160607
        Documentation: dnsblog.

20160609
        Documentation: postsuper(1) manpage text for multiple -[dhH]
        options.  File: postsuper/postsuper.c.

    [19 lines not shown]

OpenBSD — usr.sbin/smtpd smtp_session.c

quote space-containing values in smtpd logs or they become hard to parse

diff by Pavel Korovin <p at tristero.se>, ok giovanni@
Delta File
+6 -6 usr.sbin/smtpd/smtp_session.c
+6 -6 1 file

OpenBSD — usr.sbin/smtpd smtpd.c

use io_set_nonblocking() instead of SOCK_NONBLOCKING to reduce delta with
-portable
Delta File
+9 -3 usr.sbin/smtpd/smtpd.c
+9 -3 1 file

OpenBSD — usr.sbin/smtpd mproc.c

do not return on EAGAIN otherwise the event is never reloaded.

ok gilles@
Delta File
+2 -2 usr.sbin/smtpd/mproc.c
+2 -2 1 file

OpenBSD — usr.sbin/smtpd delivery_lmtp.c

LMTP banner is handled by a getline() call so it cannot handle multiline
banners, introduce lmtp_banner() which takes care of this.

ok sunil@
Delta File
+39 -6 usr.sbin/smtpd/delivery_lmtp.c
+39 -6 1 file

OpenBSD — usr.sbin/smtpd delivery_lmtp.c

delivery_lmtp does not know how to deal with LMTP servers returning
continuation lines, fix this.

reported and initial diff by parchd-1 @ github, ok sunil@
Delta File
+29 -9 usr.sbin/smtpd/delivery_lmtp.c
+29 -9 1 file

OpenBSD — usr.sbin/smtpd smtpctl.8

transfer is not a smtpctl command, but mta is

ok gilles
Delta File
+3 -3 usr.sbin/smtpd/smtpctl.8
+3 -3 1 file

OpenBSD — usr.sbin/smtpd to.c

Simplify address parsing code by only using inet_net_pton(3).

There's no need to have a separate case for non-CIDR addresses using
inet_pton(3) as inet_net_pton(3) handles them as well.

This simplification is valid for all our daemons parsing addresses,
it is a common patern.

ok gilles@, millert@
Delta File
+15 -37 usr.sbin/smtpd/to.c
+15 -37 1 file

OpenBSD — usr.sbin/smtpd smtpd.c config.c

Implement the fork+exec pattern in smtpd.

The parent process forks child processes and re-exec each of them with
an additional "-x <proc>" argument.  During the early setup phase, the
parent process sends ipc socket pairs to interconnect the child
processes as needed, and it passes the queue encryption key to the
queue if necessary. When this is done, all processes have their
environment set as in the fork-only case, and they can start doing
their work as before.

ok gilles@ jung@
Delta File
+410 -92 usr.sbin/smtpd/smtpd.c
+10 -46 usr.sbin/smtpd/config.c
+11 -9 usr.sbin/smtpd/smtpd.h
+2 -13 usr.sbin/smtpd/ca.c
+2 -13 usr.sbin/smtpd/queue.c
+2 -13 usr.sbin/smtpd/scheduler.c
+6 -39 3 files not shown
+443 -225 9 files

OpenBSD — usr.sbin/smtpd smtp_session.c mta_session.c

start work on improving the log format, this is work in progress but it'll
be better worked in tree

ok eric@, beck@

OpenBSD — usr.sbin/smtpd to.c

use temporary variables to store some struct tm values, no functional
change but reduces the changeset with portable version
Delta File
+10 -5 usr.sbin/smtpd/to.c
+10 -5 1 file

OpenBSD — usr.sbin/smtpd aliases.c

replace hardcoded '+' with TAG_CHAR define

diff from obadz <github at obadz.com>
Delta File
+4 -4 usr.sbin/smtpd/aliases.c
+4 -4 1 file

OpenBSD — usr.sbin/smtpd smtpd.conf.5

table formats are described in table(5) not makemap(8)
Delta File
+4 -4 usr.sbin/smtpd/smtpd.conf.5
+4 -4 1 file

OpenBSD — usr.sbin/smtpd ioev.c

No need to store the return value of fcntl(fd, F_SETFL, flags).
OK jung@
Delta File
+2 -2 usr.sbin/smtpd/ioev.c
+2 -2 1 file

OpenBSD — usr.sbin/smtpd smtp_session.c filter.c

fix logic in error code path of smtp state machine that can lead to an
invalid state ending in fatal(), while at it plug a file pointer leak.

ok eric@, millert@

OpenBSD — usr.sbin/smtpd util.c

replace hardcoded + with TAG_CHAR
Delta File
+3 -3 usr.sbin/smtpd/util.c
+3 -3 1 file

OpenBSD — usr.sbin/smtpd smtpd.conf.5

mention ca option in listen directive

same spelling fix from jmc and gilles

ok gilles
Delta File
+6 -2 usr.sbin/smtpd/smtpd.conf.5
+6 -2 1 file

OpenBSD — usr.sbin/smtpd smtp_session.c

The "loop detected" message should not print the errno string.
OK gilles@
Delta File
+2 -2 usr.sbin/smtpd/smtp_session.c
+2 -2 1 file

OpenBSD — etc/mail smtpd.conf, usr.sbin/smtpd smtpd.conf.5

listen directive may use a table for authentication, to make this work the
table has to be defined BEFORE
consequently move all tables in the examples to the beginning and before the
listen directive to avoid tables not being found

no functional change

ran into this myself earlier, also reported by cjones via irc

ok gilles
Delta File
+12 -10 usr.sbin/smtpd/smtpd.conf.5
+3 -3 etc/mail/smtpd.conf
+15 -13 2 files

OpenBSD — usr.sbin/smtpd smtpctl.c queue.c

fix "smtpctl show queue" reporting "invalid" envelope state.
runtime state is not serialized with the envelope, so add it to the imsg.

ok gilles@
Delta File
+55 -10 usr.sbin/smtpd/smtpctl.c
+8 -12 usr.sbin/smtpd/queue.c
+63 -22 2 files

OpenBSD — usr.sbin/smtpd ssl.c smtpd.conf.5

Use automatic DH parameters, instead of fixed ones. Also disable DHE by
default since it is computationally expensive and a potential DoS vector.

ok gilles@

OpenBSD — usr.sbin/smtpd smtpd.8

add -T to SYNOPSIS;
Delta File
+2 -1 usr.sbin/smtpd/smtpd.8
+2 -1 1 file

OpenBSD — usr.sbin/smtpd smtpd.8

document the -T flag

original diff from Bernard Spil

ok millert
Delta File
+37 -2 usr.sbin/smtpd/smtpd.8
+37 -2 1 file

OpenBSD — usr.sbin/smtpd smtpctl.8

fix typo, it is supposed to be smtpctl trace "filters" not "filter"

from Boudewijn Dijkstra
Delta File
+3 -3 usr.sbin/smtpd/smtpctl.8
+3 -3 1 file

OpenBSD — usr.sbin/smtpd smtpd.conf.5

arguments to "chain" are space separated, not comma; verified by jung
diff from david+bsd

i also removed Op, since ... is enough/
Delta File
+3 -3 usr.sbin/smtpd/smtpd.conf.5
+3 -3 1 file

OpenBSD — bin/ksh Makefile, bin/md5 Makefile

for some time now mandoc has not required MLINKS to function
correctly - logically complete that now by removing MLINKS from base;

authors need only to ensure there is an entry in NAME for any function/
util being added. MLINKS will still work, and remain for perl to ease
upgrades;

ok nicm (curses) bcook (ssl)
ok schwarze, who provided a lot of feedback and assistance
ok tb natano jung
Delta File
+1 -903 lib/libcrypto/man/Makefile
+1 -436 share/man/man9/Makefile
+1 -202 lib/libm/Makefile
+1 -175 lib/libcurses/Makefile
+1 -166 lib/libssl/man/Makefile
+1 -111 lib/libc/rpc/Makefile.inc
+114 -1,141 115 files not shown
+120 -3,134 121 files

OpenBSD — usr.sbin/ntpd control.c ntpd.h

Rename session_socket_blockmode() to session_socket_nonblockmode(),
removing its second parameter and the enum() that provided the
values for said parameter.

The function was only called with the second parameter set to one
value (BM_NONBLOCKING) from the enum(). So just do the right thing.
Similar to changes made in smtpd.

While here remove the pointless third parameter from the fcntl(F_GETFL)
call.

No functional change.

ok guenther@ bcook@ deraadt@
Delta File
+6 -9 usr.sbin/ntpd/control.c
+2 -7 usr.sbin/ntpd/ntpd.h
+8 -16 2 files

OpenBSD — usr.sbin/smtpd util.c ioev.c

Nuke session_socket_blockmode() and session_socket_linger(). Use
the identical io_set_blocking() and io_set_linger().

Since both are always called to turn off blocking or lingering,
nuke the parameter and associated enum in favour of "just doing the
right thing".

While passing remove the unneeded last parameter to the remaining
fcntl(F_GETFL).

Finally, rename the functions to io_set_nonblocking() and
io_set_nolinger() for clarity.

No functional change.

Started with a sweep of fcntl() usage inspired by guenther@.

ok gilles@

OpenBSD — usr.sbin/smtpd smtpd.h control.c

Nuke session_socket_blockmode() and session_socket_linger(). Use
the identical io_set_blocking() and io_set_linger().

Since both are always called to turn off blocking or lingering,
nuke the parameter and associated enum in favour of "just doing the
right thing".

While passing remove the unneeded last parameter to the remaining
fcntl(F_GETFL).

Finally, rename the functions to io_set_nonblocking() and
io_set_nolinger() for clarity.

No functional change.

Started with a sweep of fcntl() usage inspired by guenther@.

ok gilles@

OpenBSD — regress/lib/libpthread/signals/ignore_sigchild ignore_sigchild.c, regress/sys/kern/exec_self exec_self.c

Last parameter to execl[e]() functions *must* be cast to a pointer.
Just NULL is not good practise as NULL is theoretically allowed to
be an integer rather than a pointer.

Use (char *)NULL consistently instead of scattering a few (char *)0
and (void *)NULL into the mix.

Prompted by and probably ok deraadt@ millert@ kettenis@

Definitely ok mestre@ ratchov@

FreeBSD Ports — head/mail/postfix-current Makefile distinfo

- update to 3.2-20160314
- change comment to reflect this is a  Experimental version
- fix CONFLICTS

Changes:
20160227
        Cleanup: remember multiple BCC actions in access maps.
        Files: smtpd/smtpd.h, smtpd/smtpd.c, smtpd/smtpd_check.c,
        smtpd/smtpd_state.c, proto/access.

20160228
        Documentation: STRESS_README. File: proto/STRESS_README.html.

20160229
        Documentation: postmulti manpage. File: postmulti/postmulti.c.

20160305
        Future-proofing: detect integer overflow before it happens.
        After-the-fact detection relies on assumptions about
        undefined behavior that are invalidated by compilers.  Files:
        util/mymalloc.c, util/vstring.c.

20160310
        Bugfix (introduced: Postfix 2.6): the Milter SMFIR_CHGFROM
        (replace sender) request lost the sender_bcc_maps address.

    [15 lines not shown]

OpenBSD — usr.sbin/smtpd smtpd.conf.5

fix error in documentation of `ca' keyword

From: Sevan Janiyan <venture37 at geeklan.co.uk>
Delta File
+3 -3 usr.sbin/smtpd/smtpd.conf.5
+3 -3 1 file

Bitrig — usr.sbin/smtpd smtpd.conf.5

fix error in documentation of `ca' keyword

From: Sevan Janiyan <venture37 at geeklan.co.uk>
Delta File
+3 -3 usr.sbin/smtpd/smtpd.conf.5
+3 -3 1 file

OpenBSD — usr.sbin/smtpd parse.y

the default address family for a listener was set too late and would
override the value provided by the user if any. this commit moves the
initialization earlier to avoid this.

issue reported by and fix ok jturner@
Delta File
+6 -7 usr.sbin/smtpd/parse.y
+6 -7 1 file

Bitrig — usr.sbin/smtpd parse.y

the default address family for a listener was set too late and would
override the value provided by the user if any. this commit moves the
initialization earlier to avoid this.

issue reported by and fix ok jturner@
Delta File
+6 -7 usr.sbin/smtpd/parse.y
+6 -7 1 file

OpenBSD — usr.sbin/smtpd smtpd.h

bump version
Delta File
+2 -2 usr.sbin/smtpd/smtpd.h
+2 -2 1 file

Bitrig — usr.sbin/smtpd smtpd.h

bump version
Delta File
+2 -2 usr.sbin/smtpd/smtpd.h
+2 -2 1 file

OpenBSD — usr.sbin/smtpd to.c

Revert previous, semarie@ found a regression.
Delta File
+34 -15 usr.sbin/smtpd/to.c
+34 -15 1 file

Bitrig — usr.sbin/smtpd to.c

Revert previous, semarie@ found a regression.
Delta File
+34 -15 usr.sbin/smtpd/to.c
+34 -15 1 file

OpenBSD — usr.sbin/smtpd to.c

Simplify address parsing code by only using inet_net_pton(3).

There's no need to have a separate case for non-CIDR addresses using
inet_pton(3) as inet_net_pton(3) handles them as well.

This simplification is valid for all our daemons parsing addresses,
it is a common patern.

ok gilles@, millert@, jung@
Delta File
+15 -34 usr.sbin/smtpd/to.c
+15 -34 1 file

Bitrig — usr.sbin/smtpd to.c

Simplify address parsing code by only using inet_net_pton(3).

There's no need to have a separate case for non-CIDR addresses using
inet_pton(3) as inet_net_pton(3) handles them as well.

This simplification is valid for all our daemons parsing addresses,
it is a common patern.

ok gilles@, millert@, jung@
Delta File
+15 -34 usr.sbin/smtpd/to.c
+15 -34 1 file

OpenBSD — usr.sbin/smtpd smtpd.conf.5

tweak previous;
Delta File
+3 -5 usr.sbin/smtpd/smtpd.conf.5
+3 -5 1 file